Commit Graph

1970 Commits (fix/269-invalid-ctext-loop)
 

Author SHA1 Message Date
Manos Pitsidianakis b603524bc3 melib/nntp: log error when command length exceeds 512 octets
According to RFC 3977:

> Command lines MUST NOT exceed 512 octets, which includes the
> terminating CRLF pair

This commit adds a log::error entry when any sent command exceeds that
limit and recommends the user to report this as a bug.
10 months ago
Manos Pitsidianakis c8abb15d78 melib/nntp: limit LIST ACTIVE command length to 512 octets
According to RFC 3977:

> Command lines MUST NOT exceed 512 octets, which includes the
> terminating CRLF pair

Sending a `LIST ACTIVE` command with lots of newgroups and passing the
512 byte limit is therefore invalid. This commit splits the mailboxes in
chunks and sends a separate command for each maximal chunk that has
a valid length.

Fixes #269.

Reported-by: r3k2
10 months ago
Manos Pitsidianakis 2a079ee175 melib/nntp: accept invalid (non-ascii) address comment text
NNTP servers may return addresses that are not RFC 5322 compliant. An
address with a comment with non-ascii characters will make the parser loop indefinitely.

Fixes #269.
10 months ago
Manos Pitsidianakis 0ee1b6e018
account: start background watch job in init
When IsOnline was introduced, the background watch job stopped being
created when the connection was initialized. Restore that behavior.
10 months ago
Manos Pitsidianakis 8cb2a515e1
melib/smtp: use localhost in lieu of 127.0.0.1 for CI 10 months ago
Manos Pitsidianakis 6e27edcb77
ci: use cargo-nextest 10 months ago
Manos Pitsidianakis ae25ffba43
melib/smtp: don't do plain EHLO before starting Tls connection 10 months ago
Manos Pitsidianakis 1e084c1d85
melib: move backends out of the backends module
No reason to have such a deep module tree.
10 months ago
Manos Pitsidianakis 9216e7bc65
melib/connections: add opt id string for tracing 10 months ago
Manos Pitsidianakis 8ecdb6df31
melib/imap: add imap-trace feature 10 months ago
Manos Pitsidianakis b65934facc
melib/nntp: add nntp-trace feature 10 months ago
Manos Pitsidianakis 89c90f224a
melib: add `nntp` feature 10 months ago
Manos Pitsidianakis 7db930cabd
melib: rename `jmap_backend` feature to `jmap` 10 months ago
Manos Pitsidianakis e9f09a153c
melib: rename `mbox_backend` feature to `mbox` 10 months ago
Manos Pitsidianakis fe7dcc508e
melib: rename `notmuch_backend` feature to `notmuch` 10 months ago
Manos Pitsidianakis fe027fa300
melib: rename `maildir_backend` feature to `maildir` 10 months ago
Manos Pitsidianakis 129f10911b
melib: rename `imap_backend` feature to `imap` 10 months ago
Manos Pitsidianakis 51e9fbe8f2
sqlite3: add account_name identifier to sqlite3 index database name 10 months ago
Manos Pitsidianakis 4874e30f3c
melib: add smtp-trace feature
If it's enabled, every read/write in an SMTP transaction will be logged
on TRACE level.
10 months ago
Manos Pitsidianakis 073d43b9b8
melib/test: move data files to data subdir 10 months ago
Manos Pitsidianakis 8e698cabcf
Fix unreachable-pub and disjoint-capture lint errors 10 months ago
Manos Pitsidianakis 1d0405ed5b
ci: add env vars 10 months ago
Manos Pitsidianakis bb7e119ade
Add gitea CI workflows 10 months ago
Manos Pitsidianakis 29b43e2c88
melib/datetime: replace mktime with timegm 10 months ago
Manos Pitsidianakis 2df7354751
mail/{listing,view}: fix overflow substracts 10 months ago
Manos Pitsidianakis 6280bc75e5
melib/jmap: fix blob download URL formatting 10 months ago
Manos Pitsidianakis 48a10f7241
melib: remove unused BackendOp::fetch_flags() method 10 months ago
Manos Pitsidianakis 0219dc8707
melib/jmap: respect max_objects_in_get when fetching email
Fixes #144
10 months ago
Manos Pitsidianakis c4c245ee19
melib/jmap: respect danger_accept_invalid_certs setting 10 months ago
Manos Pitsidianakis 53cba4beee
Update README.md relative file paths 10 months ago
Manos Pitsidianakis 561ba9c87b
listing: add relative_list_indices setting for thread listing 10 months ago
Manos Pitsidianakis 8abc9358a7
mail/pgp: add newline after Version: 1 header 10 months ago
Manos Pitsidianakis e9cd800f49
melib/nntp: add support for storing read status locally 10 months ago
Manos Pitsidianakis 519257b08f
listing: add relative_menu_indices setting for menubar 10 months ago
Manos Pitsidianakis ab418c1d39
pgp: refresh documentation, fix encryption/signing
Closes #259
10 months ago
Manos Pitsidianakis cf9a04a591
Add metadata to Jobs, and add JobManager tab
Opened with command `manage-jobs`
10 months ago
Manos Pitsidianakis 369c1dbdac
view/html: show `open` command in status bar 10 months ago
Manos Pitsidianakis 4e55fbc90d
nntp: add SEEN flag to all envs, since NNTP has no flags 10 months ago
Manos Pitsidianakis 5ceddf412e
Update CHANGELOG.md 10 months ago
Manos Pitsidianakis 13fe64a027
Cache pgp signature verification results 10 months ago
Manos Pitsidianakis 6086a3789d
Fix libgpgme segfault error and re-enable gpg
Closes #255
10 months ago
Manos Pitsidianakis 5b5869a2ec
logging: re-enable print to stderr ifdef MELI_DEBUG_STDERR 10 months ago
Manos Pitsidianakis 866166eb8e
attachments: don't print parsing error for empty bytes 10 months ago
Manos Pitsidianakis d4e605c098
Add tagref source code annotations
Source Code Annotation Tags:

Global tags (in tagref format <https://github.com/stepchowfun/tagref>)
for source code annotation:

- [tag:hardcoded_color_value] Replace hardcoded color values with user
   configurable ones.
- [tag:needs_unit_test]
- [tag:needs_user_doc]
- [tag:needs_dev_doc]
- [tag:FIXME]
- [tag:TODO]
- [tag:VERIFY] Verify whether this is the correct way to do something
- [tag:DEBT] Technical debt
10 months ago
Manos Pitsidianakis a5770c89f4
Add Woodpecker-CI check pipeline 10 months ago
Manos Pitsidianakis 74e15316db
view/envelope: open message/rfc822 attachments in subview instead of new tab 10 months ago
Manos Pitsidianakis d93ee413a7
melib/datetime: add timestamp_to_string_utc
Tests were using `timestamp_to_string` which in turn uses `localtime_r`
which assumes the local machine's time zone. Use gmtime_r instead.

Fixes #252
10 months ago
Manos Pitsidianakis c2ed3e283f
view/envelope: fix Source::* view showing only envelope body
Instead of the entire envelope source
11 months ago
Manos Pitsidianakis b0e867eb68
Move src to meli/src 11 months ago
Manos Pitsidianakis b5657201db
melib: fix doctest compilation errors 11 months ago