Commit Graph

4591 Commits

Author SHA1 Message Date
Jeff Becker
977ea3d689
* add log warn
* throw if inbound link makes outbound session
2021-07-05 09:09:20 -04:00
Jeff Becker
99379c5def
establish outbound sessions when we have no outbound session.
when we have an inbound session we still want to make an outbound session.
2021-07-05 09:09:20 -04:00
Jeff Becker
cf0349c259
if we have an inbound session don't fail with NoLink 2021-07-05 09:09:19 -04:00
Jeff Becker
f4fa83703f
refactor to use RouterID instead of rc.pubkey 2021-06-30 06:45:11 -04:00
Thomas Winget
8515fe09d4 fix minor oversight/inefficiency with already established connections 2021-06-29 18:44:42 -04:00
Jeff Becker
abd6e4c558
use weak_ptr instead of bare pointer to prevent use after free 2021-06-25 05:08:31 -04:00
Jeff Becker
aa48a1de1b
lower log level 2021-06-23 07:30:30 -04:00
Jeff Becker
3ad59105ef
when an outbound context is "marked bad" we want to ignore any new paths.
before this commit when a new path was made when an outbound context marked bad lokinet would segfault.
2021-06-23 07:21:01 -04:00
Jeff Becker
9d0dffe086
only permit 1 pending session per udp endpoint 2021-06-22 09:26:03 -04:00
Jeff Becker
67f8a7116f
if we get a discard message from the pivot discard the outbound context if the remote intro is also expired 2021-06-21 16:02:03 -04:00
Jeff Becker
0900ab88d1
publish introsets on nearest routers
fetch introset from random routers
2021-06-21 16:01:38 -04:00
Jeff Becker
872a8d8045
use exisitng convotag first instead of trying to send to directly 2021-06-21 15:16:28 -04:00
Jeff Becker
ee5723ecdc
add upperbound to number of endpoints used in lns lookups 2021-06-21 15:16:28 -04:00
Jeff Becker
3393b5a5a7
make it so lookups dont time out 2021-06-21 15:16:27 -04:00
Jeff Becker
b5efb8c604
rename local variable to be clear about meaning, add comment 2021-06-21 15:16:27 -04:00
Jeff Becker
1a0e6a7ac1
remove redundant check as ReadyToSend also checks IntroSent() 2021-06-21 15:16:27 -04:00
Jeff Becker
d45f0f8951
value initialize introduction so that expiresAt defaults to zero 2021-06-21 15:16:27 -04:00
Jeff Becker
9f353238af
ReadyToSend also should include checking we have a path to the remote 2021-06-21 15:16:27 -04:00
Jeff Becker
4b11858bb0
make clang compile, remove unused variable 2021-06-21 15:16:27 -04:00
Jeff Becker
963250c0ef
format 2021-06-21 15:16:27 -04:00
Jeff Becker
00d4942d85
more 2021-06-21 15:16:26 -04:00
Thomas Winget
7f9a60066b
make sure we have a path to the next introduction we want to use 2021-06-21 15:16:26 -04:00
Jeff Becker
d9cae4a6c6
in outbound context, ShouldBuildMore intro.ExpiresSoon delta is too big and has no overlap, change it so that 2021-06-21 15:16:26 -04:00
Jeff Becker
e48feb8b9a
kill outbound context when we remove our convotag 2021-06-21 15:16:26 -04:00
Jeff Becker
71d17dc2c9
format and logging
ignore outbound session auth messages
2021-06-21 15:16:26 -04:00
Jeff Becker
5c3b4090d2
dont mark inbound sessions as outbound when we get a DNS lookup for it 2021-06-21 15:16:26 -04:00
Jeff Becker
b70ecade2b
correct the logic for inbound convos
send back traffic on the correct path
2021-06-21 15:16:25 -04:00
Jeff Becker
a0505d8e85
mitigate lto compiler bug with lto 2021-06-20 06:06:29 -04:00
Jeff Becker
db5862cda8
only use @ syntax when the dns port is not port 53 2021-06-20 05:59:23 -04:00
Jeff Becker
a6fbaa7c7a
add dns hosts file option for user side dns filtering 2021-06-20 05:59:22 -04:00
Jeff Becker
a24b82119b
fix #1655
* make it so that we don't set up unbound resolver when we have no resolvers provided by config
* clean up dns codepath and make it use llarp::SockAddr instead of llarp::IpAddress
2021-06-20 05:59:22 -04:00
Jeff Becker
5c512601bf
use std::make_optional for backwards compat on older toolchains 2021-06-19 09:39:10 -04:00
Jeff
c9b4ca85b2
[feature] optionally keep inbound convos mapped to same IP on restart (#1672)
* add option to persist address mappings between restarts using [network]:persist-addrmap-file

* make it work

* only persist address map for inbound convos

* turn persisting address map on by default

* dont load addrmap file if it has been modified last over a minute ago to prevent foot cannons fired from loading a really old version of it
2021-06-17 12:05:50 -04:00
Jeff Becker
afe55f0932
fix for testing:
dont remove from failing set
2021-06-10 14:17:31 -04:00
Jeff Becker
5cdb1afa0d
increase timer timeout interval because 1 seconds RTT can happen but 2 seconds is pretty bad 2021-06-09 20:15:22 -04:00
Jeff Becker
fab086db0c
downgrade log level 2021-06-09 20:15:06 -04:00
Jeff Becker
3142bab0ac
move setting hop to nullptr to after delivery or delivery fail 2021-06-09 09:51:46 -04:00
Jeff Becker
ce7643a3aa
remove case that spams build on an outbound context 2021-06-09 09:36:08 -04:00
Jeff Becker
9a51e4d9b5
forgot to pump on wakeup 2021-06-09 08:45:52 -04:00
Jeff Becker
486cdc0949
correctly do latency test FEC
before this it would cause a posative feedback loop causing paths to fail for "no real reason"
2021-06-09 08:32:51 -04:00
Jeff Becker
c97fe4aa96
convert magic number to where it came from 2021-06-08 18:07:54 -04:00
Jeff Becker
a0b8fe144a
convert to lambda 2021-06-08 18:06:19 -04:00
Jeff Becker
3594d3e211
spelling fix 2021-06-08 17:54:40 -04:00
Jeff Becker
f9e0c8f50c
add idempotent wakeup for flushing instead of the dumb queue checking 2021-06-08 17:38:04 -04:00
Jeff Becker
e2bdf8792b
typofix 2021-06-08 17:27:50 -04:00
Jeff Becker
7dc1061461
mark ip active on successful send 2021-06-08 14:52:16 -04:00
Jeff Becker
adc6237d1c
mark exit address outbound when we add it via rpc 2021-06-08 14:36:34 -04:00
Jeff Becker
1da0a007ff
close links and remove commit 2021-06-08 14:36:34 -04:00
Jeff Becker
719dd38cf5
more shit 2021-06-08 14:36:33 -04:00
Jeff Becker
7a5dcc3eab
correctly persist link sessions 2021-06-08 14:36:33 -04:00
Jeff Becker
046e02ebe7
fixes for loopback testnet 2021-06-08 14:36:33 -04:00
Jeff Becker
5a713b0142
tweak timeouts to be a bit more sane 2021-06-08 14:36:33 -04:00
Jeff Becker
ea3276333a
on path timeout look up each router, if the lookup fails then we remove it from nodedb and close any connections to it so that bad first hops are rotated off of. 2021-06-08 14:36:33 -04:00
Jeff Becker
07e29da5c0
when we map an address forever mark it as outbound 2021-06-08 14:36:33 -04:00
Jeff Becker
c2722be81c
this fixes the shit wtf 2021-06-08 14:36:33 -04:00
Jeff Becker
5909ad0386
add MarkAddressOutbound to plainquic 2021-06-08 14:36:33 -04:00
Jeff Becker
cce15b13c8
dont establish paths to inbound sessions to try and address state race condition 2021-06-08 14:36:33 -04:00
Jeff Becker
aefab797d7
unconditional putsenderfor 2021-06-08 14:36:33 -04:00
Jeff Becker
6a3dc67e9b
nuke from orbit style router profiling for path build timeouts.
* when a path build times out, shitlist every router in the path except the first hop, this way eventually we get the nodedb pruned to only the routers that are currently actually alive, any ones we nuke that we need later we can always do lookups for.
2021-06-08 14:36:33 -04:00
Jeff Becker
1f9b8e5972
nuke invalid routers when we get a path build fail back to not resuse them in the future 2021-06-08 14:36:32 -04:00
Jeff Becker
aa1c1bad0b
record reason for path fail and the full hops 2021-06-08 14:36:32 -04:00
Jeff Becker
0096bd4e35
account for path latency in introset lookups on outbound contexts 2021-06-08 14:36:32 -04:00
Jeff Becker
e4ed53224c
use weak_ptr on a path to reference its parent pathset instead of a bare pointer so crashes dont happen 2021-06-08 14:36:32 -04:00
Jeff Becker
2a76a3d081
treat ignored paths like established paths when dealing with expiration 2021-06-08 14:36:32 -04:00
Jeff Becker
23aa35b825
log when we ignore a path 2021-06-08 14:36:32 -04:00
Jeff Becker
c6660dd6c1
add path aligntment timeout to send and connect timeouts on outbound context to reduce the chance of timing race conditon 2021-06-08 14:36:32 -04:00
Jeff Becker
a8964a6d8a
add idempotent wake up for sending messages to the network and writing packets on interfaces 2021-06-08 14:36:32 -04:00
Jeff Becker
108b8e089e
HandleTimeout can touch iterators so do all handling of lookup timeouts outside of loop iteration 2021-06-08 14:36:32 -04:00
Jeff Becker
0f1e806155
don't kill outbound context after build or lookup fails 2021-06-08 14:36:32 -04:00
Jeff Becker
1aa2146b4a
for inbound sessions, keep them alive for the default session lifetime, for outbound sessions keep alive for 5 ping intervals 2021-06-08 14:36:31 -04:00
Jeff Becker
60cc47447f
increase default session lifetime to 5 minutes for mobile client related reasons
make the default inbound session lifetime be default session lifetime + 2 ping intervals
2021-06-08 14:36:31 -04:00
Jeff Becker
a7b20b79c5
add relay order to error message 2021-06-08 14:36:31 -04:00
Jeff Becker
a86152e03c
decay path build limiter per path builder every tick 2021-06-08 14:36:31 -04:00
Jeff Becker
34e31ba04f
only inform failure or success of introset lookups when all lookups have returned 2021-06-08 14:36:31 -04:00
Jeff Becker
220b8837da
delay setting sentIntro by the advertised latency of the remote intro instead of static value 2021-06-08 14:36:31 -04:00
Jeff Becker
c5a86a49a3
defer ready to send state until after we send a handshake 2021-06-08 14:36:31 -04:00
Jeff Becker
40a189a9a3
log drop events more 2021-06-08 14:36:31 -04:00
Jeff Becker
00257567c2
dont call null handler
if we have no path to the remote router that's fine still use it just in case we have no other convotags
2021-06-08 14:36:31 -04:00
Jeff Becker
85cd1b6863
use inbound sessions we don't have paths to in GetBestConvoTagFor just so we can give the caller SOMETHING. 2021-06-08 14:36:31 -04:00
Jeff Becker
b03d17bc8e
dont change send timeout for exits from tun handler as that screws with consistency in testing.
improve log messages, provide more info
2021-06-08 14:36:30 -04:00
Jeff Becker
a94c100e7b
improve log messages about expiring convotags 2021-06-08 14:36:30 -04:00
Jeff Becker
42d75b934d
remove service nodes we can't look up from the nodedb as client 2021-06-08 14:36:30 -04:00
Jeff Becker
8dd1358cc6
* tweak introset handover timeouts
* introset path haodver tweaks
* improve warn/error messages to convey more information
* dont block on queue insertion
* reset convotag on decrypt/verify fail
* add multiple ready hooks on outbound context
* lookup introsets from close routers on dht
* continue to tick dead sessions so they expire their paths
* introset spacing
* reduce lns lookup diversity requirement for speed
* add a function to send reset convotag message
* only have 1 outbound context at a time
2021-06-08 14:36:30 -04:00
Jeff Becker
9a1a022d62
add relayOrder awareness to introset lookups.
* only propgate fail when relay order is non zero as zero relay order often fails
2021-06-08 14:36:30 -04:00
Jeff Becker
5074dd5f2b
re-enable multithreading on clients but not on service nodes 2021-06-08 14:36:30 -04:00
Jeff Becker
d7a51e88f5
make router tick 250ms instead of 100ms to prevent excessive log spam
limit calls to decommissioned warning to every 30s to prevent excessive log spam
2021-06-08 14:36:30 -04:00
Jeff Becker
66f6103832
far stricter profiling algorithm
* include first hop in profiling
* decay stats faster
* make fail case for path build profiling far more sensative
2021-06-08 14:36:30 -04:00
Jeff Becker
23a82c493f
* don't include failed at when we are the pivot router as that case never happens.
* mark paths as ingored instead of expired when we stop a path builder
* only remove path builder when we have no established paths
2021-06-08 14:36:30 -04:00
Jeff Becker
503db46eca
path and intro selection fixups:
* include stricter router profiling checks in path::Builder hop slection algorithm
* make intro selection function nicer by returning a std::optional instead of a bool with an "out" variable
2021-06-08 14:36:30 -04:00
Jeff Becker
174e1b247b
fix latency tests.
* do FEC for latency tests so if we fail one test it doesn't kill the entire path
* ignore FEC'd responses on latency tests
* track latency history and report the mean latency instead of just the last sample
2021-06-08 14:36:30 -04:00
Jeff Becker
691390edff
make log warning have a more accurate message when we have no path for a relay downstream message 2021-06-08 14:36:29 -04:00
Jeff Becker
97df84994e
make packet sending logic not attempt to align back to inbound sessions. 2021-06-08 14:36:29 -04:00
Jeff Becker
4994208fbc
don't cache dns result if we have an address mapped.
we want to use dns to trigger a call to EnsurePathTo
2021-06-08 14:36:29 -04:00
Jeff Becker
5e761235d6
improve log message clairity by printing the address not hex 2021-06-08 14:36:29 -04:00
Jeff Becker
4199f2f52b
fix an assert fail in gcc 11. 2021-06-08 14:36:29 -04:00
Jeff Becker
5849176f04
reduce path intro spread slices from 5 to 4.
parameterize path intro spread slices.
2021-06-08 14:36:29 -04:00
Jeff Becker
08d62e32c0
reduce path build timeout from 30s to 10s
this should help make path timeouts less insufferable.
2021-06-08 14:36:29 -04:00
Jeff Becker
9bb3711ca4
increase link layer buffer size
allows for higher amounts of traffic on the network to be pushed.
2021-06-08 14:36:29 -04:00
Jeff Becker
b1d30f9803
updates to lokinetmon
* add introset inspector mode
* add required parts for introset insecptor mode to rpc introspection
2021-06-08 14:36:29 -04:00
Jeff
8da05d08cc
Merge pull request #1660 from majestrate/win32-cmake-fixes-2021-06-04
windows cmake upgrades
2021-06-08 14:12:41 -04:00
Jeff Becker
f3deabdb96
* get_failing does not need abstract router as paramter so we remove it
* add remove_node_from_failing to remove a node by pubkey from the failing set
* if a router is deregistered we remove it from the failing set so we don't retest it
* remove a router from the failing set if we get a test success
2021-06-08 10:47:27 -04:00
Jeff Becker
046ab3d453
export functions in liblokinet for win32 dll 2021-06-08 08:32:52 -04:00
Jeff Becker
d88ed4eee0
make windows happy by making some constexprs non static and such as windows does not LTO 2021-06-08 05:46:05 -04:00
Thomas Winget
d68d39a450 make outbound session if we do not have
currently creating an outbound session will cancel if we have any session
at all with the relay.  instead, only cancel if we have an outbound session
to that relay.  this is useful for reachability testing.
2021-06-07 18:31:57 -04:00
Jeff Becker
37ab78b654
dont run router testing if we are decommissioned.
properly name function to be called LooksDecommissioned because that is different than deregistered
2021-06-07 16:35:06 -04:00
Jeff Becker
07d18b30c0
typofix 2021-06-07 16:18:52 -04:00
Jason Rhinelander
0fa39c89dc
Make format 2021-06-07 16:16:18 -04:00
Jason Rhinelander
7f41c6092c
Fix failing pks not being populated 2021-06-07 16:16:18 -04:00
Jason Rhinelander
40ad286bf4
Don't pass last hash into UpdateServiceNodeList
It's there for polling, which we aren't doing anymore; we just got the
hash from oxend's push notification, so if it pass it in then we will
always get an "unchanged" result because we're telling oxend that we
already have the data for that hash updated.

This just drops the hash completely because we don't need it anymore.
2021-06-07 16:16:18 -04:00
Jason Rhinelander
cd6962f538
Avoid copying & keep router alive by moving shared_ptr 2021-06-07 16:16:18 -04:00
Jason Rhinelander
7c964800ba
Fix unintentional whitelist/greylist copying 2021-06-07 16:16:18 -04:00
Jason Rhinelander
4974ce6f98
Add warning when can't update whitelist 2021-06-07 16:16:18 -04:00
Jeff Becker
ef924aea39
gossip RC when we are not deregistered so we can come back when we are decommissioned 2021-06-07 16:15:17 -04:00
Jeff Becker
95537804cd
separate white/grey list for active/decommissioned nodes.
allow sessions to decommissioned nodes but not paths.
2021-06-07 10:57:33 -04:00
Jason Rhinelander
28ba0b7533
Add logging about testing success/fail 2021-06-07 10:00:36 -04:00
Jason Rhinelander
4630c5673a
Fix use after move 2021-06-07 10:00:36 -04:00
Jeff Becker
d40484deea
handle case where we already have an outbound session, inform caller about it 2021-06-07 10:00:02 -04:00
Jeff Becker
c23e121139
capture by value to appease clang 11 2021-06-07 08:44:47 -04:00
Jason Rhinelander
e332bbe3f3
Switch stl mt19937_64 to CSRNG 2021-06-07 08:41:35 -04:00
Jeff Becker
e8af36ee91
there were some unhandled edge cases in outbound_session_maker, specifically when we are not permitted to connect to a remoute but we got its rc we silently drop the error. 2021-06-07 08:41:35 -04:00
Jeff Becker
9ad90d029d
* use weak_ptr on core rpc
* use reachability testing code lifted storage server's code
2021-06-07 08:41:35 -04:00
Jeff Becker
b830eeb535
initial lokinet router testing:
* report via rpc to oxen core connection stats on success and failure
* connect to random service node by pubkey every 5 seconds for testing
2021-06-04 16:52:41 -04:00
Jeff Becker
f172db75c5
don't defer call to ready hook with timer call it right away because we are ready 2021-05-16 19:31:59 -04:00
Jeff Becker
432e7f2a5a
update introset if we get a discard message from a possibly expired intro 2021-05-16 16:27:48 -04:00
Jeff Becker
970ccfcd4e
send a keep alive to keep an idle session alive so it doesn't get removed 2021-05-16 05:59:39 -04:00
Jeff Becker
7c6bb9a24c
simplify loop and correct logic, we want to bail out of the loop on first match. 2021-05-15 15:27:28 -04:00
Jeff Becker
ae97b87111
exits don't rewrite ip addresses, fix this and add note 2021-05-15 15:27:28 -04:00
Jeff Becker
f1efcc29ea
mark inbound traffic as convotag active 2021-05-15 15:27:28 -04:00
Jeff
bd9db35975
Merge pull request #1643 from majestrate/win32-rpc-fixups-2021-05-13
win32 fixups
2021-05-13 14:42:19 -04:00
Jeff Becker
499bb38e6f
fix route poking via rpc:
* immediately poke routes when we are told to use an exit so that packets get pushed which makes an exit path happen
* fix up cmake oddity in nsis section
2021-05-13 07:30:53 -04:00
Jeff Becker
209bcc39dd
make liblokinet target work on nsis cpack 2021-05-13 06:40:17 -04:00
Jeff Becker
8c0f448e12
add liblokinet option to nsis cpack installer 2021-05-13 06:30:40 -04:00
Jeff Becker
2458b5fd71
rpc server fixups for win32:
* RoutePoker::Enable calls RoutePoker::Up so remove additional call to RoutePoker::Up
* allow specifying null exit via rpc
2021-05-13 06:09:52 -04:00
Jeff Becker
3c2334112c
when we stop a path builder we want to expire all of their paths so they go away 2021-05-12 12:48:24 -04:00
Jeff Becker
51b7566a46
if we look deregistered we will now:
* not gossip our rc
* not explore the network to prevent outbound session attempts
* not establish sessions to other service nodes
* close all open sessions we have to tell clients we don't want them
* catch exceptions flushing peerdb in disk thread
* don't connect out to non allowed routers
* simplify logic in RCLookupHandler::RemoteIsAllowed()
* add HaveReceivedWhitelist to I_RCLookupHandler base type
* add LooksDeregistered to Router type that tells us if we think we are deregistered
* don't allow building paths over us if we are deregistered
2021-05-12 07:17:40 -04:00
Jeff Becker
c5350ab2c4
DefaultPathAlignmentTimeout -> PathAlignmentTimeout 2021-05-11 05:12:27 -04:00
Jeff Becker
c834414b47
when we have to reestablish an outbound session use a much much higher timeout for restablishment
so it doesn't time out and get into a state that's totally screwed.

add virtual function service::Endpont::DefaultPathAlignmentTimeout() to get the timeout for path alignment
and use it for resetablishing outbound sessions
2021-05-11 05:12:27 -04:00
Jeff Becker
38cc130dc3
shift off bad intros when we get a discard message, this happens if the
other side's intro expires or the pivot restarts for whatever reason.
2021-05-10 09:01:46 -04:00
Jeff Becker
3c22e01d7c
in the event that a session is removed and then gets more traffic we would re-add the session with everything blank if there was more traffic in the same tick.
this remedies this behavior by only increment usage timestamps on sessions if they exist.
2021-05-09 08:00:31 -04:00
Jeff Becker
6bb31468d7
don't send nx if we have an address already mapped 2021-05-06 16:34:37 -04:00
Jeff Becker
d3d929efa7
fixups in service endpoint
* increase publish introset timeout so that it does not time out on the network
* remove pedantic log warn
* make sure the path we are using for replying on inbound sessions is alive
* include convotag in log message so we know wtf is going on
* appease tom's autism, improve log message text
2021-05-06 16:34:24 -04:00
Jeff
d53945b011
Merge pull request #1621 from majestrate/path-ptr-leak-2021-05-02
try fixing std::shared_ptr leak with paths
2021-05-06 16:15:27 -04:00
Jeff
34eb254959
Merge pull request #1626 from majestrate/edge-limiter-2021-05-05
limit path builds across all builders
2021-05-06 16:14:59 -04:00
Jeff
ea4529af92
Merge pull request #1628 from majestrate/unfug-network-path-builds-2021-05-05
always do path tests
2021-05-05 19:25:20 -04:00
Jeff
2bb5a7ccea
Merge pull request #1622 from majestrate/stricter-profiling-2021-05-03
stricter profiling
2021-05-05 18:27:29 -04:00
Jeff Becker
b1afe0f596
always do path tests
this reverts some stupid bullshit that broke 0.9.0
2021-05-05 18:24:15 -04:00
Jeff Becker
ec62228149
limit path builds across all builders 2021-05-05 08:21:39 -04:00
Jeff Becker
955071ba5c
make profiling far stricter for path builds 2021-05-04 17:01:29 -04:00
Jeff Becker
e916c9610c
format 2021-05-03 19:42:13 -04:00
Jeff Becker
554a44c8bf
report block height reported by oxend in systemd status 2021-05-03 16:53:00 -04:00