Fix unintentional whitelist/greylist copying

3 years ago · 7c964800ba
parent 4974ce6f98
commit 7c964800ba
3 changed files with 3 additions and 3 deletions
--- a/llarp/router/abstractrouter.hpp
+++ b/llarp/router/abstractrouter.hpp
@ -285,7 +285,7 @@ namespace llarp
    /// set router's service node whitelist
    virtual void
    SetRouterWhitelist(
-        const std::vector<RouterID> whitelist, const std::vector<RouterID> greylist) = 0;
+        const std::vector<RouterID>& whitelist, const std::vector<RouterID>& greylist) = 0;

    virtual std::unordered_set<RouterID>
    GetRouterWhitelist() const = 0;
--- a/llarp/router/router.cpp
+++ b/llarp/router/router.cpp
@ -1043,7 +1043,7 @@ namespace llarp

  void
  Router::SetRouterWhitelist(
-      const std::vector<RouterID> whitelist, const std::vector<RouterID> greylist)
+      const std::vector<RouterID>& whitelist, const std::vector<RouterID>& greylist)
  {
    _rcLookupHandler.SetRouterWhitelist(whitelist, greylist);
  }
--- a/llarp/router/router.hpp
+++ b/llarp/router/router.hpp
@ -132,7 +132,7 @@ namespace llarp

    void
    SetRouterWhitelist(
-        const std::vector<RouterID> whitelist, const std::vector<RouterID> greylist) override;
+        const std::vector<RouterID>& whitelist, const std::vector<RouterID>& greylist) override;

    std::unordered_set<RouterID>
    GetRouterWhitelist() const override