Merge pull request #638 from michael-loki/mem_fn

Create util::MemFn and memFn to make binding callbacks easier

llarp/CMakeLists.txt

@@ -17,13 +17,15 @@ set(LIB_UTIL_SRC
   util/logger.cpp
   util/android_logger.cpp
   util/file_logger.cpp
-  util/ostream_logger.cpp
-  util/syslog_logger.cpp
-  util/win32_logger.cpp
   util/logic.cpp
   util/mem.cpp
+  util/memfn_traits.cpp
+  util/memfn.cpp
   util/metrics_core.cpp
   util/metrics_types.cpp
+  util/ostream_logger.cpp
+  util/syslog_logger.cpp
+  util/win32_logger.cpp
   util/metrics.cpp
   util/object.cpp
   util/printer.cpp

llarp/context.cpp

@@ -12,6 +12,7 @@
 #include <nodedb.hpp>
 #include <router/router.hpp>
 #include <util/logger.h>
+#include <util/memfn.hpp>
 #include <util/metrics.hpp>
 #include <util/scheduler.hpp>
 
@@ -50,8 +51,7 @@ namespace llarp
       llarp::LogError("failed to load config file ", configfile);
       return false;
     }
-    using namespace std::placeholders;
+    config->visit(util::memFn(&Context::iter_config, this));
-    config->visit(std::bind(&Context::iter_config, this, _1, _2, _3));
 
     if(!disableMetrics)
     {

llarp/exit/session.cpp

@@ -4,6 +4,7 @@
 #include <nodedb.hpp>
 #include <path/path.hpp>
 #include <router/abstractrouter.hpp>
+#include <util/memfn.hpp>
 
 namespace llarp
 {
@@ -97,19 +98,11 @@ namespace llarp
     BaseSession::HandlePathBuilt(llarp::path::Path_ptr p)
     {
       path::Builder::HandlePathBuilt(p);
-      p->SetDropHandler(std::bind(&BaseSession::HandleTrafficDrop, this,
+      p->SetDropHandler(util::memFn(&BaseSession::HandleTrafficDrop, this));
-                                  std::placeholders::_1, std::placeholders::_2,
+      p->SetDeadChecker(util::memFn(&BaseSession::CheckPathDead, this));
-                                  std::placeholders::_3));
+      p->SetExitTrafficHandler(util::memFn(&BaseSession::HandleTraffic, this));
-      p->SetDeadChecker(std::bind(&BaseSession::CheckPathDead, this,
+      p->AddObtainExitHandler(util::memFn(&BaseSession::HandleGotExit, this));
-                                  std::placeholders::_1,
-                                  std::placeholders::_2));
-      p->SetExitTrafficHandler(
-          std::bind(&BaseSession::HandleTraffic, this, std::placeholders::_1,
-                    std::placeholders::_2, std::placeholders::_3));
 
-      p->AddObtainExitHandler(std::bind(&BaseSession::HandleGotExit, this,
-                                        std::placeholders::_1,
-                                        std::placeholders::_2));
       routing::ObtainExitMessage obtain;
       obtain.S = p->NextSeqNo();
       obtain.T = llarp::randint();

llarp/handlers/tun.cpp

@@ -13,6 +13,7 @@
 #include <router/abstractrouter.hpp>
 #include <service/context.hpp>
 #include <util/logic.hpp>
+#include <util/memfn.hpp>
 #include <nodedb.hpp>
 
 #include <util/str.hpp>
@@ -150,9 +151,8 @@ namespace llarp
         }
         m_Exit = std::make_shared< llarp::exit::ExitSession >(
             exitRouter,
-            std::bind(&TunEndpoint::QueueInboundPacketForExit, this,
+            util::memFn(&TunEndpoint::QueueInboundPacketForExit, this), router,
-                      std::placeholders::_1),
+            m_NumPaths, numHops, ShouldBundleRC());
-            router, m_NumPaths, numHops, ShouldBundleRC());
         llarp::LogInfo(Name(), " using exit at ", exitRouter);
       }
       if(k == "local-dns")

llarp/iwp/iwp.cpp

@@ -1,6 +1,7 @@
 #include <iwp/iwp.hpp>
 #include <iwp/linklayer.hpp>
 #include <router/abstractrouter.hpp>
+#include <util/memfn.hpp>
 
 namespace llarp
 {
@@ -9,15 +10,14 @@ namespace llarp
     std::unique_ptr< ILinkLayer >
     NewServerFromRouter(AbstractRouter* r)
     {
-      using namespace std::placeholders;
       return NewServer(
           r->encryption(), std::bind(&AbstractRouter::rc, r),
-          std::bind(&AbstractRouter::HandleRecvLinkMessageBuffer, r, _1, _2),
+          util::memFn(&AbstractRouter::HandleRecvLinkMessageBuffer, r),
-          std::bind(&AbstractRouter::OnSessionEstablished, r, _1),
+          util::memFn(&AbstractRouter::OnSessionEstablished, r),
-          std::bind(&AbstractRouter::CheckRenegotiateValid, r, _1, _2),
+          util::memFn(&AbstractRouter::CheckRenegotiateValid, r),
-          std::bind(&AbstractRouter::Sign, r, _1, _2),
+          util::memFn(&AbstractRouter::Sign, r),
-          std::bind(&AbstractRouter::OnConnectTimeout, r, _1),
+          util::memFn(&AbstractRouter::OnConnectTimeout, r),
-          std::bind(&AbstractRouter::SessionClosed, r, _1));
+          util::memFn(&AbstractRouter::SessionClosed, r));
     }
 
     std::unique_ptr< ILinkLayer >

llarp/messages/relay_commit.cpp

@@ -8,6 +8,7 @@
 #include <util/buffer.hpp>
 #include <util/logger.hpp>
 #include <util/logic.hpp>
+#include <util/memfn.hpp>
 #include <nodedb.hpp>
 
 #include <functional>
@@ -161,9 +162,7 @@ namespace llarp
   bool
   LR_CommitRecord::BDecode(llarp_buffer_t* buf)
   {
-    using namespace std::placeholders;
+    return bencode_read_dict(util::memFn(&LR_CommitRecord::OnKey, this), buf);
-    return bencode_read_dict(std::bind(&LR_CommitRecord::OnKey, this, _1, _2),
-                             buf);
   }
 
   bool

llarp/router/router.cpp

@@ -14,6 +14,7 @@
 #include <util/buffer.hpp>
 #include <util/encode.hpp>
 #include <util/logger.hpp>
+#include <util/memfn.hpp>
 #include <util/file_logger.hpp>
 #include <util/logger_syslog.hpp>
 #include <util/metrics.hpp>
@@ -462,8 +463,7 @@ namespace llarp
   bool
   Router::Configure(Config *conf)
   {
-    using namespace std::placeholders;
+    conf->visit(util::memFn(&Router::router_iter_config, this));
-    conf->visit(std::bind(&Router::router_iter_config, this, _1, _2, _3));
     if(!InitOutboundLinks())
       return false;
     if(!Ready())
@@ -1147,9 +1147,10 @@ namespace llarp
   void
   Router::ServiceNodeLookupRouterWhenExpired(RouterID router)
   {
-    dht()->impl->LookupRouter(router,
+    using namespace std::placeholders;
-                              std::bind(&Router::HandleDHTLookupForExplore,
+    dht()->impl->LookupRouter(
-                                        this, router, std::placeholders::_1));
+        router,
+        std::bind(&Router::HandleDHTLookupForExplore, this, router, _1));
   }
 
   void
@@ -1926,9 +1927,7 @@ namespace llarp
     bool
     Validate()
     {
-      using namespace std::placeholders;
+      config->visit(util::memFn(&RouterConfigValidator::ValidateEntry, this));
-      config->visit(
-          std::bind(&RouterConfigValidator::ValidateEntry, this, _1, _2, _3));
       return valid;
     }
   };

llarp/rpc/rpc.cpp

@@ -7,6 +7,7 @@
 #include <exit/context.hpp>
 
 #include <util/encode.hpp>
+#include <util/memfn.hpp>
 #include <libabyss.hpp>
 
 namespace llarp
@@ -151,8 +152,7 @@ namespace llarp
       {
         LogInfo("Updating service node list");
         QueueRPC("get_all_service_nodes_keys", nlohmann::json::object(),
-                 std::bind(&CallerImpl::NewAsyncUpdatePubkeyListConn, this,
+                 util::memFn(&CallerImpl::NewAsyncUpdatePubkeyListConn, this));
-                           std::placeholders::_1));
       }
 
       bool
@@ -166,8 +166,7 @@ namespace llarp
       {
         return new GetServiceNodeListHandler(
             impl, this,
-            std::bind(&CallerImpl::HandleServiceNodeListUpdated, this,
+            util::memFn(&CallerImpl::HandleServiceNodeListUpdated, this));
-                      std::placeholders::_1, std::placeholders::_2));
       }
 
       void

llarp/service/async_key_exchange.cpp

@@ -3,6 +3,7 @@
 #include <crypto/crypto.hpp>
 #include <crypto/types.hpp>
 #include <util/logic.hpp>
+#include <util/memfn.hpp>
 
 namespace llarp
 {
@@ -50,9 +51,7 @@ namespace llarp
       // compure post handshake session key
       // PKE (A, B, N)
       SharedSecret sharedSecret;
-      using namespace std::placeholders;
+      path_dh_func dh_client = util::memFn(&Crypto::dh_client, crypto);
-      path_dh_func dh_client =
-          std::bind(&Crypto::dh_client, crypto, _1, _2, _3, _4);
       if(!self->m_LocalIdentity.KeyExchange(dh_client, sharedSecret,
                                             self->remote, self->frame.N))
       {

llarp/service/endpoint.cpp

@@ -17,6 +17,7 @@
 #include <util/logic.hpp>
 #include <util/str.hpp>
 #include <util/buffer.hpp>
+#include <util/memfn.hpp>
 #include <hook/shell.hpp>
 
 namespace llarp
@@ -795,11 +796,9 @@ namespace llarp
     void
     Endpoint::HandlePathBuilt(path::Path_ptr p)
     {
-      using namespace std::placeholders;
+      p->SetDataHandler(util::memFn(&Endpoint::HandleHiddenServiceFrame, this));
-      p->SetDataHandler(
+      p->SetDropHandler(util::memFn(&Endpoint::HandleDataDrop, this));
-          std::bind(&Endpoint::HandleHiddenServiceFrame, this, _1, _2));
+      p->SetDeadChecker(util::memFn(&Endpoint::CheckPathIsDead, this));
-      p->SetDropHandler(std::bind(&Endpoint::HandleDataDrop, this, _1, _2, _3));
-      p->SetDeadChecker(std::bind(&Endpoint::CheckPathIsDead, this, _1, _2));
       path::Builder::HandlePathBuilt(p);
     }
 
@@ -982,8 +981,7 @@ namespace llarp
 
       using namespace std::placeholders;
       HiddenServiceAddressLookup* job = new HiddenServiceAddressLookup(
-          this, std::bind(&Endpoint::OnLookup, this, _1, _2, _3), remote,
+          this, util::memFn(&Endpoint::OnLookup, this), remote, GenTXID());
-          GenTXID());
       LogInfo("doing lookup for ", remote, " via ", path->Endpoint());
       if(job->SendRequestViaPath(path, Router()))
       {

llarp/service/outbound_context.cpp

@@ -6,6 +6,7 @@
 #include <service/endpoint.hpp>
 #include <nodedb.hpp>
 #include <profiling.hpp>
+#include <util/memfn.hpp>
 
 namespace llarp
 {
@@ -127,12 +128,9 @@ namespace llarp
       /// don't use it if we are marked bad
       if(markedBad)
         return;
-      p->SetDataHandler(std::bind(&OutboundContext::HandleHiddenServiceFrame,
+      p->SetDataHandler(
-                                  this, std::placeholders::_1,
+          util::memFn(&OutboundContext::HandleHiddenServiceFrame, this));
-                                  std::placeholders::_2));
+      p->SetDropHandler(util::memFn(&OutboundContext::HandleDataDrop, this));
-      p->SetDropHandler(std::bind(&OutboundContext::HandleDataDrop, this,
-                                  std::placeholders::_1, std::placeholders::_2,
-                                  std::placeholders::_3));
       // we now have a path to the next intro, swap intros
       if(p->Endpoint() == m_NextIntro.router && remoteIntro != m_NextIntro)
         SwapIntros();
@@ -198,10 +196,7 @@ namespace llarp
       if(path)
       {
         HiddenServiceAddressLookup* job = new HiddenServiceAddressLookup(
-            m_Endpoint,
+            m_Endpoint, util::memFn(&OutboundContext::OnIntroSetUpdate, this),
-            std::bind(&OutboundContext::OnIntroSetUpdate, this,
-                      std::placeholders::_1, std::placeholders::_2,
-                      std::placeholders::_3),
             addr, m_Endpoint->GenTXID());
 
         updatingIntroSet = job->SendRequestViaPath(path, m_Endpoint->Router());

llarp/service/protocol.cpp

@@ -4,6 +4,7 @@
 #include <util/buffer.hpp>
 #include <util/logic.hpp>
 #include <util/mem.hpp>
+#include <util/memfn.hpp>
 
 namespace llarp
 {
@@ -315,9 +316,8 @@ namespace llarp
 
         // PKE (A, B, N)
         SharedSecret sharedSecret;
-        using namespace std::placeholders;
+        path_dh_func dh_server =
-        path_dh_func dh_server = std::bind(
+            util::memFn(&Crypto::dh_server, CryptoManager::instance());
-            &Crypto::dh_server, CryptoManager::instance(), _1, _2, _3, _4);
 
         if(!self->m_LocalIdentity.KeyExchange(dh_server, sharedSecret,
                                               self->msg->sender, self->frame.N))

llarp/util/memfn.cpp

@@ -0,0 +1 @@
+#include <util/memfn.hpp>

llarp/util/memfn.hpp

@@ -0,0 +1,91 @@
+#ifndef LLARP_UTIL_MEMFN
+#define LLARP_UTIL_MEMFN
+
+#include <util/memfn_traits.hpp>
+#include <util/object.hpp>
+#include <util/traits.hpp>
+
+#include <functional>
+#include <utility>
+
+namespace llarp
+{
+  namespace util
+  {
+    template < typename Obj >
+    struct MemFnDereference
+    {
+      // clang-format off
+      static inline Obj& derefImp(Obj& obj, std::false_type)
+      {
+        return obj;
+      }
+
+      template < typename Type >
+      static inline Obj& derefImp(Type& obj, std::true_type)
+      {
+        return *obj;
+      }
+
+      template < typename Type >
+      static inline Obj& derefImp(const Type& obj, std::true_type)
+      {
+        return *obj;
+      }
+
+      template < typename Type >
+      static inline Obj& deref(Type& obj)
+      {
+        return derefImp(obj, traits::is_pointy< Type >());
+      }
+
+      template < typename Type >
+      static inline Obj& deref(const Type& obj)
+      {
+        return derefImp(obj, traits::is_pointy< Type >());
+      }
+      // clang-format on
+    };
+
+    template < typename Prototype, typename Instance >
+    class MemFn
+    {
+      using traits = MemFnTraits< Prototype >;
+
+      static_assert(traits::IsMemFn, "");
+
+     public:
+      using result_type = typename traits::result_type;
+
+     private:
+      Prototype m_func;
+      object::Proxy< Instance > m_instance;
+
+      using Deref = MemFnDereference< typename traits::class_type >;
+
+     public:
+      MemFn(Prototype prototype, const Instance& instance)
+          : m_func(prototype), m_instance(instance)
+      {
+      }
+
+      template < typename... Args >
+      result_type
+      operator()(Args&&... args) const
+      {
+        return (Deref::deref(m_instance.value())
+                .*m_func)(std::forward< Args >(args)...);
+      }
+    };
+
+    template < typename Prototype, typename Instance >
+    MemFn< Prototype, Instance >
+    memFn(Prototype prototype, const Instance& instance)
+    {
+      return MemFn< Prototype, Instance >(prototype, instance);
+    }
+
+  }  // namespace util
+}  // namespace llarp
+
+#endif

llarp/util/memfn_traits.cpp

@@ -0,0 +1 @@
+#include <util/memfn_traits.hpp>

llarp/util/memfn_traits.hpp

@@ -0,0 +1,107 @@
+#ifndef LLARP_UTIL_MEMFN_TRAITS
+#define LLARP_UTIL_MEMFN_TRAITS
+
+#include <util/object.hpp>
+#include <util/traits.hpp>
+
+#include <functional>
+#include <utility>
+
+namespace llarp
+{
+  namespace util
+  {
+    template < typename Prototype, typename TestPrototype >
+    struct MemFnTraitsImpl;
+
+    template < typename Prototype >
+    struct MemFnTraits : public MemFnTraitsImpl< Prototype, Prototype >
+    {
+    };
+
+    template < typename Prototype, typename Return, typename Type,
+               typename... Args >
+    class MemFnTraitsClass
+    {
+      using NonCVTag    = traits::Tag< 0 >;
+      using ConstTag    = traits::Tag< 1 >;
+      using VolTag      = traits::Tag< 2 >;
+      using ConstVolTag = traits::Tag< 3 >;
+
+      // clang-format off
+      static constexpr NonCVTag    test(Return (Type::*)(Args...));
+      static constexpr ConstTag    test(Return (Type::*)(Args...) const);
+      static constexpr VolTag      test(Return (Type::*)(Args...) volatile);
+      static constexpr ConstVolTag test(Return (Type::*)(Args...) const volatile);
+      // clang-format on
+     public:
+      static constexpr bool IsConst =
+          ((sizeof((test)((Prototype)0)) - 1) & 1) != 0;
+      static constexpr bool IsVolatile =
+          ((sizeof((test)((Prototype)0)) - 1) & 2) != 0;
+
+      using ctype = std::conditional_t< IsConst, const Type, Type >;
+      using type  = std::conditional_t< IsVolatile, volatile ctype, ctype >;
+    };
+
+    template < typename Prototype, typename Return, typename Type,
+               typename... Args >
+    struct MemFnTraitsImpl< Prototype, Return (Type::*)(Args...) >
+    {
+      static constexpr bool IsMemFn = true;
+
+      using class_type =
+          typename MemFnTraitsClass< Prototype, Return, Type, Args... >::type;
+
+      using result_type = Return;
+    };
+
+    template < typename Prototype, typename Return, typename Type,
+               typename... Args >
+    struct MemFnTraitsImpl< Prototype, Return (Type::*)(Args...) const >
+    {
+      static constexpr bool IsMemFn = true;
+
+      using class_type =
+          typename MemFnTraitsClass< Prototype, Return, Type, Args... >::type;
+
+      using result_type = Return;
+    };
+
+    template < typename Prototype, typename Return, typename Type,
+               typename... Args >
+    struct MemFnTraitsImpl< Prototype, Return (Type::*)(Args...) volatile >
+    {
+      static constexpr bool IsMemFn = true;
+
+      using class_type =
+          typename MemFnTraitsClass< Prototype, Return, Type, Args... >::type;
+
+      using result_type = Return;
+    };
+
+    template < typename Prototype, typename Return, typename Type,
+               typename... Args >
+    struct MemFnTraitsImpl< Prototype,
+                            Return (Type::*)(Args...) const volatile >
+    {
+      static constexpr bool IsMemFn = true;
+
+      using class_type =
+          typename MemFnTraitsClass< Prototype, Return, Type, Args... >::type;
+
+      using result_type = Return;
+    };
+
+    template < typename Prototype, typename TestPrototype >
+    struct MemFnTraitsImpl
+    {
+      static constexpr bool IsMemFn = false;
+
+      using result_type = void;
+      using class_type  = void;
+    };
+  }  // namespace util
+}  // namespace llarp
+
+#endif

llarp/util/object.hpp

@@ -56,6 +56,54 @@ namespace llarp
       }
     };
 
+    template < typename Value >
+    class Proxy
+    {
+      Buffer< Value > m_value;
+
+      Proxy&
+      operator=(const Proxy&) = delete;
+
+     public:
+      Proxy()
+      {
+        ::new(m_value.buffer()) Value();
+      }
+
+      Proxy(const Proxy& other)
+      {
+        ::new(m_value.buffer()) Value(other.value());
+      }
+
+      Proxy(const Value& value)
+      {
+        ::new(m_value.buffer()) Value(value);
+      }
+
+      // template < typename... Args >
+      // Proxy(Args&&... args)
+      // {
+      //   ::new(m_value.buffer()) Value(std::forward< Args >(args)...);
+      // }
+
+      ~Proxy()
+      {
+        m_value.address()->~Value();
+      }
+
+      Value&
+      value()
+      {
+        return m_value.value();
+      }
+
+      const Value&
+      value() const
+      {
+        return m_value.value();
+      }
+    };
+
     template < typename Value >
     class Catalog;
     template < typename Value >

llarp/util/traits.hpp

@@ -1,6 +1,8 @@
 #ifndef LLARP_TRAITS_HPP
 #define LLARP_TRAITS_HPP
 
+#include <absl/meta/type_traits.h>
+
 #include <cstddef>
 #include <type_traits>
 #include <utility>
@@ -10,14 +12,39 @@ namespace llarp
 {
   namespace traits
   {
+    using absl::conjunction;
+    using absl::disjunction;
+    using absl::void_t;
+
     /// Represents the empty type
     struct Bottom
     {
     };
 
-    /// C++17 compatibility. template pack
+    /// Int tag
-    template < class... >
+    template < size_t N >
-    using void_t = void;
+    struct Tag
+    {
+      char arr[N + 1];
+    };
+
+    /// Type trait representing whether a type is pointer-like
+    template < typename T, typename _ = void >
+    struct is_pointy : public std::false_type
+    {
+    };
+
+    // We take the following things:
+    // - has element_type typedef
+    // - has dereference operator
+    // - has arrow operator
+    template < typename T >
+    struct is_pointy<
+        T,
+        std::conditional_t< false, void_t< decltype(*std::declval< T >()) >,
+                            void > > : public std::true_type
+    {
+    };
 
     /// Type trait representing whether a type is an STL-style container
     template < typename T, typename _ = void >

llarp/utp/session.cpp

@@ -4,13 +4,12 @@
 #include <messages/discard.hpp>
 #include <messages/link_intro.hpp>
 #include <util/metrics.hpp>
+#include <util/memfn.hpp>
 
 namespace llarp
 {
   namespace utp
   {
-    using namespace std::placeholders;
-
     void
     Session::OnLinkEstablished(ILinkLayer* p)
     {
@@ -613,7 +612,7 @@ namespace llarp
       ABSL_ATTRIBUTE_UNUSED void* res = utp_set_userdata(sock, this);
       assert(res == this);
       assert(s == sock);
-      GotLIM = std::bind(&InboundSession::InboundLIM, this, _1);
+      GotLIM = util::memFn(&InboundSession::InboundLIM, this);
     }
 
     bool
@@ -678,7 +677,7 @@ namespace llarp
         gotLIM = true;
         EnterState(eSessionReady);
         /// future LIM are used for session renegotiation
-        GotLIM = std::bind(&Session::GotSessionRenegotiate, this, _1);
+        GotLIM = util::memFn(&Session::GotSessionRenegotiate, this);
       }
       return true;
     }
@@ -702,7 +701,7 @@ namespace llarp
       assert(res == this);
       assert(s == sock);
 
-      GotLIM = std::bind(&OutboundSession::OutboundLIM, this, _1);
+      GotLIM = util::memFn(&OutboundSession::OutboundLIM, this);
     }
 
     void
@@ -729,7 +728,7 @@ namespace llarp
         return false;
       }
       /// future LIM are used for session renegotiation
-      GotLIM = std::bind(&Session::GotSessionRenegotiate, this, _1);
+      GotLIM = util::memFn(&Session::GotSessionRenegotiate, this);
       EnterState(eSessionReady);
       return true;
     }

llarp/utp/utp.cpp

@@ -1,14 +1,13 @@
 #include <utp/utp.hpp>
 
-#include <utp/linklayer.hpp>
 #include <router/abstractrouter.hpp>
+#include <util/memfn.hpp>
+#include <utp/linklayer.hpp>
 
 namespace llarp
 {
   namespace utp
   {
-    using namespace std::placeholders;
-
     LinkLayer_ptr
     NewServer(const SecretKey& routerEncSecret, GetRCFunc getrc,
               LinkMessageHandler h, SessionEstablishedHandler est,
@@ -22,15 +21,14 @@ namespace llarp
     LinkLayer_ptr
     NewServerFromRouter(AbstractRouter* r)
     {
-      using namespace std::placeholders;
       return NewServer(
-          r->encryption(), std::bind(&AbstractRouter::rc, r),
+          r->encryption(), util::memFn(&AbstractRouter::rc, r),
-          std::bind(&AbstractRouter::HandleRecvLinkMessageBuffer, r, _1, _2),
+          util::memFn(&AbstractRouter::HandleRecvLinkMessageBuffer, r),
-          std::bind(&AbstractRouter::OnSessionEstablished, r, _1),
+          util::memFn(&AbstractRouter::OnSessionEstablished, r),
-          std::bind(&AbstractRouter::CheckRenegotiateValid, r, _1, _2),
+          util::memFn(&AbstractRouter::CheckRenegotiateValid, r),
-          std::bind(&AbstractRouter::Sign, r, _1, _2),
+          util::memFn(&AbstractRouter::Sign, r),
-          std::bind(&AbstractRouter::OnConnectTimeout, r, _1),
+          util::memFn(&AbstractRouter::OnConnectTimeout, r),
-          std::bind(&AbstractRouter::SessionClosed, r, _1));
+          util::memFn(&AbstractRouter::SessionClosed, r));
     }
 
   }  // namespace utp

test/CMakeLists.txt

@@ -39,6 +39,7 @@ list(APPEND TEST_SRC
     util/test_llarp_util_ini.cpp
     util/test_llarp_util_metrics_core.cpp
     util/test_llarp_util_metrics_types.cpp
+    util/test_llarp_util_memfn.cpp
     util/test_llarp_util_object.cpp
     util/test_llarp_util_printer.cpp
     util/test_llarp_util_queue_manager.cpp

test/util/test_llarp_util_memfn.cpp

@@ -0,0 +1,68 @@
+#include <util/memfn.hpp>
+
+#include <gtest/gtest.h>
+#include <gmock/gmock.h>
+
+using namespace llarp;
+
+struct Foo
+{
+  bool
+  empty()
+  {
+    return false;
+  }
+
+  bool
+  constEmpty() const
+  {
+    return true;
+  }
+
+  int
+  arg(int v)
+  {
+    return v + 1;
+  }
+
+  int
+  constArg(int v) const
+  {
+    return v - 1;
+  }
+};
+
+TEST(MemFn, call)
+{
+  Foo foo;
+  ASSERT_FALSE(util::memFn(&Foo::empty, &foo)());
+  ASSERT_TRUE(util::memFn(&Foo::constEmpty, &foo)());
+  ASSERT_EQ(11, util::memFn(&Foo::arg, &foo)(10));
+  ASSERT_EQ(9, util::memFn(&Foo::constArg, &foo)(10));
+
+  ASSERT_TRUE(util::memFn(&Foo::constEmpty, foo)());
+  ASSERT_EQ(9, util::memFn(&Foo::constArg, foo)(10));
+}
+
+template < typename T >
+class MemFnType : public ::testing::Test
+{
+};
+
+TYPED_TEST_SUITE_P(MemFnType);
+
+TYPED_TEST_P(MemFnType, Smoke)
+{
+  TypeParam foo;
+  ASSERT_TRUE(util::memFn(&Foo::constEmpty, foo)());
+  ASSERT_TRUE(util::memFn(&Foo::constEmpty, &foo)());
+}
+
+REGISTER_TYPED_TEST_SUITE_P(MemFnType, Smoke);
+
+// clang-format off
+using MemFnTypes = ::testing::Types<
+  Foo, const Foo>;
+
+INSTANTIATE_TYPED_TEST_SUITE_P(MemFn, MemFnType, MemFnTypes);
+// clang-format on

test/util/test_llarp_util_traits.cpp

@@ -152,3 +152,30 @@ using SelectTypes = ::testing::Types<
 INSTANTIATE_TYPED_TEST_SUITE_P(traits, Select, SelectTypes);
 
 // clang-format on
+
+template < typename T >
+class IsPointy : public ::testing::Test
+{
+};
+
+TYPED_TEST_SUITE_P(IsPointy);
+
+TYPED_TEST_P(IsPointy, Smoke)
+{
+  bool expected = std::tuple_element_t< 1, TypeParam >::value;
+  bool result =
+      traits::is_pointy< std::tuple_element_t< 0, TypeParam > >::value;
+  ASSERT_EQ(expected, result);
+}
+
+REGISTER_TYPED_TEST_SUITE_P(IsPointy, Smoke);
+
+// clang-format off
+using PointerTypes = ::testing::Types<
+    std::tuple< int *, std::true_type >,
+    std::tuple< int, std::integral_constant< bool, false > >,
+    std::tuple< std::shared_ptr<int>, std::true_type >,
+    std::tuple< std::unique_ptr<int>, std::true_type >
+>;
+INSTANTIATE_TYPED_TEST_SUITE_P(traits, IsPointy, PointerTypes);
+// clang-format on