macos compilation fixes

pull/1969/head
Jason Rhinelander 2 years ago
parent a82907bc6c
commit 27d58044c7
No known key found for this signature in database
GPG Key ID: C4992CE7A88D4262

@ -90,7 +90,7 @@ llarp_apple_init(llarp_apple_config* appleconf)
#ifdef MACOS_SYSTEM_EXTENSION #ifdef MACOS_SYSTEM_EXTENSION
std::strncpy( std::strncpy(
appleconf->dns_bind_ip, appleconf->dns_bind_ip,
config->dns.m_bind.hostString().c_str(), config->dns.m_bind.front().hostString().c_str(),
sizeof(appleconf->dns_bind_ip)); sizeof(appleconf->dns_bind_ip));
#endif #endif

@ -38,14 +38,14 @@ namespace llarp::apple
trampoline_active = enable; trampoline_active = enable;
} }
void RouteManager::AddDefaultRouteViaInterface(std::string) void RouteManager::AddDefaultRouteViaInterface(vpn::NetworkInterface&)
{ {
check_trampoline(true); check_trampoline(true);
if (callback_context and route_callbacks.add_default_route) if (callback_context and route_callbacks.add_default_route)
route_callbacks.add_default_route(callback_context); route_callbacks.add_default_route(callback_context);
} }
void RouteManager::DelDefaultRouteViaInterface(std::string) void RouteManager::DelDefaultRouteViaInterface(vpn::NetworkInterface&)
{ {
check_trampoline(false); check_trampoline(false);
if (callback_context and route_callbacks.del_default_route) if (callback_context and route_callbacks.del_default_route)

@ -1,7 +1,7 @@
#pragma once #pragma once
#include <llarp/router/abstractrouter.hpp> #include <llarp/router/abstractrouter.hpp>
#include <llarp/ev/vpn.hpp> #include <llarp/vpn/platform.hpp>
#include "context_wrapper.h" #include "context_wrapper.h"
namespace llarp::apple namespace llarp::apple
@ -16,18 +16,18 @@ namespace llarp::apple
/// These are called for poking route holes, but we don't have to do that at all on macos /// These are called for poking route holes, but we don't have to do that at all on macos
/// because the appex isn't subject to its own rules. /// because the appex isn't subject to its own rules.
void void
AddRoute(IPVariant_t /*ip*/, IPVariant_t /*gateway*/) override AddRoute(net::ipaddr_t /*ip*/, net::ipaddr_t /*gateway*/) override
{} {}
void void
DelRoute(IPVariant_t /*ip*/, IPVariant_t /*gateway*/) override DelRoute(net::ipaddr_t /*ip*/, net::ipaddr_t /*gateway*/) override
{} {}
void void
AddDefaultRouteViaInterface(std::string ifname) override; AddDefaultRouteViaInterface(vpn::NetworkInterface& vpn) override;
void void
DelDefaultRouteViaInterface(std::string ifname) override; DelDefaultRouteViaInterface(vpn::NetworkInterface& vpn) override;
void void
AddRouteViaInterface(vpn::NetworkInterface& vpn, IPRange range) override; AddRouteViaInterface(vpn::NetworkInterface& vpn, IPRange range) override;
@ -35,13 +35,13 @@ namespace llarp::apple
void void
DelRouteViaInterface(vpn::NetworkInterface& vpn, IPRange range) override; DelRouteViaInterface(vpn::NetworkInterface& vpn, IPRange range) override;
std::vector<IPVariant_t> std::vector<net::ipaddr_t>
GetGatewaysNotOnInterface(std::string /*ifname*/) override GetGatewaysNotOnInterface(vpn::NetworkInterface& /*vpn*/) override
{ {
// We can't get this on mac from our sandbox, but we don't actually need it because we // We can't get this on mac from our sandbox, but we don't actually need it because we
// ignore the gateway for AddRoute/DelRoute anyway, so just return a zero IP. // ignore the gateway for AddRoute/DelRoute anyway, so just return a zero IP.
std::vector<IPVariant_t> ret; std::vector<net::ipaddr_t> ret;
ret.push_back(huint32_t{0}); ret.emplace_back(net::ipv4addr_t{});
return ret; return ret;
} }

@ -10,7 +10,8 @@ namespace llarp::apple
packet_write_callback packet_writer, packet_write_callback packet_writer,
on_readable_callback on_readable, on_readable_callback on_readable,
AbstractRouter* router) AbstractRouter* router)
: m_PacketWriter{std::move(packet_writer)} : vpn::NetworkInterface{{}}
, m_PacketWriter{std::move(packet_writer)}
, m_OnReadable{std::move(on_readable)} , m_OnReadable{std::move(on_readable)}
, _router{router} , _router{router}
{ {
@ -39,12 +40,6 @@ namespace llarp::apple
return -1; return -1;
} }
std::string
VPNInterface::IfName() const
{
return "";
}
net::IPPacket net::IPPacket
VPNInterface::ReadNextPacket() VPNInterface::ReadNextPacket()
{ {
@ -58,7 +53,7 @@ namespace llarp::apple
VPNInterface::WritePacket(net::IPPacket pkt) VPNInterface::WritePacket(net::IPPacket pkt)
{ {
int af_family = pkt.IsV6() ? AF_INET6 : AF_INET; int af_family = pkt.IsV6() ? AF_INET6 : AF_INET;
return m_PacketWriter(af_family, pkt.buf, pkt.sz); return m_PacketWriter(af_family, pkt.data(), pkt.size());
} }
} // namespace llarp::apple } // namespace llarp::apple

@ -29,9 +29,6 @@ namespace llarp::apple
int int
PollFD() const override; PollFD() const override;
std::string
IfName() const override;
net::IPPacket net::IPPacket
ReadNextPacket() override; ReadNextPacket() override;

@ -1,6 +1,6 @@
#pragma once #pragma once
#include <llarp/ev/vpn.hpp> #include <llarp/vpn/platform.hpp>
#include "vpn_interface.hpp" #include "vpn_interface.hpp"
#include "route_manager.hpp" #include "route_manager.hpp"

Loading…
Cancel
Save