Remove all ABSL_ATTRIBUTE_UNUSED uses

libabyss/src/client.cpp

@@ -77,7 +77,7 @@ namespace abyss
       }
 
       static void
-      OnTick(ABSL_ATTRIBUTE_UNUSED llarp_tcp_conn* conn)
+      OnTick(llarp_tcp_conn* /*conn*/)
       {
       }
 

llarp/config/config.cpp

@@ -330,8 +330,7 @@ namespace llarp
   }
 
   void
-  ConnectConfig::fromSection(ABSL_ATTRIBUTE_UNUSED string_view key,
+  ConnectConfig::fromSection(string_view /*key*/, string_view val)
-                             string_view val)
   {
     routers.emplace_back(val.begin(), val.end());
   }

llarp/dht/messages/gotintro.cpp

@@ -20,8 +20,7 @@ namespace llarp
     bool
     GotIntroMessage::HandleMessage(
         llarp_dht_context *ctx,
-        ABSL_ATTRIBUTE_UNUSED std::vector< std::unique_ptr< IMessage > >
+        std::vector< std::unique_ptr< IMessage > > & /*replies*/) const
-            &replies) const
     {
       auto &dht = *ctx->impl;
 

llarp/messages/discard.hpp

@@ -54,7 +54,7 @@ namespace llarp
     }
 
     bool
-    HandleMessage(ABSL_ATTRIBUTE_UNUSED AbstractRouter* router) const override
+    HandleMessage(AbstractRouter* /*router*/) const override
     {
       return true;
     }

llarp/messages/link_intro.cpp

@@ -99,8 +99,7 @@ namespace llarp
   }
 
   bool
-  LinkIntroMessage::HandleMessage(
+  LinkIntroMessage::HandleMessage(AbstractRouter* /*router*/) const
-      ABSL_ATTRIBUTE_UNUSED AbstractRouter* router) const
   {
     if(!Verify())
       return false;

llarp/path/path.cpp

@@ -625,9 +625,8 @@ namespace llarp
     }
 
     bool
-    Path::HandlePathTransferMessage(
+    Path::HandlePathTransferMessage(const routing::PathTransferMessage& /*msg*/,
-        ABSL_ATTRIBUTE_UNUSED const routing::PathTransferMessage& msg,
+                                    AbstractRouter* /*r*/)
-        ABSL_ATTRIBUTE_UNUSED AbstractRouter* r)
     {
       LogWarn("unwarranted path transfer message on tx=", TXID(),
               " rx=", RXID());
@@ -675,9 +674,8 @@ namespace llarp
     }
 
     bool
-    Path::HandlePathConfirmMessage(
+    Path::HandlePathConfirmMessage(const routing::PathConfirmMessage& /*msg*/,
-        ABSL_ATTRIBUTE_UNUSED const routing::PathConfirmMessage& msg,
+                                   AbstractRouter* r)
-        AbstractRouter* r)
     {
       return HandlePathConfirmMessage(r);
     }
@@ -725,7 +723,7 @@ namespace llarp
 
     bool
     Path::HandleCloseExitMessage(const routing::CloseExitMessage& msg,
-                                 ABSL_ATTRIBUTE_UNUSED AbstractRouter* r)
+                                 AbstractRouter* /*r*/)
     {
       /// allows exits to close from their end
       if(SupportsAnyRoles(ePathRoleExit | ePathRoleSVC))

llarp/path/transit_hop.hpp

@@ -191,8 +191,7 @@ namespace llarp
                              AbstractRouter* r) override;
 
       bool
-      HandleHiddenServiceFrame(
+      HandleHiddenServiceFrame(const service::ProtocolFrame& /*frame*/) override
-          ABSL_ATTRIBUTE_UNUSED const service::ProtocolFrame& frame) override
       {
         /// TODO: implement me
         LogWarn("Got hidden service data on transit hop");

llarp/pow.cpp

@@ -10,8 +10,7 @@ namespace llarp
   PoW::~PoW() = default;
 
   bool
-  PoW::DecodeKey(ABSL_ATTRIBUTE_UNUSED const llarp_buffer_t& k,
+  PoW::DecodeKey(const llarp_buffer_t& /*k*/, llarp_buffer_t* /*val*/)
-                 ABSL_ATTRIBUTE_UNUSED llarp_buffer_t* val)
   {
     // TODO: implement me
     return false;

llarp/router/router.cpp

@@ -805,7 +805,7 @@ namespace llarp
   }
 
   void
-  Router::HandleDHTLookupForExplore(ABSL_ATTRIBUTE_UNUSED RouterID remote,
+  Router::HandleDHTLookupForExplore(RouterID /*remote*/,
                                     const std::vector< RouterContact > &results)
   {
     for(const auto &rc : results)
@@ -1180,7 +1180,7 @@ namespace llarp
   }
 
   bool
-  Router::ValidateConfig(ABSL_ATTRIBUTE_UNUSED Config *conf) const
+  Router::ValidateConfig(Config * /*conf*/) const
   {
     return true;
   }

llarp/rpc/rpc.cpp

@@ -401,8 +401,7 @@ namespace llarp
       }
 
       Response
-      HandleJSONRPC(Method_t method,
+      HandleJSONRPC(Method_t method, const Params& /*params*/) override
-                    ABSL_ATTRIBUTE_UNUSED const Params& params) override
       {
         auto it = m_dispatch.find(method);
         if(it != m_dispatch.end())

llarp/service/endpoint.cpp

@@ -196,10 +196,7 @@ namespace llarp
         if(!EndpointUtil::HasPathToService(addr, m_state->m_RemoteSessions))
         {
           if(!EnsurePathToService(
-                 addr,
+                 addr, [](Address, OutboundContext*) {}, 10000))
-                 [](ABSL_ATTRIBUTE_UNUSED Address _addr,
-                    ABSL_ATTRIBUTE_UNUSED OutboundContext* _ctx) {},
-                 10000))
           {
             LogWarn("failed to ensure path to ", addr);
           }
@@ -966,7 +963,7 @@ namespace llarp
 
     bool
     Endpoint::EnsurePathToService(const Address remote, PathEnsureHook hook,
-                                  ABSL_ATTRIBUTE_UNUSED llarp_time_t timeoutMS)
+                                  llarp_time_t /*timeoutMS*/)
     {
       static constexpr size_t NumParalellLookups = 2;
       LogInfo(Name(), " Ensure Path to ", remote.ToString());
@@ -1120,9 +1117,8 @@ namespace llarp
     }
 
     bool
-    Endpoint::EnsureConvo(ABSL_ATTRIBUTE_UNUSED const AlignedBuffer< 32 > addr,
+    Endpoint::EnsureConvo(const AlignedBuffer< 32 > /*addr*/, bool snode,
-                          bool snode,
+                          ConvoEventListener_ptr /*ev*/)
-                          ABSL_ATTRIBUTE_UNUSED ConvoEventListener_ptr ev)
     {
       if(snode)
       {

llarp/service/protocol.cpp

@@ -460,7 +460,7 @@ namespace llarp
 
     bool
     ProtocolFrame::HandleMessage(routing::IMessageHandler* h,
-                                 ABSL_ATTRIBUTE_UNUSED AbstractRouter* r) const
+                                 AbstractRouter* /*r*/) const
     {
       return h->HandleHiddenServiceFrame(*this);
     }