2
0
mirror of https://github.com/lnbook/lnbook synced 2024-11-08 19:10:35 +00:00
Commit Graph

427 Commits

Author SHA1 Message Date
8go
e7fd91964b
minor improvements to chapter "Missing bits" (#202)
- repeated use of "following"
- peer-to-peer instead "peer to peer"
- minor clarifications
- etc
2020-04-22 18:12:29 +02:00
Rene Pichardt
08c87e7fdf started to write about setteling htlcs 2020-04-20 20:00:56 +02:00
Andreas M. Antonopoulos
fd776b39c1 Relaxed Travis to avoid breaking builds while things are in flux
The travis linter is too strict and we keep failing builds. This is a bit like taking the batteries out of the smoke alarm, or using aluminum foil to replace a fuse, or both. Everything is fine!
2020-04-19 17:51:38 -04:00
Andreas M. Antonopoulos
473a259bfa
Merge pull request #154 from HAOYUatHZ/ln_msg
add "Ligtning Messages" section
2020-04-19 16:10:41 -04:00
Rene Pichardt
05e161596d added explainations how htlcs are being set up in payment channels to prepare routing 2020-04-19 16:46:11 +02:00
Rene Pichardt
03b0d87b8a added the fist version of the routing chapter. did no have time to do proof reading or editorial yet 2020-04-18 17:12:13 +02:00
Rene Pichardt
369400428b added some calaculations about onchain scaling 2020-04-18 11:39:04 +02:00
HAOYUatHZ
dae192a37c
add Transaction Malleability (#150)
* add Transaction Malleability

* fix https://github.com/lnbook/lnbook/pull/150#discussion_r379919498

* explain why non-malleability is needed

* fix typos
2020-04-18 11:03:19 +02:00
Kory Newton
f226a5fb1a
fix typos in chapter 3 (#166)
* fix typos Chapter 3

* additional ch3 typo fixes

Co-authored-by: Rene Pickhardt <rene@rene-pickhardt.de>
2020-04-18 10:57:17 +02:00
Roman
ae9d905f27
fix typos in ch1 and ch2 (#168)
* table indentation

* 'a' before consonant

* less commas

* wording

* unquote commas

* typo

* on chain -> on-chain

* need comma (IMHO)

* dot

* caps acronym

* wording

Co-authored-by: Rene Pickhardt <rene@rene-pickhardt.de>
2020-04-18 10:54:47 +02:00
8go
e7ea91fe81
minor improvements in "Example of a poor channel opening procedure" (#184)
- replace "committing attack" with "performing attack" to avoid that the reader incorrectly concludes that the term "commitment tx" has anything to do with "committing an attack"
- signed by, not signed from
2020-04-18 10:51:19 +02:00
8go
58f282ee38
minor improvements to Funding Transaction paragraphs (#183)
- consistently sticking to "2-out-of-2"
- rephrasing some sentences to make them more palatable. "obviously a lie" is a bit aggressive. 
- avoid using exaggerating terms like "very expensive", just state the facts without too many emotions
2020-04-18 10:50:33 +02:00
8go
a4e59ed614
improvements to Multisig addresses paragraphs (#182)
- as before "2-out-of-2" is more appropriate than "2-2" 
- "thus" is not what you wanted to express, "however" is what you wanted to say
- added missing comma
- etc
2020-04-18 10:49:06 +02:00
8go
26b0fb4e78
minor corrections in Payment channels paragraphs (#181)
- "the both of you": incorrect English, better "both of you"
- "cheat on you": spoken English, better "cheat you"
- "had to be", that sounds like you are guessing, better "was"
- if you give full names of some, give full names of all 
- added year to make it more precise
- etc.
2020-04-18 10:48:10 +02:00
8go
bf44a80973
minor improvements, corrections (#180)
- comma must follow "additionally" and "however" as they are introductory words or phrases
- same for "last but not least", comma missing
- "nothing else than", not perfect English; better "nothing but" 
- "get most use", not perfect English; better "get more benefits"
2020-04-18 10:45:20 +02:00
8go
a80f758b1f
minor improvements in Note (#179)
- 2-out-of-2 is more consistent (see usage above) and carries more information than 2-2
- comma after however needed
2020-04-18 10:44:16 +02:00
8go
b4204ba4cf
added a few words to improve definition paragraph (#178)
- consistent use of "partner"
- added "Bitcoin" to "Bitcoin smart contract" because there are many people out there that have heard the term "smart contract" exclusively in the context of Ethereum. It might be worth while to underline that Bitcoin also has its form of smart contracts. This should eliminate any possible doubts.
- imply that earlier states are no longer valid, added "invalidated" 
- channel member is singular, so "if they try" is wrong. better "if it tries"
2020-04-18 10:43:44 +02:00
8go
52aa362dcc
improved definition of LN (#177)
- removed incorrect comma in front of "as well as"
- added "both" to make it stronger that LN has 2 main functionalities
- "... on the network." leaves it undefined. The reader might ask to which netowrk it refers to? To the before mentioned netowrk of payment-channels? Added "Bitcoin" to clarify.
2020-04-18 10:42:52 +02:00
8go
6ec8035b52
clarifications and additions (#173)
* clarifiactions and additions

some modifications to improve, clarify

some additions to add more details where appropriate

... lightweight Bitcoin client (commonly referred to as Simplified Payment Verification (SPV)) to partially validate the correctness of their blockchain. --> partially? Probably you mean "indirectly" as you delegate to a third party. Also SPVs clients don't have a blockchain, so why "their blockchain"? --> to reduce this confusion --> lightweight Bitcoin client (commonly referred to as Simplified Payment Verification (SPV)) to interact with the blockchain

... lightning wallets ... --> ... Lightning wallets ...

centralized and added more details to definition of non-custodial wallet

* Update 02_getting_started.asciidoc

added the sentince back in

Co-authored-by: Rene Pickhardt <rene@rene-pickhardt.de>
2020-04-18 10:41:46 +02:00
8go
94bdc595c5
minor improvements and clarifications (#170)
- minor clarifications
- incorrect use of plural
- repetitive use of "this way" --> this fashion
- clarifying "each time" --> each payment
- added detail that LN txs are not stored permanently
- repetitive use of "explanation" --> clarification
- seeing --> revisiting
- etc.
2020-04-18 10:24:14 +02:00
Kory Newton
3ef507291a
fix glossary typos (#167) 2020-04-18 10:17:19 +02:00
Andreas M. Antonopoulos
ed13d20960
Merge pull request #163 from brianmcmichael/brianmcmichael_ch01
Ch. 1 readthrough.
2020-02-23 15:35:44 -06:00
Andreas M. Antonopoulos
19e6a0357c
Merge pull request #156 from PatrickLemke/fix-typos-ch03
Fix typos ch03
2020-02-23 15:32:20 -06:00
Brian McMichael
01cef463ef Fix sp. breaking build 2020-02-23 15:29:32 -05:00
Brian McMichael
b2b9e55f2a ox comma 2020-02-23 15:25:44 -05:00
Brian McMichael
09d04a297c comma 2020-02-23 15:24:36 -05:00
Brian McMichael
b2760a81e3 bitcoin and demand grow 2020-02-23 15:00:22 -05:00
Brian McMichael
88e78da7e5 non obvious => non-obvious 2020-02-23 14:55:49 -05:00
Patrick Lemke
68911c5560 remove end of line spaces 2020-02-23 19:21:01 +01:00
Patrick Lemke
504d7f37e8 add patricklemke to contributions in preface 2020-02-23 19:16:07 +01:00
Patrick Lemke
c97ad6e980 capitalization 2020-02-23 19:16:07 +01:00
Patrick Lemke
4fe03c9567 capitalization 2020-02-23 19:16:07 +01:00
Patrick Lemke
0076c89e35 capitalization 2020-02-23 19:16:07 +01:00
Patrick Lemke
76079a3d6d wording 2020-02-23 19:16:07 +01:00
Patrick Lemke
9df3a8267a typo 2020-02-23 19:16:07 +01:00
Patrick Lemke
2c8860b00e typo 2020-02-23 19:16:07 +01:00
Patrick Lemke
18fbeb85d2 comma separation 2020-02-23 19:14:42 +01:00
Patrick Lemke
cf94641c26 wording 2020-02-23 19:13:44 +01:00
Patrick Lemke
bd79255000 spacing 2020-02-23 19:11:31 +01:00
Patrick Lemke
85f5e4de32 comma separation 2020-02-23 19:09:56 +01:00
Patrick Lemke
f7df2f5cd3 capitalization 2020-02-23 19:00:43 +01:00
Patrick Lemke
56dfd77201 capitalization 2020-02-23 19:00:43 +01:00
Patrick Lemke
0af20a81dd typo 2020-02-23 18:59:56 +01:00
Patrick Lemke
6091c64296 typo 2020-02-23 18:59:27 +01:00
Patrick Lemke
df0a164f77 typo 2020-02-23 18:59:27 +01:00
Patrick Lemke
0724f00353 capitalization 2020-02-23 18:59:27 +01:00
Patrick Lemke
0e8c264ed0 capitalization 2020-02-23 18:58:47 +01:00
Patrick Lemke
7375e64c0d capitalization 2020-02-23 18:58:06 +01:00
Patrick Lemke
64520e1d4f capitalization 2020-02-23 18:56:53 +01:00
Patrick Lemke
43c398e790 comma seperation 2020-02-23 18:55:46 +01:00