2
0
mirror of https://github.com/lnbook/lnbook synced 2024-11-08 19:10:35 +00:00
Commit Graph

70 Commits

Author SHA1 Message Date
TS
dab18f48fd adds parenthesis in the docker-compose exec , such that the command behind pipe is exectued within the container 2020-08-14 10:12:28 +02:00
Andreas M. Antonopoulos
89559bfb8f
Merge pull request #346 from 8go/patch-80
Eclair: English touch ups, commas
2020-08-06 14:02:55 -04:00
Andreas M. Antonopoulos
a3bacdc724
Merge pull request #345 from 8go/patch-79
Eclair: English touch ups
2020-08-06 14:02:36 -04:00
Andreas M. Antonopoulos
915ebc195a
Merge pull request #343 from 8go/patch-78
LND: more English fixes, 1 error
2020-08-06 14:02:10 -04:00
Andreas M. Antonopoulos
bc54811d12
Merge pull request #341 from 8go/patch-77
LND: typos, touch ups, English, etc.
2020-08-06 14:01:45 -04:00
8go
8c853ee92c
Complete Network, part 1: English touch ups
- Oxford comma for consistency (see PR #340)
- sentence restructuring (one does not compose by routing a payment)
- no comma in list of 2
- only the top of the config is listed, we should say so. --> The top looks like ...
- in most cases, no comma before "because" or "since", exceptions apply
- it's (wrong) --> its (possessive)
2020-08-06 17:11:22 +00:00
8go
a77e4161c4
Eclair: English touch ups, commas
- commas
- reorg of sentences
- "Check to..." sentence is copy-paste from above, changed it slightly to avoid repetition
- OK, Eclair is uppercase, but here we refer to a directory which is lowercase, so "eclair" (just because it is the lowercase name of the dir)
- etc
2020-08-06 16:16:04 +00:00
8go
90836468d0
Eclair: English touch ups
- commas
- "by this point" --> "at this point" or "by this time". Maybe best "by now"
- "... you have seen previously to build the Eclair container" is ambiguous. Rephrased
- "directly" .... word order
- it's: incorrect,  --> its
- "unlike the LND or c-lightning containers": did not read well, reordered sub-phrases
- eclair vs Eclair: ok, the logo is lower cased. But when you read their https://github.com/ACINQ/eclair page ALL occurrences of Eclair are UPPERCASED.
- Based on their own use of "Eclair" in English text I have upper-cased all "Eclair" occurrences 
- up to line 779 it was already upper-case, then suddenly it was lower-case
- rephrasing
- etc
2020-08-05 14:14:49 +00:00
8go
ac2ec76dd4
LND: more English fixes, 1 error
- again commas
- sentence simplifications
- typo
- "at minimum" : that's wrong, "at a minimum", "at least" but I rephrased anyway to avoid it altogether because it does not read well in any case due to the following "or later"
- "distributed" repetitive, changed to "available"
- "It doesn't matter where the GOPATH points" ... this is misleading or could be misunderstood. I rephrased.
- ERROR: "git clone" should be "go get"
2020-08-05 13:38:43 +00:00
8go
06b8a2f38e
more touch ups, English, commas (#340)
- replaced ", as is often the case," with "common"
- "prerequisite" has no hyphen
- in most cases no comma in front of "which"
- replaced "that we can do" with "available"
- if there is a list of 3 choices, one can place (optional) a comma before the "and". This is called the Oxford comma. It is optional, but it should be used consistently, always in the book or never. Since above it was used, I set it below as well.
- replaced "aggressively" with "heavily", we are not aggressive :)
- etc.
2020-08-05 15:09:50 +02:00
8go
fd9635d345
minor touch up, English corrections (#338)
- usually there is no comma in front of because, as, etc. (exceptions exist)
- other commas
- "Let's" sounds very colloquial. It shows up a lot. In a couple of locations I replaced it with "let us" to make it a bit more formal, but I did not want to replace all. Maybe colloquialisms create some closeness to the reader.
- "also" seemed out of place
- local area network  has no hyphen
- "not important, but has ...": either no comma   or   a subject (it) has to be added after "but"
- "like this" was also a bit repetitive, I replaced it once with "as follows"
2020-08-05 15:08:11 +02:00
8go
cee0dfe142
LND: typos, touch ups, English, etc.
- no comma in front of "and" in a list of 2
- same for "or" in list of 2
- list of 3: yes, we want a comma there to be consistent (Oxford comma, see PR #340 
- many many --> many
2020-08-02 19:03:27 +00:00
Andreas M. Antonopoulos
27bb45b5c3
Merge branch 'develop' into typos-and-small-fix 2020-07-28 09:46:31 -04:00
Andreas M. Antonopoulos
d74ab8293c
Merge pull request #319 from vnprc/develop
code, spelling and grammar fixes for node_client chapter
2020-07-28 09:37:56 -04:00
Andreas M. Antonopoulos
23a1acf634
Merge pull request #303 from 8go/patch-74
simplifications
2020-07-28 09:30:36 -04:00
Andreas M. Antonopoulos
dc77a9ea00
Merge pull request #302 from 8go/patch-73
rephrase the pipe explanation
2020-07-28 09:30:17 -04:00
Andreas M. Antonopoulos
32684a1462
Merge pull request #301 from 8go/patch-72
commas, formats, it's vs its
2020-07-28 09:28:48 -04:00
Andreas M. Antonopoulos
83f3c0b380
Merge pull request #300 from 8go/patch-71
commas, formatting
2020-07-28 09:28:29 -04:00
Andreas M. Antonopoulos
48307f2065
Merge pull request #299 from 8go/patch-70
tiny English improvements 5, commas
2020-07-28 09:27:43 -04:00
Andreas M. Antonopoulos
ca8497fce9
Merge pull request #297 from 8go/patch-69
English improvements 4
2020-07-28 09:26:02 -04:00
Andreas M. Antonopoulos
b464a16338
Merge pull request #296 from 8go/patch-68
tiny English improvements 3
2020-07-28 09:24:53 -04:00
Andreas M. Antonopoulos
ef299263c3
Merge pull request #295 from 8go/patch-67
updated TIP box
2020-07-28 09:24:10 -04:00
Trigger
326c95ac4c Node client - Installing go in 20.04 is easier 2020-07-24 23:04:57 +02:00
Trigger
9a632006ff Node client - Add missing line break causing an error 2020-07-24 22:27:38 +02:00
Trigger
655b3acca8 Update ubuntu LTS to 20.04 2020-07-24 22:24:18 +02:00
Francisco Calderón
9044787d57
Fixes some typos 2020-07-22 11:48:33 -03:00
evan
94a1395925 use correct mvn -v flag, not mvn -V 2020-07-10 13:41:25 -04:00
evan
3a1103136a spelling and formatting fixes 2020-07-10 13:40:43 -04:00
evan
4b6c3c34d1 add missing newline to fix broken apt-get command 2020-07-10 13:40:07 -04:00
evan
c213590a1d run jq on docker instance using bash -c args 2020-07-10 13:39:37 -04:00
8go
2aa2c0967d
simplifications 2020-07-02 06:43:08 +00:00
8go
f795ae82da
rephrase the pipe explanation
- added "simulated" to make sure readers understand that they are not mining real blocks
- 1st --> first, general guideline is to spell numbers up to 12 out
- "now" ==> used twice ==> repetitive ==> removed second "now"
- "refer to" ==> "by some name"
- removed also
2020-07-02 06:23:00 +00:00
8go
c1d038a6c1
commas, formats, it's vs its
- also ==> there is reference point to this "also", removed
- comma
- lightning ==> Lightning
- another comma
- It's ==> wrong ==> Its
2020-07-02 05:28:48 +00:00
8go
d762886a4b
commas, formatting 2020-07-02 05:16:12 +00:00
8go
a31016841d
tiny English improvements 5, commas
- comma ... no comma in front of "for"
- which, which   ... repetitive, improved
- comma
- instructions to install ==> installation instructions
- another comma
2020-07-02 04:56:30 +00:00
8go
f6a740ac10
Update node_client.asciidoc
- "not worry" ==> "need not worry"
- removed ( ) ==> replaced with "i.e." to make it more formal
- "we want to work with a distribution that is familiar to many developers" ==> not correct linguistically; "familiar with" is better English than "familiar to"; this should be changed. I took this as reason to rephrase the whole sentence.
- "beneath" ==> "as can be seen below"
2020-07-01 16:40:46 +00:00
8go
792f8d6896
tiny English improvements 3
- putting emphasis on repository being online
- "the" article required in this case
- removed "version" from "ebook version" to simplify
- green: work order corrected
- no comma with "..., to"
2020-07-01 16:10:04 +00:00
8go
7d9d320552
updated TIP box
- to make it even easier to understand for noobies
2020-07-01 15:59:02 +00:00
Andreas M. Antonopoulos
1db4e55110
Merge pull request #294 from 8go/patch-65
tiny English improvements
2020-07-01 11:56:30 -04:00
Andreas M. Antonopoulos
b19836953b
Merge branch 'develop' into patch-64 2020-07-01 11:55:31 -04:00
8go
de586c676f
tiny English improvements
- removed ( ) and replaced it with "or" ... better style
- added 2 words to make it read better
- restructured a sentence 
- plural seems more appropriate
2020-07-01 15:43:44 +00:00
8go
99a3f85c10
tiny English improvements
- Similarily ==> correspondingly   ... fits the meaning better
- show ==> present ... more elegant
- BOLTS ==> BOLT standards ... to make it more clear to the novice reader
- removed comma ... no comma when subject is same in both parts of sentence
- recommend ==> endorse ... better, recommend one over the other is at best used colloquially
2020-07-01 15:18:53 +00:00
8go
f4289a980a
tiny fixes
- 've ==> have ==> because it is more formal
- ```-``` ==> , ==> because it is more formal
2020-07-01 15:06:31 +00:00
Andreas M. Antonopoulos
dda03ffa54 Chapter ready for review: node_client.asciidoc
Finished chapter by demonstrating a whole Lightning network with diverse nodes using docker-compose. Added exercises for the reader. Ready for review!
2020-06-27 10:54:28 -04:00
Andreas M. Antonopoulos
f0912b961b Chapter node_client: Eclair container and building from source 2020-06-26 09:51:40 -04:00
Andreas M. Antonopoulos
2baac1fc0a Chapter node_client: installing LND from source 2020-06-25 11:36:01 -04:00
Andreas M. Antonopoulos
548eb5ceb5 Docker basic commands, LND writeup, formatting 2020-06-23 10:27:06 -04:00
Andreas M. Antonopoulos
a07b6499e6 Chapter update: c-lightning container, docker network 2020-06-22 10:38:45 -04:00
Andreas M. Antonopoulos
ac89953e7e Nodes: docker interaction 2020-06-20 11:19:52 -04:00
Andreas M. Antonopoulos
6a90b945bc Chapter update: bitcoind docker container, building and running 2020-06-19 10:50:31 -04:00