2
0
mirror of https://github.com/lnbook/lnbook synced 2024-11-08 19:10:35 +00:00
Commit Graph

635 Commits

Author SHA1 Message Date
Hugo Doyon
60a2513cfb
lose instead of loose
lose instead of loose
2020-05-14 13:19:38 -04:00
Hugo Doyon
da006d423f
publicly insteat of pubicly
publicly insteat of pubicly
2020-05-14 13:17:49 -04:00
Rene Pichardt
a4aa839529 saving stub for onion routing. being stuck at deciding which detail level I should aim. It is tempting to include shared secrete generation for the paths including computation of blinding factors of ephemeral keys. While I believe it would be highly instructional and edcuational it is kind of a random deep dive into standard cryptographic methods 2020-05-12 21:03:16 +02:00
Or Neeman
b2848b25a5 Fix 'loose' vs 'lose' mistakes 2020-05-12 11:39:10 -06:00
Andreas M. Antonopoulos
61be3679ca README - Status by section and wordcount 2020-05-11 12:27:49 -04:00
Andreas M. Antonopoulos
8ee334633f New README with status 2020-05-11 11:48:47 -04:00
Andreas M. Antonopoulos
578f38e12b
Merge pull request #223 from HugoDoyon/patch-10
Minor correction
2020-05-10 15:06:07 -04:00
Andreas M. Antonopoulos
7f211229e3
Merge branch 'develop' into patch-10 2020-05-10 15:05:58 -04:00
Andreas M. Antonopoulos
2d2f7285d1
Merge pull request #222 from HugoDoyon/patch-9
Minor correction when"S"
2020-05-10 15:04:57 -04:00
Andreas M. Antonopoulos
991398f494
Merge pull request #221 from HugoDoyon/patch-7
Implicitly (Minor correction)
2020-05-10 15:04:51 -04:00
Andreas M. Antonopoulos
d3d464c4b7
Merge pull request #220 from HugoDoyon/patch-6
then
2020-05-10 15:04:30 -04:00
Andreas M. Antonopoulos
7a75a84ba9
Merge pull request #219 from Roasbeef/chapter-outlines
multi: add skeleton chapter outlines
2020-05-10 15:04:11 -04:00
Hugo Doyon
5c0b883a93
Minor correction
"anormality" should be written "abnormality"
2020-05-06 10:59:39 -04:00
Hugo Doyon
0c5a5a0468
Minor correction when"S"
When does not need "s"
2020-05-06 10:57:39 -04:00
Hugo Doyon
89cee83f81
Implicitly (Minor correction)
"implicitely" should be "implicitly"
2020-05-06 10:53:27 -04:00
Hugo Doyon
27046411dd
then
Instead of "theh", should be writtent "then"
2020-05-06 10:50:56 -04:00
Olaoluwa Osuntokun
6e5f246552 fixup! chp2p: add chapter outline for p2p chapter 2020-05-05 21:06:33 -07:00
Olaoluwa Osuntokun
454d86c432
ch-e2e: add chapter overview 2020-05-05 21:01:31 -07:00
Olaoluwa Osuntokun
96fbd84587
ch-path-finding: add chapter overview 2020-05-05 20:58:00 -07:00
Olaoluwa Osuntokun
cce7ada5b7
ch-channel-graph: add chapter overview 2020-05-05 20:52:38 -07:00
Olaoluwa Osuntokun
e3ccdee02c
ch-htlc-forwarding: add chapter overview 2020-05-05 20:46:48 -07:00
Olaoluwa Osuntokun
c5c686cdb2
ch-chan-link: add chapter overview 2020-05-05 20:39:26 -07:00
Olaoluwa Osuntokun
7a0f824d51
chp2p: add chapter outline for p2p chapter 2020-05-05 20:25:05 -07:00
8go
cba3c55ff8
ch3: minor improvements to chapter "Thoughts about Trust"
- principal --> Major
- I would not call cost a risk. The opening fee IMHO is not a risk, it is simply a cost.
- commas
- in reference to time "immediately" better than "directly"
- added another example, to explain when not to create a channel
2020-05-05 19:50:23 -07:00
Andrea Cabral
5870e433c5
ch1+ch3: fix small typos 2020-05-05 19:48:46 -07:00
Olaoluwa Osuntokun
526be60ded
Merge pull request #216 from HugoDoyon/patch-5
feasable?
2020-05-05 19:41:45 -07:00
Olaoluwa Osuntokun
a42827c2a7
Merge pull request #215 from HugoDoyon/patch-4
Typos
2020-05-05 19:41:13 -07:00
Olaoluwa Osuntokun
75c2ebc9b0
Merge pull request #214 from HugoDoyon/patch-3
Learn and comma
2020-05-05 19:40:48 -07:00
Olaoluwa Osuntokun
e26eeb29ea
Merge pull request #209 from 8go/patch-35
addition to chapter "Comparison with Bitcoin" part 6
2020-05-05 19:38:09 -07:00
Olaoluwa Osuntokun
a349340160
Merge pull request #205 from 8go/patch-30
minor improvements to chapter "Comparison with Bitcoin" part 2
2020-05-05 19:32:52 -07:00
Olaoluwa Osuntokun
dbf37bdfe5
Merge pull request #204 from 8go/patch-29
minor improvements to chapter "Comparison with Bitcoin" part 1
2020-05-05 19:31:13 -07:00
Hugo Doyon
d17df44749
feasable?
feasible (typo)
2020-04-25 10:35:21 -04:00
Hugo Doyon
da50feeb3b
Typos
challanges & whith should be written: challenges and with
2020-04-24 12:06:35 -04:00
Hugo Doyon
a70fe1c24f
Learn and comma
Laern instead of Lear
2020-04-24 12:03:02 -04:00
Hugo Doyon
5bb60a65c6
typo (#212)
inormation should be in"f"ormation
2020-04-23 10:34:49 +02:00
Hugo Doyon
453606a107
Terrabyte sould be Terabyte (#211)
Typo
2020-04-23 10:30:00 +02:00
8go
f4688b692b
addition to chapter "Comparison with Bitcoin" part 6
- added new chapter
2020-04-22 19:16:22 +00:00
8go
5f876a4c59
minor improvements to chapter "Comparison with Bitcoin" part 2
- more details
- etc
2020-04-22 17:07:46 +00:00
Rene Pickhardt
43ce57298b
fix htlc typo that came in through find and replace 2020-04-22 19:04:59 +02:00
8go
e8bb86d45c
minor improvements to chapter "Comparison with Bitcoin" part 1
- no commas when subject is the same on both parts of sentence
- nothing seems to be gained by introducing concept of "traffic" --> removed it
- instead explained what the scarce resources are
- more explanations
- etc.
2020-04-22 16:56:13 +00:00
8go
3bfca36de6
minor improvements to chapter "Examining the ugly way" (#194)
- again, avoid extreme terms like "really high" that cannot be quantified.
- you do not gain the entire channel capacity, gain means "benefit", if 9 mBTC out of the 10 mBTC channel capacity were yours anyway, you would GET 10 mBTC but only GAIN 1 mBTC.
- additions
- mention of game theory
- etc
2020-04-22 18:54:20 +02:00
8go
1c3f3d7f52
minor improvements to chapter "Examining the bad way" (#193)
- simplified
- reduced sentence length
- comma after thus
- with respect to time "immediately" is better than "directly"
- avoid extremes, replaced "much higher" with "higher", later we specify the figure 5x anyway
- "additional" better than "more" 
- misc clarifications
- some additions
- etc
2020-04-22 18:51:56 +02:00
8go
a7f830d7f1
minor improvements to chapter "Examining the good way - mutual close" (#192)
- closing tx, shutdown tx, etc:  to avoid any confusion I took the "shutdown tx" out and simply named it the "on-chain tx"
- replaced "party" with "channel partner" for consistency
- removed "as many people think". If the book does a good job, not many people will think that ! In any case, this phrase does not help. Better to just state the facts. 
- etc
2020-04-22 18:49:59 +02:00
8go
ee3164c398
minor improvements to chapter "Closing the channel" (#191)
- Bitcoin: uppercase as it refers to fees on the Bitcoin protocol
- added more detail on importance of longevity of channel
- the last sentence was way too long and too complicated. restructured it.
- etc
2020-04-22 18:48:45 +02:00
8go
66f730a077
minor improvements to "Announcing the channel" (#190)
- added distinction between "public" and "private" channel, added the 2 terms
- rename 2-2 to 2-out-of-2 for consistency and to make it clearer
- simplified a few sentences
- added a few additional clarifying words
- etc
2020-04-22 18:45:41 +02:00
8go
97c8927d66
improvements to chapter "Commitment Transaction", part 2 (#189)
- comma after however
- when referring to time "immediately" is better and more meaningful than "directly"
- when referring to time duration "lasts" is better than "is"
- consistency: "channel partner" better than "party"
- etc
2020-04-22 18:40:14 +02:00
8go
05f8370259
Improvements to chapter "Commitment Transaction" (#188)
- replace "capacity" with "funds to reduce tech jargon
- replaced 2-2 with 2-out-of-2 for consistency and to clarify
- everyone --> singular  .. its funds .. not their funds
- "wallet" wrong, "address" better
- avoid "flaw", it might get misinterpreted, rephrased to clearly state that we present the design step-by-step
- "you probably have realized" and "hope you recognize that" puts the reader in a bind. If the reader does not see the problem we will feel "dumb" because the text implies "probably you realized". I suggest to rewrite it so, that the reader does not feel "dumb" just because he does not see the shortcut. --> see changes
- however requires comma
- avoid extremes like "rather high", use facts and measurable units, here simply "high"
- "to lose funds" incorrect, "loose" is correct
- took one long sentence and split it up into several short one making understanding a lot simpler
- etc
2020-04-22 18:38:13 +02:00
8go
af6b431265
added contributor name (#195)
+1 line  :)
2020-04-22 18:32:21 +02:00
8go
5b3a4ab256
minor improvements to chapter "Payment Hash" and "Additional Meta Data" (#198)
- repeated use of "also", --> furthermore, ...
- minor clarifications
- etc
2020-04-22 18:25:25 +02:00
8go
114387e822
minor improvements to chapter "Delivering the payment" (#199)
- peer-to-peer better than "peer 2 peer" , in acronyms p2p is ok
- English language guidelines recommend numbers up to 12 to be spelled out. 4 --> four
- minor additions/clarifications
2020-04-22 18:22:24 +02:00