Commit Graph

72 Commits (68e8d2fbb307df1b626e65e9202203da05ce5f45)

Author SHA1 Message Date
8go 763ea48fc7
Last part of node_client: English touch ups (#348)
- 10 cents, hence 10 satoshis (different is : a 10 cent coin, a 20 dollar suit), but in an amount: use plural: one dollar and 32 cents. Here 10,000 satoshiS (s)
- "a bunch of", very colloquial, --> "several"
- Oxford comma in list of 3 or more
- "funny" --> "unusual"
- "could" --> "can", more encouraging
- "cheap long" and "expensive short" --> add comma, comma should be placed between two adjectives of equal rank
- "it's own" (incorrect) --> its (possessive)
- "explore and dig deeper" (one does not explore deeper) --> explore further and dig deeper
4 years ago
TS 6dbb07f482 update the commands for the channel establishment and payment within the text 4 years ago
TS dab18f48fd adds parenthesis in the `docker-compose exec` , such that the command behind pipe is exectued within the container 4 years ago
Andreas M. Antonopoulos 89559bfb8f
Merge pull request #346 from 8go/patch-80
Eclair: English touch ups, commas
4 years ago
Andreas M. Antonopoulos a3bacdc724
Merge pull request #345 from 8go/patch-79
Eclair: English touch ups
4 years ago
Andreas M. Antonopoulos 915ebc195a
Merge pull request #343 from 8go/patch-78
LND: more English fixes, 1 error
4 years ago
Andreas M. Antonopoulos bc54811d12
Merge pull request #341 from 8go/patch-77
LND: typos, touch ups, English, etc.
4 years ago
8go 8c853ee92c
Complete Network, part 1: English touch ups
- Oxford comma for consistency (see PR #340)
- sentence restructuring (one does not compose by routing a payment)
- no comma in list of 2
- only the top of the config is listed, we should say so. --> The top looks like ...
- in most cases, no comma before "because" or "since", exceptions apply
- it's (wrong) --> its (possessive)
4 years ago
8go a77e4161c4
Eclair: English touch ups, commas
- commas
- reorg of sentences
- "Check to..." sentence is copy-paste from above, changed it slightly to avoid repetition
- OK, Eclair is uppercase, but here we refer to a directory which is lowercase, so "eclair" (just because it is the lowercase name of the dir)
- etc
4 years ago
8go 90836468d0
Eclair: English touch ups
- commas
- "by this point" --> "at this point" or "by this time". Maybe best "by now"
- "... you have seen previously to build the Eclair container" is ambiguous. Rephrased
- "directly" .... word order
- it's: incorrect,  --> its
- "unlike the LND or c-lightning containers": did not read well, reordered sub-phrases
- eclair vs Eclair: ok, the logo is lower cased. But when you read their https://github.com/ACINQ/eclair page ALL occurrences of Eclair are UPPERCASED.
- Based on their own use of "Eclair" in English text I have upper-cased all "Eclair" occurrences 
- up to line 779 it was already upper-case, then suddenly it was lower-case
- rephrasing
- etc
4 years ago
8go ac2ec76dd4
LND: more English fixes, 1 error
- again commas
- sentence simplifications
- typo
- "at minimum" : that's wrong, "at a minimum", "at least" but I rephrased anyway to avoid it altogether because it does not read well in any case due to the following "or later"
- "distributed" repetitive, changed to "available"
- "It doesn't matter where the GOPATH points" ... this is misleading or could be misunderstood. I rephrased.
- ERROR: "git clone" should be "go get"
4 years ago
8go 06b8a2f38e
more touch ups, English, commas (#340)
- replaced ", as is often the case," with "common"
- "prerequisite" has no hyphen
- in most cases no comma in front of "which"
- replaced "that we can do" with "available"
- if there is a list of 3 choices, one can place (optional) a comma before the "and". This is called the Oxford comma. It is optional, but it should be used consistently, always in the book or never. Since above it was used, I set it below as well.
- replaced "aggressively" with "heavily", we are not aggressive :)
- etc.
4 years ago
8go fd9635d345
minor touch up, English corrections (#338)
- usually there is no comma in front of because, as, etc. (exceptions exist)
- other commas
- "Let's" sounds very colloquial. It shows up a lot. In a couple of locations I replaced it with "let us" to make it a bit more formal, but I did not want to replace all. Maybe colloquialisms create some closeness to the reader.
- "also" seemed out of place
- local area network  has no hyphen
- "not important, but has ...": either no comma   or   a subject (it) has to be added after "but"
- "like this" was also a bit repetitive, I replaced it once with "as follows"
4 years ago
8go cee0dfe142
LND: typos, touch ups, English, etc.
- no comma in front of "and" in a list of 2
- same for "or" in list of 2
- list of 3: yes, we want a comma there to be consistent (Oxford comma, see PR #340 
- many many --> many
4 years ago
Andreas M. Antonopoulos 27bb45b5c3
Merge branch 'develop' into typos-and-small-fix 4 years ago
Andreas M. Antonopoulos d74ab8293c
Merge pull request #319 from vnprc/develop
code, spelling and grammar fixes for node_client chapter
4 years ago
Andreas M. Antonopoulos 23a1acf634
Merge pull request #303 from 8go/patch-74
simplifications
4 years ago
Andreas M. Antonopoulos dc77a9ea00
Merge pull request #302 from 8go/patch-73
rephrase the pipe explanation
4 years ago
Andreas M. Antonopoulos 32684a1462
Merge pull request #301 from 8go/patch-72
commas, formats, it's vs its
4 years ago
Andreas M. Antonopoulos 83f3c0b380
Merge pull request #300 from 8go/patch-71
commas, formatting
4 years ago
Andreas M. Antonopoulos 48307f2065
Merge pull request #299 from 8go/patch-70
tiny English improvements 5, commas
4 years ago
Andreas M. Antonopoulos ca8497fce9
Merge pull request #297 from 8go/patch-69
English improvements 4
4 years ago
Andreas M. Antonopoulos b464a16338
Merge pull request #296 from 8go/patch-68
tiny English improvements 3
4 years ago
Andreas M. Antonopoulos ef299263c3
Merge pull request #295 from 8go/patch-67
updated TIP box
4 years ago
Trigger 326c95ac4c Node client - Installing go in 20.04 is easier 4 years ago
Trigger 9a632006ff Node client - Add missing line break causing an error 4 years ago
Trigger 655b3acca8 Update ubuntu LTS to 20.04 4 years ago
Francisco Calderón 9044787d57
Fixes some typos 4 years ago
evan 94a1395925 use correct mvn -v flag, not mvn -V 4 years ago
evan 3a1103136a spelling and formatting fixes 4 years ago
evan 4b6c3c34d1 add missing newline to fix broken apt-get command 4 years ago
evan c213590a1d run jq on docker instance using bash -c args 4 years ago
8go 2aa2c0967d
simplifications 4 years ago
8go f795ae82da
rephrase the pipe explanation
- added "simulated" to make sure readers understand that they are not mining real blocks
- 1st --> first, general guideline is to spell numbers up to 12 out
- "now" ==> used twice ==> repetitive ==> removed second "now"
- "refer to" ==> "by some name"
- removed also
4 years ago
8go c1d038a6c1
commas, formats, it's vs its
- also ==> there is reference point to this "also", removed
- comma
- lightning ==> Lightning
- another comma
- It's ==> wrong ==> Its
4 years ago
8go d762886a4b
commas, formatting 4 years ago
8go a31016841d
tiny English improvements 5, commas
- comma ... no comma in front of "for"
- which, which   ... repetitive, improved
- comma
- instructions to install ==> installation instructions
- another comma
4 years ago
8go f6a740ac10
Update node_client.asciidoc
- "not worry" ==> "need not worry"
- removed ( ) ==> replaced with "i.e." to make it more formal
- "we want to work with a distribution that is familiar to many developers" ==> not correct linguistically; "familiar with" is better English than "familiar to"; this should be changed. I took this as reason to rephrase the whole sentence.
- "beneath" ==> "as can be seen below"
4 years ago
8go 792f8d6896
tiny English improvements 3
- putting emphasis on repository being online
- "the" article required in this case
- removed "version" from "ebook version" to simplify
- green: work order corrected
- no comma with "..., to"
4 years ago
8go 7d9d320552
updated TIP box
- to make it even easier to understand for noobies
4 years ago
Andreas M. Antonopoulos 1db4e55110
Merge pull request #294 from 8go/patch-65
tiny English improvements
4 years ago
Andreas M. Antonopoulos b19836953b
Merge branch 'develop' into patch-64 4 years ago
8go de586c676f
tiny English improvements
- removed ( ) and replaced it with "or" ... better style
- added 2 words to make it read better
- restructured a sentence 
- plural seems more appropriate
4 years ago
8go 99a3f85c10
tiny English improvements
- Similarily ==> correspondingly   ... fits the meaning better
- show ==> present ... more elegant
- BOLTS ==> BOLT standards ... to make it more clear to the novice reader
- removed comma ... no comma when subject is same in both parts of sentence
- recommend ==> endorse ... better, recommend one over the other is at best used colloquially
4 years ago
8go f4289a980a
tiny fixes
- 've ==> have ==> because it is more formal
- ```-``` ==> , ==> because it is more formal
4 years ago
Andreas M. Antonopoulos dda03ffa54 Chapter ready for review: node_client.asciidoc
Finished chapter by demonstrating a whole Lightning network with diverse nodes using docker-compose. Added exercises for the reader. Ready for review!
4 years ago
Andreas M. Antonopoulos f0912b961b Chapter node_client: Eclair container and building from source 4 years ago
Andreas M. Antonopoulos 2baac1fc0a Chapter node_client: installing LND from source 4 years ago
Andreas M. Antonopoulos 548eb5ceb5 Docker basic commands, LND writeup, formatting 4 years ago
Andreas M. Antonopoulos a07b6499e6 Chapter update: c-lightning container, docker network 4 years ago