2
0
mirror of https://github.com/lnbook/lnbook synced 2024-11-15 00:15:05 +00:00
Commit Graph

42 Commits

Author SHA1 Message Date
Nick Adams
ad813f1ebe renaming draft figs 2021-09-23 13:54:29 -04:00
Andreas M. Antonopoulos
635a3f28b7 Merge branch 'develop' 2021-09-21 17:15:01 +02:00
Andreas M. Antonopoulos
b84990da34 fix broken refs 3 2021-09-21 14:57:42 +02:00
Andreas M. Antonopoulos
d44cd74156 fix broken refs 1 2021-09-21 13:55:53 +02:00
randy808
01b7bc9ba6 Made small grammar corrections to chapters 7, 8, 9, 10, and 11. 2021-09-17 09:19:21 -04:00
Olaoluwa Osuntokun
3f8dbf46e5
ch-07: add caveat re 3rd party malleability and segwit 2021-09-16 20:01:25 -07:00
Olaoluwa Osuntokun
871772590c
ch-07: add caveat re indefinite lifetime channels w/o a mal fix 2021-09-16 20:01:23 -07:00
Olaoluwa Osuntokun
b92856f2c5
ch-07: mention that CL implements dual-funded channels 2021-09-16 20:01:20 -07:00
Olaoluwa Osuntokun
4d8495e9ad
Merge pull request #755 from Roasbeef/revocation-key-derivation
ch-07: construct revocation key derivation from first principles
2021-09-16 18:57:58 -07:00
Stephen DeLorme
6064c6b6f3
Grammar fix (#844) 2021-09-15 18:43:27 +02:00
Stephen DeLorme
8f5ce3d52b
Typo fix (#843)
Co-authored-by: Rene Pickhardt <rene@rene-pickhardt.de>
2021-09-15 18:43:02 +02:00
Owen Gunden
449cd73251
grammar fix (#799) 2021-09-10 20:49:03 +02:00
Owen Gunden
8c08e7662c
fix typo (#798) 2021-09-10 20:48:46 +02:00
Owen Gunden
1efaf8ede1
capitalization fix (#791) 2021-09-10 20:43:57 +02:00
Owen Gunden
540342418e
typo fix (#790) 2021-09-10 20:43:40 +02:00
Owen Gunden
c5fbe0a32c
grammatical fixes (#788) 2021-09-10 20:42:38 +02:00
Patrick Lemke
8c8f960528
fix typo brackets (#783) 2021-09-10 20:38:27 +02:00
Olaoluwa Osuntokun
7c7bf21359
ch-07: construct revocation key derivation from first principles
In this commit, we attempt to construct the derivation method we used to
derive the revocation keys from first principles. This explanation was
inspired by a conversation with Rene, leading to a sort of Socratic
method explanation w.r.t why the remote party cannot be allowed to
unilaterally sign with the revocation public key.

This initial draft explanation is a bit too technical IMO, but it's
unclear how much prior knowledge we can expect from the reader and/or
how much space we should devote for explaining this little trick.

One thing we may want to do is use some shorter variable names (defined
earlier) to make this section a bit more compact.
2021-08-17 18:51:37 -07:00
kristen@oreilly.com
f030bcfc66 Edited 07_payment_channels.asciidoc with Atlas code editor 2021-08-10 07:25:23 -07:00
mknoszlig
d88acf5585
Ch07: Typos, fixes and attempts at improving clarity (#752)
* fix link.

* some typos, punctuation and attempts at improving clarity.
2021-07-23 10:31:53 +02:00
François Degros
231ae4459f
Fix a couple of typos (#748)
* Add name to contributors in preface

* Add missing word

* Remove extraneous word

"being in used" -> "being used"
2021-07-23 10:24:26 +02:00
mknoszlig
bdfb00479e
short explanation of channel_reserve and its role in commitment tx (#754) 2021-07-23 10:00:57 +02:00
Olaoluwa Osuntokun
8cca51da73
ch-07: mention upfront shutdown scripts in co-op close section
We haven't described the set of TLV fields here used in the modern
protocol though, so we may want to enumerate all the fields used as the
top to provide more context. Alternatively, we can house them all in a
sort of  index chapter and refer to that instead.
2021-07-11 18:20:40 -07:00
Olaoluwa Osuntokun
5a4483bdaa
ch-07: describe the use of state hints in breach revocation
Could possibly be moved up to the section describing funding, as both
sides need to be able to derive the proper state hints to arrive at the
same set of commitment transactions.
2021-07-11 18:20:34 -07:00
Olaoluwa Osuntokun
ef61f03939
ch-07: mention asymmetric commitments is for ascribing blame 2021-07-11 18:20:31 -07:00
Olaoluwa Osuntokun
3e69fa297d
ch-07: add more precise algo for generating a chan_id 2021-07-11 18:20:27 -07:00
Olaoluwa Osuntokun
0ab01e51cc
ch-07: use more precise description of segwit w.r.t transaciton malleability 2021-07-11 18:20:24 -07:00
Olaoluwa Osuntokun
13933cc194
ch-07: mention sorting of funding keys for multi-sig witness script 2021-07-11 18:20:21 -07:00
Olaoluwa Osuntokun
5e0229160e
ch-07: mention asymmetry w.r.t interpretation of to_self_delay field
A party can't pick its to_self_delay (the CSV delay) itself, as that
would mean they can set it to effectively zero and be able to breach at
will. Instead, both sides propose a CSV delay for the other, effectively
enforcing time delay that allows them to act in the face of a breach.
2021-07-11 18:20:18 -07:00
Olaoluwa Osuntokun
567254ac9a
ch-07: typo fix in warning for push_msat field 2021-07-11 18:20:15 -07:00
Olaoluwa Osuntokun
f34f8e6995
ch-07: qualify what "sufficient confirmations" is for chan funding 2021-07-11 18:20:12 -07:00
Olaoluwa Osuntokun
4c205376b5
ch-07: mention commitment tx as synonym for refund transaction 2021-07-11 18:20:09 -07:00
Olaoluwa Osuntokun
999aff3de8
ch-07: use unaffiliated public key for node URI example
Similar to the prior commit, here we remove another piece of personally
identifiable information: the public key of Rene's known (?) routing
node on the public network.
2021-07-11 18:20:07 -07:00
Olaoluwa Osuntokun
ea04f6c633
ch-07: use a private IP addr for example node IP
As is the chapter uses 144.76.235.20 which has a PTR DNS record to
rene-pickhardt.de. Rather than include possibly private information
relating to the authors of the book, we opt to use an IP address from a
known private range. This doesn't take away from the example, but lets
us include less personally identifying information in the book.
2021-07-11 18:20:03 -07:00
Pamela Morgan
8da2d02a9b
Update 07_payment_channels.asciidoc
Very small changes to grammar and wording
2021-07-11 14:12:01 +02:00
Andreas M. Antonopoulos
7adcad07ef Added TIP on relative timelocks 2021-06-29 10:28:45 -04:00
Andreas M. Antonopoulos
2be166fc46 edits and spelling 2021-06-29 10:28:45 -04:00
Andreas M. Antonopoulos
9456b2358a edits 2021-06-29 10:28:45 -04:00
Rene Pickhardt
40680eb902 added a few more notes to the second have of the chapter 2021-06-29 10:28:45 -04:00
Rene Pickhardt
b15d093ebb added a few fixes and additional info for the funding flow
I think it might be best to stick to most of them
2021-06-29 10:28:45 -04:00
Rene Pickhardt
374113103c few additions to up until constructing the channel
Most additions make the text more complex but sometimes it seemed the additional detail was preferable?
2021-06-29 10:28:45 -04:00
Andreas M. Antonopoulos
1a4a4bf708 cleanup and reorg of chapters, README updated 2021-06-29 10:28:45 -04:00