Archives
/
lnav
mirror of https://github.com/tstack/lnav
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[cleanup] uncrustify

Browse Source
pull/69/head
Timothy Stack 11 years ago
parent eee43efd5a
commit 5a7d6dab2c
45 changed files with 691 additions and 562 deletions
Show Stats Download Patch File Download Diff File

2
lnav.cfg
Unescape Escape View File

@ -66,7 +66,7 @@ indent_sing_line_comments = 0 # number
indent_switch_case = 0 # number
# Spaces to indent 'case' body from 'case'
indent_case_body = 0 # number
indent_case_body = 4 # number
# Spaces to indent '{' from 'case'
indent_case_brace = 0 # number

1
src/ansi_scrubber.cc
Unescape Escape View File

@ -48,6 +48,7 @@ static pcrepp &ansi_regex(void)
void scrub_ansi_string(std::string &str, string_attrs_t &sa)
{
view_colors &vc = view_colors::singleton();
vector<pair<string, string_attr_t> > attr_queue;
pcre_context_static<60> context;
vector<line_range> range_queue;

1
src/ansi_scrubber.hh
Unescape Escape View File

@ -49,5 +49,4 @@
* @param sa The container for any style attributes.
*/
void scrub_ansi_string(std::string &str, string_attrs_t &sa);
#endif

6
src/auto_mem.hh
Unescape Escape View File

@ -101,8 +101,9 @@ public:
void reset(T *ptr = NULL)
{
if (this->am_ptr != ptr) {
if (this->am_ptr != NULL)
if (this->am_ptr != NULL) {
this->am_free_func(this->am_ptr);
}
this->am_ptr = ptr;
}
};
@ -115,7 +116,8 @@ private:
template<typename T, void(*free_func) (T *)>
class static_root_mem {
public:
static_root_mem() {
static_root_mem()
{
memset(&this->srm_value, 0, sizeof(T));
};

3
src/bottom_status_source.hh
Unescape Escape View File

@ -96,7 +96,8 @@ public:
status_field &get_field(field_t id) { return this->bss_fields[id]; };
void set_prompt(const std::string &prompt) {
void set_prompt(const std::string &prompt)
{
this->bss_prompt.set_value(prompt);
};

9
src/byte_array.hh
Unescape Escape View File

@ -55,11 +55,13 @@ struct byte_array {
return memcmp(this->ba_data, other.ba_data, BYTE_COUNT) != 0;
};
void clear(void) {
void clear(void)
{
memset(this->ba_data, 0, BYTE_COUNT);
};
void to_string(char *buffer) const {
void to_string(char *buffer) const
{
assert(buffer != NULL);
for (size_t lpc = 0; lpc < BYTE_COUNT; lpc++) {
@ -67,7 +69,8 @@ struct byte_array {
}
};
std::string to_string() const {
std::string to_string() const
{
char buffer[BYTE_COUNT * 2 + 1];
this->to_string(buffer);

3
src/collation-functions.cc
Unescape Escape View File

@ -156,7 +156,8 @@ int sql_strnatcasecmp(void *ptr,
int register_collation_functions(sqlite3 *db)
{
sqlite3_create_collation(db, "ipaddress", SQLITE_UTF8, NULL, ipaddress);
sqlite3_create_collation(db, "naturalcase", SQLITE_UTF8, NULL, sql_strnatcmp);
sqlite3_create_collation(db, "naturalcase", SQLITE_UTF8, NULL,
sql_strnatcmp);
sqlite3_create_collation(db, "naturalnocase", SQLITE_UTF8, NULL,
sql_strnatcasecmp);

7
src/data_parser.cc
Unescape Escape View File

@ -62,15 +62,18 @@ data_format_state_t dfs_prefix_next(data_format_state_t state,
case DT_LANGLE:
case DT_RANGLE:
break;
default:
retval = DFS_ERROR;
break;
}
break;
case DFS_EXPECTING_SEP:
case DFS_ERROR:
retval = DFS_ERROR;
break;
default:
break;
}
@ -130,6 +133,7 @@ data_format_state_t dfs_comma_next(data_format_state_t state,
switch (next_token) {
case DT_COMMA:
break;
case DT_SEMI:
retval = DFS_ERROR;
break;
@ -161,15 +165,18 @@ data_format_state_t dfs_comma_next(data_format_state_t state,
default: break;
}
break;
case DFS_EXPECTING_SEP:
switch (next_token) {
case DT_SEPARATOR:
retval = DFS_VALUE;
break;
case DT_COMMA:
case DT_SEMI:
retval = DFS_ERROR;
break;
default: break;
}
break;

59
src/data_parser.hh
Unescape Escape View File

@ -114,7 +114,8 @@
#define PUSH_BACK(elem) push_back(elem, __FILE__, __LINE__)
#define POP_FRONT(elem) pop_front(__FILE__, __LINE__)
#define POP_BACK(elem) pop_back(__FILE__, __LINE__)
#define SPLICE(pos, other, first, last) splice(pos, other, first, last, __FILE__, __LINE__)
#define SPLICE(pos, other, first, last) splice(pos, other, first, last, \
__FILE__, __LINE__)
template<class Container, class UnaryPredicate>
void strip(Container &container, UnaryPredicate p)
@ -238,15 +239,17 @@ public:
typedef byte_array<SHA_DIGEST_LENGTH> schema_id_t;
struct element;
// typedef std::list<element> element_list_t;
/* typedef std::list<element> element_list_t; */
class element_list_t : public std::list<element> {
public:
element_list_t(const char *varname, const char *fn, int line) {
element_list_t(const char *varname, const char *fn, int line)
{
LIST_INIT_TRACE;
}
element_list_t() {
element_list_t()
{
const char *varname = "_anon2_";
const char *fn = __FILE__;
int line = __LINE__;
@ -254,26 +257,30 @@ public:
LIST_INIT_TRACE;
};
~element_list_t() {
~element_list_t()
{
const char *fn = __FILE__;
int line = __LINE__;
LIST_DEINIT_TRACE;
};
void push_back(const element &elem, const char *fn, int line) {
void push_back(const element &elem, const char *fn, int line)
{
ELEMENT_TRACE;
this->std::list<element>::push_back(elem);
};
void pop_front(const char *fn, int line) {
void pop_front(const char *fn, int line)
{
LIST_TRACE;
this->std::list<element>::pop_front();
};
void pop_back(const char *fn, int line) {
void pop_back(const char *fn, int line)
{
LIST_TRACE;
this->std::list<element>::pop_back();
@ -284,7 +291,8 @@ public:
iterator first,
iterator last,
const char *fn,
int line) {
int line)
{
SPLICE_TRACE;
this->std::list<element>::splice(pos, other, first, last);
@ -340,7 +348,8 @@ public:
void assign_elements(element_list_t &subs)
{
if (this->e_sub_elements == NULL) {
this->e_sub_elements = new element_list_t("_sub_", __FILE__, __LINE__);
this->e_sub_elements = new element_list_t("_sub_", __FILE__,
__LINE__);
}
this->e_sub_elements->swap(subs);
this->update_capture();
@ -356,7 +365,8 @@ public:
}
};
const element &get_pair_value(void) const {
const element & get_pair_value(void) const
{
assert(this->e_token == DNT_PAIR);
return this->e_sub_elements->back();
@ -452,7 +462,8 @@ private:
: dp_errors("dp_errors", __FILE__, __LINE__),
dp_pairs("dp_pairs", __FILE__, __LINE__),
dp_format(NULL),
dp_scanner(ds) {
dp_scanner(ds)
{
if (TRACE_FILE != NULL) {
fprintf(TRACE_FILE, "input %s\n", ds->get_input().get_string());
}
@ -461,7 +472,9 @@ private:
void pairup(schema_id_t *schema, element_list_t &pairs_out,
element_list_t &in_list)
{
element_list_t ELEMENT_LIST_T(el_stack), ELEMENT_LIST_T(free_row), ELEMENT_LIST_T(key_comps), ELEMENT_LIST_T(value), ELEMENT_LIST_T(prefix);
element_list_t ELEMENT_LIST_T(el_stack), ELEMENT_LIST_T(free_row),
ELEMENT_LIST_T(key_comps), ELEMENT_LIST_T(value),
ELEMENT_LIST_T(prefix);
SHA_CTX context;
POINT_TRACE("pairup_start");
@ -530,8 +543,8 @@ private:
if (el_stack.size() > 1 &&
this->dp_format->df_appender != DT_INVALID &&
this->dp_format->df_terminator != DT_INVALID) {
// If we're expecting a terminator and haven't found it
// then this is part of the value.
/* If we're expecting a terminator and haven't found it */
/* then this is part of the value. */
continue;
}
@ -601,7 +614,8 @@ private:
struct element blank;
blank.e_capture.c_begin = blank.e_capture.c_end =
el_stack.front().e_capture.c_begin;
el_stack.front().e_capture.
c_begin;
blank.e_token = DNT_KEY;
free_pair_subs.PUSH_BACK(blank);
free_pair_subs.PUSH_BACK(el_stack.front());
@ -637,7 +651,8 @@ private:
struct element blank;
blank.e_capture.c_begin = blank.e_capture.c_end =
free_row.front().e_capture.c_begin;
free_row.front().e_capture.
c_begin;
blank.e_token = DNT_KEY;
free_pair_subs.PUSH_BACK(blank);
free_pair_subs.PUSH_BACK(free_row.front());
@ -771,11 +786,13 @@ private:
semi_state = dfs_semi_next(semi_state, elem.e_token);
comma_state = dfs_comma_next(comma_state, elem.e_token);
if (prefix_state != DFS_ERROR) {
if (semi_state == DFS_ERROR)
if (semi_state == DFS_ERROR) {
semi_state = DFS_INIT;
if (comma_state == DFS_ERROR)
}
if (comma_state == DFS_ERROR) {
comma_state = DFS_INIT;
}
}
hist[elem.e_token] += 1;
switch (elem.e_token) {
case DT_LPAREN:
@ -783,7 +800,9 @@ private:
case DT_LCURLY:
case DT_LSQUARE:
this->dp_group_token.push_back(elem.e_token);
this->dp_group_stack.push_back(element_list_t("_anon_", __FILE__, __LINE__));
this->dp_group_stack.push_back(element_list_t("_anon_",
__FILE__,
__LINE__));
break;
case DT_RPAREN:

18
src/data_scanner.cc
Unescape Escape View File

@ -46,7 +46,8 @@ static struct {
"(?:u|r)?'((?:\\\\.|[^'])+)')"), },
{ "url", pcrepp("\\A([\\w]+://[^\\s'\"\\[\\](){}]+[a-zA-Z0-9\\-=&])"),
},
{ "path", pcrepp("\\A((?:/|\\./|\\.\\./)[\\w\\.\\-_\\~/]*)"), },
{ "path", pcrepp("\\A((?:/|\\./|\\.\\./)[\\w\\.\\-_\\~/]*)"),
},
{ "mac", pcrepp(
"\\A([0-9a-fA-F][0-9a-fA-F](?::[0-9a-fA-F][0-9a-fA-F]){5})"), },
{ "time", pcrepp(
@ -94,16 +95,17 @@ static struct {
{ "pcnt", pcrepp("\\A(-?[0-9]+(\\.[0-9]+)?[ ]*%\\b)"),
},
{ "num", pcrepp("\\A(-?[0-9]+(\\.[0-9]+)?([eE][-+][0-9]+)?)"
"\\b(?![\\._\\-][a-zA-Z])"),
},
"\\b(?![\\._\\-][a-zA-Z])"), },
{ "hex", pcrepp("\\A(-?(?:0x|[0-9])[0-9a-fA-F]+)"
"\\b(?![\\._\\-][a-zA-Z])"),
},
"\\b(?![\\._\\-][a-zA-Z])"), },
{ "mail", pcrepp("\\A([a-zA-Z0-9\\._%+-]+@[a-zA-Z0-9\\.-]+\\.[a-zA-Z]+)\\b"), },
{ "cnst", pcrepp("\\A(true|True|TRUE|false|False|FALSE|None|null)\\b") },
{ "mail", pcrepp(
"\\A([a-zA-Z0-9\\._%+-]+@[a-zA-Z0-9\\.-]+\\.[a-zA-Z]+)\\b"), },
{ "cnst",
pcrepp("\\A(true|True|TRUE|false|False|FALSE|None|null)\\b") },
{ "word", pcrepp(
"\\A([a-zA-Z][a-z']+(?=[\\s\\(\\)!\\*:;'\\\"\\?,]|[\\.\\!,\\?]\\s|$))"), },
"\\A([a-zA-Z][a-z']+(?=[\\s\\(\\)!\\*:;'\\\"\\?,]|[\\.\\!,\\?]\\s|$))"),
},
{ "sym", pcrepp(
"\\A([^\";\\s:=,\\(\\)\\{\\}\\[\\]\\+#!@%\\^&\\*'\\?<>\\~`\\|\\\\]+"
"(?:::[^\";\\s:=,\\(\\)\\{\\}\\[\\]\\+#!@%\\^&\\*'\\?<>\\~`\\|\\\\]+)*)"),

93
src/lnav.cc
Unescape Escape View File

@ -725,7 +725,8 @@ static bool append_default_files(lnav_flags_t flag)
perror("Unable to resolve path");
}
else {
lnav_data.ld_file_names.insert(make_pair(abspath.in(), -1));
lnav_data.ld_file_names.insert(make_pair(abspath.in(),
-1));
found = true;
}
}
@ -784,7 +785,9 @@ static void update_view_name(void)
sf.set_value("% 5s ", view_names[tc - lnav_data.ld_views]);
sf.get_value().get_attrs()[lr].insert(make_string_attr(
"style", A_REVERSE|COLOR_PAIR(view_colors::VC_BLUE_ON_WHITE)));
"style", A_REVERSE |
COLOR_PAIR(view_colors::
VC_BLUE_ON_WHITE)));
}
bool toggle_view(textview_curses *toggle_tc)
@ -1013,7 +1016,8 @@ static void handle_paging_key(int ch)
&logfile_sub_source::BM_ERRORS,
tc->get_top());
lnav_data.ld_rl_view->set_alt_value(HELP_MSG_2(
w, W, "to move forward/backward through warning messages"));
w, W,
"to move forward/backward through warning messages"));
break;
case 'E':
@ -1021,7 +1025,8 @@ static void handle_paging_key(int ch)
&logfile_sub_source::BM_ERRORS,
tc->get_top());
lnav_data.ld_rl_view->set_alt_value(HELP_MSG_2(
w, W, "to move forward/backward through warning messages"));
w, W,
"to move forward/backward through warning messages"));
break;
case 'w':
@ -1029,7 +1034,8 @@ static void handle_paging_key(int ch)
&logfile_sub_source::BM_WARNINGS,
tc->get_top());
lnav_data.ld_rl_view->set_alt_value(HELP_MSG_2(
o, O, "to move forward/backward an hour"));
o, O,
"to move forward/backward an hour"));
break;
case 'W':
@ -1037,7 +1043,8 @@ static void handle_paging_key(int ch)
&logfile_sub_source::BM_WARNINGS,
tc->get_top());
lnav_data.ld_rl_view->set_alt_value(HELP_MSG_2(
o, O, "to move forward/backward an hour"));
o, O,
"to move forward/backward an hour"));
break;
case 'n':
@ -1146,7 +1153,8 @@ static void handle_paging_key(int ch)
}
lnav_data.ld_rl_view->set_alt_value(HELP_MSG_1(
I, "to switch to the log view at the top displayed time"));
I,
"to switch to the log view at the top displayed time"));
}
break;
@ -1161,7 +1169,8 @@ static void handle_paging_key(int ch)
}
lnav_data.ld_rl_view->set_alt_value(HELP_MSG_1(
I, "to switch to the log view at the top displayed time"));
I,
"to switch to the log view at the top displayed time"));
}
break;
@ -1183,7 +1192,8 @@ static void handle_paging_key(int ch)
tc->reload_data();
lnav_data.ld_rl_view->set_alt_value(HELP_MSG_2(
u, U, "to move forward/backward through user bookmarks"));
u, U,
"to move forward/backward through user bookmarks"));
}
break;
@ -1214,7 +1224,8 @@ static void handle_paging_key(int ch)
tc->reload_data();
lnav_data.ld_rl_view->set_alt_value(HELP_MSG_1(
c, "to copy marked lines to the clipboard"));
c,
"to copy marked lines to the clipboard"));
}
break;
@ -1247,7 +1258,8 @@ static void handle_paging_key(int ch)
tc->reload_data();
lnav_data.ld_rl_view->set_alt_value(HELP_MSG_1(
c, "to copy marked lines to the clipboard"));
c,
"to copy marked lines to the clipboard"));
}
break;
@ -1409,7 +1421,8 @@ static void handle_paging_key(int ch)
textview_curses & log_view = lnav_data.ld_views[LNV_LOG];
content_line_t cl = lss.at(log_view.get_top());
logfile * lf = lss.find(cl);
std::string line = lf->read_line(lf->begin() + cl);
std::string line = lf->read_line(
lf->begin() + cl);
struct line_range body;
string_attrs_t sa;
std::vector<logline_value> line_values;
@ -1428,13 +1441,16 @@ static void handle_paging_key(int ch)
column_namer namer;
lnav_data.ld_rl_view->clear_possibilities(LNM_COMMAND, "colname");
for (data_parser::element_list_t::iterator iter = dp.dp_pairs.begin();
for (data_parser::element_list_t::iterator iter =
dp.dp_pairs.begin();
iter != dp.dp_pairs.end();
++iter) {
std::string colname = dp.get_element_string(iter->e_sub_elements->front());
std::string colname = dp.get_element_string(
iter->e_sub_elements->front());
colname = namer.add_column(colname);
lnav_data.ld_rl_view->add_possibility(LNM_COMMAND, "colname", colname);
lnav_data.ld_rl_view->add_possibility(LNM_COMMAND, "colname",
colname);
}
}
lnav_data.ld_mode = LNM_COMMAND;
@ -1493,7 +1509,8 @@ static void handle_paging_key(int ch)
}
else if (toggle_view(&lnav_data.ld_views[LNV_TEXT])) {
lnav_data.ld_rl_view->set_alt_value(HELP_MSG_2(
f, F, "to switch to the next/previous file"));
f, F,
"to switch to the next/previous file"));
}
break;
@ -1631,26 +1648,33 @@ static void handle_paging_key(int ch)
break;
case 'r':
lnav_data.ld_session_file_index = (lnav_data.ld_session_file_index + 1) %
lnav_data.ld_session_file_index =
(lnav_data.ld_session_file_index + 1) %
lnav_data.ld_session_file_names.size();
reset_session();
load_session();
rebuild_indexes(true);
break;
case 'R':
if (lnav_data.ld_session_file_index == 0)
lnav_data.ld_session_file_index = lnav_data.ld_session_file_names.size() - 1;
else
if (lnav_data.ld_session_file_index == 0) {
lnav_data.ld_session_file_index =
lnav_data.ld_session_file_names.size() - 1;
}
else{
lnav_data.ld_session_file_index -= 1;
}
reset_session();
load_session();
rebuild_indexes(true);
break;
case KEY_CTRL_R:
reset_session();
rebuild_indexes(true);
lnav_data.ld_rl_view->set_alt_value(HELP_MSG_2(
r, R, "to restore the next/previous session"));
r, R,
"to restore the next/previous session"));
break;
default:
@ -1846,9 +1870,9 @@ void execute_search(lnav_view_t view, const std::string &regex)
tc.set_follow_search(true);
auto_ptr<grep_highlighter> gh(new grep_highlighter(gp, "$search", hm));
auto_ptr<grep_highlighter> gh(new grep_highlighter(gp, "$search",
hm));
gc = gh;
}
}
@ -1893,8 +1917,7 @@ static void rl_search(void *dummy, readline_curses *rc)
grep_error(string("sql error: ") + string(errmsg));
}
else {
lnav_data.ld_bottom_source.
grep_error("");
lnav_data.ld_bottom_source.grep_error("");
}
}
return;
@ -1935,7 +1958,8 @@ static void rl_callback(void *dummy, readline_curses *rc)
add_possibility(LNM_COMMAND, "filter", rc->get_value());
rc->set_value("search: " + rc->get_value());
rc->set_alt_value(HELP_MSG_2(
n, N, "to move forward/backward through search results"));
n, N,
"to move forward/backward through search results"));
}
lnav_data.ld_mode = LNM_PAGING;
break;
@ -2011,7 +2035,8 @@ static void rl_callback(void *dummy, readline_curses *rc)
(int)dls.dls_rows.size());
rc->set_value(row_count);
rc->set_alt_value(HELP_MSG_2(
y, Y, "to move forward/backward through query results "
y, Y,
"to move forward/backward through query results "
"in the log view"));
}
else {
@ -2539,7 +2564,8 @@ static void looper(void)
rlc.set_perform_action(readline_curses::action(rl_callback));
rlc.set_timeout_action(readline_curses::action(rl_search));
rlc.set_alt_value(HELP_MSG_2(
e, E, "to move forward/backward through error messages"));
e, E,
"to move forward/backward through error messages"));
(void)curs_set(0);
@ -2677,9 +2703,8 @@ static void looper(void)
toggle_view(&lnav_data.ld_views[LNV_TEXT]);
lnav_data.ld_views[LNV_TEXT].set_top(vis_line_t(0));
lnav_data.ld_rl_view->set_alt_value(
HELP_MSG_2(f, F, "to switch to the next/previous file"));
HELP_MSG_2(f, F,
"to switch to the next/previous file"));
}
initial_build = true;
@ -2802,7 +2827,8 @@ public:
cols.push_back(vtab_column("cs_user_agent", SQLITE3_TEXT));
};
void get_foreign_keys(vector<string> &keys_inout) {
void get_foreign_keys(vector<string> &keys_inout)
{
this->log_vtab_impl::get_foreign_keys(keys_inout);
keys_inout.push_back("sc_status");
@ -2821,7 +2847,8 @@ public:
cols.push_back(vtab_column("log_pid", SQLITE_INTEGER));
};
void get_foreign_keys(vector<string> &keys_inout) {
void get_foreign_keys(vector<string> &keys_inout)
{
this->log_vtab_impl::get_foreign_keys(keys_inout);
keys_inout.push_back("log_pid");

1
src/lnav.hh
Unescape Escape View File

@ -190,5 +190,4 @@ bool setup_logline_table();
int sql_callback(sqlite3_stmt *stmt);
void execute_search(lnav_view_t view, const std::string &regex);
#endif

40
src/lnav_commands.cc
Unescape Escape View File

@ -168,17 +168,23 @@ static string com_save_to(string cmdline, vector<string> &args)
static_root_mem<wordexp_t, wordfree> wordmem;
switch (wordexp(args[1].c_str(), wordmem.inout(), WRDE_NOCMD|WRDE_UNDEF)) {
switch (wordexp(args[1].c_str(), wordmem.inout(), WRDE_NOCMD |
WRDE_UNDEF)) {
case WRDE_BADCHAR:
return "error: invalid filename character";
case WRDE_CMDSUB:
return "error: command substitution is not allowed";
case WRDE_BADVAL:
return "error: unknown environment variable in file name";
case WRDE_NOSPACE:
return "error: out of memory";
case WRDE_SYNTAX:
return "error: invalid syntax";
default:
break;
}
@ -344,10 +350,11 @@ public:
return retval;
};
std::string to_command(void) {
return ((this->lf_type == logfile_filter::INCLUDE ?
std::string to_command(void)
{
return (this->lf_type == logfile_filter::INCLUDE ?
"filter-in " : "filter-out ") +
this->lf_id);
this->lf_id;
};
protected:
@ -637,22 +644,25 @@ static string com_summarize(string cmdline, vector<string> &args)
for (std::vector<string>::iterator iter = other_columns.begin();
iter != other_columns.end();
++iter) {
if (iter != other_columns.begin())
if (iter != other_columns.begin()) {
query += ",";
}
query_frag = sqlite3_mprintf(" \"%s\", count(*) as \"count_%s\"",
iter->c_str(),
iter->c_str());
query += query_frag;
}
if (!other_columns.empty() && !num_columns.empty())
if (!other_columns.empty() && !num_columns.empty()) {
query += ", ";
}
for (std::vector<string>::iterator iter = num_columns.begin();
iter != num_columns.end();
++iter) {
if (iter != num_columns.begin())
if (iter != num_columns.begin()) {
query += ",";
}
query_frag = sqlite3_mprintf(" sum(\"%s\"), "
" min(\"%s\"), "
" avg(\"%s\"), "
@ -673,10 +683,12 @@ static string com_summarize(string cmdline, vector<string> &args)
for (std::vector<string>::iterator iter = other_columns.begin();
iter != other_columns.end();
++iter) {
if (iter == other_columns.begin())
if (iter == other_columns.begin()) {
query += " GROUP BY ";
else
}
else{
query += ",";
}
query_frag = sqlite3_mprintf(" \"%s\"", iter->c_str());
query += query_frag;
}
@ -684,10 +696,12 @@ static string com_summarize(string cmdline, vector<string> &args)
for (std::vector<string>::iterator iter = other_columns.begin();
iter != other_columns.end();
++iter) {
if (iter == other_columns.begin())
if (iter == other_columns.begin()) {
query += " ORDER BY ";
else
}
else{
query += ",";
}
query_frag = sqlite3_mprintf(" \"count_%s\" desc, \"%s\" asc",
iter->c_str(),
iter->c_str());
@ -769,9 +783,7 @@ static string com_add_test(string cmdline, vector<string> &args)
{
string retval = "";
if (args.size() == 0) {
}
if (args.size() == 0) {}
else if (args.size() > 1) {
retval = "error: not expecting any arguments";
}

1
src/lnav_config.hh
Unescape Escape View File

@ -58,5 +58,4 @@ bool check_experimental(const char *feature_name);
* Ensure that the '.lnav' directory exists.
*/
void ensure_dotlnav(void);
#endif

16
src/lnav_util.hh
Unescape Escape View File

@ -91,7 +91,8 @@ std::string time_ago(time_t last_time);
struct sha_updater {
sha_updater(SHA_CTX *context) : su_context(context) { };
void operator()(const std::string &str) {
void operator()(const std::string &str)
{
SHA_Update(this->su_context, str.c_str(), str.length());
}
@ -102,14 +103,12 @@ std::string hash_string(const std::string &str);
template<typename UnaryFunction, typename Member>
struct object_field_t {
object_field_t(UnaryFunction &func, Member &mem)
: of_func(func), of_mem(mem) {
};
: of_func(func), of_mem(mem) {};
template<typename Object>
void operator()(Object obj) {
void operator()(Object obj)
{
this->of_func(obj.*(this->of_mem));
};
@ -118,7 +117,9 @@ struct object_field_t {
};
template<typename UnaryFunction, typename Member>
object_field_t<UnaryFunction, Member> object_field(UnaryFunction &func, Member mem) {
object_field_t<UnaryFunction, Member> object_field(UnaryFunction &func,
Member mem)
{
return object_field_t<UnaryFunction, Member>(func, mem);
}
@ -135,5 +136,4 @@ enum file_format_t {
};
file_format_t detect_file_format(const std::string &filename);
#endif

8
src/log_data_table.hh
Unescape Escape View File

@ -47,7 +47,8 @@
class log_data_table : public log_vtab_impl {
public:
log_data_table(content_line_t template_line, std::string table_name="logline")
log_data_table(content_line_t template_line,
std::string table_name = "logline")
: log_vtab_impl(table_name),
ldt_template_line(template_line) {};
@ -148,8 +149,8 @@ public:
lf_iter->set_schema(dp.dp_schema_id);
// The cached schema ID in the log line is not complete, so we still
// need to check for a full match.
/* The cached schema ID in the log line is not complete, so we still */
/* need to check for a full match. */
if (dp.dp_schema_id != this->ldt_schema_id) {
return false;
}
@ -180,6 +181,7 @@ public:
values.push_back(logline_value("", d));
}
break;
default:
values.push_back(logline_value("", tmp));
break;

7
src/log_format.cc
Unescape Escape View File

@ -111,12 +111,15 @@ static int strcasestr_i(const char *s1, const char *s2)
logline::level_t logline::string2level(const char *levelstr, bool exact)
{
logline::level_t retval = logline::LEVEL_UNKNOWN;
int (*cmpfunc)(const char *, const char *);
if (exact)
if (exact) {
cmpfunc = strcasecmp;
else
}
else{
cmpfunc = strcasestr_i;
}
if (cmpfunc(levelstr, "TRACE") == 0) {
retval = logline::LEVEL_TRACE;

16
src/log_format.hh
Unescape Escape View File

@ -95,7 +95,8 @@ public:
ll_time(t),
ll_millis(millis),
ll_level(l),
ll_module(m) {
ll_module(m)
{
memset(this->ll_schema, 0, sizeof(this->ll_schema));
};
@ -130,11 +131,12 @@ public:
/**
* @return True if there is a schema value set for this log line.
*/
bool has_schema(void) const {
return (this->ll_schema[0] != 0 ||
bool has_schema(void) const
{
return this->ll_schema[0] != 0 ||
this->ll_schema[1] != 0 ||
this->ll_schema[2] != 0 ||
this->ll_schema[3] != 0);
this->ll_schema[3] != 0;
};
/**
@ -144,7 +146,8 @@ public:
*
* @param ba The SHA-1 hash of the constant parts of this log line.
*/
void set_schema(const byte_array<20> &ba) {
void set_schema(const byte_array<20> &ba)
{
memcpy(this->ll_schema, ba.in(), sizeof(this->ll_schema));
};
@ -157,7 +160,8 @@ public:
* @return True if the first four bytes of the given schema match the
* schema stored in this log line.
*/
bool match_schema(const byte_array<20> &ba) const {
bool match_schema(const byte_array<20> &ba) const
{
return memcmp(this->ll_schema, ba.in(), sizeof(this->ll_schema)) == 0;
}

3
src/log_format_impls.cc
Unescape Escape View File

@ -156,8 +156,7 @@ class access_log_format : public log_format {
logline_value::VALUE_TEXT },
{ "cs_username",
logline_value::VALUE_TEXT },
{ "",
},
{ "", },
{ "cs_method",
logline_value::VALUE_TEXT },
{ "cs_uri_stem",

9
src/log_vtab_impl.hh
Unescape Escape View File

@ -101,7 +101,8 @@ public:
virtual void get_columns(std::vector<vtab_column> &cols) { };
virtual void get_foreign_keys(std::vector<std::string> &keys_inout) {
virtual void get_foreign_keys(std::vector<std::string> &keys_inout)
{
keys_inout.push_back("log_line");
};
@ -140,11 +141,13 @@ public:
return this->vm_impls[name];
};
iterator begin() const {
iterator begin() const
{
return this->vm_impls.begin();
};
iterator end() const {
iterator end() const
{
return this->vm_impls.end();
};

9
src/logfile_sub_source.hh
Unescape Escape View File

@ -252,7 +252,8 @@ public:
}
};
void set_user_mark(bookmark_type_t *bm, content_line_t cl) {
void set_user_mark(bookmark_type_t *bm, content_line_t cl)
{
this->lss_user_marks[bm].insert_once(cl);
};
@ -330,11 +331,13 @@ public:
typedef std::vector<logfile_data>::iterator iterator;
iterator begin() {
iterator begin()
{
return this->lss_files.begin();
};
iterator end() {
iterator end()
{
return this->lss_files.end();
};

1
src/pcrepp.cc
Unescape Escape View File

@ -47,6 +47,7 @@ pcre_jit_stack *pcrepp::jit_stack(void)
return retval;
}
#else
#warning "pcrejit is not available, search performance will be degraded"

14
src/pcrepp.hh
Unescape Escape View File

@ -191,7 +191,8 @@ public:
iter->length());
};
void reset(const char *str, size_t off = 0, size_t len = -1) {
void reset(const char *str, size_t off = 0, size_t len = -1)
{
this->pi_string = str;
this->pi_offset = off;
this->pi_next_offset = off;
@ -203,7 +204,8 @@ public:
}
}
void reset(const std::string &str, size_t off = 0) {
void reset(const std::string &str, size_t off = 0)
{
this->reset(str.c_str(), off, str.length());
}
@ -237,7 +239,8 @@ public:
this->study();
};
pcrepp(const char *pattern, int options = 0) : p_code_extra(pcre_free_study)
pcrepp(const char *pattern, int options =
0) : p_code_extra(pcre_free_study)
{
const char *errptr;
int eoff;
@ -302,6 +305,7 @@ public:
switch (rc) {
case PCRE_ERROR_NOMATCH:
break;
default:
fprintf(stderr, "pcre err %d\n", rc);
break;
@ -333,13 +337,15 @@ public:
#ifdef PCRE_STUDY_JIT_COMPILE
static pcre_jit_stack *jit_stack(void);
#else
static void pcre_free_study(pcre_extra *);
#endif
private:
void study(void) {
void study(void)
{
const char *errptr;
this->p_code_extra = pcre_study(this->p_code,

11
src/readline_curses.hh
Unescape Escape View File

@ -200,13 +200,17 @@ public:
void set_perform_action(action va) { this->rc_perform = va; };
void set_timeout_action(action va) { this->rc_timeout = va; };
void set_value(const std::string &value) {
void set_value(const std::string &value)
{
this->rc_value = value;
this->rc_value_expiration = time(NULL) + VALUE_EXPIRATION;
};
std::string get_value() const { return this->rc_value; };
void set_alt_value(const std::string &value) { this->rc_alt_value = value; };
void set_alt_value(const std::string &value)
{
this->rc_alt_value = value;
};
std::string get_alt_value() const { return this->rc_alt_value; };
int update_fd_set(fd_set &readfds)
@ -248,7 +252,8 @@ public:
void add_possibility(int context,
const std::string &type,
const char *values[]) {
const char *values[])
{
for (int lpc = 0; values[lpc]; lpc++) {
this->add_possibility(context, type, values[lpc]);
}

60
src/session_data.cc
Unescape Escape View File

@ -73,6 +73,7 @@ static string bookmark_file_name(const string &name)
static string latest_bookmark_file(const string &name)
{
timestamped_list_t file_names;
static_root_mem<glob_t, globfree> file_list;
string mark_file_pattern;
char mark_base_name[256];
@ -101,8 +102,9 @@ static string latest_bookmark_file(const string &name)
sort(file_names.begin(), file_names.end());
if (file_names.empty())
if (file_names.empty()) {
return "";
}
return file_names.back().second;
}
@ -111,14 +113,16 @@ struct session_file_info {
session_file_info(int timestamp,
const string &id,
const string &path)
: sfi_timestamp(timestamp), sfi_id(id), sfi_path(path) {
};
: sfi_timestamp(timestamp), sfi_id(id), sfi_path(path) {};
bool operator<(const session_file_info &other) const {
if (this->sfi_timestamp < other.sfi_timestamp)
bool operator<(const session_file_info &other) const
{
if (this->sfi_timestamp < other.sfi_timestamp) {
return true;
if (this->sfi_path < other.sfi_path)
}
if (this->sfi_path < other.sfi_path) {
return true;
}
return false;
};
@ -221,7 +225,9 @@ void init_session(void)
void scan_sessions(void)
{
std::list<session_pair_t> &session_file_names = lnav_data.ld_session_file_names;
std::list<session_pair_t> &session_file_names =
lnav_data.ld_session_file_names;
static_root_mem<glob_t, globfree> view_info_list;
std::list<session_pair_t>::iterator iter;
char view_info_pattern_base[128];
@ -245,7 +251,8 @@ void scan_sessions(void)
"view-info-%s.*.json",
lnav_data.ld_session_id.c_str());
view_info_pattern = dotlnav_path(view_info_pattern_base);
if (glob(view_info_pattern.c_str(), 0, NULL, view_info_list.inout()) == 0) {
if (glob(view_info_pattern.c_str(), 0, NULL,
view_info_list.inout()) == 0) {
for (size_t lpc = 0; lpc < view_info_list->gl_pathc; lpc++) {
const char *path = view_info_list->gl_pathv[lpc];
int timestamp, ppid;
@ -299,6 +306,7 @@ static int read_path(void *ctx, const unsigned char *str, size_t len)
static int read_marks(void *ctx, long long num)
{
yajlpp_parse_context *ypc = (yajlpp_parse_context *)ctx;
pair<logfile *, content_line_t> *pair;
fprintf(stderr, "read line %qd\n", num);
@ -341,8 +349,9 @@ void load_bookmarks(void)
}
mark_file_name = latest_bookmark_file(log_name.c_str());
if (mark_file_name.empty())
if (mark_file_name.empty()) {
continue;
}
fprintf(stderr, "loading %s\n", mark_file_name.c_str());
handle = yajl_alloc(&ypc.ypc_callbacks, NULL, &ypc);
@ -409,9 +418,10 @@ static int read_top_line(void *ctx, long long value)
if (view_index < LNV__MAX) {
textview_curses &tc = lnav_data.ld_views[view_index];
if (value != -1 && value < tc.get_inner_height())
if (value != -1 && value < tc.get_inner_height()) {
tc.set_top(vis_line_t(value));
}
}
return 1;
}
@ -479,8 +489,11 @@ static void yajl_writer(void *context, const char *str, size_t len)
void save_bookmarks(void)
{
logfile_sub_source &lss = lnav_data.ld_log_source;
bookmarks<content_line_t>::type &bm = lss.get_user_bookmarks();
bookmark_vector<content_line_t> &user_marks = bm[&textview_curses::BM_USER];
bookmarks<content_line_t>::type &bm =
lss.get_user_bookmarks();
bookmark_vector<content_line_t> &user_marks =
bm[&textview_curses::BM_USER];
logfile_sub_source::iterator file_iter;
bookmark_vector<content_line_t>::iterator iter;
string mark_file_name, mark_file_tmp_name;
@ -528,7 +541,6 @@ void save_bookmarks(void)
lf = lss.find(cl);
if (curr_lf != lf) {
if (handle) {
yajl_gen_array_close(handle);
yajl_gen_map_close(handle);
@ -571,6 +583,7 @@ void save_bookmarks(void)
void save_session(void)
{
string view_file_name, view_file_tmp_name;
auto_mem<FILE> file(fclose);
char view_base_name[256];
yajl_gen handle = NULL;
@ -612,7 +625,8 @@ void save_session(void)
for_each(lnav_data.ld_file_names.begin(),
lnav_data.ld_file_names.end(),
object_field(file_list.gen, &pair<string, int>::first));
object_field(file_list.gen,
&pair<string, int>::first));
}
root_map.gen("views");
@ -632,10 +646,12 @@ void save_session(void)
view_map.gen("top_line");
tc.get_dimensions(height, width);
if ((tc.get_top() + height) > tc.get_inner_height())
if ((tc.get_top() + height) > tc.get_inner_height()) {
view_map.gen(-1);
else
}
else{
view_map.gen((long long)tc.get_top());
}
view_map.gen("search");
view_map.gen(lnav_data.ld_last_search[lpc]);
@ -654,20 +670,23 @@ void save_session(void)
for (filter_iter = fs.begin();
filter_iter != fs.end();
++filter_iter) {
if (!(*filter_iter)->is_enabled())
if (!(*filter_iter)->is_enabled()) {
continue;
}
cmd_array.gen((*filter_iter)->to_command());
}
textview_curses::highlight_map_t &hmap = lnav_data.ld_views[LNV_LOG].get_highlights();
textview_curses::highlight_map_t &hmap =
lnav_data.ld_views[LNV_LOG].get_highlights();
textview_curses::highlight_map_t::iterator hl_iter;
for (hl_iter = hmap.begin();
hl_iter != hmap.end();
++hl_iter) {
if (hl_iter->first[0] == '$')
if (hl_iter->first[0] == '$') {
continue;
}
cmd_array.gen("highlight " + hl_iter->first);
}
}
@ -684,7 +703,8 @@ void save_session(void)
void reset_session(void)
{
textview_curses::highlight_map_t &hmap = lnav_data.ld_views[LNV_LOG].get_highlights();
textview_curses::highlight_map_t &hmap =
lnav_data.ld_views[LNV_LOG].get_highlights();
textview_curses::highlight_map_t::iterator hl_iter = hmap.begin();
save_session();

1
src/session_data.hh
Unescape Escape View File

@ -37,5 +37,4 @@ void load_session(void);
void save_session(void);
void reset_session(void);
void scan_sessions(void);
#endif

4
src/sql_util.cc
Unescape Escape View File

@ -168,7 +168,7 @@ const char *sql_keywords[] = {
};
const char *sql_function_names[] = {
// http://www.sqlite.org/lang_aggfunc.html
/* http://www.sqlite.org/lang_aggfunc.html */
"avg",
"count",
"group_concat",
@ -177,7 +177,7 @@ const char *sql_function_names[] = {
"sum",
"total",
// http://www.sqlite.org/lang_corefunc.html
/* http://www.sqlite.org/lang_corefunc.html */
"abs",
"changes",
"char",

1
src/sql_util.hh
Unescape Escape View File

@ -57,5 +57,4 @@ struct sqlite_metadata_callbacks {
int walk_sqlite_metadata(sqlite3 *db, struct sqlite_metadata_callbacks &smc);
void attach_sqlite_db(sqlite3 *db, const std::string &filename);
#endif

3
src/statusview_curses.hh
Unescape Escape View File

@ -128,7 +128,8 @@ public:
va_end(args);
};
void set_stitch_value(int color_pair) {
void set_stitch_value(int color_pair)
{
string_attrs_t & sa = this->sf_value.get_attrs();
struct line_range lr = { 0, 1 };

1
src/test_override.cc
Unescape Escape View File

@ -1,4 +1,3 @@
#include "config.h"
#include <time.h>

6
src/top_status_source.hh
Unescape Escape View File

@ -62,12 +62,14 @@ public:
this->tss_fields[TSF_VIEW_NAME].set_width(6);
this->tss_fields[TSF_VIEW_NAME].right_justify(true);
this->tss_fields[TSF_STITCH_VIEW_FORMAT].set_width(2);
this->tss_fields[TSF_STITCH_VIEW_FORMAT].set_stitch_value(view_colors::VC_CYAN_ON_BLUE);
this->tss_fields[TSF_STITCH_VIEW_FORMAT].set_stitch_value(
view_colors::VC_CYAN_ON_BLUE);
this->tss_fields[TSF_STITCH_VIEW_FORMAT].right_justify(true);
this->tss_fields[TSF_FORMAT].set_width(13);
this->tss_fields[TSF_FORMAT].right_justify(true);
this->tss_fields[TSF_STITCH_FORMAT_FILENAME].set_width(2);
this->tss_fields[TSF_STITCH_FORMAT_FILENAME].set_stitch_value(view_colors::VC_WHITE_ON_CYAN);
this->tss_fields[TSF_STITCH_FORMAT_FILENAME].set_stitch_value(
view_colors::VC_WHITE_ON_CYAN);
this->tss_fields[TSF_STITCH_FORMAT_FILENAME].right_justify(true);
this->tss_fields[TSF_FILENAME].set_min_width(35); /* XXX */
this->tss_fields[TSF_FILENAME].set_share(1);

3
src/view_curses.cc
Unescape Escape View File

@ -288,7 +288,8 @@ void view_colors::init(void)
for (int lpc = 0; lpc < 8; lpc++) {
short gradient_value = (1000 / 8) * lpc;
init_color(lpc + 16, gradient_value, gradient_value, gradient_value);
init_color(lpc + 16, gradient_value, gradient_value,
gradient_value);
init_pair(VC_GRADIENT_START + lpc, lpc + 16, COLOR_BLACK);
}
}

6
src/view_curses.hh
Unescape Escape View File

@ -424,11 +424,13 @@ public:
VC_GRADIENT_START,
};
static inline int ansi_color_pair_index(int fg, int bg) {
static inline int ansi_color_pair_index(int fg, int bg)
{
return VC_ANSI_START + ((fg * 8) + bg);
};
int ansi_color_pair(int fg, int bg) {
int ansi_color_pair(int fg, int bg)
{
return COLOR_PAIR(ansi_color_pair_index(fg, bg));
};

74
src/yajlpp.hh
Unescape Escape View File

@ -61,7 +61,8 @@ yajl_gen_status yajl_gen_string(yajl_gen hand, const std::string &str)
}
struct json_path_handler_base {
json_path_handler_base(const char *path) : jph_path(path), jph_regex(path) {
json_path_handler_base(const char *path) : jph_path(path), jph_regex(path)
{
memset(&this->jph_callbacks, 0, sizeof(this->jph_callbacks));
};
@ -72,32 +73,37 @@ struct json_path_handler_base {
struct json_path_handler : public json_path_handler_base {
json_path_handler(const char *path, int(*null_func)(void *))
: json_path_handler_base(path) {
: json_path_handler_base(path)
{
this->jph_callbacks.yajl_null = null_func;
};
json_path_handler(const char *path, int(*bool_func)(void *, int))
: json_path_handler_base(path) {
: json_path_handler_base(path)
{
this->jph_callbacks.yajl_boolean = bool_func;
}
json_path_handler(const char *path, int(*int_func)(void *, long long))
: json_path_handler_base(path) {
: json_path_handler_base(path)
{
this->jph_callbacks.yajl_integer = int_func;
}
json_path_handler(const char *path, int(*double_func)(void *, double))
: json_path_handler_base(path) {
: json_path_handler_base(path)
{
this->jph_callbacks.yajl_double = double_func;
}
json_path_handler(const char *path, int (*str_func)(void *, const unsigned char *, size_t))
: json_path_handler_base(path) {
json_path_handler(const char *path,
int(*str_func)(void *, const unsigned char *, size_t))
: json_path_handler_base(path)
{
this->jph_callbacks.yajl_string = str_func;
}
json_path_handler() : json_path_handler_base("") {
};
json_path_handler() : json_path_handler_base("") {};
};
class yajlpp_parse_context {
@ -106,15 +112,12 @@ public:
struct json_path_element {
json_path_element(int index = 0) : jpe_index(index) { };
json_path_element(const std::string &name)
: jpe_name(name), jpe_index(0) {
};
: jpe_name(name), jpe_index(0) {};
json_path_element(const unsigned char *name)
: jpe_name((const char *)name), jpe_index(0) {
};
: jpe_name((const char *)name), jpe_index(0) {};
void set_name(const unsigned char *name, size_t len) {
void set_name(const unsigned char *name, size_t len)
{
this->jpe_name = std::string((const char *)name, len);
};
@ -122,21 +125,26 @@ public:
int jpe_index;
};
yajlpp_parse_context(struct json_path_handler *handlers) : ypc_handlers(handlers) {
yajlpp_parse_context(struct json_path_handler *handlers) : ypc_handlers(
handlers)
{
this->ypc_callbacks = DEFAULT_CALLBACKS;
};
std::string get_path_fragment(int offset) const {
std::string get_path_fragment(int offset) const
{
size_t start, end;
if (offset < 0) {
offset = this->ypc_path_index_stack.size() + offset;
}
start = this->ypc_path_index_stack[offset] + 1;
if ((offset + 1) < (int)this->ypc_path_index_stack.size())
if ((offset + 1) < (int)this->ypc_path_index_stack.size()) {
end = this->ypc_path_index_stack[offset + 1];
else
}
else{
end = std::string::npos;
}
return this->ypc_path.substr(start, end - start);
};
@ -163,11 +171,13 @@ class yajlpp_generator {
public:
yajlpp_generator(yajl_gen handle) : yg_handle(handle) { };
void operator()(const std::string &str) {
void operator()(const std::string &str)
{
yajl_gen_string(this->yg_handle, str);
};
void operator()(long long value) {
void operator()(long long value)
{
yajl_gen_integer(this->yg_handle, value);
};
@ -178,15 +188,15 @@ private:
class yajlpp_container_base {
public:
yajlpp_container_base(yajl_gen handle)
: gen(handle), ycb_handle(handle) {
: gen(handle), ycb_handle(handle) {};
};
void operator()(const std::string &str) {
void operator()(const std::string &str)
{
yajl_gen_string(this->ycb_handle, str);
};
void operator()(long long value) {
void operator()(long long value)
{
yajl_gen_integer(this->ycb_handle, value);
};
@ -197,24 +207,22 @@ protected:
};
class yajlpp_map : public yajlpp_container_base {
public:
yajlpp_map(yajl_gen handle) : yajlpp_container_base(handle) {
yajlpp_map(yajl_gen handle) : yajlpp_container_base(handle)
{
yajl_gen_map_open(handle);
};
~yajlpp_map() { yajl_gen_map_close(this->ycb_handle); };
};
class yajlpp_array : public yajlpp_container_base {
public:
yajlpp_array(yajl_gen handle) : yajlpp_container_base(handle) {
yajlpp_array(yajl_gen handle) : yajlpp_container_base(handle)
{
yajl_gen_array_open(handle);
};
~yajlpp_array() { yajl_gen_array_close(this->ycb_handle); };
};
#endif

Write Preview
Loading…
Cancel
Save