mirror of https://github.com/LemmyNet/lemmy
Adding hot_rank columns in place of function sorting. (#2952)
* Adding hot_rank columns in place of function sorting. - Creates hot_rank columns for post, comment, and community. - Fixes #2932 * Updating all hot ranks on startup. * Fixing post.url migration. * Removing update_instance_software from startup. * Adding post_rank querypull/2956/head
parent
4e5798852f
commit
8cb5939f50
@ -1 +1,5 @@
|
||||
-- Change back the column type
|
||||
alter table post alter column url type text;
|
||||
|
||||
-- Drop the index
|
||||
drop index idx_post_url;
|
||||
|
@ -1 +1,9 @@
|
||||
-- Make a hard limit of 512 for the post.url column
|
||||
-- Truncate existing long rows.
|
||||
update post set url = left(url, 512) where length(url) > 512;
|
||||
|
||||
-- Enforce the limit
|
||||
alter table post alter column url type varchar (512);
|
||||
|
||||
-- Add the index
|
||||
create index idx_post_url on post(url);
|
||||
|
@ -0,0 +1,35 @@
|
||||
|
||||
-- Remove the new columns
|
||||
|
||||
alter table post_aggregates drop column hot_rank;
|
||||
alter table post_aggregates drop column hot_rank_active;
|
||||
|
||||
alter table comment_aggregates drop column hot_rank;
|
||||
|
||||
alter table community_aggregates drop column hot_rank;
|
||||
|
||||
-- Drop some new indexes
|
||||
drop index idx_post_aggregates_score;
|
||||
drop index idx_post_aggregates_published;
|
||||
drop index idx_post_aggregates_newest_comment_time;
|
||||
drop index idx_post_aggregates_newest_comment_time_necro;
|
||||
drop index idx_post_aggregates_featured_community;
|
||||
drop index idx_post_aggregates_featured_local;
|
||||
|
||||
-- Recreate the old indexes
|
||||
CREATE INDEX idx_post_aggregates_featured_local_newest_comment_time ON public.post_aggregates USING btree (featured_local DESC, newest_comment_time DESC);
|
||||
CREATE INDEX idx_post_aggregates_featured_community_newest_comment_time ON public.post_aggregates USING btree (featured_community DESC, newest_comment_time DESC);
|
||||
CREATE INDEX idx_post_aggregates_featured_local_comments ON public.post_aggregates USING btree (featured_local DESC, comments DESC);
|
||||
CREATE INDEX idx_post_aggregates_featured_community_comments ON public.post_aggregates USING btree (featured_community DESC, comments DESC);
|
||||
CREATE INDEX idx_post_aggregates_featured_local_hot ON public.post_aggregates USING btree (featured_local DESC, hot_rank((score)::numeric, published) DESC, published DESC);
|
||||
CREATE INDEX idx_post_aggregates_featured_community_hot ON public.post_aggregates USING btree (featured_community DESC, hot_rank((score)::numeric, published) DESC, published DESC);
|
||||
CREATE INDEX idx_post_aggregates_featured_local_score ON public.post_aggregates USING btree (featured_local DESC, score DESC);
|
||||
CREATE INDEX idx_post_aggregates_featured_community_score ON public.post_aggregates USING btree (featured_community DESC, score DESC);
|
||||
CREATE INDEX idx_post_aggregates_featured_local_published ON public.post_aggregates USING btree (featured_local DESC, published DESC);
|
||||
CREATE INDEX idx_post_aggregates_featured_community_published ON public.post_aggregates USING btree (featured_community DESC, published DESC);
|
||||
CREATE INDEX idx_post_aggregates_featured_local_active ON public.post_aggregates USING btree (featured_local DESC, hot_rank((score)::numeric, newest_comment_time_necro) DESC, newest_comment_time_necro DESC);
|
||||
CREATE INDEX idx_post_aggregates_featured_community_active ON public.post_aggregates USING btree (featured_community DESC, hot_rank((score)::numeric, newest_comment_time_necro) DESC, newest_comment_time_necro DESC);
|
||||
|
||||
CREATE INDEX idx_comment_aggregates_hot ON public.comment_aggregates USING btree (hot_rank((score)::numeric, published) DESC, published DESC);
|
||||
|
||||
CREATE INDEX idx_community_aggregates_hot ON public.community_aggregates USING btree (hot_rank((subscribers)::numeric, published) DESC, published DESC);
|
@ -0,0 +1,51 @@
|
||||
-- This converts the old hot_rank functions, to columns
|
||||
|
||||
-- Remove the old compound indexes
|
||||
DROP INDEX idx_post_aggregates_featured_local_newest_comment_time;
|
||||
DROP INDEX idx_post_aggregates_featured_community_newest_comment_time;
|
||||
DROP INDEX idx_post_aggregates_featured_local_comments;
|
||||
DROP INDEX idx_post_aggregates_featured_community_comments;
|
||||
DROP INDEX idx_post_aggregates_featured_local_hot;
|
||||
DROP INDEX idx_post_aggregates_featured_community_hot;
|
||||
DROP INDEX idx_post_aggregates_featured_local_score;
|
||||
DROP INDEX idx_post_aggregates_featured_community_score;
|
||||
DROP INDEX idx_post_aggregates_featured_local_published;
|
||||
DROP INDEX idx_post_aggregates_featured_community_published;
|
||||
DROP INDEX idx_post_aggregates_featured_local_active;
|
||||
DROP INDEX idx_post_aggregates_featured_community_active;
|
||||
|
||||
DROP INDEX idx_comment_aggregates_hot;
|
||||
|
||||
DROP INDEX idx_community_aggregates_hot;
|
||||
|
||||
-- Add the new hot rank columns for post and comment aggregates
|
||||
-- Note: 1728 is the result of the hot_rank function, with a score of 1, posted now
|
||||
-- hot_rank = 10000*log10(1 + 3)/Power(2, 1.8)
|
||||
alter table post_aggregates add column hot_rank integer not null default 1728;
|
||||
alter table post_aggregates add column hot_rank_active integer not null default 1728;
|
||||
|
||||
alter table comment_aggregates add column hot_rank integer not null default 1728;
|
||||
|
||||
alter table community_aggregates add column hot_rank integer not null default 1728;
|
||||
|
||||
-- Populate them initially
|
||||
-- Note: After initial population, these are updated in a periodic scheduled job,
|
||||
-- with only the last week being updated.
|
||||
update post_aggregates set hot_rank_active = hot_rank(score::numeric, newest_comment_time_necro);
|
||||
update post_aggregates set hot_rank = hot_rank(score::numeric, published);
|
||||
update comment_aggregates set hot_rank = hot_rank(score::numeric, published);
|
||||
update community_aggregates set hot_rank = hot_rank(subscribers::numeric, published);
|
||||
|
||||
-- Create single column indexes
|
||||
create index idx_post_aggregates_score on post_aggregates (score desc);
|
||||
create index idx_post_aggregates_published on post_aggregates (published desc);
|
||||
create index idx_post_aggregates_newest_comment_time on post_aggregates (newest_comment_time desc);
|
||||
create index idx_post_aggregates_newest_comment_time_necro on post_aggregates (newest_comment_time_necro desc);
|
||||
create index idx_post_aggregates_featured_community on post_aggregates (featured_community desc);
|
||||
create index idx_post_aggregates_featured_local on post_aggregates (featured_local desc);
|
||||
create index idx_post_aggregates_hot on post_aggregates (hot_rank desc);
|
||||
create index idx_post_aggregates_active on post_aggregates (hot_rank_active desc);
|
||||
|
||||
create index idx_comment_aggregates_hot on comment_aggregates (hot_rank desc);
|
||||
|
||||
create index idx_community_aggregates_hot on community_aggregates (hot_rank desc);
|
@ -0,0 +1,3 @@
|
||||
#!/bin/bash
|
||||
|
||||
sudo docker exec -i docker-postgres-1 psql -Ulemmy -c "EXPLAIN (ANALYZE, COSTS, VERBOSE, BUFFERS, FORMAT JSON) SELECT post.id, post.name, post.url, post.body, post.creator_id, post.community_id, post.removed, post.locked, post.published, post.updated, post.deleted, post.nsfw, post.embed_title, post.embed_description, post.embed_video_url, post.thumbnail_url, post.ap_id, post.local, post.language_id, post.featured_community, post.featured_local, person.id, person.name, person.display_name, person.avatar, person.banned, person.published, person.updated, person.actor_id, person.bio, person.local, person.banner, person.deleted, person.inbox_url, person.shared_inbox_url, person.matrix_user_id, person.admin, person.bot_account, person.ban_expires, person.instance_id, community.id, community.name, community.title, community.description, community.removed, community.published, community.updated, community.deleted, community.nsfw, community.actor_id, community.local, community.icon, community.banner, community.hidden, community.posting_restricted_to_mods, community.instance_id, community_person_ban.id, community_person_ban.community_id, community_person_ban.person_id, community_person_ban.published, community_person_ban.expires, post_aggregates.id, post_aggregates.post_id, post_aggregates.comments, post_aggregates.score, post_aggregates.upvotes, post_aggregates.downvotes, post_aggregates.published, post_aggregates.newest_comment_time_necro, post_aggregates.newest_comment_time, post_aggregates.featured_community, post_aggregates.featured_local, community_follower.id, community_follower.community_id, community_follower.person_id, community_follower.published, community_follower.pending, post_saved.id, post_saved.post_id, post_saved.person_id, post_saved.published, post_read.id, post_read.post_id, post_read.person_id, post_read.published, person_block.id, person_block.person_id, person_block.target_id, person_block.published, post_like.score, coalesce((post_aggregates.comments - person_post_aggregates.read_comments), post_aggregates.comments) FROM ((((((((((((post INNER JOIN person ON (post.creator_id = person.id)) INNER JOIN community ON (post.community_id = community.id)) LEFT OUTER JOIN community_person_ban ON (((post.community_id = community_person_ban.community_id) AND (community_person_ban.person_id = post.creator_id)) AND ((community_person_ban.expires IS NULL) OR (community_person_ban.expires > CURRENT_TIMESTAMP)))) INNER JOIN post_aggregates ON (post_aggregates.post_id = post.id)) LEFT OUTER JOIN community_follower ON ((post.community_id = community_follower.community_id) AND (community_follower.person_id = '33517'))) LEFT OUTER JOIN post_saved ON ((post.id = post_saved.post_id) AND (post_saved.person_id = '33517'))) LEFT OUTER JOIN post_read ON ((post.id = post_read.post_id) AND (post_read.person_id = '33517'))) LEFT OUTER JOIN person_block ON ((post.creator_id = person_block.target_id) AND (person_block.person_id = '33517'))) LEFT OUTER JOIN community_block ON ((community.id = community_block.community_id) AND (community_block.person_id = '33517'))) LEFT OUTER JOIN post_like ON ((post.id = post_like.post_id) AND (post_like.person_id = '33517'))) LEFT OUTER JOIN person_post_aggregates ON ((post.id = person_post_aggregates.post_id) AND (person_post_aggregates.person_id = '33517'))) LEFT OUTER JOIN local_user_language ON ((post.language_id = local_user_language.language_id) AND (local_user_language.local_user_id = '11402'))) WHERE ((((((((((community_follower.person_id IS NOT NULL) AND (post.nsfw = 'f')) AND (community.nsfw = 'f')) AND (local_user_language.language_id IS NOT NULL)) AND (community_block.person_id IS NULL)) AND (person_block.person_id IS NULL)) AND (post.removed = 'f')) AND (post.deleted = 'f')) AND (community.removed = 'f')) AND (community.deleted = 'f')) ORDER BY post_aggregates.featured_local DESC , post_aggregates.hot_rank DESC LIMIT '40' OFFSET '0';" > query_results.json
|
Loading…
Reference in New Issue