mirror of https://github.com/hwchase17/langchain
Fix `allowed_search_types` in `VectorStoreRetriever` (#8064)
Unexpectedly changed atpull/8073/merge6792a3557d
<!-- Thank you for contributing to LangChain! Replace this comment with: - Description: a description of the change, - Issue: the issue # it fixes (if applicable), - Dependencies: any dependencies required for this change, - Tag maintainer: for a quicker response, tag the relevant maintainer (see below), - Twitter handle: we announce bigger features on Twitter. If your PR gets announced and you'd like a mention, we'll gladly shout you out! Please make sure you're PR is passing linting and testing before submitting. Run `make format`, `make lint` and `make test` to check this locally. If you're adding a new integration, please include: 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. Maintainer responsibilities: - General / Misc / if you don't know who to tag: @baskaryan - DataLoaders / VectorStores / Retrievers: @rlancemartin, @eyurtsev - Models / Prompts: @hwchase17, @baskaryan - Memory: @hwchase17 - Agents / Tools / Toolkits: @hinthornw - Tracing / Callbacks: @agola11 - Async: @agola11 If no one reviews your PR within a few days, feel free to @-mention the same people again. See contribution guidelines for more information on how to write/run tests, lint, etc: https://github.com/hwchase17/langchain/blob/master/.github/CONTRIBUTING.md --> I guess `allowed_search_types` is unexpectedly changed in6792a3557d
, so that we cannot specify `similarity_score_threshold` here. ```python class VectorStoreRetriever(BaseRetriever): ... allowed_search_types: ClassVar[Collection[str]] = ( "similarity", "similarityatscore_threshold", "mmr", ) @root_validator() def validate_search_type(cls, values: Dict) -> Dict: """Validate search type.""" search_type = values["search_type"] if search_type not in cls.allowed_search_types: raise ValueError(...) if search_type == "similarity_score_threshold": ... # UNREACHABLE CODE ``` VectorStores Maintainers: @rlancemartin @eyurtsev
parent
95e369b38d
commit
623b321e75
Loading…
Reference in New Issue