2
0
mirror of https://github.com/koreader/koreader synced 2024-11-16 06:12:56 +00:00
Commit Graph

3948 Commits

Author SHA1 Message Date
chrox
ef6235e4ae fix #1305 2014-12-03 11:33:54 +08:00
chrox
6c9b7facbe fix crash when removing highlighted bookmarks in PDF 2014-12-03 11:12:15 +08:00
chrox
4f35834b2e wrap computation intensive functions in hook free env when makeing coverage test
so that Travis CI job won't fail because of timeout.
2014-12-03 11:01:12 +08:00
Huang Xin
0a94696213 Merge pull request #1324 from variousvirgil/patch-1
Fix #1299
2014-12-02 20:45:44 +08:00
variousvirgil
9c69c1f14e Fix #1299 2014-12-02 20:30:55 +08:00
Huang Xin
d9b661ffa7 Merge pull request #1323 from hwhw/master
only open frontlight device on Kobo devices that actually have light
2014-12-02 18:29:52 +08:00
Hans-Werner Hilse
3d73ff5ae7 only open frontlight device on Kobo devices that actually have light 2014-12-02 11:18:19 +01:00
HW
4fb6eae358 Merge pull request #1320 from chrox/master
fix filemanager cannot remember sorting order
2014-12-02 11:17:51 +01:00
chrox
eea6f97796 fix #1319 2014-12-02 10:35:55 +08:00
chrox
aa9566205b fix filemanager cannot remember sorting order 2014-12-02 09:52:05 +08:00
Huang Xin
a505ac2e54 Merge pull request #1316 from hwhw/master
killling/shrinking refreshes
2014-12-02 08:49:45 +08:00
Hans-Werner Hilse
ff0fbbdb4b fix widget closing 2014-12-01 16:21:42 +00:00
Hans-Werner Hilse
844c1babf7 UIManager:_refresh(): no more default refresh
If no refresh type is specified, don't do a refresh.
There should be now refresh types specified in all relevant places.
2014-12-01 16:03:41 +00:00
Hans-Werner Hilse
94ce08937a clean up refreshes
This is a larger clean-up of the refresh situation.
The general shift is that refreshes are now mainly triggered by
the (top-level) widgets when they get shown or closed via UIManager.

All refreshes for the widgets when they are in use were handled by
themselves before. This adds the case of showing/closing.

It is the desired result of not having UIManager:show()/:close()
do (full screen) refreshes on its own.
2014-12-01 16:03:40 +00:00
Hans-Werner Hilse
9c4088a3ac small change of UIManager:show(): No more automatic refresh
This eliminates the API difference between the extra parameters of
UIManager:show() and setDirty(). They work the same now.
Note that this also eliminates the automatic refresh that took place
before when using show() without refresh options. It always refreshed
the full screen, which led to too big refresh regions all over the
place. Thus, refresh has now explicitly to be asked for, hopefully
encouraging to implement it in the widget that gets shown (and is
aware about the screen region it covers).

Also add an event that is triggered when a widget is closed:
CloseWidget. So a widget can implement "onCloseWidget()" to trigger
actions upon closing - most commonly, this is a refresh for the area
previously taken by the widget. That way, the widget's user does not
have to take measures to ensure that the area is refreshed later.
2014-12-01 14:42:38 +00:00
Frans de Jonge
2c1eacdbf5 Merge pull request #1314 from chrox/master
make coverage in after_success stage
2014-12-01 14:50:31 +01:00
chrox
20fd6f902e fix #1175 2014-12-01 15:32:12 +08:00
chrox
d6c4465c47 fix coverage test fails on OPDS browser module
for some reason luxl.lua has problem when being set hook for luacov
2014-12-01 14:46:17 +08:00
chrox
6a0554f226 make coverage in after_success stage
So that if the coverage job is timeout it won't fail the
CI result.
2014-12-01 14:43:01 +08:00
Huang Xin
ddae003925 Merge pull request #1310 from hwhw/master
fixes for scrolling, fix for double-refresh, misc stuff
2014-12-01 09:56:04 +08:00
Hans-Werner Hilse
e8642fbad7 use API for refresh when closing widgets in message popups 2014-11-30 22:35:08 +00:00
Hans-Werner Hilse
1091a8a3b9 add refresh control to UIManager:close() 2014-11-30 22:35:07 +00:00
Hans-Werner Hilse
e7f7417cd3 refresh only dialog part of the screen for multi-word selection window 2014-11-30 22:33:38 +00:00
Hans-Werner Hilse
143c56c48c record ButtonDialog.dimen 2014-11-30 22:33:38 +00:00
Hans-Werner Hilse
8376e2f821 dictionary window triggers refresh itself, not via show() 2014-11-30 22:33:37 +00:00
Hans-Werner Hilse
afb59667c0 allow for more control on refreshes when show()ing widgets
for now, we have show() automatically call setDirty() for the new
widget, as before. However, now show() takes two arguments for
refresh configuration that will get passed on to setDirty().

For compatibility, the default is here in show() to do a partial
refresh. So if you want no refresh triggered (via this show() call),
add a function that doesn't return anything.
2014-11-30 22:33:36 +00:00
HW
33e93342f7 Merge pull request #1312 from Frenzie/master
OPDS: refactored unit test and fixed a minor bug with undefined image_rel
2014-11-30 22:14:07 +01:00
Frans de Jonge
47d7a48555 OPDS: refactored unit test and fixed a minor bug with undefined image_rel 2014-11-30 21:44:47 +01:00
Hans-Werner Hilse
3f9dc46315 fix dict window refresh
was still using old API
also, move this to another place.
2014-11-30 18:38:03 +00:00
Hans-Werner Hilse
c4a9903162 on finish of pan gesture when scrolling, do partial refresh
it was set to a full refresh. However, we want to behave as if in
non-scrolling mode and issue a partial refresh. That might get
updated to a full refresh if the full-refresh counter has reached
the limit - which is configurable.
2014-11-30 18:38:03 +00:00
Hans-Werner Hilse
745e3837e0 updating the screen in tap handler of readerfooter is not needed
Was a hack anyway, c.f.
https://github.com/koreader/koreader/pull/1306#discussion_r21057461

Seems to be not needed anymore. If some areas are now not refreshed
anymore, that ought to be fixed in another place.

This also gets rid of redundant screen flashes.
2014-11-30 18:38:02 +00:00
HW
b451b10dde Merge pull request #1311 from Frenzie/master
OPDS: embryonic unit test for OPDS browser
2014-11-30 19:36:32 +01:00
Frans de Jonge
c25254a7ec OPDS: embryonic unit test for OPDS browser
This initial seed specifically tests against what recently broke in Gutenberg and FeedBooks.
2014-11-30 19:06:27 +01:00
Huang Xin
24daab0420 Merge pull request #1309 from hwhw/master
update base: fixes for tests, libk2pdfopt without mupdf linkage
2014-12-01 01:17:09 +08:00
Hans-Werner Hilse
328169065d update base: fixes for tests, libk2pdfopt without mupdf linkage 2014-11-30 16:43:37 +00:00
Huang Xin
a485141324 Merge pull request #1306 from hwhw/master
Refresh refactoring, frontend/UIManager side
2014-11-30 23:57:12 +08:00
Hans-Werner Hilse
f02be20a65 refresh fixes for the menus
this will only refresh the areas that actually need to be refreshed.
2014-11-30 12:04:33 +00:00
Hans-Werner Hilse
6793a4fee1 reader config dialog: properly refresh config pane
This serves as a good example for the way refreshes are done:
setDirty("all", function() ... end)
* the "all" will have all widgets on screen repainted.
  In this case that is needed because the config pane has
  different sizes, covering different parts of underlying
  widgets. So they need to be repainted every time.
* the function will return the area to refresh and is evaluated
  after painting. In this example, we take the area that is covered
  by the config pane before switching it (if present at all), and
  hand it to the refresh area function as an upvalue.
  When the function is called later after painting, it will
  use that saved area and combine it with the area that is covered
  then by the widget. That way, parts that are covered no more are
  included in the refresh area, too.
2014-11-30 11:50:51 +00:00
Hans-Werner Hilse
bc3ef46fbf update base: use new refresh wait queue
also pull refresh emulation improvement for emulator.
2014-11-30 11:15:54 +00:00
Hans-Werner Hilse
82c26b1f18 adapt widgets to new refresh/repaint API 2014-11-30 00:17:50 +00:00
Hans-Werner Hilse
229c5ad61c change setDirty/refresh API
See documentation in the code.
In short: There is now one single method, setDirty(), that triggers
repaints and/or refreshes.
All variables in UIManager are gone - at least from an external
perspective. Everything is done through setDirty().
This also allows for easier debugging, since all requests come
in via function calls.
2014-11-30 00:15:17 +00:00
Hans-Werner Hilse
2f9386cd69 move refresh menu table out of UIManager
no need to clutter a core file of the whole UI concept with definitions
of UI elements
2014-11-30 00:15:17 +00:00
HW
d793d73182 Merge pull request #1304 from Frenzie/master
Added some instruction about the translation of variables
2014-11-30 01:14:41 +01:00
Frans de Jonge
daccda42d8 Added some instruction about the translation of variables
Simplified building prerequisites
2014-11-29 21:46:33 +01:00
HW
abcb94d946 Merge pull request #1303 from Frenzie/language
Add missing util.template definition to readerfrontlight.lua
2014-11-29 16:34:53 +01:00
Frans de Jonge
7fd8f4d2f1 Add missing util.template definition to readerfrontlight.lua
Fixes #1302.
2014-11-29 15:45:18 +01:00
Frans de Jonge
d182810292 Merge pull request #1300 from erosennin/opds-ignore-unknown-rels
OPDS: ignore links with unknown rel values, treat empty rel as rel="subsection"
2014-11-29 12:22:55 +01:00
Andrey Golovizin
296f63b22a OPDS: ignore links with unknown rel values, treat empty rel as rel="subsection". 2014-11-29 11:15:41 +01:00
HW
cceac98180 Merge pull request #1298 from Frenzie/master
Language: prevent spaces from disappearing in localizations with util.template
2014-11-28 23:14:58 +01:00
Frans de Jonge
73a6f71a0b Prevent spaces from being eaten by Transifex
Fixes #1276
2014-11-28 22:38:54 +01:00