Commit Graph

5363 Commits (e8c01274f4d1ef81ebc431ad50a4af9de3000148)
 

Author SHA1 Message Date
Frans de Jonge e8c01274f4 Travis: enforce shellscript coding style
* enormous coding style update

* update luajit-launcher

All changes are formatting only except for:

* new more correct pushd/popd style
	* keeps useful indentation
	* prevents execution of commands when pushd failed (cf. https://github.com/koalaman/shellcheck/wiki/SC2164 and https://github.com/koalaman/shellcheck/issues/863)

```
pushd some_dir && {
    command1
    command2
} || exit
popd
```
7 years ago
Qingping Hou f51285e89b revert code that enables screensaver on kindle by default 7 years ago
Qingping Hou 15fd7fc0ff bring back support for disabling progressbar in footer (#2753)
* footer(optimize): remove dead code

* footer(fix): disable auto refresh time option when current time is not checked

* fix: support disable progress bar again
7 years ago
Frans de Jonge 9d39f11f59 Travis: speed up by caching base and running luacheck earlier (#2741)
* Travis: speed up by caching base and running luacheck earlier
* ignore bin and install for git status change detection
* skip coverage except on official master branch. It adds 3 whole minutes and does nothing to prevent regressions
* also cache ~/.luarocks. It evens out but would generally prevent remote timeout shenenigans
* remove base cache dir before caching with verbose remove to see what's going on
* more inclusive shell code quality analysis
* fixed more shellcheck issues
* better shellcheck/shfmt debugging info
7 years ago
poire-z 5bc19fa084 clean ReaderDictionary:cleanSelection
crengine now does a much better job at finding word boundaries, so
less cleanup is needed
7 years ago
Frans de Jonge f1c0b4b3bb UIManager docs & lang: add some docs and correct "quiting" to "quitting" 7 years ago
Frans de Jonge 338fcd76ae Lang: two tiny strings
* ReaderHighlight: underscore to underline. Although underscore means to
emphasize by underlining, the emphasis lies on the, ahem, emphasis. Besides
which, it's mostly AmE and less well understood worldwide (although in this
particular context it should probably cause no trouble).

* Statistics plugin: menu item text to "reading statistics" to make it clear
which statistics we're talking about. Fixes #2744.
7 years ago
robert00s a51941c397 Add Last suspend and resume time into System statistics 7 years ago
Frans de Jonge e5bcdee85e Add ShellCheck and shfmt shell code quality analysis (#2712)
* Add ShellCheck and shfmt shell code quality analysis

* kobo/koreader.sh: remove useless $PREFIX

* kobo/koreader.sh: fix rotation issue caused by #2731

* Travis: speed up (caching Luarocks should shave a minute off install process)
7 years ago
Robert 59873ae293 Screensaver option on Kindle devices (#2734)
* Screensaver on Kindle devices
7 years ago
Frans de Jonge e217b99fa6 Dev docs (#2730) 7 years ago
Frans de Jonge e8721887ba InputContainer: add cancel_text and ok_text
Makes it easier to comply with UX style.

* Change "OK" to "Search dictionary" in Dictionary lookup to comply with UX style
* Change "OK" to "Search all text" in Fulltext search to comply with UX style

Tacked on but highly related:

* change "OK" to "Search Wikipedia" in Wikipedia lookup to comply with UX style
* change "OK" to "Set default" in ConfigDialog to comply with UX style

Chore:

* fixed up order of requires
7 years ago
Frans de Jonge 92b9139294 ReaderFooter (lang): "Show toc markers" to "Show chapter markers"
I think it sounds more natural as chapter than as table of content, which is an implementation detail (i.e., the chapter markers are shown based on what's in the TOC).

Also removed redundant "this" from "Remaining pages in this chapter"
7 years ago
pazos 3a75b6deab use fullpath for reboot 7 years ago
pazos 31b246574b Kobo framebuffer: workaround to support +4.0FW 7 years ago
Frans de Jonge 0256601e85 UX and language fixes
* lang: changed `...` in CloudStorage to real ellipses
* chore: reordered requires in CloudStorage per coding style
* UX: switched "Close" and "Stay alive" in KeepAlive per UX style
* lang: improved message in CloudStorage
* chore: reordered requires in OTAManager per coding style
* lang: removed "your" from "Your KOReader is up to date" in OTAManager
7 years ago
Frans de Jonge dd7251e66d Menu order and separators
* Add separators to navigation menu
* Move speed reading to "typeset" (reading experience) menu
* Move Goodreads over to search

See https://github.com/koreader/koreader/issues/2562#issuecomment-290379241
7 years ago
Qingping Hou 1461574894 Support configurable extra plugin lookup path (#2693)
* plugin loader(feat): support loading plugins from user defined directories
Extra plugin lookup paths can be set in global reader setting via key
`extra_plugin_paths`. Value of the key can either be a string or an array
of strings.
* build(fix): also purge non-exist plugins on build
* plugin: migrate debug plugin to menu sorter
7 years ago
robert00s ba74921c4b Fix showing footer on Kindle with Special Offers screensaver 7 years ago
robert00s 1749ab7227 Fix 2716 7 years ago
Frans de Jonge a8b3873c8c Help submenu
This commit seeks to improve the paltry help menu item. It breaks the "try to have at least three items in a submenu" rule in anticipation of an upcoming quickstart guide and show quickstart guide setting. This guide will explain that (soon) you will have to swipe south at the top of the screen to activate the menu.

Also see the somewhat related #1371, which would also go in the submenu.
7 years ago
Frans de Jonge 2e43faedfe FileManager menu order: add synchronize_time
Fixes #2722.
7 years ago
Frans de Jonge da48a54727 Fix LuaCheck error
"frontend/ui/menusorter.lua:110:13: value assigned to variable 'sub_menu_content' is unused"

Kind of the point, I'm assigning it nil after all. This way it probably shouldn't complain.
7 years ago
Frans de Jonge 3982170886 MenuSorter: fix findById 7 years ago
Frans de Jonge e9df73f6dc Developer documentation improvements
* Fixed up all of util and added when absent
* Updated widget examples to new coding style
7 years ago
Frans de Jonge 69b826781a gettext: unescape quotation mark
Fixes #2718.
7 years ago
Frans de Jonge 1c25d0fd1b Language: improve confirmboxes
Generic "OK" buttons should be avoided. Thanks to @lightonflux for pointing this out https://github.com/koreader/koreader/issues/2555#issuecomment-291039945
7 years ago
Frans de Jonge b076ca1c29 ReaderFooter: fix quick browsing by tapping footer in flipping mode
Fixes #2649.
7 years ago
Frans de Jonge d91bd91840 Terminal plugin: minor language fixes
* ... should be a proper ellipsis
* "written" is a bit more end-user friendly than "dumped"
7 years ago
Frans de Jonge a6ca0f9b55 CreDocument: add "md" (Markdown) to supported filetypes
Fixes #2632.
7 years ago
Robert 3f0ce5de34 Remove invalid UTF8 chars from FTP (cloud storage) and sort order of requires (#2711) 7 years ago
Hzj_jie 3ad3452d1a System Stat plugin (#2699) 7 years ago
Robert a3c4254809 Added util.fixUtf8 (#2704)
* Remove invalid UTF-8 chars from OPDS
* add unit tests
7 years ago
Cosmin Gorgovan c73a1c1fcf Update koreader-base 7 years ago
Hzj_jie 339e16636b Terminal plugin (#2646) 7 years ago
Frans de Jonge eb641b6abc squash: mono-spaced font is necessary for ASCII-art type stuff
* reordered requires
7 years ago
Frans de Jonge e5a3ecd3e5 CreDocument: disable fancy formatting by default
It does significantly more harm than good. It can be reenabled with a `txt_preformatted` setting if desired. Fixes #1607.
7 years ago
Cosmin Gorgovan 10132d1c59 Disable the network asynchronously to avoid blocking the UI
Noticeable latency between toggling the power switch and the device
showing the screensaver has been tracked down to the two network
manager calls. This change allows the screen to be updated first.
Note that unloading the open source brcmfmac driver used on okreader
is slower than unloading the proprietary driver shipped by Kobo,
making this delay even more noticeable.

self.suspend() is scheduled after the network manager calls to avoid
race conditions.
7 years ago
Cosmin Gorgovan 11d6bfbc40 Fix typo in frontend/device/generic/device.lua 7 years ago
Hzj_jie 1a2e4f5b55 Force Kobo to suspend (#2691)
Without this change, the device resumed randomly. With this change, the device had not resumed randomly anymore. (Technically speaking, it still randomly resumed, but got suspended immediately.)
7 years ago
Cosmin Gorgovan 6aeecdba08 Only show the last character of a password after typing it 7 years ago
Qingping Hou 1b700c0044 kobolight(fix): do not consume swipe event if not matched
Otherwise it will conflict with swipe to go back feature
7 years ago
Frans de Jonge cee3603436 TouchMenu: keep hamburger menu on the right 7 years ago
Hzj_jie ed461c7f30 InputDialog is broken by #2672 (#2690)
This change also adds a tap_input_func in both TouchMenu and Button.
7 years ago
Hzj_jie ea2de9638b LuaSettings:wrap() / LuaSettings:child() function to create an LuaSettings to represent a sub table of an existing one (#2685) 7 years ago
Frans de Jonge bdbda9b405 ReaderMenu: fix MenuSorter-related typo (#2689)
Fixes #2688
7 years ago
Hzj_jie 0318a048b4 Read timer plugin (#2672)
A countdown timer to notify user.
7 years ago
Frans de Jonge 791d540a5a FileSearcher: filter .sdr directories
Fixes #2665
7 years ago
Cosmin Gorgovan 3e656d71e0 WiFi manager bugfix: delete the cached psk when changing the password
Previously, the cached psk, which is derived from the password and
passed to wpa_supplicant, was not updated when changing the password.
7 years ago
Frans de Jonge e0c2232237 Menus plugin typo fix 7 years ago