c5a6e86f9b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15600 - Move removal of timed out sessions to immediately after restoration
4 years ago
15cab56493
[fenix] Revert "No issue: remove * ac from codeowners." ( https://github.com/mozilla-mobile/fenix/pull/15638 )
...
This reverts commit 112510aab50b141f910de211e2363c6b81882431.
4 years ago
dbd9a99c76
[fenix] No issue: add custom lint guide to readme.
4 years ago
3cc3ed7e59
[fenix] Update Android Components version to 62.0.20201002143132.
4 years ago
d9aefd1ce2
[fenix] No issue: Update biometric, core, and recyclerview libraries
4 years ago
1add1c7454
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13031 : Show size in KB for smaller downloaded files.
4 years ago
c318e736f9
[fenix] Import l10n.
4 years ago
1d7eaed3ba
[fenix] No issue: remove * ac from codeowners.
...
rocketsroger and I agreed this may be undesireable due to the increased
notifications. If we remove it and someone complains, we can re-add it.
4 years ago
cc4d4a14d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10107 : Show Today and Yesterday labels in History ( https://github.com/mozilla-mobile/fenix/pull/15415 )
4 years ago
e1ffe1108f
[fenix] No issue: replace LintUnitTestRunner with detekt implementation.
...
This should be more performant and easier to maintain.
4 years ago
7e5cad1e66
[fenix] No issue: run detekt on unit test files.
...
detekt still passes after I make this change.
afaik, there isn't a good reason not to run it on unit tests and it can
be valuable to add custom rules for them. Also, detekt is already
running on our androidTest directory.
4 years ago
d81eff94bd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15593 - Reverts back to simple UUID creation without Fenix side caching
4 years ago
5c98159598
[fenix] Update Android Components version to 62.0.20201001194334.
4 years ago
c4c94979ea
[fenix] No issue: document list_compatible_dependency_versions script in README.
4 years ago
635e49092e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15471 : Show Delete button in red in multi-select overflow menu ( https://github.com/mozilla-mobile/fenix/pull/15576 )
4 years ago
482efed8de
[fenix] Import l10n.
4 years ago
a41022554b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15443 : Use fragment's lifecycleScope for AlertDialog actions
4 years ago
33e49d471b
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/15555 : Set channel to Nightly explicitly for SettingsFragmentTest
4 years ago
1589942479
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15559 : Allow tabs to stretch in landscape mode for tablets.
...
This overrides the default tabMaxWidth of 264dp to allow for tabGravity="fill".
4 years ago
a846743af4
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15555 : Intermittent failures in SettingsFragmentTest
4 years ago
a0c00cb3b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15537 - Be more verbose about leanplum identifiers ( https://github.com/mozilla-mobile/fenix/pull/15538 )
4 years ago
192e5dc063
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15535 : hasOpenTabs now considers the selected tab mode in tray tab.
4 years ago
6977b53c5f
[fenix] Block github tagging on push-apk ( https://github.com/mozilla-mobile/fenix/pull/15546 )
...
Currently, push-apk fails to verify its chain of trust if github tagging
is done before it runs. Until this is fixed, we need to make sure
tagging is blocked on pushing.
4 years ago
af732f0748
[fenix] No issue: elaborate on Components class doc.
...
This is to clarify a misunderstanding I found in PR review.
4 years ago
70dbf0d765
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass metrics to share controller" for debug test failures.
...
This reverts commit 5de145914e9fc10d3d647e6f2856c2df19dd9156.
4 years ago
9b598b33d8
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass bookmark storage to controller" for debug test failures.
...
This reverts commit 9825a5d2dfb0f6d3c0235fdf0032e510c34bf20a.
4 years ago
43778cf3cb
[fenix] Show undo snackbars with padding with static bottom toolbar
...
This specifically fixes the close tab snackbar. This commit mirrors
the logic when not using Undo from
e14bf8e791aa56ded47812018f32ee9801a5b4f9. References https://github.com/mozilla-mobile/fenix/issues/14982 .
4 years ago
1429c5ddaf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15324 - Show tab settings and recently closed items in menu when no tabs
4 years ago
8caf149ab7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15503 - Change recently closed max to 10
4 years ago
98f8f3b2ca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13856 - Prevent overscroll in swipe to switch tabs gesture
4 years ago
5a3b5af7d9
[fenix] Extract locale settings initial state
4 years ago
be11bfd5b4
[fenix] Add test for initial logins list state
4 years ago
e4bdd355d3
[fenix] Add tests for initial collection creation state
4 years ago
ac1a2a708a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11561 - changed inactive heading and menu icon color in dark mode
4 years ago
87ecdf8bfb
[fenix] Import l10n.
4 years ago
b55c4af6fb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass bookmark storage to controller
4 years ago
966e13c9aa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass metrics to share controller
4 years ago
a50cf27648
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : fix startup crash by using arg Context.
...
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
4 years ago
53bd004f55
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : remove resetAfter & port tests to StrictModeManager.
4 years ago
d0fbe70f10
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : clean up existing StrictMode test names.
4 years ago
8a9472e540
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : move resetAfter into StrictModeManager.
...
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.
Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```
We're going to have to add a lint check to prevent them from doing that.
4 years ago
5f8943f76c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : change StrictModeManager to class from object.
...
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
4 years ago
76018e2fe0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14034 : Add debug preference to override AMO collection in Nightly
4 years ago
9e86e369b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : comment about duplication in logic in StrictMode.
...
I had to drop a commit that addressed the issue because it was too hard
to fix.
4 years ago
394465e33e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add comment to explain why we only resetAfter in certain build modes.
4 years ago
c1aa8d396a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : use ac StrictMode.resetAfter rather than duplicating functionality.
4 years ago
b2c01e442f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : rename to attachListenerToDisablePenaltyDeath for clarity.
4 years ago
1ec45f33a2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : remove unused penaltyDialog parameter.
...
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
4 years ago
3b76f2b3fc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : always enable detectNonSdkApiUsage.
...
We don't use penalty death for the VM policy so we theoretically don't
need to disable this check if penalty death is enabled.
4 years ago
eca2b8ecf4
[fenix] Use "undo" implementation from Android Components.
...
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.
Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
4 years ago
ekager
Roger Yang
Michael Comella
MickeyMoz
mcarare
Mozilla L10n Automation Bot
Jocelyne
Jeff Boek
Grisha Kruglov
Christian Sadilek
Stefan Arentz
Ben Hearsum
Sebastian Kaspari
Andrew Gaul
TrianguloY
Tiger Oakes
Sören Hentzschel