b9c243c0ec
[fenix] Update TabSessionState.createdAt for inactive tabs debugging
3 years ago
d735df1dd6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20764 separate learn more string
3 years ago
7e548348e3
[fenix] Android Autofill: Use AppCompat theme for UnlockActivity.
3 years ago
3dc3db856c
[fenix] Remove duplicated line in TabsSettingsFragment
3 years ago
eb35f06802
[fenix] Use theming in debug screen.
3 years ago
632311b1ea
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/15168 : Remove intermittent failing test in ToolbarViewTest
...
This test seems to be hacking at the binding between Fenix and the
BrowserToolbar to simulate toolbar events passing to the Fenix
interactor.
This is rather clumsy test that relies on the magic working of mockk
instead of following a general unit testing strategy that would commonly
require the class to be re-written to allow for better testing instead.
It is far safer to remove this test since we are not guaranteeing
anything in it and instead we see intermittent failures that make us
lose more time.
So therefore.. 🔥
3 years ago
d32727eff9
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20796 : Fix intermittent test failure in TrackingProtectionExceptionsInteractorTest
3 years ago
14735a61ae
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20795 : Speculative fix for intermittent test failures in HomeFragmentTest
...
The expectation is that replacing `return` with `answers` will compute
the return value for the extension function again in order to avoid the
error, "no answer found for: Settings".
3 years ago
a590fd2b74
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20797 : Fix intermittent test failures in ShortcutsSuggestionProviderTest
3 years ago
9b20f9c1c0
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20792 : Fix intermittent test failures in QuickSettingsFragmentReducerTest
3 years ago
f2fe9ae61d
[fenix] Filter out test target packages in Flank-x86 ( https://github.com/mozilla-mobile/fenix/pull/20841 )
...
* Filter out test target packages in Flank-x86
* Ignore verifyRunBlockingAndStrictModeSuppresionCount
3 years ago
fce543516e
[fenix] No issue: move kotlin-allopen outside appVariants loop.
...
The kotlin-allopen plugin could be getting applied for each variant we
have in the app. With the changed code, it will only get applied once.
3 years ago
cc2f37b040
[fenix] Use header20 style on collections to match other home items. Add margin above collections. ( https://github.com/mozilla-mobile/fenix/pull/20633 )
3 years ago
00cb0c74f3
[fenix] Update the description for an inactive tabs string
3 years ago
982dc4410f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4134 Add Forward Back Reload to Toolbar on Tablets
3 years ago
4082b5eb90
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20098 : Allow PB PiP video screenshots
...
...when `Allow screenshots in private browsing` is enabled
3 years ago
620d034134
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20596 remove perf.startup probes
3 years ago
d4a2d1ac83
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20764 add screen for opting out of experiments
3 years ago
be0f7d9dcc
[fenix] Disable intermittent tests.
3 years ago
8ff9adb54e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20672 crash when attempting to disconnect from Mozilla account
3 years ago
f4f6b18cbe
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in history screens
3 years ago
c441adb0d8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in collections
3 years ago
21fedbf45f
[fenix] Dismisses search dialog if active in (RecentTabsHeaderViewHolder, RecentBookmarksViewHolderTest) and adapts test for the changes.
3 years ago
b8f673380f
[fenix] No issue: remove unnecessary robolectric annotations.
...
Theoretically, this should marginally decrease the duration of our unit
test suite. In my testing, for 1 iteration each (i.e. noise is very
possible), the duration changed from 9m 32s to 8m 21s – a 71s
improvement.
---
To identify tests that were running with robolectric that didn't need to
be, I removed the @RunWith(FenixRobo... from all relevant files:
sed -i '' "/@RunWith(FenixRobolectric/d" app/src/test/**/*.kt
I ran the tests and discovered which ones failed from the Classes tab of
the index.html test result file. Something like:
tests = document.querySelectorAll('table')[3].querySelectorAll('tr');
failureElements = tests.querySelectorAll('.failures');
// TODO: extract the test names
Then I copied these results to a text file and compared them to all the
files that had robolectric test runners to figure out which ones still
pass:
comm -1 -2 failures.txt changed_files.txt > robolectric_not_needed.txt
And undid the changes to the failing files:
for i in $(cat robolectric_not_needed.txt); do git checkout $i; done
Then I removed the import statements on those files:
for i in $(cut changed_files.txt); do sed -i '' "/import.*RunWith/d" $i; done
for i in $(cat changed_files.txt); do sed -i '' "/import.*RobolectricTestRunner/d" $i; done
3 years ago
7273536742
[fenix] For FNXV2-17067: always show home in background behind search dialog ( https://github.com/mozilla-mobile/fenix/pull/20573 )
...
* Navigate to home on toolbar click. Handle back press from search dialog
Update tests to show home behind search dialog. Remove unused test.
Jump back in show all button is clickable behind search dialog
Recently saved bookmarks show all button is clickable behind search dialog
* Add feature flag
* Past explorations show all button is clickable behind search dialog
Handle keyboard in controllers instead of viewholders. Update tests.
Allow collections to be visible behind search dialog
Dismiss keyboard and search dialog with navigateUp instead of just dismissing the keyboard
Verify navigateUp in tests
Adding ignore for flaky UI test
Only resize home behind search dialog
Add ignore for collection intermittent test
Cleanup
3 years ago
33b08b6b83
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in downloads screen
3 years ago
dcbd978c73
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20425 : Re-add tests for class BookmarksUseCaseTest.
3 years ago
8f3313ad02
[fenix] Start on home UI tests
3 years ago
2120e07768
[fenix] Import l10n.
3 years ago
8c1a00b21c
[fenix] Import l10n.
3 years ago
feb8f5e363
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20726 : Fix intermittent failure in AddonsManagementViewTest
3 years ago
0a0af212f0
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20718 : Show url if title is missing for inactive tabs
3 years ago
3bfd5d1827
[fenix] Correct search_count telemetry after revert
3 years ago
1612db86c8
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20723 : Fix credit card management fragment binding
3 years ago
b4ce5abf0e
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20697 : replace mockked lambda in DownloadControllerTest.
...
This is expected to fix the intermittent failure in this test.
3 years ago
13249f7080
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20679 : revert allowaccessmodification proguard disabling.
...
We disabled the allowaccessmodification proguard option because it broke
functionality or crashed the app (I can't rememeber). As far as we know,
the R8 bug was fixed in the R8 bundled with the Android Gradle Plugin
v4.1. We're now on AGP v7.0.0-rc1 so we should be able to revert this
now.
This commit reverts the following commits:
Revert "Proguard/r8: Do not allow access modification."
This reverts commit d2ec7c648856664c27b31831959fd2e83a580968.
Revert "Dump `proguard-android-optimize.txt` into local configuration for later modification"
This reverts commit c543ae338e0bce4a6e2395f3e72742d9c0d65042.
3 years ago
3c66fa4833
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19956 : Add telemetry for tab view setting changes
...
This differs from `tab_view_setting` which tells us what the user's tab
setting is at startup. It does not tell us if the user explicitly
changed it instead of just using the default (which was recently
changed in https://github.com/mozilla-mobile/fenix/issues/19809 ).
3 years ago
18a51be61c
[fenix] Update Android Components version to 92.0.20210806164329 ( https://github.com/mozilla-mobile/fenix/pull/20722 )
...
Addresses breaking change in ShortcutsSuggestionProvider
3 years ago
6c15482c9d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in bookmarks screen
3 years ago
d4ab4f3572
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20663 : Make inactive card collapsible
...
We use make the inactive tabs section of the tabstray collapsible in
this change, with a technical quirk: we want to make the "isExpanded"
state of the tabs stay for the lifetime of the app and not the tabs
tray, but this functionality does not exist.
In this patch, we're storing the UI state in a singleton class that
exists for the lifetime of the app, but a more concrete solution is to
use an AppStore that holds content like this, which we can land in a
future patch.
3 years ago
75aeb961e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 - Add a Kotlin synthetics Lint detector
...
This would help ease the current refactoring effort by ensuring no new
synthetics usages.
3 years ago
2971cd309d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20310 - Adds Recently Closed button to tabsTray
3 years ago
39561f3644
[fenix] External source support
...
Adds handling of information about external referrer (package, category)
when dealing with external intents.
3 years ago
333840f02e
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/18711 : Telemetry for credit card autofill ( https://github.com/mozilla-mobile/fenix/pull/19548 )"
...
This reverts commit 5d65ba087e6b30a2a34b73b34e15b03bfecace0d.
3 years ago
cffad4f424
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/18711 - Refactor credit card telemetry under the Metrics ping ( https://github.com/mozilla-mobile/fenix/pull/19733 )"
...
This reverts commit f6dd0834df4e2a15de684292a8422279487c5a23.
3 years ago
60da5771b7
[fenix] Import l10n.
3 years ago
b583864643
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20584 - Speculative fix for ToolbarViewTest failing in CI
...
There was an `java.lang.InstantiationError: kotlin.jvm.functions.Function1`
stemming from line 75. See if avoiding nullability helps.
3 years ago
19767246f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20584 - Use CombinedHistorySuggestionProvider for history suggestions
...
This should ensure user is always presented with history results for his
searches.
3 years ago
317bf219d0
[fenix] Import l10n.
3 years ago
cdade5b44a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20664 : Do not consider newly created tabs as inactive
3 years ago
cb4a24d6a6
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/20674 : Remove elevation from inactive tabs card
3 years ago
5949766c5d
[fenix] Enable Android Autofill in Beta builds.
3 years ago
a710775406
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20601 : Use View binding in quick settings.
3 years ago
bd036901ae
[fenix] Import l10n.
3 years ago
39ea051a14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19970 [Crash] IllegalStateException when navigating to TP panel
3 years ago
24b4a03d32
[fenix] Fix intermittent test failures in ToolbarViewTest
3 years ago
b901490a1b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20650 : Revert to manually close tab as default setting
3 years ago
724fb8b60f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20601 : Undo Use View binding in quick Settings.
3 years ago
68bef957b5
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20461 : remove app_received_intent probe.
3 years ago
6109d61cd7
[fenix] Fix UI tests: SettingsPrivacyTest, DeepLinkTest.
3 years ago
6e4060fa5a
[fenix] Add preference for enabling/disabling Android Autofill from within the app.
3 years ago
7f6cdd491b
[fenix] Add dialog-like theme for AutofillSearchActivity
3 years ago
d0ca64a9a4
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20631 : remove @Ignore on StorageStats tests.
...
The errors that caused this to be @Ignored were addressed by a recent PR
landing on master (i.e. the one that renewed the probes this test is
testing).
3 years ago
4a3576d299
[fenix] Fix intermittent test failures in TabsTouchHelperTest
3 years ago
46a11a3f56
[fenix] Import l10n.
3 years ago
7d59c1f786
[fenix] Fix intermittent test failures in DefaultBrowserToolbarControllerTest
3 years ago
5272c60934
[fenix] Fix intermittent test failures in DefaultSessionControlControllerTest.
3 years ago
85309f1d25
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/20627 : replace mocked lambda in HistoryItemMenuTest.
...
This will prevent intermittent failures with Java 11.
3 years ago
e0e46cda2d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20518 : disable metrics we don't want to renew.
3 years ago
f3f4526124
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20518 : link to data renewal request.
3 years ago
d23a7639ae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20518 : renew perf telemetry probes (August expiry).
...
I used eliserichards' PR https://github.com/mozilla-mobile/fenix/pull/20519 to
renew more easily.
3 years ago
1bad9ad91c
[fenix] No issue: fix glean metrics tests for expired metrics ( https://github.com/mozilla-mobile/fenix/pull/20621 )
...
* Remove references to preferences.open_links_in_private and preferences.private_search_suggestions in tests. These metrics have been expired and may be removed.
* Add ignores for performance metrics that have expired.
* Remove tabs_tray.cfr.dismiss and tabs_tray.cfr.go_to_settings telemetry probes.
* Remove metrics controller from signature and remove in tests
3 years ago
a84d30689d
[fenix] For issue: https://github.com/mozilla-mobile/fenix/issues/16396 Fix text contrast ratio on "recently closed tabs"
3 years ago
3fcd0878d4
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20349 : Add inactive tab grouping to tabs tray
3 years ago
0ae2f837b6
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20590 : 'Jump back in' should obey feature flags
3 years ago
bb3071457a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533 : Fix intermittent test failures of DefaultCollectionCreationControllerTest
3 years ago
eafb11112d
[fenix] https://github.com/mozilla-mobile/fenix/issues/7346 update lint-baseline.xml and remove activity_addons.xml as unused resource
3 years ago
b0c410ce60
[fenix] Add history metadata feature to the settings menu
3 years ago
fb66b53852
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533 : Fix intermittent failures of DefaultSessionControlControllerTest
3 years ago
f3027746bf
[fenix] Add more context for the Past Exploration localization comment
3 years ago
0d7aa7a57a
[fenix] Keep history metadata for 14 days
3 years ago
fa26d61a8f
[fenix] Fix intermittent test failures of ModeTest
3 years ago
6ea19d4b17
[fenix] Run ktlintFormat to adapt to latest formatting rules.
3 years ago
bc41dd0b52
[fenix] Add telemetry for Android Autofill feature.
3 years ago
acc5dc1220
[fenix] Fix intermittent test failures of LoginExceptionFragmentStoreTest
3 years ago
2a67850677
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533 : Fix intermittent test failures of ExceptionsListItemViewHolderTest
3 years ago
9ed161ff27
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533 : Fix intermittent test failures in SearchDialogControllerTest
3 years ago
a5716396be
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20533 : Fix intermittent failures of DefaultTabsTrayControllerTest
3 years ago
e3b9c8b633
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in settings screens.
3 years ago
a1ac269c73
[fenix] Import l10n.
3 years ago
2fdd3cc5e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/20516 : Renew product telemetry probes expiring in August ( https://github.com/mozilla-mobile/fenix/pull/20517 )
...
* Renew product telemetry probes expiring in august 2021
* Add placeholder for data reviews
* Allow unneeded metrics to expire in August. To be re-evaluated later.
* Add link to data review
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
cc18008cbe
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19955 https://github.com/mozilla-mobile/fenix/issues/20393 : Add telemetry for home screen recent tabs.
3 years ago
b36321a8ed
[fenix] Fix intermittent test failures in WebPushEngineIntegrationTest
3 years ago
2c38047d32
[fenix] Fix intermittent test failures in FenixSnackbarKtTest
3 years ago
dfb5ee8746
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17917 : Use View binding in lists.
3 years ago
9e42de220f
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/20531 : Fix intermittent test failures in DefaultQuickSettingsControllerTest
3 years ago
c49e052da2
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/19785 : Let WebAuthnFeature ride the trains
3 years ago
cef6144944
[fenix] Put the Start On home setting behind a feature flag.
3 years ago
ad8312ea31
[fenix] Fix intermittent test failures in NavigationInteractorTest
3 years ago
696561599e
[fenix] Fix intermittent test failures in PagedHistoryProviderTest
3 years ago
Jonathan Almeida
Arturo Mejia
Sebastian Kaspari
Aaron Train
Michael Comella
Elise Richards
Steven Knipe
codrut.topliceanu
Rohan Maity
Vitaly V. Pinchuk
mcarare
AndiAJ
Mozilla L10n Automation Bot
Roger Yang
Christian Sadilek
Mugurell
Grisha Kruglov
fevziomurtekin
Gabriel Luong