49a98cb413
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 - Remove feature flag for return to browser ( https://github.com/mozilla-mobile/fenix/pull/16622 )
4 years ago
d23db3c8ee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16614 - Ensure a stable order for the items in tabs tray. ( https://github.com/mozilla-mobile/fenix/pull/16618 )
...
Items should follow the following ordering:
- current session open tabs
- collections options - currently the "Select tabs" button
- synced tabs items
This order should also be kept after returning from Multiselect mode.
4 years ago
42de52ac1c
[fenix] Replace @string/tab_tray_menu_item_save with @string/tab_tray_menu_select, Remove "Share all tabs" option from tab tray's private browsing menu
4 years ago
ad95b57c30
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15091 - Fixes RecentlyClosedAdapter DiffCallback ( https://github.com/mozilla-mobile/fenix/pull/16608 )
4 years ago
2256f29d23
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16153 : Intermittent failures of ShareControllerTest.handleShareToApp
4 years ago
85aa2f4fc9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16420 : Make search bar first view focused by a11y services on open.
4 years ago
0e37184204
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/16587 : Make sure tab counter correctly reflects private/normal tab counts
4 years ago
df087718e1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16053 : Fix crash when closing private tabs via notification
4 years ago
ee11970d27
[fenix] Update Android Components version to 67.0.20201115143123.
4 years ago
8fd55d87f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13477 - Move BiometricPrompt to a separate feature ( https://github.com/mozilla-mobile/fenix/pull/16498 )
...
Instead of simply fixing the memory leak for this issue by directly
removing references, it makes more sense to move the whole
BiometricPrompt out of the fragment and into it's own feature to be
re-usable.
4 years ago
d68aee5549
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16511 - Change a11y parent of button without breaking the tab list. ( https://github.com/mozilla-mobile/fenix/pull/16555 )
4 years ago
a6cef89dc2
[fenix] No issue: move StrictModeManager to perf package.
...
While StrictMode is not exclusively used for performance purposes, it's
primarily used for perf purposes so let's move it to the perf package
and code owner it.
4 years ago
4f82163e36
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15725 : Set up preferences in onCreatePreferences instead of onResume
...
set up preferences in onCreatePreferences instead of onResume so that their visibility is determined before the screen appears rather than after
4 years ago
1ed7efce41
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16477 : Switch to using an extension to update a11y collection info.
4 years ago
2302a589da
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16477 : Migrate updateAccessibilityCollectionItemInfo to extension.
4 years ago
33e8a2b22b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16477 : Update a11y info to collection item for both grid and list.
4 years ago
f73385df4a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16461 - Ensure the proper items order after exiting Multiselect ( https://github.com/mozilla-mobile/fenix/pull/16482 )
4 years ago
957e30453b
[fenix] Fixes Comment on https://github.com/mozilla-mobile/fenix/issues/16563 : DefaultToolbarMenu registering for bookmark changes
...
comment link: https://github.com/mozilla-mobile/fenix/pull/16536#discussion_r522387945
4 years ago
60820051d1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16345 : Update share icon shape
...
updating share icon to a filled shape, like default toolbar menu across all app
4 years ago
c6e4316e75
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16345 : use same share icon across all app
...
replace mozac_ic_share for ic_hollow_share on DefaultToolbarMenu
4 years ago
4a21bcd11c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15761 - [Grid View] Enable the grid view and remove its feature flag ( https://github.com/mozilla-mobile/fenix/pull/16546 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15761 - Part 1: Turn ON the showGridViewInTabsSettings feature flag
* For https://github.com/mozilla-mobile/fenix/issues/15761 - Part 2: Remove the showGridViewInTabsSettings feature flag and show the Tab view preference category
4 years ago
70fb6a8d7a
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/15761 - [Grid View] Enable the grid view and remove its feature flag ( https://github.com/mozilla-mobile/fenix/pull/16535 )" ( https://github.com/mozilla-mobile/fenix/pull/16544 )
...
This reverts commit cb340e88f265cc16ba05edaa54c3a99164560438.
4 years ago
c8ce71a622
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16451 - Change default top sites to Baidu & JD in China build ( https://github.com/mozilla-mobile/fenix/pull/16515 )
...
* Add top sites related strings
* Change default top sites to Baidu & JD in China build
4 years ago
350be5af87
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15761 - [Grid View] Enable the grid view and remove its feature flag ( https://github.com/mozilla-mobile/fenix/pull/16535 )
4 years ago
c129fa2aba
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16132 - Rename normal mode menu item, remove telemetry
4 years ago
a1e4f02882
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14920 - Show a Tabs Tray CFR Banner for grid view tip ( https://github.com/mozilla-mobile/fenix/pull/16466 )
4 years ago
63e2bd3f9e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11376 - Reverse tabs list order ( https://github.com/mozilla-mobile/fenix/pull/16245 )
4 years ago
31d379f36d
[fenix] Revert "Update Android Components version to 66.0.20201111143206."
...
This reverts commit 3a07e10eefe64d955de3b71221bb99e7cfc6b039.
4 years ago
f962ee2d08
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14772 : Crash in Downloads
4 years ago
0afd4bdae5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16076 - Add new "share_image" telemetry event
4 years ago
34196ed813
[fenix] Update Android Components version to 66.0.20201111143206.
4 years ago
f535d467cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16416 : Remove save to collection button from tab a11y list.
4 years ago
a197281092
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16132 - Revise multiselect mode UI
4 years ago
da543114c3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16424 - Focus the right item in tabs tray when using Talkback ( https://github.com/mozilla-mobile/fenix/pull/16472 )
...
To get the index of the current selected browser tab when using reverse layout
we should also account for items placed below of the browser tabs.
The patch here unifies the logic already used for some calls but not all.
4 years ago
23ff2851e6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15720 - Remove unused telemetry ( https://github.com/mozilla-mobile/fenix/pull/15887 )
4 years ago
ebc1ba3b50
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15960 - Enable Grid View in Nightly only ( https://github.com/mozilla-mobile/fenix/pull/16462 )
4 years ago
70852916d6
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16430 : ExternalAppBrowserActivity should not handle incoming intents
4 years ago
489e8cc970
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15764 - Update Tabs summary description. ( https://github.com/mozilla-mobile/fenix/pull/16428 )
4 years ago
0ccff38ebc
[fenix] Update Android Components version to 66.0.20201106143126 ( https://github.com/mozilla-mobile/fenix/pull/16439 )
4 years ago
80e9e1fa8e
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16327 : Refactor MenuPresenter to use browser store
4 years ago
8cc09b5785
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/15934 fix ConcurrentModificationException
...
on WifiConnectionMonitor
4 years ago
c481d0504b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 - review: set LazyMonitored to private.
4 years ago
7ac4b40fa8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : remove redundant lazy wrapper from storage APIs.
...
They're currently lazy { lazy { value } }. Accessing `lazy.value`
directly allows us to make it lazy { value }. This should be more
performant and prevents us from double-counting these components.
4 years ago
9e8fd7c6f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : LazyMonitored implement Lazy + update built-in API use.
...
By having LazyMonitored implement Lazy, we can continue to pass these
values directly into the ac APIs that require Lazy references. For some
reason, implementing `Lazy.value` can replace `operator fun getValue`
required for delegates.
4 years ago
3879697c06
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : replace lazy with lazyMonitored in component groups.
...
By component groups, I mean I applied this to any class with the
class kdoc, "Component group for...".
There are a few instances of lazy we had to keep using the old API to
avoid having to update constructor arguments.
4 years ago
07e69195f2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15279 : add LazyMonitored and tests.
4 years ago
88375a2294
[fenix] For https://github.com/mozilla-mobile/fenix/issues/352 : Delete a download
4 years ago
5344dceead
[fenix] No issue: Update stable androidx and material versions
4 years ago
f3d5862668
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6521 - Remove auto sigin onboarding card ( https://github.com/mozilla-mobile/fenix/pull/16315 )
...
With the Fennec -> Fenix migration complete there is no other Mozilla
application that would serve as a custom account provider hence the automatic
signin would not be possible.
Make this more obvious by commenting out the code that would trigger an
onboarding banner for it but keep the code in the app for when https://github.com/mozilla-mobile/fenix/issues/15694 would add
to Fenix the ability to serve as a custom account provider.
4 years ago
2f04b48e7c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14980 - Effectively disable tabs tray STATE_HALF_EXPANDED ( https://github.com/mozilla-mobile/fenix/pull/16052 )
...
STATE_HALF_EXPANDED cannot be disabled while also keeping fitToContents = true
based on which the tabs tray layout is currently set.
To work around this we'll set a a minuscule height for the tab tray when in
this state and then immediately advance to STATE_HIDDEN so to make it
imperceptible to the users.
Since I couldn't write unit tests because of InflateExceptions in Robolectric
I've written UI tests to protect against regressions.
4 years ago
647117ca54
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13172 - Tab swipe order follows text direction from oldest to newest ( https://github.com/mozilla-mobile/fenix/pull/16178 )
4 years ago
7dab7b2d53
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12971 - Show collection saved snackbar above FAB ( https://github.com/mozilla-mobile/fenix/pull/16311 )
4 years ago
5311233fae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16339 - Initialize FxaAccountManager with also a CrashReporter ( https://github.com/mozilla-mobile/fenix/pull/16340 )
4 years ago
03343e86ed
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16256 : Introduce build flag for "Mozilla Online" variant.
...
This patch introduces a build flag that can be used on demand on the command line (`./gradlew -PmozillaOnline [..}`) or
permanently when added to local.properties (`mozillaOnline`).
At runtime `Config.channel.isMozillaOnline` will return `true` if the flag was set at build time.
4 years ago
b495ffee53
[fenix] No issue - review: clarify thread safety of suppressionCount.
4 years ago
6fed5f3177
[fenix] No issue: make StrictMode suppression count thread safe.
4 years ago
ecd79c4d6e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 : Switch to consumeFlow and add tests
4 years ago
5991d0996e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4652 - Remove activityViewModels workarounds
4 years ago
78850c7e3d
[fenix] 15278 detekt rule runblocking ( https://github.com/mozilla-mobile/fenix/pull/15942 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15278 : added CoroutineManager to count runBlocking calls
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added actual detekt rule for runblocking and its config to the yaml
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added unit test for RunblockingCounter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : renamed StrictModeStartupSuppressionCountTest.kt to PerformanceStartupTest.kt and added runBlockingCount test
* Lint fix
* For https://github.com/mozilla-mobile/fenix/issues/15278 : made runblocking a Long to prevent overflow
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fixed MozRunblocking name, description and moved RunBlockingCounter to perf package
* For https://github.com/mozilla-mobile/fenix/issues/15278:Renamed MozillaRunblockingCheck to MozillaRunBlockingCheck
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added setup for unit test, since it failed without restting counter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Fixed naming for RunBlocking lint check
* For https://github.com/mozilla-mobile/fenix/issues/15278 : removed changes made to test to use runBlockingIncrement
* For https://github.com/mozilla-mobile/fenix/issues/15728 : added test exclusion for runBlocking check
* For https://github.com/mozilla-mobile/fenix/issues/15278 : changed null check and added Synchronized to count setter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fix for nits
* For https://github.com/mozilla-mobile/fenix/issues/15278 : added StartupExcessiveResourceUseTest to CODEOWNERS
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fixed for nits
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Moved increment function to extension function and fixed indentation
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added tests for Atomic Integer extension and nit fix
4 years ago
e564dda990
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6313 - Remove unneeded delay in BrowserAnimator
4 years ago
f60df4a976
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16268 - Allowing multiple task while sharing ( https://github.com/mozilla-mobile/fenix/pull/16275 )
4 years ago
3139337d7f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15931 : Sort Downloads from newest to oldest ( https://github.com/mozilla-mobile/fenix/pull/15939 )
4 years ago
e682cb55cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15430 : Fix StrictMode death on opening app from widget voice search.
4 years ago
c66ab231d5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15430 : Fix StrictMode death on opening app from widget text search.
4 years ago
b85522198c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15963 - Increase touch target for the close button in the tabs tray grid layout
...
We need to ensure it has at least 48dp while also not appearing too big.
4 years ago
58a22af103
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15757 - Avoid the double spacing issues for grid items in tabs tray
...
Items should have a 16dp all around padding.
Have them have a 8dp padding that will add to 16 when placed together.
Have the parent have another 8dp that will add to 16 for when items are placed
to the edge of the available screen.
4 years ago
0dd114beb8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15968 - Show a border for the selected tab in the grid based tabs tray
...
The border for the grid item will now be updated in the same method that
updates the background for the list item.
4 years ago
949d66da5f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9548 - Ability to rename top sites ( https://github.com/mozilla-mobile/fenix/pull/16285 )
...
* Ability to rename top sites, closes https://github.com/mozilla-mobile/fenix/issues/9548
* Highlight the "Remove" top site action as destructive
With more menu items in the top site contextual menu, it makes sense to differentiate
* Added test for the top site renaming action
* Fixed lint check (wildcard imports, blank spaces)
* Applied suggestions from code review
* Apply suggestions from code review
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
* Implemented dialog click listener with manual dismiss/cancel
Co-authored-by: Lorenzo Stanco <lorenzo.stanco@gmail.com>
4 years ago
2d083e853a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14637 - Fix sitePermissionsFeature breaking change + AC bump ( https://github.com/mozilla-mobile/fenix/pull/16229 )
...
* For https://github.com/mozilla-mobile/fenix/issues/14637 - Compatibility patch for AC - 8554
* Update Android Components version to 65.0.20201029143039
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
4 years ago
3047ea3601
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16250 : Disable remote USB debugging for SDK <23.
4 years ago
5fb5471df1
[fenix] For # 15929: Remove the search widget discoverability experiment. ( https://github.com/mozilla-mobile/fenix/pull/16081 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15929 : Remove SearchWidgetCFR telemetry.
* For https://github.com/mozilla-mobile/fenix/issues/15929 : Remove SearchWidgetCFR and search widget experiment.
* For https://github.com/mozilla-mobile/fenix/issues/15929 : Remove unit tests references to search widget experiment.
4 years ago
51018be388
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15413 : Use proper url when bookmarking a page.
4 years ago
df0da31c1f
[fenix] Fix AddonsManagementFragment detekt error
4 years ago
79ab29eff2
[fenix] No issue: Fix onConfigurationChange crashes in Debug build
4 years ago
56c98b57b8
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/11285 : Replace Session[Manager] observers in BaseBrowserFragment
4 years ago
268da65b3f
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15816 - Attempt to handle 'allowInPrivate..' pref with detached context
4 years ago
047b712ffe
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15379 : Use proper url when sharing.
4 years ago
647e73e851
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16199 - Don't pass BrowserToolbarView in onStart when we just need parent
4 years ago
d3faecd59c
[fenix] Fix add-on translation braking changes
4 years ago
f3d03c5e73
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6313 - Set session ClearColor through Engine DefaultSettings
4 years ago
089fe7a9fd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15508 : Show error when trying to save empty or invalid bookmark URL ( https://github.com/mozilla-mobile/fenix/pull/15674 )
4 years ago
ebcb172781
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15543 - Adjust the height of the tabs tray depending on the number of tabs ( https://github.com/mozilla-mobile/fenix/pull/15749 )
4 years ago
6ff5ec846b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 - Feature Flag return to browser ( https://github.com/mozilla-mobile/fenix/pull/16099 )
4 years ago
f8d0a97210
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16084 - Match elevation of Tab in Collection to header ( https://github.com/mozilla-mobile/fenix/pull/16100 )
4 years ago
29a179e8c3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15910 - Adds back automatic toggle, disables slider when enabled ( https://github.com/mozilla-mobile/fenix/pull/16070 )
4 years ago
7f82d5e052
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14619 : Show half a tab top offset when scrolling to selected tab.
4 years ago
ebcf7ea907
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16054 - Enable pull to refresh webpage in Nightly and Debug ( https://github.com/mozilla-mobile/fenix/pull/16060 )
4 years ago
11e73eebfa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15080 : Handle default search engine when editing or removing ( https://github.com/mozilla-mobile/fenix/pull/15768 )
4 years ago
a3fce6b92d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11397 - Add lint rule for AppCompatResources instead of ContextCompat ( https://github.com/mozilla-mobile/fenix/pull/16011 )
4 years ago
09efe75e27
[fenix] FennecWebAppIntentProcessor: Catch JSONException.
4 years ago
274ab54236
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11631 : Move report site issue extension to main menu. ( https://github.com/mozilla-mobile/fenix/pull/15884 )
...
* For https://github.com/mozilla-mobile/fenix/issues/11631 : Move report site issue extension to main menu.
* For https://github.com/mozilla-mobile/fenix/issues/11631 : Update UI test for installing add-on.
4 years ago
85d7bb0baf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15480 - Update the UI when a collection is renamed
4 years ago
ff595c7854
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15688 : Navigate to home screen with arguments on new tab action.
4 years ago
9c7e0ad770
[fenix] Update Android Components, Kotlin, Gradle plugin ( https://github.com/mozilla-mobile/fenix/pull/16021 )
...
* Closes https://github.com/mozilla-mobile/fenix/issues/13262 : Update AGP to 4
* Update to Mozilla Android Components 63.0.20201019090011.
* Update Kotlin to 1.4.10 and Coroutines to 1.3.9.
* Fix new compiler warnings.
* Fix compilation of lint rules module.
* Pin JNA version.
* Fix new lint errors.
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
b931723651
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14744 : Also show Fill link from clipboard with search shortcuts. ( https://github.com/mozilla-mobile/fenix/pull/15885 )
4 years ago
d1e5785dad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15796 - Use the device locale for the system locale subtitle ( https://github.com/mozilla-mobile/fenix/pull/15975 )
4 years ago
36ab249924
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15937 - Remove topFrecentSite feature flag ( https://github.com/mozilla-mobile/fenix/pull/15967 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15937 - Remove the topFrecentSite feature flag
* For https://github.com/mozilla-mobile/fenix/issues/15937 - Hide the "Pull to refresh" preference since its visibility is managed by a feature flag
4 years ago
b7cb6aa53c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7345 - Update new shield icons, remove lottie ( https://github.com/mozilla-mobile/fenix/pull/15909 )
4 years ago
8ec056ffb9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/11286 : Add TelemetryMiddleware to remove Session[Manager] observers
4 years ago
96e38a14eb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15796 - show device language under follow device language ( https://github.com/mozilla-mobile/fenix/pull/15966 )
4 years ago
81556c956a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15596 - Removes upgrade faq link from fennec builds ( https://github.com/mozilla-mobile/fenix/pull/15643 )
4 years ago
aa19f541b2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : change apply to with in GleanMetricsService.
...
While the callback receiver is identical in these two methods, they're
semantically different: apply is for initializing the receiver while with
is anything else benefiting from a new `this` receiver.
I didn't change the usage of apply that has a return statement because I
was afraid my change might change behavior.
4 years ago
910b7f19aa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15644 : mock package inspection dependencies in GleanMetricsService.
...
The new robolectric version changed the behavior such that the app ID
that was returned for our app was `org.mozilla.fenix.debug` instead of
(I guess) `org.mozilla.fenix`. In general, relying on robolectric can be
fragile, such as this case, so it's better to mock. Also, this test
behavior should theoretically have varied between build flavors so
mocking prevents the tests from breaking across flavors.
4 years ago
74b4866e3d
[fenix] Fixes existing lint errors
4 years ago
ef60d82caa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15907 - Remove the usage of the TabTrayGridItemDecorator
4 years ago
9d876a7076
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15347 - Adds telemetry for tabs settings
4 years ago
9f67b3df9b
[fenix] fix detekt errors
4 years ago
3368ddce5c
[fenix] Use new SearchEngineProvider interface.
4 years ago
5baed32e13
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15265 - Save cached top sites for metrics ping
4 years ago
6ee2d5a8dd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 - Launch back to browser if we previoulsy had tabs
4 years ago
3726b8c98b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15853 - Always set fontSizeFactor setting with new text scale
4 years ago
26854525c6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14735 : Remove debug logs from release build. ( https://github.com/mozilla-mobile/fenix/pull/15747 )
4 years ago
53244870e9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15812 : Check for a null context during onScanResult
4 years ago
c63bc04bd2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13168 - Removed the close button from history navigation bar
4 years ago
88268c18a1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - review: clarify init time for External...Activity.
4 years ago
6c86641cbc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10069 - review: change extra name to firstFramePreDrawNanos.
4 years ago
e97a48b48f
[fenix] for https://github.com/mozilla-mobile/fenix/issues/10069 added AppLaunchTimeMeasurement.kt to handle logic of startup time for cold, warm, and hot startup types.
4 years ago
bf2e2d545d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14923 - Removes auto size preference toggle
4 years ago
3aaded4868
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15402 : Hide ETP pop-up if the toolbar is not visible ( https://github.com/mozilla-mobile/fenix/pull/15667 )
...
For https://github.com/mozilla-mobile/fenix/issues/15402 : Hide ETP pop-up when top or bottom toolbar is not visible
4 years ago
17fc28304a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15497 : Hide and remove the three dot menu from the Desktop Bookmarks folder ( https://github.com/mozilla-mobile/fenix/pull/15649 )
...
For https://github.com/mozilla-mobile/fenix/issues/15497 : Remove and disable the three dot menu button
4 years ago
8281e16c83
[fenix] Fix lint warnings and test in site permissions
4 years ago
4f67095c8b
[fenix] Add support for local storage permission
4 years ago
d7a4925a5a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 8: Add a feature flag for showing the grid view in the tabs setting
4 years ago
c95c4de162
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 7: Draw a border around the selected tab
4 years ago
ca8cc56e32
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 6: Display the tab's favicon in the grid view
4 years ago
8a4b3d85d4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 5: Don't draw any background when swiping to delete a tab
4 years ago
b837358f14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 4: Formatted TabTrayView.kt
4 years ago
d7f46fa9f5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 3: Implement a grid view layout for the tabs
...
Co-authored-by: Abhijit Valluri avalluri2@bloomberg.net
4 years ago
88ce83d0d2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15115 - Part 1: Convert the CloseTabsSettingsFragment to a general TabsSettingsFragment
...
- Renames CloseTabsSettingsFragment.kt to TabsSettingsFragment.kt
- Renames close_tabs_preferences.xml to tabs_preferences.xml
- Adds preference options for the switching between the Grid and List tab views
4 years ago
d7ea7c3555
[fenix] No issue: fix tests related to inline change.
...
The difficulty in mocking StrictMode.resetAfter is concerning.
I'm starting to second-guess whether or not making strict mode manager a class
was a good idea.
4 years ago
d23a1b8274
[fenix] No issue: remove inline from StrictModeManager.resetAfter.
...
I believe this was a premature optimization: it's unclear that it would
actually improve performance and yet we had to add several weird
workarounds to make it work that broke encapsulation. It's also
possible it would be worse for the APK size because of excessive
inlining.
4 years ago
848286b7b1
[fenix] Upgrade to Android Component 62.0.20201006190820 with breaking changes
4 years ago
4a56121cc4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15711 : Also add custom engines to fallback list.
4 years ago
f5ff218d46
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8765 : Use shared list widget in collections ( https://github.com/mozilla-mobile/fenix/pull/15733 )
...
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
0934b7fe93
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 - review: add clarifying comments.
4 years ago
86a44fb728
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add marker when StrictMode is suppressed.
4 years ago
19904397b2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add MozillaStrictModeSuppression detekt check.
4 years ago
b6609a0747
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : count StrictMode suppressions on startup.
4 years ago
efc846d57a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15675 : Disable Save button when editing saved login until something has been changed
...
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
4 years ago
8668f5a0d6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15632 : Improve checking open tabs logic to show collection button.
...
Check now considers selected tab tray mode.
4 years ago
c5a6e86f9b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15600 - Move removal of timed out sessions to immediately after restoration
4 years ago
d9aefd1ce2
[fenix] No issue: Update biometric, core, and recyclerview libraries
4 years ago
1add1c7454
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13031 : Show size in KB for smaller downloaded files.
4 years ago
cc4d4a14d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10107 : Show Today and Yesterday labels in History ( https://github.com/mozilla-mobile/fenix/pull/15415 )
4 years ago
d81eff94bd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15593 - Reverts back to simple UUID creation without Fenix side caching
4 years ago
635e49092e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15471 : Show Delete button in red in multi-select overflow menu ( https://github.com/mozilla-mobile/fenix/pull/15576 )
4 years ago
a41022554b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15443 : Use fragment's lifecycleScope for AlertDialog actions
4 years ago
a0c00cb3b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15537 - Be more verbose about leanplum identifiers ( https://github.com/mozilla-mobile/fenix/pull/15538 )
4 years ago
192e5dc063
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15535 : hasOpenTabs now considers the selected tab mode in tray tab.
4 years ago
af732f0748
[fenix] No issue: elaborate on Components class doc.
...
This is to clarify a misunderstanding I found in PR review.
4 years ago
70dbf0d765
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass metrics to share controller" for debug test failures.
...
This reverts commit 5de145914e9fc10d3d647e6f2856c2df19dd9156.
4 years ago
9b598b33d8
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass bookmark storage to controller" for debug test failures.
...
This reverts commit 9825a5d2dfb0f6d3c0235fdf0032e510c34bf20a.
4 years ago
43778cf3cb
[fenix] Show undo snackbars with padding with static bottom toolbar
...
This specifically fixes the close tab snackbar. This commit mirrors
the logic when not using Undo from
e14bf8e791aa56ded47812018f32ee9801a5b4f9. References https://github.com/mozilla-mobile/fenix/issues/14982 .
4 years ago
1429c5ddaf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15324 - Show tab settings and recently closed items in menu when no tabs
4 years ago
8caf149ab7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15503 - Change recently closed max to 10
4 years ago
98f8f3b2ca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13856 - Prevent overscroll in swipe to switch tabs gesture
4 years ago
5a3b5af7d9
[fenix] Extract locale settings initial state
4 years ago
be11bfd5b4
[fenix] Add test for initial logins list state
4 years ago
e4bdd355d3
[fenix] Add tests for initial collection creation state
4 years ago
b55c4af6fb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass bookmark storage to controller
4 years ago
966e13c9aa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass metrics to share controller
4 years ago
a50cf27648
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : fix startup crash by using arg Context.
...
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
4 years ago
53bd004f55
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : remove resetAfter & port tests to StrictModeManager.
4 years ago
8a9472e540
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : move resetAfter into StrictModeManager.
...
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.
Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```
We're going to have to add a lint check to prevent them from doing that.
4 years ago
5f8943f76c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : change StrictModeManager to class from object.
...
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
4 years ago
76018e2fe0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14034 : Add debug preference to override AMO collection in Nightly
4 years ago
9e86e369b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : comment about duplication in logic in StrictMode.
...
I had to drop a commit that addressed the issue because it was too hard
to fix.
4 years ago
394465e33e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add comment to explain why we only resetAfter in certain build modes.
4 years ago
c1aa8d396a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : use ac StrictMode.resetAfter rather than duplicating functionality.
4 years ago
b2c01e442f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : rename to attachListenerToDisablePenaltyDeath for clarity.
4 years ago
1ec45f33a2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : remove unused penaltyDialog parameter.
...
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
4 years ago
3b76f2b3fc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : always enable detectNonSdkApiUsage.
...
We don't use penalty death for the VM policy so we theoretically don't
need to disable this check if penalty death is enabled.
4 years ago
eca2b8ecf4
[fenix] Use "undo" implementation from Android Components.
...
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.
Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
4 years ago
9d9d283dc7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15310 : Also catch ActivityNotFoundException when sharing to app.
4 years ago
b276e9daca
[fenix] No issue: Update AC to 61.0.20200925190057
4 years ago
cf0af49d3b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12383 https://github.com/mozilla-mobile/fenix/issues/15407 https://github.com/mozilla-mobile/fenix/issues/12860 - Switch to using shared view model for session to delete on home
4 years ago
c348e03d0e
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15434 : Don't try to display a 'signed in' snackbar in a 'headless' mode
4 years ago
a0189c8080
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15432 : Invoke UI updates on main thread in response to account events
4 years ago
5bb231cc70
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15436 : Auto-close tabs during startup on the main thread
4 years ago
1d7b1df0e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15130 : Remove "what's new card" from onboarding screen.
4 years ago
739a3520e1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15320 : Ensure Mimetype Other PDF Shows PDF Icon
4 years ago
609857c5f1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14280 , https://github.com/mozilla-mobile/fenix/issues/14743 : Remove old search fragment ( https://github.com/mozilla-mobile/fenix/pull/15169 )
...
* Remove search fragment
* Use new folder to search dialog
* Rebase and lint
* Update tests with search dialog nav directions
* Rename interactor to match naming convention. Remove old controller and point everything to the dialog controller.
4 years ago
2ab099b37b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15349 : Fixes SyncedTabs suggestion not clicking
4 years ago
bc90bd2f31
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15296 : Allow excluding bookmark subtrees when editing parent folder
...
I'm really not a fan of how title overwriting and structure processing are mangled together,
but will leave clearing that up for another day.
4 years ago
9d49be285c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14243 : Pre-land visuals for Close Tabs CFR ( https://github.com/mozilla-mobile/fenix/pull/15171 )
4 years ago
661a48a940
[fenix] Update breaking changes in the FxA/Sync integration
4 years ago
0638e9b3d1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11800 : Hide reveal and clear password icons if the password is empty when editing a saved login ( https://github.com/mozilla-mobile/fenix/pull/15244 )
...
Co-authored-by: Jocelyne Abi Haidar <jocelyne.abihaidar@gotocme.com>
4 years ago
deafcc7387
[fenix] https://github.com/mozilla-mobile/fenix/pull/274-android-l10n : Update create account string to avoid partial translations.
4 years ago
2ddd7950b9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15219 - Fix tab tray handle size.
...
Also use dimens for the tab history handle.
4 years ago
65db93b8b5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15291 - Limit current CFRs to show max one every 3 days
4 years ago
9b953c0255
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15263 : Properly update open links in app preference.
4 years ago
5536851865
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15272 - Remove bottom margin for toolbar on enter fullscreen
4 years ago
2f7edfe924
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15121 - Ensure tabs removed while on browser select an available parent session
4 years ago
d6f5f88deb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15268 : Use safe navigation to addon details fragments.
4 years ago
0b56dd58e4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15284 : Process root titles when creating new folders
...
This also simplifies how we do this. We're no longer creating instances of `DesktopFolder` class
nor creating copies of BookmarkNodes just to display root titles correctly for the 'edit folder' UI.
4 years ago
e2f534e533
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15089 - Disable recently closed in multiselect
4 years ago
231bfe6323
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15112 - Still show recently closed when history empty
4 years ago
4e486c0b40
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15286 : Don't crash when separators are long-touched
4 years ago
9763d05ef2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13934 - Make TabHistory work on PWA/Custom Tabs
4 years ago
f4406b2265
[fenix] No issue: Fixes strict mode death in debug custom tab
4 years ago
ekager
Mugurell
Bryan Kok
Christian Sadilek
mcarare
MickeyMoz
Jonathan Almeida
Mihai Adrian Carare
Michael Comella
Jocelyne Abi Haidar
LeoMaldonado
Gabriel Luong
rxumoz
Codrut Topliceanu
Johan Lorenzo
Kate Glazko
Arturo Mejia
Rafał Opiłowski
Sebastian Kaspari
MarcLeclair
Roger Yang
Jocelyne Abi Haidar
Grisha Kruglov
Elise Richards
Juan C. Goncalves
Tom Klein
Jeff Boek
Shen
sraturi
Sijan Rijal
Stefan Arentz
Andrew Gaul
TrianguloY
Tiger Oakes
Sawyer Blatz
person808