21e848692d
[fenix] Update to latest feature-intent and feature-recentlyclosed APIs (and update Android Components).
4 years ago
9954d20d0a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12732 : Match notification accent color with app theme
4 years ago
cca00bd8eb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13522 : Also remove history entries from tab history. ( https://github.com/mozilla-mobile/fenix/pull/17392 )
...
* For https://github.com/mozilla-mobile/fenix/issues/13522 : Also remove history entries from tab history.
* For https://github.com/mozilla-mobile/fenix/issues/13522 : Test that deleting history also removes it from tab history.
4 years ago
9a85144210
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8716 : Authentication custom tab now considers browsing mode.
4 years ago
3e346542f4
[fenix] Update Android Components version to 71.0.20210108190105
4 years ago
8fd1fbcb80
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16249 - ClipboardHandler cleans up returned text
4 years ago
90eb9cfad5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17117 : Use proper custom tab session for custom tab toolbar menu.
4 years ago
b3f74a3d66
[fenix] Closes issue https://github.com/mozilla-mobile/fenix/issues/16945 Refactor TrackingProtectionOverlay to observe session via store.
4 years ago
edc8c3c7f6
[fenix] Use new RestoreUseCase in A-C to handle tab timeouts
4 years ago
72e6e7e69e
[fenix] Closes issue https://github.com/mozilla-mobile/fenix/issues/16944 Refactor TrackingProtectionPanelDialogFragment to observe session via store.
4 years ago
d9e06f581a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15464 : Always dismiss search dialog on url committed.
4 years ago
39c21ff474
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17303 : Move ext fun runIfFragmentIsAttached to utils
...
move to ext
4 years ago
9a60af122f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16790 - Allow top sites to have an empty name when renamed ( https://github.com/mozilla-mobile/fenix/pull/17290 )
4 years ago
4e1f40b41b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16603 : Disable pull down when in fullscreen ( https://github.com/mozilla-mobile/fenix/pull/17314 )
4 years ago
7e4471eda6
[fenix] Switch to new SessionStorage / session restore API.
4 years ago
fa25b4e258
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17177 - Do not show PBM CFR if entering search on home, make sure fragment attached before showing
4 years ago
3a9df794c1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17298 : Turn on new MediaSession feature for all builds ( https://github.com/mozilla-mobile/fenix/pull/17302 )
4 years ago
c441f2af27
[fenix] 16373 Count the # of inflations done on startup ( https://github.com/mozilla-mobile/fenix/pull/16778 )
...
* For https://github.com/mozilla-mobile/fenix/issues/16373 : Added performance Inflater to counter # of inflations
This class is quite straight forward. The only thing that I have to point out is the onCreateView method. It usually
calls its super if you don't override it. The problem with that is that the super.onCreateView actually uses
android.view. as a prefix for the XML element it tries to inflate. So if we have an element that isn't part
of that package, it'll crash. As I said in the code, a good example is ImageButton. Calling android.view.ImageButton
will make the app crash. The method is implemented the same way that PhoneLayoutInflater does (Another example
is the AsyncLayoutInflater)
* For https://github.com/mozilla-mobile/fenix/issues/16373 : Added test for PerformanceInflater
This test got quite awkward / complicated fast. I wanted to test the to make sure we don't break *any* of our layouts
and to do so, I decided to just retrieve all our XML in our /res/layout folder. However, this gets quite a bit outside of a unit test scope.
The point was to get every layouts and get their LayoutID through the resources using the testContext we have. It gets even weirder, since some
of the XML tags have special implementation in android. One of them is the <fragment> tag. That tag actually is inflated by the OS using the Factory2
that the Activity.java implements. In order to get around the fragment issue, we just return a basic FrameLayout since the system LayoutInflater doesn't deal
won't ever get a <fragment> tag to inflate. Another issue was the <merge> tag. In order to inflate those, you need 1) a root view and 2) attach your view to it.
In order to be able to test those layouts file, I had to create an empty FrameLayout and use it as the root view for testing. Again, I know this is beyond the spirit of a unit test but if we use this inflater, I think it should make sure that no layouts are broken by it.
* For https://github.com/mozilla-mobile/fenix/issues/16373 : Overrode getSystemService to return PerformanceInflater
This allows PerformanceInflater to be called in every inflation to keep track of the number of inflations we do.
* For https://github.com/mozilla-mobile/fenix/issues/16373 : Added UI test for # of inflations
* For https://github.com/mozilla-mobile/fenix/issues/16373 : Lint fix
* For #167373 : Changed the LayoutInflater cloneInContext to take this instead of inflater
The inflater parameter is set on the first call from the OS from the Window object. However, the activity itself sets multiple factories on the inflater
during its creation (usually through AppCompatDelegateImpl.java). This means that, once we initially set the inflater with a null check, we pass an inflater
that has no factory initially. However, since we keep a reference to it, when cloneInContext was called, it cloned the inflater with the original inflater
which didn't have any factories set up. This meant that the app would crash on either browserFragment creation or any thing that required appCompat (such as
ImageView and ImageButton). Now, passing itself with a cloneInContext means we keep all the factories initially set by the activity or the fragment.
* For https://github.com/mozilla-mobile/fenix/issues/16373 : Fixed code issues for PR. No behavior change
* For https://github.com/mozilla-mobile/fenix/issues/16373 : fixed some code nits
4 years ago
04495bb1cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15061 : Fix error text color in SyncedTabsFragment.
4 years ago
b71d813d64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11580 - Tracks text selection context menu usage ( https://github.com/mozilla-mobile/fenix/pull/16968 )
...
* For https://github.com/mozilla-mobile/fenix/issues/11580 - Tracks text selection context menu usage
Tracks Copy, Search, Select All and Share items from the text selection context menu. Uses AC's DefaultSelectionActionDelegate to achieve this.
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
4 years ago
05ded2a9cd
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/13981 Use DEEP_LINK_SCHEME instead of hard-coded fenix
4 years ago
6f8721988c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15703 and https://github.com/mozilla-mobile/fenix/issues/17133 : allow ETP redirect trackers setting to be customized ( https://github.com/mozilla-mobile/fenix/pull/17137 )
...
* Remove ETP redirect trackers feature flag. Add category to ETP panel view.
* Add redirect tracker category to ETP custom settings
4 years ago
6211d0c2be
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17165 - Use application context to get notification localized strings
4 years ago
a7e1ff2c69
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17086 https://github.com/mozilla-mobile/fenix/issues/17143 : Temporarily turn off Nimbus
4 years ago
6c27e44fa1
[fenix] No bug- protect nimbus init from StrictMode ( https://github.com/mozilla-mobile/fenix/pull/17033 ) r=christian
4 years ago
cb2f6a813f
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16949 : Refactor OpenInAppOnboardingObserver to use browser store
4 years ago
52267f2764
[fenix] Switch to new feature-tab-collections API.
4 years ago
7f5c6d46d5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13321 - Do not hide toolbar when opening multiple bookmarks ( https://github.com/mozilla-mobile/fenix/pull/17038 )
4 years ago
d75514d6fa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16483 : Rotate edit arrow when toolbar position is set to bottom.
4 years ago
dd2085b6a0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16068 : Update SUMO links.
4 years ago
04611dda64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17061 : Prevent appBarLayout from leaking.
4 years ago
ac3ca9dbe3
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17045 : Crash caused by calling consumeFlow on wrong thread
4 years ago
621f31efc9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16973 - Use controller handled action instead of toolbar focus
4 years ago
29e329d8f1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16941 - [Telemetry] Bookmark Counts ( https://github.com/mozilla-mobile/fenix/pull/16942 )
4 years ago
4a0ad08ed5
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16946 : Refactor PwaOnboardingObserver to use browser store
4 years ago
27f4c6b494
[fenix] Add search current/home region to debug screen. ( https://github.com/mozilla-mobile/fenix/pull/17015 )
4 years ago
35eaf646a9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15368 - Adds telemetry for fullscreen, pip ( https://github.com/mozilla-mobile/fenix/pull/16833 )
4 years ago
8ad1fdea2d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16827 : Add copy url from long press metrics.
4 years ago
c1216c5079
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15369 : Add synced tabs usage metrics.
4 years ago
86118316f8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15366 : Add recently closed tabs metrics from history fragment.
4 years ago
de2d1d9fd9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15366 : Add recently closed tabs metrics.
4 years ago
2d3fdfdf54
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16422 : Handle theme for tab history bottom sheet.
4 years ago
6019e8c907
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15367 - DownloadsFragment telemetry ( https://github.com/mozilla-mobile/fenix/pull/16728 )
...
Adds a counter for how many times the user does the following action:
- opens the Downloads section inside the app
- tap to open an item from inside Downloads / from the download dialog
- tap to delete one or more downloads at once
4 years ago
cf4631c5c3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11578 - Add telemetry for how many times we download something ( https://github.com/mozilla-mobile/fenix/pull/16730 )
4 years ago
82bc38f76b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4333 : Open the keyboard when a search engine is selected ( https://github.com/mozilla-mobile/fenix/pull/14353 )
...
Co-authored-by: Elise Richards <erichards@mozilla.com>
4 years ago
9a3a4faf12
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/16847 Show the autoplay icon in the toolbar
4 years ago
b5fccc3989
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16937 - Ensure FIP is removed on navigation
4 years ago
02a1474cff
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15403 - Adds a secret debug info screen in settings ( https://github.com/mozilla-mobile/fenix/pull/15540 )
...
Co-authored-by: Elise Richards <erichards@mozilla.com>
4 years ago
cbf04e3fb8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16807 - Make sure there's only one instance of search dialog
4 years ago
0f3b3668db
[fenix] Remove hidden fab in tabs tray ( https://github.com/mozilla-mobile/fenix/pull/16972 )
4 years ago
28d0d32a53
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15636 - Focus a11y collection on snackbar view tap ( https://github.com/mozilla-mobile/fenix/pull/16853 )
...
With accessibility enabled, when adding a site to a collection and tapping "View" on the snackbar, we send a request for focus and an `AccessibilityEvent.TYPE_VIEW_FOCUSED` to the specified collection.
4 years ago
2ac76ff4ce
[fenix] Add withExperiment extension method to Nimbus ( https://github.com/mozilla-mobile/fenix/pull/16926 ) r=christian, sebastian
...
* Fixes https://github.com/mozilla-mobile/fenix/issues/16925 Add withExperiment extension method to Nimbus
* Don't call Nimbus at all if not enabled by FeatureFlag
4 years ago
9dee73b238
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16075 : Add distribution_id in telemetry startup metrics ( https://github.com/mozilla-mobile/fenix/pull/16821 )
4 years ago
5e9e8eca63
[fenix] Prepare for A-C Session[Manager] observable deprecation
4 years ago
361b86b5e6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16442 - Check if fragment is still attached before updating site permissions rules ( https://github.com/mozilla-mobile/fenix/pull/16954 )
4 years ago
6210ff136d
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/16948 : call nimbus.updateExperiments on startup ( https://github.com/mozilla-mobile/fenix/pull/16950 ) r=gl
4 years ago
6727d044c1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16894 : Handle adding voice search button depending on state.
4 years ago
9c15fe3321
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16775 : Fallback to light mode drawable when ui mode is not resolved
4 years ago
07366516cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15640 : Remove private resources from RadioButtonPreference.
4 years ago
fad5cfe71d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15640 : Remove private resources from TextPercentageSeekBarPref.
4 years ago
f92d2a9ef8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16668 - Fix keyboard show/hide from search dialog fragment
4 years ago
1e7a67d0ca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16541 : Download UX Updates
4 years ago
61e10d8561
[fenix] Update IntentProcessors after breaking API change
4 years ago
042f7dd697
[fenix] Add support for EME permission.
...
This accompanies the changes in https://github.com/mozilla-mobile/android-components/pull/9121 .
Closes https://github.com/mozilla-mobile/fenix/issues/1175
4 years ago
ee96af1b9a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13427 - Disable the "selected tab" decoration when in Multiselect
...
Selecting a tab while in Multiselect would add a different decoration to the one
already set for the last tab opened and this would confuse users.
Let's avoid this.
4 years ago
de8ef956c8
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/11290 : Refactor ToolbarMenu to use browser store
4 years ago
30305ae436
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16896 : Integrate new MediaSession API to nightly or debug builds ( https://github.com/mozilla-mobile/fenix/pull/16909 )
4 years ago
bfe1ad1961
[fenix] Reload restored tabs from collection ( https://github.com/mozilla-mobile/fenix/pull/16865 )
4 years ago
89b697a9bd
[fenix] Update Android Components to 69.0.20201207103252.
4 years ago
4328204fc6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16397 - Fixes SignOutFragment crash and invisible button
4 years ago
7421ad5026
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16248 - Cleanup error pages of inlined code ( https://github.com/mozilla-mobile/fenix/pull/16834 )
...
Also streamlined the js code.
The errorPageScripts.js from AC had too much or too little of what we needed.
4 years ago
2dd89dfed4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16133 : Simplify OpenInAppOnboardingObserver condition ( https://github.com/mozilla-mobile/fenix/pull/16851 )
4 years ago
7d2fb5c3b1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15362 : Remove swipe to delete for bookmarks ( https://github.com/mozilla-mobile/fenix/pull/16646 )
...
Removed now obsolete feature flag and tests.
Removed obsolete swipe refresh state from BookmarkFragmentState
Also adapted tests and remove obsolete ones.
4 years ago
198c065970
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/8791 : Use A-C tab counter and upgrades to A-C 69.0.20201203202830
...
Upgrades to A-C 69.0.20201203202830 and addresses breaking changes:
- Upgrades androidx workmanager to 2.4.0 in line with A-C.
- RecordingDevicesNotificationFeature was removed
- SearchUseCases accept parent session ID instead of session itself
4 years ago
6c07bc316f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16629 - Fix for collection snackbar View button ( https://github.com/mozilla-mobile/fenix/pull/16679 )
4 years ago
29047c674f
[fenix] Fix breaking changes from FCM SDK update
4 years ago
1c0e70d647
[fenix] Nimbus-SDK-119 Get Nimbus server endpoint at build time. ( https://github.com/mozilla-mobile/fenix/pull/16682 )
...
This PR builds on [AC#https://github.com/mozilla-mobile/fenix/pull/9024 ][1], and implements setting the Nimbus endpoints from [a secret set at build time][2].
For production use, this requires a secret named `nimbus_url` to be put into CI.
Note: Nimbus is currently behind a feature flag.
If developers wish to use a Nimbus server for local development, you can set the url by adding an entry into local.properties, e.g.:
```
nimbus.remote-settings.url=https://settings.stage.moz4ws.net
```
Without setting server, Nimbus will be able to function, except no experimental definitions will be fetched, and features under experiment will be configured as if not enrolled in the experiment.
[1]: https://github.com/mozilla-mobile/android-components/pull/9024
[2]: https://groups.google.com/a/mozilla.com/g/android-components-team/c/lAGVKQy8aiA/m/rY3uGAwhBAAJ
4 years ago
d1a41ce4cf
[fenix] Adding menu configuration for A/A experiment and A/B experiment ( https://github.com/mozilla-mobile/fenix/pull/16692 )
4 years ago
c549b71c2a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16032 : Support installing recommended add-ons from AMO
4 years ago
9d092df86b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16603 : Disable pull down refresh when activity is in immersive mode ( https://github.com/mozilla-mobile/fenix/pull/16793 )
4 years ago
73ae4c9c72
[fenix] ExternalAppBrowserActivity: Add additional test cases.
4 years ago
1e4efa280d
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/16435 : Open custom tab in Fenix: Force launch outside of and remove current task.
4 years ago
c2bde5c8d8
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/16435 : Finish ExternalAppBrowserActivity and remove task if linked tab doesn't exist anymore.
...
This doesn't fix the underlying issue of https://github.com/mozilla-mobile/fenix/issues/16435 , but a symptom we have seen quite often in different
situations: When the ExternalAppBrowserActivity is not linked to a tab anymore then it falls back
to displaying a (partially broken) browser UI. With multiple browser activities at the same time
sooner or later we crash with a "display already acquired" error because both activities try to
render the same tab.
4 years ago
255e8aab73
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16759 : Prevent crash on showing info banner.
4 years ago
9b853166ac
[fenix] FenixApplication: Remove unused kinto endpoint.
4 years ago
cb755e7ba4
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/12731 : Log and record breadcrumb when onTrimMemory() gets invoked.
4 years ago
9edf548f87
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16735 - Do not show grid view CFR if grid view is already selected. ( https://github.com/mozilla-mobile/fenix/pull/16740 )
4 years ago
a0aeb5eb0a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16676 - Do not switch mode on last private tab via tab context menu
4 years ago
8556ebe1fe
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16592 - Fix missing collection snackbar for a11y ( https://github.com/mozilla-mobile/fenix/pull/16593 )
...
Set null anchor for snackbar when using a11y services
4 years ago
e68c318f1f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16353 : Avoid strict mode death on reading onboarding preference.
4 years ago
a1b3273427
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16353 : Add unit tests for onboarding finishing conditions.
4 years ago
e377bad9b3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16353 : Finish onboarding on loading a web page, with exceptions.
4 years ago
1f4134904d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16353 : Do not finish onboarding on search dialog opening.
4 years ago
09c687da86
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16351 - Add divider lines for search dialog
4 years ago
d50140272a
[fenix] Integrate new search code from Android Components into Fenix.
4 years ago
6a02e68f96
[fenix] Update Android Components version to 68.0.20201120125142.
4 years ago
d001a5aa36
[fenix] Nimbus Global Opt Out ( https://github.com/mozilla-mobile/fenix/pull/16543 ) r=gl
4 years ago
29eb6e9d1f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16351 - Make homescreen interactive when search dialog is up
4 years ago
56bc46801c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15788 : Remove nested layouts in search dialog layout.
4 years ago
36d8481c96
[fenix] Update Android Components to 67.0.20201117165227 ( https://github.com/mozilla-mobile/fenix/pull/16619 )
4 years ago
Sebastian Kaspari
hakkikaancaliskan
Mihai Adrian Carare
mcarare
Christian Sadilek
Mugurell
Arturo Mejia
Gabriel Luong
Roger Yang
ekager
MarcLeclair
Codrut Topliceanu
Elise Richards
jhugman
Sebastian Kaspari
Michael Debertol
Jeff Boek
Kate Glazko
Emilio Cobos Álvarez
Philipp Klein
Jonathan Almeida
MickeyMoz