Colin Lee
4c2a7ac10e
Delete AUTH_SESSIONS with COOKIES
2019-09-09 12:32:28 -07:00
Colin Lee
758f4c13ec
Updates per UX and PR feedback
2019-09-09 12:32:28 -07:00
Colin Lee
2b9efccfca
For #3106 : Granular options for clearing user data
2019-09-09 12:32:28 -07:00
Petru Lingurar
53341f620a
Code cleanup - Remove unused FindInPageBarBehavior
...
There is a "unused" lint suppression in place with the comment
"Referenced from XML". I found no such usage.
It's documentation says that this Behavior will always position FindInPageBar
above BrowserToolbar but the current code ensures
BrowserToolbar.visibility == GONE when FindInPageBar.visibility == VISIBLE
so there's no need for such behavior.
2019-09-06 14:20:02 -04:00
Petru Lingurar
716cf3995a
Fix #4856 - Propagate LifecycleAwareFeature's onStart() to the inner feature
...
FindInPageFeature is used inside the app as a LifecycleAwareFeature and as such
it receives the onStart / onStop lifecycle calls.
The onStart() lifecycle call would not get passed to the feature but in
onStop() FindInPageFeature will detach it's Presenter and Interactor so when
the user comes back to the screen she could not interact anymore with the
feature.
To fix this we'll propagate LifecycleAwareFeature's onStart() to the inner
feature which is to rebind it's Presenter and Interactor in onStart().
This behavior is common to all the other features so all of them who implement
LifecycleAwareFeature will now get the onStart() call also.
2019-09-06 14:20:02 -04:00
Mihai Adrian
ed0b6bd5ef
For #4193 - Makes close button for tabs more accessible ( #4442 )
...
* fixes #4193 - made close button for tabs more accessible.
set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button and text as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
* Fix margins
2019-09-06 10:33:55 -07:00
Sawyer Blatz
aef087aae0
No issue: Removes unused nestedScrollQuickActionView ( #5143 )
2019-09-06 09:03:24 -07:00
Sawyer Blatz
2653b5966e
For #964 : Adds ability to disable each suggestion provider ( #5096 )
...
* For #964 : Adds ability to disable each suggestion provider
* Fix nit
2019-09-05 14:45:44 -07:00
Jonathan Almeida
ccd9e44a3e
No issue: Add logging for firebase/autopush
2019-09-05 16:03:36 -04:00
Emily Kager
58287cd5bb
For #5033 - Update browsing mode when session selected ( #5118 )
2019-09-05 14:27:30 -05:00
Emily Kager
bb2a685ad9
For #5075 - Fix boolean error for private mode notification persistence ( #5120 )
2019-09-05 09:21:56 -07:00
Sebastian Kaspari
3a35233ac0
Remove ThumbnailsFeature. ( #5127 )
...
We currently do not use thumbnails anywhere in the app. Not using the feature means we are
not taking thumbnails on every page load which means we are saving memory and CPU cycles.
2019-09-05 11:05:37 -05:00
Grisha Kruglov
231924f5eb
Fix breaking services APIs changes
2019-09-05 13:38:15 +02:00
Sebastian Kaspari
2c7fd93c7d
Update to Mozilla Android Components 12.0.0-SNAPSHOT.
2019-09-05 13:38:15 +02:00
Sebastian Kaspari
c2db07acf8
Add browser-state component.
2019-09-05 13:38:15 +02:00
Emily Kager
a5e9da7a55
For #5025 - Do not remove custom tab session with config removed
2019-09-05 10:57:37 +02:00
Sawyer Blatz
09dcdb079d
For #4474 : Adds what's new button to home screen menu ( #5088 )
...
* For #4474 : Adds what's new button to home screen menu
* For #4474 : Adds tests for what's new button
2019-09-03 15:16:29 -05:00
Petru Lingurar
46b09395f8
For #5067 - Refactor ShareControllerTest following the use of SendTabUseCases
2019-09-03 12:01:26 -07:00
Petru Lingurar
f7087e46e3
Fix #5067 - Refactor ShareController to use SendTabUseCases
...
Navigation between app fragments uses ShareTab as arguments. The newly used
SendTabUseCases uses TabData which is not Parcelable.
For minimal changes we'll keep both data classes and ShareController will know
how to map between the two.
Removed the `sessionId` property of ShareTab as it isn't needed anymore.
2019-09-03 12:01:26 -07:00
Sebastian Kaspari
ba05d21657
Fix ktlint MaxLineLength issues.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
38d97fda8b
Stores: Reduce visibility of reducer functions.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
2723a55b03
Rename HistoryStore/State/Action to HistoryFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
f3d8a89c63
Rename AccountSettingsStore/State/Action to AccountSettingsFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
61e84c161d
Rename SearchStore/State/Action to SearchFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
22446263f1
Rename ExceptionsStore/State/Action to ExceptionsFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
ac32a88d45
Rename BrowserStore/State/Action to BrowserFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
76063e307a
Rename BookmarkStore/State/Action to BookmarkFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
mihai-adrian
fc8fc2b33d
Fixes #4997 : Changed navigation to ShareFragment
...
Added global navigation action to share fragment in navigation graph
Changed share action to use global navigation to ShareFragment
2019-09-03 07:08:08 -10:00
Colin Lee
709588572a
For #5055 : Crash when opening bookmarks ( #5058 )
2019-08-31 17:41:50 -05:00
Christian Sadilek
4cf03be236
For #2088 : Use new async API to load default search engine in HomeFragment
2019-08-30 17:56:18 -04:00
Sebastian Kaspari
9b633f7f0f
Move creation of GeckoRuntime to flavor-specific source set.
...
Since we are now able to build against GeckoView Nightly and GeckoView Beta,
we should create the GeckoRuntime from a flavor-specific source set.
Creating the runtime is not covered by the AC abstraction and so API changes
in GeckoView Nightly can break the build and leaves us with no option to fix
it from a shared code base. Separating the creation of GeckoRuntime
allows us to adapt individually and also to configure the runtimes
differently.
2019-08-30 15:16:12 +02:00
Will Hawkins
3abffd5d77
Use new async API to load and access search engines
...
Use the new asynchronous features of the search engine
manager from a-c to avoid the latency required to load
the default search engine.
2019-08-29 18:16:02 -07:00
Mugurell
bf5b0e5cda
For 4007 - Add unit tests for the Share Interactor, Controller and list Adapters
2019-08-29 18:12:50 -07:00
Mugurell
e165868a53
For #4007 - Add ShareController for handling ShareFragment's business logic
...
`ShareController` defines a contract with all possible `ShareFragment`'s
behavior changes and comes with a default implementation -
`DefaultShareController`.
It is to be delegated by all `ShareFragment`s contained Views' Interactors
following any user interactions.
2019-08-29 18:12:50 -07:00
Mugurell
16eba61b25
For #4007 - ShareFragment will set the contained Views' state
...
ShareFragment which acts as a container would contain all business logic needed
for populating it's Views.
Data initialization should be done only once since the app state has no reason
to change after the ShareFragment is created and is done as soon as possible,
in onAttach().
Because of the expected short lifespan of this fragment, given the fact that
the state has no reason to change and we handle orientation changes ourselves
to keep things simple I didn't use a ViewModel to persist the state.
2019-08-29 18:12:50 -07:00
Mugurell
095870145f
For #4007 - Refactor AppShareView in standalone Share Views
...
In an effort to respect the initial MVI architecture I've broken the
complex `AppShareView` in 3 separate Views
- `ShareCloseView`
- `ShareToAccountDevicesView`
- `ShareToAppsView`
They are standalone Views (extending LayoutContainer) which know nothing about
each other or their parent and so offer their container the possibility to
order or display them in any form later.
According to the lib-state contract they are only responsible to
- inflate themselves in their injected containerView
- render a certain state (to be added in later commits)
- delegate all user interaction to an associated Interactor
2019-08-29 18:12:50 -07:00
Mugurell
5e19741ddd
For #4007 - Use camelCase for views referenced from code
...
As per #4341 .
Also reformatted layouts to have a more consistent style.
Also refactored `AppShareRecyclerView` and `AccountDevicesShareRecyclerView` by
defining their LayoutManager in XML to reduce code complexity.
2019-08-29 18:12:50 -07:00
Tiger Oakes
fb907033bb
Add comments to AuthCustomTabActivity
2019-08-29 15:06:34 -07:00
Sawyer Blatz
cea18f31c4
For #3892 : Fixes help link on nightly ( #4956 )
2019-08-29 13:27:50 -07:00
Mihai Adrian
9b911f3276
Fixes #4894 : added workaround for SDK<24 vector drawable with gradient color ( #4944 )
...
Removed drawableStart and added ImageView in layouts
Set ImageView logo programmatically: bitmap for SDK<24, vector for SDK>=24
Added onClickPendingIntent for ImageView in large and medium layouts
2019-08-29 12:55:51 -07:00
Tiger Oakes
f740d4382a
Closes #773 - Add shortcuts to homescreen ( #4925 )
2019-08-29 14:45:11 -05:00
mihai-adrian
5e78420cce
Fixes #3602:navigate to top of home screen after tapping "start browsing"
...
After onboarding.finish(), scrolled homeLayout to top
2019-08-29 07:45:04 -07:00
Jonathan Almeida
f25a9660e8
Closes #4218 : Remove forced registration renewal for push
2019-08-28 21:14:12 -04:00
Jonathan Almeida
18ca62b887
For #4063 : Remove SendTab feature flags
2019-08-28 21:14:12 -04:00
Yeon Taek Jeong
d87b8a8a5c
For #4658 : Add some private browsing mode telemetry ( #4968 )
2019-08-28 14:41:37 -07:00
Sawyer Blatz
09ed721015
For #4969 : Removes erroneous FxA sign up ping ( #4970 )
2019-08-28 14:32:43 -07:00
Yeon Taek Jeong
cc5408d717
For #2053 : Add persistent notification to close all private browsing tabs ( #4913 )
2019-08-28 12:55:24 -07:00
Sebastian Kaspari
aa5069caca
Closes #4215 : CustomTabActivity: Remove attached session if activity is finishing. ( #4985 )
2019-08-28 11:03:04 -07:00
Emily Kager
7b5ed2673b
For #4863 - Remove delay in HomeFragment onPreDraw
2019-08-28 13:48:14 -04:00
Suraj Shah
66a8c04967
Fixes #4488 : Shows snackbar on bookmark deletion from edit fragment ( #4792 )
...
* Fixes #4488
Updates changelog
* Removes wildcard imports.
* Removes custom label in use, replaces with let
2019-08-28 10:12:39 -07:00
Sebastian Kaspari
8608375eac
Use Mozilla Android Components 10.0.1.
2019-08-28 15:31:25 +02:00
Jonathan Almeida
681257bea7
For #4960 : Initialize push only if available ( #4964 )
2019-08-27 14:15:38 -07:00
Jeff Boek
bfb2beabe7
For #4063 - Always enable the push service ( #4932 )
2019-08-27 13:12:29 -07:00
Tiger Oakes
d1964d6536
Fixes #4771 - Add method for sessions of type ( #4782 )
...
Fixes share tabs to use the new method
2019-08-27 13:04:03 -07:00
Emily Kager
1cf8a40059
For #4295 - Adds Experiments Pref to Data Collection Settings ( #4915 )
2019-08-27 12:56:16 -07:00
Sebastian Kaspari
c322343248
Closes #4431 : Enable feature-media component for all builds. ( #4898 )
2019-08-27 12:51:27 -07:00
Emily Kager
a65f220b39
For #4921 - Adds WindowFeature to BaseBrowserFragment
2019-08-27 15:33:59 -04:00
Arturo Mejia
24f79b3263
Fix safe browsing API breaking change. ( #4946 )
2019-08-27 13:43:22 -05:00
Sourabh
091778a4b9
For #4398 - add HistoryController ( #4837 )
2019-08-27 10:33:40 -07:00
Amaan Marfatia
dc9fdd9db3
Fixes #4067 besides snackbar ( #4777 )
...
* Fixes #4067 besides snackbar
Makes layout hierarchy more shallow to increase performance.
* Fix #4067 Feedback
Make sure quick_action_overlay appears on top and use horizontal chain in tab_header.
2019-08-27 10:09:55 -07:00
Tiger Oakes
66e14959ba
Add custom tab fragment
2019-08-23 16:12:19 -04:00
ekager
ffbbe119f3
For #3967 - Invoke pending deletion on back pressed
2019-08-23 15:32:27 -04:00
ekager
b07df9698a
For #4868 - Update content description of tabs button with number of tabs
2019-08-23 09:21:32 -07:00
Grisha Kruglov
282c2dc182
No issue: only sync once on startup
2019-08-23 12:08:11 -04:00
Emily Kager
b9f6f7fa93
For #4779 : Don't double navigate with global directions in HomeActivity
2019-08-23 12:01:28 -04:00
Emily Kager
84b0693fd2
For #4652 : Use workaround for HomeScreenViewModel ( #4887 )
2019-08-22 13:35:51 -05:00
Tiger Oakes
9f154dc3a0
Extract intent processors from HomeActivity ( #4884 )
2019-08-22 13:31:40 -05:00
Tiger Oakes
79e58250fc
Make Settings.instance private
2019-08-22 08:14:08 -07:00
Sebastian Kaspari
f62e295fc6
Closes #4874 : Use new build types in FeatureFlags class.
2019-08-22 08:12:49 -07:00
Tiger Oakes
c475bc87cf
Move classes out of top-level package
2019-08-21 13:52:30 -07:00
Jeff Boek
68f5d211d3
For #4326 - Updates codebase to support latest version of detekt
2019-08-21 13:50:51 -07:00
Colin Lee
051ae9f584
For #3869 : Switch to A-C SearchLocalizationProvider ( #4858 )
...
* For #3869 : Switch to A-C SearchLocalizationProvider
* Fix test
2019-08-21 11:14:59 -07:00
Mihai Adrian
df3e1bf9d3
Fixes #4795 fixed requestDesktopStateProvider value from private to desktopMode ( #4810 )
...
RequestDesktopStateProvider was taken from private instead of desktopMode
2019-08-21 09:10:06 -07:00
Tiger Oakes
aab357845b
No issue: Clean up preferences code ( #4699 )
2019-08-21 08:38:14 -07:00
Emily Kager
c1b1c2f332
For #3967 - Invokes pending deletion with more bookmark actions ( #4522 )
2019-08-21 08:36:41 -07:00
Jonathan Almeida
71a2478f4d
Use Mozilla Android Components 10.0.0
2019-08-21 10:06:05 -04:00
Emily Kager
416e25e8a5
No issue: Don't show session provider in private mode
2019-08-20 16:09:55 -07:00
Yeon Taek Jeong
6f899c7fb5
For #2834 : Delete all Private Tabs redesign ( #4787 )
2019-08-20 13:10:08 -07:00
(´⌣`ʃƪ)
c076cc85f9
For #4436 : Dismiss onboarding before navigating away from home ( #4801 )
2019-08-20 10:56:28 -07:00
Tiger Oakes
33f3b14c29
Adds setters and property delegates in Settings ( #4809 )
...
* Change Settings to use setters
* Add delegate for shared preferences
2019-08-20 10:47:55 -07:00
Tiger Oakes
ac6c1ec2ee
Closes #2690 - Clean up CreateCollection viewmodel ( #4731 )
2019-08-20 10:45:41 -07:00
Tiger Oakes
9ee8c00928
For #4774 - Use vector drawable compat ( #4811 )
2019-08-20 10:43:02 -07:00
Tiger Oakes
ad98b2f3ea
For #4744 - Extract private browsing button ( #4813 )
2019-08-20 10:41:18 -07:00
Tiger Oakes
090e8006b0
Color the system bars in custom tabs ( #4819 )
2019-08-20 10:13:01 -07:00
Tiger Oakes
95ef312b1e
Issue #1000 - Remove isCustomTab flag ( #4656 )
2019-08-20 10:00:49 -07:00
Sourabh
1afc0eacd8
For #4399 : Create LibState Controller for Search ( #4673 )
...
* For #4399 : Create LibState Controller for Search
* fix code format
* add unit tests for DefaultSearchController
* add more test
* fix unit tests
2019-08-20 09:07:00 -07:00
Mugurell
ab6e7dc52b
Fix 4827 - Use ktx doOnPreDraw() to restore HomeFragment's layout
...
The previous solution would result in a crash because the passed in
viewTreeObserver that would trigger onPreDraw would be invalid.
The proposed solution is simpler and ensures we'll always use the right
viewTreeObserver.
`FragmentPreDrawManager` is general enough that can be used by other Fragments
also, so I've added it to the `utils` package.
2019-08-20 13:45:55 +02:00
Tiger Oakes
b8c93107c0
For #4744 - Extract TransitionPreDrawListener ( #4812 )
2019-08-19 16:27:43 -07:00
Tiger Oakes
a632d8f1dc
For #4744 - Move search bar icon padding to dimens ( #4814 )
2019-08-19 16:22:51 -07:00
Emily Kager
fb1d655d96
Closes #4822 - Update Bookmark State in onResume ( #4823 )
2019-08-19 16:22:20 -07:00
Sawyer Blatz
0d4eceed56
For #2706 : Refactor Glean to reduce errors ( #4753 )
...
* For #2706 : Adds recording for untracked events
* For #2706 : Adds key alignment to Metrics
2019-08-19 15:25:48 -07:00
Sawyer Blatz
4731977f5d
For #4421 : Fixes issues with new glean events ( #4816 )
2019-08-19 14:49:48 -07:00
Sawyer Blatz
73e3db8fe0
For #4804 : Resolves issue with crash reporter stack
2019-08-19 16:40:41 -04:00
Arturo Mejia
210868f5bc
Use Mozilla Android Components 9.0.0-SNAPSHOT. ( #4750 )
2019-08-19 10:29:10 -07:00
Suraj Shah
806961094b
Fixes #4704 ( #4728 )
...
* Fixes #4704 . Overrides `setEnabled` for DeleteBrowsingDataItem to change view alpha when disabled and to toggle the checkbox `isEnabled` behavior based on the value provided.
* Updates CHANGELOG.md
* Removes unnecessary disabling of checkbox in DeleteBrowsingDataItem.kt
Updates CHANGELOG.md to reflect the component changed.
2019-08-19 09:23:12 -07:00
Mugurell
645674c9bd
Closes #4396 - Add a Bookmarks Controller ( #4593 )
...
* For #4396 - Rename BookmarkInteractor methods
Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.
Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.
* For #4396 - Add a BookmarkController
It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.
This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.
* For #4396 - Refactored Bookmark related tests
Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`
Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
Tiger Oakes
de14962e3f
Extract quick action sheet observer code ( #4368 )
2019-08-19 08:28:33 -07:00
Emily Kager
7d02354f4f
For #4799 #4790 - Don't use passed in sessions in BrowserToolbarController ( #4800 )
2019-08-18 20:36:40 -05:00
Colin Lee
d1aed157dd
For #4686 : Fix potential security issue ( #4764 )
2019-08-16 16:50:54 -05:00
Yeon Taek Jeong
d4c83f9668
For #4736 : Display search shortcuts only from home or search widget
2019-08-15 12:24:54 -04:00
Yeon Taek Jeong
a680d733c8
For #4384 : Hide mic icon if speech-to-text is unavailable ( #4701 )
2019-08-14 16:40:21 -07:00
Yeon Taek Jeong
2441592ef2
For #4516 : Use full width for large search widgets ( #4659 )
2019-08-14 16:00:13 -07:00
Emily Kager
f71106cb51
Closes #3860 - Update description text for collections
2019-08-14 17:13:52 -04:00
Sawyer Blatz
b7ca520787
For #4421 : Adds Leanplum events and attributes ( #4626 )
...
* For #4421 : Adds Leanplum events and attributes
* For #4421 : Adds Leanplum deep links
2019-08-14 13:48:45 -07:00
Yeon Taek Jeong
67f3b63ae5
For #4421 : Add search widget attribute to Leanplum ( #4694 )
2019-08-14 12:00:29 -07:00
Yeon Taek Jeong
f5ffe3734c
For #4457 : Adds telemetry for search widget actions ( #4714 )
2019-08-14 11:39:54 -07:00
Yeon Taek Jeong
2f265eccbd
For #4732 : Fix search engine display issue ( #4735 )
2019-08-14 11:03:14 -07:00
Michael Cooper
12371ca9c1
Add no-op experiment to test service-experiments integration ( #4551 )
...
* Add no-op experiment to test service-experiments integration
* Shorten metric name to meet schema
* Add active_experiment metric to docs
* Add approved data review
2019-08-14 12:07:41 -05:00
Tiger Oakes
3acabeb6c3
Use global navigation action for browser fragment ( #4691 )
2019-08-14 11:58:29 -05:00
Colin Lee
5b4a441bcb
For #1667 : Screen reader can't reach other UI items when QAB expanded ( #4695 )
2019-08-14 09:56:29 -07:00
Emily Kager
1328d686aa
No issue - Autoformatting ( #4715 )
2019-08-14 09:40:46 -05:00
Sourabh
42e3b2771e
fix #4633 : show toast only on first login ( #4676 )
...
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
2019-08-13 16:28:34 -05:00
(´⌣`ʃƪ)
5aac05859d
Fix #4436 : hide onboarding before navigating to settings ( #4675 )
...
* Fix #4436 : hide onboarding before navigating to settings
* No issue: Rename emitAccountChanges to emitModeChanges
2019-08-13 15:49:42 -05:00
Sebastian Kaspari
d03c15d15c
Issue #4431 : Integrate feature-media component (Nightly and debug builds only). ( #4683 )
2019-08-13 15:02:20 -05:00
Colin Lee
0c8bcd39be
For #4652 : HomeFragment Crash "Can not.. after onSaveInstanceState"
2019-08-12 15:51:49 -04:00
Jorge De Los Santos
337ad1e88e
For #3424 - Make talkback ignore ImageButton in Collection Sele… ( #3792 )
...
For #3424 - Make talkback ignore ImageButton in Collection Selection by removing contentDescription and setting importantForAccessibility=no
2019-08-12 11:49:25 -04:00
Grisha Kruglov
b38b94ed79
Closes #4671 : Fix a potential NPE in BookmarkFragment
2019-08-12 11:16:28 -04:00
Grisha Kruglov
634ee184a6
No issue: add some BookmarkFragmentInteractor tests
2019-08-09 17:27:58 -07:00
Grisha Kruglov
f323105163
No issue: reduce code duplication in BookmarkFragmentInteractor
2019-08-09 17:27:58 -07:00
Christian Sadilek
5fe05e919a
For #4125 : Suppress coroutine warning to fix release build
2019-08-09 17:30:27 -04:00
Sawyer Blatz
0ec92d716f
For #4123 : Adds telemetry for quick action open in app ( #4629 )
2019-08-09 13:51:12 -07:00
Yeon Taek Jeong
6c9ce784b1
Fix, add some tests
2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
2a6069bfb7
Fix rest of issues
2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
69434a765f
Fix most issues
2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
faf0ecbcc0
For #4125 : Migrate Sign in to Sync to Libstate
2019-08-09 13:39:51 -07:00
Colin Lee
7f07eabbd8
For #4652 : Crash "Can not perform this action after onSaveInstanceState" ( #4654 )
2019-08-09 14:46:40 -05:00
Tiger Oakes
52542708aa
Consodilate private browsing code
2019-08-09 11:00:41 -07:00
Jonathan Almeida
23f5ac0fb9
For #4066 : Create InflationAwareFeature for lazy inflation
2019-08-09 11:48:55 -04:00
Colin Lee
519c3bde5d
For #4066 : Provide lazy inflation of Find In Page View
2019-08-09 11:48:55 -04:00
Colin Lee
c9c43260c9
For #4529 : Handle crash initializing CreateCollectionViewModel late ( #4628 )
2019-08-08 17:40:55 -05:00
Christian Sadilek
e26570054a
Suppress warning in LeanplumMetricsService to fix release builds
2019-08-08 15:17:12 -04:00
Mathieu Leplatre
04daf21437
Fix #4612 : Fetch experiments from Remote Settings CDN
2019-08-08 10:15:01 -07:00
Colin Lee
ef97173cd9
For #4529 , #4427 : Resuming after restoring instance state breaks UI ( #4571 )
...
* For #4529 , #4427 : Resuming after restoring instance state breaks UI
* Clear up warnings
2019-08-08 11:05:01 -05:00
Sawyer Blatz
ff6e9bccb7
For #4451 : Adds tests for DefaultBrowserToolbarController ( #4493 )
...
* For #4451 : Adds tests for DefaultBrowserToolbarController
* Continue working
* Large refactoring of test
* Mock analytics
* Fix merge conflicts
2019-08-08 09:02:42 -07:00
Hakkı Kaan Çalışkan
0ea595743d
Fixes #4562 : Add a-c git hash to about page
2019-08-07 16:59:11 -07:00
Emily Kager
0b98d43c23
Closes #4602 - Add back transitions
2019-08-07 16:56:21 -07:00
Sawyer Blatz
4566bd6fba
Fixes feedback
2019-08-07 16:41:29 -07:00
Sawyer Blatz
4d14735935
For #3060 : Adds Leanplum attributes for fxa syncing
2019-08-07 16:41:29 -07:00
Sawyer Blatz
9d65e665e5
No issue: Removes deprecated usage of ViewModelProviders
2019-08-07 19:21:41 -04:00
Yeon Taek Jeong
ec4d62c895
Fix ktlint
2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
00bd26abe3
Remove task flags
2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
f952234c57
Keep CLEAR_TASK
2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
c87468d031
Remove popBackStack
2019-08-07 19:17:56 -04:00
Yeon Taek Jeong
a8526a0606
For #4438 : Fix crash when opening any URL from URL bar w/ long press
2019-08-07 19:17:56 -04:00
Sawyer Blatz
969d17b4a9
For #969 : Adds more telemetry for collections ( #4539 )
2019-08-07 16:05:20 -07:00
Sawyer Blatz
da06b0fb15
For #4508 : Treats warnings as errors ( #4543 )
2019-08-07 14:00:53 -07:00
Grisha Kruglov
f23f3b7489
Closes #4467 : Use a-c version of FirefoxAccountsAuthFeature
2019-08-07 13:42:39 -07:00
ValentinTimisica
59c60ef189
Fixes #4354 : Updated SearchFragment state after returning from SearchEngineFragment.
...
The user has the option to go to 'Shortcuts' -> 'Search engine settings' to
modify the default search engine. When returning from that settings screen we
need to update it to account for any changes.
For this we will check the current default engine against a previously stored
value in a newly added 'defaultEngineSource' property from SearchState class.
Also, I modified 'SearchStoreTest' by adding the new parameter to the
'SearchState' constructor.
2019-08-07 13:19:53 -07:00
Colin Lee
a514cb3f8c
No issue: Add OSS licenses link to About page
2019-08-07 12:40:10 -07:00
Sawyer Blatz
f9288c7fbd
For #969 : Finalizes collections telemetry ( #4592 )
2019-08-07 10:26:52 -07:00
Emily Kager
8194e0778e
For #4026 - Update BookmarkDiffUtil to update on Title or URL change
2019-08-07 00:37:16 -04:00
Emily Kager
0604e9858d
Closes #3939 - Adds strings for delete browsing history
2019-08-06 16:06:56 -07:00
ValentinTimisica
71aedc79fe
Fixes #3922 : Added accessibility announcement for history empty state.
...
Sent an announcement when the list becomes empty in order to tell the user
that there is no history.
2019-08-06 12:32:59 -07:00
Tiger Oakes
631b7ba7cb
Issue #1000 - Split out common browser functions
2019-08-06 12:31:25 -07:00
Emily Kager
23bc8f4320
Fro #4563 - Update delete button alpha when history mode changes
2019-08-06 12:26:25 -07:00
Tiger Oakes
3c1ce90f6f
Fixes #2379 - Generic library selection
2019-08-06 11:10:50 -07:00
Yeon Taek Jeong
6f962d3376
For #1744 : Open search shortcuts when entering search mode ( #4536 )
2019-08-05 15:07:03 -07:00
Emily Kager
6f7ae227a8
Closes #4540 - Set correct tint for select bookmark folder icon ( #4541 )
2019-08-05 14:54:39 -07:00
ekager
5edc9d0b4e
For #2021 - Update custom preferences' views with email/account changes
2019-08-05 09:53:27 -07:00
Travis Long
51218bc93e
Integrate service-experiments component ( #4098 )
2019-08-05 11:14:42 -05:00
Emily Kager
a526e0fad3
For #4455 - Rename history headers by hours and days ( #4478 )
2019-08-05 11:12:22 -05:00
Nikit Bhandari
8aecc2b850
For #4530 Reduce build warnings ( #4531 )
2019-08-05 11:10:57 -05:00
ekager
d0071d0177
For #4495 - Clean up homescreen toolbar focus and content descriptions
2019-08-05 08:58:03 -07:00
Sören Hentzschel
bfd4849064
For #1427 - enter multi select mode with single click on favicon in library
2019-08-03 16:43:51 -07:00
Nikit Bhandari
671727c3e8
For #4341 use camelCase for views referenced from code
2019-08-03 09:25:55 -07:00
Nikit Bhandari
1cb9f88787
For #4199 make checkbox disabled when there is no data ( #4200 )
...
* For #4199 make checkbox unclickable when there is no data
2019-08-02 17:42:39 -07:00
Tiger Oakes
1e4399ee38
Use auto pause with BrowserFragment observers
2019-08-02 17:32:58 -07:00
Tiger Oakes
cbd811dcfb
Closes #1657 - Use Gecko for downloads ( #4296 )
2019-08-02 17:28:30 -07:00
Tiger Oakes
6e2ea0750e
Issue #2379 - Use LibrarySiteItemView in history
2019-08-02 17:15:41 -07:00
mihai-adrian
bac2e40eb2
fixes #4435 - changed title of menuitem for delete and added content description
...
setting menu title should also set content description. I added the setContentDescription programmatically in order to ensure that the content description is being set. If content description matches title it won't be read twice
2019-08-02 17:09:24 -07:00
ekager
015922ddd2
No issue: Fix Crash lower API by setting gradient drawables in onBind
2019-08-02 16:18:34 -07:00
Yeon Taek Jeong
83ceec6289
For #201 : Search Widget
2019-08-02 11:26:48 -07:00
Jonathan Almeida
ec96d134ff
No issue: Fix breaking AccountObserver API
2019-08-02 13:40:50 -04:00
Sawyer Blatz
29f089c414
For #2203 : Polishes BrowserToolbarMenu
2019-08-02 13:40:50 -04:00
Colin Lee
33e881ca8a
For #1539 : Only allow delete when folders multi-selected ( #4062 )
2019-08-02 10:11:21 -07:00
ValentinTimisica
da59e36c1b
Fixes #4410 : Modified visibility of 'Add Tab' button.
...
I changed the visibility of 'Add Tab' button according to the number of
opened tabs. If there is at least one tab open, the button is displayed.
2019-08-02 08:49:50 -07:00
Grisha Kruglov
ae33234bbc
Closes #2593 : FxA automatic sign-in integration
2019-08-01 17:03:45 -07:00
Grisha Kruglov
210864186b
Reflect current sync status when opening account settings
2019-08-01 17:03:45 -07:00
Tiger Oakes
c342a680d8
Fix crash for bookmarks
2019-08-01 18:57:35 -04:00
Emily Kager
d42e72fd8b
Closes #4462 - Adjust layout params of select bookmark folder view
2019-08-01 13:31:13 -07:00
Thom Chiovoloni
a1adb2e57f
Update fenix for new megazord setup
2019-08-01 13:10:20 -07:00
Tiger Oakes
ccae66c08a
Issue #2379 - Use LibraryPageView in history
2019-08-01 15:59:55 -04:00
Jeff Boek
2813a3cff7
For #4441 - Keeps the ID 0 based for the recyclerview
2019-08-01 10:45:23 -07:00
Christian Sadilek
9887945296
For #4412 : Only consume state change when UI initialized
2019-08-01 11:51:32 -04:00
Christian Sadilek
b646e87d9e
No issue: Add engine warmup call
2019-08-01 10:53:55 -04:00
Jeff Boek
e4700f76c6
For #3886 - Uses defaultDeviceName for the DeviceConfig device name
2019-07-31 21:34:21 -07:00
Jeff Boek
a75c2f7cfb
No Issue - Fixes the offset key to prevent endless history bug
2019-07-31 17:58:56 -07:00
Sawyer Blatz
97f7d5ba87
For #2267 : Fixes telemetry for reader view ( #4328 )
2019-07-31 17:58:37 -07:00
Sawyer Blatz
2e7a61860a
For #969 : Adds more telemetry for collections ( #4358 )
2019-07-31 17:07:41 -07:00
Jonathan Almeida
4922e5d09d
No issue: Move PublicSuffixList to root component
...
With the PublicSuffixList class in Utilities, the first instantiation
of it (prefetching in onCreate), causes the Utilities to instantiate
and thus slowing down startup by needing the SearchEngineManager from
instantiating as well.
Moving this back to the root component fixes the immediate perf issue.
Co-authored-by: Will Hawkins <whh8b@obs.cr>
2019-07-31 17:01:14 -07:00
Christian Sadilek
59c0005979
For #4412 : SiteSecurityClickedListener set incorrectly
2019-07-31 19:52:53 -04:00
Will Hawkins
ed31d990a4
No Issue: Move notification manager to member of background services
...
Instead of taking notification manager as a parameter
(from the utils class), create one private to the
BackgroundServices class. This means that we do not need
to create the entirety of utilities just to use
the notification manager.
2019-07-31 16:11:46 -07:00
Jeff Boek
af449c84d5
For #4137 - Fixes HistoryInteractorTest
2019-07-31 14:35:33 -07:00
ekager
4494e40dbc
For #4137 - Adds pagination to the history view
2019-07-31 14:35:33 -07:00
Emily Kager
0773069dad
For #3829 - Ignore Intents Launched From History
2019-07-31 17:07:54 -04:00
Nikit Bhandari
46de06d132
For #4339 reduce build warnings ( #4340 )
2019-07-31 11:43:49 -07:00
Emily Kager
95208c84a9
Closes #4265 - Do not pop after all exceptions are removed ( #4392 )
2019-07-31 11:43:15 -07:00
Christian Sadilek
76ed07bd5d
Closes #4412 : BrowserInteractor has not been initialized ( #4414 )
2019-07-31 09:14:05 -07:00
Afzal Najam
8946bf20c4
Closes #3341 - Remove UserAgentRewriter
2019-07-31 11:05:42 -04:00
Emily Kager
ec0bd85f6d
For #4198 - Include Intent.ACTION_SEND to open to browser
2019-07-31 01:11:39 -04:00
