Michael Comella
e85dd6a09c
[fenix] No issue: correct position of StartupTimeline; add warning.
2020-07-20 14:27:41 -07:00
Sawyer Blatz
80b4fb0808
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10466 : Add search privately to top of list ( https://github.com/mozilla-mobile/fenix/pull/12744 )
2020-07-20 13:25:36 -07:00
Tiger Oakes
5b7d951590
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/10924 - Cleanup SavedLoginsAuthFragment ( https://github.com/mozilla-mobile/fenix/pull/10930 )
2020-07-20 13:25:24 -07:00
Kainalu Hagiwara
055620f117
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12730 - Fix ripple for font size setting.
2020-07-20 13:00:59 -07:00
Sawyer Blatz
d8ecc2e19c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11851 : Close tab tray when last tab closed ( https://github.com/mozilla-mobile/fenix/pull/12615 )
2020-07-20 11:05:32 -07:00
ekager
b8b3d8b367
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10784 - Fixes memory leak in BrowserAnimator
2020-07-20 13:50:18 -04:00
Sawyer Blatz
54a6de9b84
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12735 : Fixes issue with tab deletion undo ( https://github.com/mozilla-mobile/fenix/pull/12737 )
2020-07-20 10:48:16 -07:00
Hakkı Kaan Çalışkan
197a076ef2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12554 : Helper class for password reveal on logins
2020-07-20 13:45:46 -04:00
mozilla-l10n-automation-bot
24f19cd763
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/12687 )
2020-07-19 21:30:11 -07:00
Christian Sadilek
250c95eb28
[fenix] Update Android Components to 51.0.20200717190031
2020-07-17 19:32:02 -04:00
Tiger Oakes
e740819acd
[fenix] Fix lint issues ( https://github.com/mozilla-mobile/fenix/pull/12683 )
2020-07-17 16:20:08 -07:00
Tiger Oakes
cb59729010
[fenix] Change enabled lint rules ( https://github.com/mozilla-mobile/fenix/pull/12517 )
2020-07-17 15:17:16 -07:00
Tiger Oakes
25a5f478ef
[fenix] Test migration classes ( https://github.com/mozilla-mobile/fenix/pull/12677 )
2020-07-17 14:35:13 -07:00
Tiger Oakes
a7bbc86f4a
[fenix] Add tests for login exceptions ( https://github.com/mozilla-mobile/fenix/pull/12681 )
2020-07-17 14:25:45 -07:00
Tiger Oakes
5c9876dcff
[fenix] Fix failure in handleWhatsNewGetAnswersClicked ( https://github.com/mozilla-mobile/fenix/pull/12682 )
2020-07-17 14:25:35 -07:00
Mihai Adrian Carare
3823c632ac
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7966 : Update toolbar content description. ( https://github.com/mozilla-mobile/fenix/pull/12667 )
2020-07-17 16:22:13 -05:00
Elise Richards
508854ea07
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12532 : Align Settings -> Site permissions -> Sub-pages to 72dp keyline ( https://github.com/mozilla-mobile/fenix/pull/12680 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-17 15:54:57 -05:00
Mihai-Eduard Badea
65c98d6c16
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9949 - Bookmarks/History deletion inconsistencies ( https://github.com/mozilla-mobile/fenix/pull/12630 )
...
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.
- Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in https://github.com/mozilla-mobile/fenix/issues/8648 .
Co-authored-by: Mihai Eduard Badea <mihai.badea@softvision.ro>
2020-07-17 15:13:18 -05:00
Tiger Oakes
549acfa6f1
[fenix] Test session control controller ( https://github.com/mozilla-mobile/fenix/pull/12652 )
2020-07-17 13:07:01 -07:00
Hakkı Kaan Çalışkan
415bbf6574
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12509 : Set height of remove add on button to 36dp
2020-07-17 12:55:36 -07:00
ekager
f7f80ad6cb
[fenix] Update ContextMenuUseCases to just take a store
2020-07-17 14:49:10 -04:00
ekager
2deadc2e22
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12453 - Sets secure flags on private tab of tabs tray
2020-07-17 13:24:25 -04:00
ekager
bc08df1c8f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12364 - Only show PWA prompt the third time a user visits installable site
2020-07-17 12:37:03 -04:00
Tiger Oakes
ded7cde177
[fenix] Add tests for adapters in collections ( https://github.com/mozilla-mobile/fenix/pull/12649 )
2020-07-17 09:04:16 -07:00
Kainalu Hagiwara
46a9bba6e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12531 : Align Settings -> Private browsing to 72dp keyline ( https://github.com/mozilla-mobile/fenix/pull/12654 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-16 22:26:49 -07:00
Elise Richards
5b46f572df
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10173 : login duplicates and save ( https://github.com/mozilla-mobile/fenix/pull/11208 )
...
* Extract controller into it's own class. Implement find dupes and filter based on username.
Create edit login controller. Add text watchers and check for duplicates.
Edit controller test
* Find duplicates and save to store
* Retrieve duplicates from AC and check list on username text changed
Move duplicates logic into the controller
* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.
* Use correct threads in controller. Enable save button when applicable.
Save enabled in datastore.
Move login data to datastore
Rebase with password error states
Update metrics to be more specific for edit
* Create logins controller for AC calls
* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.
Inflate view in edit fragment. Double layout showing up.
Edit view
Controller tests
Controller tests passing
Interactor tests
Lint and detekt cleanup
* Remove datastore and use storage controller for all logins calls to password storage.
Addressed comments
Lint
:
Rebase - 1
2020-07-16 17:08:04 -05:00
Tiger Oakes
046682f889
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12457 : Add MockK matcher for intents ( https://github.com/mozilla-mobile/fenix/pull/12612 )
2020-07-16 15:05:01 -07:00
Mugurell
ac85ba0945
[fenix] Ensure logins deletion ( https://github.com/mozilla-mobile/fenix/pull/12507 )
...
* For https://github.com/mozilla-mobile/fenix/issues/11227 - Cleanup saved logins list when one is selected
Selecting a saved login will open a detail screen for it from where users can
change details or even delete that particular login.
After the change is made the user is brought back to the list of saved logins
where for a brief moment (< 1s) until we get a new response from
passwordsStorage.list() the user can see and even interact with the old list
of items, which may still contain the just deleted one.
To avoid users seeing obsolete logins or even interacting with them (selecting
a previosuly deleted item will result in a crash) we will clean the list of
logins just before the selected login is opened in the detailed view.
When returning for a brief moment the users may see the "loading" UX until
passwordsStorage.list() returns the up-to-date list of logins to display.
* For https://github.com/mozilla-mobile/fenix/issues/11227 - Refactor SavedLoginsView to be closer to MVI
- Interactors should only get passed other Interactors or Controllers as
dependencies to which they should delegate user actions.
- Controllers should hold most of the business logic and get passed all final
dependencies they need to do their job.
2020-07-16 14:40:08 -05:00
Tiger Oakes
2a7e8f7adb
[fenix] Add tests for sync, wifi, and push ( https://github.com/mozilla-mobile/fenix/pull/12581 )
2020-07-16 12:25:38 -07:00
Tiger Oakes
fe5b219a89
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12565 : Add Locale settings tests & use activity ( https://github.com/mozilla-mobile/fenix/pull/12579 )
2020-07-16 11:43:27 -07:00
jhugman
773884bdc4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12600 - remove AddonInstalled event when the permission dialog is shown ( https://github.com/mozilla-mobile/fenix/pull/12601 ) r=csadilek,sblatz
2020-07-16 19:40:39 +01:00
Mihai Branescu
582fc2cff7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12201 - forced callbacks to be on the main thread ( https://github.com/mozilla-mobile/fenix/pull/12543 )
2020-07-16 13:39:31 -05:00
Elise Richards
fc847d79e7
[fenix] No issue: Delete unnecessary to-dos ( https://github.com/mozilla-mobile/fenix/pull/12603 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-16 13:38:07 -05:00
Hakkı Kaan Çalışkan
ad239ff1ae
[fenix] No issue: Move dp's to dimens.xml
2020-07-16 13:08:55 -04:00
Kainalu Hagiwara
ce7ba9a2ac
[fenix] Update TabTrayViewHolder with A-C thumbnail changes.
2020-07-16 12:50:33 -04:00
Roger Yang
be3ce6e2ba
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12118 : Add isSubframeRequest parameter for app links
2020-07-16 12:50:33 -04:00
Christian Sadilek
4c49410910
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12248 : Webcompat reporter not active in Nightly
2020-07-16 12:24:21 -04:00
jhugman
6a7a29fc61
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11704 Add leanplum attributes for tracking protection ( https://github.com/mozilla-mobile/fenix/pull/11965 ) r=sblatz
...
* For 11657: add LP attribute for tracking protection
* For https://github.com/mozilla-mobile/fenix/issues/11704 : added tracking_protection_enabled attribute
* Added docs for the new attributes, linking to data-review to the mma.md
* Rename null to none when no ETP is enabled
2020-07-16 17:09:32 +01:00
Hakkı Kaan Çalışkan
ab317dc779
[fenix] No issue: Uncomment forgotten assert
2020-07-16 11:45:53 -04:00
Tiger Oakes
82d1b4380d
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/12493 : Remove kapt plugin
2020-07-16 10:38:03 -04:00
Hakkı Kaan Çalışkan
8645075a39
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12105 : Follow ux mock on Settings --> Accessibility screen
2020-07-16 10:37:20 -04:00
James Hugman
61fe76774f
[fenix] Address review comments
2020-07-16 10:37:03 -04:00
James Hugman
800e55e69a
[fenix] Remove need to specify component names for new intents
2020-07-16 10:37:03 -04:00
James Hugman
648b389a68
[fenix] Changed home_* style links to urls_* to reflect that the destination is a set of links, rather than where the screen is
2020-07-16 10:37:03 -04:00
James Hugman
8e7c9bf003
[fenix] Add install_search_widget
2020-07-16 10:37:03 -04:00
James Hugman
83ed39ed5c
[fenix] Add UI tests for deep links
2020-07-16 10:37:03 -04:00
James Hugman
dc588ca0ae
[fenix] Add unit tests for deep links
2020-07-16 10:37:03 -04:00
James Hugman
bc397268a6
[fenix] Add deep links for settings and home screens
2020-07-16 10:37:03 -04:00
isabelrios
18b3fb95b4
[fenix] cron-job-ui-screenshots ( https://github.com/mozilla-mobile/fenix/pull/12423 )
...
Co-authored-by: isabel rios <isabelrios@MacBook-Pro-de-isabel-2.local>
2020-07-16 16:08:00 +02:00
Mugurell
85e05cb841
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12544 - Prevent search engines mixup
...
Stricter synchronization by always using the same "loadedSearchEngines"
variable.
With "loadedSearchEngines" calling "refreshAsync()" we also get the fallback
engines to contain reddit and youtube (which are programatically added) and
also now we properly remember and display the engines added by user.
2020-07-16 16:49:54 +03:00
Oana Horvath
70e30dcf98
[fenix] Replaces verifyPageContent in UI tests
2020-07-16 10:55:58 +03:00
Tiger Oakes
65402a62dd
[fenix] Add tests for StartupReportFullyDrawn ( https://github.com/mozilla-mobile/fenix/pull/12560 )
2020-07-15 23:31:59 -07:00
Tiger Oakes
c1a74cc939
[fenix] Add helper for underlining text ( https://github.com/mozilla-mobile/fenix/pull/12520 )
2020-07-15 22:38:46 -07:00
Tiger Oakes
2e8da8abe0
[fenix] Fix nav graph and theme tests ( https://github.com/mozilla-mobile/fenix/pull/12567 )
2020-07-15 18:04:36 -07:00
Tiger Oakes
034a9dae8f
[fenix] Update Kotlin dependency ( https://github.com/mozilla-mobile/fenix/pull/10806 )
2020-07-15 18:02:58 -07:00
mcarare
1efe17c801
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12503 : Add unit tests for permissions details view.
2020-07-15 10:04:40 -04:00
mcarare
bfd879be4a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12503 : Open addon permissions link in app.
2020-07-15 10:04:40 -04:00
Aaron Train
d60d77248b
[fenix] No issue: Add a couple Tabs Tray UI tests
2020-07-15 10:49:34 +03:00
ekager
772f69c5f5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7094 - Adds save login exceptions
2020-07-14 14:47:37 -04:00
Tiger Oakes
09c37671a8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12457 - Add MockK matcher for nav directions ( https://github.com/mozilla-mobile/fenix/pull/12262 )
2020-07-14 10:39:23 -07:00
Tiger Oakes
431459d181
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12171 : Use one-line logo in Nightly ( https://github.com/mozilla-mobile/fenix/pull/12555 )
2020-07-14 10:37:01 -07:00
Tiger Oakes
d9e7a351fa
[fenix] Add tests for search ( https://github.com/mozilla-mobile/fenix/pull/12437 )
2020-07-14 10:32:04 -07:00
Tiger Oakes
afd8eafd9f
[fenix] Test viewholders in home.sessioncontrol ( https://github.com/mozilla-mobile/fenix/pull/12524 )
2020-07-14 10:31:50 -07:00
Hakkı Kaan Çalışkan
e83a7f3370
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12107 : Follow ux mock on Settings --> Account screen
2020-07-14 12:25:21 +03:00
Mozilla L10n Automation Bot
2d97e98f58
[fenix] Import l10n.
2020-07-14 11:40:19 +03:00
ekager
9c0e356950
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11099 For https://github.com/mozilla-mobile/fenix/issues/12189 For https://github.com/mozilla-mobile/fenix/issues/7532 - Clean up bottom navigation bar colors
2020-07-13 13:46:35 -04:00
Sawyer Blatz
ca02217039
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10466 : Put call & email at top of context list
2020-07-13 10:33:55 -07:00
Hakkı Kaan Çalışkan
c332cc631e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12106 : Follow ux mock on Settings --> Logins screen
2020-07-13 11:14:32 -04:00
Oana Horvath
0885d0047e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10911 : disables flaky createBookmarkFolderTest
2020-07-13 15:40:50 +03:00
Mugurell
66fdc14386
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11875 - Prevent mixup of region / locale based search engines
...
We have two search engine types:
- one based on MLS reported region,
- one based only on Locale.
There are multiple steps involved in returning the default search engine for
example and though at each step we could verify if a certain operation is
completed we are still exposed to concurrency issues.
Simplest and most effective way to make sure the MLS engines do not mix with
Locale based engines is to use the same type of engines for the entire duration
of the app. At the next cold start we'll verify again which engines to use.
Using the Locale based engines (fallbacks) is expected to only happen once, at
the first run of the application after being installed.
2020-07-13 13:41:34 +03:00
Mozilla L10n Automation Bot
73fbb27808
[fenix] Import l10n.
2020-07-13 07:59:10 +03:00
jhugman
de6a9cf93b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11655 : add leanplum event for installing an addon ( https://github.com/mozilla-mobile/fenix/pull/12136 ) r=elise
...
* For https://github.com/mozilla-mobile/fenix/issues/11655 : add leanplum event for installing an addon
* Add link to data-review request in PR
* Addressed CI comments
2020-07-12 23:47:34 +01:00
Grisha Kruglov
1278ca374c
[fenix] Synced Tabs: make sure to stop 'loading' when we encounter an error
2020-07-10 19:02:55 -07:00
Tiger Oakes
291c3196ee
[fenix] Fix Robolectric tests SDK version ( https://github.com/mozilla-mobile/fenix/pull/12464 )
2020-07-10 17:21:10 -07:00
ekager
fade6c7936
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11324 - Adds trash icon to swipe to delete
2020-07-10 20:16:57 -04:00
Michael Comella
03b8068cd2
[fenix] No issue - post: mock profiler object in DefaultTabTrayControllerTest.
...
Without this line, the tests fail when running the full suite (but not
this test in isolation, for some reason).
2020-07-10 16:43:06 -07:00
Nazım Can Altınova
5a1c31e13f
[fenix] Add profiler markers for HomeActivity.load and DefaultTabTrayController.onNewTabTapped
2020-07-10 16:43:06 -07:00
Sawyer Blatz
bdcd04cc6a
[fenix] Update app/src/main/java/org/mozilla/fenix/HomeActivity.kt
...
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
2020-07-10 18:44:14 -04:00
Sawyer Blatz
33ea9d02aa
[fenix] No issue: Update AC version
2020-07-10 18:44:14 -04:00
Michael Comella
2a3a343393
[fenix] For perf-frontend-issues https://github.com/mozilla-mobile/fenix/issues/44 : add local property to autosign release builds.
2020-07-10 10:55:32 -07:00
Mihai Eduard Badea
a9c19cbcf5
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/12339 - Collection delete dialog string update
...
Set the collection delete dialog title text to "Delete %1$s?"
2020-07-10 11:38:39 -04:00
Mozilla L10n Automation Bot
03185f680a
[fenix] Import l10n.
2020-07-09 21:39:49 -04:00
Grisha Kruglov
d76815b9ca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12433 - Allow synced tabs pull-to-refresh for non-critical account errors
2020-07-09 16:18:54 -07:00
ekager
ddf56f9bc6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11303 - Change copy login origin to open in browser
2020-07-09 18:09:41 -04:00
Tiger Oakes
e69b1e06f1
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/9832 - Change targetSdkVersion to Android 10 ( https://github.com/mozilla-mobile/fenix/pull/11014 )
2020-07-09 10:50:51 -07:00
Emily Kager
2eaef29243
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12010 : Follow ux mock on Settings --> ETP --> Info screen ( https://github.com/mozilla-mobile/fenix/pull/12429 )
...
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-09 09:47:09 -07:00
Sebastian Kaspari
f3cfdc5058
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/12311 : BrowserToolbarController: Stop SessionFeature and release session from EngineView.
2020-07-09 12:36:56 -04:00
TejaswiKarasani
47e60525ff
[fenix] No Issue: Verify the page main menu items UI Test ( https://github.com/mozilla-mobile/fenix/pull/12336 )
2020-07-09 09:15:10 -07:00
Mozilla L10n Automation Bot
869c91048a
[fenix] Import l10n.
2020-07-09 11:29:38 -04:00
David Walsh
940bc85996
[fenix] For 11889 - Fix snackbar for collection creation in browser fragment
2020-07-09 08:50:12 +03:00
mozilla-l10n-automation-bot
1f3c3966fb
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/12404 )
2020-07-08 18:56:37 -07:00
Hakkı Kaan Çalışkan
cfb8cac9a3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11563 : Set ic_close.xml to use full width and height
2020-07-08 17:21:25 -04:00
ekager
16132f2c5d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11431 - Scroll to restored tab in tab tray
2020-07-08 17:18:16 -04:00
Christian Sadilek
bcb49d3985
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12353 : URL copied to clipboard should not be extension/reader URL
2020-07-08 16:55:32 -04:00
Tiger Oakes
5406f2cafb
[fenix] Add tests for exceptions
2020-07-08 15:52:37 -04:00
MickeyMoz
d0e3833d3b
[fenix] Update Android Components version to 50.0.20200708130551.
2020-07-08 12:44:51 -04:00
isabelrios
d1582d892a
[fenix] No issue: Update screenshots test ( https://github.com/mozilla-mobile/fenix/pull/12348 )
2020-07-08 12:20:34 -04:00
Tiger Oakes
d8847824a9
[fenix] Add tests for onboarding viewholders ( https://github.com/mozilla-mobile/fenix/pull/11522 )
2020-07-08 07:53:22 -07:00
Richard Pappalardo
0e434d53ee
[fenix] fix: disable intermittent test failure
2020-07-08 12:21:25 +03:00
Tiger Oakes
9d875c7cca
[fenix] Add tests for browser helper classes ( https://github.com/mozilla-mobile/fenix/pull/12370 )
2020-07-07 19:46:25 -07:00