Severin Rudie
d1d20b544e
For 4780: update HomeActivity to maintain private mode in memory
...
As an added bonus, this makes the temporal coupling between `setPrivateModeIfNecessary` and `setupThemeAndBrowsingMode` explicit. They previously would have broken if called in reverse order, now it will fail to compile.
2019-10-08 15:13:17 -07:00
Severin Rudie
10f334303d
For #4780 : remove previous fix for leaking private mode status
...
This didn't function when 'open links in a private tab' was set. Rather than adding another sketchy fix for the edge case, following commits will change `usePrivateMode` to be maintained in memory, instead of in Settings.
2019-10-08 15:13:17 -07:00
Sawyer Blatz
4045fb0107
For #4190 : Removes waterfall animation from awesomebar
2019-10-08 09:14:23 -07:00
Sawyer Blatz
6484a48147
For #5787 : Fixes shortcuts asking to launch private alias ( #5825 )
2019-10-08 08:40:28 -07:00
mcarare
1c6aefd82b
For #3604 Snackbar messages for closing tabs use closed instead of deleted
2019-10-08 17:06:02 +03:00
Mihai Adrian
18a130b38e
For #5798 : Fix info icon pixelation ( #5841 )
2019-10-08 09:30:32 -04:00
isabelrios
0e3148f0da
fixing more reviewers comments
2019-10-08 09:56:29 +02:00
Isabel Rios
44f4cedefd
Add fxa/sync integration tests
...
fixing Jenkins path to tests and clean tests
commenting future tests and adding doc with info about the tests
2019-10-08 09:56:29 +02:00
Vipul Asri
31ae5709c2
Closes #5573 : fix radio-button spacing in settings
2019-10-07 13:07:53 -07:00
Tiger Oakes
d5c3433041
Use the new fragment constructor
2019-10-07 11:07:48 -07:00
Denys M
a4439ff373
For #3563 . Use ListAdapter
for App Share list.
2019-10-07 10:41:48 -07:00
Denys M
e55eda30fb
For #3563 . Use ListAdapter
for Bookmark folder selection list.
2019-10-07 10:40:55 -07:00
Madalin Valceleanu
f4be12227f
Fix the incognito icon looks out of place/misaligned
2019-10-07 10:15:11 -07:00
ekager
f6285ad5f8
For #3846 - Pass in updated session icon to tabs
2019-10-07 09:38:43 -07:00
Tiger Oakes
d028c97112
For #5213 - Use support library attributes
2019-10-06 16:17:00 -07:00
Prat T
80a1e6dd2c
Fixes #5351 - listen to onIconChanged in HomeFragment
2019-10-06 10:41:34 -07:00
Prat T
fe648a0b99
Fixes #5351 - use session icon in tab view on home
2019-10-06 10:41:34 -07:00
Emily Kager
2b19b28d25
For #5651 - Set up Standard vs Strict Tracking Protection Experiment
2019-10-05 10:14:09 -07:00
Sawyer Blatz
19a2d9df4f
For #1620 : Hide search results when they match URL
2019-10-04 14:05:55 -07:00
mcarare
22eb207cef
For #5784 : Fix hiding default browser preference in sdk<=23
2019-10-04 12:41:12 -07:00
Colin Lee
b7647a454f
For #5599 : Remove dependency on fetch_httpurlconnection ( #5716 )
...
* For #5599 : Remove dependency on fetch_httpurlconnection
* For #5599 : Switch Glean to GeckoViewFetchClient
* Use existing Gecko client for Glean
2019-10-04 12:28:23 -05:00
Emily Kager
40e6284aef
For #5442 - Show Delete Browsing Data on Quit option in home menu
2019-10-04 09:26:59 -07:00
Sawyer Blatz
841b06b02f
No issue: fixes master ( #5777 )
2019-10-03 14:42:56 -07:00
Sawyer Blatz
371e2ac3d8
For #514 & #5742 : Updates "launch links in private tab" functionality ( #5721 )
...
* For #514 & #5742 : Updates "launch links in private tab" functionality
* Fixes comments
2019-10-03 12:43:33 -07:00
Madalin Valceleanu
4a0917ba32
Fix too much space under the address bar
2019-10-03 11:30:03 -07:00
Christian Sadilek
b733e4fa8f
Upgrade to Mozilla Android Components 16.0.0-SNAPSHOT
2019-10-03 11:07:26 -07:00
Severin Rudie
3be06953d6
For #4780 switch off private mode ( #5614 )
...
* Do not launch in Private Mode
When the app launches do not launch in Private Mode in order to prevent usage leaks to other users of the device.
* Issue #4780 : add comments to use private mode
* For #4780 : write tests for clear private mode on create app
* For #4780 : clear private mode when privacy notification is removed
2019-10-03 10:23:13 -07:00
Sawyer Blatz
e8216e3079
For #5094 : Adds telemetry for suggestion toggles ( #5704 )
2019-10-03 10:03:14 -07:00
Sawyer Blatz
097d7c2038
For #5742 : Adds strings ( #5743 )
2019-10-03 09:32:50 -07:00
Sawyer Blatz
785b8b9519
For #5567 : Removes search shortcuts button ( #5739 )
...
* For #5567 : Removes search shortcut button
* No issue: Simplifies logic for displaying shortcuts
2019-10-03 08:53:16 -07:00
Sawyer Blatz
2896b36d14
No issue: Updates naming of launch links privately var ( #5701 )
...
The previous name was pretty confusing
2019-10-02 12:11:21 -07:00
Sawyer Blatz
eb3c9f86e2
No issue: Removes feature flags for delete data ( #5738 )
2019-10-02 10:43:37 -07:00
Sawyer Blatz
2f0d8d8243
For #5712 : Updates text color for fill link from clipboard
2019-10-01 16:29:39 -07:00
Emily Kager
f7c9ab11eb
For #3487 - Add back open image in new tab
2019-10-01 12:45:09 -07:00
Michael Droettboom
a250241523
1585250: Initialize metrics off of the main thread
2019-10-01 10:29:54 -07:00
Sawyer Blatz
669e694af9
For #5672 : Fixes broken send tab link
2019-09-30 16:13:40 -07:00
Axel Hecht
214ca421f7
Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@10559d774c
2019-09-30 16:10:08 -07:00
Sawyer Blatz
69c42b6192
For #5681 : Sets OPEN_TO_BROWSER false when using new tab shortcut
2019-09-30 14:56:16 -07:00
Emily Kager
e9a0f1f65d
For #2078 - Filter Out Self in Share Sheet ( #5641 )
2019-09-30 12:43:47 -07:00
Sawyer Blatz
c8af16bd47
For #5679 : Hides autoplay behind feature flag ( #5685 )
2019-09-30 12:01:04 -07:00
ekager
ef29fe2584
Update BackgroundServicesTest, Suppress Complex Method
2019-09-30 10:33:56 -07:00
Grisha Kruglov
a4097cd380
FxA WebChannels integration
...
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971 )
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-30 10:33:56 -07:00
Chenxia Liu
8f97d247a6
For #235 - Add Glean crash count + docs.
2019-09-30 08:32:33 -07:00
Sawyer Blatz
3e42114190
For #5656 : Fixes nightly major version number crash
2019-09-27 15:06:57 -07:00
Sawyer Blatz
a38b73f19e
Fixes #5653 : Removes crash with null campaign
2019-09-27 15:01:00 -07:00
mcarare
64923978e6
For #1071 Added Desktop Mode icon
2019-09-27 09:47:10 -07:00
Sawyer Blatz
5e18ead45e
For #4474 : Adds tests and fixes issues
2019-09-27 08:59:05 -07:00
Tiger Oakes
ee1f040e53
No issue: Move signedIn tracking to BookmarksSharedViewModel ( #4755 )
2019-09-27 08:57:38 -07:00
Sawyer Blatz
7f328a6dc4
For #1298 : Adds adjustCampaignId to core ping ( #5579 )
2019-09-27 08:56:33 -07:00
Sawyer Blatz
6babf72352
For #5197 : Adds telemetry for media notification ( #5520 )
2019-09-27 08:02:29 -07:00
Tiger Oakes
88aa519210
Closes #4711 - Extract VoiceSearchActivity ( #5502 )
2019-09-27 07:54:29 -07:00
Emily Kager
3f41a4e9c6
No issue: Update navigation library
2019-09-26 17:01:13 -07:00
Sawyer Blatz
11baabb63a
No issue: Updates fact mapping to use enums
2019-09-26 17:00:51 -07:00
Emily Kager
c3287b17ac
Closes #5624 - Fix crash on preference change listener
2019-09-26 16:56:54 -07:00
Mihai Adrian
62ae025d65
For #4991:Ensured deleteSelectedBookmarks deletes all selected bookmarks ( #5559 )
...
Moved the deletion to a CoroutineScope(IO) to decouple from fragment lifecycle
Used local val tempStorage to keep reference to bookmarkStorage of outside class
Ran deletions with awaitAll to avoid concurrency issues on storage
2019-09-26 16:52:59 -07:00
Severin Rudie
dffa61bf16
Closes #4513 : fixes bookmark tests broken by loading change
...
Note that BookmarkFragmentStoreTest changes preserve existing behavior, which in many cases is more expansive than the test name implies
2019-09-26 16:29:14 -07:00
Severin Rudie
fd7f1b2665
Closes #4513 : adds tests for bookmark loading state
2019-09-26 16:29:14 -07:00
Severin Rudie
fbdd537bc7
Closes #4513 : show progress bar when loading bookmarks
2019-09-26 16:29:14 -07:00
Severin Rudie
ca6c324f29
Issue #4513 : added isLoading to bookmark state
...
This was added to the state object as a top level param because it could reasonably coexist with any value of `tree` or `mode`. Even if we don't now, we may someday want to display a loading indicator while also showing cached bookmarks.
For now, we set isLoading to false whenever we receive any bookmarks
2019-09-26 16:29:14 -07:00
Severin Rudie
5e8798e89c
Issue #4513 : add ProgressBar to bookmark component layout
2019-09-26 16:29:14 -07:00
Severin Rudie
96472a533a
Issue #4513 : fix mismatched bookmark listener lifecycles
...
The mismatch here was creating potentially inconsistent states. When first put into a CREATED or STARTED state, the listener would not be active, however after going through onResume it would then stay active until destroyed.
We should only be navigating to bookmarks when in a RESUMED state, so this change should be safe. I tried it a few times to verify. But I've been wrong before!
2019-09-26 16:29:14 -07:00
Colin Lee
de93b05cac
For #2754 Add tab cards to share sheet ( #5493 )
...
* For #2754 Add tab cards to share sheet
* For #2754 : Fix background near rounded corners and ShareButtonAppearanceTest
* Add license to share_tab_item
2019-09-26 14:25:34 -07:00
Christian Sadilek
ac2611d744
Upgrade to A-C 15.0.0-SNAPSHOT (incl. required changes) ( #5578 )
...
* Upgrade to Mozilla Android components 15.0.0-SNAPSHOT
* Update findinpage integration to use browser-state
* Use new UseCases APIs after download migration.
2019-09-26 12:50:50 -07:00
Mugurell
c5330c6880
For 5092 - Show a Snackbar with retry option if sharing to devices fails ( #5158 )
...
* For #5092 - Show a Snackbar with retry option if sharing to devices fails
ShareController will contain all the business logic for checking the result
status of the `share to device` operations. When this fails it will show a
snackbar which also offer the possibility to retry the just failed operation.
To allow this even in the event the user has closed the share fragment we'll
use a GlobalScope's coroutine.
Refactored out the TabsSharedCallback from ShareFragment because otherwise we
would have neede to sent through that the just failed operation. After the
refactor the ShareController is solely responsable for showing the right
snackbar and handling the retry actions.
* For #5092 - Refactor ShareControllerTest
* For #5092 : Adds color theming of snackbars
2019-09-26 12:30:28 -07:00
Yeon Taek Jeong
59e2c124cb
No issue: Update long-press shortcut strings ( #5284 )
...
* No issue: Update long-press shortcut strings
* Updates identifiers
2019-09-26 11:57:37 -07:00
ekager
0b01635ce0
For #2874 , #5375 , #5131 - submitList workaround for Android 5 + 6
2019-09-25 19:59:07 -07:00
ekager
44bb592b43
For #5312 - Send ETP Strict/Standard event
2019-09-25 15:23:30 -07:00
ekager
24b3ed4384
For #5568 - Don't pass in Session for QuickActionSheetController
2019-09-25 13:33:38 -07:00
Emily Kager
b0b60aa27d
For #5281 - Use TrackerLog for reporting ETP categories ( #5556 )
2019-09-25 10:48:06 -07:00
Sawyer Blatz
b6e6e36ccd
For #561 : Fix stutter of search icon & text when animating
2019-09-25 10:06:38 -07:00
Sawyer Blatz
75a25c9bd0
For #561 : Fix linting issue
2019-09-25 10:06:38 -07:00
Jeff Boek
c592a69aad
For #561 - Fixes snackbar placement on homeview
2019-09-25 10:06:38 -07:00
Jeff Boek
32c506121e
For #561 - Fixes visual inconsistencies with the search bar
2019-09-25 10:06:38 -07:00
Jeff Boek
5c092c1ef1
For #561 - Adds shadow/highlightto the bottom bar
2019-09-25 10:06:38 -07:00
Jeff Boek
00d1be97ac
For #561 - Wires up add tab button inside the bottom bar
2019-09-25 10:06:38 -07:00
Jeff Boek
b16754d78a
For #561 - Adds add tab and menu button to bottom bar
...
- Adds space between wordmark and session control component
2019-09-25 10:06:38 -07:00
Jeff Boek
abbb310ce3
For #561 - Removes the toolbar from the home screen
...
- Removes the menu button
- Fixes motionlayout animation with the wordmark/private browsing button
2019-09-25 10:06:38 -07:00
Axel Hecht
2829235651
Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@97355ffcdc
2019-09-25 09:02:42 -07:00
mcarare
bfe8bf4663
For #1383 Added tab title to close button content description
2019-09-25 10:34:02 +03:00
Jeff Boek
1c9c5317eb
For #5552 - Temporary fix for startup crash on es locales
2019-09-24 19:21:47 -07:00
Sawyer Blatz
856399e9e2
No issue: Fixes GleanMetricsService nits & broken UI test ( #5539 )
...
* No issue: Fixes GleanMetricsService nits
* No issue: fixes broken UI test
2019-09-24 16:12:09 -07:00
Alessio Placitelli
1ffdf1cf9b
Add basic test coverage for Glean metrics in Fenix
...
This introduces test coverage, using the Glean SDK
testing API, for the metrics that are set at startup
by Fenix in the GleanMetricsService.
This additional adds a basic test for the translation
of the `app_opened` event.
2019-09-24 12:33:14 -07:00
Emily Kager
25e2a7abfc
For #2765 - Run places maintenance daily ( #5466 )
2019-09-24 10:50:11 -07:00
Mihai Adrian
c7c752cabb
For #5356 Improves private browsing "common myths" link accessibility ( #5479 )
...
Added separate TextView for link text
Used UnderlineSpan to show text as link
Split string private_browsing_placeholder, one for each TextView
Set clickListener on TextView so it can be accessed via Talkback
2019-09-24 10:46:34 -07:00
Tiger Oakes
8c30200ced
Only use Context.settings() function (not getter) ( #5335 )
...
Remove unused String extensions
2019-09-24 10:33:46 -07:00
Tiger Oakes
734d4031e2
Extract UriOpened observer from HomeActivity
2019-09-24 09:37:24 -07:00
Tiger Oakes
e3c60faf24
Move BookmarkNode extensions to helper class ( #4752 )
2019-09-24 09:17:29 -07:00
Mihai Adrian
236f702bbe
For#5468 Changed info source for url clipboard copy from view to session ( #5514 )
2019-09-24 07:56:59 -07:00
Axel Hecht
7c55aff1be
Import strings from android-l10n ( #5482 )
...
State: mozilla-l10n/android-l10n@d10506f569
2019-09-23 19:53:57 -07:00
Tiger Oakes
cb7701584f
No issue: Extract home fragment mode ( #5343 )
2019-09-23 09:33:55 -07:00
Nicholas
72eed21bfc
For https://github.com/mozilla-mobile/fenix/issues/5474 - Adapt Autoplay icon to theme
2019-09-23 08:56:09 -07:00
Emily Kager
9d9ff959b5
For #5312 - Add Telemetry for Tracking Protection
2019-09-23 08:29:45 -07:00
Christian Sadilek
c866ae1a1e
Closes #5444 : IntentReceiverActivity: Add tests for intent processing
2019-09-20 19:44:05 -04:00
Sawyer Blatz
f02603be37
For #5460 : Fixes styling of fill link from clipboard ( #5464 )
2019-09-20 15:29:16 -07:00
Sawyer Blatz
4a6e647167
For #5197 : Adds telemetry for media controls ( #5266 )
2019-09-20 14:49:27 -07:00
mcarare
77ce658033
For #5383 Refactored ETP layout to keep appearance for larger font size.
...
Added paddingTop to layout to maintain similar space above title.
Added image's bottom colour as background color to fill space below image.
Refactored TextViews alignment to chain.
Changed guideline to percent instead of dp for wider screens including tablets.
2019-09-20 14:01:30 -07:00
Tiger Oakes
6c30a94081
Move settings classes to packages
2019-09-20 12:36:15 -07:00
Tiger Oakes
699eacab39
For #778 - Rename CustomTabActivity
2019-09-20 12:35:12 -07:00
Tiger Oakes
e9fd6892ba
For #394 , #778 - Add hide toolbar feature
...
And also add CustomTabsServiceStore
2019-09-20 12:34:49 -07:00
ekager
78ac6fc912
For #5448 - Reload custom tab session when TP is toggled
2019-09-20 12:30:02 -07:00
Michael Droettboom
a63eaa9d67
1581556: Initialize Glean on the main thread
2019-09-20 12:29:40 -07:00
mihai-adrian
47064a68e0
For #5141 Changed "learn more" link to be accessible to Talkback users
2019-09-20 12:29:02 -07:00
Tiger Oakes
172a9cf06c
Extract and test crash reporter code
2019-09-20 11:04:11 -07:00
ekager
464122fda1
For #5421 - Make share dialog scrim dismiss fragment
2019-09-20 09:52:39 -07:00
mcarare
95a7aa9223
For #4526 Prevent automatic theme summary being cutoff with long text
2019-09-20 09:20:57 -07:00
Dennis Schubert
5577470d0b
No bug - Add WebCompat feature.
2019-09-20 08:33:48 -07:00
Tiger Oakes
f71ec8928b
Add note about lazy in FeatureFlags
2019-09-20 08:33:29 -07:00
Sawyer Blatz
6f3d7b4ee8
For #5396 : Adds "always launch in private mode" to settings
2019-09-20 08:33:07 -07:00
Emily Kager
9591172ee9
No issue: Make Shortcut dialog buttons match other dialogs
2019-09-20 08:04:55 -07:00
Mihai Adrian
a1c8fc0698
For #3731 Improved UX for opening tabs from a Collection ( #5427 )
...
* For #3731 Changed order of items for a collection's overflow menu
* For #3731 Changed the order tabs open to keep same order from collections
2019-09-20 06:41:04 -07:00
Tiger Oakes
05a4faec78
Add tryGetHostFromUrl and update ExceptionDomains
2019-09-19 22:40:35 -04:00
Colin Lee
1aa4f5a519
For #255 : Toggle Media Autoplay
2019-09-19 15:13:04 -07:00
Sawyer Blatz
2db2d9ceae
For #1744 : Adds tests for clipboard
2019-09-19 08:24:27 -07:00
Sawyer Blatz
fd1fcd8b89
For #4155 : Adds paste & go for search terms
2019-09-19 08:24:27 -07:00
Sawyer Blatz
e961a9d63d
For #1744 : Adds clipboard provider to search engine screen
2019-09-19 08:24:27 -07:00
Tiger Oakes
1777b5a830
Use enum to simplify delete on quit code
2019-09-18 20:20:08 -07:00
Tiger Oakes
106458c2c9
For #3440 - Reduce HomeFragment require calls
2019-09-18 17:25:44 -07:00
Jeff Boek
976c840047
For #3077 - Replaces connect another device dialog with a scree
2019-09-18 17:24:43 -07:00
Unpublished
065ce13999
Pass color resource for what's new menu item by id
2019-09-18 16:41:03 -07:00
Sawyer Blatz
956f4f0534
For #5411 : Fixes delete button turning red ( #5412 )
2019-09-18 15:20:05 -07:00
Sawyer Blatz
50cd2920d3
For #5371 : Updates search engine settings string ( #5393 )
2019-09-18 11:26:44 -07:00
Emily Kager
a68fabd3a7
For #1749 - Update to new ETP Settings Strings ( #5395 )
2019-09-18 10:36:09 -07:00
Emily Kager
95e4f2d754
No issue: Land strings for login management
2019-09-18 08:06:20 -07:00
Sawyer Blatz
e1b84a7a08
For #5396 : Reverts broken activity alias
2019-09-17 18:35:31 -07:00
Tiger Oakes
284cbab9ea
Use .orEmpty()
2019-09-17 11:09:21 -07:00
Emily Kager
3e132f102c
No issue: Update androidx libraries Sept 5 2019
2019-09-17 09:50:31 -07:00
Mihai Adrian
1767bd5569
For #5174 Changed FindInPage height to toolbar height to cover QAB ( #5376 )
2019-09-17 05:47:17 -07:00
Emily Kager
2b71af4087
For #5258 - Pop AccountProblemFragment if signed out
2019-09-16 21:26:01 -07:00
Grisha Kruglov
8a9340fd9d
Post: Clean up 'push' initialization code
2019-09-16 19:44:13 -07:00
Grisha Kruglov
d67fb3eed2
Post: Add experiment flags, push and telemetry tests for BackgroundServices
2019-09-16 19:44:13 -07:00
Grisha Kruglov
eeaeb973ff
Post: minor cleanup
2019-09-16 19:44:13 -07:00
Grisha Kruglov
c2fb99a73f
FxA WebChannels integration
...
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes #4971 )
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-16 19:44:13 -07:00
Tiger Oakes
a61391ef58
Separates tracker bucket sorting code
2019-09-16 15:16:12 -07:00
Emily Kager
7214f40008
For #5368 - Make every blocking category gone by default
2019-09-16 15:01:29 -07:00
Emily Kager
140da0dd0f
For #5359 , #5360 - Update ETP Vectors for Android 5+6
2019-09-16 15:01:29 -07:00
Axel Hecht
0eca317d03
Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@f0d82028ce
2019-09-16 12:54:44 -07:00
Yeon Taek Jeong
b6f2e8da35
For #5296 : Fix long-press shortcuts to work across build variants
2019-09-16 12:31:20 -07:00
mawen7
9ebd4efe70
Pass app name to delete browsing data prompt
2019-09-16 09:59:42 -07:00
Sebastian Kaspari
b8539ccb33
Use new feature-contextmenu API.
2019-09-16 17:24:13 +02:00
Tiger Oakes
42bb3e1410
Change deleteAndQuit to take an activity
2019-09-15 20:03:04 -07:00
ekager
90ef5ec9bb
Closes #5338 - Use padding instead of margin for delete browsing item
2019-09-15 19:46:50 -07:00
Emily Kager
da37dedba3
For #5279 - Don't use runBlocking in delete and quit
2019-09-14 11:18:43 -07:00
ekager
8cd0d8faf3
For #5304 - Align ETP Onboarding Tool Tip PopupWindow
2019-09-13 18:25:26 -07:00
Yeon Taek Jeong
3787dd7b1f
For #5254 : Fix transition to private browsing mode after sharing a page
2019-09-13 14:44:28 -07:00
Axel Hecht
8a371191b7
Import strings from android-l10n ( #5300 )
...
State: mozilla-l10n/android-l10n@e78d5868c7
2019-09-13 12:15:08 -07:00
Sawyer Blatz
e247870b9f
For #5277 : Updates string for delete browsing data ( #5309 )
2019-09-13 10:18:25 -07:00
Sebastian Kaspari
dd85229c41
Use new feature-downloads API.
2019-09-13 15:01:25 +02:00
Sawyer Blatz
42b31f0088
For #4155 : Adds elevation to copy/paste menu
2019-09-12 14:03:12 -07:00
Mihai Adrian
c8bc144114
For #2570 : Hide 3-dots menu when in select mode for bookmarks and history ( #5173 )
...
Show or hide overflow menu for entire list is triggered when mode is changed
For bookmarks, due to implementation of selection and diffUtil,
additional check is necessary for current item (last selected) that is redrawn
2019-09-12 13:56:39 -07:00
Sawyer Blatz
93ba506722
No issue: Slightly changes margin on play/pause button
2019-09-12 13:37:49 -07:00
Emily Kager
f698bdfcb5
For #5270 - Adds state list color for delete browsing checkboxes
2019-09-12 13:27:27 -07:00
Emily Kager
96f0ec829b
No issue: Remove recommended from standard ETP option
2019-09-12 12:34:28 -07:00
Emily Kager
b83ae45c36
For #5263 - Hide ETP Panel Settings for custom tab
2019-09-12 10:45:35 -07:00
Tiger Oakes
4acf48e817
Fixes #5212 - Change tint in onCreateOptionsMenu
...
Also fixes #5213
2019-09-12 10:30:49 -07:00
Colin Lee
0d1c19d017
For #3106 : Improve granular data deletion margins
2019-09-12 10:25:14 -07:00
Mihai Adrian
bc16061939
For #3371 : Show snackbar message when share fails with crash ( #5210 )
2019-09-12 09:26:24 -07:00
Emily Kager
fcb0448fa5
For #4458 - Enable font inflation with font auto size setting ( #5252 )
2019-09-12 09:05:16 -07:00
ekager
4461230e9b
For #5229 , #5228 - Dismiss ETP panel on back press, don't truncate text
2019-09-12 07:40:49 -07:00
Emily Kager
a5859e0028
For #5178 - Polish delete browsing data item layout
2019-09-11 18:11:26 -07:00
Emily Kager
102a36bd7e
No issue: Updates isPWA to isInstallable for AC 13 snapshot
2019-09-11 18:10:52 -07:00
Roger Yang
b3eca65614
Closes #5091 : Refactor Sentry BreadCrumbs to use lib-crash BreadCrumbs
2019-09-11 16:14:42 -07:00
Emily Kager
80d8c76453
No issue: Land new ETP Strings
2019-09-11 16:11:42 -07:00
Jeff Boek
e092dfd684
For #5047 - Addresses nits
...
- Changes MainScope to viewLifecycleScope
- Fixes string name/comment to better describe what it is
- Adds disabled state to the add button
2019-09-11 16:10:54 -07:00
Jeff Boek
d18ec49704
For #5047 - Wires up dialog to webAppUseCases
2019-09-11 16:10:54 -07:00
Jeff Boek
faff73b9b3
For #5047 - Creates dialog ui for naming a shortcut
2019-09-11 16:10:54 -07:00
Emily Kager
e3209dcc84
For #3700 - Add Setting to Delete Data on "Quit" menu action
2019-09-11 16:06:18 -07:00
Yeon Taek Jeong
ddc1b2e648
For #4658 : Add private browsing mode shortcut telemetry
2019-09-11 16:03:22 -07:00
Emily Kager
418b1ba890
For #1749 - Use Strict ETP by default, use Feature Flag for Settings
2019-09-11 16:03:01 -07:00
Sawyer Blatz
999d3cb963
For #1114 : Show playing tab
2019-09-11 15:45:22 -07:00
Emily Kager
bafbea1512
No issue: Set color for toolbar divider ( #5221 )
2019-09-11 11:46:00 -07:00
Emily Kager
9a4610f068
For #2897 - Add Action States To Share Sheet
2019-09-11 11:32:26 -07:00
Yeon Taek Jeong
2e2bac4ccd
For #419 : Create launch icon for private browsing ( #4948 )
2019-09-11 10:52:33 -07:00
Sawyer Blatz
5586b18c3e
For #4155 : Handle custom tabs & fix test
2019-09-11 09:03:17 -07:00
Sawyer Blatz
53b3f105ca
For #4155 : Sets pastedText default value
2019-09-11 09:03:17 -07:00
Sawyer Blatz
9d30d7bb03
For #4155 : Restyle to custom menu
2019-09-11 09:03:17 -07:00
Sawyer Blatz
52fd327bc0
For #4155 : Adds tests for browser toolbar popup menu
2019-09-11 09:03:17 -07:00
Sawyer Blatz
fdd2b59fb8
For #4155 : Adds popup menu for browser toolbar
2019-09-11 09:03:17 -07:00
Emily Kager
4485b7f647
Add Tracking Protection Info Panel
2019-09-11 07:47:13 -07:00
mihai-adrian
ef4a6b4154
For #4877 : Restored logic for closing tabs when not on browserFragment
...
Added return in function when saving collections coming from browser fragment
2019-09-10 21:42:16 -07:00
Sawyer Blatz
e240de7e31
For #4908 : Adds telemetry for send tab
2019-09-10 20:58:12 -07:00
Tiger Oakes
d0ef2d40c2
Move bookmark navigation listener to separate file
2019-09-10 16:53:09 -07:00
Sawyer Blatz
f7dde41b3b
For #5021 : Adds telemetry for what's new button
2019-09-10 14:15:34 -07:00
Tiger Oakes
3c07cacf4d
Use A-C preferences property delegates
2019-09-10 13:19:00 -07:00
ekager
9dd9400600
For #5178 - Do not truncate delete browsing text
2019-09-10 10:44:14 -07:00
Tiger Oakes
b77c4d2e2e
Clean up SupportUtils
2019-09-10 10:16:04 -07:00
Mihai Adrian
a31eb1f371
Code Health #4883 : Refactored accessing settings by using Context extensions ( #4973 )
2019-09-10 10:11:58 -07:00
Sawyer Blatz
cd533854e6
No issue: Only use iconTint in XML for bookmark menus ( #5145 )
2019-09-10 09:04:05 -07:00
Tiger Oakes
16115f57d1
For #3440 - Reduce BrowserFragment require calls
2019-09-09 21:33:32 -07:00
mihai-adrian
8d363d68b1
For #4517 : Keep Bookmarks fragment when navigating to browser
...
Removed popUp when navigating from bookmarks to browser
2019-09-09 20:52:36 -07:00
Colin Lee
4c2a7ac10e
Delete AUTH_SESSIONS with COOKIES
2019-09-09 12:32:28 -07:00
Colin Lee
758f4c13ec
Updates per UX and PR feedback
2019-09-09 12:32:28 -07:00
Colin Lee
2b9efccfca
For #3106 : Granular options for clearing user data
2019-09-09 12:32:28 -07:00
Sawyer Blatz
b86a32fa17
No issue: Top aligns close button for tab in collection ( #5161 )
...
See https://github.com/mozilla-mobile/fenix/pull/4442#issuecomment-528580904 for more info
2019-09-09 11:08:30 -07:00
Petru Lingurar
53341f620a
Code cleanup - Remove unused FindInPageBarBehavior
...
There is a "unused" lint suppression in place with the comment
"Referenced from XML". I found no such usage.
It's documentation says that this Behavior will always position FindInPageBar
above BrowserToolbar but the current code ensures
BrowserToolbar.visibility == GONE when FindInPageBar.visibility == VISIBLE
so there's no need for such behavior.
2019-09-06 14:20:02 -04:00
Petru Lingurar
716cf3995a
Fix #4856 - Propagate LifecycleAwareFeature's onStart() to the inner feature
...
FindInPageFeature is used inside the app as a LifecycleAwareFeature and as such
it receives the onStart / onStop lifecycle calls.
The onStart() lifecycle call would not get passed to the feature but in
onStop() FindInPageFeature will detach it's Presenter and Interactor so when
the user comes back to the screen she could not interact anymore with the
feature.
To fix this we'll propagate LifecycleAwareFeature's onStart() to the inner
feature which is to rebind it's Presenter and Interactor in onStart().
This behavior is common to all the other features so all of them who implement
LifecycleAwareFeature will now get the onStart() call also.
2019-09-06 14:20:02 -04:00
Mihai Adrian
ed0b6bd5ef
For #4193 - Makes close button for tabs more accessible ( #4442 )
...
* fixes #4193 - made close button for tabs more accessible.
set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button and text as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
* Fix margins
2019-09-06 10:33:55 -07:00
Sawyer Blatz
aef087aae0
No issue: Removes unused nestedScrollQuickActionView ( #5143 )
2019-09-06 09:03:24 -07:00
mihai-adrian
c8d622c43d
For #5142 Removed RadioButton from accessibility keeping one option for Talkback
...
Set android:importantForAccessibility = "no" for RadioButton
2019-09-06 14:09:58 +02:00
Sawyer Blatz
2653b5966e
For #964 : Adds ability to disable each suggestion provider ( #5096 )
...
* For #964 : Adds ability to disable each suggestion provider
* Fix nit
2019-09-05 14:45:44 -07:00
Jonathan Almeida
ccd9e44a3e
No issue: Add logging for firebase/autopush
2019-09-05 16:03:36 -04:00