d5e5b73485
[fenix] Color the system bars in custom tabs ( https://github.com/mozilla-mobile/fenix/pull/4819 )
5 years ago
efe2e2e466
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/1000 - Remove isCustomTab flag ( https://github.com/mozilla-mobile/fenix/pull/4656 )
5 years ago
0e376bb266
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4399 : Create LibState Controller for Search ( https://github.com/mozilla-mobile/fenix/pull/4673 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4399 : Create LibState Controller for Search
* fix code format
* add unit tests for DefaultSearchController
* add more test
* fix unit tests
5 years ago
2634b6dee4
[fenix] For 4827 - Remove TransitionPreDrawListenerTest pending tests refactoring
...
New tests for `FragmentPreDrawManager` are to be added in https://github.com/mozilla-mobile/fenix/issues/4828
5 years ago
fa2abeffe9
[fenix] Fix 4827 - Use ktx doOnPreDraw() to restore HomeFragment's layout
...
The previous solution would result in a crash because the passed in
viewTreeObserver that would trigger onPreDraw would be invalid.
The proposed solution is simpler and ensures we'll always use the right
viewTreeObserver.
`FragmentPreDrawManager` is general enough that can be used by other Fragments
also, so I've added it to the `utils` package.
5 years ago
9431f611d5
[fenix] Update strings.xml
...
Remove space in placeholder for es (temp for release)
5 years ago
7d5d5b7afd
[fenix] Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@413e05dba4
5 years ago
1c389d1231
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4744 - Extract TransitionPreDrawListener ( https://github.com/mozilla-mobile/fenix/pull/4812 )
5 years ago
774d696c92
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4744 - Move search bar icon padding to dimens ( https://github.com/mozilla-mobile/fenix/pull/4814 )
5 years ago
0268034e79
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4822 - Update Bookmark State in onResume ( https://github.com/mozilla-mobile/fenix/pull/4823 )
5 years ago
8a1829b484
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/4179 removed control highlight from disconnect button ( https://github.com/mozilla-mobile/fenix/pull/4806 )
...
set colorControlHighlight to transparent in activity theme.
property cannot be set in view because it is overwritten by activity theme.
5 years ago
1c995d36e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2706 : Refactor Glean to reduce errors ( https://github.com/mozilla-mobile/fenix/pull/4753 )
...
* For https://github.com/mozilla-mobile/fenix/issues/2706 : Adds recording for untracked events
* For https://github.com/mozilla-mobile/fenix/issues/2706 : Adds key alignment to Metrics
5 years ago
46eaca2871
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4421 : Fixes issues with new glean events ( https://github.com/mozilla-mobile/fenix/pull/4816 )
5 years ago
ea193a5472
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4804 : Resolves issue with crash reporter stack
5 years ago
aa9bf1aa6e
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4618 - Stub Library UI tests ( https://github.com/mozilla-mobile/fenix/pull/4619 )
...
See https://github.com/mozilla-mobile/fenix/issues/4572
5 years ago
7f746f6f17
[fenix] Use Mozilla Android Components 9.0.0-SNAPSHOT. ( https://github.com/mozilla-mobile/fenix/pull/4750 )
5 years ago
f3a412e24e
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4704 ( https://github.com/mozilla-mobile/fenix/pull/4728 )
...
* Fixes https://github.com/mozilla-mobile/fenix/issues/4704 . Overrides `setEnabled` for DeleteBrowsingDataItem to change view alpha when disabled and to toggle the checkbox `isEnabled` behavior based on the value provided.
* Updates CHANGELOG.md
* Removes unnecessary disabling of checkbox in DeleteBrowsingDataItem.kt
Updates CHANGELOG.md to reflect the component changed.
5 years ago
43e4bcc0b1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4396 - Add a Bookmarks Controller ( https://github.com/mozilla-mobile/fenix/pull/4593 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4396 - Rename BookmarkInteractor methods
Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.
Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.
* For https://github.com/mozilla-mobile/fenix/issues/4396 - Add a BookmarkController
It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.
This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.
* For https://github.com/mozilla-mobile/fenix/issues/4396 - Refactored Bookmark related tests
Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`
Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
5 years ago
84349bda63
[fenix] Extract quick action sheet observer code ( https://github.com/mozilla-mobile/fenix/pull/4368 )
5 years ago
80b2c4ee51
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4799 https://github.com/mozilla-mobile/fenix/issues/4790 - Don't use passed in sessions in BrowserToolbarController ( https://github.com/mozilla-mobile/fenix/pull/4800 )
5 years ago
47bbb9081d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4686 : Fix potential security issue ( https://github.com/mozilla-mobile/fenix/pull/4764 )
5 years ago
d72c8cf1b6
[fenix] No issue: fixes click failures on search widget icon
5 years ago
043f8829c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4688 - Try to use context instead of targetContext ( https://github.com/mozilla-mobile/fenix/pull/4765 )
5 years ago
b1fdb6a353
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4736 : Display search shortcuts only from home or search widget
5 years ago
52ff9a61f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4688 - Try slightly different Context class for MockWebServer ( https://github.com/mozilla-mobile/fenix/pull/4747 )
5 years ago
b037ddee5a
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4680 - Align collection creation text center vertical
5 years ago
6c41d30fd8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4384 : Hide mic icon if speech-to-text is unavailable ( https://github.com/mozilla-mobile/fenix/pull/4701 )
5 years ago
8efb7f9cdb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4516 : Use full width for large search widgets ( https://github.com/mozilla-mobile/fenix/pull/4659 )
5 years ago
e4f3b39e0b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/3860 - Update description text for collections
5 years ago
6cfbb2c02b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4421 : Adds Leanplum events and attributes ( https://github.com/mozilla-mobile/fenix/pull/4626 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4421 : Adds Leanplum events and attributes
* For https://github.com/mozilla-mobile/fenix/issues/4421 : Adds Leanplum deep links
5 years ago
309b86544c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4421 : Add search widget attribute to Leanplum ( https://github.com/mozilla-mobile/fenix/pull/4694 )
5 years ago
468c400ff5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4457 : Adds telemetry for search widget actions ( https://github.com/mozilla-mobile/fenix/pull/4714 )
5 years ago
2c70a18a62
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4732 : Fix search engine display issue ( https://github.com/mozilla-mobile/fenix/pull/4735 )
5 years ago
4835dbb1a8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4434 - made close button for collections more accessible. ( https://github.com/mozilla-mobile/fenix/pull/4443 )
...
* fixes https://github.com/mozilla-mobile/fenix/issues/4434 - made close button for collections more accessible.
set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
implemented same visual solution as for https://github.com/mozilla-mobile/fenix/issues/4193 - close button for tabs
* fixes https://github.com/mozilla-mobile/fenix/issues/4434 - made buttons for collection home list row more accessible and aligned 3 dot menu with individual tabs close button
set buttons sizes to recommended minimum size for accessibility 48x48, while keeping image size the same
removed margins from buttons as they were not needed anymore
aligned center of menu buttons with center of collection icon
constrained description top to bottom of title, instead of share button to reduce empty space. (overlap with share button is already prevented by end constraint of description)
5 years ago
9646181343
[fenix] Add no-op experiment to test service-experiments integration ( https://github.com/mozilla-mobile/fenix/pull/4551 )
...
* Add no-op experiment to test service-experiments integration
* Shorten metric name to meet schema
* Add active_experiment metric to docs
* Add approved data review
5 years ago
07eda357ba
[fenix] Use global navigation action for browser fragment ( https://github.com/mozilla-mobile/fenix/pull/4691 )
5 years ago
61e400c2d8
[fenix] Fix UI Screenshot TabMenuTest ( https://github.com/mozilla-mobile/fenix/pull/4730 )
5 years ago
4987c40d67
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1667 : Screen reader can't reach other UI items when QAB expanded ( https://github.com/mozilla-mobile/fenix/pull/4695 )
5 years ago
bf76cbe7e6
[fenix] No issue - Autoformatting ( https://github.com/mozilla-mobile/fenix/pull/4715 )
5 years ago
c30700580c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4719 : Get rid of fragment-testing dependency and create fragments in StoreProviderTest manually. ( https://github.com/mozilla-mobile/fenix/pull/4722 )
5 years ago
2de56210e2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4709 : Fix Bugzilla issue 1573549 ( https://github.com/mozilla-mobile/fenix/pull/4710 )
5 years ago
9c7caab6e3
[fenix] fix https://github.com/mozilla-mobile/fenix/issues/4633 : show toast only on first login ( https://github.com/mozilla-mobile/fenix/pull/4676 )
...
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
5 years ago
f292286006
[fenix] Fix https://github.com/mozilla-mobile/fenix/issues/4436 : hide onboarding before navigating to settings ( https://github.com/mozilla-mobile/fenix/pull/4675 )
...
* Fix https://github.com/mozilla-mobile/fenix/issues/4436 : hide onboarding before navigating to settings
* No issue: Rename emitAccountChanges to emitModeChanges
5 years ago
4cba063e4e
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4431 : Integrate feature-media component (Nightly and debug builds only). ( https://github.com/mozilla-mobile/fenix/pull/4683 )
5 years ago
de2b2a74c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4652 : HomeFragment Crash "Can not.. after onSaveInstanceState"
5 years ago
3cfa2aff96
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3424 - Make talkback ignore ImageButton in Collection Sele… ( https://github.com/mozilla-mobile/fenix/pull/3792 )
...
For https://github.com/mozilla-mobile/fenix/issues/3424 - Make talkback ignore ImageButton in Collection Selection by removing contentDescription and setting importantForAccessibility=no
5 years ago
caeb3477b9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4671 : Fix a potential NPE in BookmarkFragment
5 years ago
cd52df3314
[fenix] No issue: add some BookmarkFragmentInteractor tests
5 years ago
88db14a22f
[fenix] No issue: reduce code duplication in BookmarkFragmentInteractor
5 years ago
9b956a3c42
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4125 : Suppress coroutine warning to fix release build
5 years ago
Tiger Oakes
Sourabh
Mugurell
Emily Kager
Axel Hecht
Mihai Adrian
Sawyer Blatz
Aaron Train
Arturo Mejia
Suraj Shah
Mugurell
Colin Lee
Yeon Taek Jeong
Emily Kager
Michael Cooper
isabelrios
Sebastian Kaspari
Sourabh
(´⌣`ʃƪ)
Jorge De Los Santos
Grisha Kruglov
Christian Sadilek