Commit Graph

6334 Commits (b682f2d5c572e84a033189faeceacac442cd8c09)

Author SHA1 Message Date
Arturo Mejia d0d87a6d6d No issue update strings ids 3 years ago
AndiAJ 71d151ef18 For #18421 re-enable verifyContextCopyLink and verifyContextCopyImageLocation UI tests 3 years ago
Gabriel Luong 8f85ef2d5b For #21973 - Remove @color/top_site_title_text_light_theme redirection 3 years ago
Gabriel Luong 28883384a7 For #21973 - Remove @color/inset_dark_theme redirection 3 years ago
Gabriel Luong 9a85545da5 For #21973 - Remove @color/top_site_title_text_dark_theme redirection 3 years ago
Gabriel Luong 59f725d2fb For #21973 - Remove @color/synced_tabs_separator_dark_theme redirection 3 years ago
Gabriel Luong 35c7ef6bb6 For #21973 - Remove @color/toggle_off_knob_light_theme and @color/toggle_off_track_light_theme redirection 3 years ago
Gabriel Luong e2093f2054 For #21973 - Remove redirection of color variables for the collection color variables 3 years ago
Gabriel Luong 4001f4ee6f For #21973 - Remove redirection of color variables for the tabs tray color variables 3 years ago
Gabriel Luong 1a472c3507 For #21973 - Remove @color/caption_text_dark_theme redirection 3 years ago
Gabriel Luong 78e90d5f0e For #21973 - Remove @color/contrast_text_dark_theme redirection 3 years ago
Gabriel Luong 2456e9b5f5 For #21973 - Remove @color/secondary_text_dark_theme redirection 3 years ago
Gabriel Luong 959a142c92 For #21973 - Use destructive_normal_theme in place of R.color.design_color 3 years ago
Mozilla L10n Automation Bot b7bdd94e71 Import l10n. 3 years ago
Michael Comella 9721723af5 For android-components#11161: pass profiler into AwesomeBar.
This will add two new markers:
- SuggestionFetcher.fetch
- Suggestion update

This is a profile with the markers: https://share.firefox.dev/3E4PbEk
3 years ago
AndiAJ 4fe8921a82 For #18421 fix and re-enable verifyContextShareLink, verifyContextSaveImage and verifyContextMixedVariations UI tests 3 years ago
Arturo Mejia a2c7dfb26e For #22170: Add telemetry for the auto-close prompt 3 years ago
Arturo Mejia 9154371ba5 For #21906 ⁃ Update strings removal version 3 years ago
Mozilla L10n Automation Bot 59a069882d Import l10n. 3 years ago
Grisha Kruglov 04a35c81b8 Closes #22083 - Match history groups to history pages by all items within the group
When deciding if we should include a history group within the "page of
history" results on the History View UI, we used to look at the most
recent timestamp of the metadata items within the group, and see if that
falls within the range of the timestamps of the history page, +/- some
buffer.

This assumes that each metadata entry will have a corresponding history
item. However, that's not true - when restarting the app, the selected
tab will be restored, and when opening History View right after we'll
record some metadata for it. However, we won't record a history visit
during the app restore for the selected tab.

That's all correct, but the assumption around group matching to history is now incorrect.

This patch changes the logic to instead look at every item within the
group, and see if any of them match the time window of the current
history page. This has a side-effect of also displaying search groups
multiple times on diffenent pages of history, if it makes sense to do so chronologically.
I think that's fine, it reflects reality at least (e.g. items within the
group may have been visited at very different points in time).

Co-authored-by: Christian Sadilek <christian.sadilek@gmail.com>
3 years ago
Elise Richards 347f82f2f5
For #21313: Renew metrics for December - never expire updates (#21788)
* For #21313: Renew metrics for December - never expire updates

* For #21313: data review

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Arturo Mejia d943be0e53 For #22034: Inactive tabs prompt is redisplayed after dismissing by turning on Auto close 3 years ago
MickeyMoz a4bcecf8c5 Update Android Components version to 95.0.20211026143215.
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
3 years ago
Gabriel Luong 44666ca2ca For #21776 - Call chain on collection type may be simplified 3 years ago
Gabriel Luong 100547130e For #21776 - Add package path to TabGroupViewHolder 3 years ago
Gabriel Luong b04bf99b7d For #21776 - Remove unused symbols 3 years ago
Gabriel Luong b54698a3f2 For #21776 - Class member can have 'private' visibility 3 years ago
Gabriel Luong 3115f1343f For #21776 - Replace Java static method with Kotlin analog 3 years ago
Gabriel Luong 660300f770 For #21776 - Replace 'isEmpty' with 'ifEmpty' 3 years ago
Gabriel Luong 603ba63962 For #21776 - 'protected' visibility is effectively 'private' in a final class 3 years ago
Gabriel Luong da395d1038 For #21776 - Local 'var' is never modified and can be declared as 'val' 3 years ago
Gabriel Luong 5afe393b8f For #21776 - Remove unused imports 3 years ago
Gabriel Luong 76c746b982 For #21776 - Remove unnecessary type argument 3 years ago
Gabriel Luong 272d31b2b4 For #21776 - Remove unnecessary parentheses from function call with lambda 3 years ago
Gabriel Luong 6d1d4bea93 For #21776 - Remove redundant qualifier name 3 years ago
Gabriel Luong 1039a92281 For #21776 - Remove reductant SAM constructor 3 years ago
Gabriel Luong ed48dc934a For #21776 - Remove reductant 'suspend' modifier from SecurePrefsTelemetry 3 years ago
Gabriel Luong d854c282da For #21776 - Remove val from constructor parameter that are never used as a property 3 years ago
codrut.topliceanu bba787e87e For #21732 - Adds inactive tabs survey on disable + telemetry 3 years ago
Mugurell 6d62aed35f For #21933 - Refresh history items everytime the fragment is opened 3 years ago
Mozilla L10n Automation Bot c9e769544f Import l10n. 3 years ago
Jonathan Almeida 7666f0e4c2 No issue: Replace TabsTray.Tab with TabSessionState
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
3 years ago
Jonathan Almeida b2a7877c83 No issue: Disable FenixSnackbarDelegateTest intermittents 3 years ago
Michael Droettboom c1780cf332
For #21025: Set long term business-critical metrics as non-expiring (#21038)
* Set long term business-critical metrics as non-expiring.

* Remove quotes around "never"

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
AndiAJ 6149f9faf8 Use identifiers instead of hard coded strings 3 years ago
AndiAJ d3651eb0fc For #21747 re-enable start on homepage UI test and refactoring work 3 years ago
AndiAJ b10835992d For #21754 re-enable general settings UI test and refactoring work 3 years ago
AndiAJ 4c343b8b3a For #21004 fix and refactor verifyBasicNavigationToolbarFunctionality UI test 3 years ago
Roger Yang 367c5f42d8 No issue: Add external load flag 3 years ago
Sebastian Kaspari 170fa9705e Update Kotlin and Jetpack Compose versions. 3 years ago
Oana Horvath 52facc9723 For #21628: catch ComposeNotIdleException 3 years ago
Arturo Mejia ee8c4de62d For #21986 Confirmation when people set tabs to auto-close
For #22034 Inactive tabs prompt is redisplayed after dismissing by turning on Auto close
3 years ago
Mayank Agarwal 1a7b486808 Issue #21714: Login button visibility fix on saved logins page 3 years ago
Mugurell e0bf4f31fa For #21771 - Show url when recent tab's title is not available
This is the same previously used approach and the same used for tabs tray.
3 years ago
Mozilla L10n Automation Bot df2652f9b5 Import l10n. 3 years ago
Mozilla L10n Automation Bot a8f42cd363 Import l10n. 3 years ago
Mozilla L10n Automation Bot 9e1f596c1e Import l10n. 3 years ago
Michael Comella ec1a25dfcf For #21921 - post: switch generic marker skip to BaseBrowserFragment.
Since we instrument the marker with the duration in BaseBrowserFragment,
we should skip on BaseBrowserFragment too, not its subclass,
BrowserFragment.
3 years ago
Michael Comella 788eb2c5de For #21921: add duration for some BrowserFragment lifecycle markers.
Here is a sample profile with all the new markers:
https://share.firefox.dev/3lCGoD2
3 years ago
Michael Comella 3a3c39406a For #21921: add durations for some HomeFragment lifecycle markers. 3 years ago
Michael Comella f65ea1e972 For #21921: add and register MarkersFragmentLifecycleCallbacks. 3 years ago
Michael Comella 99533626f1 For #21921: rename MarkersLifecycleCallbacks to ...ActivityLifecycle...
This is to disamibugate with the MarkersFragmentLifecycleCallbacks that
we'll be adding.
3 years ago
Michael Comella 623914bd89 For #22054: add marker for root view layout/measure.
The onLayout marker may be redundant to onGlobalLayout marker but I'm not
sure yet so let's leave them both in and observe if that's the case.

Here's a profile with the markers: https://share.firefox.dev/3lZaOQb
3 years ago
Oana Horvath 1234d8f518 For #22095: fix intermittent click failure in verifyRateOnGooglePlayRedirect UI test 3 years ago
Mugurell acdde511d3 For #22070 - Prevent crash for when a selected topic does not exist anymore
The list of selected topics overwrites old data whenever user selects or
deselects another so the old selections will not leak for long.
3 years ago
Roger Yang 70fc6fc20f Close #22061: Let TabSorter decide if title header should be shown in tabs tray 3 years ago
Mozilla L10n Automation Bot 2d8492d33f Import l10n. 3 years ago
Roger Yang b5c15280f7 No issue: Only report telemetry when tabs tray is first opened 3 years ago
Mugurell c4278bfbf6 For #21841 - New telemetry for Google and Baidu top sites removal 3 years ago
Michael Comella a1ace964de No issue - post: fix ProfilerMarkerFactProcessor tests. 3 years ago
Michael Comella 0faa61b744 No issue: use Fact.value as detailText for markers.
This allows Facts emitted from ac to provide more details in markers.
3 years ago
Michael Comella 01e3b4b984 No issue: cache SearchDialogFragment.InlineAutocompleteEditText.
Assuming the InlineAutocompleteEditText is not being recreated (and I
did not verify this), it's unnecessary to traverse the view hierarchy
to find it more than once so this patch removes the unnecessary
traversals.
3 years ago
Oana Horvath 34ca959661 For #20754: fix intermittent click failure in verifyAboutFirefoxPreview test 3 years ago
Andrei Joltan 3af6abff18
For #22065 fix flaky privateTabsTrayWithOpenedTabTest UI test (#22068)
Co-authored-by: AndiAJ <andiaj@users.noreply.github.com>
3 years ago
AndiAJ 560de4f396 For #21207 fix flaky updateSavedLoginTest UI test 3 years ago
Mozilla L10n Automation Bot c0ab0cb1c5 Import l10n. 3 years ago
Gabriel Luong 64ca94b8fa For #22022 - Composify Customize Home Button and update the background color 3 years ago
Gabriel Luong ada3da59ec For #22022 - Update SelectableChip button background colors 3 years ago
xlog-null edd1fd9f2c For #22032 - Fix horizontal margin on private home screen 3 years ago
Gabriel Luong 07a6a386f8 For #21753 - Refactor Pocket out of sessioncontrol 3 years ago
Noah Bond 826249497a
MR2 Inactive tabs telemetry (#21908)
* For #21903 - Added telemetry for interacting with inactive tabs

* For #21903 - Added missing inactive tab delete count event to delete all event

* For #21903 - Added PR numbers to metrics

* For #21903 - Updated broken unit tests. Resolved critical lint warning.

* For #21903 - Fixed inactive tabs setting toggle metric

* For #21903 - Updated FenixApp unit test

* For #21903 - Updated newline character in Metrics. Set inactive tab metrics' lifetime to default. Updated expiration to Nov 2022. Refactored inactive tabs metric to be a single metric.

* PR: addendum for last commit that missed a file

* For #21903 - Changed logic check for reporting inactive tab count

* PR: fixed merge conflict

* For #21903 - Removed tab close tracking when the user closes ALL inactive tabs

* For #21903 - Removed individual tab close metric verify from CLOSE ALL test

* For #21903 - Updated inactive tabs toggle setting expiration to match the expiration of the other events

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 years ago
Gabriel Luong af48553418 For #21935 - Use photonBlue40 in place of #0090ED 3 years ago
Gabriel Luong 8b3d39f0c0 For #21935 - Use photonDarkGrey20 in place of #4A4A55 3 years ago
Gabriel Luong 541ed5cec6 For #21935 - Use photonPink30 in place of #FF6BBA 3 years ago
Gabriel Luong 5a5ba1c095 For #21935 - Use photonBlue30 in place of #00B3F4 3 years ago
Gabriel Luong a81912bd98 For #21935 - Use photonViolet30 in place of #C689FF 3 years ago
Gabriel Luong 475d59b781 For #21935 - Use photonYellow90 in place of #960E18 3 years ago
Gabriel Luong 5a7890497f For #21935 - Use photonRed40 in place of #FF6A75 3 years ago
Gabriel Luong dfd9f7c1ea For #21935 - Use photonDarkGrey50 in place oof #32313C 3 years ago
Gabriel Luong 6010767da7 For #21935 - Use photonBlue50 in place of #0060DF 3 years ago
Gabriel Luong 0e8b797014 For #21935 - Use photonGreen70 in place of #.008787 3 years ago
Gabriel Luong c379d75c7f For #21935 - Use photonInk20 in place of #312A64 3 years ago
Gabriel Luong 4d61277e88 For #21935 - Use photonViolet50 in place of #9059ff 3 years ago
Gabriel Luong a31d638191 For #21935 - Use photonYellow70 in place of #C45A27 3 years ago
Gabriel Luong a02d58dd48 For #21935 - Use photonYellow60 in place of #E27F2E 3 years ago
Gabriel Luong cd6bcb3d47 For #21935 - Use photonGreen60 in place of #2AC3A2 3 years ago
Gabriel Luong 9048af04be For #21935 - Use photonPink60 in place of #E31587 3 years ago
Gabriel Luong bd7ced5867 For #21935 - Use photonDarkGrey90 in place of #15141A 3 years ago
Gabriel Luong e119b8b590 For #21935 - Use photonViolet40 in place of #AB71FF 3 years ago
Gabriel Luong ff829f9f25 For #21935 - Use photonBlue60 in place of #0250BB 3 years ago