Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-05 21:20:45 +00:00
Code Issues Releases Wiki Activity
2,365 Commits 67 Branches 113 Tags 1.2 GiB
b5ef6dbcfe
Commit Graph

2027 Commits

Author SHA1 Message Date
Sawyer Blatz
a18a9af1c7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5396: Adds "always launch in private mode" to settings 2019-09-20 08:33:07 -07:00
Sawyer Blatz
d95e439bab [fenix] Reverts https://github.com/mozilla-mobile/fenix/issues/1151: Removes unused Flipper library 2019-09-20 08:05:14 -07:00
Emily Kager
6b99d7714b [fenix] No issue: Make Shortcut dialog buttons match other dialogs 2019-09-20 08:04:55 -07:00
Mihai Adrian
dfc03d4580 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3731 Improved UX for opening tabs from a Collection (https://github.com/mozilla-mobile/fenix/pull/5427) 
* For https://github.com/mozilla-mobile/fenix/issues/3731 Changed order of items for a collection's overflow menu

* For https://github.com/mozilla-mobile/fenix/issues/3731 Changed the order tabs open to keep same order from collections
 2019-09-20 06:41:04 -07:00
Tiger Oakes
f7983c0384 [fenix] Add tryGetHostFromUrl and update ExceptionDomains 2019-09-19 22:40:35 -04:00
Colin Lee
09fa635075 [fenix] For https://github.com/mozilla-mobile/fenix/issues/255: Toggle Media Autoplay 2019-09-19 15:13:04 -07:00
Sawyer Blatz
3c61270af5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1744: Adds tests for clipboard 2019-09-19 08:24:27 -07:00
Sawyer Blatz
c855e80043 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4155: Adds paste & go for search terms 2019-09-19 08:24:27 -07:00
Sawyer Blatz
85410f47fc [fenix] For https://github.com/mozilla-mobile/fenix/issues/1744: Adds clipboard provider to search engine screen 2019-09-19 08:24:27 -07:00
Tiger Oakes
b01480575b [fenix] Use enum to simplify delete on quit code 2019-09-18 20:20:08 -07:00
Jonathan Almeida
8d8adae0f1 [fenix] No issue: Add Digital Asset Links token for TWAs 2019-09-18 20:19:47 -07:00
Tiger Oakes
03d1034a3d [fenix] For https://github.com/mozilla-mobile/fenix/issues/3440 - Reduce HomeFragment require calls 2019-09-18 17:25:44 -07:00
Jeff Boek
5ecd6a1a9a [fenix] For https://github.com/mozilla-mobile/fenix/issues/3077 - Replaces connect another device dialog with a scree 2019-09-18 17:24:43 -07:00
Unpublished
97abbb9fe9 [fenix] Pass color resource for what's new menu item by id 2019-09-18 16:41:03 -07:00
Sawyer Blatz
cc79eb3a95 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5411: Fixes delete button turning red (https://github.com/mozilla-mobile/fenix/pull/5412) 2019-09-18 15:20:05 -07:00
Sawyer Blatz
320fd1462f [fenix] For https://github.com/mozilla-mobile/fenix/issues/5371: Updates search engine settings string (https://github.com/mozilla-mobile/fenix/pull/5393) 2019-09-18 11:26:44 -07:00
Emily Kager
7c3a8c2e57 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1749 - Update to new ETP Settings Strings (https://github.com/mozilla-mobile/fenix/pull/5395) 2019-09-18 10:36:09 -07:00
Emily Kager
b51c5de5b0 [fenix] No issue: Land strings for login management 2019-09-18 08:06:20 -07:00
Sawyer Blatz
24abe8b9d8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5396: Reverts broken activity alias 2019-09-17 18:35:31 -07:00
Tiger Oakes
b4a7190d1e [fenix] Use .orEmpty() 2019-09-17 11:09:21 -07:00
Emily Kager
44dee734d4 [fenix] No issue: Update androidx libraries Sept 5 2019 2019-09-17 09:50:31 -07:00
Mihai Adrian
028d9fe646 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5174 Changed FindInPage height to toolbar height to cover QAB (https://github.com/mozilla-mobile/fenix/pull/5376) 2019-09-17 05:47:17 -07:00
Emily Kager
2c74a708a0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5258 - Pop AccountProblemFragment if signed out 2019-09-16 21:26:01 -07:00
Grisha Kruglov
27812d19e0 [fenix] Post: Clean up 'push' initialization code 2019-09-16 19:44:13 -07:00
Grisha Kruglov
5fb2eadde8 [fenix] Post: Add experiment flags, push and telemetry tests for BackgroundServices 2019-09-16 19:44:13 -07:00
Grisha Kruglov
ddbfc7b4c1 [fenix] Post: minor cleanup 2019-09-16 19:44:13 -07:00
Grisha Kruglov
6411072f0d [fenix] FxA WebChannels integration 
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes https://github.com/mozilla-mobile/fenix/issues/4971)

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2019-09-16 19:44:13 -07:00
Tiger Oakes
65a6d962b3 [fenix] Separates tracker bucket sorting code 2019-09-16 15:16:12 -07:00
Emily Kager
5c5d3b8ab8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5368 - Make every blocking category gone by default 2019-09-16 15:01:29 -07:00
Emily Kager
b7d6ab40b2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5359 , https://github.com/mozilla-mobile/fenix/issues/5360 - Update ETP Vectors for Android 5+6 2019-09-16 15:01:29 -07:00
Axel Hecht
0434de4d53 [fenix] Import strings from android-l10n 
State: mozilla-l10n/android-l10n@f0d82028ce
 2019-09-16 12:54:44 -07:00
Yeon Taek Jeong
6fdb6d41fa [fenix] For https://github.com/mozilla-mobile/fenix/issues/5296: Fix long-press shortcuts to work across build variants 2019-09-16 12:31:20 -07:00
mawen7
04a72ff834 [fenix] Pass app name to delete browsing data prompt 2019-09-16 09:59:42 -07:00
Sebastian Kaspari
f205820367 [fenix] Use new feature-contextmenu API. 2019-09-16 17:24:13 +02:00
Tiger Oakes
b0f4ecd5a5 [fenix] Change deleteAndQuit to take an activity 2019-09-15 20:03:04 -07:00
ekager
d14d848d51 [fenix] No issue: Fixes UI tests by removing TP onboarding closure 2019-09-15 19:47:16 -07:00
ekager
438fb1ac95 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5338 - Use padding instead of margin for delete browsing item 2019-09-15 19:46:50 -07:00
Emily Kager
ec79707dfe [fenix] For https://github.com/mozilla-mobile/fenix/issues/5279 - Don't use runBlocking in delete and quit 2019-09-14 11:18:43 -07:00
ekager
28b4010b7a [fenix] For https://github.com/mozilla-mobile/fenix/issues/5304 - Align ETP Onboarding Tool Tip PopupWindow 2019-09-13 18:25:26 -07:00
Richard Pappalardo
6b813c0aae [fenix] fix: broken UI tests (https://github.com/mozilla-mobile/fenix/pull/5324) 2019-09-13 17:30:53 -07:00
Yeon Taek Jeong
359619c538 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5254: Fix transition to private browsing mode after sharing a page 2019-09-13 14:44:28 -07:00
Axel Hecht
5acc115b73 [fenix] Import strings from android-l10n (https://github.com/mozilla-mobile/fenix/pull/5300) 
State: mozilla-l10n/android-l10n@e78d5868c7
 2019-09-13 12:15:08 -07:00
Sawyer Blatz
2c4b7d0f61 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5277: Updates string for delete browsing data (https://github.com/mozilla-mobile/fenix/pull/5309) 2019-09-13 10:18:25 -07:00
Oana Horvath
9706df2e2b [fenix] Adds 2 new tests to SearchTest (https://github.com/mozilla-mobile/fenix/pull/4770) 2019-09-13 10:11:33 -07:00
Sebastian Kaspari
e6d6d6ecf6 [fenix] Use new feature-downloads API. 2019-09-13 15:01:25 +02:00
No-Jun Park
d293228b8f [fenix] fix TabbedBrowsingTest.kt failure where Share Tabs element was not found (https://github.com/mozilla-mobile/fenix/pull/5282) 2019-09-12 15:56:35 -07:00
Alessio Placitelli
2edc73ed3f [fenix] Automatically generate metrics docs using the Glean SDK (https://github.com/mozilla-mobile/fenix/pull/5101) 2019-09-12 14:49:49 -07:00
Sawyer Blatz
c9bf807f3e [fenix] For https://github.com/mozilla-mobile/fenix/issues/4155: Adds elevation to copy/paste menu 2019-09-12 14:03:12 -07:00
Mihai Adrian
b0f9621fee [fenix] For https://github.com/mozilla-mobile/fenix/issues/2570: Hide 3-dots menu when in select mode for bookmarks and history (https://github.com/mozilla-mobile/fenix/pull/5173) 
Show or hide overflow menu for entire list is triggered when mode is changed
For bookmarks, due to implementation of selection and diffUtil,
additional check is necessary for current item (last selected) that is redrawn
 2019-09-12 13:56:39 -07:00
Colin Lee
f0fd309d38 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5274: Fix LogTest unit tests (https://github.com/mozilla-mobile/fenix/pull/5275) 2019-09-12 15:41:56 -05:00
Sawyer Blatz
6697a820f9 [fenix] No issue: Slightly changes margin on play/pause button 2019-09-12 13:37:49 -07:00
Emily Kager
9470a74175 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5270 - Adds state list color for delete browsing checkboxes 2019-09-12 13:27:27 -07:00
Emily Kager
c0fd3632c6 [fenix] No issue: Remove recommended from standard ETP option 2019-09-12 12:34:28 -07:00
Emily Kager
92f2692fbf [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5268 - Fix 2 detekt errors 2019-09-12 11:32:33 -07:00
Emily Kager
03b4bc2d32 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5263 - Hide ETP Panel Settings for custom tab 2019-09-12 10:45:35 -07:00
kglazko
58a85d264e [fenix] Issue 4622- Create Unit Tests for Extensions (https://github.com/mozilla-mobile/fenix/pull/4669) 2019-09-12 10:44:37 -07:00
Tiger Oakes
29d73507a9 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5212 - Change tint in onCreateOptionsMenu 
Also fixes https://github.com/mozilla-mobile/fenix/issues/5213
 2019-09-12 10:30:49 -07:00
Colin Lee
c1577cd1f8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3106: Improve granular data deletion margins 2019-09-12 10:25:14 -07:00
Mihai Adrian
2f2d130ad6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3371: Show snackbar message when share fails with crash (https://github.com/mozilla-mobile/fenix/pull/5210) 2019-09-12 09:26:24 -07:00
Emily Kager
b6679bc23d [fenix] For https://github.com/mozilla-mobile/fenix/issues/4458 - Enable font inflation with font auto size setting (https://github.com/mozilla-mobile/fenix/pull/5252) 2019-09-12 09:05:16 -07:00
ekager
9bc95446ca [fenix] For https://github.com/mozilla-mobile/fenix/issues/5229, https://github.com/mozilla-mobile/fenix/issues/5228 - Dismiss ETP panel on back press, don't truncate text 2019-09-12 07:40:49 -07:00
Sebastian Kaspari
509d3c5e20 [fenix] Unbreak Nightly: Get rid of fragment-testing dependency and create fragments in test manually. 2019-09-12 13:44:17 +02:00
Emily Kager
fe01f2f319 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5178 - Polish delete browsing data item layout 2019-09-11 18:11:26 -07:00
Emily Kager
432972dac1 [fenix] No issue: Updates isPWA to isInstallable for AC 13 snapshot 2019-09-11 18:10:52 -07:00
Emily Kager
a22a98243c [fenix] No issue: Fix BreadCrumbReporterTest 2019-09-11 18:10:52 -07:00
Roger Yang
d1011bbfda [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5091: Refactor Sentry BreadCrumbs to use lib-crash BreadCrumbs 2019-09-11 16:14:42 -07:00
Emily Kager
a652723373 [fenix] No issue: Land new ETP Strings 2019-09-11 16:11:42 -07:00
Jeff Boek
5099eaa00f [fenix] For https://github.com/mozilla-mobile/fenix/issues/5047 - Addresses nits 
- Changes MainScope to viewLifecycleScope
- Fixes string name/comment to better describe what it is
- Adds disabled state to the add button
 2019-09-11 16:10:54 -07:00
Jeff Boek
1574f05038 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5047 - Wires up dialog to webAppUseCases 2019-09-11 16:10:54 -07:00
Jeff Boek
410d33a4c8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5047 - Creates dialog ui for naming a shortcut 2019-09-11 16:10:54 -07:00
Emily Kager
e647d7e8c6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3700 - Add Setting to Delete Data on "Quit" menu action 2019-09-11 16:06:18 -07:00
Yeon Taek Jeong
88ecaf12b1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4658: Add private browsing mode shortcut telemetry 2019-09-11 16:03:22 -07:00
Emily Kager
f2ff2c4f32 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1749 - Use Strict ETP by default, use Feature Flag for Settings 2019-09-11 16:03:01 -07:00
Sawyer Blatz
f001f5b6d8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1114: Show playing tab 2019-09-11 15:45:22 -07:00
Jeff Boek
2102e39e4b [fenix] For https://github.com/mozilla-mobile/fenix/issues/5214 - Bumps expiration dates for telemetry 2019-09-11 14:44:13 -07:00
Emily Kager
ee8cd6d08f [fenix] No issue: Set color for toolbar divider (https://github.com/mozilla-mobile/fenix/pull/5221) 2019-09-11 11:46:00 -07:00
Emily Kager
8eb6b616c8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2897 - Add Action States To Share Sheet 2019-09-11 11:32:26 -07:00
Yeon Taek Jeong
c26cca80e7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/419: Create launch icon for private browsing (https://github.com/mozilla-mobile/fenix/pull/4948) 2019-09-11 10:52:33 -07:00
Aaron Train
036b3d239b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5217 - fix androidx.test dep error (https://github.com/mozilla-mobile/fenix/pull/5219) 
See https://github.com/mozilla-mobile/fenix/issues/5217
 2019-09-11 12:55:22 -04:00
Oana Horvath
f36d0c476a [fenix] added LibraryMenuTest, BookmarksRobot, HistoryRobot (https://github.com/mozilla-mobile/fenix/pull/4769) 
ran ktlint

added the goBack()method in  Transition

added the goBack method in Transition
 2019-09-11 09:09:22 -07:00
Sawyer Blatz
e30570dc86 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4155: Handle custom tabs & fix test 2019-09-11 09:03:17 -07:00
Sawyer Blatz
7bee891913 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4155: Sets pastedText default value 2019-09-11 09:03:17 -07:00
Sawyer Blatz
603740cde0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4155: Restyle to custom menu 2019-09-11 09:03:17 -07:00
Sawyer Blatz
8b5a149877 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4155: Adds tests for browser toolbar popup menu 2019-09-11 09:03:17 -07:00
Sawyer Blatz
7daf054b67 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4155: Adds popup menu for browser toolbar 2019-09-11 09:03:17 -07:00
Aaron Train
1465ea335c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5192 - Add UI Test for "What's New" menu option (https://github.com/mozilla-mobile/fenix/pull/5193) 2019-09-11 11:41:05 -04:00
Emily Kager
3b0a3c1643 [fenix] Add Tracking Protection Info Panel 2019-09-11 07:47:13 -07:00
mihai-adrian
40108e53c7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4877: Restored logic for closing tabs when not on browserFragment 
Added base test for CreateCollectionFragment that we can build upon later
 2019-09-10 21:42:16 -07:00
mihai-adrian
ed24b8b0f1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4877: Restored logic for closing tabs when not on browserFragment 
Added return in function when saving collections coming from browser fragment
 2019-09-10 21:42:16 -07:00
Sawyer Blatz
3c746c4b5c [fenix] For https://github.com/mozilla-mobile/fenix/issues/4908: Adds telemetry for send tab 2019-09-10 20:58:12 -07:00
Tiger Oakes
dd2c36c14a [fenix] Move bookmark navigation listener to separate file 2019-09-10 16:53:09 -07:00
Sawyer Blatz
2502dcc4bb [fenix] For https://github.com/mozilla-mobile/fenix/issues/5021: Adds telemetry for what's new button 2019-09-10 14:15:34 -07:00
Tiger Oakes
97bdbdc223 [fenix] Use A-C preferences property delegates 2019-09-10 13:19:00 -07:00
No-Jun Park
5dc8dd7264 [fenix] Create homeview share dialog UITest (https://github.com/mozilla-mobile/fenix/pull/5160) 
Share Button UI test added
Collection test steps created
 2019-09-10 15:03:47 -04:00
ekager
faedf2f638 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5178 - Do not truncate delete browsing text 2019-09-10 10:44:14 -07:00
Tiger Oakes
ebcc6ce414 [fenix] Clean up SupportUtils 2019-09-10 10:16:04 -07:00
Mihai Adrian
72f0d9ce56 [fenix] Code Health https://github.com/mozilla-mobile/fenix/issues/4883: Refactored accessing settings by using Context extensions (https://github.com/mozilla-mobile/fenix/pull/4973) 2019-09-10 10:11:58 -07:00
Sawyer Blatz
e2eb292241 [fenix] No issue: Only use iconTint in XML for bookmark menus (https://github.com/mozilla-mobile/fenix/pull/5145) 2019-09-10 09:04:05 -07:00
Tiger Oakes
0e9d9d82c5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3440 - Reduce BrowserFragment require calls 2019-09-09 21:33:32 -07:00
mihai-adrian
8a5b5682f4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4517: Keep Bookmarks fragment when navigating to browser 
Removed popUp when navigating from bookmarks to browser
 2019-09-09 20:52:36 -07:00
Colin Lee
06d8f42c94 [fenix] Delete AUTH_SESSIONS with COOKIES 2019-09-09 12:32:28 -07:00
Colin Lee
a34b774213 [fenix] Updates per UX and PR feedback 2019-09-09 12:32:28 -07:00
Colin Lee
736fb7fd7c [fenix] For https://github.com/mozilla-mobile/fenix/issues/3106: Granular options for clearing user data 2019-09-09 12:32:28 -07:00
Emily Kager
6103a21747 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4763 - Enable GV logging in debug builds (https://github.com/mozilla-mobile/fenix/pull/5144) 2019-09-09 11:20:51 -07:00
Aaron Train
7f6fdcda4b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5137 - Add Find in Page UI Test (https://github.com/mozilla-mobile/fenix/pull/5138) 2019-09-09 14:16:47 -04:00
Sawyer Blatz
1cfb9cef09 [fenix] No issue: Top aligns close button for tab in collection (https://github.com/mozilla-mobile/fenix/pull/5161) 
See https://github.com/mozilla-mobile/fenix/pull/4442#issuecomment-528580904 for more info
 2019-09-09 11:08:30 -07:00
Petru Lingurar
37308af6b8 [fenix] Code cleanup - Remove unused FindInPageBarBehavior 
There is a "unused" lint suppression in place with the comment
"Referenced from XML". I found no such usage.
It's documentation says that this Behavior will always position FindInPageBar
above BrowserToolbar but the current code ensures
BrowserToolbar.visibility == GONE when FindInPageBar.visibility == VISIBLE
so there's no need for such behavior.
 2019-09-06 14:20:02 -04:00
Petru Lingurar
f911a3d485 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4856 - Refactor InflationAwareFeatureTest 
We previously had a test exactly for checking that "start does nothing" but we
now need to ensure that start actually is propagated to the inner feature that
is to rebind itself to the app to allow for user interactions.
 2019-09-06 14:20:02 -04:00
Petru Lingurar
c6f298f9fb [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/4856 - Propagate LifecycleAwareFeature's onStart() to the inner feature 
FindInPageFeature is used inside the app as a LifecycleAwareFeature and as such
it receives the onStart / onStop lifecycle calls.
The onStart() lifecycle call would not get passed to the feature but in
onStop() FindInPageFeature will detach it's Presenter and Interactor so when
the user comes back to the screen she could not interact anymore with the
feature.
To fix this we'll propagate LifecycleAwareFeature's onStart() to the inner
feature which is to rebind it's Presenter and Interactor in onStart().

This behavior is common to all the other features so all of them who implement
LifecycleAwareFeature will now get the onStart() call also.
 2019-09-06 14:20:02 -04:00
Mihai Adrian
3312a8c307 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4193 - Makes close button for tabs more accessible (https://github.com/mozilla-mobile/fenix/pull/4442) 
* fixes https://github.com/mozilla-mobile/fenix/issues/4193 - made close button for tabs more accessible.

set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button and text as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible

* Fix margins
 2019-09-06 10:33:55 -07:00
Sawyer Blatz
db43c5db32 [fenix] No issue: Removes unused nestedScrollQuickActionView (https://github.com/mozilla-mobile/fenix/pull/5143) 2019-09-06 09:03:24 -07:00
mihai-adrian
9d18725a8b [fenix] For https://github.com/mozilla-mobile/fenix/issues/5142 Removed RadioButton from accessibility keeping one option for Talkback 
Set android:importantForAccessibility = "no" for RadioButton
 2019-09-06 14:09:58 +02:00
Sawyer Blatz
88996e7f0c [fenix] For https://github.com/mozilla-mobile/fenix/issues/964: Adds ability to disable each suggestion provider (https://github.com/mozilla-mobile/fenix/pull/5096) 
* For https://github.com/mozilla-mobile/fenix/issues/964: Adds ability to disable each suggestion provider

* Fix nit
 2019-09-05 14:45:44 -07:00
Jonathan Almeida
5891296994 [fenix] No issue: Add logging for firebase/autopush 2019-09-05 16:03:36 -04:00
Emily Kager
470b943edd [fenix] For https://github.com/mozilla-mobile/fenix/issues/5033 - Update browsing mode when session selected (https://github.com/mozilla-mobile/fenix/pull/5118) 2019-09-05 14:27:30 -05:00
Richard Pappalardo
6a54b74c1e [fenix] Temporarily disable broken UI test (https://github.com/mozilla-mobile/fenix/pull/5136) 2019-09-05 10:22:14 -07:00
Alessio Placitelli
cf76cd9c62 [fenix] Enable Gecko metrics exfiltration through Glean (https://github.com/mozilla-mobile/fenix/pull/5126) 2019-09-05 11:58:35 -05:00
Emily Kager
16d1b63850 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5075 - Fix boolean error for private mode notification persistence (https://github.com/mozilla-mobile/fenix/pull/5120) 2019-09-05 09:21:56 -07:00
Sebastian Kaspari
fcee35b059 [fenix] Remove ThumbnailsFeature. (https://github.com/mozilla-mobile/fenix/pull/5127) 
We currently do not use thumbnails anywhere in the app. Not using the feature means we are
not taking thumbnails on every page load which means we are saving memory and CPU cycles.
 2019-09-05 11:05:37 -05:00
Grisha Kruglov
7cd0e2d290 [fenix] Fix breaking services APIs changes 2019-09-05 13:38:15 +02:00
Sebastian Kaspari
9fdfd82bc0 [fenix] Update to Mozilla Android Components 12.0.0-SNAPSHOT. 2019-09-05 13:38:15 +02:00
Sebastian Kaspari
1ad6f0ea20 [fenix] Add browser-state component. 2019-09-05 13:38:15 +02:00
Alessio Placitelli
0ab76faedb [fenix] Revert "Enable Gecko metrics exfiltration through Glean (https://github.com/mozilla-mobile/fenix/pull/5124)" (https://github.com/mozilla-mobile/fenix/pull/5125) 
This reverts commit ed9c9cffa8033784f9ab3c7391c177ab5b66cf1e.
 2019-09-05 04:26:46 -05:00
Alessio Placitelli
7d25624e16 [fenix] Enable Gecko metrics exfiltration through Glean (https://github.com/mozilla-mobile/fenix/pull/5124) 2019-09-05 04:17:28 -05:00
Emily Kager
a4172aafae [fenix] For https://github.com/mozilla-mobile/fenix/issues/5025 - Do not remove custom tab session with config removed 2019-09-05 10:57:37 +02:00
Sawyer Blatz
d0fa780907 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4155: Adds strings for long press popup (https://github.com/mozilla-mobile/fenix/pull/5112) 2019-09-04 17:15:06 -07:00
Emily Kager
dafda5ba3c [fenix] No issue: Land strings for delete browsing data on quit 2019-09-04 15:45:10 -07:00
Yeon Taek Jeong
e039e6a5ac [fenix] For https://github.com/mozilla-mobile/fenix/issues/419: Add strings for "Add private browsing shortcut" feature (https://github.com/mozilla-mobile/fenix/pull/5109) 2019-09-04 15:44:22 -07:00
Jeff Boek
51b7cc54cf [fenix] For i5047 - Adds strings for the add to homescreen dialog 2019-09-04 15:18:44 -07:00
Sawyer Blatz
5a5f46cb76 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5021: Adds metric for what's new button 2019-09-04 09:17:14 -07:00
Sawyer Blatz
da34c36d24 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4908: Adds metrics for send tab telemetry 2019-09-04 09:15:50 -07:00
mihai-adrian
d6883885e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5095: Changed search engine text color from default to ?primaryText 2019-09-04 07:57:17 -07:00
mihai-adrian
1329fdef70 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4892: Replaced straight single quote with curly apostrophe in contractions 2019-09-04 14:10:05 +02:00
Axel Hecht
2dfb11a83a [fenix] Import strings from android-l10n 
State: mozilla-l10n/android-l10n@6d2fe8331a
 2019-09-04 14:08:15 +02:00
Sawyer Blatz
e0e1bdba5c [fenix] For https://github.com/mozilla-mobile/fenix/issues/4474: Adds what's new button to home screen menu (https://github.com/mozilla-mobile/fenix/pull/5088) 
* For https://github.com/mozilla-mobile/fenix/issues/4474: Adds what's new button to home screen menu

* For https://github.com/mozilla-mobile/fenix/issues/4474: Adds tests for what's new button
 2019-09-03 15:16:29 -05:00
Petru Lingurar
8c4f0ecc02 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5067 - Refactor ShareControllerTest following the use of SendTabUseCases 2019-09-03 12:01:26 -07:00
Petru Lingurar
2f4392c064 [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/5067 - Refactor ShareController to use SendTabUseCases 
Navigation between app fragments uses ShareTab as arguments. The newly used
SendTabUseCases uses TabData which is not Parcelable.
For minimal changes we'll keep both data classes and ShareController will know
how to map between the two.
Removed the `sessionId` property of ShareTab as it isn't needed anymore.
 2019-09-03 12:01:26 -07:00
Sebastian Kaspari
98f0427ea2 [fenix] Fix ktlint MaxLineLength issues. 2019-09-03 10:09:06 -07:00
Sebastian Kaspari
d4849ca93e [fenix] Stores: Reduce visibility of reducer functions. 2019-09-03 10:09:06 -07:00
Sebastian Kaspari
ec29bdbc78 [fenix] Rename HistoryStore/State/Action to HistoryFragmentStore/State/Action. 2019-09-03 10:09:06 -07:00
Sebastian Kaspari
a682a16b25 [fenix] Rename AccountSettingsStore/State/Action to AccountSettingsFragmentStore/State/Action. 2019-09-03 10:09:06 -07:00
Sebastian Kaspari
0a46f6d16a [fenix] Rename SearchStore/State/Action to SearchFragmentStore/State/Action. 2019-09-03 10:09:06 -07:00
Sebastian Kaspari
5a3bfb2b77 [fenix] Rename ExceptionsStore/State/Action to ExceptionsFragmentStore/State/Action. 2019-09-03 10:09:06 -07:00
Sebastian Kaspari
52d15c5be7 [fenix] Rename BrowserStore/State/Action to BrowserFragmentStore/State/Action. 2019-09-03 10:09:06 -07:00
Sebastian Kaspari
c0b76b338f [fenix] Rename BookmarkStore/State/Action to BookmarkFragmentStore/State/Action. 2019-09-03 10:09:06 -07:00
mihai-adrian
309495f15a [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4997: Changed navigation to ShareFragment 
Changed test for new global navigation to share fragment.
 2019-09-03 07:08:08 -10:00
mihai-adrian
0f119aae4e [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4997: Changed navigation to ShareFragment 
Added global navigation action to share fragment in navigation graph
Changed share action to use global navigation to ShareFragment
 2019-09-03 07:08:08 -10:00
Sebastian Kaspari
61c2a0878f [fenix] Issue https://github.com/mozilla-mobile/fenix/pull/4907: Link to usage of sharedUserId in Fennec code. 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
720589cbb0 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873: Use manifest placeholder to inject sharedUserId. 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
7a554f2f4e [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873: Reuse sharedUserId from Fennec for fennecProduction build type. 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
9a01bb2639 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873: Use Fennec version code mechanism for fennecProduction build type. 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
b4b87eb165 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873: Only build fennecProduction build types with GeckoView Beta. 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
c91a28030f [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873: Reuse Firefox application id for fennecProduction build type. 2019-09-03 17:10:06 +02:00
Sebastian Kaspari
7061d22246 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873: Introduce "fennecProduction" build type. 2019-09-03 17:10:06 +02:00
Colin Lee
b5615b600d [fenix] For https://github.com/mozilla-mobile/fenix/issues/5055: Crash when opening bookmarks (https://github.com/mozilla-mobile/fenix/pull/5058) 2019-08-31 17:41:50 -05:00
Christian Sadilek
c1d104a193 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2088: Use new async API to load default search engine in HomeFragment 2019-08-30 17:56:18 -04:00
Sebastian Kaspari
6ac2509131 [fenix] Move creation of GeckoRuntime to flavor-specific source set. 
Since we are now able to build against GeckoView Nightly and GeckoView Beta,
we should create the GeckoRuntime from a flavor-specific source set.

Creating the runtime is not covered by the AC abstraction and so API changes
in GeckoView Nightly can break the build and leaves us with no option to fix
it from a shared code base. Separating the creation of GeckoRuntime
allows us to adapt individually and also to configure the runtimes
differently.
 2019-08-30 15:16:12 +02:00
Will Hawkins
2127d42c9d [fenix] Use new async API to load and access search engines 
Use the new asynchronous features of the search engine
manager from a-c to avoid the latency required to load
the default search engine.
 2019-08-29 18:16:02 -07:00
Mugurell
23f1395585 [fenix] For 4007 - Add unit tests for the Share Interactor, Controller and list Adapters 2019-08-29 18:12:50 -07:00
Mugurell
00a0d8db5e [fenix] For https://github.com/mozilla-mobile/fenix/issues/4007 - Add ShareController for handling ShareFragment's business logic 
`ShareController` defines a contract with all possible `ShareFragment`'s
behavior changes and comes with a default implementation -
`DefaultShareController`.
It is to be delegated by all `ShareFragment`s contained Views' Interactors
following any user interactions.
 2019-08-29 18:12:50 -07:00
Mugurell
051f09a15a [fenix] For https://github.com/mozilla-mobile/fenix/issues/4007 - ShareFragment will set the contained Views' state 
ShareFragment which acts as a container would contain all business logic needed
for populating it's Views.
Data initialization should be done only once since the app state has no reason
to change after the ShareFragment is created and is done as soon as possible,
in onAttach().
Because of the expected short lifespan of this fragment, given the fact that
the state has no reason to change and we handle orientation changes ourselves
to keep things simple I didn't use a ViewModel to persist the state.
 2019-08-29 18:12:50 -07:00
Mugurell
a8cbf8b1d8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4007 - Refactor AppShareView in standalone Share Views 
In an effort to respect the initial MVI architecture I've broken the
complex `AppShareView` in 3 separate Views
- `ShareCloseView`
- `ShareToAccountDevicesView`
- `ShareToAppsView`
They are standalone Views (extending LayoutContainer) which know nothing about
each other or their parent and so offer their container the possibility to
order or display them in any form later.
According to the lib-state contract they are only responsible to
- inflate themselves in their injected containerView
- render a certain state (to be added in later commits)
- delegate all user interaction to an associated Interactor
 2019-08-29 18:12:50 -07:00
Mugurell
4168f278f2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4007 - Use camelCase for views referenced from code 
As per https://github.com/mozilla-mobile/fenix/issues/4341.
Also reformatted layouts to have a more consistent style.
Also refactored `AppShareRecyclerView` and `AccountDevicesShareRecyclerView` by
defining their LayoutManager in XML to reduce code complexity.
 2019-08-29 18:12:50 -07:00
Tiger Oakes
09ca0c9e48 [fenix] Add comments to AuthCustomTabActivity 2019-08-29 15:06:34 -07:00
Sawyer Blatz
90a79b82f7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3892: Fixes help link on nightly (https://github.com/mozilla-mobile/fenix/pull/4956) 2019-08-29 13:27:50 -07:00
Mihai Adrian
d091cb2c1c [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4894: added workaround for SDK<24 vector drawable with gradient color (https://github.com/mozilla-mobile/fenix/pull/4944) 
Removed drawableStart and added ImageView in layouts
Set ImageView logo programmatically: bitmap for SDK<24, vector for SDK>=24
Added onClickPendingIntent for ImageView in large and medium layouts
 2019-08-29 12:55:51 -07:00
Tiger Oakes
e4abe9cace [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/773 - Add shortcuts to homescreen (https://github.com/mozilla-mobile/fenix/pull/4925) 2019-08-29 14:45:11 -05:00
Colin Lee
b472ab03be [fenix] For https://github.com/mozilla-mobile/fenix/issues/4064: Old R8 & keep rules are inhibiting optimizations (https://github.com/mozilla-mobile/fenix/pull/4930) 2019-08-29 10:16:26 -05:00
mihai-adrian
46aec58767 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/3602:navigate to top of home screen after tapping "start browsing" 
After onboarding.finish(), scrolled homeLayout to top
 2019-08-29 07:45:04 -07:00
Jonathan Almeida
d8489d7350 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4218: Remove forced registration renewal for push 2019-08-28 21:14:12 -04:00
Jonathan Almeida
818a6693f9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4063: Remove SendTab feature flags 2019-08-28 21:14:12 -04:00
Yeon Taek Jeong
b4fa37b231 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4658: Add some private browsing mode telemetry (https://github.com/mozilla-mobile/fenix/pull/4968) 2019-08-28 14:41:37 -07:00
Sawyer Blatz
0356d7c3ec [fenix] For https://github.com/mozilla-mobile/fenix/issues/4969: Removes erroneous FxA sign up ping (https://github.com/mozilla-mobile/fenix/pull/4970) 2019-08-28 14:32:43 -07:00
Yeon Taek Jeong
cc75c0df87 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2053: Add persistent notification to close all private browsing tabs (https://github.com/mozilla-mobile/fenix/pull/4913) 2019-08-28 12:55:24 -07:00
Sebastian Kaspari
a63606870c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4215: CustomTabActivity: Remove attached session if activity is finishing. (https://github.com/mozilla-mobile/fenix/pull/4985) 2019-08-28 11:03:04 -07:00
Emily Kager
6527ff2fcd [fenix] For https://github.com/mozilla-mobile/fenix/issues/4863 - Remove delay in HomeFragment onPreDraw 2019-08-28 13:48:14 -04:00
Suraj Shah
bde36a6d45 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4488: Shows snackbar on bookmark deletion from edit fragment (https://github.com/mozilla-mobile/fenix/pull/4792) 
* Fixes https://github.com/mozilla-mobile/fenix/issues/4488
Updates changelog

* Removes wildcard imports.

* Removes custom label in use, replaces with let
 2019-08-28 10:12:39 -07:00
Sebastian Kaspari
5db6464268 [fenix] Use Mozilla Android Components 10.0.1. 2019-08-28 15:31:25 +02:00
Jonathan Almeida
dec7d9a442 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4960: Initialize push only if available (https://github.com/mozilla-mobile/fenix/pull/4964) 2019-08-27 14:15:38 -07:00
Afzal Najam
e0f503fe0c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4718 - Update site permissions layout (https://github.com/mozilla-mobile/fenix/pull/4953) 2019-08-27 14:07:51 -07:00
Jeff Boek
03babccbf6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4063 - Always enable the push service (https://github.com/mozilla-mobile/fenix/pull/4932) 2019-08-27 13:12:29 -07:00
Tiger Oakes
6fa3cf4a26 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4771 - Add method for sessions of type (https://github.com/mozilla-mobile/fenix/pull/4782) 
Fixes share tabs to use the new method
 2019-08-27 13:04:03 -07:00
Emily Kager
d3cbb93b88 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4295 - Adds Experiments Pref to Data Collection Settings (https://github.com/mozilla-mobile/fenix/pull/4915) 2019-08-27 12:56:16 -07:00
Sebastian Kaspari
dc70e530cc [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4431: Enable feature-media component for all builds. (https://github.com/mozilla-mobile/fenix/pull/4898) 2019-08-27 12:51:27 -07:00
Mihai Adrian
1e2fdf5cae [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4211 changed SeekBar height to wrap_content to prevent misaligned dot (https://github.com/mozilla-mobile/fenix/pull/4832) 
Changed height from match_constrained to wrap_content.
 2019-08-27 12:50:00 -07:00
Emily Kager
018086c9ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/4921 - Adds WindowFeature to BaseBrowserFragment 2019-08-27 15:33:59 -04:00
Arturo Mejia
eb53d10047 [fenix] Fix safe browsing API breaking change. (https://github.com/mozilla-mobile/fenix/pull/4946) 2019-08-27 13:43:22 -05:00
Aaron Train
da02c6f228 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4926: Add basic UI test for regular/private tabs (https://github.com/mozilla-mobile/fenix/pull/4928) 2019-08-27 13:56:12 -04:00
Sourabh
d47dc7b29d [fenix] For https://github.com/mozilla-mobile/fenix/issues/4398 - add HistoryController (https://github.com/mozilla-mobile/fenix/pull/4837) 2019-08-27 10:33:40 -07:00
Mihai Adrian
c68c8a4374 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4440 changed padding for account_preference (https://github.com/mozilla-mobile/fenix/pull/4830) 
Changed padding to default value in @android:style/Preference.Material.Category.
Also changed paddingEnd value to default value.
 2019-08-27 10:26:32 -07:00
Amaan Marfatia
f42c71ccfe [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4067 besides snackbar (https://github.com/mozilla-mobile/fenix/pull/4777) 
* Fixes https://github.com/mozilla-mobile/fenix/issues/4067 besides snackbar

Makes layout hierarchy more shallow to increase performance.

* Fix https://github.com/mozilla-mobile/fenix/issues/4067 Feedback

Make sure quick_action_overlay appears on top and use horizontal chain in tab_header.
 2019-08-27 10:09:55 -07:00
Axel Hecht
118c704270 [fenix] Import strings from android-l10n 
State: mozilla-l10n/android-l10n@349efdbc8f
 2019-08-27 08:22:42 -07:00
Colin Lee
cdc611fec5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4885: D8 Build failure on attempt to execute UI test (https://github.com/mozilla-mobile/fenix/pull/4903) 
* For https://github.com/mozilla-mobile/fenix/issues/4885: D8 Build failure on attempt to execute UI test

* Disabled screengrab tests until AndroidX fix is available
 2019-08-23 13:37:52 -07:00
Tiger Oakes
df7dc6523c [fenix] Add custom tab fragment 2019-08-23 16:12:19 -04:00
ekager
eb3c357f61 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3967 - Invoke pending deletion on back pressed 2019-08-23 15:32:27 -04:00
ekager
2f11d83ca4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4868 - Update content description of tabs button with number of tabs 2019-08-23 09:21:32 -07:00
Grisha Kruglov
a9288459fa [fenix] No issue: only sync once on startup 2019-08-23 12:08:11 -04:00
Emily Kager
ea577bdf3a [fenix] For https://github.com/mozilla-mobile/fenix/issues/4779 : Don't double navigate with global directions in HomeActivity 2019-08-23 12:01:28 -04:00
Axel Hecht
86cd4a78ba [fenix] Import strings from android-l10n 
State: mozilla-l10n/android-l10n@90a28fd458
 2019-08-23 14:36:01 +02:00
Sebastian Kaspari
456cfb5bfb [fenix] Use version name/code override. (https://github.com/mozilla-mobile/fenix/pull/4895) 2019-08-23 07:08:37 -05:00
Emily Kager
c87829be14 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4652 : Use workaround for HomeScreenViewModel (https://github.com/mozilla-mobile/fenix/pull/4887) 2019-08-22 13:35:51 -05:00
Tiger Oakes
63814821eb [fenix] Extract intent processors from HomeActivity (https://github.com/mozilla-mobile/fenix/pull/4884) 2019-08-22 13:31:40 -05:00
Sebastian Kaspari
11a92537ce [fenix] Rename "nightly" source folder to "fenixNightly". 2019-08-22 19:46:40 +02:00
Tiger Oakes
b8695ca06b [fenix] Make Settings.instance private 2019-08-22 08:14:08 -07:00
Sebastian Kaspari
14e9fc85da [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4874: Use new build types in FeatureFlags class. 2019-08-22 08:12:49 -07:00
Emily Kager
11b37b2da0 [fenix] Adds experiments preferences strings 2019-08-21 19:55:26 -07:00
Emily Kager
494008a099 [fenix] No issue: Land strings for Delete Browsing Data on Quit 2019-08-21 19:55:26 -07:00
Colin Lee
bd400b8f53 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4064: Dispatchers.Main still has long cold start delay (Phase II) 2019-08-21 14:32:44 -07:00
Tiger Oakes
cf9ace2cc1 [fenix] Move classes out of top-level package 2019-08-21 13:52:30 -07:00
Richard Pappalardo
3e02efef28 [fenix] Stub out Settings tests 2019-08-21 13:52:03 -07:00
Jeff Boek
6ec0801d0c [fenix] For https://github.com/mozilla-mobile/fenix/issues/4326 - Updates codebase to support latest version of detekt 2019-08-21 13:50:51 -07:00
Jeff Boek
40ae66fdbb [fenix] For https://github.com/mozilla-mobile/fenix/issues/4326 - Updates codebase to support latest version of ktlint 2019-08-21 13:50:51 -07:00
Emily Kager
51d4956148 [fenix] No issue: Land new string for delete browsing data prompt (https://github.com/mozilla-mobile/fenix/pull/4859) 2019-08-21 11:17:34 -07:00
Colin Lee
f187762a78 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3869: Switch to A-C SearchLocalizationProvider (https://github.com/mozilla-mobile/fenix/pull/4858) 
* For https://github.com/mozilla-mobile/fenix/issues/3869: Switch to A-C SearchLocalizationProvider

* Fix test
 2019-08-21 11:14:59 -07:00
Nick Alexander
dbb115a551 [fenix] Consume new substitute-local-geckoview.gradle script from Bug 1533465. 2019-08-21 19:52:01 +02:00
Mihai Adrian
71229cdddd [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4795 fixed requestDesktopStateProvider value from private to desktopMode (https://github.com/mozilla-mobile/fenix/pull/4810) 
RequestDesktopStateProvider was taken from private instead of desktopMode
 2019-08-21 09:10:06 -07:00
Sourabh
c50d08d405 [fenix] add tests for DefaultQuickActionSheetController (https://github.com/mozilla-mobile/fenix/pull/4835) 2019-08-21 08:52:01 -07:00
Tiger Oakes
9e9246ada3 [fenix] No issue: Clean up preferences code (https://github.com/mozilla-mobile/fenix/pull/4699) 2019-08-21 08:38:14 -07:00
Emily Kager
409cea2128 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3967 - Invokes pending deletion with more bookmark actions (https://github.com/mozilla-mobile/fenix/pull/4522) 2019-08-21 08:36:41 -07:00
Mitchell Hentges
e7ca5257b4 [fenix] Configure either geckoview beta or nightly at compile-time (https://github.com/mozilla-mobile/fenix/pull/4851) 
* Remove "abi" product flavor and introduce "engine" product flavor.

This patch will allow us to build Fenix against GeckoView Nightly and GeckoView Beta by
introducing a new flavor dimension: engine = [geckoNightly, geckoBeta].

In addition to that it adds a "fenix"  prefix to the nightly, beta and production flavors
to reduce the ambiguity between fenix beta/nightly and GeckoView beta/nightly.

For now the build types have the following engine variants enabled:

**debug**: geckoNightly, geckoBeta
Both variants enabled for local development and testing.

**forPerformanceTest**: geckoNightly, geckoBeta
Both variants enabled unless the perf team only cares about Nightly (tbd)

**fenixNightlyLegacy**: geckoBeta
Uses GeckoView Beta for now - the same version we ship production builds with (same behavior
as before). This release type will eventualyl be decommissioned once we switch to a separate
Nightly app on Google Play.

**fenixNightly**: geckoBeta
Uses GeckoView Beta for now - the same version we ship production builds with (same behavior
as before). Changing this build to use GeckoView Nightly is currently being discussed.

**fenixBeta**: geckoBeta
Fenix Beta uses GeckoView Beta.

**fenixProduction**
Fenix Production uses GeckoView Beta (69) currently.

* gradle.py/variant.py: Replace "abi" with "engine".

* Disable enableUnitTestBinaryResources until we can switch to Android Gradle plugin 3.5.

* Fenix nightly should use both geckoview nightly and beta

* Updates automation to use apk splitting and support different engine
 2019-08-21 08:32:01 -07:00
Jonathan Almeida
584103cdf6 [fenix] Use Mozilla Android Components 10.0.0 2019-08-21 10:06:05 -04:00
Emily Kager
528b8e0d5f [fenix] No issue: Land new strings for ETP and delete browsing data 2019-08-21 10:59:12 +02:00
Yeon Taek Jeong
410bb482b1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2834: Add contentDescription to tabs button icons 2019-08-20 16:34:05 -07:00
Emily Kager
1d3eec6208 [fenix] No issue: Don't show session provider in private mode 2019-08-20 16:09:55 -07:00
Yeon Taek Jeong
86ec7d5d6c [fenix] For https://github.com/mozilla-mobile/fenix/issues/2834: Delete all Private Tabs redesign (https://github.com/mozilla-mobile/fenix/pull/4787) 2019-08-20 13:10:08 -07:00
(´⌣`ʃƪ)
da54bdfe63 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4436: Dismiss onboarding before navigating away from home (https://github.com/mozilla-mobile/fenix/pull/4801) 2019-08-20 10:56:28 -07:00
Tiger Oakes
9882aa6a50 [fenix] Adds setters and property delegates in Settings (https://github.com/mozilla-mobile/fenix/pull/4809) 
* Change Settings to use setters

* Add delegate for shared preferences
 2019-08-20 10:47:55 -07:00
Tiger Oakes
7780821922 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2690 - Clean up CreateCollection viewmodel (https://github.com/mozilla-mobile/fenix/pull/4731) 2019-08-20 10:45:41 -07:00
Tiger Oakes
2fb1bd0283 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4774 - Use vector drawable compat (https://github.com/mozilla-mobile/fenix/pull/4811) 2019-08-20 10:43:02 -07:00
Tiger Oakes
500d557828 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4744 - Extract private browsing button (https://github.com/mozilla-mobile/fenix/pull/4813) 2019-08-20 10:41:18 -07:00
Tiger Oakes
d5e5b73485 [fenix] Color the system bars in custom tabs (https://github.com/mozilla-mobile/fenix/pull/4819) 2019-08-20 10:13:01 -07:00
Tiger Oakes
efe2e2e466 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/1000 - Remove isCustomTab flag (https://github.com/mozilla-mobile/fenix/pull/4656) 2019-08-20 10:00:49 -07:00
Sourabh
0e376bb266 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4399: Create LibState Controller for Search (https://github.com/mozilla-mobile/fenix/pull/4673) 
* For https://github.com/mozilla-mobile/fenix/issues/4399: Create LibState Controller for Search

* fix code format

* add unit tests for DefaultSearchController

* add more test

* fix unit tests
 2019-08-20 09:07:00 -07:00
Mugurell
2634b6dee4 [fenix] For 4827 - Remove TransitionPreDrawListenerTest pending tests refactoring 
New tests for `FragmentPreDrawManager` are to be added in https://github.com/mozilla-mobile/fenix/issues/4828
 2019-08-20 13:45:55 +02:00
Mugurell
fa2abeffe9 [fenix] Fix 4827 - Use ktx doOnPreDraw() to restore HomeFragment's layout 
The previous solution would result in a crash because the passed in
viewTreeObserver that would trigger onPreDraw would be invalid.
The proposed solution is simpler and ensures we'll always use the right
viewTreeObserver.

`FragmentPreDrawManager` is general enough that can be used by other Fragments
also, so I've added it to the `utils` package.
 2019-08-20 13:45:55 +02:00
Emily Kager
9431f611d5 [fenix] Update strings.xml 
Remove space in placeholder for es (temp for release)
 2019-08-19 19:14:22 -07:00
Axel Hecht
7d5d5b7afd [fenix] Import strings from android-l10n 
State: mozilla-l10n/android-l10n@413e05dba4
 2019-08-19 19:14:22 -07:00
Tiger Oakes
1c389d1231 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4744 - Extract TransitionPreDrawListener (https://github.com/mozilla-mobile/fenix/pull/4812) 2019-08-19 16:27:43 -07:00
Tiger Oakes
774d696c92 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4744 - Move search bar icon padding to dimens (https://github.com/mozilla-mobile/fenix/pull/4814) 2019-08-19 16:22:51 -07:00
Emily Kager
0268034e79 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4822 - Update Bookmark State in onResume (https://github.com/mozilla-mobile/fenix/pull/4823) 2019-08-19 16:22:20 -07:00
Mihai Adrian
8a1829b484 [fenix] fixes https://github.com/mozilla-mobile/fenix/issues/4179 removed control highlight from disconnect button (https://github.com/mozilla-mobile/fenix/pull/4806) 
set colorControlHighlight to transparent in activity theme.
property cannot be set in view because it is overwritten by activity theme.
 2019-08-19 16:16:06 -07:00
Sawyer Blatz
1c995d36e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2706: Refactor Glean to reduce errors (https://github.com/mozilla-mobile/fenix/pull/4753) 
* For https://github.com/mozilla-mobile/fenix/issues/2706: Adds recording for untracked events

* For https://github.com/mozilla-mobile/fenix/issues/2706: Adds key alignment to Metrics
 2019-08-19 15:25:48 -07:00
Sawyer Blatz
46eaca2871 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4421: Fixes issues with new glean events (https://github.com/mozilla-mobile/fenix/pull/4816) 2019-08-19 14:49:48 -07:00
Sawyer Blatz
ea193a5472 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4804: Resolves issue with crash reporter stack 2019-08-19 16:40:41 -04:00
Aaron Train
aa9bf1aa6e [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4618 - Stub Library UI tests (https://github.com/mozilla-mobile/fenix/pull/4619) 
See https://github.com/mozilla-mobile/fenix/issues/4572
 2019-08-19 14:05:10 -04:00
Arturo Mejia
7f746f6f17 [fenix] Use Mozilla Android Components 9.0.0-SNAPSHOT. (https://github.com/mozilla-mobile/fenix/pull/4750) 2019-08-19 10:29:10 -07:00
Suraj Shah
f3a412e24e [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4704 (https://github.com/mozilla-mobile/fenix/pull/4728) 
* Fixes https://github.com/mozilla-mobile/fenix/issues/4704. Overrides `setEnabled` for DeleteBrowsingDataItem to change view alpha when disabled and to toggle the checkbox `isEnabled` behavior based on the value provided.

* Updates CHANGELOG.md

* Removes unnecessary disabling of checkbox in DeleteBrowsingDataItem.kt
Updates CHANGELOG.md to reflect the component changed.
 2019-08-19 09:23:12 -07:00
Mugurell
43e4bcc0b1 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4396 - Add a Bookmarks Controller (https://github.com/mozilla-mobile/fenix/pull/4593) 
* For https://github.com/mozilla-mobile/fenix/issues/4396 - Rename BookmarkInteractor methods

Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.

Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.

* For https://github.com/mozilla-mobile/fenix/issues/4396 - Add a BookmarkController

It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.

This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.

* For https://github.com/mozilla-mobile/fenix/issues/4396 - Refactored Bookmark related tests

Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`

Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
 2019-08-19 08:34:57 -07:00
Tiger Oakes
84349bda63 [fenix] Extract quick action sheet observer code (https://github.com/mozilla-mobile/fenix/pull/4368) 2019-08-19 08:28:33 -07:00
Emily Kager
80b2c4ee51 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4799 https://github.com/mozilla-mobile/fenix/issues/4790 - Don't use passed in sessions in BrowserToolbarController (https://github.com/mozilla-mobile/fenix/pull/4800) 2019-08-18 20:36:40 -05:00
Colin Lee
47bbb9081d [fenix] For https://github.com/mozilla-mobile/fenix/issues/4686: Fix potential security issue (https://github.com/mozilla-mobile/fenix/pull/4764) 2019-08-16 16:50:54 -05:00
Yeon Taek Jeong
d72c8cf1b6 [fenix] No issue: fixes click failures on search widget icon 2019-08-16 13:58:29 -07:00
Emily Kager
043f8829c9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4688 - Try to use context instead of targetContext (https://github.com/mozilla-mobile/fenix/pull/4765) 2019-08-16 10:12:56 -07:00
Yeon Taek Jeong
b1fdb6a353 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4736: Display search shortcuts only from home or search widget 2019-08-15 12:24:54 -04:00
Emily Kager
52ff9a61f0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4688 - Try slightly different Context class for MockWebServer (https://github.com/mozilla-mobile/fenix/pull/4747) 2019-08-15 08:05:23 -07:00
Emily Kager
b037ddee5a [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4680 - Align collection creation text center vertical 2019-08-14 20:17:01 -04:00
Yeon Taek Jeong
6c41d30fd8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4384: Hide mic icon if speech-to-text is unavailable (https://github.com/mozilla-mobile/fenix/pull/4701) 2019-08-14 16:40:21 -07:00
Yeon Taek Jeong
8efb7f9cdb [fenix] For https://github.com/mozilla-mobile/fenix/issues/4516: Use full width for large search widgets (https://github.com/mozilla-mobile/fenix/pull/4659) 2019-08-14 16:00:13 -07:00
Emily Kager
e4f3b39e0b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/3860 - Update description text for collections 2019-08-14 17:13:52 -04:00
Sawyer Blatz
6cfbb2c02b [fenix] For https://github.com/mozilla-mobile/fenix/issues/4421: Adds Leanplum events and attributes (https://github.com/mozilla-mobile/fenix/pull/4626) 
* For https://github.com/mozilla-mobile/fenix/issues/4421: Adds Leanplum events and attributes

* For https://github.com/mozilla-mobile/fenix/issues/4421: Adds Leanplum deep links
 2019-08-14 13:48:45 -07:00
Yeon Taek Jeong
309b86544c [fenix] For https://github.com/mozilla-mobile/fenix/issues/4421: Add search widget attribute to Leanplum (https://github.com/mozilla-mobile/fenix/pull/4694) 2019-08-14 12:00:29 -07:00
Yeon Taek Jeong
468c400ff5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4457: Adds telemetry for search widget actions (https://github.com/mozilla-mobile/fenix/pull/4714) 2019-08-14 11:39:54 -07:00
Yeon Taek Jeong
2c70a18a62 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4732: Fix search engine display issue (https://github.com/mozilla-mobile/fenix/pull/4735) 2019-08-14 11:03:14 -07:00
Mihai Adrian
4835dbb1a8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4434 - made close button for collections more accessible. (https://github.com/mozilla-mobile/fenix/pull/4443) 
* fixes https://github.com/mozilla-mobile/fenix/issues/4434 - made close button for collections more accessible.

set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
implemented same visual solution as for https://github.com/mozilla-mobile/fenix/issues/4193 - close button for tabs

* fixes https://github.com/mozilla-mobile/fenix/issues/4434 - made buttons for collection home list row more accessible and aligned 3 dot menu with individual tabs close button

set buttons sizes to recommended minimum size for accessibility 48x48, while keeping image size the same
removed margins from buttons as they were not needed anymore
aligned center of menu buttons with center of collection icon
constrained description top to bottom of title, instead of share button to reduce empty space. (overlap with share button is already prevented by end constraint of description)
 2019-08-14 10:12:39 -07:00
Michael Cooper
9646181343 [fenix] Add no-op experiment to test service-experiments integration (https://github.com/mozilla-mobile/fenix/pull/4551) 
* Add no-op experiment to test service-experiments integration

* Shorten metric name to meet schema

* Add active_experiment metric to docs

* Add approved data review
 2019-08-14 12:07:41 -05:00
Tiger Oakes
07eda357ba [fenix] Use global navigation action for browser fragment (https://github.com/mozilla-mobile/fenix/pull/4691) 2019-08-14 11:58:29 -05:00
isabelrios
61e400c2d8 [fenix] Fix UI Screenshot TabMenuTest (https://github.com/mozilla-mobile/fenix/pull/4730) 2019-08-14 11:57:36 -05:00
Colin Lee
4987c40d67 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1667: Screen reader can't reach other UI items when QAB expanded (https://github.com/mozilla-mobile/fenix/pull/4695) 2019-08-14 09:56:29 -07:00
Emily Kager
bf76cbe7e6 [fenix] No issue - Autoformatting (https://github.com/mozilla-mobile/fenix/pull/4715) 2019-08-14 09:40:46 -05:00
Sebastian Kaspari
c30700580c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4719: Get rid of fragment-testing dependency and create fragments in StoreProviderTest manually. (https://github.com/mozilla-mobile/fenix/pull/4722) 2019-08-14 09:10:24 -05:00
Colin Lee
2de56210e2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4709: Fix Bugzilla issue 1573549 (https://github.com/mozilla-mobile/fenix/pull/4710) 2019-08-13 22:16:23 -05:00
Sourabh
9c7caab6e3 [fenix] fix https://github.com/mozilla-mobile/fenix/issues/4633: show toast only on first login (https://github.com/mozilla-mobile/fenix/pull/4676) 
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
 2019-08-13 16:28:34 -05:00
(´⌣`ʃƪ)
f292286006 [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/4436: hide onboarding before navigating to settings (https://github.com/mozilla-mobile/fenix/pull/4675) 
* Fix https://github.com/mozilla-mobile/fenix/issues/4436: hide onboarding before navigating to settings

* No issue: Rename emitAccountChanges to emitModeChanges
 2019-08-13 15:49:42 -05:00
Sebastian Kaspari
4cba063e4e [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4431: Integrate feature-media component (Nightly and debug builds only). (https://github.com/mozilla-mobile/fenix/pull/4683) 2019-08-13 15:02:20 -05:00
Colin Lee
de2b2a74c9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4652: HomeFragment Crash "Can not.. after onSaveInstanceState" 2019-08-12 15:51:49 -04:00
Jorge De Los Santos
3cfa2aff96 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3424 - Make talkback ignore ImageButton in Collection Sele… (https://github.com/mozilla-mobile/fenix/pull/3792) 
For https://github.com/mozilla-mobile/fenix/issues/3424 - Make talkback ignore ImageButton in Collection Selection by removing contentDescription and setting importantForAccessibility=no
 2019-08-12 11:49:25 -04:00
Grisha Kruglov
caeb3477b9 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4671: Fix a potential NPE in BookmarkFragment 2019-08-12 11:16:28 -04:00
Grisha Kruglov
cd52df3314 [fenix] No issue: add some BookmarkFragmentInteractor tests 2019-08-09 17:27:58 -07:00
Grisha Kruglov
88db14a22f [fenix] No issue: reduce code duplication in BookmarkFragmentInteractor 2019-08-09 17:27:58 -07:00
Christian Sadilek
9b956a3c42 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4125: Suppress coroutine warning to fix release build 2019-08-09 17:30:27 -04:00
Sawyer Blatz
20b0c30640 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4123: Adds telemetry for quick action open in app (https://github.com/mozilla-mobile/fenix/pull/4629) 2019-08-09 13:51:12 -07:00
Yeon Taek Jeong
ae90650052 [fenix] ktlint fix 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
b050218cd6 [fenix] Finish adding tests 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
6517ffed64 [fenix] Fix, add some tests 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
b190e9b80d [fenix] Fix rest of issues 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
b3ef78f3cc [fenix] Fix most issues 2019-08-09 13:39:51 -07:00
Yeon Taek Jeong
8391e933be [fenix] For https://github.com/mozilla-mobile/fenix/issues/4125: Migrate Sign in to Sync to Libstate 2019-08-09 13:39:51 -07:00
Axel Hecht
059ee1671d [fenix] Import strings from android-l10n (https://github.com/mozilla-mobile/fenix/pull/4643) 
State: mozilla-l10n/android-l10n@ab580f757c
 2019-08-09 14:55:05 -05:00
Colin Lee
9124321227 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4652: Crash "Can not perform this action after onSaveInstanceState" (https://github.com/mozilla-mobile/fenix/pull/4654) 2019-08-09 14:46:40 -05:00
Jonathan Almeida
d544526692 [fenix] No issue: Disable failing ActivationPingTest 2019-08-09 15:22:38 -04:00
Tiger Oakes
025fc336b1 [fenix] Consodilate private browsing code 2019-08-09 11:00:41 -07:00
Jonathan Almeida
d3ff33d2d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4066: Create InflationAwareFeature for lazy inflation 2019-08-09 11:48:55 -04:00
Colin Lee
45ec0682f5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4066: Provide lazy inflation of Find In Page View 2019-08-09 11:48:55 -04:00
Sawyer Blatz
e4488b1909 [fenix] No issue: Removes deprecated usage of InstrumentationRegistry 2019-08-08 17:35:13 -07:00
Colin Lee
952926509c [fenix] For https://github.com/mozilla-mobile/fenix/issues/4507 Enable codecov (https://github.com/mozilla-mobile/fenix/pull/4520) 2019-08-08 19:09:54 -05:00
Colin Lee
1d4952ddf1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4529: Handle crash initializing CreateCollectionViewModel late (https://github.com/mozilla-mobile/fenix/pull/4628) 2019-08-08 17:40:55 -05:00
ValentinTimisica
9ce027a0a4 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4323: Modified UI of component_collection_creation. 
To fix the overlapping issue I used Guideline and
layout_constraintWidth_default property. I also used the
layout_constraintHorizontal_bias property to make the back_button to
lean to the left and the select_all_button to lean to the right.
 2019-08-08 12:57:19 -07:00
Christian Sadilek
27b574d548 [fenix] Suppress warning in LeanplumMetricsService to fix release builds 2019-08-08 15:17:12 -04:00
Emily Kager
527b52ed71 [fenix] No issue: Update testing dependencies 2019-08-08 11:37:16 -07:00
Mathieu Leplatre
edc8182698 [fenix] Fix https://github.com/mozilla-mobile/fenix/issues/4612: Fetch experiments from Remote Settings CDN 2019-08-08 10:15:01 -07:00