Mihai Adrian
ab0bc61cb3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6997 Avoid overwriting empty_search_string error ( https://github.com/mozilla-mobile/fenix/pull/6998 )
...
Setting error twice also clips error message
2019-12-09 18:10:24 -08:00
Emily Kager
69f92da9cb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6922 - Check current destination is logins fragment before navigation ( https://github.com/mozilla-mobile/fenix/pull/6924 )
2019-12-09 15:42:40 -08:00
Michael Comella
ed87207990
[fenix] For perf-frontend-issues https://github.com/mozilla-mobile/fenix/pull/33 : Clarify VERBOSE logging motivation.
2019-12-09 15:11:52 -08:00
Michael Comella
3b36ea34c8
[fenix] For perf-frontend-issues https://github.com/mozilla-mobile/fenix/pull/33 : Add HotStartPerformanceMonitorTest.
...
We really don't want our startup tests to subtlely change so I thought
it was worth writing some quick tests.
2019-12-09 15:11:52 -08:00
Michael Comella
bde17a6a4e
[fenix] For perf-frontend-issues https://github.com/mozilla-mobile/fenix/pull/33 : Add HotStartPerformanceMonitor.
...
As mentioned in the class comment, we could use an alternative
implementation to measure perf from outside the application however
it's more complicated to set up and less consistent with our cold
startup methodology so we'll start with this.
2019-12-09 15:11:52 -08:00
ekager
7f5cac63f1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5771 - Don't force landscape mode on fullscreen
2019-12-09 23:47:57 +01:00
mcarare
35eeb98cac
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4107 Make home screen fullscreen.
...
Add/Remove fullscreen flags in home fragment's onResume / onPause
Change homeLayout padding to include system bars height (status&navigation).
Change homeMenu orientation to UP to properly display menu.
Change home bottomBar background to transparent.
2019-12-09 23:45:02 +01:00
mcarare
d49503e58e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7026 Dispatch ModeChange on hideOnboarding
2019-12-09 23:44:33 +01:00
ekager
058da9bf17
[fenix] No issue: Remove unnecessary back slashes from curly apostrophe strings
2019-12-09 23:16:00 +01:00
Grisha Kruglov
46bf7f45f9
[fenix] Fennec migration: enable logins migration
2019-12-09 13:35:22 -08:00
Jeff Boek
e0b335ed68
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1607 - Passes "custom" as the search engine identifier for custom engines
2019-12-09 11:47:05 -08:00
Severin Rudie
f838367e84
[fenix] No issue: small installedSearchEngineIdentifiers readability refactor
2019-12-09 10:58:19 -08:00
Severin Rudie
013aac2604
[fenix] No issue: tests installedSearchEngineIdentifiers
2019-12-09 10:58:19 -08:00
Severin Rudie
a6bb6ad9ca
[fenix] No issue: begin moving FenixSearchEngineProvider into a testing harness
2019-12-09 10:58:19 -08:00
Oana Horvath
4e1bb19dc0
[fenix] Fixed flaky History UI tests by adding an extra verification step that ( https://github.com/mozilla-mobile/fenix/pull/6894 )
...
the page is loaded.
Enabled all tests
2019-12-09 11:52:55 +02:00
Aaron Train
4cf0c56803
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6873 : Support many more Content-Type in MockWebServer (UI tests) ( https://github.com/mozilla-mobile/fenix/pull/7001 )
...
Ensure our MockResponse can handle different Content-Type e.g, images, to help support other tests
2019-12-06 14:53:18 -05:00
Severin Rudie
53b4d6714e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5334 : added private custom tab processor ( https://github.com/mozilla-mobile/fenix/pull/6845 )
...
* For https://github.com/mozilla-mobile/fenix/issues/5334 : added private custom tab processor
* For https://github.com/mozilla-mobile/fenix/issues/5334 - Fixes up IntentReceiverActivity for handling intents
* For 5334: update styling for private custom tabbs
* For 5334: update tests to account for new processors
Note that two are still failing. These appear to be true failures, and will be corrected in a later commit.
* For 5334: fixes bug introduced by changes to IntentReceiverActivity
RCA: intent className and extra were previously set based on which processors matched, not which successfully processed. This patch reintroduces that behavior.
* For 5334: add tests for custom tabs processing
2019-12-06 10:57:54 -08:00
Jeff Boek
fa903dd097
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4664 - Updates search_with string. ( https://github.com/mozilla-mobile/fenix/pull/6909 )
2019-12-06 10:36:19 -08:00
Mozilla L10n Automation Bot
8671faa0f6
[fenix] Import l10n.
2019-12-06 08:53:22 -08:00
kglazko
50b8f92201
[fenix] Issue 5366 Vector Drawable Compat ( https://github.com/mozilla-mobile/fenix/pull/6904 )
2019-12-05 19:54:32 -08:00
Richard Pappalardo
101f6a1770
[fenix] Disable flaky testDownloadNotification - API28 ( https://github.com/mozilla-mobile/fenix/pull/6982 )
2019-12-05 18:00:21 -08:00
Mihai Adrian
208d0c684b
[fenix] Temporarily fix lint issues with bad translation of string ( https://github.com/mozilla-mobile/fenix/pull/6963 )
2019-12-05 13:57:57 -08:00
mcarare
4a29b6b06b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6917 Emit mode change only when new mode is different from current
2019-12-05 11:10:14 -08:00
Mihai Adrian
b36189b3b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6910 Align shortcuts in private onboarding panel style to… ( https://github.com/mozilla-mobile/fenix/pull/6950 )
...
Divider only shows when both panel and "Search with" are visible
2019-12-05 09:37:20 -08:00
Mihai Adrian
a4be691ea0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6943 Hide supportActionBar in onResume, not onCreate ( https://github.com/mozilla-mobile/fenix/pull/6978 )
2019-12-05 09:36:39 -08:00
Mozilla L10n Automation Bot
4d9a90f293
[fenix] Import l10n.
2019-12-04 19:59:25 -08:00
Gabriel
9ed4f7f119
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5574 - Migrate SessionControl to LibState ( https://github.com/mozilla-mobile/fenix/pull/6651 )
...
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 1: Port TabAction.SaveTabGroup to TabSessionInteractor and SessionControlController. (https://github.com/mozilla-mobile/fenix/pull/6651 )
- Introduces the TabSessionInteractor, SessionControlInteractor and SessionControlController classes.
- Removes the TabAction.SaveTabGroup.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 2: Port TabAction.PrivateBrowsingLearnMore to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 3: Port TabAction.ShareTabs to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 4: Remove unused TabAction.Share and TabItemMenu (https://github.com/mozilla-mobile/fenix/pull/6651 )
In https://github.com/mozilla-mobile/fenix/issues/2205 , the tab overflow button was removed which would have shown the
TabItemMenu when clicked. So, we can remove TabItemMenu since it is not
used and as a result, we can also remove TabAction.Share since there are
no consumers.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 5: Port TabAction.PlayMedia and TabAction.PauseMedia to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 6: Port TabAction.Select to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 7: Port Onboarding.Finish to OnboardingInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 8: Port TabAction.Close and TabAction.CloseAll to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
- Removes TabAction
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 9: Port CollectionAction.Delete to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 10: Port CollectionAction.ShareTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 11: Port CollectionAction.AddTab and CollectionAction.Rename to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 12: Port CollectionAction.RemoveTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 13: Port CollectionAction.OpenTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 14: Port CollectionAction.CloseTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 15: Introduce a HomeFragmentStore (https://github.com/mozilla-mobile/fenix/pull/6651 )
- We will hook up the HomeFragmentStore in later parts.
- Removes List<Tab>.toSessionBundle(context: Context) since it is unused.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 16: Port CollectionAction.Collapse and CollectionAction.Expand to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
- We assume the store is hooked up to the SessionControlController in this part,
but this work will be done in a later part.
- Removes CollectionAction.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 20: Remove the architecture module. (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 17: Remove duplicate subscribeToTabCollections in BrowserFragment.kt (https://github.com/mozilla-mobile/fenix/pull/6651 )
There is a duplicate call of subscribeToTabCollections() in both HomeFragment and BrowserFragment.
In this patch, we remove the call in BrowserFragment to avoid passing the HomeFragmentStore to
BrowserFragment in order to dispatch the CollectionsChange event.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 18: Delete SessionControlComponent and fix TabCollection and Tab imports (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 19: Use the new HomeFragmentStore in the HomeFragment (https://github.com/mozilla-mobile/fenix/pull/6651 )
- Renames SessionControlUIView to SessionControlView
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 21: Fix white screen on home fragment (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 22: Fix formatting in SessionControlInteractor and replace See with @see in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 23: Move to metrics.track call to the beginning of handleCollectionRemoveTab (https://github.com/mozilla-mobile/fenix/pull/6651 )
This ensures that the metrics.track will be called immediately before the tab is removed from the collection.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 24: Use the sessionManager getter in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 25: Use mapNotNull in List<Tab>.toSessionBundle (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 26: Simplify closeTab and closeAllTabs functions by assigning a deletionJob constant (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 27: Replace listOf() with emptyList() in removeAllTabsWithUndo (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 28: Replace the Context parameter with the HomeActivity in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 29: Add test for HomeFragmentStore, DefaultSessionControlController and SessionControlInteractor (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Removes running CI against the architecture debug build varient
2019-12-04 22:06:05 -05:00
Jeff Boek
58bdd912e6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6855 - Filter out duplicated bundled search engines
...
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 17:10:02 -08:00
mcarare
7a289d1eb1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6070 Adds telemetry for enabling search suggestions in private
2019-12-04 16:44:01 -08:00
Jeff Boek
e6709a82d7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6849 - Properly select a new default search engine when you delete the current one
...
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 16:10:26 -08:00
Jeff Boek
4e988fce7b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6848 - Sorts the search engine list without case sensitivity
...
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 16:10:26 -08:00
Jeff Boek
e51c588fd7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6847 - Properly rebuilds the SearchEngineList on undo
...
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 16:10:26 -08:00
Emily Kager
4ce302d29f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6908 - Set null anchors for snackbars with top toolbar ( https://github.com/mozilla-mobile/fenix/pull/6911 )
2019-12-04 15:01:04 -08:00
Jeff Boek
7f7685689f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6795 - Auto shows toolbar when loading a new URL ( https://github.com/mozilla-mobile/fenix/pull/6955 )
...
Co-authored-by: Severin <Baron-Severin@users.noreply.github.com>
2019-12-04 15:00:51 -08:00
Sebastian Kaspari
ad503a83c1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4976 : Reuse Fennec launcher entry in manifest.
...
With this patch Fennec users, who upgrade to Fenix, will not lose Firefox launcher icons they
have added to their home screen.
A side effect of this change is that the launcher entry for existing Fenix users may disappear
from the home screen for existing Firefox Preview users and they will have to re-add it.
Since the Preview audience is more accepting of breaking changes and since that group is
way smaller than the millions of Fennec users, I think that this is an acceptable breaking
change. I looked into supporting multiple launcher entries in parallel, but that got quite
complex with multiple build types and multiple manifest files. Especially if we decide
to keep a Firefox Preview build around (e.g. org.mozilla.fenix) then it would be good to
unify on a single launcher and do that as early as possible.
2019-12-04 12:51:48 -08:00
Oana Horvath
0cb634facc
[fenix] Added multi-selection tests for bookmarks ( https://github.com/mozilla-mobile/fenix/pull/6475 )
...
Updated bookmarking method
Fixed flaky tests
Added wait to create bookmark
2019-12-03 12:44:54 +02:00
mawen7
bbfa8aadd4
[fenix] Run lint for app module and set baseline
2019-12-02 14:45:34 -08:00
Aaron Train
0e77c47f42
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6363 - Add Downloads UI tests ( https://github.com/mozilla-mobile/fenix/pull/6574 )
...
- Initiates a download
- Verifies prompt
- Verifies notification in notification shade
2019-12-02 17:15:00 -05:00
ekager
333ff28126
[fenix] No issue: Fix search suggestions strings
2019-12-02 21:39:10 +00:00
ekager
c09e977ff7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6791 - Inflate SavedLoginsListItemViewHolder layout explicitly
2019-12-02 10:40:58 -08:00
ekager
4f0bcac5b8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6889 - Check current destination before navigating from settings
2019-12-02 10:40:21 -08:00
ekager
41af91db69
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6890 - Don't crash with no connection when adding custom search engine
2019-12-02 10:37:31 -08:00
Severin Rudie
312a66c20e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5540 : updates error page copy when no internet is available ( https://github.com/mozilla-mobile/fenix/pull/6803 )
2019-12-02 10:26:06 -08:00
cesar
8a51b43fbc
[fenix] test fixed
2019-12-02 16:18:48 +00:00
cesar
9b868c1e0b
[fenix] nested loop removed
2019-12-02 16:18:48 +00:00
cesar
51fe91d723
[fenix] klint clean up and previous nit fixed
2019-12-02 16:18:48 +00:00
cesar
cc1bfd730b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6731 - fixed BookmarkNode minus operator and deleteOperation
2019-12-02 16:18:48 +00:00
cesar
85a1b85158
[fenix] Test for 6731
2019-12-02 16:18:48 +00:00
mcarare
2ca9178898
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6835 Align Home and Browser toolbar elements to perfectly overlap
2019-12-02 16:17:07 +00:00
mcarare
10831c25ed
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6401 Set false as default value for Open links in a private tab
2019-12-02 16:16:26 +00:00