Commit Graph

2613 Commits (ab0bc61cb341c1ec450f3669c53e9b44f741b951)
 

Author SHA1 Message Date
Mihai Adrian ab0bc61cb3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6997 Avoid overwriting empty_search_string error (https://github.com/mozilla-mobile/fenix/pull/6998)
Setting error twice also clips error message
5 years ago
Emily Kager 69f92da9cb [fenix] For https://github.com/mozilla-mobile/fenix/issues/6922 - Check current destination is logins fragment before navigation (https://github.com/mozilla-mobile/fenix/pull/6924) 5 years ago
Michael Comella ed87207990 [fenix] For perf-frontend-issueshttps://github.com/mozilla-mobile/fenix/pull/33: Clarify VERBOSE logging motivation. 5 years ago
Michael Comella 3b36ea34c8 [fenix] For perf-frontend-issueshttps://github.com/mozilla-mobile/fenix/pull/33: Add HotStartPerformanceMonitorTest.
We really don't want our startup tests to subtlely change so I thought
it was worth writing some quick tests.
5 years ago
Michael Comella bde17a6a4e [fenix] For perf-frontend-issueshttps://github.com/mozilla-mobile/fenix/pull/33: Add HotStartPerformanceMonitor.
As mentioned in the class comment, we could use an alternative
implementation to measure perf from outside the application however
it's more complicated to set up and less consistent with our cold
startup methodology so we'll start with this.
5 years ago
ekager 7f5cac63f1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5771 - Don't force landscape mode on fullscreen 5 years ago
mcarare 35eeb98cac [fenix] For https://github.com/mozilla-mobile/fenix/issues/4107 Make home screen fullscreen.
Add/Remove fullscreen flags in home fragment's onResume / onPause
Change homeLayout padding to include system bars height (status&navigation).
Change homeMenu orientation to UP to properly display menu.
Change home bottomBar background to transparent.
5 years ago
mcarare d49503e58e [fenix] For https://github.com/mozilla-mobile/fenix/issues/7026 Dispatch ModeChange on hideOnboarding 5 years ago
ekager 058da9bf17 [fenix] No issue: Remove unnecessary back slashes from curly apostrophe strings 5 years ago
Michael Comella 4c25bc77a3 [fenix] No issue: remove Quality PR template item.
This should be caught by CI and should not be necessary to force folks
to check off.
5 years ago
Michael Comella 25fdcb5596 [fenix] No issue: make pre-push hook assemble only one variant, run tests, build UI test.
Since it's redundant to the definition in the source, I intend to remove
the pre-push hook listed in the wiki after this merges.
5 years ago
Grisha Kruglov 46bf7f45f9 [fenix] Fennec migration: enable logins migration 5 years ago
Jeff Boek e0b335ed68 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1607 - Passes "custom" as the search engine identifier for custom engines 5 years ago
Severin Rudie f838367e84 [fenix] No issue: small installedSearchEngineIdentifiers readability refactor 5 years ago
Severin Rudie 013aac2604 [fenix] No issue: tests installedSearchEngineIdentifiers 5 years ago
Severin Rudie a6bb6ad9ca [fenix] No issue: begin moving FenixSearchEngineProvider into a testing harness 5 years ago
Johan Lorenzo d434bc04ba [fenix] Bug 1600104 - Change FennecNightly signing format to have sha1 digest 5 years ago
Oana Horvath 4e1bb19dc0 [fenix] Fixed flaky History UI tests by adding an extra verification step that (https://github.com/mozilla-mobile/fenix/pull/6894)
the page is loaded.

Enabled all tests
5 years ago
Aaron Train 4cf0c56803 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6873: Support many more Content-Type in MockWebServer (UI tests) (https://github.com/mozilla-mobile/fenix/pull/7001)
Ensure our MockResponse can handle different Content-Type e.g, images, to help support other tests
5 years ago
Severin Rudie 53b4d6714e [fenix] For https://github.com/mozilla-mobile/fenix/issues/5334: added private custom tab processor (https://github.com/mozilla-mobile/fenix/pull/6845)
* For https://github.com/mozilla-mobile/fenix/issues/5334: added private custom tab processor

* For https://github.com/mozilla-mobile/fenix/issues/5334 - Fixes up IntentReceiverActivity for handling intents

* For 5334: update styling for private custom tabbs

* For 5334: update tests to account for new processors

Note that two are still failing. These appear to be true failures, and will be corrected in a later commit.

* For 5334: fixes bug introduced by changes to IntentReceiverActivity

RCA: intent className and extra were previously set based on which processors matched, not which successfully processed. This patch reintroduces that behavior.

* For 5334: add tests for custom tabs processing
5 years ago
Jeff Boek fa903dd097 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4664 - Updates search_with string. (https://github.com/mozilla-mobile/fenix/pull/6909) 5 years ago
Mozilla L10n Automation Bot 8671faa0f6 [fenix] Import l10n. 5 years ago
kglazko 50b8f92201 [fenix] Issue 5366 Vector Drawable Compat (https://github.com/mozilla-mobile/fenix/pull/6904) 5 years ago
Richard Pappalardo 101f6a1770 [fenix] Disable flaky testDownloadNotification - API28 (https://github.com/mozilla-mobile/fenix/pull/6982) 5 years ago
Richard Pappalardo fec1720185 [fenix] fix: enable nightly startup-test on push-apk (https://github.com/mozilla-mobile/fenix/pull/6936) 5 years ago
Mihai Adrian 208d0c684b [fenix] Temporarily fix lint issues with bad translation of string (https://github.com/mozilla-mobile/fenix/pull/6963) 5 years ago
mcarare 4a29b6b06b [fenix] For https://github.com/mozilla-mobile/fenix/issues/6917 Emit mode change only when new mode is different from current 5 years ago
Mihai Adrian b36189b3b6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6910 Align shortcuts in private onboarding panel style to… (https://github.com/mozilla-mobile/fenix/pull/6950)
Divider only shows when both panel and "Search with" are visible
5 years ago
Mihai Adrian a4be691ea0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6943 Hide supportActionBar in onResume, not onCreate (https://github.com/mozilla-mobile/fenix/pull/6978) 5 years ago
Johan Lorenzo 5c49919353 [fenix] Use multi_dep instead of single_dep (https://github.com/mozilla-mobile/fenix/pull/6923) 5 years ago
Mozilla L10n Automation Bot 4d9a90f293 [fenix] Import l10n. 5 years ago
Gabriel 9ed4f7f119 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5574 - Migrate SessionControl to LibState (https://github.com/mozilla-mobile/fenix/pull/6651)
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 1: Port TabAction.SaveTabGroup to TabSessionInteractor and SessionControlController. (https://github.com/mozilla-mobile/fenix/pull/6651)

- Introduces the TabSessionInteractor, SessionControlInteractor and SessionControlController classes.
- Removes the TabAction.SaveTabGroup.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 2: Port TabAction.PrivateBrowsingLearnMore to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 3: Port TabAction.ShareTabs to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 4: Remove unused TabAction.Share and TabItemMenu (https://github.com/mozilla-mobile/fenix/pull/6651)

In https://github.com/mozilla-mobile/fenix/issues/2205, the tab overflow button was removed which would have shown the
TabItemMenu when clicked. So, we can remove TabItemMenu since it is not
used and as a result, we can also remove TabAction.Share since there are
no consumers.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 5: Port TabAction.PlayMedia and TabAction.PauseMedia to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 6: Port TabAction.Select to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 7: Port Onboarding.Finish to OnboardingInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 8: Port TabAction.Close and TabAction.CloseAll to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

- Removes TabAction

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 9: Port CollectionAction.Delete to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 10: Port CollectionAction.ShareTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 11: Port CollectionAction.AddTab and CollectionAction.Rename to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 12: Port CollectionAction.RemoveTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 13: Port CollectionAction.OpenTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 14: Port CollectionAction.CloseTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 15: Introduce a HomeFragmentStore (https://github.com/mozilla-mobile/fenix/pull/6651)

- We will hook up the HomeFragmentStore in later parts.
- Removes List<Tab>.toSessionBundle(context: Context) since it is unused.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 16: Port CollectionAction.Collapse and CollectionAction.Expand to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

- We assume the store is hooked up to the SessionControlController in this part,
but this work will be done in a later part.
- Removes CollectionAction.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 20: Remove the architecture module. (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 17:  Remove duplicate subscribeToTabCollections in BrowserFragment.kt (https://github.com/mozilla-mobile/fenix/pull/6651)

There is a duplicate call of subscribeToTabCollections() in both HomeFragment and BrowserFragment.
In this patch, we remove the call in BrowserFragment to avoid passing the HomeFragmentStore to
BrowserFragment in order to dispatch the CollectionsChange event.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 18: Delete SessionControlComponent and fix TabCollection and Tab imports (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 19: Use the new HomeFragmentStore in the HomeFragment (https://github.com/mozilla-mobile/fenix/pull/6651)

- Renames SessionControlUIView to SessionControlView

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 21: Fix white screen on home fragment (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 22: Fix formatting in SessionControlInteractor and replace See with @see in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 23: Move to metrics.track call to the beginning of handleCollectionRemoveTab (https://github.com/mozilla-mobile/fenix/pull/6651)

This ensures that the metrics.track will be called immediately before the tab is removed from the collection.

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 24: Use the sessionManager getter in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 25: Use mapNotNull in List<Tab>.toSessionBundle (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 26: Simplify closeTab and closeAllTabs functions by assigning a deletionJob constant (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 27: Replace listOf() with emptyList() in removeAllTabsWithUndo (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 28: Replace the Context parameter with the HomeActivity in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 29: Add test for HomeFragmentStore, DefaultSessionControlController and SessionControlInteractor (https://github.com/mozilla-mobile/fenix/pull/6651)

* For https://github.com/mozilla-mobile/fenix/issues/5574 - Removes running CI against the architecture debug build varient
5 years ago
Michael Comella 60a9ccc2ed [fenix] No issue: correct glean links in telemetry.md (https://github.com/mozilla-mobile/fenix/pull/6488) 5 years ago
Jeff Boek 58bdd912e6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6855 - Filter out duplicated bundled search engines
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
5 years ago
mcarare 7a289d1eb1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6070 Adds telemetry for enabling search suggestions in private 5 years ago
Jeff Boek e6709a82d7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6849 - Properly select a new default search engine when you delete the current one
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
5 years ago
Jeff Boek 4e988fce7b [fenix] For https://github.com/mozilla-mobile/fenix/issues/6848 - Sorts the search engine list without case sensitivity
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
5 years ago
Jeff Boek e51c588fd7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6847 - Properly rebuilds the SearchEngineList on undo
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
5 years ago
Emily Kager 4ce302d29f [fenix] For https://github.com/mozilla-mobile/fenix/issues/6908 - Set null anchors for snackbars with top toolbar (https://github.com/mozilla-mobile/fenix/pull/6911) 5 years ago
Jeff Boek 7f7685689f [fenix] For https://github.com/mozilla-mobile/fenix/issues/6795 - Auto shows toolbar when loading a new URL (https://github.com/mozilla-mobile/fenix/pull/6955)
Co-authored-by: Severin <Baron-Severin@users.noreply.github.com>
5 years ago
Sebastian Kaspari ad503a83c1 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4976: Reuse Fennec launcher entry in manifest.
With this patch Fennec users, who upgrade to Fenix, will not lose Firefox launcher icons they
have added to their home screen.

A side effect of this change is that the launcher entry for existing Fenix users may disappear
from the home screen for existing Firefox Preview users and they will have to re-add it.
Since the Preview audience is more accepting of breaking changes and since that group is
way smaller than the millions of Fennec users, I think that this is an acceptable breaking
change. I looked into supporting multiple launcher entries in parallel, but that got quite
complex with multiple build types and multiple manifest files. Especially if we decide
to keep a Firefox Preview build around (e.g. org.mozilla.fenix) then it would be good to
unify on a single launcher and do that as early as possible.
5 years ago
Severin Rudie d0d74627e7 [fenix] No issue: update release docs (https://github.com/mozilla-mobile/fenix/pull/6489)
* No issue: update release docs and add Beta release steps
5 years ago
Johan Lorenzo f640ecccec [fenix] Bug 1600104 - Enable Fennec{Nightly,Beta} builds on CI 5 years ago
ekager 28eab83d14 [fenix] No issue: Update to 25.0.0-snapshot 5 years ago
Oana Horvath 0cb634facc [fenix] Added multi-selection tests for bookmarks (https://github.com/mozilla-mobile/fenix/pull/6475)
Updated bookmarking method

Fixed flaky tests

Added wait to create bookmark
5 years ago
Richard Pappalardo a6231458fc [fenix] Add Nightly startup-test (https://github.com/mozilla-mobile/fenix/pull/6569) 5 years ago
mawen7 bbfa8aadd4 [fenix] Run lint for app module and set baseline 5 years ago
Aaron Train 0e77c47f42 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6363 - Add Downloads UI tests (https://github.com/mozilla-mobile/fenix/pull/6574)
- Initiates a download
- Verifies prompt
- Verifies notification in notification shade
5 years ago
ekager 333ff28126 [fenix] No issue: Fix search suggestions strings 5 years ago
Edouard Oger 1e1c28e89c [fenix] Update Application Services to 0.44.0 5 years ago