Commit Graph

3885 Commits (a939f4ee8f9b8335a64885e27ee0655bccbdd45d)

Author SHA1 Message Date
Sawyer Blatz de6145c967 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12461: Add tab count to tab tray 4 years ago
Tiger Oakes 712dce391d [fenix] For https://github.com/mozilla-mobile/fenix/issues/5499 - Unify CFR drawables and dimens (https://github.com/mozilla-mobile/fenix/pull/12749) 4 years ago
Hakkı Kaan Çalışkan 898defc3a2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12532: Quick fix for radio button alignment (https://github.com/mozilla-mobile/fenix/pull/12691) 4 years ago
Kainalu Hagiwara 3320f82bfb [fenix] For https://github.com/mozilla-mobile/fenix/issues/12551 - Implement swipe to delete for bookmarks. 4 years ago
Kainalu Hagiwara 0671fc50e8 [fenix] Rename tab_tray_background.xml 4 years ago
Michael Comella e85dd6a09c [fenix] No issue: correct position of StartupTimeline; add warning. 4 years ago
Sawyer Blatz 80b4fb0808 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10466: Add search privately to top of list (https://github.com/mozilla-mobile/fenix/pull/12744) 4 years ago
Tiger Oakes 5b7d951590 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/10924 - Cleanup SavedLoginsAuthFragment (https://github.com/mozilla-mobile/fenix/pull/10930) 4 years ago
Kainalu Hagiwara 055620f117 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12730 - Fix ripple for font size setting. 4 years ago
Sawyer Blatz d8ecc2e19c [fenix] For https://github.com/mozilla-mobile/fenix/issues/11851: Close tab tray when last tab closed (https://github.com/mozilla-mobile/fenix/pull/12615) 4 years ago
ekager b8b3d8b367 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10784 - Fixes memory leak in BrowserAnimator 4 years ago
Sawyer Blatz 54a6de9b84 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12735: Fixes issue with tab deletion undo (https://github.com/mozilla-mobile/fenix/pull/12737) 4 years ago
Hakkı Kaan Çalışkan 197a076ef2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12554: Helper class for password reveal on logins 4 years ago
mozilla-l10n-automation-bot 24f19cd763 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/12687) 4 years ago
Christian Sadilek 250c95eb28 [fenix] Update Android Components to 51.0.20200717190031 4 years ago
Tiger Oakes e740819acd [fenix] Fix lint issues (https://github.com/mozilla-mobile/fenix/pull/12683) 4 years ago
Tiger Oakes cb59729010 [fenix] Change enabled lint rules (https://github.com/mozilla-mobile/fenix/pull/12517) 4 years ago
Tiger Oakes 25a5f478ef [fenix] Test migration classes (https://github.com/mozilla-mobile/fenix/pull/12677) 4 years ago
Tiger Oakes a7bbc86f4a [fenix] Add tests for login exceptions (https://github.com/mozilla-mobile/fenix/pull/12681) 4 years ago
Tiger Oakes 5c9876dcff [fenix] Fix failure in handleWhatsNewGetAnswersClicked (https://github.com/mozilla-mobile/fenix/pull/12682) 4 years ago
Mihai Adrian Carare 3823c632ac [fenix] For https://github.com/mozilla-mobile/fenix/issues/7966: Update toolbar content description. (https://github.com/mozilla-mobile/fenix/pull/12667) 4 years ago
Elise Richards 508854ea07 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12532: Align Settings -> Site permissions -> Sub-pages to 72dp keyline (https://github.com/mozilla-mobile/fenix/pull/12680)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
4 years ago
Mihai-Eduard Badea 65c98d6c16 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9949 - Bookmarks/History deletion inconsistencies (https://github.com/mozilla-mobile/fenix/pull/12630)
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.

 - Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in https://github.com/mozilla-mobile/fenix/issues/8648.

Co-authored-by: Mihai Eduard Badea <mihai.badea@softvision.ro>
4 years ago
Tiger Oakes 549acfa6f1 [fenix] Test session control controller (https://github.com/mozilla-mobile/fenix/pull/12652) 4 years ago
Hakkı Kaan Çalışkan 415bbf6574 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12509: Set height of remove add on button to 36dp 4 years ago
ekager f7f80ad6cb [fenix] Update ContextMenuUseCases to just take a store 4 years ago
ekager 2deadc2e22 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12453 - Sets secure flags on private tab of tabs tray 4 years ago
ekager bc08df1c8f [fenix] For https://github.com/mozilla-mobile/fenix/issues/12364 - Only show PWA prompt the third time a user visits installable site 4 years ago
Tiger Oakes ded7cde177 [fenix] Add tests for adapters in collections (https://github.com/mozilla-mobile/fenix/pull/12649) 4 years ago
Kainalu Hagiwara 46a9bba6e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12531: Align Settings -> Private browsing to 72dp keyline (https://github.com/mozilla-mobile/fenix/pull/12654)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
4 years ago
Elise Richards 5b46f572df [fenix] For https://github.com/mozilla-mobile/fenix/issues/10173: login duplicates and save (https://github.com/mozilla-mobile/fenix/pull/11208)
* Extract controller into it's own class. Implement find dupes and filter based on username.

Create edit login controller. Add text watchers and check for duplicates.

Edit controller test

* Find duplicates and save to store

* Retrieve duplicates from AC and check list on username text changed

Move duplicates logic into the controller

* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.

* Use correct threads in controller. Enable save button when applicable.

Save enabled in datastore.

Move login data to datastore

Rebase with password error states

Update metrics to be more specific for edit

* Create logins controller for AC calls

* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.

Inflate view in edit fragment. Double layout showing up.

Edit view

Controller tests

Controller tests passing

Interactor tests

Lint and detekt cleanup

* Remove datastore and use storage controller for all logins calls to password storage.

Addressed comments

Lint
:

Rebase - 1
4 years ago
Tiger Oakes 046682f889 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12457: Add MockK matcher for intents (https://github.com/mozilla-mobile/fenix/pull/12612) 4 years ago
Mugurell ac85ba0945 [fenix] Ensure logins deletion (https://github.com/mozilla-mobile/fenix/pull/12507)
* For https://github.com/mozilla-mobile/fenix/issues/11227 - Cleanup saved logins list when one is selected

Selecting a saved login will open a detail screen for it from where users can
change details or even delete that particular login.
After the change is made the user is brought back to the list of saved logins
where for a brief moment (< 1s) until we get a new response from
passwordsStorage.list() the user can see and even interact with the old list
of items, which may still contain the just deleted one.

To avoid users seeing obsolete logins or even interacting with them (selecting
a previosuly deleted item will result in a crash) we will clean the list of
logins just before the selected login is opened in the detailed view.
When returning for a brief moment the users may see the "loading" UX until
passwordsStorage.list() returns the up-to-date list of logins to display.

* For https://github.com/mozilla-mobile/fenix/issues/11227 - Refactor SavedLoginsView to be closer to MVI

- Interactors should only get passed other Interactors or Controllers as
dependencies to which they should delegate user actions.
- Controllers should hold most of the business logic and get passed all final
dependencies they need to do their job.
4 years ago
Tiger Oakes 2a7e8f7adb [fenix] Add tests for sync, wifi, and push (https://github.com/mozilla-mobile/fenix/pull/12581) 4 years ago
Tiger Oakes fe5b219a89 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565: Add Locale settings tests & use activity (https://github.com/mozilla-mobile/fenix/pull/12579) 4 years ago
jhugman 773884bdc4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12600 - remove AddonInstalled event when the permission dialog is shown (https://github.com/mozilla-mobile/fenix/pull/12601) r=csadilek,sblatz 4 years ago
Mihai Branescu 582fc2cff7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12201 - forced callbacks to be on the main thread (https://github.com/mozilla-mobile/fenix/pull/12543) 4 years ago
Elise Richards fc847d79e7 [fenix] No issue: Delete unnecessary to-dos (https://github.com/mozilla-mobile/fenix/pull/12603)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
4 years ago
Hakkı Kaan Çalışkan ad239ff1ae [fenix] No issue: Move dp's to dimens.xml 4 years ago
Kainalu Hagiwara ce7ba9a2ac [fenix] Update TabTrayViewHolder with A-C thumbnail changes. 4 years ago
Roger Yang be3ce6e2ba [fenix] For https://github.com/mozilla-mobile/fenix/issues/12118: Add isSubframeRequest parameter for app links 4 years ago
Christian Sadilek 4c49410910 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12248: Webcompat reporter not active in Nightly 4 years ago
jhugman 6a7a29fc61 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11704 Add leanplum attributes for tracking protection (https://github.com/mozilla-mobile/fenix/pull/11965) r=sblatz
* For 11657: add LP attribute for tracking protection

* For https://github.com/mozilla-mobile/fenix/issues/11704: added tracking_protection_enabled attribute

* Added docs for the new attributes, linking to data-review to the mma.md

* Rename null to none when no ETP is enabled
4 years ago
Hakkı Kaan Çalışkan ab317dc779 [fenix] No issue: Uncomment forgotten assert 4 years ago
Tiger Oakes 82d1b4380d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/12493: Remove kapt plugin 4 years ago
Hakkı Kaan Çalışkan 8645075a39 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12105: Follow ux mock on Settings --> Accessibility screen 4 years ago
James Hugman 61fe76774f [fenix] Address review comments 4 years ago
James Hugman 800e55e69a [fenix] Remove need to specify component names for new intents 4 years ago
James Hugman 648b389a68 [fenix] Changed home_* style links to urls_* to reflect that the destination is a set of links, rather than where the screen is 4 years ago
James Hugman 8e7c9bf003 [fenix] Add install_search_widget 4 years ago
James Hugman 83ed39ed5c [fenix] Add UI tests for deep links 4 years ago
James Hugman dc588ca0ae [fenix] Add unit tests for deep links 4 years ago
James Hugman bc397268a6 [fenix] Add deep links for settings and home screens 4 years ago
isabelrios 18b3fb95b4 [fenix] cron-job-ui-screenshots (https://github.com/mozilla-mobile/fenix/pull/12423)
Co-authored-by: isabel rios <isabelrios@MacBook-Pro-de-isabel-2.local>
4 years ago
Mugurell 85e05cb841 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12544 - Prevent search engines mixup
Stricter synchronization by always using the same "loadedSearchEngines"
variable.
With "loadedSearchEngines" calling "refreshAsync()" we also get the fallback
engines to contain reddit and youtube (which are programatically added) and
also now we properly remember and display the engines added by user.
4 years ago
Oana Horvath 70e30dcf98 [fenix] Replaces verifyPageContent in UI tests 4 years ago
Tiger Oakes 65402a62dd [fenix] Add tests for StartupReportFullyDrawn (https://github.com/mozilla-mobile/fenix/pull/12560) 4 years ago
Tiger Oakes c1a74cc939 [fenix] Add helper for underlining text (https://github.com/mozilla-mobile/fenix/pull/12520) 4 years ago
Tiger Oakes 2e8da8abe0 [fenix] Fix nav graph and theme tests (https://github.com/mozilla-mobile/fenix/pull/12567) 4 years ago
Tiger Oakes 034a9dae8f [fenix] Update Kotlin dependency (https://github.com/mozilla-mobile/fenix/pull/10806) 4 years ago
mcarare 1efe17c801 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12503: Add unit tests for permissions details view. 4 years ago
mcarare bfd879be4a [fenix] For https://github.com/mozilla-mobile/fenix/issues/12503: Open addon permissions link in app. 4 years ago
Aaron Train d60d77248b [fenix] No issue: Add a couple Tabs Tray UI tests 4 years ago
ekager 772f69c5f5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7094 - Adds save login exceptions 4 years ago
Tiger Oakes 09c37671a8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12457 - Add MockK matcher for nav directions (https://github.com/mozilla-mobile/fenix/pull/12262) 4 years ago
Tiger Oakes 431459d181 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12171: Use one-line logo in Nightly (https://github.com/mozilla-mobile/fenix/pull/12555) 4 years ago
Tiger Oakes d9e7a351fa [fenix] Add tests for search (https://github.com/mozilla-mobile/fenix/pull/12437) 4 years ago
Tiger Oakes afd8eafd9f [fenix] Test viewholders in home.sessioncontrol (https://github.com/mozilla-mobile/fenix/pull/12524) 4 years ago
Hakkı Kaan Çalışkan e83a7f3370 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12107: Follow ux mock on Settings --> Account screen 4 years ago
Mozilla L10n Automation Bot 2d97e98f58 [fenix] Import l10n. 4 years ago
ekager 9c0e356950 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11099 For https://github.com/mozilla-mobile/fenix/issues/12189 For https://github.com/mozilla-mobile/fenix/issues/7532 - Clean up bottom navigation bar colors 4 years ago
Sawyer Blatz ca02217039 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10466: Put call & email at top of context list 4 years ago
Hakkı Kaan Çalışkan c332cc631e [fenix] For https://github.com/mozilla-mobile/fenix/issues/12106: Follow ux mock on Settings --> Logins screen 4 years ago
Oana Horvath 0885d0047e [fenix] For https://github.com/mozilla-mobile/fenix/issues/10911: disables flaky createBookmarkFolderTest 4 years ago
Mugurell 66fdc14386 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11875 - Prevent mixup of region / locale based search engines
We have two search engine types:
- one based on MLS reported region,
- one based only on Locale.

There are multiple steps involved in returning the default search engine for
example and though at each step we could verify if a certain operation is
completed we are still exposed to concurrency issues.
Simplest and most effective way to make sure the MLS engines do not mix with
Locale based engines is to use the same type of engines for the entire duration
of the app. At the next cold start we'll verify again which engines to use.

Using the Locale based engines (fallbacks) is expected to only happen once, at
the first run of the application after being installed.
4 years ago
Mozilla L10n Automation Bot 73fbb27808 [fenix] Import l10n. 4 years ago
jhugman de6a9cf93b [fenix] For https://github.com/mozilla-mobile/fenix/issues/11655: add leanplum event for installing an addon (https://github.com/mozilla-mobile/fenix/pull/12136) r=elise
* For https://github.com/mozilla-mobile/fenix/issues/11655: add leanplum event for installing an addon

* Add link to data-review request in PR

* Addressed CI comments
4 years ago
Grisha Kruglov 1278ca374c [fenix] Synced Tabs: make sure to stop 'loading' when we encounter an error 4 years ago
Tiger Oakes 291c3196ee [fenix] Fix Robolectric tests SDK version (https://github.com/mozilla-mobile/fenix/pull/12464) 4 years ago
ekager fade6c7936 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11324 - Adds trash icon to swipe to delete 4 years ago
Michael Comella 03b8068cd2 [fenix] No issue - post: mock profiler object in DefaultTabTrayControllerTest.
Without this line, the tests fail when running the full suite (but not
this test in isolation, for some reason).
4 years ago
Nazım Can Altınova 5a1c31e13f [fenix] Add profiler markers for HomeActivity.load and DefaultTabTrayController.onNewTabTapped 4 years ago
Sawyer Blatz bdcd04cc6a [fenix] Update app/src/main/java/org/mozilla/fenix/HomeActivity.kt
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
4 years ago
Sawyer Blatz 33ea9d02aa [fenix] No issue: Update AC version 4 years ago
Michael Comella 2a3a343393 [fenix] For perf-frontend-issueshttps://github.com/mozilla-mobile/fenix/issues/44: add local property to autosign release builds. 4 years ago
Mihai Eduard Badea a9c19cbcf5 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/12339 - Collection delete dialog string update
Set the collection delete dialog title text to "Delete %1$s?"
4 years ago
Mozilla L10n Automation Bot 03185f680a [fenix] Import l10n. 4 years ago
Grisha Kruglov d76815b9ca [fenix] For https://github.com/mozilla-mobile/fenix/issues/12433 - Allow synced tabs pull-to-refresh for non-critical account errors 4 years ago
ekager ddf56f9bc6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11303 - Change copy login origin to open in browser 4 years ago
Tiger Oakes e69b1e06f1 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/9832 - Change targetSdkVersion to Android 10 (https://github.com/mozilla-mobile/fenix/pull/11014) 4 years ago
Emily Kager 2eaef29243 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12010: Follow ux mock on Settings --> ETP --> Info screen (https://github.com/mozilla-mobile/fenix/pull/12429)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
4 years ago
Sebastian Kaspari f3cfdc5058 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/12311: BrowserToolbarController: Stop SessionFeature and release session from EngineView. 4 years ago
TejaswiKarasani 47e60525ff [fenix] No Issue: Verify the page main menu items UI Test (https://github.com/mozilla-mobile/fenix/pull/12336) 4 years ago
Mozilla L10n Automation Bot 869c91048a [fenix] Import l10n. 4 years ago
David Walsh 940bc85996 [fenix] For 11889 - Fix snackbar for collection creation in browser fragment 4 years ago
mozilla-l10n-automation-bot 1f3c3966fb [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/12404) 4 years ago
Hakkı Kaan Çalışkan cfb8cac9a3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11563: Set ic_close.xml to use full width and height 4 years ago
ekager 16132f2c5d [fenix] For https://github.com/mozilla-mobile/fenix/issues/11431 - Scroll to restored tab in tab tray 4 years ago
Christian Sadilek bcb49d3985 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12353: URL copied to clipboard should not be extension/reader URL 4 years ago
Tiger Oakes 5406f2cafb [fenix] Add tests for exceptions 4 years ago