Jeff Boek
1b2e67b871
Adds string freeze date to calendar and string header ( #5159 )
2019-09-06 16:52:57 -07:00
Petru Lingurar
53341f620a
Code cleanup - Remove unused FindInPageBarBehavior
...
There is a "unused" lint suppression in place with the comment
"Referenced from XML". I found no such usage.
It's documentation says that this Behavior will always position FindInPageBar
above BrowserToolbar but the current code ensures
BrowserToolbar.visibility == GONE when FindInPageBar.visibility == VISIBLE
so there's no need for such behavior.
2019-09-06 14:20:02 -04:00
Petru Lingurar
b82024f993
For #4856 - Refactor InflationAwareFeatureTest
...
We previously had a test exactly for checking that "start does nothing" but we
now need to ensure that start actually is propagated to the inner feature that
is to rebind itself to the app to allow for user interactions.
2019-09-06 14:20:02 -04:00
Petru Lingurar
716cf3995a
Fix #4856 - Propagate LifecycleAwareFeature's onStart() to the inner feature
...
FindInPageFeature is used inside the app as a LifecycleAwareFeature and as such
it receives the onStart / onStop lifecycle calls.
The onStart() lifecycle call would not get passed to the feature but in
onStop() FindInPageFeature will detach it's Presenter and Interactor so when
the user comes back to the screen she could not interact anymore with the
feature.
To fix this we'll propagate LifecycleAwareFeature's onStart() to the inner
feature which is to rebind it's Presenter and Interactor in onStart().
This behavior is common to all the other features so all of them who implement
LifecycleAwareFeature will now get the onStart() call also.
2019-09-06 14:20:02 -04:00
Mihai Adrian
ed0b6bd5ef
For #4193 - Makes close button for tabs more accessible ( #4442 )
...
* fixes #4193 - made close button for tabs more accessible.
set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button and text as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
* Fix margins
2019-09-06 10:33:55 -07:00
Sawyer Blatz
aef087aae0
No issue: Removes unused nestedScrollQuickActionView ( #5143 )
2019-09-06 09:03:24 -07:00
Mitchell Hentges
7d023fefc9
Fixes #5156 ; Don't publish o.m.fenix[!.nightly] to nightly index ( #5157 )
2019-09-06 08:01:02 -07:00
mihai-adrian
c8d622c43d
For #5142 Removed RadioButton from accessibility keeping one option for Talkback
...
Set android:importantForAccessibility = "no" for RadioButton
2019-09-06 14:09:58 +02:00
Sawyer Blatz
2653b5966e
For #964 : Adds ability to disable each suggestion provider ( #5096 )
...
* For #964 : Adds ability to disable each suggestion provider
* Fix nit
2019-09-05 14:45:44 -07:00
Jonathan Almeida
ccd9e44a3e
No issue: Add logging for firebase/autopush
2019-09-05 16:03:36 -04:00
Emily Kager
58287cd5bb
For #5033 - Update browsing mode when session selected ( #5118 )
2019-09-05 14:27:30 -05:00
Richard Pappalardo
d18ec43bcb
Temporarily disable broken UI test ( #5136 )
2019-09-05 10:22:14 -07:00
Alessio Placitelli
dcbe5be121
Enable Gecko metrics exfiltration through Glean ( #5126 )
2019-09-05 11:58:35 -05:00
Emily Kager
bb2a685ad9
For #5075 - Fix boolean error for private mode notification persistence ( #5120 )
2019-09-05 09:21:56 -07:00
Sebastian Kaspari
3a35233ac0
Remove ThumbnailsFeature. ( #5127 )
...
We currently do not use thumbnails anywhere in the app. Not using the feature means we are
not taking thumbnails on every page load which means we are saving memory and CPU cycles.
2019-09-05 11:05:37 -05:00
Grisha Kruglov
231924f5eb
Fix breaking services APIs changes
2019-09-05 13:38:15 +02:00
Sebastian Kaspari
2c7fd93c7d
Update to Mozilla Android Components 12.0.0-SNAPSHOT.
2019-09-05 13:38:15 +02:00
Sebastian Kaspari
c2db07acf8
Add browser-state component.
2019-09-05 13:38:15 +02:00
Alessio Placitelli
0f6f28b6da
Revert "Enable Gecko metrics exfiltration through Glean ( #5124 )" ( #5125 )
...
This reverts commit f824c98c20
.
2019-09-05 04:26:46 -05:00
Alessio Placitelli
f824c98c20
Enable Gecko metrics exfiltration through Glean ( #5124 )
2019-09-05 04:17:28 -05:00
Emily Kager
a5e9da7a55
For #5025 - Do not remove custom tab session with config removed
2019-09-05 10:57:37 +02:00
Sawyer Blatz
23095ae274
For #4155 : Adds strings for long press popup ( #5112 )
2019-09-04 17:15:06 -07:00
Emily Kager
fd1c512b2e
No issue: Land strings for delete browsing data on quit
2019-09-04 15:45:10 -07:00
Yeon Taek Jeong
fba37ee6e6
For #419 : Add strings for "Add private browsing shortcut" feature ( #5109 )
2019-09-04 15:44:22 -07:00
Jeff Boek
c9a8eae031
For i5047 - Adds strings for the add to homescreen dialog
2019-09-04 15:18:44 -07:00
Mitchell Hentges
13f11bd9b3
Adds build for fennecProduction to nightly automation tasks ( #5097 )
2019-09-04 13:52:23 -07:00
Sawyer Blatz
56128b6303
For #5021 : Adds metric for what's new button
2019-09-04 09:17:14 -07:00
Sawyer Blatz
1669b437ed
For #4908 : Adds metrics for send tab telemetry
2019-09-04 09:15:50 -07:00
mihai-adrian
2e544145b7
For #5095 : Changed search engine text color from default to ?primaryText
2019-09-04 07:57:17 -07:00
mihai-adrian
0fc42a8a09
For #4892 : Replaced straight single quote with curly apostrophe in contractions
2019-09-04 14:10:05 +02:00
Axel Hecht
0bddeb4da5
Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@6d2fe8331a
2019-09-04 14:08:15 +02:00
Sawyer Blatz
55e5c45eb5
No issue: Adds screenshots to the PR checklist ( #5089 )
2019-09-03 15:18:13 -05:00
Sawyer Blatz
09dcdb079d
For #4474 : Adds what's new button to home screen menu ( #5088 )
...
* For #4474 : Adds what's new button to home screen menu
* For #4474 : Adds tests for what's new button
2019-09-03 15:16:29 -05:00
Petru Lingurar
46b09395f8
For #5067 - Refactor ShareControllerTest following the use of SendTabUseCases
2019-09-03 12:01:26 -07:00
Petru Lingurar
f7087e46e3
Fix #5067 - Refactor ShareController to use SendTabUseCases
...
Navigation between app fragments uses ShareTab as arguments. The newly used
SendTabUseCases uses TabData which is not Parcelable.
For minimal changes we'll keep both data classes and ShareController will know
how to map between the two.
Removed the `sessionId` property of ShareTab as it isn't needed anymore.
2019-09-03 12:01:26 -07:00
Sebastian Kaspari
ba05d21657
Fix ktlint MaxLineLength issues.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
38d97fda8b
Stores: Reduce visibility of reducer functions.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
2723a55b03
Rename HistoryStore/State/Action to HistoryFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
f3d8a89c63
Rename AccountSettingsStore/State/Action to AccountSettingsFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
61e84c161d
Rename SearchStore/State/Action to SearchFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
22446263f1
Rename ExceptionsStore/State/Action to ExceptionsFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
ac32a88d45
Rename BrowserStore/State/Action to BrowserFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
76063e307a
Rename BookmarkStore/State/Action to BookmarkFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
mihai-adrian
3171f3a1a7
Fixes #4997 : Changed navigation to ShareFragment
...
Changed test for new global navigation to share fragment.
2019-09-03 07:08:08 -10:00
mihai-adrian
fc8fc2b33d
Fixes #4997 : Changed navigation to ShareFragment
...
Added global navigation action to share fragment in navigation graph
Changed share action to use global navigation to ShareFragment
2019-09-03 07:08:08 -10:00
Sebastian Kaspari
389b85f783
Issue #4907 : Link to usage of sharedUserId in Fennec code.
2019-09-03 17:10:06 +02:00
Sebastian Kaspari
be8b789e62
Issue #4907 : Config: Get rid of "floating pow()".
2019-09-03 17:10:06 +02:00
Sebastian Kaspari
be76a383b6
Issue #4907 : Config: Update commment explaining fennec versioning scheme.
2019-09-03 17:10:06 +02:00
Sebastian Kaspari
3fb22a12b6
Issue #4873 : Use manifest placeholder to inject sharedUserId.
2019-09-03 17:10:06 +02:00
Sebastian Kaspari
754c577682
Issue #4873 : Reuse sharedUserId from Fennec for fennecProduction build type.
2019-09-03 17:10:06 +02:00