2
0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-07 15:20:38 +00:00
Commit Graph

4280 Commits

Author SHA1 Message Date
Jeff Boek
f4d01f85fe [fenix] For https://github.com/mozilla-mobile/fenix/issues/13325 - Positions toolbar according to user preference 2020-08-06 18:28:31 -07:00
Mozilla L10n Automation Bot
127edf7956 [fenix] Import l10n. 2020-08-06 18:05:42 -07:00
liuche
ce565577cc [fenix] Changed name_collection_dialog.xml's EditText's input type from "text… (https://github.com/mozilla-mobile/fenix/pull/13367)
Co-authored-by: Karol Wąsowski <wasowski02@gmail.com>
2020-08-06 14:45:23 -07:00
Mozilla L10n Automation Bot
e187eb9028 [fenix] Import l10n. 2020-08-06 10:42:06 -07:00
ankur
0ff90accee [fenix] For https://github.com/mozilla-mobile/fenix/pull/13301, https://github.com/mozilla-mobile/fenix/issues/13038: hide overflow menu for all bookmark items in selected mode 2020-08-06 09:51:56 -07:00
Aaron Train
0410b34203 [fenix] No issue: Remove unused import in SettingsAddonsTest (https://github.com/mozilla-mobile/fenix/pull/13345)
Fixes lint-ktlint error on master https://github.com/mozilla-mobile/fenix/runs/954237630
2020-08-06 11:24:16 -04:00
Kadeem M
3f291b969d [fenix] Fix failing verifyAddonsCanBeUninstalled test (https://github.com/mozilla-mobile/fenix/pull/13319) 2020-08-06 10:33:25 -04:00
Sebastian Kaspari
2875338740 [fenix] Simplify build variants to just: debug, nightly, beta and release.
Co-authored-by: Johan Lorenzo <jlorenzo@mozilla.com>
2020-08-06 11:52:10 +02:00
Aaron Train
0bdfbd8d88 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13218: Fix settingsAddonsItemsTest 2020-08-06 10:21:18 +03:00
Emily Kager
a429f0482b [fenix] For https://github.com/mozilla-mobile/fenix/issues/13298 - Make private tabs in tabs tray not long clickable (https://github.com/mozilla-mobile/fenix/pull/13316) 2020-08-05 22:12:03 -04:00
ekager
a42bb3c9de [fenix] For https://github.com/mozilla-mobile/fenix/issues/6313 - Removes unused browser animations, improve delayed paint interactions 2020-08-05 20:03:05 -04:00
Tiger Oakes
5049ed496d [fenix] For https://github.com/mozilla-mobile/fenix/issues/11903: Fix private custom tabs (https://github.com/mozilla-mobile/fenix/pull/13327) 2020-08-05 16:24:47 -07:00
Jeff Boek
4f119b055d [fenix] Wires up controller, store and interactor. (https://github.com/mozilla-mobile/fenix/pull/13324)
* For https://github.com/mozilla-mobile/fenix/issues/13320 - Wires up the search store, controller and interactor for the new search experience

* For https://github.com/mozilla-mobile/fenix/issues/13323 - Navigates to new search experience from the browser when enabled
2020-08-05 18:22:07 -05:00
Jeff Boek
08967f0051 [fenix] Progress on new search experience with Toolbar and Awesomebar placeholders (https://github.com/mozilla-mobile/fenix/pull/13314)
* For https://github.com/mozilla-mobile/fenix/issues/13272 - Adds the ToolbarView to the SearchDialogFragment

* For https://github.com/mozilla-mobile/fenix/issues/13273 - Replaces container dependency with context in AwesomebarView

* For https://github.com/mozilla-mobile/fenix/issues/13276 - Hacks together the awesomebar and toolbar in the new search experience
2020-08-05 14:40:43 -05:00
Michael Comella
a2c984016b [fenix] For https://github.com/mozilla-mobile/fenix/issues/4132: remove raptor property and isRaptorEnabled manifest placeholder.
afaict, this is only used for BrowserPerformanceTestActivity, which is
being removed in this PR.
2020-08-05 10:15:46 -07:00
Michael Comella
d11908ce34 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4132: remove BrowserPerformanceTestActivity & usages. 2020-08-05 10:15:46 -07:00
Tiger Oakes
3213f5107b [fenix] For https://github.com/mozilla-mobile/fenix/issues/13262: Update gradle (https://github.com/mozilla-mobile/fenix/pull/13263) 2020-08-05 09:17:30 -07:00
Kainalu Hagiwara
87fdd035c0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12831 - Disable SwipeRefreshLayout while swiping a bookmark. 2020-08-05 09:00:43 -07:00
Kainalu Hagiwara
6e65d78609 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12906 - Fix swipe-to-delete bookmark folder. 2020-08-05 08:59:26 -07:00
Mozilla L10n Automation Bot
33e0d6861d [fenix] Import l10n. 2020-08-05 09:56:36 -04:00
Hakkı Kaan Çalışkan
3c4b386aab [fenix] For https://github.com/mozilla-mobile/fenix/issues/12585: Close tab tray menu on orientation changes 2020-08-05 09:56:08 -04:00
Richard Pappalardo
9c1a956c23 [fenix] Disable flaky tests: settingsAddonsItemsTest, verifyAboutFirefoxPreview (https://github.com/mozilla-mobile/fenix/pull/13286)
* fix: disable intermittent failing UI tests

* fix: add dependency
2020-08-04 22:46:41 -04:00
ekager
ff022c2dcf [fenix] No issue: Change first paint feature flag to nightly/debug 2020-08-04 18:28:41 -04:00
ekager
af14e3d6e2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6313 - On first load, hides engineView until firstContentfulPaint 2020-08-04 17:15:46 -04:00
Jeff Boek
5b99bf33a1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13052 - Creates new dialog fragment for search and puts it behind a feature flag 2020-08-04 12:24:24 -07:00
Kainalu Hagiwara
9b80ad8560 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13235 - Add haptic feedback when long pressing forward button. 2020-08-04 12:19:12 -07:00
ekager
4fbb2e2fbb [fenix] For https://github.com/mozilla-mobile/fenix/issues/13179 - Ensure we only dismiss share prompt once 2020-08-04 15:05:26 -04:00
ekager
591cd111e7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13221 - Update global ETP to include PBM 2020-08-04 14:34:24 -04:00
Tiger Oakes
686f0087e5 [fenix] Don't init glean in unit tests (https://github.com/mozilla-mobile/fenix/pull/13100) 2020-08-04 11:18:52 -07:00
ekager
db174e64d8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11610 - Fire sign in event for other types of auth events 2020-08-04 14:18:19 -04:00
ekager
7fbd592e45 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11280 - Adds FxA Signed Up Leanplum Event 2020-08-04 14:18:19 -04:00
Jeff Boek
f342d1bf31 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13229 - Cache deviceId for reuse 2020-08-04 11:07:20 -07:00
Oana Horvath
fc5440438b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/12893: fixed deleteAllHistoryTest (https://github.com/mozilla-mobile/fenix/pull/13255) 2020-08-04 13:33:52 -04:00
ekager
0d40fa830c [fenix] For https://github.com/mozilla-mobile/fenix/issues/13228 - Disable Firebase analytics a second way 2020-08-04 11:43:13 -04:00
Mozilla L10n Automation Bot
439cdd9652 [fenix] Import l10n. 2020-08-04 10:17:35 -04:00
Elise Richards
1e7d4c3e80 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10261: PWA Telemetry (https://github.com/mozilla-mobile/fenix/pull/11859)
* Add PWA events to metrics.

Track events for add to homescreen and install.

Map PWA facts to events

* Map component facts to local metrics

Add events pings to fragments

Supress long method for events

Move install event to AC and collect facts

Retrieve fg and bg events from Facts. Do not track intent fg/bg events, only views

* Allow onPause in base fragment to send telemetry for PWA in the external app fragment. Track foreground and bg locally in fenix, and route install and home screen taps from AC facts

* Rebase
2020-08-03 13:59:31 -05:00
Mihai Branescu
d82708797c [fenix] Remove all deprecated strings (https://github.com/mozilla-mobile/fenix/pull/13192)
As requested here: https://github.com/mozilla-l10n/android-l10n/pull/249#discussion_r461209439
2020-08-03 12:22:12 -05:00
Mozilla L10n Automation Bot
24e21e581d [fenix] Import l10n. 2020-08-03 12:07:59 -04:00
Oana Horvath
f7ad4fdcc6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13220, https://github.com/mozilla-mobile/fenix/issues/13217: Disables failing UI tests 2020-08-03 16:21:08 +03:00
Tiger Oakes
6468af8c5b [fenix] For https://github.com/mozilla-mobile/fenix/issues/13140: Use concept-menu for saved logins menu (https://github.com/mozilla-mobile/fenix/pull/13143) 2020-08-02 18:48:10 -07:00
Ankur Khandelwal
f07dd7cc58 [fenix] Renamed Deps.mozilla_ui_publicsuffixlist to Deps.mozilla_lib_publicsuffixlist (https://github.com/mozilla-mobile/fenix/pull/13201) 2020-08-02 17:23:39 -04:00
Shen
bfb617eed9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9619 hide overflow menu for all history items in selected mode 2020-08-01 22:26:43 -04:00
Mozilla L10n Automation Bot
db2dc4ed38 [fenix] Import l10n. 2020-08-01 21:44:35 -04:00
mozilla-l10n-automation-bot
392b7dffb4 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/13189) 2020-07-31 17:31:52 -07:00
Michael Comella
56b2adf7e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12802 - review: update metrics for data review. 2020-07-31 16:05:06 -07:00
Michael Comella
19abae1155 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12802: add StorageStats glean metrics. 2020-07-31 16:05:06 -07:00
Tiger Oakes
db14fef0d3 [fenix] Renamed Metrics to Event 2020-07-31 14:14:45 -07:00
Tiger Oakes
6d95c7aab0 [fenix] Moved MetricsService to its own file 2020-07-31 14:14:45 -07:00
Tiger Oakes
f1575249d1 [fenix] Move MetricController to its own file 2020-07-31 14:14:45 -07:00
Kainalu Hagiwara
f2c24c516f [fenix] For https://github.com/mozilla-mobile/fenix/issues/13127 - Make sure tabPreview is added after browserLayout. 2020-07-31 14:14:05 -07:00
ekager
c040c5ffa6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13117 - Don't show add to collections button in private tabs tray 2020-07-31 14:13:12 -07:00
Tiger Oakes
e1a2dc51c8 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/12522: Reuse exceptions code (https://github.com/mozilla-mobile/fenix/pull/13047) 2020-07-31 13:24:14 -07:00
ekager
6e5ade7b2c [fenix] For https://github.com/mozilla-mobile/fenix/issues/13135 - Replace about top header with Firefox Daylight 2020-07-31 16:21:39 -04:00
prabhat3108
043b43553a [fenix] swapped deleted and save icon in bookmarks_edit menu. closeshttps://github.com/mozilla-mobile/fenix/issues/11490 2020-07-31 16:19:02 -04:00
Kainalu Hagiwara
f84b9e5c55 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12888 - Add highlight to current page in tab history. 2020-07-31 12:54:42 -07:00
Mihai Branescu
dd5ed3fa87 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11498/https://github.com/mozilla-mobile/fenix/issues/11499 - added/fixed unit tests 2020-07-31 21:42:57 +03:00
Mihai Branescu
0c18983da3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11498 - removed SignIn ViewHolder and unified with the Error one 2020-07-31 21:42:57 +03:00
Mihai Branescu
331c042339 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11499 - replaced string for no tabs available 2020-07-31 21:42:57 +03:00
Mihai Branescu
5338c21474 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11498 - add Sync tabs error view (including sign-in CTA) 2020-07-31 21:42:57 +03:00
Kadeem
f2ad00d86e [fenix] For https://github.com/mozilla-mobile/fenix/issues/12769: Refactored Background Service Test into multiple test cases. 2020-07-31 10:47:11 -07:00
Mugurell
854065ea5a [fenix] For https://github.com/mozilla-mobile/fenix/issues/13037 - Use email to sign in to fxa if device has no camera
App can be installed on devices with no camera modules. Like Android TV boxes.
Will skip presenting the option to sign in by scanning a qr code in this case
and default to login with email and password.
2020-07-31 20:02:23 +03:00
ekager
c84bf4ea74 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6846 - Don't show ToolbarPopupWindow if nothing to show 2020-07-31 12:55:09 -04:00
Mihai Eduard Badea
11baf289f3 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/12400 - Refresh swiped collection tab view
Item is now refreshed by calling notifyDataSetChanged on the adapter when the last tab from the collection has been swiped away and the user cancels the deletion by pressing the cancel button from the dialog.
Also added a "wasSwiped" flag to onCollectionRemoveTab in order to check if the tab was deleted from a swipe action and not by pressing the "X" button.
2020-07-31 12:48:32 -04:00
Mozilla L10n Automation Bot
2d3b926e00 [fenix] Import l10n. 2020-07-31 12:37:11 +03:00
Tiger Oakes
1b2723089c [fenix] Fix suggestions, extract layout for tab history 2020-07-30 17:54:09 -07:00
Tiger Oakes
4245f4fb0f [fenix] Add tests for tab history 2020-07-30 17:54:09 -07:00
Tiger Oakes
135a3a607a [fenix] For https://github.com/mozilla-mobile/fenix/issues/12887: Use ListAdapter to diff history 2020-07-30 17:54:09 -07:00
ekager
2da8330f19 [fenix] No issue: Adds sameAs function for TopSiteList AdapterItem 2020-07-30 17:46:03 -04:00
ekager
86081e11d1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11690 - Add contentsSameAs to avoid rebind of items in SessionControlAdapter 2020-07-30 15:18:04 -04:00
Tiger Oakes
a2d4efd120 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7992: Use favicon style from AC (https://github.com/mozilla-mobile/fenix/pull/12608) 2020-07-30 11:21:17 -07:00
Tiger Oakes
c56392c5ec [fenix] Use uplifted addon date code 2020-07-30 10:29:40 -07:00
jhugman
0d4c4122a7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11664 — Fixup MissingResourceExceptions being thrown in exotic Locales (https://github.com/mozilla-mobile/fenix/pull/13124)
Our kotlin code is not catching the `MissingResourceException` in the `LeanplumMetricsService` which results in the app crashing when the locale isn't known by the device.

Catches the exception, and falls back to the ISO 639 language code. This isn't a great solution, because ISO 639 isn't especially stable.

In practice however this is almost certainly never going to be a problem because Leanplum isn't going to be supported in such exotic locales.

In this case, using the ISO 639 language code allows the error message to be more informative.
2020-07-30 18:28:26 +01:00
ekager
a863afc6c1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13117 - Hide save to collection button for private tabs in tab tray 2020-07-30 11:53:29 -04:00
mcarare
812e635a69 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565: Remove activity from DefaultTabTrayController constructor. 2020-07-30 13:33:02 +03:00
Mozilla L10n Automation Bot
63bde96bcd [fenix] Import l10n. 2020-07-29 21:52:03 -04:00
Tiger Oakes
9673c13a72 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13084 - Use runBlockingTest 2020-07-29 21:51:28 -04:00
Kate Glazko
f140e0bf32 [fenix] remove unused import 2020-07-29 17:47:18 -07:00
Kate Glazko
16797b3103 [fenix] For AC https://github.com/mozilla-mobile/fenix/issues/7673 Move DownloadStatus to DownloadState Fenix Side Changes 2020-07-29 17:47:18 -07:00
Tiger Oakes
6b5229d75b [fenix] Move config to robolectric.properties 2020-07-29 17:46:26 -07:00
Jeff Boek
b58a48ca5d [fenix] For https://github.com/mozilla-mobile/fenix/issues/12570 - Correctly removes search suggestions when search query and url is empty 2020-07-29 16:03:10 -07:00
Jeff Boek
d2d7fceb94 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11579 - Adds telemetry for autoplay settings in Site Permissions 2020-07-29 15:10:25 -07:00
Tiger Oakes
451a859db0 [fenix] Add metric tests 2020-07-29 14:58:48 -07:00
Kainalu Hagiwara
627cd8b8bd [fenix] For https://github.com/mozilla-mobile/fenix/issues/12865, https://github.com/mozilla-mobile/fenix/issues/12990 - Disable swipe to switch tabs gesture when the keyboard is visible. 2020-07-29 14:55:03 -07:00
mozilla-l10n-automation-bot
8ef2048506 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/13088) 2020-07-29 13:51:01 -07:00
Sawyer Blatz
2a5fdd6054 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9730: Add Login Dialog Prompt telemetry 2020-07-29 12:59:35 -07:00
ekager
61b5a37ce9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13084 - Update SavedLoginsStorageControllerTest 2020-07-29 15:15:18 -04:00
ekager
5f923111ff [fenix] For https://github.com/mozilla-mobile/fenix/issues/11654 - Adds leanplum ETP changed event 2020-07-29 13:35:16 -04:00
Sawyer Blatz
10a4dd6381 [fenix] Add documentation 2020-07-29 13:35:16 -04:00
Sawyer Blatz
51a33c9efe [fenix] For https://github.com/mozilla-mobile/fenix/issues/12103: Add ChangedDefaultBrowser event for leanplum 2020-07-29 13:35:16 -04:00
Sawyer Blatz
83e18873b2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11531: Add search widget installed leanplum event 2020-07-29 13:35:16 -04:00
ekager
2cc3f2b4e5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13071 - Only return to home when session doesn't have parent session to select 2020-07-29 09:50:58 -07:00
Antti Vainikka
b7b555d823 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/12692: Remove www. prefix in tab tray urls
Use separate imports instead of a wildcard import

Use toShortUrl String extension instead of removing prefix from url host

Add missing import
2020-07-29 12:16:32 -04:00
mcarare
9fad50cce9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565: Pass passwordsStorage instead of context in constructor. 2020-07-29 12:15:16 -04:00
ekager
39ddffabef [fenix] For https://github.com/mozilla-mobile/fenix/issues/12992 - Correctly notifies concat adapters about mode changes 2020-07-29 11:58:04 -04:00
Mozilla L10n Automation Bot
414488b0cf [fenix] Import l10n. 2020-07-29 11:42:30 -04:00
ekager
cf11d7e3cc [fenix] For https://github.com/mozilla-mobile/fenix/issues/13042 - Remove bottomSheetCallback in multiselect mode 2020-07-29 11:19:47 -04:00
Mihai Adrian Carare
206106ddc0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12533: Align main settings categories according to specs. (https://github.com/mozilla-mobile/fenix/pull/12534) 2020-07-29 10:08:00 -05:00
mcarare
ebf3399087 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565: Remove context from DeleteBrowsingDataController constructor 2020-07-29 17:46:43 +03:00
mozilla-l10n-automation-bot
e6ba80ba02 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/13048) 2020-07-28 18:37:50 -07:00
sraturi
adfcf08a49 [fenix] for https://github.com/mozilla-mobile/fenix/issues/11830 created class containing the logic for sending AllStartup telemetry logic
lint check

renamed the intentReceived telemetry to appOpenedAllSource

added comments

removed unused code

moved lifecycle process to AppAllSourceStartTelemetry

moved tracking event out of init function

lint fix

moved appAllStartTelemetry to components

added bit more info about the metrics

added the  onReceivedIntent metric back

minor fix

change discriptions based on the comments frm MR

wrote test cases for AppAllSourceStartTelemetry.kt

lint fix

test case to mock application going background

post rebase:

post rebase:

fixed nit from comments

fixed nit from comments

fixed nit from comments

lint fix

lint fix
2020-07-28 17:09:42 -07:00
Sachin
12202411d3 [fenix] for https://github.com/mozilla-mobile/fenix/issues/11698 added on demand workmanager initialization (https://github.com/mozilla-mobile/fenix/pull/12739) 2020-07-28 16:26:18 -07:00
Kainalu Hagiwara
b27e4b4eae [fenix] For https://github.com/mozilla-mobile/fenix/issues/12904 - Conditionally inflate SwipeGestureLayout in BaseBrowserFragment.
Changing the root view of BaseBrowserFragment from a CoordinatorLayout
to a SwipeGestureLayout has caused some regressions, particularly in
snackbar behavior. Lets prevent those regressions from occuring in
builds where the feature flag for gestures is off by only adding the
SwipeGestureLayout when the feature flag is on.
2020-07-28 14:54:18 -07:00
Leonardo Murça
f7f50cc994 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12755 - Replace @+id by @id when referencing already declared ids
When referencing an Android resource ID, you do not need the
plus-symbol if you declared before.
Caution: make sure that the resource you are referring to
is defined EARLIER and not LATER.
2020-07-28 14:46:09 -07:00
Kainalu Hagiwara
347b5d527c [fenix] For https://github.com/mozilla-mobile/fenix/issues/12861 - Swap order of tabs for tab switching gesture. 2020-07-28 14:37:45 -07:00
amkcpu
48db5eb528 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12706 - Add vertical scrollbar to bookmarks screen 2020-07-28 16:47:18 -04:00
amkcpu
0a96e991b7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12704 - Add vertical scrollbar to history screen 2020-07-28 16:47:09 -04:00
amkcpu
af7f24a305 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12707 - Add vertical scrollbar to search suggestions 2020-07-28 16:46:51 -04:00
Tiger Oakes
6bff47c3c5 [fenix] Test paged history provider 2020-07-28 12:35:34 -07:00
Jonathan Almeida
a48f4282b3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12856: Add save to collections button to Tabs Tray
Using the ConcatAdapter, we're now able to insert multiple data sources
of information into one RecyclerView and preserve layout/scrolling in
addition to adding the 'Save to Collection' button.
2020-07-28 11:14:08 -07:00
ekager
e15b895fd9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12992 - Hide tab close button while in multiselect mode 2020-07-28 11:10:45 -07:00
Hakkı Kaan Çalışkan
ffadbb4045 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12622: Visually indicate different types of suggestions in the search screen 2020-07-28 11:08:35 -07:00
Aaron Train
49d247d79c [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/13021: Fix verifyAboutFirefoxPreview UI test 2020-07-28 11:02:21 -07:00
Kainalu Hagiwara
0f81dae020 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13028 - Add feature flag for tab history. 2020-07-28 11:01:59 -07:00
Roger Yang
05675f9e94 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/12670: Add lastUri as a parameter in RequestInterceptor 2020-07-28 13:24:03 -04:00
Oana Horvath
63e3ec5c71 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12968: Re-enables Search settings tests (https://github.com/mozilla-mobile/fenix/pull/13020) 2020-07-28 09:22:46 -04:00
Jonathan Almeida
502a50bfa0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12983: Fix deep link scheme for nightly builds
When we simplified our variants, our deep link scheme for nightly was
lost.
2020-07-28 08:31:12 -04:00
Mozilla L10n Automation Bot
e8a2650d38 [fenix] Import l10n. 2020-07-27 21:05:00 -04:00
ekager
262650edb9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12991 - Set height to recommended touch target size for collect button 2020-07-27 20:17:48 -04:00
Elise Richards
0cf5fc6c53 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12571: Rename shortcuts to search engine on search screen (https://github.com/mozilla-mobile/fenix/pull/12839)
* Rename shortcuts to search engine on search screen

* Remove deprecated pref key

* Re-add deprecated string
2020-07-27 17:19:31 -05:00
Tiger Oakes
44a94f388f [fenix] Fix AccountUiView ui failures 2020-07-27 17:40:15 -04:00
Elise Richards
bc1cffe3a2 [fenix] Enable editing saved logins on all channels (https://github.com/mozilla-mobile/fenix/pull/12841) 2020-07-27 15:48:28 -05:00
Jeff Boek
42582369aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/2681 - Adds ability to bypass cache when reloading 2020-07-27 12:11:11 -07:00
Tiger Oakes
f3b7440063 [fenix] Extract navigation subgraphs 2020-07-27 15:04:28 -04:00
Tiger Oakes
233708b122 [fenix] Update LongParameterList baseline 2020-07-27 14:20:34 -04:00
Tiger Oakes
5f6b5090ae [fenix] For https://github.com/mozilla-mobile/fenix/issues/1146: Extract AccountUiView from settings 2020-07-27 21:05:47 +03:00
Tiger Oakes
d4ddb88f2a [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565 - Clean up controller and add tests 2020-07-27 10:40:09 -07:00
Mugurell
efa1351277 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12772 - Opt-out of scoped storage
Targeting Android 10 means we need to support scoped storage or we need to
opt-out of that using requestLegacyExternalStorage="true".

This patch adds the opting-out leaving investigations for what changes we need
for fully supporting scoped storage to be done in issue https://github.com/mozilla-mobile/fenix/issues/12822.
2020-07-27 10:39:47 -07:00
ekager
d7514bcf78 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6846: Added quick actions for nav bar in home 2020-07-27 13:28:28 -04:00
ekager
46a11849d2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12966 - Fixes session removal show home logic 2020-07-27 10:27:39 -07:00
Tiger Oakes
ad4476342b [fenix] Fix license on remaining files 2020-07-27 13:04:55 -04:00
Mihai Eduard Badea
3e5ceb23d5 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/12181 - Convert String to sentence case
Changed the string values capitalization to sentence case.
2020-07-27 12:31:13 -04:00
Kadeem M
a8f29e65c0 [fenix] Created UI tests for Addon Settings (https://github.com/mozilla-mobile/fenix/pull/9258) 2020-07-27 11:00:35 -04:00
ekager
76a7b37440 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/12954 - Remove all ConstraintLayout casts in SearchEngineListPreference 2020-07-27 09:49:43 -04:00
Oana Horvath
1748d2d012 [fenix] For: https://github.com/mozilla-mobile/fenix/issues/12894, https://github.com/mozilla-mobile/fenix/issues/12899, https://github.com/mozilla-mobile/fenix/issues/12968, https://github.com/mozilla-mobile/fenix/issues/11239, disables failing UI tests 2020-07-27 13:34:56 +03:00
Mihai Branescu
0507017605 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7716 - modified xml to let 'Learn more' button have min 48dp for a11y
Added a margin top of 20dp as well on the buttons so as not to change UI
2020-07-27 10:16:31 +03:00
ekager
1dbc00f08d [fenix] For https://github.com/mozilla-mobile/fenix/issues/12947 - Adjust tab selected state on bind 2020-07-25 20:07:30 -04:00
Tiger Oakes
a0f58194e2 [fenix] Add concept-menu dependency 2020-07-25 19:38:35 -04:00
ekager
180590e776 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12721 - Remove SessionManager usages in TabCounter 2020-07-25 18:37:45 -04:00
Hakkı Kaan Çalışkan
2dff66eee9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12929: Change cast to LinearLayout 2020-07-25 10:14:48 -04:00
Hakkı Kaan Çalışkan
9845637378 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12804: Set min height for search engine radio button 2020-07-24 22:10:24 -04:00
ekager
1ced27bda6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10163 - Adds tab multiselect mode 2020-07-24 18:18:26 -04:00
Jonathan Almeida
312addd8be [fenix] For https://github.com/mozilla-mobile/fenix/issues/10925: Fix breaking APIs in tabs tray 2020-07-24 16:52:06 -04:00
Tiger Oakes
2c08b342e8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12871 - Use local TWA DAL API (https://github.com/mozilla-mobile/fenix/pull/12872) 2020-07-24 13:08:24 -07:00
Kainalu Hagiwara
ee201255cc [fenix] For https://github.com/mozilla-mobile/fenix/issues/12880 - Pass a CoordinatorLayout to Snackbars created by the context menu. 2020-07-24 12:30:46 -07:00
Sawyer Blatz
fdf22f7e74 [fenix] No issue: fix master 2020-07-24 15:06:38 -04:00
ekager
a939f4ee8f [fenix] For https://github.com/mozilla-mobile/fenix/issues/12364 - Improve PWA onboarding timing logic 2020-07-24 14:43:28 -04:00
Sawyer Blatz
adc1813fd6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12793: Improve snackbars for tabs tray 2020-07-24 10:56:54 -07:00
Sawyer Blatz
6317a79222 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12791: Fix issue with undo snackbar last tab 2020-07-24 10:56:54 -07:00
Sawyer Blatz
b4a0e122d1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10997: Remove scrolling from home (https://github.com/mozilla-mobile/fenix/pull/12866) 2020-07-24 10:43:53 -07:00
Michael Comella
aff5a4f5c4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12345: replace Activity.reportFullyDrawnSafe with a-c impl. 2020-07-24 10:30:03 -07:00
Oana Horvath
d6ead0a749 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12893: Disables failing deleteAllHistoryTest (https://github.com/mozilla-mobile/fenix/pull/12902) 2020-07-24 11:47:59 -04:00
Oana Horvath
c286ebe55e [fenix] For https://github.com/mozilla-mobile/fenix/issues/12473: Disable failing verifyContextCopyLink (https://github.com/mozilla-mobile/fenix/pull/12891) 2020-07-24 10:29:22 -04:00
mcarare
ae809790c7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10026: Update scroll flags on a11y state change. 2020-07-24 10:35:33 +03:00
mcarare
38cb941da9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10026: Add a11y state listener to BaseBrowserFragment. 2020-07-24 10:35:33 +03:00
mcarare
dad550613d [fenix] For https://github.com/mozilla-mobile/fenix/issues/10026: Add Context extension to get AccessibilityManager. 2020-07-24 10:35:33 +03:00
Kainalu Hagiwara
559f83302e [fenix] For https://github.com/mozilla-mobile/fenix/issues/12868 - Fix tab counter menu snackbar position. 2020-07-23 18:30:04 -07:00
Sawyer Blatz
d63bd0b2e3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12430: Hide the mic when not using Google 2020-07-23 19:29:26 -04:00
Tiger Oakes
4037103a95 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565: Don't pass contest to SortingStrategy 2020-07-23 19:05:11 -04:00
Aaron Train
f0f972a053 [fenix] No issue: Fix recent UI test breakage (https://github.com/mozilla-mobile/fenix/pull/12869) 2020-07-23 14:17:54 -07:00
Tiger Oakes
0d37525151 [fenix] Migrate from Session.toTab to BrowserStore (https://github.com/mozilla-mobile/fenix/pull/12221) 2020-07-23 12:27:39 -07:00
Tiger Oakes
0d5d9631c1 [fenix] Add tests for some classes in home/browser (https://github.com/mozilla-mobile/fenix/pull/12837) 2020-07-23 11:17:52 -07:00
Tiger Oakes
d2d30f0e5e [fenix] Test sync adapter (https://github.com/mozilla-mobile/fenix/pull/12810) 2020-07-23 11:16:11 -07:00
Arturo Mejia
9f8851294b [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/11676: Features phone that doesn't a site permission exception shouldn't be shown (https://github.com/mozilla-mobile/fenix/pull/12855)
exception shouldn't be shown
2020-07-23 09:12:22 -07:00
Mozilla L10n Automation Bot
69d6c450c5 [fenix] Import l10n. 2020-07-23 10:40:10 +03:00
Tiger Oakes
bf4a7cd969 [fenix] Create ToolbarPosition enum (https://github.com/mozilla-mobile/fenix/pull/12747) 2020-07-22 19:23:38 -07:00
Jonathan Almeida
bb3e5bfbf9 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/11333: Set ContentBlocking settings directly on GeckoRuntime
We set the ContentBlockingSettings directly on the GeckoRuntime now to
improve the startup of the engine.

This change has requirements from Android Components and GeckoView, so
we would only see the full perf benefits in Nightly as the changes ride
the train, although we might start to see some of them as we're updating
the GeckoProvider for the `geckoBeta` variant as well.

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2020-07-22 16:28:18 -04:00
Kainalu Hagiwara
9153350cd2 [fenix] No issue - Fix compilation error caused by removed extension function. 2020-07-22 13:00:07 -07:00
Kainalu Hagiwara
d4d68f2b77 [fenix] Fix UI tests.
We need to pass a CoordinatorLayout instead of a SwipeGestureLayout to
FenixSnackbar.make() in BaseBrowserFragment to prevent UI tests from
breaking. We also need to remove a few view IDs from the tab preview.
2020-07-22 11:26:15 -07:00
Kainalu Hagiwara
a6a8c4dc08 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3481 - Implement swipe on toolbar to switch tabs. 2020-07-22 11:26:15 -07:00
Mozilla L10n Automation Bot
d85e95f6b8 [fenix] Import l10n. 2020-07-22 11:25:16 -07:00
Kainalu Hagiwara
9d3f8a7e0f [fenix] For https://github.com/mozilla-mobile/fenix/issues/1048 - Add ability to view tab history by long-pressing the back or forward button. 2020-07-22 11:20:47 -07:00
Hakkı Kaan Çalışkan
082cddf7d8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12571: Rename 'Shortcuts' to 'Search engines'
Co-Authored-By: Khushraj Rathod <khushrajrathod@gmail.com>
2020-07-22 11:05:04 -07:00
Tiger Oakes
75817b004c [fenix] Use AC RunWhenReadyQueue (https://github.com/mozilla-mobile/fenix/pull/12800) 2020-07-22 09:48:36 -07:00
Tiger Oakes
fb7c801b38 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12801 - Extra debug menu trigger, disable if already triggered 2020-07-22 19:28:48 +03:00
Jonathan Almeida
1df7dce5d0 [fenix] Update to Android Components 52.0.20200722023149
Fixes breaking APIs in SyncedTabsFeature and
BookmarksStorageSuggestionProvider
2020-07-22 10:52:14 -04:00
Michael Comella
67d1e5f935 [fenix] No issue: add missing newline. 2020-07-21 15:52:34 -07:00
Michael Comella
e84b6e82e8 [fenix] No issue: clean up initVisualCompletenessQueue... method.
A no-op clean up.
2020-07-21 15:52:34 -07:00
Michael Comella
032ca003cd [fenix] No issue: extract initVisualCompletenessQueueAndQueueTasks.
This refactor, done entirely by IDE, is a no-op cleanup.
2020-07-21 15:52:34 -07:00
Michael Comella
1f65ba446e [fenix] No issue: extract startMetricsIfEnabled function.
This refactor, done entirely by IDE, is a no-op clean-up of this file.
2020-07-21 15:52:34 -07:00
Jeff Boek
b2d6f5746b [fenix] For https://github.com/mozilla-mobile/fenix/issues/12806 - Adds unit tests to cover ToolbarView.update() (https://github.com/mozilla-mobile/fenix/pull/12807) 2020-07-21 14:34:07 -07:00
Jonathan Almeida
758f0b0b96 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12797: Use measured height/width for loading a thumbnail
Using `onNextLayout` has the side-effect of showing the thumbnail with
the tab.id from a recycled view.

The root cause of needing that call is to retrieve the measured
height/width from the view first before requesting. A simpler solution
to avoid the complexity is to retrieve these values from the dimen
resources.

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2020-07-21 16:38:49 -04:00
Sawyer Blatz
a48f1f8591 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12461: Update content description for tabs tray open tab count 2020-07-21 15:48:38 -04:00
Sebastian Kaspari
8de62c28cf [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/7877: Add SearchActionProvider for faster responses that mirror entered text. 2020-07-21 14:41:00 -04:00
Tiger Oakes
adbadba250 [fenix] Move settings in components (https://github.com/mozilla-mobile/fenix/pull/12675) 2020-07-21 10:47:10 -07:00
Mihai Eduard Badea
130de798fb [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/12387 - Display tab tray using .show
Replaced the global navigation action used for displaying the tab tray with the .show() function.
2020-07-21 10:31:24 -07:00
mcarare
2320c617b2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9722: Refactor onboarding buttons with text.
Add title and description to button text, remove extra Textviews.
2020-07-21 10:28:45 -07:00
Tiger Oakes
ef885fe482 [fenix] Add tests for web push integration 2020-07-21 10:12:06 -07:00
mcarare
5ddf809ee8 [fenix] For android-l10n https://github.com/mozilla-mobile/fenix/pull/241: Mark a11y link type as not translatable. 2020-07-21 17:59:17 +03:00
Johan Lorenzo
13e8560acf [fenix] Bug 1652979 - Stop producing fennecNightly, fenixNightly and fenixBeta (https://github.com/mozilla-mobile/fenix/pull/12225) 2020-07-21 16:42:08 +02:00
TejaswiKarasani
00cd8b8f35 [fenix] No issue: verify ETP toolbar shield icon is not displayed if ETP is OFF globally in ETP UI tests (https://github.com/mozilla-mobile/fenix/pull/12623) 2020-07-21 09:33:06 -04:00
Oana Horvath
82a76042d9 [fenix] Fix UI tests from https://github.com/mozilla-mobile/fenix/issues/12752 https://github.com/mozilla-mobile/fenix/issues/12637 https://github.com/mozilla-mobile/fenix/issues/12764 (https://github.com/mozilla-mobile/fenix/pull/12779)
* For https://github.com/mozilla-mobile/fenix/issues/12752 & https://github.com/mozilla-mobile/fenix/issues/12764: Fixes tabs tray behavior in UI tests

* For https://github.com/mozilla-mobile/fenix/issues/12637: fixes goBackTest
2020-07-21 08:49:24 -04:00
Tiger Oakes
3bccc0dd50 [fenix] Pass settings and metrics to CFR 2020-07-21 09:01:09 +03:00
mozilla-l10n-automation-bot
72e6448a1d [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/12766) 2020-07-20 18:26:00 -07:00
Richard Pappalardo
41bb2cb087 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/12752, https://github.com/mozilla-mobile/fenix/issues/12764 - Temp disable openHistoryInNewTabTest intermittent UI test failures (https://github.com/mozilla-mobile/fenix/pull/12754)
* Fixes https://github.com/mozilla-mobile/fenix/issues/12752 - Temp disable intermittent failing test
2020-07-20 18:09:01 -07:00
Kainalu Hagiwara
5a895d6125 [fenix] No issue - Suppress new warnings from detekt update 2020-07-20 17:01:50 -07:00
Sawyer Blatz
de6145c967 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12461: Add tab count to tab tray 2020-07-20 19:16:47 -04:00
Tiger Oakes
712dce391d [fenix] For https://github.com/mozilla-mobile/fenix/issues/5499 - Unify CFR drawables and dimens (https://github.com/mozilla-mobile/fenix/pull/12749) 2020-07-20 16:00:57 -07:00
Hakkı Kaan Çalışkan
898defc3a2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12532: Quick fix for radio button alignment (https://github.com/mozilla-mobile/fenix/pull/12691) 2020-07-20 15:33:32 -07:00
Kainalu Hagiwara
3320f82bfb [fenix] For https://github.com/mozilla-mobile/fenix/issues/12551 - Implement swipe to delete for bookmarks. 2020-07-20 14:54:20 -07:00
Kainalu Hagiwara
0671fc50e8 [fenix] Rename tab_tray_background.xml 2020-07-20 14:54:20 -07:00
Michael Comella
e85dd6a09c [fenix] No issue: correct position of StartupTimeline; add warning. 2020-07-20 14:27:41 -07:00
Sawyer Blatz
80b4fb0808 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10466: Add search privately to top of list (https://github.com/mozilla-mobile/fenix/pull/12744) 2020-07-20 13:25:36 -07:00
Tiger Oakes
5b7d951590 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/10924 - Cleanup SavedLoginsAuthFragment (https://github.com/mozilla-mobile/fenix/pull/10930) 2020-07-20 13:25:24 -07:00
Kainalu Hagiwara
055620f117 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12730 - Fix ripple for font size setting. 2020-07-20 13:00:59 -07:00
Sawyer Blatz
d8ecc2e19c [fenix] For https://github.com/mozilla-mobile/fenix/issues/11851: Close tab tray when last tab closed (https://github.com/mozilla-mobile/fenix/pull/12615) 2020-07-20 11:05:32 -07:00
ekager
b8b3d8b367 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10784 - Fixes memory leak in BrowserAnimator 2020-07-20 13:50:18 -04:00
Sawyer Blatz
54a6de9b84 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12735: Fixes issue with tab deletion undo (https://github.com/mozilla-mobile/fenix/pull/12737) 2020-07-20 10:48:16 -07:00
Hakkı Kaan Çalışkan
197a076ef2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12554: Helper class for password reveal on logins 2020-07-20 13:45:46 -04:00
mozilla-l10n-automation-bot
24f19cd763 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/12687) 2020-07-19 21:30:11 -07:00
Christian Sadilek
250c95eb28 [fenix] Update Android Components to 51.0.20200717190031 2020-07-17 19:32:02 -04:00
Tiger Oakes
e740819acd [fenix] Fix lint issues (https://github.com/mozilla-mobile/fenix/pull/12683) 2020-07-17 16:20:08 -07:00
Tiger Oakes
cb59729010 [fenix] Change enabled lint rules (https://github.com/mozilla-mobile/fenix/pull/12517) 2020-07-17 15:17:16 -07:00
Tiger Oakes
25a5f478ef [fenix] Test migration classes (https://github.com/mozilla-mobile/fenix/pull/12677) 2020-07-17 14:35:13 -07:00
Tiger Oakes
a7bbc86f4a [fenix] Add tests for login exceptions (https://github.com/mozilla-mobile/fenix/pull/12681) 2020-07-17 14:25:45 -07:00
Tiger Oakes
5c9876dcff [fenix] Fix failure in handleWhatsNewGetAnswersClicked (https://github.com/mozilla-mobile/fenix/pull/12682) 2020-07-17 14:25:35 -07:00
Mihai Adrian Carare
3823c632ac [fenix] For https://github.com/mozilla-mobile/fenix/issues/7966: Update toolbar content description. (https://github.com/mozilla-mobile/fenix/pull/12667) 2020-07-17 16:22:13 -05:00
Elise Richards
508854ea07 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12532: Align Settings -> Site permissions -> Sub-pages to 72dp keyline (https://github.com/mozilla-mobile/fenix/pull/12680)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-17 15:54:57 -05:00
Mihai-Eduard Badea
65c98d6c16 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9949 - Bookmarks/History deletion inconsistencies (https://github.com/mozilla-mobile/fenix/pull/12630)
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.

 - Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in https://github.com/mozilla-mobile/fenix/issues/8648.

Co-authored-by: Mihai Eduard Badea <mihai.badea@softvision.ro>
2020-07-17 15:13:18 -05:00
Tiger Oakes
549acfa6f1 [fenix] Test session control controller (https://github.com/mozilla-mobile/fenix/pull/12652) 2020-07-17 13:07:01 -07:00
Hakkı Kaan Çalışkan
415bbf6574 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12509: Set height of remove add on button to 36dp 2020-07-17 12:55:36 -07:00
ekager
f7f80ad6cb [fenix] Update ContextMenuUseCases to just take a store 2020-07-17 14:49:10 -04:00
ekager
2deadc2e22 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12453 - Sets secure flags on private tab of tabs tray 2020-07-17 13:24:25 -04:00
ekager
bc08df1c8f [fenix] For https://github.com/mozilla-mobile/fenix/issues/12364 - Only show PWA prompt the third time a user visits installable site 2020-07-17 12:37:03 -04:00
Tiger Oakes
ded7cde177 [fenix] Add tests for adapters in collections (https://github.com/mozilla-mobile/fenix/pull/12649) 2020-07-17 09:04:16 -07:00
Kainalu Hagiwara
46a9bba6e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12531: Align Settings -> Private browsing to 72dp keyline (https://github.com/mozilla-mobile/fenix/pull/12654)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-16 22:26:49 -07:00
Elise Richards
5b46f572df [fenix] For https://github.com/mozilla-mobile/fenix/issues/10173: login duplicates and save (https://github.com/mozilla-mobile/fenix/pull/11208)
* Extract controller into it's own class. Implement find dupes and filter based on username.

Create edit login controller. Add text watchers and check for duplicates.

Edit controller test

* Find duplicates and save to store

* Retrieve duplicates from AC and check list on username text changed

Move duplicates logic into the controller

* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.

* Use correct threads in controller. Enable save button when applicable.

Save enabled in datastore.

Move login data to datastore

Rebase with password error states

Update metrics to be more specific for edit

* Create logins controller for AC calls

* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.

Inflate view in edit fragment. Double layout showing up.

Edit view

Controller tests

Controller tests passing

Interactor tests

Lint and detekt cleanup

* Remove datastore and use storage controller for all logins calls to password storage.

Addressed comments

Lint
:

Rebase - 1
2020-07-16 17:08:04 -05:00
Tiger Oakes
046682f889 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12457: Add MockK matcher for intents (https://github.com/mozilla-mobile/fenix/pull/12612) 2020-07-16 15:05:01 -07:00
Mugurell
ac85ba0945 [fenix] Ensure logins deletion (https://github.com/mozilla-mobile/fenix/pull/12507)
* For https://github.com/mozilla-mobile/fenix/issues/11227 - Cleanup saved logins list when one is selected

Selecting a saved login will open a detail screen for it from where users can
change details or even delete that particular login.
After the change is made the user is brought back to the list of saved logins
where for a brief moment (< 1s) until we get a new response from
passwordsStorage.list() the user can see and even interact with the old list
of items, which may still contain the just deleted one.

To avoid users seeing obsolete logins or even interacting with them (selecting
a previosuly deleted item will result in a crash) we will clean the list of
logins just before the selected login is opened in the detailed view.
When returning for a brief moment the users may see the "loading" UX until
passwordsStorage.list() returns the up-to-date list of logins to display.

* For https://github.com/mozilla-mobile/fenix/issues/11227 - Refactor SavedLoginsView to be closer to MVI

- Interactors should only get passed other Interactors or Controllers as
dependencies to which they should delegate user actions.
- Controllers should hold most of the business logic and get passed all final
dependencies they need to do their job.
2020-07-16 14:40:08 -05:00
Tiger Oakes
2a7e8f7adb [fenix] Add tests for sync, wifi, and push (https://github.com/mozilla-mobile/fenix/pull/12581) 2020-07-16 12:25:38 -07:00
Tiger Oakes
fe5b219a89 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565: Add Locale settings tests & use activity (https://github.com/mozilla-mobile/fenix/pull/12579) 2020-07-16 11:43:27 -07:00
jhugman
773884bdc4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12600 - remove AddonInstalled event when the permission dialog is shown (https://github.com/mozilla-mobile/fenix/pull/12601) r=csadilek,sblatz 2020-07-16 19:40:39 +01:00
Mihai Branescu
582fc2cff7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12201 - forced callbacks to be on the main thread (https://github.com/mozilla-mobile/fenix/pull/12543) 2020-07-16 13:39:31 -05:00
Elise Richards
fc847d79e7 [fenix] No issue: Delete unnecessary to-dos (https://github.com/mozilla-mobile/fenix/pull/12603)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-16 13:38:07 -05:00
Hakkı Kaan Çalışkan
ad239ff1ae [fenix] No issue: Move dp's to dimens.xml 2020-07-16 13:08:55 -04:00
Kainalu Hagiwara
ce7ba9a2ac [fenix] Update TabTrayViewHolder with A-C thumbnail changes. 2020-07-16 12:50:33 -04:00
Roger Yang
be3ce6e2ba [fenix] For https://github.com/mozilla-mobile/fenix/issues/12118: Add isSubframeRequest parameter for app links 2020-07-16 12:50:33 -04:00
Christian Sadilek
4c49410910 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12248: Webcompat reporter not active in Nightly 2020-07-16 12:24:21 -04:00
jhugman
6a7a29fc61 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11704 Add leanplum attributes for tracking protection (https://github.com/mozilla-mobile/fenix/pull/11965) r=sblatz
* For 11657: add LP attribute for tracking protection

* For https://github.com/mozilla-mobile/fenix/issues/11704: added tracking_protection_enabled attribute

* Added docs for the new attributes, linking to data-review to the mma.md

* Rename null to none when no ETP is enabled
2020-07-16 17:09:32 +01:00
Hakkı Kaan Çalışkan
ab317dc779 [fenix] No issue: Uncomment forgotten assert 2020-07-16 11:45:53 -04:00
Tiger Oakes
82d1b4380d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/12493: Remove kapt plugin 2020-07-16 10:38:03 -04:00
Hakkı Kaan Çalışkan
8645075a39 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12105: Follow ux mock on Settings --> Accessibility screen 2020-07-16 10:37:20 -04:00
James Hugman
61fe76774f [fenix] Address review comments 2020-07-16 10:37:03 -04:00
James Hugman
800e55e69a [fenix] Remove need to specify component names for new intents 2020-07-16 10:37:03 -04:00
James Hugman
648b389a68 [fenix] Changed home_* style links to urls_* to reflect that the destination is a set of links, rather than where the screen is 2020-07-16 10:37:03 -04:00
James Hugman
8e7c9bf003 [fenix] Add install_search_widget 2020-07-16 10:37:03 -04:00
James Hugman
83ed39ed5c [fenix] Add UI tests for deep links 2020-07-16 10:37:03 -04:00
James Hugman
dc588ca0ae [fenix] Add unit tests for deep links 2020-07-16 10:37:03 -04:00
James Hugman
bc397268a6 [fenix] Add deep links for settings and home screens 2020-07-16 10:37:03 -04:00
isabelrios
18b3fb95b4 [fenix] cron-job-ui-screenshots (https://github.com/mozilla-mobile/fenix/pull/12423)
Co-authored-by: isabel rios <isabelrios@MacBook-Pro-de-isabel-2.local>
2020-07-16 16:08:00 +02:00
Mugurell
85e05cb841 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12544 - Prevent search engines mixup
Stricter synchronization by always using the same "loadedSearchEngines"
variable.
With "loadedSearchEngines" calling "refreshAsync()" we also get the fallback
engines to contain reddit and youtube (which are programatically added) and
also now we properly remember and display the engines added by user.
2020-07-16 16:49:54 +03:00
Oana Horvath
70e30dcf98 [fenix] Replaces verifyPageContent in UI tests 2020-07-16 10:55:58 +03:00
Tiger Oakes
65402a62dd [fenix] Add tests for StartupReportFullyDrawn (https://github.com/mozilla-mobile/fenix/pull/12560) 2020-07-15 23:31:59 -07:00
Tiger Oakes
c1a74cc939 [fenix] Add helper for underlining text (https://github.com/mozilla-mobile/fenix/pull/12520) 2020-07-15 22:38:46 -07:00
Tiger Oakes
2e8da8abe0 [fenix] Fix nav graph and theme tests (https://github.com/mozilla-mobile/fenix/pull/12567) 2020-07-15 18:04:36 -07:00
Tiger Oakes
034a9dae8f [fenix] Update Kotlin dependency (https://github.com/mozilla-mobile/fenix/pull/10806) 2020-07-15 18:02:58 -07:00
mcarare
1efe17c801 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12503: Add unit tests for permissions details view. 2020-07-15 10:04:40 -04:00
mcarare
bfd879be4a [fenix] For https://github.com/mozilla-mobile/fenix/issues/12503: Open addon permissions link in app. 2020-07-15 10:04:40 -04:00
Aaron Train
d60d77248b [fenix] No issue: Add a couple Tabs Tray UI tests 2020-07-15 10:49:34 +03:00
ekager
772f69c5f5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7094 - Adds save login exceptions 2020-07-14 14:47:37 -04:00
Tiger Oakes
09c37671a8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12457 - Add MockK matcher for nav directions (https://github.com/mozilla-mobile/fenix/pull/12262) 2020-07-14 10:39:23 -07:00
Tiger Oakes
431459d181 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12171: Use one-line logo in Nightly (https://github.com/mozilla-mobile/fenix/pull/12555) 2020-07-14 10:37:01 -07:00
Tiger Oakes
d9e7a351fa [fenix] Add tests for search (https://github.com/mozilla-mobile/fenix/pull/12437) 2020-07-14 10:32:04 -07:00
Tiger Oakes
afd8eafd9f [fenix] Test viewholders in home.sessioncontrol (https://github.com/mozilla-mobile/fenix/pull/12524) 2020-07-14 10:31:50 -07:00
Hakkı Kaan Çalışkan
e83a7f3370 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12107: Follow ux mock on Settings --> Account screen 2020-07-14 12:25:21 +03:00
Mozilla L10n Automation Bot
2d97e98f58 [fenix] Import l10n. 2020-07-14 11:40:19 +03:00
ekager
9c0e356950 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11099 For https://github.com/mozilla-mobile/fenix/issues/12189 For https://github.com/mozilla-mobile/fenix/issues/7532 - Clean up bottom navigation bar colors 2020-07-13 13:46:35 -04:00
Sawyer Blatz
ca02217039 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10466: Put call & email at top of context list 2020-07-13 10:33:55 -07:00
Hakkı Kaan Çalışkan
c332cc631e [fenix] For https://github.com/mozilla-mobile/fenix/issues/12106: Follow ux mock on Settings --> Logins screen 2020-07-13 11:14:32 -04:00
Oana Horvath
0885d0047e [fenix] For https://github.com/mozilla-mobile/fenix/issues/10911: disables flaky createBookmarkFolderTest 2020-07-13 15:40:50 +03:00
Mugurell
66fdc14386 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11875 - Prevent mixup of region / locale based search engines
We have two search engine types:
- one based on MLS reported region,
- one based only on Locale.

There are multiple steps involved in returning the default search engine for
example and though at each step we could verify if a certain operation is
completed we are still exposed to concurrency issues.
Simplest and most effective way to make sure the MLS engines do not mix with
Locale based engines is to use the same type of engines for the entire duration
of the app. At the next cold start we'll verify again which engines to use.

Using the Locale based engines (fallbacks) is expected to only happen once, at
the first run of the application after being installed.
2020-07-13 13:41:34 +03:00
Mozilla L10n Automation Bot
73fbb27808 [fenix] Import l10n. 2020-07-13 07:59:10 +03:00
jhugman
de6a9cf93b [fenix] For https://github.com/mozilla-mobile/fenix/issues/11655: add leanplum event for installing an addon (https://github.com/mozilla-mobile/fenix/pull/12136) r=elise
* For https://github.com/mozilla-mobile/fenix/issues/11655: add leanplum event for installing an addon

* Add link to data-review request in PR

* Addressed CI comments
2020-07-12 23:47:34 +01:00
Grisha Kruglov
1278ca374c [fenix] Synced Tabs: make sure to stop 'loading' when we encounter an error 2020-07-10 19:02:55 -07:00
Tiger Oakes
291c3196ee [fenix] Fix Robolectric tests SDK version (https://github.com/mozilla-mobile/fenix/pull/12464) 2020-07-10 17:21:10 -07:00
ekager
fade6c7936 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11324 - Adds trash icon to swipe to delete 2020-07-10 20:16:57 -04:00
Michael Comella
03b8068cd2 [fenix] No issue - post: mock profiler object in DefaultTabTrayControllerTest.
Without this line, the tests fail when running the full suite (but not
this test in isolation, for some reason).
2020-07-10 16:43:06 -07:00
Nazım Can Altınova
5a1c31e13f [fenix] Add profiler markers for HomeActivity.load and DefaultTabTrayController.onNewTabTapped 2020-07-10 16:43:06 -07:00
Sawyer Blatz
bdcd04cc6a [fenix] Update app/src/main/java/org/mozilla/fenix/HomeActivity.kt
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
2020-07-10 18:44:14 -04:00
Sawyer Blatz
33ea9d02aa [fenix] No issue: Update AC version 2020-07-10 18:44:14 -04:00
Michael Comella
2a3a343393 [fenix] For perf-frontend-issueshttps://github.com/mozilla-mobile/fenix/issues/44: add local property to autosign release builds. 2020-07-10 10:55:32 -07:00
Mihai Eduard Badea
a9c19cbcf5 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/12339 - Collection delete dialog string update
Set the collection delete dialog title text to "Delete %1$s?"
2020-07-10 11:38:39 -04:00
Mozilla L10n Automation Bot
03185f680a [fenix] Import l10n. 2020-07-09 21:39:49 -04:00
Grisha Kruglov
d76815b9ca [fenix] For https://github.com/mozilla-mobile/fenix/issues/12433 - Allow synced tabs pull-to-refresh for non-critical account errors 2020-07-09 16:18:54 -07:00
ekager
ddf56f9bc6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11303 - Change copy login origin to open in browser 2020-07-09 18:09:41 -04:00
Tiger Oakes
e69b1e06f1 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/9832 - Change targetSdkVersion to Android 10 (https://github.com/mozilla-mobile/fenix/pull/11014) 2020-07-09 10:50:51 -07:00
Emily Kager
2eaef29243 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12010: Follow ux mock on Settings --> ETP --> Info screen (https://github.com/mozilla-mobile/fenix/pull/12429)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-09 09:47:09 -07:00
Sebastian Kaspari
f3cfdc5058 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/12311: BrowserToolbarController: Stop SessionFeature and release session from EngineView. 2020-07-09 12:36:56 -04:00
TejaswiKarasani
47e60525ff [fenix] No Issue: Verify the page main menu items UI Test (https://github.com/mozilla-mobile/fenix/pull/12336) 2020-07-09 09:15:10 -07:00
Mozilla L10n Automation Bot
869c91048a [fenix] Import l10n. 2020-07-09 11:29:38 -04:00
David Walsh
940bc85996 [fenix] For 11889 - Fix snackbar for collection creation in browser fragment 2020-07-09 08:50:12 +03:00
mozilla-l10n-automation-bot
1f3c3966fb [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/12404) 2020-07-08 18:56:37 -07:00
Hakkı Kaan Çalışkan
cfb8cac9a3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11563: Set ic_close.xml to use full width and height 2020-07-08 17:21:25 -04:00
ekager
16132f2c5d [fenix] For https://github.com/mozilla-mobile/fenix/issues/11431 - Scroll to restored tab in tab tray 2020-07-08 17:18:16 -04:00
Christian Sadilek
bcb49d3985 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12353: URL copied to clipboard should not be extension/reader URL 2020-07-08 16:55:32 -04:00
Tiger Oakes
5406f2cafb [fenix] Add tests for exceptions 2020-07-08 15:52:37 -04:00
MickeyMoz
d0e3833d3b [fenix] Update Android Components version to 50.0.20200708130551. 2020-07-08 12:44:51 -04:00
isabelrios
d1582d892a [fenix] No issue: Update screenshots test (https://github.com/mozilla-mobile/fenix/pull/12348) 2020-07-08 12:20:34 -04:00
Tiger Oakes
d8847824a9 [fenix] Add tests for onboarding viewholders (https://github.com/mozilla-mobile/fenix/pull/11522) 2020-07-08 07:53:22 -07:00
Richard Pappalardo
0e434d53ee [fenix] fix: disable intermittent test failure 2020-07-08 12:21:25 +03:00
Tiger Oakes
9d875c7cca [fenix] Add tests for browser helper classes (https://github.com/mozilla-mobile/fenix/pull/12370) 2020-07-07 19:46:25 -07:00