Michael Comella
a60e4e9d1f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6464 : Add ReleaseChannel test to document assumptions.
2019-12-30 10:31:33 -08:00
Michael Comella
1336ec98b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6464 : Add ReleaseChannel.isDebug.
2019-12-30 10:31:33 -08:00
Severin Rudie
484d552c60
[fenix] For 5334: test NotificationSessionObserver
2019-12-30 11:40:07 +02:00
Severin Rudie
5d33e79c59
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5334 : disable notification for private custom tabs
2019-12-30 11:40:07 +02:00
Richard Pappalardo
429ad5d0d6
[fenix] Temp disable UI test verifyAboutFirefoxPreview ( https://github.com/mozilla-mobile/fenix/pull/7390 )
2019-12-27 15:46:55 -08:00
Sawyer Blatz
3edfeb2731
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7000 : Fix inverted media telemetry ( https://github.com/mozilla-mobile/fenix/pull/7368 )
2019-12-27 13:46:47 -08:00
Severin Rudie
691676a27b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7352 : integrate highlightable browser menu changes ( https://github.com/mozilla-mobile/fenix/pull/7353 )
...
* For https://github.com/mozilla-mobile/fenix/issues/7352 : integrate highlightable browser menu changes
* For 7352: invalidate menu when reader mode availability changes
* For 7352: removed highlight from reader mode appearance per UX
2019-12-27 12:15:21 -08:00
Kadeem M
78a599b06e
[fenix] Added UI tests for the About Settings page ( https://github.com/mozilla-mobile/fenix/pull/6161 )
2019-12-27 07:55:35 -08:00
isabelrios
7aa2fd8263
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5074 - Add UI tests for logins and passwords setting menu ( https://github.com/mozilla-mobile/fenix/pull/7291 )
...
* For https://github.com/mozilla-mobile/fenix/issues/5074 - Add UI tests for logins and passwords setting menu
* fix detekt failure
* remove old file
* fix scroll small screens
* fix reviewer comments
2019-12-26 14:22:40 -08:00
Sawyer Blatz
70a7a685f1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7347 : Fixes background of search field
2019-12-23 10:07:54 -08:00
Sawyer Blatz
a5f8a5b415
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6666 : Adds back button to search screen
2019-12-23 10:07:02 -08:00
Mihai Adrian
b783691de8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7122 Fix icons for saved logins screen ( https://github.com/mozilla-mobile/fenix/pull/7268 )
2019-12-23 12:46:52 -05:00
Suraj Shah
320b5a0d05
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7041 - Respect current mode when opening library items ( https://github.com/mozilla-mobile/fenix/pull/7311 )
...
* Fixes https://github.com/mozilla-mobile/fenix/issues/7041
Consumes `browserMode` from home activity for tap method of bookmark
* Fixes spaces
* Cleaning tests
* Cleaning tests
2019-12-23 12:26:47 -05:00
mozilla-l10n-automation-bot
225ed1f615
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/7009 )
2019-12-20 14:01:18 -05:00
Roger Yang
5ae8bc6f0a
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7156 : Update app links feature usage to include app links interceptor ( https://github.com/mozilla-mobile/fenix/pull/7275 )
2019-12-20 08:27:19 -05:00
Richard Pappalardo
57679f7d4d
[fenix] Temp disable flaky UI testDownloadPrompt ( https://github.com/mozilla-mobile/fenix/pull/7304 )
2019-12-20 10:31:43 +02:00
Josh
c1606de6d7
[fenix] Fix parameterized message in search engine ( https://github.com/mozilla-mobile/fenix/pull/7302 )
2019-12-20 10:27:05 +02:00
Jeff Boek
16d3a71d3d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5334 - Override custom tab styling in private mode ( https://github.com/mozilla-mobile/fenix/pull/7305 )
2019-12-19 18:17:52 -08:00
Josh
1249b4a5ca
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7254 - Replace Anko applyConstraintSet ( https://github.com/mozilla-mobile/fenix/pull/7286 )
...
* For https://github.com/mozilla-mobile/fenix/issues/7254 : Replace anko applyConstraintSet
* Anko has been deprecated and will not be continued
* Refactor ConstraintSet changes
* Replace applyConstraintSet in SearchLayouts
* Refactor HomeFragment ConstraintSet
* Define anonymous ConstraintSet
* Remove ConstraintSet prefix from PARENT_ID
2019-12-19 18:16:50 -08:00
Mihai Adrian
a16ebd937e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6992 , for https://github.com/mozilla-mobile/fenix/issues/6897 , for https://github.com/mozilla-mobile/fenix/issues/6889 : Disable multitouch in app ( https://github.com/mozilla-mobile/fenix/pull/6999 )
2019-12-19 19:32:47 -05:00
Tiger Oakes
3c0ff1b69c
[fenix] Clean up settings fragments
2019-12-19 14:29:28 -08:00
Josh Vocal
934cb1f4ed
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7253 - Replace anko setters
2019-12-19 13:42:50 -08:00
Jeffrey Starke
1bdda56989
[fenix] Consolidate duplicate mock initialization in intent processor tests. ( https://github.com/mozilla-mobile/fenix/pull/6374 )
...
* Consolidate duplicate code in intent processor tests
* Resolve ktlint errors
2019-12-19 12:33:59 -05:00
Mihai Adrian
76e063ad48
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3574 Allow all screen readers to read onboarding items one-by one ( https://github.com/mozilla-mobile/fenix/pull/7292 )
2019-12-19 09:53:53 -05:00
Tiger Oakes
8b2eb8fd5f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7085 - Remove anko px2dip ( https://github.com/mozilla-mobile/fenix/pull/7252 )
2019-12-19 00:05:51 -08:00
Tiger Oakes
999e8d222f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/768 - Add PWA install option to menu ( https://github.com/mozilla-mobile/fenix/pull/6882 )
2019-12-18 23:59:30 -08:00
mcarare
1ad17245f8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6709 , for https://github.com/mozilla-mobile/fenix/issues/6849 Handle default engine deletion and undo operation
...
Uninstall engine immediately and allow reinstall in onCancel.
Set previous list with default engine in onCancel.
Keep default engine change in operation and remove now unnecessary view refresh.
2019-12-18 23:00:42 -08:00
Tiger Oakes
59345e3bee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7183 - Fix bottom margin in PWAs
2019-12-18 22:57:54 -08:00
Rushab Kumar
d679cf7378
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7250 - Replace anko.dimen
2019-12-18 15:39:14 -08:00
Sebastian Kaspari
4c5e3996dc
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4978 : Reuse widget package name of Fennec.
2019-12-18 15:23:43 -08:00
Emily Kager
5b332811da
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7219 - Polish Download Notification Dialog. ( https://github.com/mozilla-mobile/fenix/pull/7224 )
...
* For https://github.com/mozilla-mobile/fenix/issues/7219 - Use accent color for downloads dialog positive button
* For https://github.com/mozilla-mobile/fenix/issues/7219 - Fixes gap beneath download notification dialog
* switch to setimageresource
2019-12-18 12:26:41 -05:00
Roger Yang
c0588dcd90
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7260 : Pass in GeckoView version information to MozillaSocorroservice
2019-12-18 10:45:57 +01:00
Grisha Kruglov
47f40dbf7e
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6937 : Disable runStorageMaintenance during startup
...
This call will acquire a "write" lock at the storage layer (sqlite's reserved+),
which may interfere with migrations that run during startup as well (they need to
write to storage, and so also need to acquire a lock). If these operations clash,
we get a SQLITE_BUSY crash. For now, just disable the maintenance operation.
2019-12-17 14:24:30 -08:00
Tiger Oakes
a752ecd79b
[fenix] Split out CustomTabToolbarIntegration ( https://github.com/mozilla-mobile/fenix/pull/7107 )
2019-12-17 12:26:46 -08:00
David Walsh
6f39a70d04
[fenix] Use localized strings in the quick settings panel ( https://github.com/mozilla-mobile/fenix/pull/7249 )
2019-12-17 10:47:21 -08:00
Colin Lee
fbe4ebc5d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4064 : Update R8/ProGuard config for new Kotlin coroutines library ( https://github.com/mozilla-mobile/fenix/pull/7218 )
2019-12-17 10:41:54 -06:00
Sebastian Kaspari
e91ad0086c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4976 : Use dynamic launcher entry in manifest.
2019-12-17 16:00:15 +01:00
Suraj Shah
c634d89cd4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7048 : Network info migration ( https://github.com/mozilla-mobile/fenix/pull/7091 )
...
* Fixes https://github.com/mozilla-mobile/fenix/issues/7048 .
Adds extension function to check if online or not based on capabilities
Modified `buildDeviceList`
Modifies tests
* Fixing lint error for max length
Fixing test in AppRequestInterceptorTest.kt
* Adds suppression for deprecation
Moving away from using anko for ConnectivityManager instance
* Creates ConnectivityManager extension component
* Fixes https://github.com/mozilla-mobile/fenix/issues/7180
Refactors test cases to fix static mocks
2019-12-16 22:03:11 -08:00
David Walsh
4fada3f5be
[fenix] Fix 5366 - Use VectorDrawableCompat for all imagery ( https://github.com/mozilla-mobile/fenix/pull/7221 )
...
* Fix 5366 - Use VectorDrawableCompat for all imagery
* Fix detekt lint issues
* Restore previous comment contents
2019-12-16 20:35:36 -08:00
Severin Rudie
863dcf72ab
[fenix] For 6795: expands toolbar whenever a new session is selected
...
This ensures that the bar is expanded when opening a link in a new tab
2019-12-16 14:09:29 -08:00
Jeff Boek
8d4a944920
[fenix] No Issue - Removes some search engines
2019-12-16 14:09:14 -08:00
mcarare
1531cfd558
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7194 Set snackbar anchor depending on browser toolbar position
2019-12-16 12:21:54 -08:00
Aaron Train
9b77b65e69
[fenix] No issue: Fixes breakage with unused import in 71e8063 ( https://github.com/mozilla-mobile/fenix/pull/7205 )
2019-12-16 11:55:44 -05:00
Aaron Train
f9e3b21578
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6697 : Add Tracking Protection UI Tests ( https://github.com/mozilla-mobile/fenix/pull/6825 )
...
Add tests for verifying basic UI functionality of Enhanced Tracking Protection
2019-12-16 10:12:43 -05:00
Patrick Martin
4eb5d64307
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5711 - Onboarding colours have contrast issues
2019-12-13 17:52:55 -08:00
Afzal Najam
9474fe12af
[fenix] Hide add folder option when in Desktop Bookmarks folder
2019-12-13 17:51:15 -08:00
Ryan Kelly
b806b4c5fa
[fenix] Use feature-accounts-push, which replaces feature-sendtab.
2019-12-13 16:42:28 -08:00
mcarare
b9d221b9d1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6968 Close response stream to allow use of caching
2019-12-13 12:35:25 -08:00
mcarare
d77be2b506
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7075 Update passwords preference visibility and string
...
Set visibility for feature flags before settings screen it's displayed.
Change string for preference to match existing header string.
Update UI Tests
2019-12-13 12:19:14 -08:00
mcarare
51e35d827d
[fenix] Reverts https://github.com/mozilla-mobile/fenix/pull/6925 : Make home screen full screen
2019-12-13 11:29:53 -08:00
Colin Lee
a9a3fdc1fd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4064 : Replace prerelease R8 with improved Kotlin coroutines library ( https://github.com/mozilla-mobile/fenix/pull/7153 )
2019-12-13 13:29:27 -06:00
Will Hawkins
f92865d320
[fenix] No Issue: Create a method to "finish onboarding" in CI
...
If the intent that starts the HomeActivity includes an extra
boolean flag named finishonboarding and it is set to true,
Fenix will "finish onboarding".
2019-12-13 11:28:57 -08:00
Emily Kager
c324abaa7b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6946 - Get engine margins without assuming top/bottom toolbar
2019-12-13 11:09:30 -08:00
Emily Kager
ffce59a7d7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7124 - Match toolbar location for ETP/security panel gravity
2019-12-13 11:09:30 -08:00
Vlad Filippov
3091418bd7
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5913 : Add new sessionToken scope ( https://github.com/mozilla-mobile/fenix/pull/6155 )
2019-12-12 12:00:20 -08:00
Emily Kager
6e8cdfd720
[fenix] No issue: Scroll to remote debugging text in UI Tests ( https://github.com/mozilla-mobile/fenix/pull/7117 )
2019-12-12 12:00:02 -08:00
Tiger Oakes
cd4f41aa6a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6830 - Fix "Open in" text size for custom tab ( https://github.com/mozilla-mobile/fenix/pull/7010 )
2019-12-12 11:49:54 +02:00
ValentinTimisica
3987045df8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4776 : Refactored UI tests.
...
After removing the 'Privacy notice' and 'Help' items from the Settings screen
the UI tests for them became unneeded.
2019-12-12 11:34:10 +02:00
ValentinTimisica
f88065117a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4776 : Added Unit tests for About Page.
2019-12-12 11:34:10 +02:00
ValentinTimisica
abb0295559
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4776 : Redesign and refactor the About Page
...
Added new items to be displayed.
2019-12-12 11:34:10 +02:00
Grisha Kruglov
d467ebf6b3
[fenix] Enable Fennec settings (telemetry) migration
2019-12-11 19:16:55 -08:00
mcarare
a330ab5bda
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7066 Increase space below checkbox preference
2019-12-11 11:23:14 -08:00
Mihai Adrian
b28abb5dce
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6710 Update custom search engine images with better resolution ( https://github.com/mozilla-mobile/fenix/pull/7084 )
2019-12-11 16:09:32 +02:00
Sawyer Blatz
35ee6640d3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7073 : Makes logo on about page not important for accessibi… ( https://github.com/mozilla-mobile/fenix/pull/7074 )
2019-12-10 12:15:11 -08:00
Mihai Branescu
6e2deeaadb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6330 Collections Numbering ( https://github.com/mozilla-mobile/fenix/pull/6453 )
...
* For https://github.com/mozilla-mobile/fenix/issues/6330 - Added logic for getting the recommended default collection name
* For https://github.com/mozilla-mobile/fenix/issues/6330 - Added unit test for default collection number method
2019-12-10 12:10:01 -08:00
Tiger Oakes
daf77820a4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5783 - Web Share with Fenix share sheet ( https://github.com/mozilla-mobile/fenix/pull/6883 )
2019-12-10 10:57:06 -08:00
Mihai Adrian
018f97df45
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7031 - Hide progress bar when leaving DeleteBrowsingDataFragment ( https://github.com/mozilla-mobile/fenix/pull/7056 )
2019-12-10 11:17:45 -05:00
isabelrios
4a62f38670
[fenix] Re-enable Screenshots tests ( https://github.com/mozilla-mobile/fenix/pull/6617 )
...
disabling setting test options due to different screen sizes
name screenshots according to robots
fix kotlin style
update settings tests with new Toolbar option
screenshots tests in different package than ui tests
2019-12-10 13:05:47 +02:00
Sebastian Kaspari
662000d038
[fenix] Run migration in background service.
...
In order to avoid a half done migration we are moving the migration to a background service (that is
running in the "foreground").
This is the Fenix part of:
https://github.com/mozilla-mobile/android-components/issues/4879
2019-12-10 11:31:32 +01:00
Tiger Oakes
19b362d4fd
[fenix] Extract IntentProcessorType to its own file and add tests ( https://github.com/mozilla-mobile/fenix/pull/7012 )
2019-12-10 00:02:23 -08:00
Severin Rudie
bb5685cc4c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4844 : fix file prefix url shortening
2019-12-10 05:07:53 +01:00
Severin Rudie
9a0b3f6557
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5334 : fix ETP shield coloring on custom private tabs
2019-12-10 03:22:55 +01:00
Mihai Adrian
ab0bc61cb3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6997 Avoid overwriting empty_search_string error ( https://github.com/mozilla-mobile/fenix/pull/6998 )
...
Setting error twice also clips error message
2019-12-09 18:10:24 -08:00
Emily Kager
69f92da9cb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6922 - Check current destination is logins fragment before navigation ( https://github.com/mozilla-mobile/fenix/pull/6924 )
2019-12-09 15:42:40 -08:00
Michael Comella
ed87207990
[fenix] For perf-frontend-issues https://github.com/mozilla-mobile/fenix/pull/33 : Clarify VERBOSE logging motivation.
2019-12-09 15:11:52 -08:00
Michael Comella
3b36ea34c8
[fenix] For perf-frontend-issues https://github.com/mozilla-mobile/fenix/pull/33 : Add HotStartPerformanceMonitorTest.
...
We really don't want our startup tests to subtlely change so I thought
it was worth writing some quick tests.
2019-12-09 15:11:52 -08:00
Michael Comella
bde17a6a4e
[fenix] For perf-frontend-issues https://github.com/mozilla-mobile/fenix/pull/33 : Add HotStartPerformanceMonitor.
...
As mentioned in the class comment, we could use an alternative
implementation to measure perf from outside the application however
it's more complicated to set up and less consistent with our cold
startup methodology so we'll start with this.
2019-12-09 15:11:52 -08:00
ekager
7f5cac63f1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5771 - Don't force landscape mode on fullscreen
2019-12-09 23:47:57 +01:00
mcarare
35eeb98cac
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4107 Make home screen fullscreen.
...
Add/Remove fullscreen flags in home fragment's onResume / onPause
Change homeLayout padding to include system bars height (status&navigation).
Change homeMenu orientation to UP to properly display menu.
Change home bottomBar background to transparent.
2019-12-09 23:45:02 +01:00
mcarare
d49503e58e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7026 Dispatch ModeChange on hideOnboarding
2019-12-09 23:44:33 +01:00
ekager
058da9bf17
[fenix] No issue: Remove unnecessary back slashes from curly apostrophe strings
2019-12-09 23:16:00 +01:00
Grisha Kruglov
46bf7f45f9
[fenix] Fennec migration: enable logins migration
2019-12-09 13:35:22 -08:00
Jeff Boek
e0b335ed68
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1607 - Passes "custom" as the search engine identifier for custom engines
2019-12-09 11:47:05 -08:00
Severin Rudie
f838367e84
[fenix] No issue: small installedSearchEngineIdentifiers readability refactor
2019-12-09 10:58:19 -08:00
Severin Rudie
013aac2604
[fenix] No issue: tests installedSearchEngineIdentifiers
2019-12-09 10:58:19 -08:00
Severin Rudie
a6bb6ad9ca
[fenix] No issue: begin moving FenixSearchEngineProvider into a testing harness
2019-12-09 10:58:19 -08:00
Oana Horvath
4e1bb19dc0
[fenix] Fixed flaky History UI tests by adding an extra verification step that ( https://github.com/mozilla-mobile/fenix/pull/6894 )
...
the page is loaded.
Enabled all tests
2019-12-09 11:52:55 +02:00
Aaron Train
4cf0c56803
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6873 : Support many more Content-Type in MockWebServer (UI tests) ( https://github.com/mozilla-mobile/fenix/pull/7001 )
...
Ensure our MockResponse can handle different Content-Type e.g, images, to help support other tests
2019-12-06 14:53:18 -05:00
Severin Rudie
53b4d6714e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5334 : added private custom tab processor ( https://github.com/mozilla-mobile/fenix/pull/6845 )
...
* For https://github.com/mozilla-mobile/fenix/issues/5334 : added private custom tab processor
* For https://github.com/mozilla-mobile/fenix/issues/5334 - Fixes up IntentReceiverActivity for handling intents
* For 5334: update styling for private custom tabbs
* For 5334: update tests to account for new processors
Note that two are still failing. These appear to be true failures, and will be corrected in a later commit.
* For 5334: fixes bug introduced by changes to IntentReceiverActivity
RCA: intent className and extra were previously set based on which processors matched, not which successfully processed. This patch reintroduces that behavior.
* For 5334: add tests for custom tabs processing
2019-12-06 10:57:54 -08:00
Jeff Boek
fa903dd097
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4664 - Updates search_with string. ( https://github.com/mozilla-mobile/fenix/pull/6909 )
2019-12-06 10:36:19 -08:00
Mozilla L10n Automation Bot
8671faa0f6
[fenix] Import l10n.
2019-12-06 08:53:22 -08:00
kglazko
50b8f92201
[fenix] Issue 5366 Vector Drawable Compat ( https://github.com/mozilla-mobile/fenix/pull/6904 )
2019-12-05 19:54:32 -08:00
Richard Pappalardo
101f6a1770
[fenix] Disable flaky testDownloadNotification - API28 ( https://github.com/mozilla-mobile/fenix/pull/6982 )
2019-12-05 18:00:21 -08:00
Mihai Adrian
208d0c684b
[fenix] Temporarily fix lint issues with bad translation of string ( https://github.com/mozilla-mobile/fenix/pull/6963 )
2019-12-05 13:57:57 -08:00
mcarare
4a29b6b06b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6917 Emit mode change only when new mode is different from current
2019-12-05 11:10:14 -08:00
Mihai Adrian
b36189b3b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6910 Align shortcuts in private onboarding panel style to… ( https://github.com/mozilla-mobile/fenix/pull/6950 )
...
Divider only shows when both panel and "Search with" are visible
2019-12-05 09:37:20 -08:00
Mihai Adrian
a4be691ea0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6943 Hide supportActionBar in onResume, not onCreate ( https://github.com/mozilla-mobile/fenix/pull/6978 )
2019-12-05 09:36:39 -08:00
Mozilla L10n Automation Bot
4d9a90f293
[fenix] Import l10n.
2019-12-04 19:59:25 -08:00
Gabriel
9ed4f7f119
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5574 - Migrate SessionControl to LibState ( https://github.com/mozilla-mobile/fenix/pull/6651 )
...
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 1: Port TabAction.SaveTabGroup to TabSessionInteractor and SessionControlController. (https://github.com/mozilla-mobile/fenix/pull/6651 )
- Introduces the TabSessionInteractor, SessionControlInteractor and SessionControlController classes.
- Removes the TabAction.SaveTabGroup.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 2: Port TabAction.PrivateBrowsingLearnMore to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 3: Port TabAction.ShareTabs to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 4: Remove unused TabAction.Share and TabItemMenu (https://github.com/mozilla-mobile/fenix/pull/6651 )
In https://github.com/mozilla-mobile/fenix/issues/2205 , the tab overflow button was removed which would have shown the
TabItemMenu when clicked. So, we can remove TabItemMenu since it is not
used and as a result, we can also remove TabAction.Share since there are
no consumers.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 5: Port TabAction.PlayMedia and TabAction.PauseMedia to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 6: Port TabAction.Select to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 7: Port Onboarding.Finish to OnboardingInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 8: Port TabAction.Close and TabAction.CloseAll to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
- Removes TabAction
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 9: Port CollectionAction.Delete to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 10: Port CollectionAction.ShareTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 11: Port CollectionAction.AddTab and CollectionAction.Rename to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 12: Port CollectionAction.RemoveTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 13: Port CollectionAction.OpenTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 14: Port CollectionAction.CloseTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 15: Introduce a HomeFragmentStore (https://github.com/mozilla-mobile/fenix/pull/6651 )
- We will hook up the HomeFragmentStore in later parts.
- Removes List<Tab>.toSessionBundle(context: Context) since it is unused.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 16: Port CollectionAction.Collapse and CollectionAction.Expand to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
- We assume the store is hooked up to the SessionControlController in this part,
but this work will be done in a later part.
- Removes CollectionAction.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 20: Remove the architecture module. (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 17: Remove duplicate subscribeToTabCollections in BrowserFragment.kt (https://github.com/mozilla-mobile/fenix/pull/6651 )
There is a duplicate call of subscribeToTabCollections() in both HomeFragment and BrowserFragment.
In this patch, we remove the call in BrowserFragment to avoid passing the HomeFragmentStore to
BrowserFragment in order to dispatch the CollectionsChange event.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 18: Delete SessionControlComponent and fix TabCollection and Tab imports (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 19: Use the new HomeFragmentStore in the HomeFragment (https://github.com/mozilla-mobile/fenix/pull/6651 )
- Renames SessionControlUIView to SessionControlView
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 21: Fix white screen on home fragment (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 22: Fix formatting in SessionControlInteractor and replace See with @see in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 23: Move to metrics.track call to the beginning of handleCollectionRemoveTab (https://github.com/mozilla-mobile/fenix/pull/6651 )
This ensures that the metrics.track will be called immediately before the tab is removed from the collection.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 24: Use the sessionManager getter in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 25: Use mapNotNull in List<Tab>.toSessionBundle (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 26: Simplify closeTab and closeAllTabs functions by assigning a deletionJob constant (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 27: Replace listOf() with emptyList() in removeAllTabsWithUndo (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 28: Replace the Context parameter with the HomeActivity in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 29: Add test for HomeFragmentStore, DefaultSessionControlController and SessionControlInteractor (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Removes running CI against the architecture debug build varient
2019-12-04 22:06:05 -05:00
Jeff Boek
58bdd912e6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6855 - Filter out duplicated bundled search engines
...
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 17:10:02 -08:00
mcarare
7a289d1eb1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6070 Adds telemetry for enabling search suggestions in private
2019-12-04 16:44:01 -08:00
Jeff Boek
e6709a82d7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6849 - Properly select a new default search engine when you delete the current one
...
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 16:10:26 -08:00
Jeff Boek
4e988fce7b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6848 - Sorts the search engine list without case sensitivity
...
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 16:10:26 -08:00
Jeff Boek
e51c588fd7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6847 - Properly rebuilds the SearchEngineList on undo
...
Co-authored-by: Severin Rudie <Baron-Severin@users.noreply.github.com>
2019-12-04 16:10:26 -08:00
Emily Kager
4ce302d29f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6908 - Set null anchors for snackbars with top toolbar ( https://github.com/mozilla-mobile/fenix/pull/6911 )
2019-12-04 15:01:04 -08:00
Jeff Boek
7f7685689f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6795 - Auto shows toolbar when loading a new URL ( https://github.com/mozilla-mobile/fenix/pull/6955 )
...
Co-authored-by: Severin <Baron-Severin@users.noreply.github.com>
2019-12-04 15:00:51 -08:00
Sebastian Kaspari
ad503a83c1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4976 : Reuse Fennec launcher entry in manifest.
...
With this patch Fennec users, who upgrade to Fenix, will not lose Firefox launcher icons they
have added to their home screen.
A side effect of this change is that the launcher entry for existing Fenix users may disappear
from the home screen for existing Firefox Preview users and they will have to re-add it.
Since the Preview audience is more accepting of breaking changes and since that group is
way smaller than the millions of Fennec users, I think that this is an acceptable breaking
change. I looked into supporting multiple launcher entries in parallel, but that got quite
complex with multiple build types and multiple manifest files. Especially if we decide
to keep a Firefox Preview build around (e.g. org.mozilla.fenix) then it would be good to
unify on a single launcher and do that as early as possible.
2019-12-04 12:51:48 -08:00
Oana Horvath
0cb634facc
[fenix] Added multi-selection tests for bookmarks ( https://github.com/mozilla-mobile/fenix/pull/6475 )
...
Updated bookmarking method
Fixed flaky tests
Added wait to create bookmark
2019-12-03 12:44:54 +02:00
mawen7
bbfa8aadd4
[fenix] Run lint for app module and set baseline
2019-12-02 14:45:34 -08:00
Aaron Train
0e77c47f42
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6363 - Add Downloads UI tests ( https://github.com/mozilla-mobile/fenix/pull/6574 )
...
- Initiates a download
- Verifies prompt
- Verifies notification in notification shade
2019-12-02 17:15:00 -05:00
ekager
333ff28126
[fenix] No issue: Fix search suggestions strings
2019-12-02 21:39:10 +00:00
ekager
c09e977ff7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6791 - Inflate SavedLoginsListItemViewHolder layout explicitly
2019-12-02 10:40:58 -08:00
ekager
4f0bcac5b8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6889 - Check current destination before navigating from settings
2019-12-02 10:40:21 -08:00
ekager
41af91db69
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6890 - Don't crash with no connection when adding custom search engine
2019-12-02 10:37:31 -08:00
Severin Rudie
312a66c20e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5540 : updates error page copy when no internet is available ( https://github.com/mozilla-mobile/fenix/pull/6803 )
2019-12-02 10:26:06 -08:00
cesar
8a51b43fbc
[fenix] test fixed
2019-12-02 16:18:48 +00:00
cesar
9b868c1e0b
[fenix] nested loop removed
2019-12-02 16:18:48 +00:00
cesar
51fe91d723
[fenix] klint clean up and previous nit fixed
2019-12-02 16:18:48 +00:00
cesar
cc1bfd730b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6731 - fixed BookmarkNode minus operator and deleteOperation
2019-12-02 16:18:48 +00:00
cesar
85a1b85158
[fenix] Test for 6731
2019-12-02 16:18:48 +00:00
mcarare
2ca9178898
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6835 Align Home and Browser toolbar elements to perfectly overlap
2019-12-02 16:17:07 +00:00
mcarare
10831c25ed
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6401 Set false as default value for Open links in a private tab
2019-12-02 16:16:26 +00:00
mcarare
75330ca583
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6516 On browsing mode change empty tab list before displaying new list
2019-12-02 16:15:54 +00:00
Tiger Oakes
4426480f55
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6827 , https://github.com/mozilla-mobile/fenix/issues/6811 - Cast layoutParams to MarginLayoutParams
2019-12-02 14:52:31 +00:00
mcarare
b49fd6c3b1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6881 Choose visible view when multiple views have same label text
2019-12-02 14:02:51 +00:00
Oana Horvath
d7bc4a96ce
[fenix] Disable UI history tests again for more investigation ( https://github.com/mozilla-mobile/fenix/pull/6837 )
2019-12-01 19:53:55 -05:00
Tiger Oakes
5bdd21e04e
[fenix] Suppress upcoming deprecation ( https://github.com/mozilla-mobile/fenix/pull/6765 )
2019-11-28 16:17:56 -08:00
Gabriel Luong
30a1862f30
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6857 - Replace BackHandler with UserInteractionHandler in InflationAwareFeature and InflationAwareFeatureTest
2019-11-28 15:58:07 -05:00
Jeff Boek
5c7ec54a11
[fenix] No Issue - Fixes warnings / compiler errors with A-C update
2019-11-28 12:45:45 +01:00
mcarare
68ba4480cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6629 Align Private Browsing mode to UX specs
2019-11-27 11:13:20 -08:00
ekager
4b720e646f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5586 - Track all login copy events
2019-11-27 10:59:36 -08:00
Mozilla L10n Automation Bot
a01d3cc798
[fenix] Import l10n.
2019-11-27 10:52:38 -08:00
Will Hawkins
dc526b557e
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/5183 : Initialize megazord asynchronously
...
Thanks to the work of the team at application-services, it is possible
to asynchronously initialize the Http client and logger used by megazord
Use that power to hide the time necessary to complete this initialization
within the time that it takes to warmup the gecko runtime.
2019-11-27 10:51:57 -08:00
cesar
5cd156bba2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6769 - EditText moved to be above the gradient view
2019-11-27 10:48:38 -08:00
Sebastian Kaspari
a126b92f9c
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/6622 , https://github.com/mozilla-mobile/fenix/issues/6688 : Create a "fennecBeta" and "fennecNightly" build types.
2019-11-27 10:28:22 -08:00
mcarare
a6b0fda280
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4219 Set url view not important for accessibility
...
Talkback rectangle for url view selection will include parent view
2019-11-27 10:11:16 -08:00
mcarare
bd55aaeb46
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6470 Change notification icon
...
Used private browsing icon with compulsory white color for notifications
2019-11-27 10:08:00 -08:00
mcarare
2711348828
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6470 Remove actions from notification, keep just close private tabs
...
Removed NotificationsIntentProcessor because notifications no longer open app
Added new strings
2019-11-27 10:08:00 -08:00
Mihai Branescu
6d8117f1ba
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6396 - Added metrics for tracking history/bookmarks account sync toggles ( https://github.com/mozilla-mobile/fenix/pull/6601 )
2019-11-27 11:16:23 +02:00
Mihai Adrian
61b23c7a32
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6748 Move Add search engine to search engine preference category. ( https://github.com/mozilla-mobile/fenix/pull/6749 )
2019-11-27 10:45:05 +02:00
Mihai Adrian
132c68b597
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2570 : Hide 3-dots menu for all library items when in select mode. ( https://github.com/mozilla-mobile/fenix/pull/6736 )
...
notifyDataSetChanged to avoid not displayed but created items not being redrawn
2019-11-27 10:40:38 +02:00
Mihai Adrian
d4557d5a67
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5497 Align text to viewStart to keep consistency in RTL ( https://github.com/mozilla-mobile/fenix/pull/6778 )
2019-11-27 10:35:49 +02:00
Jeff Boek
11b8410367
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5972 - Fixes bugs when launching in private mode on Android 5 ( https://github.com/mozilla-mobile/fenix/pull/6702 )
2019-11-26 14:53:03 -08:00
Sawyer Blatz
58a007659f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6821 : Fixes issues with custom tabs and dynamic toolbar ( https://github.com/mozilla-mobile/fenix/pull/6822 )
2019-11-26 13:02:52 -08:00
Mihai Adrian
8734472571
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6430 Private browsing hint width should not exceed screen dimensions ( https://github.com/mozilla-mobile/fenix/pull/6786 )
...
Renamed ambiguous pop-up window name.
Adjusted code to match max line length.
2019-11-26 10:07:31 -08:00
Sawyer Blatz
723d99864f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5694 & https://github.com/mozilla-mobile/fenix/issues/6054 : Allows users to change toolbar position ( https://github.com/mozilla-mobile/fenix/pull/6608 )
...
* For https://github.com/mozilla-mobile/fenix/issues/5694 & https://github.com/mozilla-mobile/fenix/issues/6054 : Adds preference screen for toolbar
* For https://github.com/mozilla-mobile/fenix/issues/5694 : Adds changing toolbar position functionality
* No issue: Updates telemetry links to actually work lol 😬
* For https://github.com/mozilla-mobile/fenix/issues/6054 : Adds toolbar position to core ping
2019-11-25 16:43:32 -08:00
Tiger Oakes
42d5ef61f9
[fenix] Add toolbar helpers ( https://github.com/mozilla-mobile/fenix/pull/6531 )
2019-11-25 15:36:47 -05:00
Tiger Oakes
35bf8dfc58
[fenix] Use ShareData with ShareFragment ( https://github.com/mozilla-mobile/fenix/pull/6698 )
2019-11-25 11:07:21 -08:00
Christian Sadilek
9176a21ab0
[fenix] Fix for A-C 23.0.0: onDownloadCompleted renamed to onDownloadStopped
2019-11-23 20:25:21 -05:00
Tiger Oakes
21ef894d5b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6763 - Fix early view access
2019-11-23 10:55:29 -05:00