Commit Graph

4286 Commits (7f14d314cbd753a1041155a273c21e26d9a86373)

Author SHA1 Message Date
mcarare 4a56121cc4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15711: Also add custom engines to fallback list. 4 years ago
mozilla-l10n-automation-bot 93b385ba2e [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/15738) 4 years ago
Elise Richards f5ff218d46 [fenix] For https://github.com/mozilla-mobile/fenix/issues/8765: Use shared list widget in collections (https://github.com/mozilla-mobile/fenix/pull/15733)
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
4 years ago
Michael Comella 8b20c2d8c2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 - post: decrement expected suppression count.
Running locally, I get the same error: I think that there legitimately
was an reduction in the number of StrictMode suppressions on start up.
4 years ago
Michael Comella 0934b7fe93 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 - review: add clarifying comments. 4 years ago
Michael Comella 86a44fb728 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add marker when StrictMode is suppressed. 4 years ago
Michael Comella 19904397b2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add MozillaStrictModeSuppression detekt check. 4 years ago
Michael Comella d253b9060e [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add test to prevent increasing StrictMode suppression count. 4 years ago
Michael Comella 3e9f93a0ab [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add HomeActivityTestRule.skipOnboarding.
This is more correct, faster, and results in less copy-paste duplication
than the current behavior:
  homeScreen { }.dismissOnboarding()

Which opens settings to dismiss onboarding.
4 years ago
Michael Comella b6609a0747 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: count StrictMode suppressions on startup. 4 years ago
Jocelyne Abi Haidar efc846d57a [fenix] For https://github.com/mozilla-mobile/fenix/issues/15675: Disable Save button when editing saved login until something has been changed
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
4 years ago
mozilla-l10n-automation-bot 1d8006f733 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/15712) 4 years ago
Mozilla L10n Automation Bot ded58ad2b7 [fenix] Import l10n. 4 years ago
mcarare 8668f5a0d6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15632: Improve checking open tabs logic to show collection button.
Check now considers selected tab tray mode.
4 years ago
ekager c5a6e86f9b [fenix] For https://github.com/mozilla-mobile/fenix/issues/15600 - Move removal of timed out sessions to immediately after restoration 4 years ago
ekager d9aefd1ce2 [fenix] No issue: Update biometric, core, and recyclerview libraries 4 years ago
mcarare 1add1c7454 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13031: Show size in KB for smaller downloaded files. 4 years ago
Mozilla L10n Automation Bot c318e736f9 [fenix] Import l10n. 4 years ago
Jocelyne cc4d4a14d9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10107: Show Today and Yesterday labels in History (https://github.com/mozilla-mobile/fenix/pull/15415) 4 years ago
Jeff Boek d81eff94bd [fenix] For https://github.com/mozilla-mobile/fenix/issues/15593 - Reverts back to simple UUID creation without Fenix side caching 4 years ago
Jocelyne 635e49092e [fenix] For https://github.com/mozilla-mobile/fenix/issues/15471: Show Delete button in red in multi-select overflow menu (https://github.com/mozilla-mobile/fenix/pull/15576) 4 years ago
Mozilla L10n Automation Bot 482efed8de [fenix] Import l10n. 4 years ago
Grisha Kruglov a41022554b [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15443: Use fragment's lifecycleScope for AlertDialog actions 4 years ago
Christian Sadilek 33e49d471b [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/15555: Set channel to Nightly explicitly for SettingsFragmentTest 4 years ago
mcarare 1589942479 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15559: Allow tabs to stretch in landscape mode for tablets.
This overrides the default tabMaxWidth of 264dp to allow for tabGravity="fill".
4 years ago
Christian Sadilek a846743af4 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15555: Intermittent failures in SettingsFragmentTest 4 years ago
Stefan Arentz a0c00cb3b4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15537 - Be more verbose about leanplum identifiers (https://github.com/mozilla-mobile/fenix/pull/15538) 4 years ago
mcarare 192e5dc063 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15535: hasOpenTabs now considers the selected tab mode in tray tab. 4 years ago
Michael Comella af732f0748 [fenix] No issue: elaborate on Components class doc.
This is to clarify a misunderstanding I found in PR review.
4 years ago
Sebastian Kaspari 70dbf0d765 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565: Pass metrics to share controller" for debug test failures.
This reverts commit 5de145914e9fc10d3d647e6f2856c2df19dd9156.
4 years ago
Sebastian Kaspari 9b598b33d8 [fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565: Pass bookmark storage to controller" for debug test failures.
This reverts commit 9825a5d2dfb0f6d3c0235fdf0032e510c34bf20a.
4 years ago
Andrew Gaul 43778cf3cb [fenix] Show undo snackbars with padding with static bottom toolbar
This specifically fixes the close tab snackbar.  This commit mirrors
the logic when not using Undo from
e14bf8e791aa56ded47812018f32ee9801a5b4f9.  References https://github.com/mozilla-mobile/fenix/issues/14982.
4 years ago
ekager 1429c5ddaf [fenix] For https://github.com/mozilla-mobile/fenix/issues/15324 - Show tab settings and recently closed items in menu when no tabs 4 years ago
ekager 8caf149ab7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/15503 - Change recently closed max to 10 4 years ago
TrianguloY 98f8f3b2ca [fenix] For https://github.com/mozilla-mobile/fenix/issues/13856 - Prevent overscroll in swipe to switch tabs gesture 4 years ago
Tiger Oakes 5a3b5af7d9 [fenix] Extract locale settings initial state 4 years ago
Tiger Oakes be11bfd5b4 [fenix] Add test for initial logins list state 4 years ago
Tiger Oakes e4bdd355d3 [fenix] Add tests for initial collection creation state 4 years ago
Sören Hentzschel ac1a2a708a [fenix] For https://github.com/mozilla-mobile/fenix/issues/11561 - changed inactive heading and menu icon color in dark mode 4 years ago
Mozilla L10n Automation Bot 87ecdf8bfb [fenix] Import l10n. 4 years ago
Tiger Oakes b55c4af6fb [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565: Pass bookmark storage to controller 4 years ago
Tiger Oakes 966e13c9aa [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565: Pass metrics to share controller 4 years ago
Michael Comella a50cf27648 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: fix startup crash by using arg Context.
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
4 years ago
Michael Comella 53bd004f55 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: remove resetAfter & port tests to StrictModeManager. 4 years ago
Michael Comella d0fbe70f10 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: clean up existing StrictMode test names. 4 years ago
Michael Comella 8a9472e540 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: move resetAfter into StrictModeManager.
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.

Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```

We're going to have to add a lint check to prevent them from doing that.
4 years ago
Michael Comella 5f8943f76c [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: change StrictModeManager to class from object.
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
4 years ago
Christian Sadilek 76018e2fe0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/14034: Add debug preference to override AMO collection in Nightly 4 years ago
Michael Comella 9e86e369b6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: comment about duplication in logic in StrictMode.
I had to drop a commit that addressed the issue because it was too hard
to fix.
4 years ago
Michael Comella 394465e33e [fenix] For https://github.com/mozilla-mobile/fenix/issues/13959: add comment to explain why we only resetAfter in certain build modes. 4 years ago