d53213338e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7996 : Private mode doesn't play nicely with sites added to home screen
...
Site Controls Notification should reflect the browsing mode of the
currernt web app session.
4 years ago
bf8b0df4cb
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/10142 Update sitePermissions state when toggling its value
4 years ago
6ac92c0839
[fenix] No issue - Remove unused data class TopSiteItem
4 years ago
c3ed72e7a1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10071 : Fixes PWA showing toolbar onPause ( https://github.com/mozilla-mobile/fenix/pull/10306 )
4 years ago
2d9813040a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9728 : Add actionbar search for language list.
4 years ago
6b97e0f5e3
[fenix] No issue - Update new strings for quarantine
4 years ago
fa9a791c81
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/8648
4 years ago
11a2cece68
[fenix] Fix breaking API changes in CrashReporter
4 years ago
c38d5c6546
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9694 Bug when user denies permission
4 years ago
b12708c642
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10083 : Adjust thumb offset to thumb circumference to avoid cutoff
4 years ago
a4b9d4378f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10201 - Provide proper button padding and no tabs message visibility in tabs tray
4 years ago
0812822771
[fenix] No issue: Partially update the add-on manager list
5 years ago
1b45aa0a8e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9913 , For https://github.com/mozilla-mobile/fenix/issues/9914 : Remove touch delegate when button is disabled.
5 years ago
5529f77183
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10204 - Address viewLifecycleOwner IllegalStateException crashes
5 years ago
37475de143
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6557 - added unit tests
5 years ago
e18ce8d6d4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6557 - add in_content telemetry class
5 years ago
42018cddf2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6557 - split base extension functionality from ads
5 years ago
c1e736fdb2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6557 - added metric for in_content
5 years ago
ae730cec59
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10180 : Remove touch delegate when button is disabled.
...
Also refactored multiple if's into a when.
5 years ago
bad90f3408
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10180 : Add extension to remove touch delegate from parent.
5 years ago
30273fe6de
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6558 - cleanup + added unit tests
5 years ago
95f3bf9daf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6558 - added logic for ad_clicked metric
5 years ago
09fae4d74f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6558 - added handling of web extension + sending metric for has_ads
5 years ago
f765736b27
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10162 : Set switch back to prev state when failed to enable/disable addon ( https://github.com/mozilla-mobile/fenix/pull/10164 )
5 years ago
0ecb2893f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9913 , For https://github.com/mozilla-mobile/fenix/issues/9914 : Remove button when disabling it.
...
Setting visibility to GONE allows clicks to parent view in that space.
5 years ago
7be16b503d
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9493 : Reload after cleaning individual site permissions exceptions
5 years ago
b2cad42ba9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10148 - Add basic tab tray implementation without exposing to rest of app ( https://github.com/mozilla-mobile/fenix/pull/9934 )
5 years ago
81122da15a
[fenix] Add 'useEmail' and 'useEmailProblem' metrics event
...
Fixes https://github.com/mozilla-mobile/fenix/issues/9834
5 years ago
c4dda61fe8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6123 : Expose WebExtensions in private browsing control
5 years ago
eb26d39bf0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10091 Also disable play/pause button when hiding it.
5 years ago
194aa1aec3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10091 Add extension to remove and disable button
5 years ago
8310691f2d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7387 : Change ETP onboarding from popup to a dialog.
...
Recalculated dialog position and offsets.
Changed ETP onboarding dialog to show only once.
5 years ago
5aa32ad79a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9987 : Set FLAG_SECURE to dialog when flag set in activity.
5 years ago
2aaeb8c3e4
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/10109 : Adds content description for browse privately card content
5 years ago
4c2cfe29b5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10027 : Make toolbar context menu popup dismissible on SDK<23
5 years ago
b5f847467f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6832 - Fix various fragment not attached to a context crashes
5 years ago
0e078d3f20
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2818 - Enable PiP for all builds
5 years ago
e85a7bd2ff
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/9760 : Add external app links context menu candidate
5 years ago
8ed532ebdf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9208 : Adds in-product prompt to homescreen ( https://github.com/mozilla-mobile/fenix/pull/9836 )
5 years ago
239a890d0e
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/7566 Handle deny & don't ask again for site permissions
5 years ago
07fcd5106a
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9493 : Reload after cleaning all site permissions exceptions
5 years ago
76b250e035
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10036 - Workaround for System Theme changes with config change
5 years ago
e42739298c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/8541 : Hide find bar when entering fullscreen
5 years ago
1ba6fea116
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9816 - Adds SessionObserver to session on selection
5 years ago
fafd0b6667
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/9338 : Enable WebPush engine integration in all builds
5 years ago
fbbc270ddf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8735 - Adjust fontInflation engine setting when toggling useAutoSize
5 years ago
479c41236f
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9928 - Updates private browsing text description
5 years ago
5c0d300938
[fenix] Don't use ProcessLifecycleOwner for view-tied consume
5 years ago
e27e45bc75
[fenix] No issue: Fix leaks in BookmarkFragment
5 years ago
b28a0e8ce9
[fenix] No issue: Fix leaking sessionControlInteractor
5 years ago
567d0ba9b9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4046 : Always display 'Desktop' bookmarks folder
...
See https://github.com/mozilla-mobile/fenix/issues/4046 for a detailed discussion of this.
In short, this patch removes code that would conditionally hide desktop bookmarks depending
on the signed-in state of the browser.
5 years ago
048aba1ff9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9932 : Fix navigation icon theme missing from migration UI
...
Setting the `navigationBarColor` is done in the ThemeManager for the
attached activity. Since the migration UI is separate from that, we did
not get this for free.
5 years ago
c81052bd6d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6940 : Fixes top dynamic toolbar behavior ( https://github.com/mozilla-mobile/fenix/pull/9900 )
5 years ago
d08756b53a
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/9960 : Launch URI in Fenix if failed to launch in custom tab ( https://github.com/mozilla-mobile/fenix/pull/9964 )
5 years ago
737e647c83
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8399 : Hide keyboard to prevent content resizes
...
This hides the keyboard after committing a URL in the
Toolbar right before we navigate from the SearchFragment
to the BrowserFragment. If the BrowserFragment is being
displayed before the keyboard is gone an expensive
resize of the engine view (content) is triggered when the
keyboard finally goes away. This is to prevent that.
5 years ago
a4d569db34
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8803 - review: Add clarifying comments to onAppInit capture methods.
5 years ago
a3be78d7e8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8803 : hook up frameworkStart metric.
5 years ago
deafedeada
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8803 : add StartupFrameworkStartMeasurement.
...
This class controls the central logic around the metrics we want to
record.
5 years ago
162a93a190
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8803 : add Stat and test.
...
We need to access the data in stat to get the process start time, so we
can calculate the time from process start until application.init for the
frameworkStart probe.
5 years ago
04af2a59e8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9703 - Exit fullscreen in onPause and onSessionSelected ( https://github.com/mozilla-mobile/fenix/pull/10016 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9703 - Call fullScreenChanged in onPause
* For https://github.com/mozilla-mobile/fenix/issues/10015 - Exit full screen if new session selected
5 years ago
94515941cf
[fenix] Use HomeFragment viewLifecycleOwner for BrowserSessionsObserver
5 years ago
2a4ad0e4eb
[fenix] Use HomeFragment's viewLifecycleOwner as the lifecycle for accountManager observer registry
...
If we just use the HomeFragment itself, we end up with a memory leak since the lifecycle events
that would clean up the registry (e.g. destroy) won't run (if the fragment is retained in the backstack, for example).
5 years ago
b510210dce
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9987 : Set FLAG_SECURE to dialog when flag set in activity. ( https://github.com/mozilla-mobile/fenix/pull/9998 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9987 : Add extension to secures dialog if parent activity is secured
* For https://github.com/mozilla-mobile/fenix/issues/9987 : Set FLAG_SECURE to dialog when flag set in activity
5 years ago
590a65a894
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9951 - Removed the extra empty spaces that were causing the spacing issue
5 years ago
b5255177fb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9536 : Open report issue tab depending on current browsing mode.
...
Checking if session is private uses the new browser state API.
5 years ago
fba1e732ef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7158 : Fixes browser to search animation fade
5 years ago
154ade7d64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8422 : Add spacing between migration items
5 years ago
7f3ca10103
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9981 - Make Bookmark Menu UI respond to session selection
5 years ago
880722de99
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9984 : Update addon before settings visibility check
5 years ago
e33e84bcbc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9857 : Create button style ( https://github.com/mozilla-mobile/fenix/pull/9858 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9857 : Creates text button style
* Adds lint check
* Fixes onboarding cards
5 years ago
9a162480c2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9409 : Add app icon to Leanplum push notifications
5 years ago
8ea49eb36a
[fenix] Remove duplicate FirebasePushService
...
When we moved push to it's own component the class was supposed to have
been moved but git might have only picked it up as an addition.
5 years ago
d2b9f203b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9420 - relaxed custom engine rules ( https://github.com/mozilla-mobile/fenix/pull/9967 )
...
Allow websites that return 404 to be added
Change long query param with one with higher changes of being found
5 years ago
6b4334b699
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9887 - Respect screenshot setting when resetting window flags in logins
5 years ago
bda6aa50f3
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9930 Do not assume all add-ons have a settings page
5 years ago
e5041e2fd8
[fenix] Update Android Components version
5 years ago
f38165ad6d
[fenix] No issue: Fix add-on translate() breaking change
5 years ago
3b980dadad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3194 - Pause media while undo snackbar appears
5 years ago
c33ac4edc0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/204 - Remove PWA Feature Flag
5 years ago
6308049167
[fenix] Cleans up nav_graph.xml ( https://github.com/mozilla-mobile/fenix/pull/9829 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up homeFragment directions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Uses global actions for fragments not owned by homeFragment
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up SearchFragment directions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes settings action from DeleteBrowsingDataFragment
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes browser action from SettingsFragment
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Adds ManagePhoneFeature global action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Clean up unused deletebrowsingfragment actions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans Up HistoryFragment actions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes Home -> Search action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes the Bookmark -> Browser action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up bookmark fragment actions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up actions from ShareController
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes defaultBrowserFragment to browserFragment action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes about -> browser action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Adds global action to TrackingProtectionFragment
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes exception -> browser action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes login -> browser action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Fixes LoginFragment directions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes ExternalAppBrowser directions
* for https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up actions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Fixes unit tests
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Addresses nits in PR
5 years ago
fa157d252b
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/8520 : Improve add-ons UI
5 years ago
101d815231
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9890 - Do not display full screen snackbar with toolbar padding
5 years ago
cf3f14b795
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9703 - Exit full screen on pause if pip not entered
5 years ago
92ea1cc5b3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9892 : Set dynamicToolbarMaxHeigtht to 0 for PWAs ( https://github.com/mozilla-mobile/fenix/pull/9893 )
5 years ago
27adb232c7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9692 - Fix "Install" PWA menu item labeling
5 years ago
089e2db827
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7208 For https://github.com/mozilla-mobile/fenix/issues/7212 - Update parameterized strings
5 years ago
fca63c72d7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9698 : Use extension to ensure fallback to English and avoid crash
5 years ago
79e3a1c328
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9698 : Add Context extension to avoid format IllegalArgumentException
5 years ago
290141865c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9798 : Disable buttons on hiding and enable on showing.
...
This is triggered on collection expanding or shrinking that is animated.
The animation has android:fillEnabled="true" android:fillAfter="true".
This interferes with set visibility to gone and the click still triggers.
Disabling button avoids changing animation or force clearing it.
5 years ago
fdd629b61f
[fenix] Update not yet unavailable add-on string ( https://github.com/mozilla-mobile/fenix/pull/9677 )
5 years ago
cc81201934
[fenix] Close https://github.com/mozilla-mobile/fenix/issues/9827 : Support display cutouts
5 years ago
07b1f84ec6
[fenix] No issue: Re-use existing usecases for addons
5 years ago
b57314cc8e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2818 - Adds Picture-in-Picture feature
5 years ago
b9fe826cef
[fenix] No issue: Move Do and OpenClass to utils pkg.
...
They were both in their packages by themselves, which feels unnecessary.
Unfortunately, a utils pkg is discouraged by kotlin but we don't have a
better place for them right now. Maybe an annotations/ pkg for the
latter?
5 years ago
c579e388d3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9797 : Set min height of dialog edit text to 48dp.
5 years ago
bcd9f52607
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9495 : Dismiss the ShareFragment in onPause()
5 years ago
7df242c354
[fenix] No issue: Refactor readerview to use browser-state
5 years ago
42a823fe24
[fenix] No issue: Add more settings animations ( https://github.com/mozilla-mobile/fenix/pull/9750 )
5 years ago
68a5b44663
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2768 - Prevent screenshots in private mode
...
Added a new option in Private browsing menu to allow or prevent screenshots from being taken while in private mode by adding or removing the FLAG_SECURE flag from the home activity's window.
This method is called whenever the activity is initialized to account for the browsing mode being changed and whenever the setting from the Private browsing menu is changed.
The setting is by default set to true (screenshots are allowed to be taken)
5 years ago
8fd1b5ef87
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9770 - Disable pull to refresh pending changes
5 years ago
4371996382
[fenix] For https://github.com/mozilla-mobile/fenix/issues/220 - Removes feature flag for language picker ( https://github.com/mozilla-mobile/fenix/pull/9191 )
...
* For https://github.com/mozilla-mobile/fenix/issues/220 - Removes feature flag for language picker
* For https://github.com/mozilla-mobile/fenix/issues/220 - Updates Android Components
5 years ago
8f1876407b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9687 : Refactor onboarding cards to follow app architecture ( https://github.com/mozilla-mobile/fenix/pull/9743 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9687 : Refactor onboarding cards to follow app architecture
* For https://github.com/mozilla-mobile/fenix/issues/9687 : Update unit test to new controller parameters
5 years ago
174af614f4
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9647 Crash when tapping settings after quickly
...
enabling/disabling add-on
5 years ago
461853e252
[fenix] Fix errors in top_sites_count metric
...
We discovered in the Fenix metrics errors query [1] that
top_sites_count had a spike in the number of errors. It
seems to be recording a count of 0, which is an invalid value.
[1] https://sql.telemetry.mozilla.org/queries/67107/source#169983
5 years ago
dca4c74a30
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3262 - Enable pull down to refresh in Nightly
5 years ago
0487e0ad62
[fenix] Update Android Components version to 38.0.20200403130109.
5 years ago
cb29b33e21
[fenix] No issue: add kdoc to HomeActivity.
...
We could consider renaming the Activity to make it clearer that it's the
main activity and doesn't just feature the homescreen but I'm concerned
that renaming it will break too many things (e.g. automation that starts
a specific activity). For quick fix, I added this comment.
5 years ago
9e5e780a9a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9128 & https://github.com/mozilla-mobile/fenix/issues/9222 & https://github.com/mozilla-mobile/fenix/issues/9499 : Refactors snackbar creation and fixes placement ( https://github.com/mozilla-mobile/fenix/pull/9628 )
5 years ago
e754578cef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6174 - Add telemetry for WebExtensions ( https://github.com/mozilla-mobile/fenix/pull/8318 )
5 years ago
2ec2ee395b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/768 : Add first time PWA dialog ( https://github.com/mozilla-mobile/fenix/pull/9308 )
...
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
5 years ago
a96fa3b790
[fenix] Prevent favicons from flashing when items are selected in History ( https://github.com/mozilla-mobile/fenix/pull/9233 )
5 years ago
66d28a700c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9336 Check current destination before navigating ( https://github.com/mozilla-mobile/fenix/pull/9353 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9336 Check current destination before navigating
* For https://github.com/mozilla-mobile/fenix/issues/9336 Update unit test to check for navigateSafe
5 years ago
8224f61cb3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9533 - Switch to using enum for Library Item Selected Telemetry
5 years ago
4b91238222
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9553 : Only update account UI state once when creating SettingsFragment
5 years ago
ea9add8d2b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8125 - Send top sites count with metrics ping
5 years ago
ef2d26efee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9365 : Partially reverse menu items order when using top toolbar
5 years ago
011b4f7fbd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9365 : Update naming to reflect history item
5 years ago
eb99ae1fef
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9598 & https://github.com/mozilla-mobile/fenix/issues/8697 : Fixes force expand crash ( https://github.com/mozilla-mobile/fenix/pull/9599 )
5 years ago
7b333febc0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9549 - Scrolling to top sites now includes header.
5 years ago
d80763ee11
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9109 - remove the sync error highlight from three-dot menu
5 years ago
12e3619a2e
[fenix] Make sure reconnect item is displayed in HomeMenu in case of account problems
...
AccountObserver listeners were being triggered correctly, however, during every time
we open HomeFragment, home menu gets re-created, which causes us to re-run the initialization
block. Before this patch, the init block would never touch the account manager.
After this patch, it will query it if account manager has already been initialized.
5 years ago
8d1befd34c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9561 : Fix initialization order in HomeMenu
...
`init` blocks are executed before `val` initialization which is declared afterwards
in the class. In this case, we had `quitItem` and `reconnectToSyncItem` as lazy,
but declared after the `init` block which may need them. And so, while this compiles
just fine, in practice we run into an NPE as the `init` block tries to get the lazy's value.
Simply re-ordering initialization fixes the problem.
5 years ago
12237fdca1
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/8520 : Polish Add-on manager UIs
5 years ago
72e91ad94a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9472 : ForceExpand browser toolbar when navigating ( https://github.com/mozilla-mobile/fenix/pull/9552 )
5 years ago
7d57c791f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8412 : Passes error handling function to 'CustomTabWindowFeature' ( https://github.com/mozilla-mobile/fenix/pull/8903 )
...
* For https://github.com/mozilla-mobile/fenix/issues/8412 : Passes error handling function to 'CustomTabWindowFeature'
Change required for showing error message when the app can't handle a specific
scheme. Implemented in AC:
https://github.com/mozilla-mobile/android-components/pull/6122
* Upgrade AC version
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
5 years ago
3d7f7cbe5d
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9530 : Don't crash on failed avatar fetches
5 years ago
423d7cfdda
[fenix] Part 6: Kick-off account manager initialization after visual completeness
...
In order to hide the time it takes for the account manager to be initialized
(which always involves disk IO, and often network IO), let's kick it off
after "visual completeness".
This makes sure that for most users, by the time they interact with the account
manager-related functionality (e.g. in Settings), it's ready to go.
Also, for signed-in users, this will establish background sync workers.
5 years ago
1a25bc758e
[fenix] Part 5: Refactor HomeMenu<->HomeFragment interaction
...
This refactor "reverses" relationship between these two classes, allowing
HomeMenu to inform its parent, HomeFragment, of any changes to the menu.
Once that's in place, we start observing account manager changes (once its ready)
for account problems.
This solves two problems:
- initialization of the account manager is no longer necessary to build a home menu
- home menu now starts observing changes to the account manager's state (before it was static)
5 years ago
13deec03a1
[fenix] Part 4: Make sure 'sync is on' snackbar does not initialize account manager
5 years ago
71564af97d
[fenix] Part 3: Mark accountManager as 'lazy' in Mode.kt
...
This is enough to cause it to be initialized only if we're going through onboarding.
5 years ago
1a6e1c0b7f
[fenix] Part 2: Do not eagerly initilize account manager within HomeActivity
...
Instead of always kicking off accountManager's init and telling it to sync right away in
'onResume', we move these tasks to some abstract point later on, whenever account manager
is available.
5 years ago
4e308faf35
[fenix] Part 1: Add 'accountManagerReady' queue to BackgroundServices
...
This gives us an ability to perform tasks against 'accountManager' without
causing its immediate initialization.
5 years ago
ccb08070a7
[fenix] Pre: introduce a RunWhenReadyQueue
...
This replaces the StartupTaskManager we had with a more general class.
New implementation is a thread-safe "gated task executor", which either
runs the task right away if it's marked as 'ready', or queries it to be
executed later on.
This ability to either execute or queue a task will be useful later on in the
commit series.
5 years ago
e488ed1773
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9132 : Update to search animation for top toolbar ( https://github.com/mozilla-mobile/fenix/pull/9524 )
...
* let animation in top toolbar mode play nicely.
* remove duplicate methods, make code readable.
* migrate getToolbarNavOptions method to BrowserAnimator, one method to rule them all.
* Update linting
Co-authored-by: ahmedmamdouh13 <ahmedmamdouh13196@gmail.com>
5 years ago
af892ba291
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7059 - Allow search engines to scroll
5 years ago
8b88382e82
[fenix] Add top sites heading to home screen
5 years ago
ceec72715d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9498 : Replace navargs with viewModel to remember if scroll to tab
5 years ago
f75a0e4347
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9496 : Vertically align collection name and icons to collection icon
5 years ago
df49c9dd94
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9500 - Revert patch for 8568
...
The patch for 8568 introduced this regression.
Let's just revert it until we can come up with a better solution.
5 years ago
de3dda8af1
[fenix] Update to new feature-media API.
5 years ago
24b2efdc89
[fenix] Add secret debug menu to override FxA servers
5 years ago
d2c048aa23
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8764 : Use list component for items in collections
5 years ago
003fb31dfb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8764 : Update collection design, including list elements
5 years ago
8a92e18ff8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9252 : Add progress bar to saved logins view
5 years ago
d27f0cf313
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9252 : Update views visibility ony when list has finished loading
5 years ago
23c3c286de
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/8017 enable SitePermissionsWifiIntegration
5 years ago
7ea1b1ec35
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8568 - Refocus URL editText in SearchFragment onResume
5 years ago
15a8de6f27
[fenix] AboutPageAdapter doesn't use notifyDataSetChanged()
...
We make the AboutPageAdapter inherit from a ListAdapter so that we don't use notifyDataSetChanged().
5 years ago
46e353fd73
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8968 : Hide keyboard when navigating away from browser
5 years ago
47fd3e26fc
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/9280 : Remove tabs fade in animation when pressing on Add new collection
5 years ago
Jovan Gerodetti
Arturo Mejia
ekager
Sawyer Blatz
mcarare
Mihai Eduard Badea
Jonathan Almeida
Falaye Iyanuoluwa
David Walsh
Mihai Branescu
Simon Chae
Vlad Filippov
ValentinTimisica
Roger Yang
Michael
Jeff Boek
Grisha Kruglov
Christian Sadilek
Michael Comella
Emily Kager
Mihai Adrian
Abhay Agarwal
Mugurell
Michael Droettboom
MickeyMoz
Gabriel Luong
codrut.topliceanu
Sebastian Kaspari
Edouard Oger
mcarare
Amaan Marfatia