47366000e3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9670 : Disabled intermittent tabMediaControlButton test ( https://github.com/mozilla-mobile/fenix/pull/9679 )
...
and removed file created by mistake -e
added reason for disabled tests
5 years ago
dca4c74a30
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3262 - Enable pull down to refresh in Nightly
5 years ago
09253e7566
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 - review: clarify comments in new test runner.
5 years ago
74fbc518db
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : Add LintUnitTestRunner gradle task.
...
This will prevent us from regressing on adding older versions of the
unit test runner.
5 years ago
5d2c577c64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : TestApplication -> FenixRobolectricTestApplication.
...
This disambiguates it from the FirefoxTestApplication used in on-device
tests.
5 years ago
dff3a69dc3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : move TestApplication to the helpers package.
...
The helpers/ package is created to separate the test support code from
the code under test.
5 years ago
f11bb37121
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : replace unit test runners with FenixRobolectricTestRunner.
...
This is how we can apply the new test runner to remove duplication.
This commit was generated programmatically with the following commands:
```
// Replace test runners with new one.
find app/src/test -type f -exec gsed -i "s/@RunWith(RobolectricTestRunner::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
find app/src/test -type f -exec gsed -i "s/@RunWith(AndroidJUnit4::class)/@RunWith(FenixRobolectricTestRunner::class)/" {} +
// Replace imports of old test runners with new one
find app/src/test -type f -exec gsed -i "s/org.robolectric.RobolectricTestRunner/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
find app/src/test -type f -exec gsed -i "s/androidx.test.ext.junit.runners.AndroidJUnit4/org.mozilla.fenix.helpers.FenixRobolectricTestRunner/" {} +
// Remove unused imports
find app/src/test -type f -exec gsed -i "/@Config(application = TestApplication::class)/d" {} +
find app/src/test -type f -exec gsed -i "/import org.mozilla.fenix.TestApplication/d" {} +
find app/src/test -type f -exec gsed -i "/import org.robolectric.annotation.Config/d" {} +
```
Where gsed is the GNU version of sed installed via homebrew. After
running these commands, I need to manually clean up the following files:
- FenixRobolectricTestRunner
- LocaleManagerExtensionTest
5 years ago
b401d400b3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : add FenixRobolectricTestRunner.
...
This class will help us reduce duplication by specifying the
configuration within the test runner rather than each test needing to
specify it itself.
This class is adapted from Firefox for Fire TV:
https://github.com/mozilla-mobile/firefox-tv/blob/master/app/src/test/java/org/mozilla/tv/firefox/helpers/FirefoxRobolectricTestRunner.kt
5 years ago
774a07d5f7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : remove unnecessary @RunWith(Robolectric in unit tests.
...
robolectric increases the run time of tests so it's important to remove
them when they're unnecessary.
Between this change and the last one, the unit test runtime was reduced
by ~10s.
5 years ago
b9ffb3ddcc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9605 : remove unnecessary @RunWith(AndroidJUnit4) in unit tests.
...
In unit tests, this annotation annotations defer to robolectric, non-trivially
increasing test runtime so it's important to remove them when they're
unnecessary.
5 years ago
3489fe1e22
[fenix] No issue: re-enable libraryMenuItemsTest and backButtonTest ( https://github.com/mozilla-mobile/fenix/pull/9639 )
5 years ago
0487e0ad62
[fenix] Update Android Components version to 38.0.20200403130109.
5 years ago
caded80288
[fenix] Import l10n.
5 years ago
cb29b33e21
[fenix] No issue: add kdoc to HomeActivity.
...
We could consider renaming the Activity to make it clearer that it's the
main activity and doesn't just feature the homescreen but I'm concerned
that renaming it will break too many things (e.g. automation that starts
a specific activity). For quick fix, I added this comment.
5 years ago
9e5e780a9a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9128 & https://github.com/mozilla-mobile/fenix/issues/9222 & https://github.com/mozilla-mobile/fenix/issues/9499 : Refactors snackbar creation and fixes placement ( https://github.com/mozilla-mobile/fenix/pull/9628 )
5 years ago
b2d81076f9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7978 - Put views above button in scrollView ( https://github.com/mozilla-mobile/fenix/pull/8819 )
5 years ago
e754578cef
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6174 - Add telemetry for WebExtensions ( https://github.com/mozilla-mobile/fenix/pull/8318 )
5 years ago
2f02eeb972
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9604 : Swap and adjust margin with padding to avoid text being cut ( https://github.com/mozilla-mobile/fenix/pull/9617 )
5 years ago
006e32c454
[fenix] No issue: remove unused FirefoxTestRunner.
...
It would be used for on device tests but it doesn't seem to hooked up
currently.
5 years ago
f7f452367d
[fenix] Import l10n.
5 years ago
7e54f731db
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9422 : Nit: Fix xml indenting
5 years ago
34394af021
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9422 : Align widget text to viewStart to support RTL layouts
5 years ago
2ec2ee395b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/768 : Add first time PWA dialog ( https://github.com/mozilla-mobile/fenix/pull/9308 )
...
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
5 years ago
548a18ba32
[fenix] Use same configuration for "forPerformanceTest" builds like we do for "fennec" flavor builds.
5 years ago
a96fa3b790
[fenix] Prevent favicons from flashing when items are selected in History ( https://github.com/mozilla-mobile/fenix/pull/9233 )
5 years ago
66d28a700c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9336 Check current destination before navigating ( https://github.com/mozilla-mobile/fenix/pull/9353 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9336 Check current destination before navigating
* For https://github.com/mozilla-mobile/fenix/issues/9336 Update unit test to check for navigateSafe
5 years ago
d6fe360148
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9423 : Align preference title and summary to viewStart ( https://github.com/mozilla-mobile/fenix/pull/9426 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9423 : Align preference title and summary to viewStart
* Update checkbox_left_preference_etp.xml
Co-authored-by: Jeff Boek <jeff@jeffboek.com>
5 years ago
8224f61cb3
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9533 - Switch to using enum for Library Item Selected Telemetry
5 years ago
4b91238222
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9553 : Only update account UI state once when creating SettingsFragment
5 years ago
ea9add8d2b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8125 - Send top sites count with metrics ping
5 years ago
ef2d26efee
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9365 : Partially reverse menu items order when using top toolbar
5 years ago
011b4f7fbd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9365 : Update naming to reflect history item
5 years ago
67bf4073ad
[fenix] NoIssueFixMetropolisAccountPref
5 years ago
eb99ae1fef
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9598 & https://github.com/mozilla-mobile/fenix/issues/8697 : Fixes force expand crash ( https://github.com/mozilla-mobile/fenix/pull/9599 )
5 years ago
7b333febc0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9549 - Scrolling to top sites now includes header.
5 years ago
c0b09436d0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9574 : Remove category layout from LeakCanary SwitchPreference
5 years ago
d1d0a09f21
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9564 : Fixes cut off strings in ETP panel
5 years ago
d80763ee11
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9109 - remove the sync error highlight from three-dot menu
5 years ago
1ccd93d99a
[fenix] For 3687 Use Metropolis Font for Header
5 years ago
9cb58154bb
[fenix] Import l10n.
5 years ago
12e3619a2e
[fenix] Make sure reconnect item is displayed in HomeMenu in case of account problems
...
AccountObserver listeners were being triggered correctly, however, during every time
we open HomeFragment, home menu gets re-created, which causes us to re-run the initialization
block. Before this patch, the init block would never touch the account manager.
After this patch, it will query it if account manager has already been initialized.
5 years ago
8d1befd34c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9561 : Fix initialization order in HomeMenu
...
`init` blocks are executed before `val` initialization which is declared afterwards
in the class. In this case, we had `quitItem` and `reconnectToSyncItem` as lazy,
but declared after the `init` block which may need them. And so, while this compiles
just fine, in practice we run into an NPE as the `init` block tries to get the lazy's value.
Simply re-ordering initialization fixes the problem.
5 years ago
12237fdca1
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/8520 : Polish Add-on manager UIs
5 years ago
72e91ad94a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9472 : ForceExpand browser toolbar when navigating ( https://github.com/mozilla-mobile/fenix/pull/9552 )
5 years ago
8dbcd4ed35
[fenix] Updated the method to verify system notifications and added new tests for media notifications ( https://github.com/mozilla-mobile/fenix/pull/9330 )
5 years ago
7d57c791f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8412 : Passes error handling function to 'CustomTabWindowFeature' ( https://github.com/mozilla-mobile/fenix/pull/8903 )
...
* For https://github.com/mozilla-mobile/fenix/issues/8412 : Passes error handling function to 'CustomTabWindowFeature'
Change required for showing error message when the app can't handle a specific
scheme. Implemented in AC:
https://github.com/mozilla-mobile/android-components/pull/6122
* Upgrade AC version
Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
5 years ago
3d7f7cbe5d
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9530 : Don't crash on failed avatar fetches
5 years ago
59910e8d82
[fenix] Import l10n.
5 years ago
423d7cfdda
[fenix] Part 6: Kick-off account manager initialization after visual completeness
...
In order to hide the time it takes for the account manager to be initialized
(which always involves disk IO, and often network IO), let's kick it off
after "visual completeness".
This makes sure that for most users, by the time they interact with the account
manager-related functionality (e.g. in Settings), it's ready to go.
Also, for signed-in users, this will establish background sync workers.
5 years ago
1a25bc758e
[fenix] Part 5: Refactor HomeMenu<->HomeFragment interaction
...
This refactor "reverses" relationship between these two classes, allowing
HomeMenu to inform its parent, HomeFragment, of any changes to the menu.
Once that's in place, we start observing account manager changes (once its ready)
for account problems.
This solves two problems:
- initialization of the account manager is no longer necessary to build a home menu
- home menu now starts observing changes to the account manager's state (before it was static)
5 years ago
13deec03a1
[fenix] Part 4: Make sure 'sync is on' snackbar does not initialize account manager
5 years ago
71564af97d
[fenix] Part 3: Mark accountManager as 'lazy' in Mode.kt
...
This is enough to cause it to be initialized only if we're going through onboarding.
5 years ago
1a6e1c0b7f
[fenix] Part 2: Do not eagerly initilize account manager within HomeActivity
...
Instead of always kicking off accountManager's init and telling it to sync right away in
'onResume', we move these tasks to some abstract point later on, whenever account manager
is available.
5 years ago
4e308faf35
[fenix] Part 1: Add 'accountManagerReady' queue to BackgroundServices
...
This gives us an ability to perform tasks against 'accountManager' without
causing its immediate initialization.
5 years ago
ccb08070a7
[fenix] Pre: introduce a RunWhenReadyQueue
...
This replaces the StartupTaskManager we had with a more general class.
New implementation is a thread-safe "gated task executor", which either
runs the task right away if it's marked as 'ready', or queries it to be
executed later on.
This ability to either execute or queue a task will be useful later on in the
commit series.
5 years ago
e8cfeeb0a1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9189 : Fixes "static asset not found" error in doNotSaveLoginFromPromptTest, saveLoginFromPromptTest UI tests ( https://github.com/mozilla-mobile/fenix/pull/9439 )
...
AndroidAssetDispatcher class dispatcher was attempting to open a local asset with a query suffix from the request. If query suffix is found, remove it. Re-enable saveLoginFromPromptTest() and doNotSaveLoginFromPromptTest()
5 years ago
207fa5752a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9525 - Add bottom margin to top sites header
5 years ago
e488ed1773
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9132 : Update to search animation for top toolbar ( https://github.com/mozilla-mobile/fenix/pull/9524 )
...
* let animation in top toolbar mode play nicely.
* remove duplicate methods, make code readable.
* migrate getToolbarNavOptions method to BrowserAnimator, one method to rule them all.
* Update linting
Co-authored-by: ahmedmamdouh13 <ahmedmamdouh13196@gmail.com>
5 years ago
23656b2f53
[fenix] Use existing strings for announcement
5 years ago
e3427ab39f
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7720 :
...
- Increased atp switch size to be consistent with `dimen/tracking_protection_item_height`(48dp).
- Cut out redundant traversal of TextViews in SwitchWithTraversal as per https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md
- Reuse `QuickSettingsText.Icon` style on the switch component to be consistent with other items in the component_tracking_protection_panel.xml
- Added new string resources for textOff and textOn state to get appropriate screen reader description (unsure of the translation/localisation process here!)
5 years ago
af892ba291
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7059 - Allow search engines to scroll
5 years ago
8b88382e82
[fenix] Add top sites heading to home screen
5 years ago
3fa441bedb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9498 : Update unit tests with new constructor argument
5 years ago
ceec72715d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9498 : Replace navargs with viewModel to remember if scroll to tab
5 years ago
f75a0e4347
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9496 : Vertically align collection name and icons to collection icon
5 years ago
f3e86f841d
[fenix] Update NotYetSupported add-ons copy
5 years ago
df49c9dd94
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9500 - Revert patch for 8568
...
The patch for 8568 introduced this regression.
Let's just revert it until we can come up with a better solution.
5 years ago
de3dda8af1
[fenix] Update to new feature-media API.
5 years ago
1030317365
[fenix] Import l10n.
5 years ago
24b2efdc89
[fenix] Add secret debug menu to override FxA servers
5 years ago
d2c048aa23
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8764 : Use list component for items in collections
5 years ago
003fb31dfb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8764 : Update collection design, including list elements
5 years ago
8a92e18ff8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9252 : Add progress bar to saved logins view
5 years ago
d27f0cf313
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9252 : Update views visibility ony when list has finished loading
5 years ago
23c3c286de
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/8017 enable SitePermissionsWifiIntegration
5 years ago
14de8badde
[fenix] Import l10n.
5 years ago
7ea1b1ec35
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8568 - Refocus URL editText in SearchFragment onResume
5 years ago
15a8de6f27
[fenix] AboutPageAdapter doesn't use notifyDataSetChanged()
...
We make the AboutPageAdapter inherit from a ListAdapter so that we don't use notifyDataSetChanged().
5 years ago
608a6531a5
[fenix] No issue - Make fill link from clipboard divider stretch full screen
5 years ago
b52f5a3829
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8485 Update UI tests after settings reorg
5 years ago
e7d435420f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8485 Move Remote debugging and LeakCanary to Advanced section
5 years ago
46e353fd73
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8968 : Hide keyboard when navigating away from browser
5 years ago
47fd3e26fc
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/9280 : Remove tabs fade in animation when pressing on Add new collection
5 years ago
a09fad7f74
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8651 - Add HistoryInteractor/Controller unit/ui tests
5 years ago
76642b79ff
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8651 - Ensure FenixSnackbar has a proper root for inflating into
...
FenixSnackbar, as the platform Snackbar can only be inflated in either a
`CoordinatorLayout` or a `FrameLayout`.
Ensure our HistoryFragment's layout uses one of these as it's root.
5 years ago
2bd3a7d137
[fenix] Fix https://github.com/mozilla-mobile/fenix/issues/8651 - Add new menu actions for a history item
...
We'll now also support:
- Copy url
- Share to another FXA device
- Open in new tab
- Open in private tab
5 years ago
15d82b8535
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9435 : Adjust margins and paddings to mirror correctly in RTL
5 years ago
7c4db6a8af
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9352 - changed capitalisation of 'Open in app'
5 years ago
d6928f84f6
[fenix] No issue - Add content descriptions when missing
5 years ago
b65982aba1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7356 : Scroll to selected tab when pressing tab overview
5 years ago
ccee01a230
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/8944 - Adds custom lint checks
5 years ago
058e6b3e9f
[fenix] No issue: Removes settings entrance animation for now ( https://github.com/mozilla-mobile/fenix/pull/9443 )
5 years ago
2b725c6345
[fenix] Replaced name field with search string field
5 years ago
0dd3a735f1
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4987 : Remove close tabs functionality when they are added to a collection
5 years ago
0e678b153f
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/7734 : Remove animation for back button
5 years ago
7233d650bb
[fenix] Import l10n.
5 years ago
6138eb18e3
[fenix] No issue: Fixes indentations on several settings fragments ( https://github.com/mozilla-mobile/fenix/pull/9442 )
5 years ago
0c9b5ec2a9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/9414 : Make AMO collection configurable
5 years ago
31143e7a88
[fenix] Perform storage warm-up after visual completeness
5 years ago
439608e308
[fenix] Pass lazy references to FennecMigrator
5 years ago
Oana Horvath
Mugurell
Michael Comella
Aaron Train
MickeyMoz
Mozilla L10n Automation Bot
Sawyer Blatz
Codrut Topliceanu
Gabriel Luong
Mihai Adrian
mcarare
Emily Kager
Sebastian Kaspari
David Walsh
Grisha Kruglov
Kate Glazko
codrut.topliceanu
Mihai Branescu
Kate Glazko
Arturo Mejia
ValentinTimisica
asavill
Simon Chae
Edouard Oger
mcarare
Amaan Marfatia
ekager
Mihai Eduard Badea
Christian Sadilek