f3d5862668
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6521 - Remove auto sigin onboarding card ( https://github.com/mozilla-mobile/fenix/pull/16315 )
...
With the Fennec -> Fenix migration complete there is no other Mozilla
application that would serve as a custom account provider hence the automatic
signin would not be possible.
Make this more obvious by commenting out the code that would trigger an
onboarding banner for it but keep the code in the app for when https://github.com/mozilla-mobile/fenix/issues/15694 would add
to Fenix the ability to serve as a custom account provider.
4 years ago
0a8d8cfbf0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16323 - Use 10dp corner radius for the selected outer border of a grid item ( https://github.com/mozilla-mobile/fenix/pull/16364 )
...
This would ensure the corners of the inner and outer borders are aligned, with
no empty gap between them.
4 years ago
0e28b0c8fe
[fenix] Update Android Components version to 65.0.20201103190112
4 years ago
2f04b48e7c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14980 - Effectively disable tabs tray STATE_HALF_EXPANDED ( https://github.com/mozilla-mobile/fenix/pull/16052 )
...
STATE_HALF_EXPANDED cannot be disabled while also keeping fitToContents = true
based on which the tabs tray layout is currently set.
To work around this we'll set a a minuscule height for the tab tray when in
this state and then immediately advance to STATE_HIDDEN so to make it
imperceptible to the users.
Since I couldn't write unit tests because of InflateExceptions in Robolectric
I've written UI tests to protect against regressions.
4 years ago
c7c56aa055
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/16348 - Increase Gradle daemon memory size ( https://github.com/mozilla-mobile/fenix/pull/16349 )
4 years ago
647117ca54
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13172 - Tab swipe order follows text direction from oldest to newest ( https://github.com/mozilla-mobile/fenix/pull/16178 )
4 years ago
7dab7b2d53
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12971 - Show collection saved snackbar above FAB ( https://github.com/mozilla-mobile/fenix/pull/16311 )
4 years ago
24d2b31b74
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15847 - Disables verifyAboutFirefoxPreview UI test ( https://github.com/mozilla-mobile/fenix/pull/16346 )
4 years ago
5311233fae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16339 - Initialize FxaAccountManager with also a CrashReporter ( https://github.com/mozilla-mobile/fenix/pull/16340 )
4 years ago
03343e86ed
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/16256 : Introduce build flag for "Mozilla Online" variant.
...
This patch introduces a build flag that can be used on demand on the command line (`./gradlew -PmozillaOnline [..}`) or
permanently when added to local.properties (`mozillaOnline`).
At runtime `Config.channel.isMozillaOnline` will return `true` if the flag was set at build time.
4 years ago
4fe05cc97c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13446 UI tests: wait for historyList to exist
4 years ago
9007d8d33e
[fenix] Import l10n.
4 years ago
ba18f60d64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14636 - Update preference section headers to use correct color, spacing and rulers ( https://github.com/mozilla-mobile/fenix/pull/16332 )
4 years ago
b495ffee53
[fenix] No issue - review: clarify thread safety of suppressionCount.
4 years ago
6fed5f3177
[fenix] No issue: make StrictMode suppression count thread safe.
4 years ago
ecd79c4d6e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12062 : Switch to consumeFlow and add tests
4 years ago
5991d0996e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4652 - Remove activityViewModels workarounds
4 years ago
78850c7e3d
[fenix] 15278 detekt rule runblocking ( https://github.com/mozilla-mobile/fenix/pull/15942 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15278 : added CoroutineManager to count runBlocking calls
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added actual detekt rule for runblocking and its config to the yaml
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added unit test for RunblockingCounter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : renamed StrictModeStartupSuppressionCountTest.kt to PerformanceStartupTest.kt and added runBlockingCount test
* Lint fix
* For https://github.com/mozilla-mobile/fenix/issues/15278 : made runblocking a Long to prevent overflow
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fixed MozRunblocking name, description and moved RunBlockingCounter to perf package
* For https://github.com/mozilla-mobile/fenix/issues/15278:Renamed MozillaRunblockingCheck to MozillaRunBlockingCheck
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added setup for unit test, since it failed without restting counter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Fixed naming for RunBlocking lint check
* For https://github.com/mozilla-mobile/fenix/issues/15278 : removed changes made to test to use runBlockingIncrement
* For https://github.com/mozilla-mobile/fenix/issues/15728 : added test exclusion for runBlocking check
* For https://github.com/mozilla-mobile/fenix/issues/15278 : changed null check and added Synchronized to count setter
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fix for nits
* For https://github.com/mozilla-mobile/fenix/issues/15278 : added StartupExcessiveResourceUseTest to CODEOWNERS
* For https://github.com/mozilla-mobile/fenix/issues/15278 : fixed for nits
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Moved increment function to extension function and fixed indentation
* For https://github.com/mozilla-mobile/fenix/issues/15278 : Added tests for Atomic Integer extension and nit fix
4 years ago
e564dda990
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6313 - Remove unneeded delay in BrowserAnimator
4 years ago
f60df4a976
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16268 - Allowing multiple task while sharing ( https://github.com/mozilla-mobile/fenix/pull/16275 )
4 years ago
3139337d7f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15931 : Sort Downloads from newest to oldest ( https://github.com/mozilla-mobile/fenix/pull/15939 )
4 years ago
e682cb55cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15430 : Fix StrictMode death on opening app from widget voice search.
4 years ago
c66ab231d5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15430 : Fix StrictMode death on opening app from widget text search.
4 years ago
87ce122d03
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14552 : Do not display back button when there is no tab history.
4 years ago
95d1497c25
[fenix] Update Android Components version to 65.0.20201101143039.
4 years ago
a94eca1063
[fenix] Import l10n.
4 years ago
95d897d7c1
[fenix] Update Android Components version to 65.0.20201031143038.
4 years ago
133965917c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 - post: add lint test dependencies to android-gradle-dependencies script.
...
`assemble` doesn't assemble the tests so we need to run `test`.
`testClasses` isn't good enough because, according to `--profile`, it
doesn't include dependencies for `testRuntimeClasspath`.
4 years ago
7479db73fe
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : run lint rules tests in CI.
...
This works but it's imperfect: when the tests fail, it links to the lint
failure artifacts rather than the test failure artifacts.
4 years ago
62a0f6b088
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : add lint rules tests to pre-push hook.
4 years ago
424af26340
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : add MozillaStrictModeSuppressionTest.
4 years ago
5ed416405e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : correctly configure JUnit for mozilla-detekt-rules.
...
Without this, the tests would not run from the command line though they
could run in Android Studio.
4 years ago
ce90102a75
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : add ConstraintLayoutPerfDetectorTest to code owners.
4 years ago
9ddef29862
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : add ConstraintLayoutPerfDetectorTest.
...
I had to ignore one of the tests because the linter test API seemed to
be broken. All of these APIs are beta so I didn't think it was worth
trying to force it to work.
4 years ago
cb07bf265d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : remove super.visitElement for ConstraintLayout lint.
...
It caused a test to fail because super.visitElement asserted false
because it expected to be overriden. It was correctly overridden - we
were just still calling through to super anyway.
4 years ago
3f31e4cc1b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15707 : clean up lint rules dependencies.
...
For mozilla-detekt-rules, the tests didn't compile at all so apparently
they haven't been running in testing.
mozilla-lint-rules worked but they were not clean.
4 years ago
b85522198c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15963 - Increase touch target for the close button in the tabs tray grid layout
...
We need to ensure it has at least 48dp while also not appearing too big.
4 years ago
58a22af103
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15757 - Avoid the double spacing issues for grid items in tabs tray
...
Items should have a 16dp all around padding.
Have them have a 8dp padding that will add to 16 when placed together.
Have the parent have another 8dp that will add to 16 for when items are placed
to the edge of the available screen.
4 years ago
0dd114beb8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15968 - Show a border for the selected tab in the grid based tabs tray
...
The border for the grid item will now be updated in the same method that
updates the background for the list item.
4 years ago
f90db55a2f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15756 - Add a play/pause button in the tabs tray grid layout
...
Moved the previous layout in a new, bigger FrameLayout that would serve as a
buffer space for the play/pause button to be translated to the exterior.
Otherwise the button would be clipped.
4 years ago
949d66da5f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9548 - Ability to rename top sites ( https://github.com/mozilla-mobile/fenix/pull/16285 )
...
* Ability to rename top sites, closes https://github.com/mozilla-mobile/fenix/issues/9548
* Highlight the "Remove" top site action as destructive
With more menu items in the top site contextual menu, it makes sense to differentiate
* Added test for the top site renaming action
* Fixed lint check (wildcard imports, blank spaces)
* Applied suggestions from code review
* Apply suggestions from code review
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
* Implemented dialog click listener with manual dismiss/cancel
Co-authored-by: Lorenzo Stanco <lorenzo.stanco@gmail.com>
4 years ago
ccb507dc60
[fenix] Update Android Components version to 65.0.20201030143049. ( https://github.com/mozilla-mobile/fenix/pull/16286 )
4 years ago
45aa002f94
[fenix] Bug 1674186 - Use shippable platforms for Browsertime tests. ( https://github.com/mozilla-mobile/fenix/pull/16261 )
...
* Use shippable platforms.
* Undo testing changes.
4 years ago
c4d7e19da6
[fenix] No issue: Make sure we are cleaning up test coroutines
4 years ago
0a9821fdbb
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16274 )
4 years ago
986e28f100
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16161 - Fixes Saved Login toolbar layout
4 years ago
2d083e853a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14637 - Fix sitePermissionsFeature breaking change + AC bump ( https://github.com/mozilla-mobile/fenix/pull/16229 )
...
* For https://github.com/mozilla-mobile/fenix/issues/14637 - Compatibility patch for AC - 8554
* Update Android Components version to 65.0.20201029143039
Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
4 years ago
f15d1054bb
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/16240 )
4 years ago
3047ea3601
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16250 : Disable remote USB debugging for SDK <23.
4 years ago
5fb5471df1
[fenix] For # 15929: Remove the search widget discoverability experiment. ( https://github.com/mozilla-mobile/fenix/pull/16081 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15929 : Remove SearchWidgetCFR telemetry.
* For https://github.com/mozilla-mobile/fenix/issues/15929 : Remove SearchWidgetCFR and search widget experiment.
* For https://github.com/mozilla-mobile/fenix/issues/15929 : Remove unit tests references to search widget experiment.
4 years ago
Mugurell
MickeyMoz
Stefan Arentz
Mihai Adrian Carare
Rafał Opiłowski
Oana Horvath
Sebastian Kaspari
Mozilla L10n Automation Bot
Gabriel Luong
Michael Comella
Christian Sadilek
ekager
MarcLeclair
Roger Yang
Jocelyne Abi Haidar
mcarare
Mickey Moz
Gregory Mierzwinski
mozilla-l10n-automation-bot
Codrut Topliceanu