Michael Comella
4e7658e479
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 - post: ignore new StrictMode rule in tests.
4 years ago
Michael Comella
0934b7fe93
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 - review: add clarifying comments.
4 years ago
Michael Comella
86a44fb728
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add marker when StrictMode is suppressed.
4 years ago
Michael Comella
19904397b2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add MozillaStrictModeSuppression detekt check.
4 years ago
Michael Comella
7a4230df00
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : improve custom detekt violation output.
...
Before it used to output the violations all one one line. Now it looks
like:
```
MozillaStrictModeSuppression:
'import mozilla.components.support.ktx.android.os.resetAfter' at
(17,1) in /StrictModeManager.kt
Please use `components.strictMode.resetAfter` instead because it has
performance improvements and additional code to monitor for performance
regressions.
MozillaStrictModeSuppression:
'setThreadPolicy(threadPolicy.build())' at (56,24) in
/StrictModeManager.kt
Please use `components.strictMode.resetAfter` instead because it has
performance improvements and additional code to monitor for performance
regressions.
MozillaStrictModeSuppression:
'setVmPolicy(builder.build())' at (71,24) in /StrictModeManager.kt
NOT YET IMPLEMENTED: please consult the perf team about
implementing`StrictModeManager.resetAfter`: we want to understand the
performance implications of suppressing setVmPolicy before allowing it.
```
4 years ago
Michael Comella
d253b9060e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add test to prevent increasing StrictMode suppression count.
4 years ago
Michael Comella
3e9f93a0ab
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add HomeActivityTestRule.skipOnboarding.
...
This is more correct, faster, and results in less copy-paste duplication
than the current behavior:
homeScreen { }.dismissOnboarding()
Which opens settings to dismiss onboarding.
4 years ago
Michael Comella
b6609a0747
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : count StrictMode suppressions on startup.
4 years ago
Jocelyne Abi Haidar
efc846d57a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15675 : Disable Save button when editing saved login until something has been changed
...
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
4 years ago
mozilla-l10n-automation-bot
1d8006f733
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/15712 )
4 years ago
Mozilla L10n Automation Bot
ded58ad2b7
[fenix] Import l10n.
4 years ago
mcarare
8668f5a0d6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15632 : Improve checking open tabs logic to show collection button.
...
Check now considers selected tab tray mode.
4 years ago
ekager
c5a6e86f9b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15600 - Move removal of timed out sessions to immediately after restoration
4 years ago
Roger Yang
15cab56493
[fenix] Revert "No issue: remove * ac from codeowners." ( https://github.com/mozilla-mobile/fenix/pull/15638 )
...
This reverts commit 112510aab50b141f910de211e2363c6b81882431.
4 years ago
Michael Comella
dbd9a99c76
[fenix] No issue: add custom lint guide to readme.
4 years ago
MickeyMoz
3cc3ed7e59
[fenix] Update Android Components version to 62.0.20201002143132.
4 years ago
ekager
d9aefd1ce2
[fenix] No issue: Update biometric, core, and recyclerview libraries
4 years ago
mcarare
1add1c7454
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13031 : Show size in KB for smaller downloaded files.
4 years ago
Mozilla L10n Automation Bot
c318e736f9
[fenix] Import l10n.
4 years ago
Michael Comella
1d7eaed3ba
[fenix] No issue: remove * ac from codeowners.
...
rocketsroger and I agreed this may be undesireable due to the increased
notifications. If we remove it and someone complains, we can re-add it.
4 years ago
Jocelyne
cc4d4a14d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10107 : Show Today and Yesterday labels in History ( https://github.com/mozilla-mobile/fenix/pull/15415 )
4 years ago
Michael Comella
e1ffe1108f
[fenix] No issue: replace LintUnitTestRunner with detekt implementation.
...
This should be more performant and easier to maintain.
4 years ago
Michael Comella
7e5cad1e66
[fenix] No issue: run detekt on unit test files.
...
detekt still passes after I make this change.
afaik, there isn't a good reason not to run it on unit tests and it can
be valuable to add custom rules for them. Also, detekt is already
running on our androidTest directory.
4 years ago
Jeff Boek
d81eff94bd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15593 - Reverts back to simple UUID creation without Fenix side caching
4 years ago
MickeyMoz
5c98159598
[fenix] Update Android Components version to 62.0.20201001194334.
4 years ago
Michael Comella
c4c94979ea
[fenix] No issue: document list_compatible_dependency_versions script in README.
4 years ago
Jocelyne
635e49092e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15471 : Show Delete button in red in multi-select overflow menu ( https://github.com/mozilla-mobile/fenix/pull/15576 )
4 years ago
Mozilla L10n Automation Bot
482efed8de
[fenix] Import l10n.
4 years ago
Grisha Kruglov
a41022554b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15443 : Use fragment's lifecycleScope for AlertDialog actions
4 years ago
Christian Sadilek
33e49d471b
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/15555 : Set channel to Nightly explicitly for SettingsFragmentTest
4 years ago
mcarare
1589942479
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15559 : Allow tabs to stretch in landscape mode for tablets.
...
This overrides the default tabMaxWidth of 264dp to allow for tabGravity="fill".
4 years ago
Christian Sadilek
a846743af4
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15555 : Intermittent failures in SettingsFragmentTest
4 years ago
Stefan Arentz
a0c00cb3b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15537 - Be more verbose about leanplum identifiers ( https://github.com/mozilla-mobile/fenix/pull/15538 )
4 years ago
mcarare
192e5dc063
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15535 : hasOpenTabs now considers the selected tab mode in tray tab.
4 years ago
Ben Hearsum
6977b53c5f
[fenix] Block github tagging on push-apk ( https://github.com/mozilla-mobile/fenix/pull/15546 )
...
Currently, push-apk fails to verify its chain of trust if github tagging
is done before it runs. Until this is fixed, we need to make sure
tagging is blocked on pushing.
4 years ago
Michael Comella
af732f0748
[fenix] No issue: elaborate on Components class doc.
...
This is to clarify a misunderstanding I found in PR review.
4 years ago
Sebastian Kaspari
70dbf0d765
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass metrics to share controller" for debug test failures.
...
This reverts commit 5de145914e9fc10d3d647e6f2856c2df19dd9156.
4 years ago
Sebastian Kaspari
9b598b33d8
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass bookmark storage to controller" for debug test failures.
...
This reverts commit 9825a5d2dfb0f6d3c0235fdf0032e510c34bf20a.
4 years ago
Andrew Gaul
43778cf3cb
[fenix] Show undo snackbars with padding with static bottom toolbar
...
This specifically fixes the close tab snackbar. This commit mirrors
the logic when not using Undo from
e14bf8e791aa56ded47812018f32ee9801a5b4f9. References https://github.com/mozilla-mobile/fenix/issues/14982 .
4 years ago
ekager
1429c5ddaf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15324 - Show tab settings and recently closed items in menu when no tabs
4 years ago
ekager
8caf149ab7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15503 - Change recently closed max to 10
4 years ago
TrianguloY
98f8f3b2ca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13856 - Prevent overscroll in swipe to switch tabs gesture
4 years ago
Tiger Oakes
5a3b5af7d9
[fenix] Extract locale settings initial state
4 years ago
Tiger Oakes
be11bfd5b4
[fenix] Add test for initial logins list state
4 years ago
Tiger Oakes
e4bdd355d3
[fenix] Add tests for initial collection creation state
4 years ago
Sören Hentzschel
ac1a2a708a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11561 - changed inactive heading and menu icon color in dark mode
4 years ago
Mozilla L10n Automation Bot
87ecdf8bfb
[fenix] Import l10n.
4 years ago
Tiger Oakes
b55c4af6fb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass bookmark storage to controller
4 years ago
Tiger Oakes
966e13c9aa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass metrics to share controller
4 years ago
Michael Comella
a50cf27648
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : fix startup crash by using arg Context.
...
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
4 years ago