efc846d57a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15675 : Disable Save button when editing saved login until something has been changed
...
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
4 years ago
1d8006f733
[fenix] Import l10n. ( https://github.com/mozilla-mobile/fenix/pull/15712 )
4 years ago
ded58ad2b7
[fenix] Import l10n.
4 years ago
8668f5a0d6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15632 : Improve checking open tabs logic to show collection button.
...
Check now considers selected tab tray mode.
4 years ago
c5a6e86f9b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15600 - Move removal of timed out sessions to immediately after restoration
4 years ago
d9aefd1ce2
[fenix] No issue: Update biometric, core, and recyclerview libraries
4 years ago
1add1c7454
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13031 : Show size in KB for smaller downloaded files.
4 years ago
c318e736f9
[fenix] Import l10n.
4 years ago
cc4d4a14d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10107 : Show Today and Yesterday labels in History ( https://github.com/mozilla-mobile/fenix/pull/15415 )
4 years ago
e1ffe1108f
[fenix] No issue: replace LintUnitTestRunner with detekt implementation.
...
This should be more performant and easier to maintain.
4 years ago
d81eff94bd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15593 - Reverts back to simple UUID creation without Fenix side caching
4 years ago
635e49092e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15471 : Show Delete button in red in multi-select overflow menu ( https://github.com/mozilla-mobile/fenix/pull/15576 )
4 years ago
482efed8de
[fenix] Import l10n.
4 years ago
a41022554b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15443 : Use fragment's lifecycleScope for AlertDialog actions
4 years ago
33e49d471b
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/15555 : Set channel to Nightly explicitly for SettingsFragmentTest
4 years ago
1589942479
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15559 : Allow tabs to stretch in landscape mode for tablets.
...
This overrides the default tabMaxWidth of 264dp to allow for tabGravity="fill".
4 years ago
a846743af4
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15555 : Intermittent failures in SettingsFragmentTest
4 years ago
a0c00cb3b4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15537 - Be more verbose about leanplum identifiers ( https://github.com/mozilla-mobile/fenix/pull/15538 )
4 years ago
192e5dc063
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15535 : hasOpenTabs now considers the selected tab mode in tray tab.
4 years ago
af732f0748
[fenix] No issue: elaborate on Components class doc.
...
This is to clarify a misunderstanding I found in PR review.
4 years ago
70dbf0d765
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass metrics to share controller" for debug test failures.
...
This reverts commit 5de145914e9fc10d3d647e6f2856c2df19dd9156.
4 years ago
9b598b33d8
[fenix] Revert "For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass bookmark storage to controller" for debug test failures.
...
This reverts commit 9825a5d2dfb0f6d3c0235fdf0032e510c34bf20a.
4 years ago
43778cf3cb
[fenix] Show undo snackbars with padding with static bottom toolbar
...
This specifically fixes the close tab snackbar. This commit mirrors
the logic when not using Undo from
e14bf8e791aa56ded47812018f32ee9801a5b4f9. References https://github.com/mozilla-mobile/fenix/issues/14982 .
4 years ago
1429c5ddaf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15324 - Show tab settings and recently closed items in menu when no tabs
4 years ago
8caf149ab7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15503 - Change recently closed max to 10
4 years ago
98f8f3b2ca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13856 - Prevent overscroll in swipe to switch tabs gesture
4 years ago
5a3b5af7d9
[fenix] Extract locale settings initial state
4 years ago
be11bfd5b4
[fenix] Add test for initial logins list state
4 years ago
e4bdd355d3
[fenix] Add tests for initial collection creation state
4 years ago
ac1a2a708a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11561 - changed inactive heading and menu icon color in dark mode
4 years ago
87ecdf8bfb
[fenix] Import l10n.
4 years ago
b55c4af6fb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass bookmark storage to controller
4 years ago
966e13c9aa
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12565 : Pass metrics to share controller
4 years ago
a50cf27648
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : fix startup crash by using arg Context.
...
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
4 years ago
53bd004f55
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : remove resetAfter & port tests to StrictModeManager.
4 years ago
d0fbe70f10
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : clean up existing StrictMode test names.
4 years ago
8a9472e540
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : move resetAfter into StrictModeManager.
...
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.
Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```
We're going to have to add a lint check to prevent them from doing that.
4 years ago
5f8943f76c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : change StrictModeManager to class from object.
...
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
4 years ago
76018e2fe0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14034 : Add debug preference to override AMO collection in Nightly
4 years ago
9e86e369b6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : comment about duplication in logic in StrictMode.
...
I had to drop a commit that addressed the issue because it was too hard
to fix.
4 years ago
394465e33e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : add comment to explain why we only resetAfter in certain build modes.
4 years ago
c1aa8d396a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : use ac StrictMode.resetAfter rather than duplicating functionality.
4 years ago
b2c01e442f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : rename to attachListenerToDisablePenaltyDeath for clarity.
4 years ago
1ec45f33a2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : remove unused penaltyDialog parameter.
...
Additional branching introduces complexity so we should avoid it when
possible. This branch was also unused so it's more likely to have bugs
if we tried to use it after some refactor.
4 years ago
3b76f2b3fc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : always enable detectNonSdkApiUsage.
...
We don't use penalty death for the VM policy so we theoretically don't
need to disable this check if penalty death is enabled.
4 years ago
eca2b8ecf4
[fenix] Use "undo" implementation from Android Components.
...
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.
Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
4 years ago
788b5bb21e
[fenix] Import l10n.
4 years ago
3ede6cf544
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15310 : Add test for ActivityNotFoundException when sharing to app.
4 years ago
9d9d283dc7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15310 : Also catch ActivityNotFoundException when sharing to app.
4 years ago
b276e9daca
[fenix] No issue: Update AC to 61.0.20200925190057
4 years ago
cf0af49d3b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12383 https://github.com/mozilla-mobile/fenix/issues/15407 https://github.com/mozilla-mobile/fenix/issues/12860 - Switch to using shared view model for session to delete on home
4 years ago
c348e03d0e
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15434 : Don't try to display a 'signed in' snackbar in a 'headless' mode
4 years ago
a0189c8080
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15432 : Invoke UI updates on main thread in response to account events
4 years ago
5bb231cc70
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15436 : Auto-close tabs during startup on the main thread
4 years ago
146aa075dd
[fenix] Configure M5 AMO collection for Nightly/Debug
4 years ago
c5c3b6549d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15130 : Remove "what's new card" check in UI test.
4 years ago
1d7b1df0e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15130 : Remove "what's new card" from onboarding screen.
4 years ago
8774b36f49
[fenix] Import l10n.
4 years ago
739a3520e1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15320 : Ensure Mimetype Other PDF Shows PDF Icon
4 years ago
609857c5f1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14280 , https://github.com/mozilla-mobile/fenix/issues/14743 : Remove old search fragment ( https://github.com/mozilla-mobile/fenix/pull/15169 )
...
* Remove search fragment
* Use new folder to search dialog
* Rebase and lint
* Update tests with search dialog nav directions
* Rename interactor to match naming convention. Remove old controller and point everything to the dialog controller.
4 years ago
2ab099b37b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15349 : Fixes SyncedTabs suggestion not clicking
4 years ago
bc90bd2f31
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15296 : Allow excluding bookmark subtrees when editing parent folder
...
I'm really not a fan of how title overwriting and structure processing are mangled together,
but will leave clearing that up for another day.
4 years ago
fdb3d6c013
[fenix] Import l10n.
4 years ago
9d49be285c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14243 : Pre-land visuals for Close Tabs CFR ( https://github.com/mozilla-mobile/fenix/pull/15171 )
4 years ago
661a48a940
[fenix] Update breaking changes in the FxA/Sync integration
4 years ago
0638e9b3d1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11800 : Hide reveal and clear password icons if the password is empty when editing a saved login ( https://github.com/mozilla-mobile/fenix/pull/15244 )
...
Co-authored-by: Jocelyne Abi Haidar <jocelyne.abihaidar@gotocme.com>
4 years ago
0663cf8916
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/13270 : Do not launch into Fennec's task anymore.
...
Initially we did this to avoid a duplicated task right after the migration from Fennec. We'd end up
with the original task from Fennec and the new one from Fenix; with the Fennec task still showing
Fennec in the app switcher, but launching Fenix once selected.
Anyhow, now on Android 11 this causes the Fenix task to get duplicated. The simple fix is to not
do any of that anymore. This may re-introduce the problem with the Fennec migration, but:
* We are at 100% rollout for quite some time. There are still users migrating, but the impact
of the bug is much lower.
* The bug after the migration was only temporary. This bug here is happening every time you
launch Fenix. So I'd rather fix this than a possible inconvenience right after the migration.
4 years ago
deafcc7387
[fenix] https://github.com/mozilla-mobile/fenix/pull/274-android-l10n : Update create account string to avoid partial translations.
4 years ago
d12fa25350
[fenix] Configure M4 AMO collection for all builds
4 years ago
2ddd7950b9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15219 - Fix tab tray handle size.
...
Also use dimens for the tab history handle.
4 years ago
06036292ae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15262 : Updated margins
4 years ago
65db93b8b5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15291 - Limit current CFRs to show max one every 3 days
4 years ago
9b953c0255
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15263 : Properly update open links in app preference.
4 years ago
5536851865
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15272 - Remove bottom margin for toolbar on enter fullscreen
4 years ago
2f7edfe924
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15121 - Ensure tabs removed while on browser select an available parent session
4 years ago
f887985405
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15268 : Update unit tests for safe navigation to details fragment.
4 years ago
d6f5f88deb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15268 : Use safe navigation to addon details fragments.
4 years ago
90ef2c90bf
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/14524 , https://github.com/mozilla-mobile/fenix/issues/12896 , https://github.com/mozilla-mobile/fenix/issues/13830 : re-enabled strict ETP tests after code bug fix
4 years ago
0b56dd58e4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15284 : Process root titles when creating new folders
...
This also simplifies how we do this. We're no longer creating instances of `DesktopFolder` class
nor creating copies of BookmarkNodes just to display root titles correctly for the 'edit folder' UI.
4 years ago
e2f534e533
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15089 - Disable recently closed in multiselect
4 years ago
231bfe6323
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15112 - Still show recently closed when history empty
4 years ago
4e486c0b40
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15286 : Don't crash when separators are long-touched
4 years ago
3249a5e7f4
[fenix] Import l10n.
4 years ago
9763d05ef2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13934 - Make TabHistory work on PWA/Custom Tabs
4 years ago
f4406b2265
[fenix] No issue: Fixes strict mode death in debug custom tab
4 years ago
0fbfbb5516
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14982 - Show snackbars with padding with static bottom toolbar
4 years ago
abe4ccd2ea
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14458 - dismiss keyboard on fill link from clipboard
4 years ago
a8ce1d6722
[fenix] Import l10n.
4 years ago
6b66dbd5cc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15245 - Remove margin for toolbar on toolbar-less PWA
4 years ago
ddd8d2b7fd
[fenix] Import l10n.
4 years ago
4f6213a2dd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2792 : Display bookmark folders at the top of the bookmarks UI
4 years ago
ec18031057
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15211 : Make sure bookmarks are moved to the end of folders
4 years ago
ba242fb3b9
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15206 : Only track 'move' event if bookmark parent was changed
4 years ago
fa8af7dcd2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11502 : Make sure to always process root titles for parent folders during edit
...
This also switches to a simpler bookmarks query API ('getBookmark') which doesn't fetch
children. We don't need 'children' for this dialog, and so don't need to do the extra work.
4 years ago
f79c9733e1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13157 : Filter out folder being edited from 'select folder' dialog
4 years ago
412ae60537
[fenix] Rename 'visitedAddBookmark' arg to a less confusing name
4 years ago
2e646b696a
[fenix] Remove unused nav arg from 'select folder'
4 years ago
e4bf6224f6
[fenix] Import l10n.
4 years ago
da57dc840d
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/14131 : Move constants to dimens.xml ( https://github.com/mozilla-mobile/fenix/pull/14135 )
...
Co-authored-by: Elise Richards <erichards@mozilla.com>
4 years ago
86c20fc7c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13300 - Adjust the 'Sharing a Collection' layout to prevent overlapping of the close icon and 'Share' label in RTL
...
Note that the "Share" title is still constrained to start at the end of the
close button - I don't know why the previous extra constraint was causing the
differing behavior in LTR and RTL, but this seems to fix it.
4 years ago
Jocelyne Abi Haidar
mozilla-l10n-automation-bot
Mozilla L10n Automation Bot
mcarare
ekager
Jocelyne
Michael Comella
Jeff Boek
Grisha Kruglov
Christian Sadilek
Stefan Arentz
Sebastian Kaspari
Andrew Gaul
TrianguloY
Tiger Oakes
Sören Hentzschel
Kate Glazko
Elise Richards
Jonathan Almeida
Sawyer Blatz
person808
aprabhakara
Oana Horvath
Tom Klein