Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-11 13:11:01 +00:00
Code Issues Releases Wiki Activity
5,810 Commits 67 Branches 115 Tags 1.2 GiB
66b94ced14
Commit Graph

4292 Commits

Author SHA1 Message Date
mcarare
f823a5d246 For #16353: Avoid strict mode death on reading onboarding preference. 2020-11-23 13:33:05 +02:00
mcarare
de1fa74ac1 For #16353: Add unit tests for onboarding finishing conditions. 2020-11-23 10:15:37 +02:00
mcarare
089c79f868 For #16353: Finish onboarding on loading a web page, with exceptions. 2020-11-23 10:15:37 +02:00
mcarare
451f60b095 For #16353: Do not finish onboarding on search dialog opening. 2020-11-23 10:15:37 +02:00
Mozilla L10n Automation Bot
c5b9491619 Import l10n. 2020-11-23 00:27:20 +00:00
Mozilla L10n Automation Bot
7166cf2b48 Import l10n. 2020-11-22 00:26:22 +00:00
Mozilla L10n Automation Bot
9cd2757502 Import l10n. 2020-11-21 00:30:41 +00:00
ekager
b9737bde95 For #16351 - Add divider lines for search dialog 2020-11-20 12:12:07 -08:00
Sebastian Kaspari
2b759e9d6f Integrate new search code from Android Components into Fenix. 2020-11-20 17:45:45 +01:00
MickeyMoz
2904ca8ac0 Update Android Components version to 68.0.20201120125142. 2020-11-20 15:34:45 +00:00
Mozilla L10n Automation Bot
4e598d16fc Import l10n. 2020-11-19 22:46:17 -08:00
jhugman
9cdfb6db4a
Nimbus Global Opt Out (#16543) r=gl 2020-11-19 11:17:25 +00:00
Mozilla L10n Automation Bot
359759753c Import l10n. 2020-11-18 23:03:14 -08:00
ekager
b7fe809ae4 For #16351 - Make homescreen interactive when search dialog is up 2020-11-18 13:53:33 -08:00
mcarare
519885da43 For #15788: Remove nested constraint layout in tabs tray. 2020-11-18 11:31:44 -08:00
mcarare
cf162c69d1 For #15788: Remove nested layouts in search dialog layout. 2020-11-18 11:31:25 -08:00
mozilla-l10n-automation-bot
01ec558811
Import l10n. (#16625) 2020-11-17 21:28:11 -05:00
Jonathan Almeida
cebab81e07
Update Android Components to 67.0.20201117165227 (#16619) 2020-11-17 15:29:54 -05:00
ekager
f520586dcd
For #12062 - Remove feature flag for return to browser (#16622) 2020-11-17 15:28:59 -05:00
Mugurell
ef5846dc3e
For #16614 - Ensure a stable order for the items in tabs tray. (#16618) 
Items should follow the following ordering:
- current session open tabs
- collections options - currently the "Select tabs" button
- synced tabs items

This order should also be kept after returning from Multiselect mode.
 2020-11-17 13:33:41 -05:00
Bryan Kok
5f9de1e261 Replace @string/tab_tray_menu_item_save with @string/tab_tray_menu_select, Remove "Share all tabs" option from tab tray's private browsing menu 2020-11-17 09:16:55 -08:00
ekager
614471495d
For #15091 - Fixes RecentlyClosedAdapter DiffCallback (#16608) 2020-11-17 10:40:33 -05:00
Mozilla L10n Automation Bot
edfb85b021 Import l10n. 2020-11-16 17:33:42 -08:00
Christian Sadilek
1d5f74d865 Closes #16153: Intermittent failures of ShareControllerTest.handleShareToApp 2020-11-16 18:50:48 -05:00
mcarare
0d37c8f268 For #16420: Make search bar first view focused by a11y services on open. 2020-11-16 17:30:52 -05:00
Christian Sadilek
88f3f3564e Issue #16587: Make sure tab counter correctly reflects private/normal tab counts 2020-11-16 13:41:51 -08:00
Christian Sadilek
fbbc25b54e Closes #16053: Fix crash when closing private tabs via notification 2020-11-16 13:41:51 -08:00
MickeyMoz
2c4f0624fd Update Android Components version to 67.0.20201115143123. 2020-11-16 11:37:03 +01:00
Mozilla L10n Automation Bot
4895cf4e91 Import l10n. 2020-11-16 10:34:18 +01:00
Jonathan Almeida
78715c3020
For #13477 - Move BiometricPrompt to a separate feature (#16498) 
Instead of simply fixing the memory leak for this issue by directly
removing references, it makes more sense to move the whole
BiometricPrompt out of the fragment and into it's own feature to be
re-usable.
 2020-11-14 12:20:05 -05:00
Mihai Adrian Carare
85dd2f8313
For #16511 - Change a11y parent of button without breaking the tab list. (#16555) 2020-11-13 22:57:06 -05:00
Mozilla L10n Automation Bot
af666d8c57 Import l10n. 2020-11-13 17:09:02 -08:00
Michael Comella
e8bf955893 No issue: move StrictModeManager to perf package. 
While StrictMode is not exclusively used for performance purposes, it's
primarily used for perf purposes so let's move it to the perf package
and code owner it.
 2020-11-13 16:07:59 -08:00
Jocelyne Abi Haidar
88233ef42d For #15725: Set up preferences in onCreatePreferences instead of onResume 
set up preferences in onCreatePreferences instead of onResume so that their visibility is determined before the screen appears rather than after
 2020-11-13 18:14:02 -05:00
mcarare
d45bdfb0f4 For #16477: Switch to using an extension to update a11y collection info. 2020-11-13 11:17:47 +02:00
mcarare
e2322a18f9 For #16477: Migrate updateAccessibilityCollectionItemInfo to extension. 2020-11-13 11:17:47 +02:00
mcarare
b52f069573 For #16477: Update a11y info to collection item for both grid and list. 2020-11-13 11:17:47 +02:00
Bryan Kok
92b93081e5
Replace lingering occurence of ic_hollow_share with ic_share_filled (#16548) 2020-11-13 10:46:21 +02:00
Mugurell
c6de8632de
For #16461 - Ensure the proper items order after exiting Multiselect (#16482) 2020-11-13 07:32:45 +02:00
LeoMaldonado
a06b30a73d Fixes Comment on #16563: DefaultToolbarMenu registering for bookmark changes 
comment link: https://github.com/mozilla-mobile/fenix/pull/16536#discussion_r522387945
 2020-11-12 19:57:36 -08:00
LeoMaldonado
2d8fe7a9ad Closes #16345: Update share icon shape 
updating share icon to a filled shape, like default toolbar menu across all app
 2020-11-12 19:57:36 -08:00
LeoMaldonado
84eda3d38f For #16345: use same share icon across all app 
replace mozac_ic_share for ic_hollow_share on DefaultToolbarMenu
 2020-11-12 19:57:36 -08:00
Gabriel Luong
27ee2ba4f6
For #15761 - [Grid View] Enable the grid view and remove its feature flag (#16546) 
* For #15761 - Part 1: Turn ON the showGridViewInTabsSettings feature flag

* For #15761 - Part 2: Remove the showGridViewInTabsSettings feature flag and show the Tab view preference category
 2020-11-12 21:14:34 -05:00
mozilla-l10n-automation-bot
6ebc90deae
Import l10n. (#16486) 2020-11-12 19:56:19 -05:00
Gabriel Luong
e9d335cb24
Revert "For #15761 - [Grid View] Enable the grid view and remove its feature flag (#16535)" (#16544) 
This reverts commit 7499d33b32.
 2020-11-12 17:17:36 -05:00
rxumoz
409041ae3b
For #16451 - Change default top sites to Baidu & JD in China build (#16515) 
* Add top sites related strings

* Change default top sites to Baidu & JD in China build
 2020-11-12 16:53:50 -05:00
Gabriel Luong
7499d33b32
For #15761 - [Grid View] Enable the grid view and remove its feature flag (#16535) 2020-11-12 15:17:38 -05:00
ekager
1ed9ebf622 For #16132 - Rename normal mode menu item, remove telemetry 2020-11-12 09:11:16 -08:00
Gabriel Luong
ebadbdb352
For #14920 - Show a Tabs Tray CFR Banner for grid view tip (#16466) 2020-11-12 11:52:59 -05:00
Codrut Topliceanu
f3edce5f16
For #11376 - Reverse tabs list order (#16245) 2020-11-12 10:58:02 -05:00
Johan Lorenzo
4570f5a14f Revert "Update Android Components version to 66.0.20201111143206." 
This reverts commit dbdb68ac72.
 2020-11-12 12:48:00 +01:00
Kate Glazko
6c68e79a22 For #14772: Crash in Downloads 2020-11-11 12:17:28 -08:00
Mugurell
a097b135b3 For #16076 - Add new "share_image" telemetry event 2020-11-11 11:12:53 -08:00
MickeyMoz
dbdb68ac72 Update Android Components version to 66.0.20201111143206. 2020-11-11 10:18:01 -08:00
Mugurell
c3179512de
For #16500 - Ensure CardView clips ImageView on lower APIs (#16507) 
ImageViews are normally not clipped but extend to cover the entire width and
height set.
CardViews as a parent can help with that but on lower APIS they still need a
shapeAppearance which is a property already in the added style.
 2020-11-11 20:10:12 +02:00
mcarare
c427ebf8d5 For #16416: Remove save to collection button from tab a11y list. 2020-11-11 12:13:35 +02:00
ekager
a8db85fc22 For #16132 - Revise multiselect mode UI 2020-11-10 17:15:19 -08:00
mozilla-l10n-automation-bot
c8aee39db1
Import l10n. (#16468) 2020-11-10 16:14:29 +02:00
Mugurell
5e58377948
For #16424 - Focus the right item in tabs tray when using Talkback (#16472) 
To get the index of the current selected browser tab when using reverse layout
we should also account for items placed below of the browser tabs.
The patch here unifies the logic already used for some calls but not all.
 2020-11-10 15:10:50 +02:00
Codrut Topliceanu
6e4393a199
For #15720 - Remove unused telemetry (#15887) 2020-11-09 17:24:46 -05:00
Gabriel Luong
b5c25ccf3b
For #15960 - Enable Grid View in Nightly only (#16462) 2020-11-09 17:09:31 -05:00
mcarare
928d320836 For #16426: Allow multiselect title to be selected by a11y services. 2020-11-09 10:23:51 -08:00
mozilla-l10n-automation-bot
517ff91753
Import l10n. (#16447) 2020-11-09 09:39:52 -05:00
Christian Sadilek
0fbc8410a4 Closes #16430: ExternalAppBrowserActivity should not handle incoming intents 2020-11-09 09:29:55 +01:00
mozilla-l10n-automation-bot
2fb7383684
Import l10n. (#16441) 2020-11-06 19:48:10 -05:00
Mihai Adrian Carare
c641ed72dc
For #15764 - Update Tabs summary description. (#16428) 2020-11-06 17:30:59 -05:00
Christian Sadilek
96e2123f86
Update Android Components version to 66.0.20201106143126 (#16439) 2020-11-06 17:22:46 -05:00
Mozilla L10n Automation Bot
1ad5ea58a2 Import l10n. 2020-11-06 14:19:41 +01:00
Christian Sadilek
4abd399002 Closes #16327: Refactor MenuPresenter to use browser store 2020-11-05 16:45:10 -05:00
Arturo Mejia
50d7792330 For issue #15934 fix ConcurrentModificationException 
on WifiConnectionMonitor
 2020-11-05 14:24:37 -05:00
Michael Comella
afa080c956 For #15279 - review: set LazyMonitored to private. 2020-11-05 07:48:17 -08:00
Michael Comella
090650485f For #15279: remove redundant lazy wrapper from storage APIs. 
They're currently lazy { lazy { value } }. Accessing `lazy.value`
directly allows us to make it lazy { value }. This should be more
performant and prevents us from double-counting these components.
 2020-11-05 07:48:17 -08:00
Michael Comella
89541a17f7 For #15279: LazyMonitored implement Lazy + update built-in API use. 
By having LazyMonitored implement Lazy, we can continue to pass these
values directly into the ac APIs that require Lazy references. For some
reason, implementing `Lazy.value` can replace `operator fun getValue`
required for delegates.
 2020-11-05 07:48:17 -08:00
Michael Comella
901c78684c For #15279: replace lazy with lazyMonitored in component groups. 
By component groups, I mean I applied this to any class with the
class kdoc, "Component group for...".

There are a few instances of lazy we had to keep using the old API to
avoid having to update constructor arguments.
 2020-11-05 07:48:17 -08:00
Michael Comella
f37ace0630 For #15279: add LazyMonitored and tests. 2020-11-05 07:48:17 -08:00
mozilla-l10n-automation-bot
de3c4bc635
Import l10n. (#16380) 2020-11-04 18:58:23 -08:00
Kate Glazko
0ae268914b For #352: Delete a download 2020-11-04 13:32:24 -08:00
ekager
c0e01373e1 No issue: Update stable androidx and material versions 2020-11-04 12:00:32 -08:00
Mugurell
88bfaaabe7
For #6521 - Remove auto sigin onboarding card (#16315) 
With the Fennec -> Fenix migration complete there is no other Mozilla
application that would serve as a custom account provider hence the automatic
signin would not be possible.
Make this more obvious by commenting out the code that would trigger an
onboarding banner for it but keep the code in the app for when #15694 would add
to Fenix the ability to serve as a custom account provider.
 2020-11-04 17:23:19 +02:00
Mugurell
1358e09d7e
For #16323 - Use 10dp corner radius for the selected outer border of a grid item (#16364) 
This would ensure the corners of the inner and outer borders are aligned, with
no empty gap between them.
 2020-11-04 10:03:43 -05:00
Mugurell
172977f698
For #14980 - Effectively disable tabs tray STATE_HALF_EXPANDED (#16052) 
STATE_HALF_EXPANDED cannot be disabled while also keeping fitToContents = true
based on which the tabs tray layout is currently set.
To work around this we'll set a a minuscule height for the tab tray when in
this state and then immediately advance to STATE_HIDDEN so to make it
imperceptible to the users.
Since I couldn't write unit tests because of InflateExceptions in Robolectric
I've written UI tests to protect against regressions.
 2020-11-04 11:22:46 +02:00
Mihai Adrian Carare
db58022fbb
For #13172 - Tab swipe order follows text direction from oldest to newest (#16178) 2020-11-03 15:48:00 -05:00
Rafał Opiłowski
96fb9f4676
For #12971 - Show collection saved snackbar above FAB (#16311) 2020-11-03 15:45:23 -05:00
Mugurell
34f0c84d46
For #16339 - Initialize FxaAccountManager with also a CrashReporter (#16340) 2020-11-03 14:46:08 +02:00
Sebastian Kaspari
baaa85db80 Closes #16256: Introduce build flag for "Mozilla Online" variant. 
This patch introduces a build flag that can be used on demand on the command line (`./gradlew -PmozillaOnline [..}`) or
permanently when added to local.properties (`mozillaOnline`).

At runtime `Config.channel.isMozillaOnline` will return `true` if the flag was set at build time.
 2020-11-03 10:34:25 +01:00
Mozilla L10n Automation Bot
e61e5b80dd Import l10n. 2020-11-02 19:44:47 -08:00
Gabriel Luong
2bd2a5651d
For #14636 - Update preference section headers to use correct color, spacing and rulers (#16332) 2020-11-02 19:56:41 -05:00
Michael Comella
2b621fcb1b No issue - review: clarify thread safety of suppressionCount. 2020-11-02 15:37:04 -08:00
Michael Comella
bff8a0d6a7 No issue: make StrictMode suppression count thread safe. 2020-11-02 15:37:04 -08:00
Christian Sadilek
d7688c8427 For #12062: Switch to consumeFlow and add tests 2020-11-02 14:23:33 -08:00
ekager
bd2c407943 For #4652 - Remove activityViewModels workarounds 2020-11-02 11:30:37 -08:00
MarcLeclair
7b1af41b40
15278 detekt rule runblocking (#15942) 
* For #15278: added CoroutineManager to count runBlocking calls

* For #15278: Added actual detekt rule for runblocking and its config to the yaml

* For #15278: Added unit test for RunblockingCounter

* For #15278: renamed StrictModeStartupSuppressionCountTest.kt to PerformanceStartupTest.kt and added runBlockingCount test

* Lint fix

* For #15278: made runblocking a Long to prevent overflow

* For #15278: fixed MozRunblocking name, description and moved RunBlockingCounter to perf package

* For #15278:Renamed MozillaRunblockingCheck to MozillaRunBlockingCheck

* For #15278: Added setup for unit test, since it failed without restting counter

* For #15278: Fixed naming for RunBlocking lint check

* For #15278: removed changes made to test to use runBlockingIncrement

* For #15728: added test exclusion for runBlocking check

* For #15278: changed null check and added Synchronized to count setter

* For #15278: fix for nits

* For #15278: added StartupExcessiveResourceUseTest to CODEOWNERS

* For #15278: fixed for nits

* For #15278: Moved increment function to extension function and fixed indentation

* For #15278: Added tests for Atomic Integer extension and nit fix
 2020-11-02 12:49:17 -05:00
ekager
d46fc7b142 For #6313 - Remove unneeded delay in BrowserAnimator 2020-11-02 09:38:15 -08:00
Roger Yang
b65c798450
For #16268 - Allowing multiple task while sharing (#16275) 2020-11-02 11:16:29 -05:00
Jocelyne Abi Haidar
1b204158e5
For #15931: Sort Downloads from newest to oldest (#15939) 2020-11-02 11:06:30 -05:00
mcarare
142d7a418c For #15430: Fix StrictMode death on opening app from widget voice search. 2020-11-02 15:50:12 +02:00
mcarare
5b0bdda974 For #15430: Fix StrictMode death on opening app from widget text search. 2020-11-02 15:50:12 +02:00
mcarare
adbb262787 For #14552: Do not display back button when there is no tab history. 2020-11-02 14:25:49 +02:00
Mozilla L10n Automation Bot
bf69519dc9 Import l10n. 2020-11-02 00:12:21 -05:00
Mugurell
a6092c34cc For #15963 - Increase touch target for the close button in the tabs tray grid layout 
We need to ensure it has at least 48dp while also not appearing too big.
 2020-10-30 18:13:50 -04:00
Mugurell
83bd80c873 For #15757 - Avoid the double spacing issues for grid items in tabs tray 
Items should have a 16dp all around padding.
Have them have a 8dp padding that will add to 16 when placed together.
Have the parent have another 8dp that will add to 16 for when items are placed
to the edge of the available screen.
 2020-10-30 18:13:50 -04:00
Mugurell
0324baef03 For #15968 - Show a border for the selected tab in the grid based tabs tray 
The border for the grid item will now be updated in the same method that
updates the background for the list item.
 2020-10-30 18:13:50 -04:00
Mugurell
482739ba8c For #15756 - Add a play/pause button in the tabs tray grid layout 
Moved the previous layout in a new, bigger FrameLayout that would serve as a
buffer space for the play/pause button to be translated to the exterior.
Otherwise the button would be clipped.
 2020-10-30 18:13:50 -04:00
Gabriel Luong
66210469c0
For #9548 - Ability to rename top sites (#16285) 
* Ability to rename top sites, closes #9548

* Highlight the "Remove" top site action as destructive

With more menu items in the top site contextual menu, it makes sense to differentiate

* Added test for the top site renaming action

* Fixed lint check (wildcard imports, blank spaces)

* Applied suggestions from code review

* Apply suggestions from code review

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>

* Implemented dialog click listener with manual dismiss/cancel

Co-authored-by: Lorenzo Stanco <lorenzo.stanco@gmail.com>
 2020-10-30 15:08:04 -04:00
mozilla-l10n-automation-bot
d1ec6cac86
Import l10n. (#16274) 2020-10-29 21:40:40 -04:00
ekager
4246293a93 For #16161 - Fixes Saved Login toolbar layout 2020-10-29 16:10:06 -07:00
Codrut Topliceanu
975a5b76ec
For #14637 - Fix sitePermissionsFeature breaking change + AC bump (#16229) 
* For #14637 - Compatibility patch for AC - 8554

* Update Android Components version to 65.0.20201029143039

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2020-10-29 19:08:31 -04:00
mozilla-l10n-automation-bot
e21c81a0dd
Import l10n. (#16240) 2020-10-29 10:42:14 -04:00
mcarare
3cb2c83980 For #16250: Disable remote USB debugging for SDK <23. 2020-10-29 15:02:02 +01:00
Mihai Adrian Carare
0ee7e1c28d
For # 15929: Remove the search widget discoverability experiment. (#16081) 
* For #15929: Remove SearchWidgetCFR telemetry.

* For #15929: Remove SearchWidgetCFR and search widget experiment.

* For #15929: Remove unit tests references to search widget experiment.
 2020-10-28 13:46:02 -07:00
mcarare
9748c65c71 For #15413: Use proper url when bookmarking a page. 2020-10-28 16:33:48 +02:00
Mozilla L10n Automation Bot
5739140ff3 Import l10n. 2020-10-28 10:54:41 +01:00
Arturo Mejia
bb7d821804 Fix AddonsManagementFragment detekt error 2020-10-27 19:23:32 -04:00
Christian Sadilek
c330426bb7 No issue: Fix onConfigurationChange crashes in Debug build 2020-10-27 18:54:07 -04:00
Christian Sadilek
601aa19176 Closes #11285: Replace Session[Manager] observers in BaseBrowserFragment 2020-10-27 17:40:58 -04:00
Grisha Kruglov
655a5cbf54 Closes #15816 - Attempt to handle 'allowInPrivate..' pref with detached context 2020-10-27 16:18:19 -04:00
mcarare
21a67de947 For #15379: Use proper url when sharing. 2020-10-27 14:15:56 -04:00
ekager
9b2162fca2 For #16199 - Don't pass BrowserToolbarView in onStart when we just need parent 2020-10-27 09:13:13 -07:00
Arturo Mejia
0ae0b89d65 Fix add-on translation braking changes 2020-10-27 11:33:18 -04:00
mozilla-l10n-automation-bot
b8d6dbd426
Import l10n. (#16198) 2020-10-26 20:28:45 -04:00
Lorenzo Stanco
90220678cf
For #16122 - Add a dark theme color for the top sites pin icon (#16180) 2020-10-26 18:50:41 -04:00
mozilla-l10n-automation-bot
7d59a58134
Import l10n. (#16163) 2020-10-26 12:07:02 -04:00
mozilla-l10n-automation-bot
6353e9979e
Import l10n. (#16154) 2020-10-23 22:18:34 -04:00
ekager
e15f50712a For #6313 - Set session ClearColor through Engine DefaultSettings 2020-10-22 20:36:04 -07:00
mozilla-l10n-automation-bot
4acf3c601d
Import l10n. (#16138) 2020-10-22 23:12:05 -04:00
Jocelyne Abi Haidar
f514f6099a
For #15508: Show error when trying to save empty or invalid bookmark URL (#15674) 2020-10-22 17:22:37 -04:00
mozilla-l10n-automation-bot
c40b93715f
Import l10n. (#16108) 2020-10-21 21:01:50 -04:00
Mugurell
358ca2c87f
For #15543 - Adjust the height of the tabs tray depending on the number of tabs (#15749) 2020-10-21 19:21:37 -04:00
ekager
aae43b84eb
For #12062 - Feature Flag return to browser (#16099) 2020-10-21 16:29:06 -04:00
ekager
6b8f2001df
For #16084 - Match elevation of Tab in Collection to header (#16100) 2020-10-21 15:47:25 -04:00
ekager
d5cb9c599c
For #15910 - Adds back automatic toggle, disables slider when enabled (#16070) 2020-10-21 12:20:04 -04:00
mcarare
1a10215caf For #14619: Show half a tab top offset when scrolling to selected tab. 2020-10-21 13:31:59 +03:00
mozilla-l10n-automation-bot
20df97ad57
Import l10n. (#16074) 2020-10-20 20:41:54 -04:00
Mugurell
57462d612f
For #16054 - Enable pull to refresh webpage in Nightly and Debug (#16060) 2020-10-20 20:41:14 -04:00
Elise Richards
7e3c26914c
For #15080: Handle default search engine when editing or removing (#15768) 2020-10-20 16:00:00 -07:00
Juan C. Goncalves
eb0712d9b4
For #11397 - Add lint rule for AppCompatResources instead of ContextCompat (#16011) 2020-10-20 13:23:43 -07:00
Sebastian Kaspari
0d97862824 FennecWebAppIntentProcessor: Catch JSONException. 2020-10-20 15:46:18 +02:00
Mihai Adrian Carare
b1bc024ff5
For #11631: Move report site issue extension to main menu. (#15884) 
* For #11631: Move report site issue extension to main menu.

* For #11631: Update UI test for installing add-on.
 2020-10-20 09:34:54 +03:00
Tom Klein
57ba92080f For #15480 - Update the UI when a collection is renamed 2020-10-19 19:32:11 -07:00
mcarare
9274558e2f For #15688: Navigate to home screen with arguments on new tab action. 2020-10-19 17:45:46 -07:00
Mozilla L10n Automation Bot
ae74edecdb Import l10n. 2020-10-19 17:37:17 -07:00
Sebastian Kaspari
2da24cd91d
Update Android Components, Kotlin, Gradle plugin (#16021) 
* Closes #13262: Update AGP to 4

* Update to Mozilla Android Components 63.0.20201019090011.

* Update Kotlin to 1.4.10 and Coroutines to 1.3.9.

* Fix new compiler warnings.

* Fix compilation of lint rules module.

* Pin JNA version.

* Fix new lint errors.

Co-authored-by: Tiger Oakes <toakes@mozilla.com>
 2020-10-19 14:07:47 -04:00
Mihai Adrian Carare
3ed49d8802
For #14744: Also show Fill link from clipboard with search shortcuts. (#15885) 2020-10-19 13:58:54 -04:00
mozilla-l10n-automation-bot
46ff7a182a
Import l10n. (#16014) 2020-10-18 23:26:52 -04:00
mozilla-l10n-automation-bot
c941bd99b0
Import l10n. (#16001) 2020-10-17 21:54:08 -04:00
mozilla-l10n-automation-bot
1d91f1f087
Import l10n. (#15986) 2020-10-17 09:41:31 -04:00
Gabriel Luong
d33bd76e40
For #15796 - Use the device locale for the system locale subtitle (#15975) 2020-10-17 09:40:28 -04:00
Gabriel Luong
87ec7a77ae
For #15937 - Remove topFrecentSite feature flag (#15967) 
* For #15937 - Remove the topFrecentSite feature flag

* For #15937 - Hide the "Pull to refresh" preference since its visibility is managed by a feature flag
 2020-10-16 18:37:27 -07:00
ekager
d208ffe002
For #7345 - Update new shield icons, remove lottie (#15909) 2020-10-16 16:01:38 -07:00
Christian Sadilek
c852301c93 Closes #11286: Add TelemetryMiddleware to remove Session[Manager] observers 2020-10-16 11:05:34 -07:00
Gabriel Luong
412b412d5f
For #15796 - show device language under follow device language (#15966) 2020-10-16 12:47:56 -04:00
amkcpu
7ba5e130ba For #10683: Show longer tab titles 
Also update tab tray item layout according to specs posted in the issue.
 2020-10-16 15:50:29 +03:00
mozilla-l10n-automation-bot
a2a4284a1a
Import l10n. (#15945) 2020-10-15 17:29:04 -07:00
Jeff Boek
55515d8f7c
For #15596 - Removes upgrade faq link from fennec builds (#15643) 2020-10-15 15:02:51 -07:00
Gabriel Luong
b79df0ba8f For #14922: Use padding instead of margin to use the full screen width for the "Add search engine" button 2020-10-15 16:09:13 -04:00
mcarare
9f14007a98 For #14922: Adjust margins for add search engine preference. 2020-10-15 16:09:13 -04:00
mcarare
ba0c005ae9 For #14922: Add divider above address bar preferences. 2020-10-15 16:09:13 -04:00
mcarare
7510b1609f For #15898: Add dividers above subheadings in tabs screen. 2020-10-15 13:13:52 -04:00
mcarare
e50cb21fd0 For #15898: Add dividers above subheadings in customise screen. 2020-10-15 13:13:52 -04:00
Michael Comella
4a000ab4f9 For #15644: change apply to with in GleanMetricsService. 
While the callback receiver is identical in these two methods, they're
semantically different: apply is for initializing the receiver while with
is anything else benefiting from a new `this` receiver.

I didn't change the usage of apply that has a return statement because I
was afraid my change might change behavior.
 2020-10-15 09:53:13 -07:00
Michael Comella
690554b5c6 For #15644: mock package inspection dependencies in GleanMetricsService. 
The new robolectric version changed the behavior such that the app ID
that was returned for our app was `org.mozilla.fenix.debug` instead of
(I guess) `org.mozilla.fenix`. In general, relying on robolectric can be
fragile, such as this case, so it's better to mock. Also, this test
behavior should theoretically have varied between build flavors so
mocking prevents the tests from breaking across flavors.
 2020-10-15 09:53:13 -07:00
ekager
4d348dd26a Fixes existing lint errors 2020-10-15 09:53:13 -07:00
Gabriel Luong
665a71cbb0 For #15907 - Remove the usage of the TabTrayGridItemDecorator 2020-10-15 10:02:07 -04:00
ekager
508ec8b8ff For #15347 - Adds telemetry for tabs settings 2020-10-14 22:53:31 -04:00
ekager
b6587455f8 fix detekt errors 2020-10-14 18:22:02 -07:00
Sebastian Kaspari
430282c8ec Use new SearchEngineProvider interface. 2020-10-14 18:22:02 -07:00
Mozilla L10n Automation Bot
ce99cc9ccf Import l10n. 2020-10-14 17:49:27 -07:00
Michael Comella
c6b83b10e0 For #15280: suppress new lint rule in migration code. 2020-10-14 15:20:28 -07:00
ekager
e56043c485 For #15265 - Save cached top sites for metrics ping 2020-10-14 15:08:54 -07:00
ekager
cbe293d3e4 For #12062 - Launch back to browser if we previoulsy had tabs 2020-10-14 15:05:20 -07:00
Mozilla L10n Automation Bot
399c9c57fb Import l10n. 2020-10-13 20:54:10 -04:00
ekager
7931d66c8e For #15853 - Always set fontSizeFactor setting with new text scale 2020-10-13 09:40:43 -07:00
Mihai Adrian Carare
0e2657e262
For #14735: Remove debug logs from release build. (#15747) 2020-10-13 09:17:58 -04:00
Mozilla L10n Automation Bot
2751da0372 Import l10n. 2020-10-12 17:50:57 -07:00
Gabriel Luong
ee5f678442 For #15777 - [Grid View] Set the height of the title to 30dp 2020-10-12 10:38:54 -07:00
Gabriel Luong
463f83a79a For #15758 ⁃ [Grid View] Add a divider between the tab item's title and thumbnail 2020-10-12 10:38:54 -07:00
Mozilla L10n Automation Bot
83b5bae65e Import l10n. 2020-10-11 22:55:02 -04:00
Mozilla L10n Automation Bot
25c9706cfd Import l10n. 2020-10-11 10:04:34 -04:00
Grisha Kruglov
2030580fc8 Closes #15812: Check for a null context during onScanResult 2020-10-09 20:40:03 -07:00
Mozilla L10n Automation Bot
d5bef99834 Import l10n. 2020-10-09 20:42:16 -04:00
Shen
45e3f7805b For #13168 - Removed the close button from history navigation bar 2020-10-09 20:33:37 -04:00
Michael Comella
4179ab05bb For #10069 - review: clarify init time for External...Activity. 2020-10-09 15:47:55 -07:00
Michael Comella
a1bbd2589e For #10069 - review: change extra name to firstFramePreDrawNanos. 2020-10-09 15:47:55 -07:00
sraturi
8f16f9cb37 for #10069 added AppLaunchTimeMeasurement.kt to handle logic of startup time for cold, warm, and hot startup types. 2020-10-09 15:47:55 -07:00
mcarare
6516eff5c8 For #13831: Adjust buttons dimensions to improve a11y. 
Margins were also adjusted to maintain relative placements.
 2020-10-09 15:39:31 -07:00
mcarare
e89b9756ee For #13831: Add ripple for the copy password button. 2020-10-09 15:39:31 -07:00
ekager
881e3d6ccd For #14923 - Removes auto size preference toggle 2020-10-09 15:04:57 -07:00
Sijan Rijal
127d006d66
For #15402: Hide ETP pop-up if the toolbar is not visible (#15667) 
For #15402: Hide ETP pop-up when top or bottom toolbar is not visible
 2020-10-09 16:22:57 +03:00
Sijan Rijal
70908307fc
For #15497: Hide and remove the three dot menu from the Desktop Bookmarks folder (#15649) 
For #15497: Remove and disable the three dot menu button
 2020-10-09 14:39:03 +03:00
Mozilla L10n Automation Bot
0fbb28296e Import l10n. 2020-10-08 21:20:56 -04:00
Jonathan Almeida
666781aa62 Fix lint warnings and test in site permissions 2020-10-08 19:37:56 -04:00
Arturo Mejia
de521192e0 Add support for local storage permission 2020-10-08 19:37:56 -04:00
Gabriel Luong
2dd019c05f For #15115 - Part 8: Add a feature flag for showing the grid view in the tabs setting 2020-10-08 12:50:43 -04:00
Gabriel Luong
af0af7f88a For #15115 - Part 7: Draw a border around the selected tab 2020-10-08 12:50:43 -04:00
Gabriel Luong
5fcc486caa For #15115 - Part 6: Display the tab's favicon in the grid view 2020-10-08 12:50:43 -04:00
Gabriel Luong
5fa72cf48c For #15115 - Part 5: Don't draw any background when swiping to delete a tab 2020-10-08 12:50:43 -04:00
Gabriel Luong
a001004add For #15115 - Part 4: Formatted TabTrayView.kt 2020-10-08 12:50:43 -04:00
Gabriel Luong
6c77cdab41 For #15115 - Part 3: Implement a grid view layout for the tabs 
Co-authored-by: Abhijit Valluri avalluri2@bloomberg.net
 2020-10-08 12:50:43 -04:00
Gabriel Luong
2117dfb524 For #15115 - Part 2: Remove unused xmlns:mozac in component_tabstray.xml 2020-10-08 12:50:43 -04:00
Gabriel Luong
ed3986662f For #15115 - Part 1: Convert the CloseTabsSettingsFragment to a general TabsSettingsFragment 
- Renames CloseTabsSettingsFragment.kt to TabsSettingsFragment.kt
- Renames close_tabs_preferences.xml to tabs_preferences.xml
- Adds preference options for the switching between the Grid and List tab views
 2020-10-08 12:50:43 -04:00
Michael Comella
7c0d00c800 No issue: fix tests related to inline change. 
The difficulty in mocking StrictMode.resetAfter is concerning.
I'm starting to second-guess whether or not making strict mode manager a class
was a good idea.
 2020-10-08 07:24:21 -07:00
Michael Comella
7b5cd8c165 No issue: remove inline from StrictModeManager.resetAfter. 
I believe this was a premature optimization: it's unclear that it would
actually improve performance and yet  we had to add several weird
workarounds to make it work that broke encapsulation. It's also
possible it would be worse for the APK size because of excessive
inlining.
 2020-10-08 07:24:21 -07:00
Mozilla L10n Automation Bot
a72b5b0dd6 Import l10n. 2020-10-07 21:56:24 -07:00
Jonathan Almeida
23d9951e78 Upgrade to Android Component 62.0.20201006190820 with breaking changes 2020-10-07 20:01:35 -04:00
mcarare
9845626eca For #15711: Also add custom engines to fallback list. 2020-10-07 10:19:26 -07:00
mozilla-l10n-automation-bot
0ac7feacb4
Import l10n. (#15738) 2020-10-06 18:19:11 -07:00
Elise Richards
13f3304912
For #8765: Use shared list widget in collections (#15733) 
Co-authored-by: Tiger Oakes <toakes@mozilla.com>
 2020-10-06 16:24:08 -05:00
Michael Comella
3e96f6b385 For #13959 - review: add clarifying comments. 2020-10-06 14:11:53 -07:00
Michael Comella
50959d997e For #13959: add marker when StrictMode is suppressed. 2020-10-06 14:11:53 -07:00
Michael Comella
3b5d6d58d9 For #13959: add MozillaStrictModeSuppression detekt check. 2020-10-06 14:11:53 -07:00
Michael Comella
4a4edeb184 For #13959: count StrictMode suppressions on startup. 2020-10-06 14:11:53 -07:00
Jocelyne Abi Haidar
a5de2c0352 For #15675: Disable Save button when editing saved login until something has been changed 
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
 2020-10-06 11:47:12 +03:00
mozilla-l10n-automation-bot
5fed37cf45
Import l10n. (#15712) 2020-10-05 18:08:06 -07:00
Mozilla L10n Automation Bot
ad2b99f9f9 Import l10n. 2020-10-05 12:19:48 +02:00
mcarare
07748f69b7 For #15632: Improve checking open tabs logic to show collection button. 
Check now considers selected tab tray mode.
 2020-10-02 20:46:29 -04:00
ekager
ec3595d4fc For #15600 - Move removal of timed out sessions to immediately after restoration 2020-10-02 13:22:49 -07:00
ekager
01eedd159a No issue: Update biometric, core, and recyclerview libraries 2020-10-02 08:47:40 -07:00
mcarare
b696fc4c4b For #13031: Show size in KB for smaller downloaded files. 2020-10-02 11:04:48 -04:00
Mozilla L10n Automation Bot
ee4a5283a4 Import l10n. 2020-10-01 17:46:57 -07:00
Jocelyne
0154c81f81
For #10107: Show Today and Yesterday labels in History (#15415) 2020-10-01 16:42:50 -07:00
Jeff Boek
41a92a8d8b For #15593 - Reverts back to simple UUID creation without Fenix side caching 2020-10-01 15:51:30 -07:00
Jocelyne
e74a12b442
For #15471: Show Delete button in red in multi-select overflow menu (#15576) 2020-10-01 13:10:33 -07:00
Mozilla L10n Automation Bot
97adee3bd9 Import l10n. 2020-10-01 20:13:40 +02:00
Grisha Kruglov
51dab196c4 Closes #15443: Use fragment's lifecycleScope for AlertDialog actions 2020-09-30 17:42:40 -07:00
mcarare
67310061a3 For #15559: Allow tabs to stretch in landscape mode for tablets. 
This overrides the default tabMaxWidth of 264dp to allow for tabGravity="fill".
 2020-09-30 14:46:22 -07:00
Stefan Arentz
ff930175de
For #15537 - Be more verbose about leanplum identifiers (#15538) 2020-09-30 13:05:28 -04:00
mcarare
19b377c021 For #15535: hasOpenTabs now considers the selected tab mode in tray tab. 2020-09-30 08:33:38 -07:00
Michael Comella
56f78cb30c No issue: elaborate on Components class doc. 
This is to clarify a misunderstanding I found in PR review.
 2020-09-29 15:39:10 -07:00
Sebastian Kaspari
2fda22e857 Revert "For #12565: Pass metrics to share controller" for debug test failures. 
This reverts commit bbaca06274.
 2020-09-29 10:59:31 +02:00
Sebastian Kaspari
4de466883b Revert "For #12565: Pass bookmark storage to controller" for debug test failures. 
This reverts commit 3c22100b84.
 2020-09-29 10:59:17 +02:00
Andrew Gaul
cfbad1dae9 Show undo snackbars with padding with static bottom toolbar 
This specifically fixes the close tab snackbar.  This commit mirrors
the logic when not using Undo from
9e876ebc44.  References #14982.
 2020-09-29 10:15:30 +02:00
ekager
01e802fef0 For #15324 - Show tab settings and recently closed items in menu when no tabs 2020-09-28 21:09:30 -07:00
ekager
e49cd9c558 For #15503 - Change recently closed max to 10 2020-09-29 00:03:49 -04:00
TrianguloY
b07af9ccd3
For #13856 - Prevent overscroll in swipe to switch tabs gesture 2020-09-28 20:43:44 -07:00
Tiger Oakes
25f62f1c76 Extract locale settings initial state 2020-09-28 20:39:49 -07:00
Tiger Oakes
acbad66f45 Add test for initial logins list state 2020-09-28 20:39:49 -07:00
Tiger Oakes
f2a6aa4f25 Add tests for initial collection creation state 2020-09-28 20:39:49 -07:00
Sören Hentzschel
01fdb4ac3f For #11561 - changed inactive heading and menu icon color in dark mode 2020-09-28 20:24:12 -07:00
Mozilla L10n Automation Bot
863b135723 Import l10n. 2020-09-28 20:18:50 -07:00
Tiger Oakes
3c22100b84 For #12565: Pass bookmark storage to controller 2020-09-28 20:05:50 -07:00
Tiger Oakes
bbaca06274 For #12565: Pass metrics to share controller 2020-09-28 20:05:50 -07:00
Michael Comella
d767cd199e For #13959: fix startup crash by using arg Context. 
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
 2020-09-28 18:01:19 -07:00
Michael Comella
42cca072e2 For #13959: remove resetAfter & port tests to StrictModeManager. 2020-09-28 18:01:19 -07:00
Michael Comella
f19c9920f9 For #13959: move resetAfter into StrictModeManager. 
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.

Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```

We're going to have to add a lint check to prevent them from doing that.
 2020-09-28 18:01:19 -07:00
Michael Comella
6abeb2d9e7 For #13959: change StrictModeManager to class from object. 
I originally tried to create this PR leaving this as an object to keep
the change simple but it wasn't worth it - once the object started to
keep state, we'd need to manually reset the state between runs. Also,
the tests were already getting hacky with static mocking so it was
easier to address some of those issues this way too.
 2020-09-28 18:01:19 -07:00
Christian Sadilek
d4ab728cff For #14034: Add debug preference to override AMO collection in Nightly 2020-09-28 17:25:52 -04:00
Michael Comella
a92356fe00 For #13959: comment about duplication in logic in StrictMode. 
I had to drop a commit that addressed the issue because it was too hard
to fix.
 2020-09-28 13:52:40 -07:00
Michael Comella
e1bd6191c7 For #13959: add comment to explain why we only resetAfter in certain build modes. 2020-09-28 13:52:40 -07:00
Michael Comella
3bf71ef655 For #13959: use ac StrictMode.resetAfter rather than duplicating functionality. 2020-09-28 13:52:40 -07:00
Michael Comella
2c1befaa25 For #13959: rename to attachListenerToDisablePenaltyDeath for clarity. 2020-09-28 13:52:40 -07:00