Emily Kager
92f2692fbf
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5268 - Fix 2 detekt errors
2019-09-12 11:32:33 -07:00
Emily Kager
03b4bc2d32
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5263 - Hide ETP Panel Settings for custom tab
2019-09-12 10:45:35 -07:00
kglazko
58a85d264e
[fenix] Issue 4622- Create Unit Tests for Extensions ( https://github.com/mozilla-mobile/fenix/pull/4669 )
2019-09-12 10:44:37 -07:00
Tiger Oakes
29d73507a9
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5212 - Change tint in onCreateOptionsMenu
...
Also fixes https://github.com/mozilla-mobile/fenix/issues/5213
2019-09-12 10:30:49 -07:00
Colin Lee
c1577cd1f8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3106 : Improve granular data deletion margins
2019-09-12 10:25:14 -07:00
Mihai Adrian
2f2d130ad6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3371 : Show snackbar message when share fails with crash ( https://github.com/mozilla-mobile/fenix/pull/5210 )
2019-09-12 09:26:24 -07:00
Emily Kager
b6679bc23d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4458 - Enable font inflation with font auto size setting ( https://github.com/mozilla-mobile/fenix/pull/5252 )
2019-09-12 09:05:16 -07:00
ekager
9bc95446ca
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5229 , https://github.com/mozilla-mobile/fenix/issues/5228 - Dismiss ETP panel on back press, don't truncate text
2019-09-12 07:40:49 -07:00
Sebastian Kaspari
509d3c5e20
[fenix] Unbreak Nightly: Get rid of fragment-testing dependency and create fragments in test manually.
2019-09-12 13:44:17 +02:00
Emily Kager
fe01f2f319
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5178 - Polish delete browsing data item layout
2019-09-11 18:11:26 -07:00
Emily Kager
432972dac1
[fenix] No issue: Updates isPWA to isInstallable for AC 13 snapshot
2019-09-11 18:10:52 -07:00
Emily Kager
a22a98243c
[fenix] No issue: Fix BreadCrumbReporterTest
2019-09-11 18:10:52 -07:00
Roger Yang
d1011bbfda
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5091 : Refactor Sentry BreadCrumbs to use lib-crash BreadCrumbs
2019-09-11 16:14:42 -07:00
Emily Kager
a652723373
[fenix] No issue: Land new ETP Strings
2019-09-11 16:11:42 -07:00
Jeff Boek
5099eaa00f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5047 - Addresses nits
...
- Changes MainScope to viewLifecycleScope
- Fixes string name/comment to better describe what it is
- Adds disabled state to the add button
2019-09-11 16:10:54 -07:00
Jeff Boek
1574f05038
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5047 - Wires up dialog to webAppUseCases
2019-09-11 16:10:54 -07:00
Jeff Boek
410d33a4c8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5047 - Creates dialog ui for naming a shortcut
2019-09-11 16:10:54 -07:00
Emily Kager
e647d7e8c6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3700 - Add Setting to Delete Data on "Quit" menu action
2019-09-11 16:06:18 -07:00
Yeon Taek Jeong
88ecaf12b1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4658 : Add private browsing mode shortcut telemetry
2019-09-11 16:03:22 -07:00
Emily Kager
f2ff2c4f32
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1749 - Use Strict ETP by default, use Feature Flag for Settings
2019-09-11 16:03:01 -07:00
Sawyer Blatz
f001f5b6d8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1114 : Show playing tab
2019-09-11 15:45:22 -07:00
Jeff Boek
2102e39e4b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5214 - Bumps expiration dates for telemetry
2019-09-11 14:44:13 -07:00
Emily Kager
ee8cd6d08f
[fenix] No issue: Set color for toolbar divider ( https://github.com/mozilla-mobile/fenix/pull/5221 )
2019-09-11 11:46:00 -07:00
Emily Kager
8eb6b616c8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2897 - Add Action States To Share Sheet
2019-09-11 11:32:26 -07:00
Yeon Taek Jeong
c26cca80e7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/419 : Create launch icon for private browsing ( https://github.com/mozilla-mobile/fenix/pull/4948 )
2019-09-11 10:52:33 -07:00
Aaron Train
036b3d239b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5217 - fix androidx.test dep error ( https://github.com/mozilla-mobile/fenix/pull/5219 )
...
See https://github.com/mozilla-mobile/fenix/issues/5217
2019-09-11 12:55:22 -04:00
Oana Horvath
f36d0c476a
[fenix] added LibraryMenuTest, BookmarksRobot, HistoryRobot ( https://github.com/mozilla-mobile/fenix/pull/4769 )
...
ran ktlint
added the goBack()method in Transition
added the goBack method in Transition
2019-09-11 09:09:22 -07:00
Sawyer Blatz
e30570dc86
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4155 : Handle custom tabs & fix test
2019-09-11 09:03:17 -07:00
Sawyer Blatz
7bee891913
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4155 : Sets pastedText default value
2019-09-11 09:03:17 -07:00
Sawyer Blatz
603740cde0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4155 : Restyle to custom menu
2019-09-11 09:03:17 -07:00
Sawyer Blatz
8b5a149877
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4155 : Adds tests for browser toolbar popup menu
2019-09-11 09:03:17 -07:00
Sawyer Blatz
7daf054b67
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4155 : Adds popup menu for browser toolbar
2019-09-11 09:03:17 -07:00
Aaron Train
1465ea335c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5192 - Add UI Test for "What's New" menu option ( https://github.com/mozilla-mobile/fenix/pull/5193 )
2019-09-11 11:41:05 -04:00
Emily Kager
3b0a3c1643
[fenix] Add Tracking Protection Info Panel
2019-09-11 07:47:13 -07:00
mihai-adrian
40108e53c7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4877 : Restored logic for closing tabs when not on browserFragment
...
Added base test for CreateCollectionFragment that we can build upon later
2019-09-10 21:42:16 -07:00
mihai-adrian
ed24b8b0f1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4877 : Restored logic for closing tabs when not on browserFragment
...
Added return in function when saving collections coming from browser fragment
2019-09-10 21:42:16 -07:00
Sawyer Blatz
3c746c4b5c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4908 : Adds telemetry for send tab
2019-09-10 20:58:12 -07:00
Tiger Oakes
dd2c36c14a
[fenix] Move bookmark navigation listener to separate file
2019-09-10 16:53:09 -07:00
Sawyer Blatz
2502dcc4bb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5021 : Adds telemetry for what's new button
2019-09-10 14:15:34 -07:00
Tiger Oakes
97bdbdc223
[fenix] Use A-C preferences property delegates
2019-09-10 13:19:00 -07:00
No-Jun Park
5dc8dd7264
[fenix] Create homeview share dialog UITest ( https://github.com/mozilla-mobile/fenix/pull/5160 )
...
Share Button UI test added
Collection test steps created
2019-09-10 15:03:47 -04:00
ekager
faedf2f638
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5178 - Do not truncate delete browsing text
2019-09-10 10:44:14 -07:00
Tiger Oakes
ebcc6ce414
[fenix] Clean up SupportUtils
2019-09-10 10:16:04 -07:00
Mihai Adrian
72f0d9ce56
[fenix] Code Health https://github.com/mozilla-mobile/fenix/issues/4883 : Refactored accessing settings by using Context extensions ( https://github.com/mozilla-mobile/fenix/pull/4973 )
2019-09-10 10:11:58 -07:00
Sawyer Blatz
e2eb292241
[fenix] No issue: Only use iconTint in XML for bookmark menus ( https://github.com/mozilla-mobile/fenix/pull/5145 )
2019-09-10 09:04:05 -07:00
Tiger Oakes
0e9d9d82c5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3440 - Reduce BrowserFragment require calls
2019-09-09 21:33:32 -07:00
mihai-adrian
8a5b5682f4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4517 : Keep Bookmarks fragment when navigating to browser
...
Removed popUp when navigating from bookmarks to browser
2019-09-09 20:52:36 -07:00
Colin Lee
06d8f42c94
[fenix] Delete AUTH_SESSIONS with COOKIES
2019-09-09 12:32:28 -07:00
Colin Lee
a34b774213
[fenix] Updates per UX and PR feedback
2019-09-09 12:32:28 -07:00
Colin Lee
736fb7fd7c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3106 : Granular options for clearing user data
2019-09-09 12:32:28 -07:00
Emily Kager
6103a21747
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4763 - Enable GV logging in debug builds ( https://github.com/mozilla-mobile/fenix/pull/5144 )
2019-09-09 11:20:51 -07:00
Aaron Train
7f6fdcda4b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/5137 - Add Find in Page UI Test ( https://github.com/mozilla-mobile/fenix/pull/5138 )
2019-09-09 14:16:47 -04:00
Sawyer Blatz
1cfb9cef09
[fenix] No issue: Top aligns close button for tab in collection ( https://github.com/mozilla-mobile/fenix/pull/5161 )
...
See https://github.com/mozilla-mobile/fenix/pull/4442#issuecomment-528580904 for more info
2019-09-09 11:08:30 -07:00
Petru Lingurar
37308af6b8
[fenix] Code cleanup - Remove unused FindInPageBarBehavior
...
There is a "unused" lint suppression in place with the comment
"Referenced from XML". I found no such usage.
It's documentation says that this Behavior will always position FindInPageBar
above BrowserToolbar but the current code ensures
BrowserToolbar.visibility == GONE when FindInPageBar.visibility == VISIBLE
so there's no need for such behavior.
2019-09-06 14:20:02 -04:00
Petru Lingurar
f911a3d485
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4856 - Refactor InflationAwareFeatureTest
...
We previously had a test exactly for checking that "start does nothing" but we
now need to ensure that start actually is propagated to the inner feature that
is to rebind itself to the app to allow for user interactions.
2019-09-06 14:20:02 -04:00
Petru Lingurar
c6f298f9fb
[fenix] Fix https://github.com/mozilla-mobile/fenix/issues/4856 - Propagate LifecycleAwareFeature's onStart() to the inner feature
...
FindInPageFeature is used inside the app as a LifecycleAwareFeature and as such
it receives the onStart / onStop lifecycle calls.
The onStart() lifecycle call would not get passed to the feature but in
onStop() FindInPageFeature will detach it's Presenter and Interactor so when
the user comes back to the screen she could not interact anymore with the
feature.
To fix this we'll propagate LifecycleAwareFeature's onStart() to the inner
feature which is to rebind it's Presenter and Interactor in onStart().
This behavior is common to all the other features so all of them who implement
LifecycleAwareFeature will now get the onStart() call also.
2019-09-06 14:20:02 -04:00
Mihai Adrian
3312a8c307
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4193 - Makes close button for tabs more accessible ( https://github.com/mozilla-mobile/fenix/pull/4442 )
...
* fixes https://github.com/mozilla-mobile/fenix/issues/4193 - made close button for tabs more accessible.
set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button and text as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
* Fix margins
2019-09-06 10:33:55 -07:00
Sawyer Blatz
db43c5db32
[fenix] No issue: Removes unused nestedScrollQuickActionView ( https://github.com/mozilla-mobile/fenix/pull/5143 )
2019-09-06 09:03:24 -07:00
mihai-adrian
9d18725a8b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5142 Removed RadioButton from accessibility keeping one option for Talkback
...
Set android:importantForAccessibility = "no" for RadioButton
2019-09-06 14:09:58 +02:00
Sawyer Blatz
88996e7f0c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/964 : Adds ability to disable each suggestion provider ( https://github.com/mozilla-mobile/fenix/pull/5096 )
...
* For https://github.com/mozilla-mobile/fenix/issues/964 : Adds ability to disable each suggestion provider
* Fix nit
2019-09-05 14:45:44 -07:00
Jonathan Almeida
5891296994
[fenix] No issue: Add logging for firebase/autopush
2019-09-05 16:03:36 -04:00
Emily Kager
470b943edd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5033 - Update browsing mode when session selected ( https://github.com/mozilla-mobile/fenix/pull/5118 )
2019-09-05 14:27:30 -05:00
Richard Pappalardo
6a54b74c1e
[fenix] Temporarily disable broken UI test ( https://github.com/mozilla-mobile/fenix/pull/5136 )
2019-09-05 10:22:14 -07:00
Alessio Placitelli
cf76cd9c62
[fenix] Enable Gecko metrics exfiltration through Glean ( https://github.com/mozilla-mobile/fenix/pull/5126 )
2019-09-05 11:58:35 -05:00
Emily Kager
16d1b63850
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5075 - Fix boolean error for private mode notification persistence ( https://github.com/mozilla-mobile/fenix/pull/5120 )
2019-09-05 09:21:56 -07:00
Sebastian Kaspari
fcee35b059
[fenix] Remove ThumbnailsFeature. ( https://github.com/mozilla-mobile/fenix/pull/5127 )
...
We currently do not use thumbnails anywhere in the app. Not using the feature means we are
not taking thumbnails on every page load which means we are saving memory and CPU cycles.
2019-09-05 11:05:37 -05:00
Grisha Kruglov
7cd0e2d290
[fenix] Fix breaking services APIs changes
2019-09-05 13:38:15 +02:00
Sebastian Kaspari
9fdfd82bc0
[fenix] Update to Mozilla Android Components 12.0.0-SNAPSHOT.
2019-09-05 13:38:15 +02:00
Sebastian Kaspari
1ad6f0ea20
[fenix] Add browser-state component.
2019-09-05 13:38:15 +02:00
Alessio Placitelli
0ab76faedb
[fenix] Revert "Enable Gecko metrics exfiltration through Glean ( https://github.com/mozilla-mobile/fenix/pull/5124 )" ( https://github.com/mozilla-mobile/fenix/pull/5125 )
...
This reverts commit ed9c9cffa8033784f9ab3c7391c177ab5b66cf1e.
2019-09-05 04:26:46 -05:00
Alessio Placitelli
7d25624e16
[fenix] Enable Gecko metrics exfiltration through Glean ( https://github.com/mozilla-mobile/fenix/pull/5124 )
2019-09-05 04:17:28 -05:00
Emily Kager
a4172aafae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5025 - Do not remove custom tab session with config removed
2019-09-05 10:57:37 +02:00
Sawyer Blatz
d0fa780907
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4155 : Adds strings for long press popup ( https://github.com/mozilla-mobile/fenix/pull/5112 )
2019-09-04 17:15:06 -07:00
Emily Kager
dafda5ba3c
[fenix] No issue: Land strings for delete browsing data on quit
2019-09-04 15:45:10 -07:00
Yeon Taek Jeong
e039e6a5ac
[fenix] For https://github.com/mozilla-mobile/fenix/issues/419 : Add strings for "Add private browsing shortcut" feature ( https://github.com/mozilla-mobile/fenix/pull/5109 )
2019-09-04 15:44:22 -07:00
Jeff Boek
51b7cc54cf
[fenix] For i5047 - Adds strings for the add to homescreen dialog
2019-09-04 15:18:44 -07:00
Sawyer Blatz
5a5f46cb76
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5021 : Adds metric for what's new button
2019-09-04 09:17:14 -07:00
Sawyer Blatz
da34c36d24
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4908 : Adds metrics for send tab telemetry
2019-09-04 09:15:50 -07:00
mihai-adrian
d6883885e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5095 : Changed search engine text color from default to ?primaryText
2019-09-04 07:57:17 -07:00
mihai-adrian
1329fdef70
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4892 : Replaced straight single quote with curly apostrophe in contractions
2019-09-04 14:10:05 +02:00
Axel Hecht
2dfb11a83a
[fenix] Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@6d2fe8331a
2019-09-04 14:08:15 +02:00
Sawyer Blatz
e0e1bdba5c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4474 : Adds what's new button to home screen menu ( https://github.com/mozilla-mobile/fenix/pull/5088 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4474 : Adds what's new button to home screen menu
* For https://github.com/mozilla-mobile/fenix/issues/4474 : Adds tests for what's new button
2019-09-03 15:16:29 -05:00
Petru Lingurar
8c4f0ecc02
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5067 - Refactor ShareControllerTest following the use of SendTabUseCases
2019-09-03 12:01:26 -07:00
Petru Lingurar
2f4392c064
[fenix] Fix https://github.com/mozilla-mobile/fenix/issues/5067 - Refactor ShareController to use SendTabUseCases
...
Navigation between app fragments uses ShareTab as arguments. The newly used
SendTabUseCases uses TabData which is not Parcelable.
For minimal changes we'll keep both data classes and ShareController will know
how to map between the two.
Removed the `sessionId` property of ShareTab as it isn't needed anymore.
2019-09-03 12:01:26 -07:00
Sebastian Kaspari
98f0427ea2
[fenix] Fix ktlint MaxLineLength issues.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
d4849ca93e
[fenix] Stores: Reduce visibility of reducer functions.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
ec29bdbc78
[fenix] Rename HistoryStore/State/Action to HistoryFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
a682a16b25
[fenix] Rename AccountSettingsStore/State/Action to AccountSettingsFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
0a46f6d16a
[fenix] Rename SearchStore/State/Action to SearchFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
5a3bfb2b77
[fenix] Rename ExceptionsStore/State/Action to ExceptionsFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
52d15c5be7
[fenix] Rename BrowserStore/State/Action to BrowserFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
c0b76b338f
[fenix] Rename BookmarkStore/State/Action to BookmarkFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
mihai-adrian
309495f15a
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4997 : Changed navigation to ShareFragment
...
Changed test for new global navigation to share fragment.
2019-09-03 07:08:08 -10:00
mihai-adrian
0f119aae4e
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4997 : Changed navigation to ShareFragment
...
Added global navigation action to share fragment in navigation graph
Changed share action to use global navigation to ShareFragment
2019-09-03 07:08:08 -10:00
Sebastian Kaspari
61c2a0878f
[fenix] Issue https://github.com/mozilla-mobile/fenix/pull/4907 : Link to usage of sharedUserId in Fennec code.
2019-09-03 17:10:06 +02:00
Sebastian Kaspari
720589cbb0
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873 : Use manifest placeholder to inject sharedUserId.
2019-09-03 17:10:06 +02:00
Sebastian Kaspari
7a554f2f4e
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873 : Reuse sharedUserId from Fennec for fennecProduction build type.
2019-09-03 17:10:06 +02:00
Sebastian Kaspari
9a01bb2639
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873 : Use Fennec version code mechanism for fennecProduction build type.
2019-09-03 17:10:06 +02:00
Sebastian Kaspari
b4b87eb165
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873 : Only build fennecProduction build types with GeckoView Beta.
2019-09-03 17:10:06 +02:00
Sebastian Kaspari
c91a28030f
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873 : Reuse Firefox application id for fennecProduction build type.
2019-09-03 17:10:06 +02:00