1b6aa1dfff
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17800 : Cleanup and fix request desktop site from home
3 years ago
57df4f3fcc
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19112 : Remove old Synced Tabs code
3 years ago
aa8d5795b2
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/19112 : Remove old tab tray code
3 years ago
3eff41bd2d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19114 : check state of sync account when navigating from sync sign in menu item ( https://github.com/mozilla-mobile/fenix/pull/19118 )
3 years ago
c56f3835be
[fenix] For https://github.com/mozilla-mobile/fenix/issues/19005 : new tab three-dot menu sync sign in ( https://github.com/mozilla-mobile/fenix/pull/19037 )
...
* Show synced tabs or sync account in new tab menu
* Sync sign in item navigates to account settings
* Check account auth and get sync item title
* Look for sync sign in item on home menu for UI test
* Sync sign in menu item UI test
3 years ago
8e8a872127
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18854 : Add metrics for home screen being displayed.
3 years ago
c4609f6e35
[fenix] No issue: Fix indenting in onViewCreated.
3 years ago
4ff47f6c1d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18856 : Add metrics for opening settings screen from home menu.
3 years ago
62f839d75a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18815 : Expand app bar on onboarding dismissal and browsing start.
3 years ago
4c45f615bb
[fenix] 16900 make navgraph inflation asynchronous ( https://github.com/mozilla-mobile/fenix/pull/18889 )
...
* For https://github.com/mozilla-mobile/fenix/issues/16900 : implement async navgraph inflation
For https://github.com/mozilla-mobile/fenix/issues/16900 : removed nav graph from xml
For https://github.com/mozilla-mobile/fenix/issues/16900 : inflate navGraph programatically
For https://github.com/mozilla-mobile/fenix/issues/16900 : Made NavGraph inflation asynchronous
For https://github.com/mozilla-mobile/fenix/issues/16900 : Changed to block with runBlocking
For https://github.com/mozilla-mobile/fenix/issues/16900 : Refactored blocking call into a function
For 16900: NavGraph inflation is now async
We now attach the nav graph (or check if its attached) on every nav call ( an extension function for NavController).
This is done by checking the value of the job stored in PerfNavController.map which keeps track of the job with the NavController as a Key.
If the job hasn't been completed, it will block the main thread until the job is done. The job itself is responsible for attaching the navgraph
to the navcontroller (and the inflation of the latter too)
For 16900: rebased upstream master
For 16900: Rebase on master
For https://github.com/mozilla-mobile/fenix/issues/16900 : Fixed Async Navgraph navigation per review comments.
1)The Asynchronous method is now found in NavGraphProvider.kt. It creates a job on the IO dispatcher
2)The Job is tracked through a WeakHashMap from Controller --> NavGraph
3)The Coroutine scope doesn't use MainScope() anymore
4)The Coroutine is cancelled if the Activity is destroyed
5)The tests mockk the blockForNavGraphInflation method through the FenixReoboelectricTestApplication instead of calling the mock every setup()
For https://github.com/mozilla-mobile/fenix/issues/16900 : inflateNavGraphAsync now takes navController
For https://github.com/mozilla-mobile/fenix/issues/16900 : Pass lifecycleScope to NavGraphProvider
For https://github.com/mozilla-mobile/fenix/issues/16900 : removed unused mock
For https://github.com/mozilla-mobile/fenix/issues/16900 : Added linter rules for navigate calls
We need linting rules to make sure no one calls the NavController.navigate() methods
For https://github.com/mozilla-mobile/fenix/issues/16900 : Added TestRule to help abstract the mocks in the code
For 16900: Fix linting problems
For https://github.com/mozilla-mobile/fenix/issues/16900 : Cleaned duplicated code in tests
For https://github.com/mozilla-mobile/fenix/issues/16900 : cleaned up NavGraphTestRule for finished test
For https://github.com/mozilla-mobile/fenix/issues/16900 : had to revert an accidentally edited file
For https://github.com/mozilla-mobile/fenix/issues/16900 : rebased master
* For https://github.com/mozilla-mobile/fenix/issues/16900 : Review nits for async navgraph
This is composed of squash commits, the original messages can be found below:
-> DisableNavGraphProviderAssertionRule + kdoc.
Use test rule in RobolectricApplication.
Fix failing CrashReporterControllerTest
Fix blame by -> navigate in tests.
This commit was generated by the following commands only:
```
find app/src/test -type f -exec sed -i '' "/import org.mozilla.fenix.ext.navigateBlockingForAsyncNavGraph/d" {} \;
find app/src/test -type f -exec sed -i "" "s/navigateBlockingForAsyncNavGraph/navigate/g" {} \;
git checkout app/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker
```
Fix various blame
This is expected to be squashed into the first commit so, if so, it'd
fix the blame.
Move test rule to helpers pkg.
add missing license header
Add import change I missed
fix unused imports
Replace robolectricTestrunner with test rule.
Improve navGraphProvider docs
Remove unnecessary rule as defined by robolectric.
add clarifying comment to robolectric
remove unnecessary space
* For https://github.com/mozilla-mobile/fenix/issues/16900 : nit fixes for MozillaNavigateCheck and lint fixes
3 squash commits:
*Changed violation message and fixed the lint rule for MozillaNavigateCheck
*Added suppression to NavController.kt
*Fixed detekt violations
* For 16900: Fixed failing tests
Co-authored-by: Michael Comella <michael.l.comella@gmail.com>
3 years ago
ed8d36520e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18375 : Add experiment for set default browser New Tab card.
3 years ago
990fe44056
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17770 : New tab three-dot menu reorder ( https://github.com/mozilla-mobile/fenix/pull/18427 )
...
* Create new menu order for new tab
* Add new tab menu navigation. Dynamically update menu when sync auth is needed. Make new tab menu and browser menu consistent.
* Lint
Lint and refactoring tests
* Tests for default toolbar menu
* Feature flag for request desktop site
Add todos for UI test issue 17979
Add todos for UI tests
3 years ago
4da13e56c1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17800 - Request desktop site from home screen. ( https://github.com/mozilla-mobile/fenix/pull/18653 )
3 years ago
3b2bda7c81
[fenix] For https://github.com/mozilla-mobile/fenix/issues/18426 : add measurement probes for long-running lifecycle methods.
...
In addition to the existing probes for onCreate, this should cover all
lifecycle methods that take a long time in our profiles.
3 years ago
122597ce56
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/17822 : Create a tabs tray layout and fragment
...
Co-authored-by: Kate Glazko <kglazko@Kates-MacBook-Pro.local>
3 years ago
a0ed1a4a1d
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17871 - use viewLifecycleOwner for TopSitesFeature owner on HomeFragment ( https://github.com/mozilla-mobile/fenix/pull/17873 )
3 years ago
466a163f05
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17785 - Use screenshots setting when adding secure flag
3 years ago
762c10940c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17092 : Dismiss toolbar menu when configuration change occurs ( https://github.com/mozilla-mobile/fenix/pull/17682 )
3 years ago
5c17f03edb
[fenix] Pop out privacy notice in first launch in MozillaOnline builds
...
Add privacy notice related strings
Pop out privacy notice with onboarding
Using embeded geckoview to display details about privacy
Present or hide privacy pop window according to isMozillaOnline
Add activity_privacy_content_display.xml into layoutNotToTest due to EngineView
3 years ago
cc56c0e127
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17655 : Do not pass threshold if showTopFrecentSites is false. ( https://github.com/mozilla-mobile/fenix/pull/17657 )
...
* For https://github.com/mozilla-mobile/fenix/issues/17655 : Do not pass threshold if showTopFrecentSites is false.
* For https://github.com/mozilla-mobile/fenix/issues/17655 : Add unit tests for getTopSitesConfig.
3 years ago
c32923f0ce
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14302 - Skip one time pages visit from frecent top sites
3 years ago
d013bf3242
[fenix] Refactor HomeFragment to use browser store
3 years ago
e76960b389
[fenix] A-C 71.0.20210118134928: Fix breaking API in TabCounterToolbarButton
3 years ago
997f1f9454
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17400 : Select tab opened from collection.
4 years ago
b0f7acdaff
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17443 : IllegalStateException in startPostponedEnterTransition on HomeFragment
4 years ago
39c21ff474
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17303 : Move ext fun runIfFragmentIsAttached to utils
...
move to ext
4 years ago
fa25b4e258
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17177 - Do not show PBM CFR if entering search on home, make sure fragment attached before showing
4 years ago
52267f2764
[fenix] Switch to new feature-tab-collections API.
4 years ago
04611dda64
[fenix] For https://github.com/mozilla-mobile/fenix/issues/17061 : Prevent appBarLayout from leaking.
4 years ago
28d0d32a53
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15636 - Focus a11y collection on snackbar view tap ( https://github.com/mozilla-mobile/fenix/pull/16853 )
...
With accessibility enabled, when adding a site to a collection and tapping "View" on the snackbar, we send a request for focus and an `AccessibilityEvent.TYPE_VIEW_FOCUSED` to the specified collection.
4 years ago
bfe1ad1961
[fenix] Reload restored tabs from collection ( https://github.com/mozilla-mobile/fenix/pull/16865 )
4 years ago
198c065970
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/8791 : Use A-C tab counter and upgrades to A-C 69.0.20201203202830
...
Upgrades to A-C 69.0.20201203202830 and addresses breaking changes:
- Upgrades androidx workmanager to 2.4.0 in line with A-C.
- RecordingDevicesNotificationFeature was removed
- SearchUseCases accept parent session ID instead of session itself
4 years ago
6c07bc316f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16629 - Fix for collection snackbar View button ( https://github.com/mozilla-mobile/fenix/pull/16679 )
4 years ago
1f4134904d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16353 : Do not finish onboarding on search dialog opening.
4 years ago
d50140272a
[fenix] Integrate new search code from Android Components into Fenix.
4 years ago
29eb6e9d1f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/16351 - Make homescreen interactive when search dialog is up
4 years ago
5991d0996e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4652 - Remove activityViewModels workarounds
4 years ago
5fb5471df1
[fenix] For # 15929: Remove the search widget discoverability experiment. ( https://github.com/mozilla-mobile/fenix/pull/16081 )
...
* For https://github.com/mozilla-mobile/fenix/issues/15929 : Remove SearchWidgetCFR telemetry.
* For https://github.com/mozilla-mobile/fenix/issues/15929 : Remove SearchWidgetCFR and search widget experiment.
* For https://github.com/mozilla-mobile/fenix/issues/15929 : Remove unit tests references to search widget experiment.
4 years ago
85d7bb0baf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15480 - Update the UI when a collection is renamed
4 years ago
a41022554b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/15443 : Use fragment's lifecycleScope for AlertDialog actions
4 years ago
8a9472e540
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13959 : move resetAfter into StrictModeManager.
...
In a followup PR, we need to add state to strictModeManager (the
number of suppressions). This is much simpler to do when this is defined
as a class rather than an object. However, when this is defined as a
class, `resetAfter` needs access to the strictModeManager. Instead of
passing it in as an argument, it made sense to move this function onto
the strictModeManager instead.
Since folks are used to calling:
```
StrictMode.ThreadPolicy.allowThreadDiskReads().resetAfter
```
We're going to have to add a lint check to prevent them from doing that.
4 years ago
eca2b8ecf4
[fenix] Use "undo" implementation from Android Components.
...
This is not the super fancy version yet - since we still need to restore into SessionManager and
haven't fully switched to BrowserStore yet. However AC having knowledge about "undo" and whether
it was performed or not, will help us with features like "recently closed tabs". And once we
can improve "undo", Fenix will get all the nice things automatically.
Requires:
https://github.com/mozilla-mobile/android-components/pull/8449
4 years ago
cf0af49d3b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12383 https://github.com/mozilla-mobile/fenix/issues/15407 https://github.com/mozilla-mobile/fenix/issues/12860 - Switch to using shared view model for session to delete on home
4 years ago
609857c5f1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14280 , https://github.com/mozilla-mobile/fenix/issues/14743 : Remove old search fragment ( https://github.com/mozilla-mobile/fenix/pull/15169 )
...
* Remove search fragment
* Use new folder to search dialog
* Rebase and lint
* Update tests with search dialog nav directions
* Rename interactor to match naming convention. Remove old controller and point everything to the dialog controller.
4 years ago
65db93b8b5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15291 - Limit current CFRs to show max one every 3 days
4 years ago
da57dc840d
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/14131 : Move constants to dimens.xml ( https://github.com/mozilla-mobile/fenix/pull/14135 )
...
Co-authored-by: Elise Richards <erichards@mozilla.com>
4 years ago
71abc5c450
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2486 - Adds Recently Closed Tabs
4 years ago
12707f2b74
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14529 - Show a dialog when the top sites limit has been reached
4 years ago
d6f52584d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13949 - Turn off tip regarding beta/nightly
4 years ago
a9c11d6f3b
[fenix] Update to new state API and update Mozilla Android Components version.
...
The EngineSessionState of a tab is now always accessible through tab.engineState.engineSessionState. It will
never get cleared.
4 years ago
793b27980d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13926 - MP migration
4 years ago
a70bbb7aff
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14376 : Use concept-menu with tab counter menu ( https://github.com/mozilla-mobile/fenix/pull/14374 )
4 years ago
befdf304c4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14251 - Dont show CFR if were navigating to Search
4 years ago
4e2b53b340
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13507 - Performance fixes for the ReviewPromptController
4 years ago
eb45012b4b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13507 - Adds tests for ReviewPromptController
4 years ago
bf08d65510
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13507 - Extracts review prompt behavior into ReviewPromptController
4 years ago
fcdd29e56e
[fenix] Allow play store in app review to be shown to users
4 years ago
f2de6f25a1
[fenix] No Issue - Fixes UI Tests with new search experience
4 years ago
b49003287a
[fenix] No Issue - Removes pref, toggles new search based on feature flag only
4 years ago
0965df3817
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10342 - Part 4: Use the TopSitesFeature in the HomeFragment for displaying top sites
4 years ago
159f46c1c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10342 - Part 3: Use the TopSitesUseCase in the BrowserToolbarController and SessionControlController
...
Use the provided `addPinnedSites` and `removeTopSites` use cases in `BrowserToolbarController` and `SessionControlController`.
4 years ago
1f3f1f481d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10342 - Part 1: Remove top sites prefetch and observation of live data
4 years ago
ef574d051c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14157 : Pass correct anchor for context menu popup.
4 years ago
7d93541b3f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12377 - Choice to hide no collections placeholder from homescreen
4 years ago
ce57fdeeb9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/349 : View Downloads
4 years ago
6f3c613f97
[fenix] for https://github.com/mozilla-mobile/fenix/issues/11364 added a resetAfter for onboarding variable inside HomeFragment to avoid random system strictmode violations during UI testing. ( https://github.com/mozilla-mobile/fenix/pull/13811 )
4 years ago
4898f0edfc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13052 - When opening a new tab pre-open search
4 years ago
a42bb3c9de
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6313 - Removes unused browser animations, improve delayed paint interactions
4 years ago
4f119b055d
[fenix] Wires up controller, store and interactor. ( https://github.com/mozilla-mobile/fenix/pull/13324 )
...
* For https://github.com/mozilla-mobile/fenix/issues/13320 - Wires up the search store, controller and interactor for the new search experience
* For https://github.com/mozilla-mobile/fenix/issues/13323 - Navigates to new search experience from the browser when enabled
4 years ago
5b99bf33a1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/13052 - Creates new dialog fragment for search and puts it behind a feature flag
4 years ago
11baf289f3
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/12400 - Refresh swiped collection tab view
...
Item is now refreshed by calling notifyDataSetChanged on the adapter when the last tab from the collection has been swiped away and the user cancels the deletion by pressing the cancel button from the dialog.
Also added a "wasSwiped" flag to onCollectionRemoveTab in order to check if the tab was deleted from a swipe action and not by pressing the "X" button.
4 years ago
d7514bcf78
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6846 : Added quick actions for nav bar in home
4 years ago
1ced27bda6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10163 - Adds tab multiselect mode
4 years ago
fdf22f7e74
[fenix] No issue: fix master
4 years ago
adc1813fd6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12793 : Improve snackbars for tabs tray
4 years ago
b4a0e122d1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10997 : Remove scrolling from home ( https://github.com/mozilla-mobile/fenix/pull/12866 )
4 years ago
0d37525151
[fenix] Migrate from Session.toTab to BrowserStore ( https://github.com/mozilla-mobile/fenix/pull/12221 )
4 years ago
bf4a7cd969
[fenix] Create ToolbarPosition enum ( https://github.com/mozilla-mobile/fenix/pull/12747 )
4 years ago
3bccc0dd50
[fenix] Pass settings and metrics to CFR
4 years ago
54a6de9b84
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12735 : Fixes issue with tab deletion undo ( https://github.com/mozilla-mobile/fenix/pull/12737 )
4 years ago
549acfa6f1
[fenix] Test session control controller ( https://github.com/mozilla-mobile/fenix/pull/12652 )
4 years ago
58a456eb33
[fenix] For issue https://github.com/mozilla-mobile/fenix/issues/12126 - Tab counter consumeFrom update
...
Added a direct call to the updateTabCounter method to account for changes made to the BrowserState while the tabCounter view is not visible.
4 years ago
f27c27360a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11763 : Shows confirmation dialog when deleting last tab from collection
4 years ago
bad18816f2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11889 : Changes collection creation confirmation snackbar strings
...
Also I changed the adding tabs to collection confirmation string from
tabtray to take into account the number of tabs.
Example: 1 tab-"Tab saved!"; multiple tabs-"Tabs saved!"
4 years ago
53508bffea
[fenix] For https://github.com/mozilla-mobile/fenix/issues/12125 : Handle visibility updates for add to collection button.
4 years ago
1949ca714f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11991 - Show tab count during onboarding
4 years ago
fe4a508fbf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11841 : Removed topsite bug on private browsing ( https://github.com/mozilla-mobile/fenix/pull/12020 )
4 years ago
c6a8a6ed28
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11860 - Conditionally show add to collection button on Home screen
4 years ago
1aaf9108c7
[fenix] Followup for https://github.com/mozilla-mobile/fenix/issues/11442 - Add tab counter menu metrics to home fragment.
4 years ago
9818176c34
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11534 - Don't check lastUsed mode for screenshots ( https://github.com/mozilla-mobile/fenix/pull/11827 )
4 years ago
17d1072e3a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11660 : added prefetch for topsites and update in onCreateView() ( https://github.com/mozilla-mobile/fenix/pull/11668 )
...
* For https://github.com/mozilla-mobile/fenix/issues/11660:added prefetch for topsites
TopSites will be prefetched with observerOnce (wrapper around observerForever).
Also, the SessionControlView.update() is called right away instead of waiting from consumeFrom
in the HomeFragment.onCreateView() which will allow the UI to render all at once on its first
perform traversal
* Removed the submitList(null) since it retriggered a drawing on lower end device
4 years ago
e56cc28342
[fenix] for https://github.com/mozilla-mobile/fenix/issues/11617 added a resetPoliciesAfter ext function for StrictMode, and replaced all existing calls to "resetAfter" with "resetPoliciesAfter" ( https://github.com/mozilla-mobile/fenix/pull/11619 )
4 years ago
ce2b4b9bfb
[fenix] For 11428 - Focus on home screen address bar when tab tray new tab is tapped ( https://github.com/mozilla-mobile/fenix/pull/11429 )
4 years ago
2b3db93673
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10374 - Adds quick contextual menu to tab switcher
...
Co-authored-by: person808 <kainaluh808@gmail.com>
4 years ago
c5d5a12d0e
[fenix] for https://github.com/mozilla-mobile/fenix/issues/10839 added IO coroutine to check onboarding stat from sharedpref ( https://github.com/mozilla-mobile/fenix/pull/11338 )
...
changed coroutine scope to fragments lifecycle
4 years ago
c17dc6a61b
[fenix] for https://github.com/mozilla-mobile/fenix/issues/7225 , Changed strictMode thread penalty to dialog on startup and back to logs after startup is done. ( https://github.com/mozilla-mobile/fenix/pull/10831 )
...
for https://github.com/mozilla-mobile/fenix/issues/7225 , refactored and cleanup the branch.
for https://github.com/mozilla-mobile/fenix/issues/7225 , change strict mode policy only on main process.
for https://github.com/mozilla-mobile/fenix/issues/7225 , setting thread policy inside a seperate thread to keep it from getting overridden in activities.
for https://github.com/mozilla-mobile/fenix/issues/7225 removed Handler().postAtFrontOfQueue as a solution due to unknown side effects. moved the enableStrictMode function to be static so we can reuse it.
for https://github.com/mozilla-mobile/fenix/issues/7225 lint check
for https://github.com/mozilla-mobile/fenix/issues/7225 created strict mode manager and moved enabledStrictMode function inside it.
for https://github.com/mozilla-mobile/fenix/issues/7225 removed penalty death on network
for https://github.com/mozilla-mobile/fenix/issues/7225 added allow disk access on thread for already existing violation
strict mode running in main process to see if it passes the gitlab check, will revert it if it doesnt
allowed diskread for super.onCreate for home activity
added comments for disk violation oncreate homeactivity
added fragment manager inside strictmode manager
allowed disk read for onboarding
allowed disk read for cachedTopSites
4 years ago
2c2cc97b97
[fenix] Remove tab tray feature flag ( https://github.com/mozilla-mobile/fenix/pull/11176 )
...
* For https://github.com/mozilla-mobile/fenix/issues/11171 - Removes feature flag for the new tab tray
* For https://github.com/mozilla-mobile/fenix/issues/11171 - Removes all tab references from homeFragment
* For https://github.com/mozilla-mobile/fenix/issues/11171 - Fixes unit tests
* For https://github.com/mozilla-mobile/fenix/issues/11171 - Gets UI tests to compile and HomeScreenTest to pass
* For https://github.com/mozilla-mobile/fenix/issues/11171 - Fixes `deleteMultipleSelectionTest`
* For https://github.com/mozilla-mobile/fenix/issues/11171 - Fixes `openHistoryItemInNewPrivateTabTest`
* For https://github.com/mozilla-mobile/fenix/issues/11171 - Fixes `openHistoryInPrivateTabTest`
* For https://github.com/mozilla-mobile/fenix/issues/11171 - Fixes `openHistoryInNewTabTest`
* For https://github.com/mozilla-mobile/fenix/issues/11171 - Fixes `openNewPrivateTabTest`
* For https://github.com/mozilla-mobile/fenix/issues/11171 - Fixes tabbedBrowsingTests
* For https://github.com/mozilla-mobile/fenix/issues/11171 - Fixes SettingsPrivacyTest
* For https://github.com/mozilla-mobile/fenix/issues/11171 - Fixes TopSitesTest
* For https://github.com/mozilla-mobile/fenix/issues/11171 - Fixes lint errors
* Ignore
4 years ago
49359e95e0
[fenix] Scroll to the top of home when using the tab tray
4 years ago
c02dd322e2
[fenix] Implement tab tray design improvements and fix close functionality.
4 years ago
6713c90c14
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/9696 : Adds Add-ons menu item to the home menu
4 years ago
d7faa8c2c5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10834 - Adding Sync Tabs Feature in Fenix
4 years ago
b314fce425
[fenix] Refactors the TabTrayDialogFragment to ditch that weird interactor ( https://github.com/mozilla-mobile/fenix/pull/11061 )
...
* For https://github.com/mozilla-mobile/fenix/issues/11056 - Removes unused argument when navigating to the collection creation fragment
* For https://github.com/mozilla-mobile/fenix/issues/11056 - Moved the collection creation navigation logic to the TabTrayDialogFragment
* For https://github.com/mozilla-mobile/fenix/issues/11056 - Moves navigating to the share screen from home/browser to the TabTrayDialogFragment
* For https://github.com/mozilla-mobile/fenix/issues/11056 - We moved tab selection logic from home/browser to the tab tray dialog
* For https://github.com/mozilla-mobile/fenix/issues/11056 - Moved new tab tapped logic to the tab tray dialog fragment
* For https://github.com/mozilla-mobile/fenix/issues/11056 - Removes all interactor logic for the TabTrayDialogFragment
* For https://github.com/mozilla-mobile/fenix/issues/11056 - Migrates the presentation / navigation around the TabTrayDialog to the androidx navigation library
4 years ago
64896fe497
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/10064 : Open help articles in normal tab instead of custom tab
4 years ago
b23bda3827
[fenix] For 11001 - Show close all tabs above tab tray
4 years ago
b5b49eccb6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9488 : Add search widget CFR
4 years ago
017016e655
[fenix] For 10734 - Open tab tray when collection is opened from Home ( https://github.com/mozilla-mobile/fenix/pull/10751 )
...
* For 10734 - Open tab tray when collection is opened from Home
* Update to work with tab tray drawer
4 years ago
bb512269ab
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10865 - Implement 3 dot menu for tab tray ( https://github.com/mozilla-mobile/fenix/pull/10869 )
4 years ago
2596bb1c51
[fenix] Remove onTabClosed from interactor
4 years ago
312998c39d
[fenix] Fix elevation for snackbar and fab
4 years ago
40381c9e65
[fenix] Move snackbar to TabTrayDialogFragment
4 years ago
dec2ddef27
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10864 - Display snack bar to undo closing tabs
4 years ago
2c2ca71d82
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10596 - Redirect moz://a URL ( https://github.com/mozilla-mobile/fenix/pull/10688 )
4 years ago
f92ea0f960
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10504 - Removes "old" TabTrayFragment
4 years ago
18f664f477
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10504 - cleans up tabLayout colors
4 years ago
8c770984a0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10504 - Adds tabTrayDialogInteractor to browserfragment
4 years ago
62eda22d40
[fenix] For https://github.com/mozilla-mobile/fenix/issues/10504 - Creates the TabTrayDialogFragment
4 years ago
eb47788f4d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6832 - Only emit session changes if fragment is attached
4 years ago
b676537519
[fenix] Cache findViewById calls in session control ( https://github.com/mozilla-mobile/fenix/pull/10575 )
4 years ago
8a493357ba
[fenix] Update Android Components version to 41.0.20200506130132 ( https://github.com/mozilla-mobile/fenix/pull/10443 )
4 years ago
4f3f47d30d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1063 : Put tab tray behind a feature flag and hidden pref ( https://github.com/mozilla-mobile/fenix/pull/10313 )
...
* For https://github.com/mozilla-mobile/fenix/issues/1063 - Adds feature flag and pref for new tab tray
* For https://github.com/mozilla-mobile/fenix/issues/1063 - Swaps add tab to tab tray button when newTabTray is enabled
* For https://github.com/mozilla-mobile/fenix/issues/1063 - Creates hidden preference to use new tab tray
* For https://github.com/mozilla-mobile/fenix/issues/1063 - Hides tabs on home screen when setting is enabled
* For https://github.com/mozilla-mobile/fenix/issues/1063 - Navigate to new tab tray from browser with setting enabled
* For https://github.com/mozilla-mobile/fenix/issues/1063 - Fixes regression where we dont show the new tab message with no tabs and no collections
* For https://github.com/mozilla-mobile/fenix/issues/1063 - Fixes crash when toggling to private mode on the home screen
* For https://github.com/mozilla-mobile/fenix/issues/1063 - combines both settings. Cleans up lint errors
4 years ago
b5f847467f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6832 - Fix various fragment not attached to a context crashes
4 years ago
8ed532ebdf
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9208 : Adds in-product prompt to homescreen ( https://github.com/mozilla-mobile/fenix/pull/9836 )
4 years ago
5c0d300938
[fenix] Don't use ProcessLifecycleOwner for view-tied consume
4 years ago
b28a0e8ce9
[fenix] No issue: Fix leaking sessionControlInteractor
4 years ago
94515941cf
[fenix] Use HomeFragment viewLifecycleOwner for BrowserSessionsObserver
4 years ago
2a4ad0e4eb
[fenix] Use HomeFragment's viewLifecycleOwner as the lifecycle for accountManager observer registry
...
If we just use the HomeFragment itself, we end up with a memory leak since the lifecycle events
that would clean up the registry (e.g. destroy) won't run (if the fragment is retained in the backstack, for example).
4 years ago
3b980dadad
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3194 - Pause media while undo snackbar appears
4 years ago
6308049167
[fenix] Cleans up nav_graph.xml ( https://github.com/mozilla-mobile/fenix/pull/9829 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up homeFragment directions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Uses global actions for fragments not owned by homeFragment
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up SearchFragment directions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes settings action from DeleteBrowsingDataFragment
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes browser action from SettingsFragment
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Adds ManagePhoneFeature global action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Clean up unused deletebrowsingfragment actions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans Up HistoryFragment actions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes Home -> Search action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes the Bookmark -> Browser action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up bookmark fragment actions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up actions from ShareController
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes defaultBrowserFragment to browserFragment action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes about -> browser action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Adds global action to TrackingProtectionFragment
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes exception -> browser action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes login -> browser action
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Fixes LoginFragment directions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Removes ExternalAppBrowser directions
* for https://github.com/mozilla-mobile/fenix/issues/9751 - Cleans up actions
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Fixes unit tests
* For https://github.com/mozilla-mobile/fenix/issues/9751 - Addresses nits in PR
4 years ago
101d815231
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9890 - Do not display full screen snackbar with toolbar padding
4 years ago
8f1876407b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9687 : Refactor onboarding cards to follow app architecture ( https://github.com/mozilla-mobile/fenix/pull/9743 )
...
* For https://github.com/mozilla-mobile/fenix/issues/9687 : Refactor onboarding cards to follow app architecture
* For https://github.com/mozilla-mobile/fenix/issues/9687 : Update unit test to new controller parameters
4 years ago
9e5e780a9a
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9128 & https://github.com/mozilla-mobile/fenix/issues/9222 & https://github.com/mozilla-mobile/fenix/issues/9499 : Refactors snackbar creation and fixes placement ( https://github.com/mozilla-mobile/fenix/pull/9628 )
4 years ago
ea9add8d2b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8125 - Send top sites count with metrics ping
4 years ago
1a25bc758e
[fenix] Part 5: Refactor HomeMenu<->HomeFragment interaction
...
This refactor "reverses" relationship between these two classes, allowing
HomeMenu to inform its parent, HomeFragment, of any changes to the menu.
Once that's in place, we start observing account manager changes (once its ready)
for account problems.
This solves two problems:
- initialization of the account manager is no longer necessary to build a home menu
- home menu now starts observing changes to the account manager's state (before it was static)
4 years ago
13deec03a1
[fenix] Part 4: Make sure 'sync is on' snackbar does not initialize account manager
4 years ago
e488ed1773
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/9132 : Update to search animation for top toolbar ( https://github.com/mozilla-mobile/fenix/pull/9524 )
...
* let animation in top toolbar mode play nicely.
* remove duplicate methods, make code readable.
* migrate getToolbarNavOptions method to BrowserAnimator, one method to rule them all.
* Update linting
Co-authored-by: ahmedmamdouh13 <ahmedmamdouh13196@gmail.com>
4 years ago
ceec72715d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9498 : Replace navargs with viewModel to remember if scroll to tab
4 years ago
de3dda8af1
[fenix] Update to new feature-media API.
4 years ago
b65982aba1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7356 : Scroll to selected tab when pressing tab overview
4 years ago
7ecf93b320
[fenix] For https://github.com/mozilla-mobile/fenix/issues/9207 - changed status bar color in home fragment to match gradient background
4 years ago
fc2c801048
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8561 - Scroll to topSites on app cold start
4 years ago
887c1c0d7a
[fenix] No issue - Fixes shadow on top layout
4 years ago
81abd0c497
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8949 - Removes old motionlayout code, fixes how shadow is drawn
4 years ago
4b14b16d51
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7158 : Improves home to search animation ( https://github.com/mozilla-mobile/fenix/pull/9008 )
4 years ago
74a8a9e29d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/167 : Improves home to browser animation
4 years ago
036e74f0f4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6607 Add button to no tab content pane
4 years ago
7e4c381982
[fenix] Make 'Redirect to Sync' home menu item go directly to the 'Reconnect to Sync' / error screen
4 years ago
1462e34c3f
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7504 - Update sync error display in menus ( https://github.com/mozilla-mobile/fenix/pull/8639 )
4 years ago
0c4725dbfb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5843 - Ensure tabs pending deletion are removed
4 years ago
dba1d8166d
[fenix] Reverts all BrowsingModeManager changes
4 years ago
dcd851b611
[fenix] Use Mozilla Android Components 34.0.0-SNAPSHOT. ( https://github.com/mozilla-mobile/fenix/pull/8527 )
4 years ago
faf145a04d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8408 : fix requireContext crash in HomeFragment#onViewCreated
4 years ago
0d7a8129f9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6980 : Update Private browsing card.
...
Added test to description.
Added link to settings.
Updated unit tests.
4 years ago
0e13878eb2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8153 : Allow web-ext to open new tabs in correct browsing mode
4 years ago
e39a1948d9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8262 : Set toolbar position relative anchor for collection snackbars
4 years ago
35faf84bfc
[fenix] For https://github.com/mozilla-mobile/fenix/issues/8212 - Fixes shadow/border when toolbar is on top ( https://github.com/mozilla-mobile/fenix/pull/8234 )
4 years ago
b3231947de
[fenix] reverting linting changes that touched codes that I didn't edit
4 years ago
ee51e9931c
[fenix] https://github.com/mozilla-mobile/fenix/pull/8085 removed findViewById with actual id
4 years ago
06587df3da
[fenix] https://github.com/mozilla-mobile/fenix/issues/7700 fixed linting issues
4 years ago
2a95a80b9f
[fenix] https://github.com/mozilla-mobile/fenix/issues/7700 fixed scrolling, parallax action to match both images and some code clean up
4 years ago
3fd0dd7663
[fenix] https://github.com/mozilla-mobile/fenix/issues/7700 squash commit and fixing toolbar to switxh to top with coordinatorlayout
4 years ago
67d02f76f5
[fenix] Fix linting issue
4 years ago
0f6e965248
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6820 : Updates background, shadow, & snackbars of toolbar
4 years ago
6ae992fc28
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6820 : Place address bar at top or bottom of the home screen based on user preference
4 years ago
f55a5190e2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7730 - always show "Add private browsing shortcut" in sett… ( https://github.com/mozilla-mobile/fenix/pull/7943 )
4 years ago
7b4c67bcc1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6758 - Part 5: Add top sites to the HomeFragmentStore
4 years ago
6cf9aeb006
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7029 : Navigate to Search Fragment when pressing Start browsing
5 years ago
4eb62cfc13
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7506 : show highlight on home 3-dot button ( https://github.com/mozilla-mobile/fenix/pull/7665 )
5 years ago
901ddb03e9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7423 : remove unnecessary wordmark_spacer view.
...
Co-authored-by: Emma Malysz <emalysz@mozilla.com>
5 years ago
1b6e2b2f2d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6308 : Remove unecessary telemetry & bump expiry date ( https://github.com/mozilla-mobile/fenix/pull/7793 )
...
* For https://github.com/mozilla-mobile/fenix/issues/6308 : Remove unecessary telemetry
* For https://github.com/mozilla-mobile/fenix/issues/6308 : Bump expiry date on telemetry
5 years ago
f832b4d1d8
[fenix] Update list of tabs after onboarding screen was dismissed.
5 years ago
e36fd53543
[fenix] Open "migration FAQ" when selecting "What's new" in a Fennec build.
5 years ago
7dc3a94acd
[fenix] For 6832: update implementation/comment to align w existing AC code
5 years ago
1b2c0bd799
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6832 : fix unattached context crash in HomeFragment
5 years ago
b86face3d4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6413 : Adds more snackbar positioning logic ( https://github.com/mozilla-mobile/fenix/pull/7444 )
...
* For https://github.com/mozilla-mobile/fenix/issues/6413 : Adds more snackbar positioning logic
* Refactor
5 years ago
1249b4a5ca
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/7254 - Replace Anko applyConstraintSet ( https://github.com/mozilla-mobile/fenix/pull/7286 )
...
* For https://github.com/mozilla-mobile/fenix/issues/7254 : Replace anko applyConstraintSet
* Anko has been deprecated and will not be continued
* Refactor ConstraintSet changes
* Replace applyConstraintSet in SearchLayouts
* Refactor HomeFragment ConstraintSet
* Define anonymous ConstraintSet
* Remove ConstraintSet prefix from PARENT_ID
5 years ago
51e35d827d
[fenix] Reverts https://github.com/mozilla-mobile/fenix/pull/6925 : Make home screen full screen
5 years ago
35eeb98cac
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4107 Make home screen fullscreen.
...
Add/Remove fullscreen flags in home fragment's onResume / onPause
Change homeLayout padding to include system bars height (status&navigation).
Change homeMenu orientation to UP to properly display menu.
Change home bottomBar background to transparent.
5 years ago
d49503e58e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/7026 Dispatch ModeChange on hideOnboarding
5 years ago
4a29b6b06b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6917 Emit mode change only when new mode is different from current
5 years ago
a4be691ea0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6943 Hide supportActionBar in onResume, not onCreate ( https://github.com/mozilla-mobile/fenix/pull/6978 )
5 years ago
9ed4f7f119
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5574 - Migrate SessionControl to LibState ( https://github.com/mozilla-mobile/fenix/pull/6651 )
...
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 1: Port TabAction.SaveTabGroup to TabSessionInteractor and SessionControlController. (https://github.com/mozilla-mobile/fenix/pull/6651 )
- Introduces the TabSessionInteractor, SessionControlInteractor and SessionControlController classes.
- Removes the TabAction.SaveTabGroup.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 2: Port TabAction.PrivateBrowsingLearnMore to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 3: Port TabAction.ShareTabs to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 4: Remove unused TabAction.Share and TabItemMenu (https://github.com/mozilla-mobile/fenix/pull/6651 )
In https://github.com/mozilla-mobile/fenix/issues/2205 , the tab overflow button was removed which would have shown the
TabItemMenu when clicked. So, we can remove TabItemMenu since it is not
used and as a result, we can also remove TabAction.Share since there are
no consumers.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 5: Port TabAction.PlayMedia and TabAction.PauseMedia to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 6: Port TabAction.Select to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 7: Port Onboarding.Finish to OnboardingInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 8: Port TabAction.Close and TabAction.CloseAll to TabSessionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
- Removes TabAction
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 9: Port CollectionAction.Delete to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 10: Port CollectionAction.ShareTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 11: Port CollectionAction.AddTab and CollectionAction.Rename to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 12: Port CollectionAction.RemoveTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 13: Port CollectionAction.OpenTab to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 14: Port CollectionAction.CloseTabs to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 15: Introduce a HomeFragmentStore (https://github.com/mozilla-mobile/fenix/pull/6651 )
- We will hook up the HomeFragmentStore in later parts.
- Removes List<Tab>.toSessionBundle(context: Context) since it is unused.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 16: Port CollectionAction.Collapse and CollectionAction.Expand to CollectionInteractor and SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
- We assume the store is hooked up to the SessionControlController in this part,
but this work will be done in a later part.
- Removes CollectionAction.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 20: Remove the architecture module. (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 17: Remove duplicate subscribeToTabCollections in BrowserFragment.kt (https://github.com/mozilla-mobile/fenix/pull/6651 )
There is a duplicate call of subscribeToTabCollections() in both HomeFragment and BrowserFragment.
In this patch, we remove the call in BrowserFragment to avoid passing the HomeFragmentStore to
BrowserFragment in order to dispatch the CollectionsChange event.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 18: Delete SessionControlComponent and fix TabCollection and Tab imports (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 19: Use the new HomeFragmentStore in the HomeFragment (https://github.com/mozilla-mobile/fenix/pull/6651 )
- Renames SessionControlUIView to SessionControlView
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 21: Fix white screen on home fragment (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 22: Fix formatting in SessionControlInteractor and replace See with @see in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 23: Move to metrics.track call to the beginning of handleCollectionRemoveTab (https://github.com/mozilla-mobile/fenix/pull/6651 )
This ensures that the metrics.track will be called immediately before the tab is removed from the collection.
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 24: Use the sessionManager getter in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 25: Use mapNotNull in List<Tab>.toSessionBundle (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 26: Simplify closeTab and closeAllTabs functions by assigning a deletionJob constant (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 27: Replace listOf() with emptyList() in removeAllTabsWithUndo (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 28: Replace the Context parameter with the HomeActivity in SessionControlController (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Part 29: Add test for HomeFragmentStore, DefaultSessionControlController and SessionControlInteractor (https://github.com/mozilla-mobile/fenix/pull/6651 )
* For https://github.com/mozilla-mobile/fenix/issues/5574 - Removes running CI against the architecture debug build varient
5 years ago
11b8410367
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5972 - Fixes bugs when launching in private mode on Android 5 ( https://github.com/mozilla-mobile/fenix/pull/6702 )
5 years ago
8734472571
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6430 Private browsing hint width should not exceed screen dimensions ( https://github.com/mozilla-mobile/fenix/pull/6786 )
...
Renamed ambiguous pop-up window name.
Adjusted code to match max line length.
5 years ago
42d5ef61f9
[fenix] Add toolbar helpers ( https://github.com/mozilla-mobile/fenix/pull/6531 )
5 years ago
35bf8dfc58
[fenix] Use ShareData with ShareFragment ( https://github.com/mozilla-mobile/fenix/pull/6698 )
5 years ago
13e71e46e7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4824 - Fixes onboarding telemetry events from being sent a… ( https://github.com/mozilla-mobile/fenix/pull/6659 )
5 years ago
daaaeef741
[fenix] Adds custom search engines ( https://github.com/mozilla-mobile/fenix/pull/6551 )
...
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds button to add a new search engine
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds custom engine store
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Creates a custom SearchEngineProvider
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Gives the ability to delete search engines
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the UI to add a custom search engine
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds form to create a custom search engine
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the ability to add a custom search engine
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the ability to delete custom search engines
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Selects the first element on the add custom search engine screen
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Prevents adding a search engine that already exists
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Styles the add search engine preference
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Makes the name check case-insensitive
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fix bug where home screen doesnt see new search engines
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Moves Search URL validation to its own type
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fixes linting errors
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds the ability to edit a custom search engine
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Allows the user to edit a serach engine even when it is the last item in the list
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds an undo snackbar when deleting a search engine
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Moves all of the strings to be translated
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fixes bug when deleting your default search engine
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Puts adding search engines behind a feature flag
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Navigate to custom search engine SUMO article when tapping learn more
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Fixes nits
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Uses concept-fetch to validate search string
* For https://github.com/mozilla-mobile/fenix/issues/5577 - Adds string resources for the cannot reach error state
5 years ago
f23d222bb7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/6342 Clicking add tab button from home screen finishes onboarding
5 years ago
a79c7d3bb1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1487 Add "my library" menu category and items to home 3-dot menu
5 years ago
1c34781659
[fenix] https://github.com/mozilla-mobile/fenix/issues/4596 migrate collections ( https://github.com/mozilla-mobile/fenix/pull/5911 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4596 : move code from CollectionCreationComponent to CollectionCreationStore
Other than adding comments, no changes were made. The code will be updated in a following commit. This is in order to make the commit diff more readable.
* For 4596: update CollectionCreateStore to libstate
* For 4596: copied CollectionCreationUIView into CollectionCreationView
Otherwise, no code was changed. The next commit will update this code. This is in order to make the commit diff more readable.
* For 4596: update CollectionCreationView to LibState
Note that the minimal changes possible to enable migration were made. Refactoring will happen in a later commit.
* For 4596: updated CollectionCreationTabListAdapter to work with the new View
* For 4596: updated SaveCollectionListAdapter to work with the new View
* For 4596: implemented CollectionCreationController
For now, it has an identical interface to the interactor. In a later commit several of its responsibilities will be moved around, some to the interactor and some to the reducer
* For 4596: copied over previous reducer code
No other changes were made. The code will be updated in the following commit. This is done to make changes more readable for the reviewer
* For 4596: update reducer code param names
Otherwise, no changes at this time
* For 4596: add arguments to CreateCollectionFragment in nav_graph
These will be used to replace the current CreateCollectionViewModel, which shares data between fragments in a way that doesn't fit within our architecture.
* For 4596: pass arguments to collection via transaction instead of VM
The VM will be removed in a later commit
* For 4596: update BrowserToolbarController to share state to collection via its Direction
* For 4596: removed CreateCollectionViewModel
* For 4596: test tab retrieval in CreateCollectionFragment
* For 4596: fix crashing CreateCollectionFragmentTest
* For 4596: removed classes create collection classes used by old architecture
* For 4596: collection interactor rename + kdoc
* For 4596: moved collection interactor interface
* For 4596: renamed CreateCollectionFragment
All related classes followed the pattern of CollectionCreationX
* For 4596: kdoc CollectionCreationController
There's no effective difference between these calls and their interactor equivalent, so I linked to them
* For 4596: fix bug that caused rename to not work
* For 4596: removed unused collection actions
These were unused before the LibState refactor
* For 4596: kdoc StepChanged
* For 4596: removed todos about moving logic to the reducer
saveTabsToCollection: this could be moved, but that would involve creating a new action. SaveCollectionStep should probably be refactored out, so adding this layer of indirection seemed counterproductive
handleBackPress: needs to be able to call dismiss(). The reducer doesn't (and shouldn't) be able to do that, so this needs to live here
stepBack: called by handleBackPress. See above
* For 4596: wrote tests for CollectionCreationController#stepback
* For 4596: fixed tests broken by changes to collections
* For 4596: small readability refactor for CollectionController#stepBack
No change to functionality (see tests)
* For 4596: broke apart CollectionView#update
There's probably a lot more that could be done here, but smaller changes were made to reduce scope
* For 4596: remove unnecessary todos
It looks like we don't follow the suggested pattern in this project
* For 4596: test CollectionCreationController#normalSessionSize
* For 4596: updated naming in CollectionCreationController per review
5 years ago
8532908d51
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5323 : Show a snackbar while browsing data is deleting. ( https://github.com/mozilla-mobile/fenix/pull/6105 )
5 years ago
35eabc4579
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/5233 : Minor modifications suggested in code review.
5 years ago
aea1af9c82
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/5233 : Added call to doesPrivateBrowsingPinnedShortcutExist function to determine whether the "recommend private browing shortcut" dialog is displayed.
5 years ago
df858f2f3b
[fenix] Merge https://github.com/mozilla-mobile/fenix/pull/5507 https://github.com/mozilla-mobile/fenix/pull/5846
...
5507: For https://github.com/mozilla-mobile/fenix/issues/1383 Added tab title to close button content description r=ekager a=mcarare
### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [ ] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md ) or does not include any user facing features
### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones ) of the version currently in development.
### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture
5846: For https://github.com/mozilla-mobile/fenix/issues/3604 Snackbar messages for closing tabs use closed instead of deleted r=sblatz a=mcarare
### Pull Request checklist
<!-- Before submitting the PR, please address each item -->
- [x] **Quality**: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
- [x] **Tests**: This PR includes thorough tests or an explanation of why it does not
- [x] **Screenshots**: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
- [x] **Accessibility**: The code in this PR follows [accessibility best practices](https://github.com/mozilla-mobile/shared-docs/blob/master/android/accessibility_guide.md ) or does not include any user facing features
### After merge
- [ ] **Milestone**: Make sure issues finished by this pull request are added to the [milestone](https://github.com/mozilla-mobile/fenix/milestones ) of the version currently in development.
### To download an APK when reviewing a PR:
1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture
Co-authored-by: mcarare <mihai.carare.dev@gmail.com>
5 years ago
68a70eaa77
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3584 - Check if menu is open before showing a new one ( https://github.com/mozilla-mobile/fenix/pull/5674 )
...
Could have implemented this check (if menu is showing) inside the show() method
of BrowserMenu but this would mean the client (us) would go to the process of
building a new menu and then trying to have it displayed only for this to be
ignored by BrowserMenu in a somewhat opaque way.
Having this check done as soon as possible offers us full control and avoids
the unnecessary steps for building an already shown menu.
5 years ago
57169406de
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3604 Snackbar messages for closing tabs use closed instead of deleted
5 years ago
d5487d6510
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/5351 - listen to onIconChanged in HomeFragment
5 years ago
d008018d31
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5442 - Show Delete Browsing Data on Quit option in home menu
5 years ago
e3d58b1676
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5567 : Removes search shortcuts button ( https://github.com/mozilla-mobile/fenix/pull/5739 )
...
* For https://github.com/mozilla-mobile/fenix/issues/5567 : Removes search shortcut button
* No issue: Simplifies logic for displaying shortcuts
5 years ago
da4b731d0d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/561 : Fix stutter of search icon & text when animating
5 years ago
Christian Sadilek
Jonathan Almeida
Elise Richards
mcarare
MarcLeclair
Mihai Adrian Carare
Michael Comella
ekager
Roger Yang
rxu
Gabriel Luong
Hakkı Kaan Çalışkan
Sebastian Kaspari
Codrut Topliceanu
Tom Klein
Grisha Kruglov
Tiger Oakes
ekager
codrut.topliceanu
Jeff Boek
Kate Glazko
Sachin
Mihai Eduard Badea
Sawyer Blatz
ValentinTimisica
David Walsh
person808
Vishwa Patel
Tiger Oakes
Simon Chae
mcarare
Mihai Branescu
Severin Rudie
Sören Hentzschel
Severin Rudie
Josh
Stephen Tsimicalis
ValentinTimisica
bswe
MozLando
Mugurell
Prat T