[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/17443: IllegalStateException in startPostponedEnterTransition on HomeFragment
parent
1299b44402
commit
b0f7acdaff
@ -1,30 +0,0 @@
|
||||
/* This Source Code Form is subject to the terms of the Mozilla Public
|
||||
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
||||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
||||
|
||||
package org.mozilla.fenix.utils
|
||||
|
||||
import androidx.core.view.doOnPreDraw
|
||||
import androidx.fragment.app.Fragment
|
||||
import androidx.lifecycle.lifecycleScope
|
||||
import kotlinx.coroutines.launch
|
||||
|
||||
/**
|
||||
* Helper class that allows executing code immediately before [Fragment]s View being drawn.
|
||||
*/
|
||||
class FragmentPreDrawManager(
|
||||
private val fragment: Fragment
|
||||
) {
|
||||
init {
|
||||
fragment.postponeEnterTransition()
|
||||
}
|
||||
|
||||
fun execute(code: suspend () -> Unit) {
|
||||
fragment.view?.doOnPreDraw {
|
||||
fragment.viewLifecycleOwner.lifecycleScope.launch {
|
||||
code()
|
||||
fragment.startPostponedEnterTransition()
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
@ -1,33 +0,0 @@
|
||||
/* This Source Code Form is subject to the terms of the Mozilla Public
|
||||
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
||||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
||||
|
||||
package org.mozilla.fenix.utils
|
||||
|
||||
import androidx.core.view.OneShotPreDrawListener
|
||||
import androidx.fragment.app.Fragment
|
||||
import io.mockk.mockk
|
||||
import io.mockk.verify
|
||||
import kotlinx.coroutines.ExperimentalCoroutinesApi
|
||||
import kotlinx.coroutines.ObsoleteCoroutinesApi
|
||||
import kotlinx.coroutines.test.runBlockingTest
|
||||
import org.junit.Test
|
||||
|
||||
@ObsoleteCoroutinesApi
|
||||
@ExperimentalCoroutinesApi
|
||||
class FragmentPreDrawManagerTest {
|
||||
private fun doNothing() { /*noop*/ }
|
||||
|
||||
@Test
|
||||
fun `execute doOnPreDraw`() {
|
||||
runBlockingTest {
|
||||
val fragmentMock = mockk<Fragment>(relaxed = true)
|
||||
val fragmentPreDrawManager = FragmentPreDrawManager(fragmentMock)
|
||||
val listener = OneShotPreDrawListener.add(fragmentMock.view!!) { mockk() }
|
||||
|
||||
verify { fragmentMock.postponeEnterTransition() }
|
||||
fragmentPreDrawManager.execute { doNothing() }
|
||||
verify { fragmentMock.view?.viewTreeObserver?.addOnPreDrawListener(listener) }
|
||||
}
|
||||
}
|
||||
}
|
Loading…
Reference in New Issue