Archives/iceraven-browser
2
0
Fork 0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-03 23:15:31 +00:00
Code Issues Releases Wiki Activity
4,659 Commits 67 Branches 113 Tags 1.2 GiB
4fbb2e2fbb
Commit Graph

4004 Commits

Author SHA1 Message Date
Mugurell
efa1351277 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12772 - Opt-out of scoped storage 
Targeting Android 10 means we need to support scoped storage or we need to
opt-out of that using requestLegacyExternalStorage="true".

This patch adds the opting-out leaving investigations for what changes we need
for fully supporting scoped storage to be done in issue https://github.com/mozilla-mobile/fenix/issues/12822.
 2020-07-27 10:39:47 -07:00
ekager
d7514bcf78 [fenix] For https://github.com/mozilla-mobile/fenix/issues/6846: Added quick actions for nav bar in home 2020-07-27 13:28:28 -04:00
ekager
46a11849d2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12966 - Fixes session removal show home logic 2020-07-27 10:27:39 -07:00
Tiger Oakes
ad4476342b [fenix] Fix license on remaining files 2020-07-27 13:04:55 -04:00
Mihai Eduard Badea
3e5ceb23d5 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/12181 - Convert String to sentence case 
Changed the string values capitalization to sentence case.
 2020-07-27 12:31:13 -04:00
Kadeem M
a8f29e65c0 [fenix] Created UI tests for Addon Settings (https://github.com/mozilla-mobile/fenix/pull/9258) 2020-07-27 11:00:35 -04:00
ekager
76a7b37440 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/12954 - Remove all ConstraintLayout casts in SearchEngineListPreference 2020-07-27 09:49:43 -04:00
Oana Horvath
1748d2d012 [fenix] For: https://github.com/mozilla-mobile/fenix/issues/12894, https://github.com/mozilla-mobile/fenix/issues/12899, https://github.com/mozilla-mobile/fenix/issues/12968, https://github.com/mozilla-mobile/fenix/issues/11239, disables failing UI tests 2020-07-27 13:34:56 +03:00
Mihai Branescu
0507017605 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7716 - modified xml to let 'Learn more' button have min 48dp for a11y 
Added a margin top of 20dp as well on the buttons so as not to change UI
 2020-07-27 10:16:31 +03:00
ekager
1dbc00f08d [fenix] For https://github.com/mozilla-mobile/fenix/issues/12947 - Adjust tab selected state on bind 2020-07-25 20:07:30 -04:00
Tiger Oakes
a0f58194e2 [fenix] Add concept-menu dependency 2020-07-25 19:38:35 -04:00
ekager
180590e776 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12721 - Remove SessionManager usages in TabCounter 2020-07-25 18:37:45 -04:00
Hakkı Kaan Çalışkan
2dff66eee9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12929: Change cast to LinearLayout 2020-07-25 10:14:48 -04:00
Hakkı Kaan Çalışkan
9845637378 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12804: Set min height for search engine radio button 2020-07-24 22:10:24 -04:00
ekager
1ced27bda6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10163 - Adds tab multiselect mode 2020-07-24 18:18:26 -04:00
Jonathan Almeida
312addd8be [fenix] For https://github.com/mozilla-mobile/fenix/issues/10925: Fix breaking APIs in tabs tray 2020-07-24 16:52:06 -04:00
Tiger Oakes
2c08b342e8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12871 - Use local TWA DAL API (https://github.com/mozilla-mobile/fenix/pull/12872) 2020-07-24 13:08:24 -07:00
Kainalu Hagiwara
ee201255cc [fenix] For https://github.com/mozilla-mobile/fenix/issues/12880 - Pass a CoordinatorLayout to Snackbars created by the context menu. 2020-07-24 12:30:46 -07:00
Sawyer Blatz
fdf22f7e74 [fenix] No issue: fix master 2020-07-24 15:06:38 -04:00
ekager
a939f4ee8f [fenix] For https://github.com/mozilla-mobile/fenix/issues/12364 - Improve PWA onboarding timing logic 2020-07-24 14:43:28 -04:00
Sawyer Blatz
adc1813fd6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12793: Improve snackbars for tabs tray 2020-07-24 10:56:54 -07:00
Sawyer Blatz
6317a79222 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12791: Fix issue with undo snackbar last tab 2020-07-24 10:56:54 -07:00
Sawyer Blatz
b4a0e122d1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10997: Remove scrolling from home (https://github.com/mozilla-mobile/fenix/pull/12866) 2020-07-24 10:43:53 -07:00
Michael Comella
aff5a4f5c4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12345: replace Activity.reportFullyDrawnSafe with a-c impl. 2020-07-24 10:30:03 -07:00
Oana Horvath
d6ead0a749 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12893: Disables failing deleteAllHistoryTest (https://github.com/mozilla-mobile/fenix/pull/12902) 2020-07-24 11:47:59 -04:00
Oana Horvath
c286ebe55e [fenix] For https://github.com/mozilla-mobile/fenix/issues/12473: Disable failing verifyContextCopyLink (https://github.com/mozilla-mobile/fenix/pull/12891) 2020-07-24 10:29:22 -04:00
mcarare
ae809790c7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10026: Update scroll flags on a11y state change. 2020-07-24 10:35:33 +03:00
mcarare
38cb941da9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10026: Add a11y state listener to BaseBrowserFragment. 2020-07-24 10:35:33 +03:00
mcarare
dad550613d [fenix] For https://github.com/mozilla-mobile/fenix/issues/10026: Add Context extension to get AccessibilityManager. 2020-07-24 10:35:33 +03:00
Kainalu Hagiwara
559f83302e [fenix] For https://github.com/mozilla-mobile/fenix/issues/12868 - Fix tab counter menu snackbar position. 2020-07-23 18:30:04 -07:00
Sawyer Blatz
d63bd0b2e3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12430: Hide the mic when not using Google 2020-07-23 19:29:26 -04:00
Tiger Oakes
4037103a95 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565: Don't pass contest to SortingStrategy 2020-07-23 19:05:11 -04:00
Aaron Train
f0f972a053 [fenix] No issue: Fix recent UI test breakage (https://github.com/mozilla-mobile/fenix/pull/12869) 2020-07-23 14:17:54 -07:00
Tiger Oakes
0d37525151 [fenix] Migrate from Session.toTab to BrowserStore (https://github.com/mozilla-mobile/fenix/pull/12221) 2020-07-23 12:27:39 -07:00
Tiger Oakes
0d5d9631c1 [fenix] Add tests for some classes in home/browser (https://github.com/mozilla-mobile/fenix/pull/12837) 2020-07-23 11:17:52 -07:00
Tiger Oakes
d2d30f0e5e [fenix] Test sync adapter (https://github.com/mozilla-mobile/fenix/pull/12810) 2020-07-23 11:16:11 -07:00
Arturo Mejia
9f8851294b [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/11676: Features phone that doesn't a site permission exception shouldn't be shown (https://github.com/mozilla-mobile/fenix/pull/12855) 
exception shouldn't be shown
 2020-07-23 09:12:22 -07:00
Mozilla L10n Automation Bot
69d6c450c5 [fenix] Import l10n. 2020-07-23 10:40:10 +03:00
Tiger Oakes
bf4a7cd969 [fenix] Create ToolbarPosition enum (https://github.com/mozilla-mobile/fenix/pull/12747) 2020-07-22 19:23:38 -07:00
Jonathan Almeida
bb3e5bfbf9 [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/11333: Set ContentBlocking settings directly on GeckoRuntime 
We set the ContentBlockingSettings directly on the GeckoRuntime now to
improve the startup of the engine.

This change has requirements from Android Components and GeckoView, so
we would only see the full perf benefits in Nightly as the changes ride
the train, although we might start to see some of them as we're updating
the GeckoProvider for the `geckoBeta` variant as well.

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
 2020-07-22 16:28:18 -04:00
Kainalu Hagiwara
9153350cd2 [fenix] No issue - Fix compilation error caused by removed extension function. 2020-07-22 13:00:07 -07:00
Kainalu Hagiwara
d4d68f2b77 [fenix] Fix UI tests. 
We need to pass a CoordinatorLayout instead of a SwipeGestureLayout to
FenixSnackbar.make() in BaseBrowserFragment to prevent UI tests from
breaking. We also need to remove a few view IDs from the tab preview.
 2020-07-22 11:26:15 -07:00
Kainalu Hagiwara
a6a8c4dc08 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3481 - Implement swipe on toolbar to switch tabs. 2020-07-22 11:26:15 -07:00
Mozilla L10n Automation Bot
d85e95f6b8 [fenix] Import l10n. 2020-07-22 11:25:16 -07:00
Kainalu Hagiwara
9d3f8a7e0f [fenix] For https://github.com/mozilla-mobile/fenix/issues/1048 - Add ability to view tab history by long-pressing the back or forward button. 2020-07-22 11:20:47 -07:00
Hakkı Kaan Çalışkan
082cddf7d8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12571: Rename 'Shortcuts' to 'Search engines' 
Co-Authored-By: Khushraj Rathod <khushrajrathod@gmail.com>
 2020-07-22 11:05:04 -07:00
Tiger Oakes
75817b004c [fenix] Use AC RunWhenReadyQueue (https://github.com/mozilla-mobile/fenix/pull/12800) 2020-07-22 09:48:36 -07:00
Tiger Oakes
fb7c801b38 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12801 - Extra debug menu trigger, disable if already triggered 2020-07-22 19:28:48 +03:00
Jonathan Almeida
1df7dce5d0 [fenix] Update to Android Components 52.0.20200722023149 
Fixes breaking APIs in SyncedTabsFeature and
BookmarksStorageSuggestionProvider
 2020-07-22 10:52:14 -04:00
Michael Comella
67d1e5f935 [fenix] No issue: add missing newline. 2020-07-21 15:52:34 -07:00
Michael Comella
e84b6e82e8 [fenix] No issue: clean up initVisualCompletenessQueue... method. 
A no-op clean up.
 2020-07-21 15:52:34 -07:00
Michael Comella
032ca003cd [fenix] No issue: extract initVisualCompletenessQueueAndQueueTasks. 
This refactor, done entirely by IDE, is a no-op cleanup.
 2020-07-21 15:52:34 -07:00
Michael Comella
1f65ba446e [fenix] No issue: extract startMetricsIfEnabled function. 
This refactor, done entirely by IDE, is a no-op clean-up of this file.
 2020-07-21 15:52:34 -07:00
Jeff Boek
b2d6f5746b [fenix] For https://github.com/mozilla-mobile/fenix/issues/12806 - Adds unit tests to cover ToolbarView.update() (https://github.com/mozilla-mobile/fenix/pull/12807) 2020-07-21 14:34:07 -07:00
Jonathan Almeida
758f0b0b96 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12797: Use measured height/width for loading a thumbnail 
Using `onNextLayout` has the side-effect of showing the thumbnail with
the tab.id from a recycled view.

The root cause of needing that call is to retrieve the measured
height/width from the view first before requesting. A simpler solution
to avoid the complexity is to retrieve these values from the dimen
resources.

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
 2020-07-21 16:38:49 -04:00
Sawyer Blatz
a48f1f8591 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12461: Update content description for tabs tray open tab count 2020-07-21 15:48:38 -04:00
Sebastian Kaspari
8de62c28cf [fenix] Issue https://github.com/mozilla-mobile/fenix/issues/7877: Add SearchActionProvider for faster responses that mirror entered text. 2020-07-21 14:41:00 -04:00
Tiger Oakes
adbadba250 [fenix] Move settings in components (https://github.com/mozilla-mobile/fenix/pull/12675) 2020-07-21 10:47:10 -07:00
Mihai Eduard Badea
130de798fb [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/12387 - Display tab tray using .show 
Replaced the global navigation action used for displaying the tab tray with the .show() function.
 2020-07-21 10:31:24 -07:00
mcarare
2320c617b2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/9722: Refactor onboarding buttons with text. 
Add title and description to button text, remove extra Textviews.
 2020-07-21 10:28:45 -07:00
Tiger Oakes
ef885fe482 [fenix] Add tests for web push integration 2020-07-21 10:12:06 -07:00
mcarare
5ddf809ee8 [fenix] For android-l10n https://github.com/mozilla-mobile/fenix/pull/241: Mark a11y link type as not translatable. 2020-07-21 17:59:17 +03:00
Johan Lorenzo
13e8560acf [fenix] Bug 1652979 - Stop producing fennecNightly, fenixNightly and fenixBeta (https://github.com/mozilla-mobile/fenix/pull/12225) 2020-07-21 16:42:08 +02:00
TejaswiKarasani
00cd8b8f35 [fenix] No issue: verify ETP toolbar shield icon is not displayed if ETP is OFF globally in ETP UI tests (https://github.com/mozilla-mobile/fenix/pull/12623) 2020-07-21 09:33:06 -04:00
Oana Horvath
82a76042d9 [fenix] Fix UI tests from https://github.com/mozilla-mobile/fenix/issues/12752 https://github.com/mozilla-mobile/fenix/issues/12637 https://github.com/mozilla-mobile/fenix/issues/12764 (https://github.com/mozilla-mobile/fenix/pull/12779) 
* For https://github.com/mozilla-mobile/fenix/issues/12752 & https://github.com/mozilla-mobile/fenix/issues/12764: Fixes tabs tray behavior in UI tests

* For https://github.com/mozilla-mobile/fenix/issues/12637: fixes goBackTest
 2020-07-21 08:49:24 -04:00
Tiger Oakes
3bccc0dd50 [fenix] Pass settings and metrics to CFR 2020-07-21 09:01:09 +03:00
mozilla-l10n-automation-bot
72e6448a1d [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/12766) 2020-07-20 18:26:00 -07:00
Richard Pappalardo
41bb2cb087 [fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/12752, https://github.com/mozilla-mobile/fenix/issues/12764 - Temp disable openHistoryInNewTabTest intermittent UI test failures (https://github.com/mozilla-mobile/fenix/pull/12754) 
* Fixes https://github.com/mozilla-mobile/fenix/issues/12752 - Temp disable intermittent failing test
 2020-07-20 18:09:01 -07:00
Kainalu Hagiwara
5a895d6125 [fenix] No issue - Suppress new warnings from detekt update 2020-07-20 17:01:50 -07:00
Sawyer Blatz
de6145c967 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12461: Add tab count to tab tray 2020-07-20 19:16:47 -04:00
Tiger Oakes
712dce391d [fenix] For https://github.com/mozilla-mobile/fenix/issues/5499 - Unify CFR drawables and dimens (https://github.com/mozilla-mobile/fenix/pull/12749) 2020-07-20 16:00:57 -07:00
Hakkı Kaan Çalışkan
898defc3a2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12532: Quick fix for radio button alignment (https://github.com/mozilla-mobile/fenix/pull/12691) 2020-07-20 15:33:32 -07:00
Kainalu Hagiwara
3320f82bfb [fenix] For https://github.com/mozilla-mobile/fenix/issues/12551 - Implement swipe to delete for bookmarks. 2020-07-20 14:54:20 -07:00
Kainalu Hagiwara
0671fc50e8 [fenix] Rename tab_tray_background.xml 2020-07-20 14:54:20 -07:00
Michael Comella
e85dd6a09c [fenix] No issue: correct position of StartupTimeline; add warning. 2020-07-20 14:27:41 -07:00
Sawyer Blatz
80b4fb0808 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10466: Add search privately to top of list (https://github.com/mozilla-mobile/fenix/pull/12744) 2020-07-20 13:25:36 -07:00
Tiger Oakes
5b7d951590 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/10924 - Cleanup SavedLoginsAuthFragment (https://github.com/mozilla-mobile/fenix/pull/10930) 2020-07-20 13:25:24 -07:00
Kainalu Hagiwara
055620f117 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12730 - Fix ripple for font size setting. 2020-07-20 13:00:59 -07:00
Sawyer Blatz
d8ecc2e19c [fenix] For https://github.com/mozilla-mobile/fenix/issues/11851: Close tab tray when last tab closed (https://github.com/mozilla-mobile/fenix/pull/12615) 2020-07-20 11:05:32 -07:00
ekager
b8b3d8b367 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10784 - Fixes memory leak in BrowserAnimator 2020-07-20 13:50:18 -04:00
Sawyer Blatz
54a6de9b84 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12735: Fixes issue with tab deletion undo (https://github.com/mozilla-mobile/fenix/pull/12737) 2020-07-20 10:48:16 -07:00
Hakkı Kaan Çalışkan
197a076ef2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12554: Helper class for password reveal on logins 2020-07-20 13:45:46 -04:00
mozilla-l10n-automation-bot
24f19cd763 [fenix] Import l10n. (https://github.com/mozilla-mobile/fenix/pull/12687) 2020-07-19 21:30:11 -07:00
Christian Sadilek
250c95eb28 [fenix] Update Android Components to 51.0.20200717190031 2020-07-17 19:32:02 -04:00
Tiger Oakes
e740819acd [fenix] Fix lint issues (https://github.com/mozilla-mobile/fenix/pull/12683) 2020-07-17 16:20:08 -07:00
Tiger Oakes
cb59729010 [fenix] Change enabled lint rules (https://github.com/mozilla-mobile/fenix/pull/12517) 2020-07-17 15:17:16 -07:00
Tiger Oakes
25a5f478ef [fenix] Test migration classes (https://github.com/mozilla-mobile/fenix/pull/12677) 2020-07-17 14:35:13 -07:00
Tiger Oakes
a7bbc86f4a [fenix] Add tests for login exceptions (https://github.com/mozilla-mobile/fenix/pull/12681) 2020-07-17 14:25:45 -07:00
Tiger Oakes
5c9876dcff [fenix] Fix failure in handleWhatsNewGetAnswersClicked (https://github.com/mozilla-mobile/fenix/pull/12682) 2020-07-17 14:25:35 -07:00
Mihai Adrian Carare
3823c632ac [fenix] For https://github.com/mozilla-mobile/fenix/issues/7966: Update toolbar content description. (https://github.com/mozilla-mobile/fenix/pull/12667) 2020-07-17 16:22:13 -05:00
Elise Richards
508854ea07 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12532: Align Settings -> Site permissions -> Sub-pages to 72dp keyline (https://github.com/mozilla-mobile/fenix/pull/12680) 
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
 2020-07-17 15:54:57 -05:00
Mihai-Eduard Badea
65c98d6c16 [fenix] For issue https://github.com/mozilla-mobile/fenix/issues/9949 - Bookmarks/History deletion inconsistencies (https://github.com/mozilla-mobile/fenix/pull/12630) 
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.

 - Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in https://github.com/mozilla-mobile/fenix/issues/8648.

Co-authored-by: Mihai Eduard Badea <mihai.badea@softvision.ro>
 2020-07-17 15:13:18 -05:00
Tiger Oakes
549acfa6f1 [fenix] Test session control controller (https://github.com/mozilla-mobile/fenix/pull/12652) 2020-07-17 13:07:01 -07:00
Hakkı Kaan Çalışkan
415bbf6574 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12509: Set height of remove add on button to 36dp 2020-07-17 12:55:36 -07:00
ekager
f7f80ad6cb [fenix] Update ContextMenuUseCases to just take a store 2020-07-17 14:49:10 -04:00
ekager
2deadc2e22 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12453 - Sets secure flags on private tab of tabs tray 2020-07-17 13:24:25 -04:00
ekager
bc08df1c8f [fenix] For https://github.com/mozilla-mobile/fenix/issues/12364 - Only show PWA prompt the third time a user visits installable site 2020-07-17 12:37:03 -04:00
Tiger Oakes
ded7cde177 [fenix] Add tests for adapters in collections (https://github.com/mozilla-mobile/fenix/pull/12649) 2020-07-17 09:04:16 -07:00
Kainalu Hagiwara
46a9bba6e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12531: Align Settings -> Private browsing to 72dp keyline (https://github.com/mozilla-mobile/fenix/pull/12654) 
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
 2020-07-16 22:26:49 -07:00
Elise Richards
5b46f572df [fenix] For https://github.com/mozilla-mobile/fenix/issues/10173: login duplicates and save (https://github.com/mozilla-mobile/fenix/pull/11208) 
* Extract controller into it's own class. Implement find dupes and filter based on username.

Create edit login controller. Add text watchers and check for duplicates.

Edit controller test

* Find duplicates and save to store

* Retrieve duplicates from AC and check list on username text changed

Move duplicates logic into the controller

* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.

* Use correct threads in controller. Enable save button when applicable.

Save enabled in datastore.

Move login data to datastore

Rebase with password error states

Update metrics to be more specific for edit

* Create logins controller for AC calls

* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.

Inflate view in edit fragment. Double layout showing up.

Edit view

Controller tests

Controller tests passing

Interactor tests

Lint and detekt cleanup

* Remove datastore and use storage controller for all logins calls to password storage.

Addressed comments

Lint
:

Rebase - 1
 2020-07-16 17:08:04 -05:00
Tiger Oakes
046682f889 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12457: Add MockK matcher for intents (https://github.com/mozilla-mobile/fenix/pull/12612) 2020-07-16 15:05:01 -07:00
Mugurell
ac85ba0945 [fenix] Ensure logins deletion (https://github.com/mozilla-mobile/fenix/pull/12507) 
* For https://github.com/mozilla-mobile/fenix/issues/11227 - Cleanup saved logins list when one is selected

Selecting a saved login will open a detail screen for it from where users can
change details or even delete that particular login.
After the change is made the user is brought back to the list of saved logins
where for a brief moment (< 1s) until we get a new response from
passwordsStorage.list() the user can see and even interact with the old list
of items, which may still contain the just deleted one.

To avoid users seeing obsolete logins or even interacting with them (selecting
a previosuly deleted item will result in a crash) we will clean the list of
logins just before the selected login is opened in the detailed view.
When returning for a brief moment the users may see the "loading" UX until
passwordsStorage.list() returns the up-to-date list of logins to display.

* For https://github.com/mozilla-mobile/fenix/issues/11227 - Refactor SavedLoginsView to be closer to MVI

- Interactors should only get passed other Interactors or Controllers as
dependencies to which they should delegate user actions.
- Controllers should hold most of the business logic and get passed all final
dependencies they need to do their job.
 2020-07-16 14:40:08 -05:00
Tiger Oakes
2a7e8f7adb [fenix] Add tests for sync, wifi, and push (https://github.com/mozilla-mobile/fenix/pull/12581) 2020-07-16 12:25:38 -07:00
Tiger Oakes
fe5b219a89 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12565: Add Locale settings tests & use activity (https://github.com/mozilla-mobile/fenix/pull/12579) 2020-07-16 11:43:27 -07:00
jhugman
773884bdc4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12600 - remove AddonInstalled event when the permission dialog is shown (https://github.com/mozilla-mobile/fenix/pull/12601) r=csadilek,sblatz 2020-07-16 19:40:39 +01:00
Mihai Branescu
582fc2cff7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12201 - forced callbacks to be on the main thread (https://github.com/mozilla-mobile/fenix/pull/12543) 2020-07-16 13:39:31 -05:00
Elise Richards
fc847d79e7 [fenix] No issue: Delete unnecessary to-dos (https://github.com/mozilla-mobile/fenix/pull/12603) 
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
 2020-07-16 13:38:07 -05:00
Hakkı Kaan Çalışkan
ad239ff1ae [fenix] No issue: Move dp's to dimens.xml 2020-07-16 13:08:55 -04:00
Kainalu Hagiwara
ce7ba9a2ac [fenix] Update TabTrayViewHolder with A-C thumbnail changes. 2020-07-16 12:50:33 -04:00
Roger Yang
be3ce6e2ba [fenix] For https://github.com/mozilla-mobile/fenix/issues/12118: Add isSubframeRequest parameter for app links 2020-07-16 12:50:33 -04:00
Christian Sadilek
4c49410910 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12248: Webcompat reporter not active in Nightly 2020-07-16 12:24:21 -04:00
jhugman
6a7a29fc61 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11704 Add leanplum attributes for tracking protection (https://github.com/mozilla-mobile/fenix/pull/11965) r=sblatz 
* For 11657: add LP attribute for tracking protection

* For https://github.com/mozilla-mobile/fenix/issues/11704: added tracking_protection_enabled attribute

* Added docs for the new attributes, linking to data-review to the mma.md

* Rename null to none when no ETP is enabled
 2020-07-16 17:09:32 +01:00
Hakkı Kaan Çalışkan
ab317dc779 [fenix] No issue: Uncomment forgotten assert 2020-07-16 11:45:53 -04:00
Tiger Oakes
82d1b4380d [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/12493: Remove kapt plugin 2020-07-16 10:38:03 -04:00
Hakkı Kaan Çalışkan
8645075a39 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12105: Follow ux mock on Settings --> Accessibility screen 2020-07-16 10:37:20 -04:00
James Hugman
61fe76774f [fenix] Address review comments 2020-07-16 10:37:03 -04:00
James Hugman
800e55e69a [fenix] Remove need to specify component names for new intents 2020-07-16 10:37:03 -04:00
James Hugman
648b389a68 [fenix] Changed home_* style links to urls_* to reflect that the destination is a set of links, rather than where the screen is 2020-07-16 10:37:03 -04:00
James Hugman
8e7c9bf003 [fenix] Add install_search_widget 2020-07-16 10:37:03 -04:00
James Hugman
83ed39ed5c [fenix] Add UI tests for deep links 2020-07-16 10:37:03 -04:00
James Hugman
dc588ca0ae [fenix] Add unit tests for deep links 2020-07-16 10:37:03 -04:00
James Hugman
bc397268a6 [fenix] Add deep links for settings and home screens 2020-07-16 10:37:03 -04:00
isabelrios
18b3fb95b4 [fenix] cron-job-ui-screenshots (https://github.com/mozilla-mobile/fenix/pull/12423) 
Co-authored-by: isabel rios <isabelrios@MacBook-Pro-de-isabel-2.local>
 2020-07-16 16:08:00 +02:00
Mugurell
85e05cb841 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12544 - Prevent search engines mixup 
Stricter synchronization by always using the same "loadedSearchEngines"
variable.
With "loadedSearchEngines" calling "refreshAsync()" we also get the fallback
engines to contain reddit and youtube (which are programatically added) and
also now we properly remember and display the engines added by user.
 2020-07-16 16:49:54 +03:00
Oana Horvath
70e30dcf98 [fenix] Replaces verifyPageContent in UI tests 2020-07-16 10:55:58 +03:00
Tiger Oakes
65402a62dd [fenix] Add tests for StartupReportFullyDrawn (https://github.com/mozilla-mobile/fenix/pull/12560) 2020-07-15 23:31:59 -07:00
Tiger Oakes
c1a74cc939 [fenix] Add helper for underlining text (https://github.com/mozilla-mobile/fenix/pull/12520) 2020-07-15 22:38:46 -07:00
Tiger Oakes
2e8da8abe0 [fenix] Fix nav graph and theme tests (https://github.com/mozilla-mobile/fenix/pull/12567) 2020-07-15 18:04:36 -07:00
Tiger Oakes
034a9dae8f [fenix] Update Kotlin dependency (https://github.com/mozilla-mobile/fenix/pull/10806) 2020-07-15 18:02:58 -07:00
mcarare
1efe17c801 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12503: Add unit tests for permissions details view. 2020-07-15 10:04:40 -04:00
mcarare
bfd879be4a [fenix] For https://github.com/mozilla-mobile/fenix/issues/12503: Open addon permissions link in app. 2020-07-15 10:04:40 -04:00
Aaron Train
d60d77248b [fenix] No issue: Add a couple Tabs Tray UI tests 2020-07-15 10:49:34 +03:00
ekager
772f69c5f5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/7094 - Adds save login exceptions 2020-07-14 14:47:37 -04:00
Tiger Oakes
09c37671a8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12457 - Add MockK matcher for nav directions (https://github.com/mozilla-mobile/fenix/pull/12262) 2020-07-14 10:39:23 -07:00
Tiger Oakes
431459d181 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12171: Use one-line logo in Nightly (https://github.com/mozilla-mobile/fenix/pull/12555) 2020-07-14 10:37:01 -07:00
Tiger Oakes
d9e7a351fa [fenix] Add tests for search (https://github.com/mozilla-mobile/fenix/pull/12437) 2020-07-14 10:32:04 -07:00
Tiger Oakes
afd8eafd9f [fenix] Test viewholders in home.sessioncontrol (https://github.com/mozilla-mobile/fenix/pull/12524) 2020-07-14 10:31:50 -07:00
Hakkı Kaan Çalışkan
e83a7f3370 [fenix] For https://github.com/mozilla-mobile/fenix/issues/12107: Follow ux mock on Settings --> Account screen 2020-07-14 12:25:21 +03:00
Mozilla L10n Automation Bot
2d97e98f58 [fenix] Import l10n. 2020-07-14 11:40:19 +03:00
ekager
9c0e356950 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11099 For https://github.com/mozilla-mobile/fenix/issues/12189 For https://github.com/mozilla-mobile/fenix/issues/7532 - Clean up bottom navigation bar colors 2020-07-13 13:46:35 -04:00
Sawyer Blatz
ca02217039 [fenix] For https://github.com/mozilla-mobile/fenix/issues/10466: Put call & email at top of context list 2020-07-13 10:33:55 -07:00
Hakkı Kaan Çalışkan
c332cc631e [fenix] For https://github.com/mozilla-mobile/fenix/issues/12106: Follow ux mock on Settings --> Logins screen 2020-07-13 11:14:32 -04:00
Oana Horvath
0885d0047e [fenix] For https://github.com/mozilla-mobile/fenix/issues/10911: disables flaky createBookmarkFolderTest 2020-07-13 15:40:50 +03:00
Mugurell
66fdc14386 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11875 - Prevent mixup of region / locale based search engines 
We have two search engine types:
- one based on MLS reported region,
- one based only on Locale.

There are multiple steps involved in returning the default search engine for
example and though at each step we could verify if a certain operation is
completed we are still exposed to concurrency issues.
Simplest and most effective way to make sure the MLS engines do not mix with
Locale based engines is to use the same type of engines for the entire duration
of the app. At the next cold start we'll verify again which engines to use.

Using the Locale based engines (fallbacks) is expected to only happen once, at
the first run of the application after being installed.
 2020-07-13 13:41:34 +03:00
Mozilla L10n Automation Bot
73fbb27808 [fenix] Import l10n. 2020-07-13 07:59:10 +03:00
jhugman
de6a9cf93b [fenix] For https://github.com/mozilla-mobile/fenix/issues/11655: add leanplum event for installing an addon (https://github.com/mozilla-mobile/fenix/pull/12136) r=elise 
* For https://github.com/mozilla-mobile/fenix/issues/11655: add leanplum event for installing an addon

* Add link to data-review request in PR

* Addressed CI comments
 2020-07-12 23:47:34 +01:00
Grisha Kruglov
1278ca374c [fenix] Synced Tabs: make sure to stop 'loading' when we encounter an error 2020-07-10 19:02:55 -07:00
Tiger Oakes
291c3196ee [fenix] Fix Robolectric tests SDK version (https://github.com/mozilla-mobile/fenix/pull/12464) 2020-07-10 17:21:10 -07:00
ekager
fade6c7936 [fenix] For https://github.com/mozilla-mobile/fenix/issues/11324 - Adds trash icon to swipe to delete 2020-07-10 20:16:57 -04:00
Michael Comella
03b8068cd2 [fenix] No issue - post: mock profiler object in DefaultTabTrayControllerTest. 
Without this line, the tests fail when running the full suite (but not
this test in isolation, for some reason).
 2020-07-10 16:43:06 -07:00