We were crashing because we were specifying the wrong `CreditCardNumber` type when constructing the `UpdatableCreditCardFields`.
We only had the plaintext card number from the user input, but was placing it off as an encrypted card number, which resulted in the crash.
This is not visible in production, but only debug. It shows three variables
being used to change the settings screen (title, icon and title-punctuation).
In our current MVI implementation the View Interactors are first called in
response to a direct user action and contain methods following the
"onXXHappened" naming scheme and then delegate other Interactors / Controllers
for specific actions.
Controllers contain the business logic for actually updating the app's state
and offer methods following the "handleXXAction" naming scheme.
As a regression from #19590 which added a new setting above the existing
"Set as default browser" setting the settingsTest() needed to be updated to
allow clicking and screenshot of what happens after clicking on the
"Set as default browser" setting which can now be pushed offscreen.
* Add preferences for enable/disable sync for cc and addresses
* Set pref visibility based on feature flags
* Helper function for pin warning preferences and set default values for cc and addresses to false.
* Kdocs for relevant sync functions in account settings
* Default visibility to false for credit cards and addresses in account settings
We now have a BrowserTrayList.
- Renamed from `BaseBrowserTrayList`.
- Removed the abstract `configuration` and used a `lateinit var`
instead.
- Removed `NormalBrowserTrayList` and `PrivateBrowserTrayList`.
Previously renaming a TopSite would bind that as a new item and in such update
the entire list. This could potentially leading changes in the list and then
it's ViewPager parent's layout.
This patch switches the code to use the existing TopSitePayload and so do a
partial update of an on-screen TopSite instead of rebind it as a new item.
If a layout is requested while showing <=4 TopSites on the second page, by
having "offscreenPageLimit = 1" the biggest height of ViewPager pages is used
preventing an edgecase where the ViewPager would hide half of the items from
the first page.
Index calculation for notifying changes while renaming a top site in the second
page was being wrongly calculated. Since it is page 2, we would need to take a
mod with the number of top sites per page to get the actual index of the top
site that was being renamed.
* Replaced #20123A with @color/photonInk80 in values\colors.xml
* Replaced #F9F9FB with @color/photonLightGrey10 in values\colors.xml
* Replaced #E0E0E6 with @color/photonLightGrey30 in values\colors.xml
* Replaced #592ACB with @color/photonViolet70 in values\colors.xml
* Replaced #312A65 with @color/photonInk20 in values\colors.xml
* Replaced #FBFBFE with @color/photonLightGrey05 in values\colors.xml
* Replaced #52525E with @color/photonDarkGrey10 in values\colors.xml
* Replaced #ffffff with @color/photonWhite in values\colors.xml
* Replaced #5B5B66 with @color/photonDarkGrey05 in values\colors.xml
* Replaced #1C1B22 with @color/photonDarkGrey80 in values\colors.xml
* Replaced #737373 with @color/photonGrey50 in values\colors.xml
* Replaced #9059FF with @color/photonViolet50 in values\colors.xml
* Replaced #5B5B66 with @color/photonDarkGrey05 in values-night\colors.xml
* Replaced #3A3944 with @color/photonDarkGrey40 in values-night\colors.xml
The main cause for this is that the `LifecycleProvider` needs to be set
to `State.RESUMED` to avoid the account manager's internal
`ObserverRegistry` from putting the UI observers into the paused state.
The rest of the changes is to rely the internal (safe) logic to
correctly sync and then update the tabs list.
Now that the Glean Dictionary (https://dictionary.telemetry.mozilla.org)
has hit production, our guidance is to move away from generating
metrics.md files. The Glean Dictionary is a better solution for this task
for a couple of reasons:
1. The Glean Dictionary contains a complete reference of all metrics
and pings sent by an application (not just those defined in the
application itself, as is the case with the markdown documentation)
2. The Glean Dictionary provides additional context and links beyond
what is provided by the documentation (for example, information on
how to access metric information via BigQuery or GLAM) as well as
annotations provided by data scientists in the course of analyzing data
(see, for example, the commentary section for:
https://dictionary.telemetry.mozilla.org/apps/fenix/metrics/metrics_search_count).
This should also reduce some of the churn/burden on people when
they submit PRs, as there is no longer any need to update metrics.md
as a part of them.
* Added color for "Share" menu's "Recently Used" in Dark theme
- Changed HEX code for inset_dark_theme in values/colors.xml
* Replaced #52525E in values/colors.xml with @color/photonDarkGrey10
* Added color for "Share" menu's "Recently Used" in Dark theme
- Created a separate attribute recentlyUsedSharedMenu to be used by 'recently used' panel of tab share menu
- It specifies colors to be used for Light and Dark theme
Mihai Adrian Carare
Oana Horvath
Mozilla L10n Automation Bot
Gabriel Luong
Jonathan Almeida
Grisha Kruglov
Elise Richards
Christian Sadilek
James Hugman
Mugurell
Ionut Cristian Bedregeanu
Bedregeanu Ionut
Codrut Topliceanu
isabelrios
Sebastian Kaspari
mcarare
AndiAJ
Tim D. Smith
Arturo Mejia
Priyanka
Roger Yang
kanish671
Neha Binwal
William Lachance