There is a "unused" lint suppression in place with the comment
"Referenced from XML". I found no such usage.
It's documentation says that this Behavior will always position FindInPageBar
above BrowserToolbar but the current code ensures
BrowserToolbar.visibility == GONE when FindInPageBar.visibility == VISIBLE
so there's no need for such behavior.
We previously had a test exactly for checking that "start does nothing" but we
now need to ensure that start actually is propagated to the inner feature that
is to rebind itself to the app to allow for user interactions.
FindInPageFeature is used inside the app as a LifecycleAwareFeature and as such
it receives the onStart / onStop lifecycle calls.
The onStart() lifecycle call would not get passed to the feature but in
onStop() FindInPageFeature will detach it's Presenter and Interactor so when
the user comes back to the screen she could not interact anymore with the
feature.
To fix this we'll propagate LifecycleAwareFeature's onStart() to the inner
feature which is to rebind it's Presenter and Interactor in onStart().
This behavior is common to all the other features so all of them who implement
LifecycleAwareFeature will now get the onStart() call also.
* fixes#4193 - made close button for tabs more accessible.
set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button and text as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
* Fix margins
We currently do not use thumbnails anywhere in the app. Not using the feature means we are
not taking thumbnails on every page load which means we are saving memory and CPU cycles.
Navigation between app fragments uses ShareTab as arguments. The newly used
SendTabUseCases uses TabData which is not Parcelable.
For minimal changes we'll keep both data classes and ShareController will know
how to map between the two.
Removed the `sessionId` property of ShareTab as it isn't needed anymore.
Chenxia Liu
No-Jun Park
ekager
Tiger Oakes
Emily Kager
Mihai Adrian
Sawyer Blatz
mihai-adrian
Colin Lee
Aaron Train
Jeff Boek
Petru Lingurar
Mitchell Hentges
Jonathan Almeida
Richard Pappalardo
Alessio Placitelli
Sebastian Kaspari
Grisha Kruglov
Yeon Taek Jeong
Axel Hecht