Sebastian Kaspari
9fdfd82bc0
[fenix] Update to Mozilla Android Components 12.0.0-SNAPSHOT.
2019-09-05 13:38:15 +02:00
Sebastian Kaspari
1ad6f0ea20
[fenix] Add browser-state component.
2019-09-05 13:38:15 +02:00
Alessio Placitelli
0ab76faedb
[fenix] Revert "Enable Gecko metrics exfiltration through Glean ( https://github.com/mozilla-mobile/fenix/pull/5124 )" ( https://github.com/mozilla-mobile/fenix/pull/5125 )
...
This reverts commit ed9c9cffa8033784f9ab3c7391c177ab5b66cf1e.
2019-09-05 04:26:46 -05:00
Alessio Placitelli
7d25624e16
[fenix] Enable Gecko metrics exfiltration through Glean ( https://github.com/mozilla-mobile/fenix/pull/5124 )
2019-09-05 04:17:28 -05:00
Emily Kager
a4172aafae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5025 - Do not remove custom tab session with config removed
2019-09-05 10:57:37 +02:00
Sawyer Blatz
d0fa780907
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4155 : Adds strings for long press popup ( https://github.com/mozilla-mobile/fenix/pull/5112 )
2019-09-04 17:15:06 -07:00
Emily Kager
dafda5ba3c
[fenix] No issue: Land strings for delete browsing data on quit
2019-09-04 15:45:10 -07:00
Yeon Taek Jeong
e039e6a5ac
[fenix] For https://github.com/mozilla-mobile/fenix/issues/419 : Add strings for "Add private browsing shortcut" feature ( https://github.com/mozilla-mobile/fenix/pull/5109 )
2019-09-04 15:44:22 -07:00
Jeff Boek
51b7cc54cf
[fenix] For i5047 - Adds strings for the add to homescreen dialog
2019-09-04 15:18:44 -07:00
Sawyer Blatz
5a5f46cb76
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5021 : Adds metric for what's new button
2019-09-04 09:17:14 -07:00
Sawyer Blatz
da34c36d24
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4908 : Adds metrics for send tab telemetry
2019-09-04 09:15:50 -07:00
mihai-adrian
d6883885e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5095 : Changed search engine text color from default to ?primaryText
2019-09-04 07:57:17 -07:00
mihai-adrian
1329fdef70
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4892 : Replaced straight single quote with curly apostrophe in contractions
2019-09-04 14:10:05 +02:00
Axel Hecht
2dfb11a83a
[fenix] Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@6d2fe8331a
2019-09-04 14:08:15 +02:00
Sawyer Blatz
e0e1bdba5c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4474 : Adds what's new button to home screen menu ( https://github.com/mozilla-mobile/fenix/pull/5088 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4474 : Adds what's new button to home screen menu
* For https://github.com/mozilla-mobile/fenix/issues/4474 : Adds tests for what's new button
2019-09-03 15:16:29 -05:00
Petru Lingurar
8c4f0ecc02
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5067 - Refactor ShareControllerTest following the use of SendTabUseCases
2019-09-03 12:01:26 -07:00
Petru Lingurar
2f4392c064
[fenix] Fix https://github.com/mozilla-mobile/fenix/issues/5067 - Refactor ShareController to use SendTabUseCases
...
Navigation between app fragments uses ShareTab as arguments. The newly used
SendTabUseCases uses TabData which is not Parcelable.
For minimal changes we'll keep both data classes and ShareController will know
how to map between the two.
Removed the `sessionId` property of ShareTab as it isn't needed anymore.
2019-09-03 12:01:26 -07:00
Sebastian Kaspari
98f0427ea2
[fenix] Fix ktlint MaxLineLength issues.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
d4849ca93e
[fenix] Stores: Reduce visibility of reducer functions.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
ec29bdbc78
[fenix] Rename HistoryStore/State/Action to HistoryFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
a682a16b25
[fenix] Rename AccountSettingsStore/State/Action to AccountSettingsFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
0a46f6d16a
[fenix] Rename SearchStore/State/Action to SearchFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
5a3bfb2b77
[fenix] Rename ExceptionsStore/State/Action to ExceptionsFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
52d15c5be7
[fenix] Rename BrowserStore/State/Action to BrowserFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
Sebastian Kaspari
c0b76b338f
[fenix] Rename BookmarkStore/State/Action to BookmarkFragmentStore/State/Action.
2019-09-03 10:09:06 -07:00
mihai-adrian
309495f15a
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4997 : Changed navigation to ShareFragment
...
Changed test for new global navigation to share fragment.
2019-09-03 07:08:08 -10:00
mihai-adrian
0f119aae4e
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4997 : Changed navigation to ShareFragment
...
Added global navigation action to share fragment in navigation graph
Changed share action to use global navigation to ShareFragment
2019-09-03 07:08:08 -10:00
Sebastian Kaspari
61c2a0878f
[fenix] Issue https://github.com/mozilla-mobile/fenix/pull/4907 : Link to usage of sharedUserId in Fennec code.
2019-09-03 17:10:06 +02:00
Sebastian Kaspari
720589cbb0
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873 : Use manifest placeholder to inject sharedUserId.
2019-09-03 17:10:06 +02:00
Sebastian Kaspari
7a554f2f4e
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873 : Reuse sharedUserId from Fennec for fennecProduction build type.
2019-09-03 17:10:06 +02:00
Sebastian Kaspari
9a01bb2639
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873 : Use Fennec version code mechanism for fennecProduction build type.
2019-09-03 17:10:06 +02:00
Sebastian Kaspari
b4b87eb165
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873 : Only build fennecProduction build types with GeckoView Beta.
2019-09-03 17:10:06 +02:00
Sebastian Kaspari
c91a28030f
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873 : Reuse Firefox application id for fennecProduction build type.
2019-09-03 17:10:06 +02:00
Sebastian Kaspari
7061d22246
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/4873 : Introduce "fennecProduction" build type.
2019-09-03 17:10:06 +02:00
Colin Lee
b5615b600d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/5055 : Crash when opening bookmarks ( https://github.com/mozilla-mobile/fenix/pull/5058 )
2019-08-31 17:41:50 -05:00
Christian Sadilek
c1d104a193
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2088 : Use new async API to load default search engine in HomeFragment
2019-08-30 17:56:18 -04:00
Sebastian Kaspari
6ac2509131
[fenix] Move creation of GeckoRuntime to flavor-specific source set.
...
Since we are now able to build against GeckoView Nightly and GeckoView Beta,
we should create the GeckoRuntime from a flavor-specific source set.
Creating the runtime is not covered by the AC abstraction and so API changes
in GeckoView Nightly can break the build and leaves us with no option to fix
it from a shared code base. Separating the creation of GeckoRuntime
allows us to adapt individually and also to configure the runtimes
differently.
2019-08-30 15:16:12 +02:00
Will Hawkins
2127d42c9d
[fenix] Use new async API to load and access search engines
...
Use the new asynchronous features of the search engine
manager from a-c to avoid the latency required to load
the default search engine.
2019-08-29 18:16:02 -07:00
Mugurell
23f1395585
[fenix] For 4007 - Add unit tests for the Share Interactor, Controller and list Adapters
2019-08-29 18:12:50 -07:00
Mugurell
00a0d8db5e
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4007 - Add ShareController for handling ShareFragment's business logic
...
`ShareController` defines a contract with all possible `ShareFragment`'s
behavior changes and comes with a default implementation -
`DefaultShareController`.
It is to be delegated by all `ShareFragment`s contained Views' Interactors
following any user interactions.
2019-08-29 18:12:50 -07:00
Mugurell
051f09a15a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4007 - ShareFragment will set the contained Views' state
...
ShareFragment which acts as a container would contain all business logic needed
for populating it's Views.
Data initialization should be done only once since the app state has no reason
to change after the ShareFragment is created and is done as soon as possible,
in onAttach().
Because of the expected short lifespan of this fragment, given the fact that
the state has no reason to change and we handle orientation changes ourselves
to keep things simple I didn't use a ViewModel to persist the state.
2019-08-29 18:12:50 -07:00
Mugurell
a8cbf8b1d8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4007 - Refactor AppShareView in standalone Share Views
...
In an effort to respect the initial MVI architecture I've broken the
complex `AppShareView` in 3 separate Views
- `ShareCloseView`
- `ShareToAccountDevicesView`
- `ShareToAppsView`
They are standalone Views (extending LayoutContainer) which know nothing about
each other or their parent and so offer their container the possibility to
order or display them in any form later.
According to the lib-state contract they are only responsible to
- inflate themselves in their injected containerView
- render a certain state (to be added in later commits)
- delegate all user interaction to an associated Interactor
2019-08-29 18:12:50 -07:00
Mugurell
4168f278f2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4007 - Use camelCase for views referenced from code
...
As per https://github.com/mozilla-mobile/fenix/issues/4341 .
Also reformatted layouts to have a more consistent style.
Also refactored `AppShareRecyclerView` and `AccountDevicesShareRecyclerView` by
defining their LayoutManager in XML to reduce code complexity.
2019-08-29 18:12:50 -07:00
Tiger Oakes
09ca0c9e48
[fenix] Add comments to AuthCustomTabActivity
2019-08-29 15:06:34 -07:00
Sawyer Blatz
90a79b82f7
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3892 : Fixes help link on nightly ( https://github.com/mozilla-mobile/fenix/pull/4956 )
2019-08-29 13:27:50 -07:00
Mihai Adrian
d091cb2c1c
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4894 : added workaround for SDK<24 vector drawable with gradient color ( https://github.com/mozilla-mobile/fenix/pull/4944 )
...
Removed drawableStart and added ImageView in layouts
Set ImageView logo programmatically: bitmap for SDK<24, vector for SDK>=24
Added onClickPendingIntent for ImageView in large and medium layouts
2019-08-29 12:55:51 -07:00
Tiger Oakes
e4abe9cace
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/773 - Add shortcuts to homescreen ( https://github.com/mozilla-mobile/fenix/pull/4925 )
2019-08-29 14:45:11 -05:00
Colin Lee
b472ab03be
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4064 : Old R8 & keep rules are inhibiting optimizations ( https://github.com/mozilla-mobile/fenix/pull/4930 )
2019-08-29 10:16:26 -05:00
mihai-adrian
46aec58767
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/3602:navigate to top of home screen after tapping "start browsing"
...
After onboarding.finish(), scrolled homeLayout to top
2019-08-29 07:45:04 -07:00
Jonathan Almeida
d8489d7350
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4218 : Remove forced registration renewal for push
2019-08-28 21:14:12 -04:00
Jonathan Almeida
818a6693f9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4063 : Remove SendTab feature flags
2019-08-28 21:14:12 -04:00
Yeon Taek Jeong
b4fa37b231
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4658 : Add some private browsing mode telemetry ( https://github.com/mozilla-mobile/fenix/pull/4968 )
2019-08-28 14:41:37 -07:00
Sawyer Blatz
0356d7c3ec
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4969 : Removes erroneous FxA sign up ping ( https://github.com/mozilla-mobile/fenix/pull/4970 )
2019-08-28 14:32:43 -07:00
Yeon Taek Jeong
cc75c0df87
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2053 : Add persistent notification to close all private browsing tabs ( https://github.com/mozilla-mobile/fenix/pull/4913 )
2019-08-28 12:55:24 -07:00
Sebastian Kaspari
a63606870c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4215 : CustomTabActivity: Remove attached session if activity is finishing. ( https://github.com/mozilla-mobile/fenix/pull/4985 )
2019-08-28 11:03:04 -07:00
Emily Kager
6527ff2fcd
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4863 - Remove delay in HomeFragment onPreDraw
2019-08-28 13:48:14 -04:00
Suraj Shah
bde36a6d45
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4488 : Shows snackbar on bookmark deletion from edit fragment ( https://github.com/mozilla-mobile/fenix/pull/4792 )
...
* Fixes https://github.com/mozilla-mobile/fenix/issues/4488
Updates changelog
* Removes wildcard imports.
* Removes custom label in use, replaces with let
2019-08-28 10:12:39 -07:00
Sebastian Kaspari
5db6464268
[fenix] Use Mozilla Android Components 10.0.1.
2019-08-28 15:31:25 +02:00
Jonathan Almeida
dec7d9a442
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4960 : Initialize push only if available ( https://github.com/mozilla-mobile/fenix/pull/4964 )
2019-08-27 14:15:38 -07:00
Afzal Najam
e0f503fe0c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4718 - Update site permissions layout ( https://github.com/mozilla-mobile/fenix/pull/4953 )
2019-08-27 14:07:51 -07:00
Jeff Boek
03babccbf6
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4063 - Always enable the push service ( https://github.com/mozilla-mobile/fenix/pull/4932 )
2019-08-27 13:12:29 -07:00
Tiger Oakes
6fa3cf4a26
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4771 - Add method for sessions of type ( https://github.com/mozilla-mobile/fenix/pull/4782 )
...
Fixes share tabs to use the new method
2019-08-27 13:04:03 -07:00
Emily Kager
d3cbb93b88
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4295 - Adds Experiments Pref to Data Collection Settings ( https://github.com/mozilla-mobile/fenix/pull/4915 )
2019-08-27 12:56:16 -07:00
Sebastian Kaspari
dc70e530cc
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4431 : Enable feature-media component for all builds. ( https://github.com/mozilla-mobile/fenix/pull/4898 )
2019-08-27 12:51:27 -07:00
Mihai Adrian
1e2fdf5cae
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4211 changed SeekBar height to wrap_content to prevent misaligned dot ( https://github.com/mozilla-mobile/fenix/pull/4832 )
...
Changed height from match_constrained to wrap_content.
2019-08-27 12:50:00 -07:00
Emily Kager
018086c9ae
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4921 - Adds WindowFeature to BaseBrowserFragment
2019-08-27 15:33:59 -04:00
Arturo Mejia
eb53d10047
[fenix] Fix safe browsing API breaking change. ( https://github.com/mozilla-mobile/fenix/pull/4946 )
2019-08-27 13:43:22 -05:00
Aaron Train
da02c6f228
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4926 : Add basic UI test for regular/private tabs ( https://github.com/mozilla-mobile/fenix/pull/4928 )
2019-08-27 13:56:12 -04:00
Sourabh
d47dc7b29d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4398 - add HistoryController ( https://github.com/mozilla-mobile/fenix/pull/4837 )
2019-08-27 10:33:40 -07:00
Mihai Adrian
c68c8a4374
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4440 changed padding for account_preference ( https://github.com/mozilla-mobile/fenix/pull/4830 )
...
Changed padding to default value in @android:style/Preference.Material.Category.
Also changed paddingEnd value to default value.
2019-08-27 10:26:32 -07:00
Amaan Marfatia
f42c71ccfe
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4067 besides snackbar ( https://github.com/mozilla-mobile/fenix/pull/4777 )
...
* Fixes https://github.com/mozilla-mobile/fenix/issues/4067 besides snackbar
Makes layout hierarchy more shallow to increase performance.
* Fix https://github.com/mozilla-mobile/fenix/issues/4067 Feedback
Make sure quick_action_overlay appears on top and use horizontal chain in tab_header.
2019-08-27 10:09:55 -07:00
Axel Hecht
118c704270
[fenix] Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@349efdbc8f
2019-08-27 08:22:42 -07:00
Colin Lee
cdc611fec5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4885 : D8 Build failure on attempt to execute UI test ( https://github.com/mozilla-mobile/fenix/pull/4903 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4885 : D8 Build failure on attempt to execute UI test
* Disabled screengrab tests until AndroidX fix is available
2019-08-23 13:37:52 -07:00
Tiger Oakes
df7dc6523c
[fenix] Add custom tab fragment
2019-08-23 16:12:19 -04:00
ekager
eb3c357f61
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3967 - Invoke pending deletion on back pressed
2019-08-23 15:32:27 -04:00
ekager
2f11d83ca4
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4868 - Update content description of tabs button with number of tabs
2019-08-23 09:21:32 -07:00
Grisha Kruglov
a9288459fa
[fenix] No issue: only sync once on startup
2019-08-23 12:08:11 -04:00
Emily Kager
ea577bdf3a
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4779 : Don't double navigate with global directions in HomeActivity
2019-08-23 12:01:28 -04:00
Axel Hecht
86cd4a78ba
[fenix] Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@90a28fd458
2019-08-23 14:36:01 +02:00
Sebastian Kaspari
456cfb5bfb
[fenix] Use version name/code override. ( https://github.com/mozilla-mobile/fenix/pull/4895 )
2019-08-23 07:08:37 -05:00
Emily Kager
c87829be14
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4652 : Use workaround for HomeScreenViewModel ( https://github.com/mozilla-mobile/fenix/pull/4887 )
2019-08-22 13:35:51 -05:00
Tiger Oakes
63814821eb
[fenix] Extract intent processors from HomeActivity ( https://github.com/mozilla-mobile/fenix/pull/4884 )
2019-08-22 13:31:40 -05:00
Sebastian Kaspari
11a92537ce
[fenix] Rename "nightly" source folder to "fenixNightly".
2019-08-22 19:46:40 +02:00
Tiger Oakes
b8695ca06b
[fenix] Make Settings.instance
private
2019-08-22 08:14:08 -07:00
Sebastian Kaspari
14e9fc85da
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4874 : Use new build types in FeatureFlags class.
2019-08-22 08:12:49 -07:00
Emily Kager
11b37b2da0
[fenix] Adds experiments preferences strings
2019-08-21 19:55:26 -07:00
Emily Kager
494008a099
[fenix] No issue: Land strings for Delete Browsing Data on Quit
2019-08-21 19:55:26 -07:00
Colin Lee
bd400b8f53
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4064 : Dispatchers.Main still has long cold start delay (Phase II)
2019-08-21 14:32:44 -07:00
Tiger Oakes
cf9ace2cc1
[fenix] Move classes out of top-level package
2019-08-21 13:52:30 -07:00
Richard Pappalardo
3e02efef28
[fenix] Stub out Settings tests
2019-08-21 13:52:03 -07:00
Jeff Boek
6ec0801d0c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4326 - Updates codebase to support latest version of detekt
2019-08-21 13:50:51 -07:00
Jeff Boek
40ae66fdbb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4326 - Updates codebase to support latest version of ktlint
2019-08-21 13:50:51 -07:00
Emily Kager
51d4956148
[fenix] No issue: Land new string for delete browsing data prompt ( https://github.com/mozilla-mobile/fenix/pull/4859 )
2019-08-21 11:17:34 -07:00
Colin Lee
f187762a78
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3869 : Switch to A-C SearchLocalizationProvider ( https://github.com/mozilla-mobile/fenix/pull/4858 )
...
* For https://github.com/mozilla-mobile/fenix/issues/3869 : Switch to A-C SearchLocalizationProvider
* Fix test
2019-08-21 11:14:59 -07:00
Nick Alexander
dbb115a551
[fenix] Consume new substitute-local-geckoview.gradle
script from Bug 1533465.
2019-08-21 19:52:01 +02:00
Mihai Adrian
71229cdddd
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4795 fixed requestDesktopStateProvider value from private to desktopMode ( https://github.com/mozilla-mobile/fenix/pull/4810 )
...
RequestDesktopStateProvider was taken from private instead of desktopMode
2019-08-21 09:10:06 -07:00
Sourabh
c50d08d405
[fenix] add tests for DefaultQuickActionSheetController ( https://github.com/mozilla-mobile/fenix/pull/4835 )
2019-08-21 08:52:01 -07:00
Tiger Oakes
9e9246ada3
[fenix] No issue: Clean up preferences code ( https://github.com/mozilla-mobile/fenix/pull/4699 )
2019-08-21 08:38:14 -07:00
Emily Kager
409cea2128
[fenix] For https://github.com/mozilla-mobile/fenix/issues/3967 - Invokes pending deletion with more bookmark actions ( https://github.com/mozilla-mobile/fenix/pull/4522 )
2019-08-21 08:36:41 -07:00
Mitchell Hentges
e7ca5257b4
[fenix] Configure either geckoview beta or nightly at compile-time ( https://github.com/mozilla-mobile/fenix/pull/4851 )
...
* Remove "abi" product flavor and introduce "engine" product flavor.
This patch will allow us to build Fenix against GeckoView Nightly and GeckoView Beta by
introducing a new flavor dimension: engine = [geckoNightly, geckoBeta].
In addition to that it adds a "fenix" prefix to the nightly, beta and production flavors
to reduce the ambiguity between fenix beta/nightly and GeckoView beta/nightly.
For now the build types have the following engine variants enabled:
**debug**: geckoNightly, geckoBeta
Both variants enabled for local development and testing.
**forPerformanceTest**: geckoNightly, geckoBeta
Both variants enabled unless the perf team only cares about Nightly (tbd)
**fenixNightlyLegacy**: geckoBeta
Uses GeckoView Beta for now - the same version we ship production builds with (same behavior
as before). This release type will eventualyl be decommissioned once we switch to a separate
Nightly app on Google Play.
**fenixNightly**: geckoBeta
Uses GeckoView Beta for now - the same version we ship production builds with (same behavior
as before). Changing this build to use GeckoView Nightly is currently being discussed.
**fenixBeta**: geckoBeta
Fenix Beta uses GeckoView Beta.
**fenixProduction**
Fenix Production uses GeckoView Beta (69) currently.
* gradle.py/variant.py: Replace "abi" with "engine".
* Disable enableUnitTestBinaryResources until we can switch to Android Gradle plugin 3.5.
* Fenix nightly should use both geckoview nightly and beta
* Updates automation to use apk splitting and support different engine
2019-08-21 08:32:01 -07:00
Jonathan Almeida
584103cdf6
[fenix] Use Mozilla Android Components 10.0.0
2019-08-21 10:06:05 -04:00
Emily Kager
528b8e0d5f
[fenix] No issue: Land new strings for ETP and delete browsing data
2019-08-21 10:59:12 +02:00
Yeon Taek Jeong
410bb482b1
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2834 : Add contentDescription to tabs button icons
2019-08-20 16:34:05 -07:00
Emily Kager
1d3eec6208
[fenix] No issue: Don't show session provider in private mode
2019-08-20 16:09:55 -07:00
Yeon Taek Jeong
86ec7d5d6c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2834 : Delete all Private Tabs redesign ( https://github.com/mozilla-mobile/fenix/pull/4787 )
2019-08-20 13:10:08 -07:00
(´⌣`ʃƪ)
da54bdfe63
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4436 : Dismiss onboarding before navigating away from home ( https://github.com/mozilla-mobile/fenix/pull/4801 )
2019-08-20 10:56:28 -07:00
Tiger Oakes
9882aa6a50
[fenix] Adds setters and property delegates in Settings
( https://github.com/mozilla-mobile/fenix/pull/4809 )
...
* Change Settings to use setters
* Add delegate for shared preferences
2019-08-20 10:47:55 -07:00
Tiger Oakes
7780821922
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2690 - Clean up CreateCollection viewmodel ( https://github.com/mozilla-mobile/fenix/pull/4731 )
2019-08-20 10:45:41 -07:00
Tiger Oakes
2fb1bd0283
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4774 - Use vector drawable compat ( https://github.com/mozilla-mobile/fenix/pull/4811 )
2019-08-20 10:43:02 -07:00
Tiger Oakes
500d557828
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4744 - Extract private browsing button ( https://github.com/mozilla-mobile/fenix/pull/4813 )
2019-08-20 10:41:18 -07:00
Tiger Oakes
d5e5b73485
[fenix] Color the system bars in custom tabs ( https://github.com/mozilla-mobile/fenix/pull/4819 )
2019-08-20 10:13:01 -07:00
Tiger Oakes
efe2e2e466
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/1000 - Remove isCustomTab flag ( https://github.com/mozilla-mobile/fenix/pull/4656 )
2019-08-20 10:00:49 -07:00
Sourabh
0e376bb266
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4399 : Create LibState Controller for Search ( https://github.com/mozilla-mobile/fenix/pull/4673 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4399 : Create LibState Controller for Search
* fix code format
* add unit tests for DefaultSearchController
* add more test
* fix unit tests
2019-08-20 09:07:00 -07:00
Mugurell
2634b6dee4
[fenix] For 4827 - Remove TransitionPreDrawListenerTest pending tests refactoring
...
New tests for `FragmentPreDrawManager` are to be added in https://github.com/mozilla-mobile/fenix/issues/4828
2019-08-20 13:45:55 +02:00
Mugurell
fa2abeffe9
[fenix] Fix 4827 - Use ktx doOnPreDraw() to restore HomeFragment's layout
...
The previous solution would result in a crash because the passed in
viewTreeObserver that would trigger onPreDraw would be invalid.
The proposed solution is simpler and ensures we'll always use the right
viewTreeObserver.
`FragmentPreDrawManager` is general enough that can be used by other Fragments
also, so I've added it to the `utils` package.
2019-08-20 13:45:55 +02:00
Emily Kager
9431f611d5
[fenix] Update strings.xml
...
Remove space in placeholder for es (temp for release)
2019-08-19 19:14:22 -07:00
Axel Hecht
7d5d5b7afd
[fenix] Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@413e05dba4
2019-08-19 19:14:22 -07:00
Tiger Oakes
1c389d1231
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4744 - Extract TransitionPreDrawListener ( https://github.com/mozilla-mobile/fenix/pull/4812 )
2019-08-19 16:27:43 -07:00
Tiger Oakes
774d696c92
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4744 - Move search bar icon padding to dimens ( https://github.com/mozilla-mobile/fenix/pull/4814 )
2019-08-19 16:22:51 -07:00
Emily Kager
0268034e79
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4822 - Update Bookmark State in onResume ( https://github.com/mozilla-mobile/fenix/pull/4823 )
2019-08-19 16:22:20 -07:00
Mihai Adrian
8a1829b484
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/4179 removed control highlight from disconnect button ( https://github.com/mozilla-mobile/fenix/pull/4806 )
...
set colorControlHighlight to transparent in activity theme.
property cannot be set in view because it is overwritten by activity theme.
2019-08-19 16:16:06 -07:00
Sawyer Blatz
1c995d36e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2706 : Refactor Glean to reduce errors ( https://github.com/mozilla-mobile/fenix/pull/4753 )
...
* For https://github.com/mozilla-mobile/fenix/issues/2706 : Adds recording for untracked events
* For https://github.com/mozilla-mobile/fenix/issues/2706 : Adds key alignment to Metrics
2019-08-19 15:25:48 -07:00
Sawyer Blatz
46eaca2871
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4421 : Fixes issues with new glean events ( https://github.com/mozilla-mobile/fenix/pull/4816 )
2019-08-19 14:49:48 -07:00
Sawyer Blatz
ea193a5472
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4804 : Resolves issue with crash reporter stack
2019-08-19 16:40:41 -04:00
Aaron Train
aa9bf1aa6e
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4618 - Stub Library UI tests ( https://github.com/mozilla-mobile/fenix/pull/4619 )
...
See https://github.com/mozilla-mobile/fenix/issues/4572
2019-08-19 14:05:10 -04:00
Arturo Mejia
7f746f6f17
[fenix] Use Mozilla Android Components 9.0.0-SNAPSHOT. ( https://github.com/mozilla-mobile/fenix/pull/4750 )
2019-08-19 10:29:10 -07:00
Suraj Shah
f3a412e24e
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4704 ( https://github.com/mozilla-mobile/fenix/pull/4728 )
...
* Fixes https://github.com/mozilla-mobile/fenix/issues/4704 . Overrides `setEnabled` for DeleteBrowsingDataItem to change view alpha when disabled and to toggle the checkbox `isEnabled` behavior based on the value provided.
* Updates CHANGELOG.md
* Removes unnecessary disabling of checkbox in DeleteBrowsingDataItem.kt
Updates CHANGELOG.md to reflect the component changed.
2019-08-19 09:23:12 -07:00
Mugurell
43e4bcc0b1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4396 - Add a Bookmarks Controller ( https://github.com/mozilla-mobile/fenix/pull/4593 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4396 - Rename BookmarkInteractor methods
Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.
Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.
* For https://github.com/mozilla-mobile/fenix/issues/4396 - Add a BookmarkController
It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.
This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.
* For https://github.com/mozilla-mobile/fenix/issues/4396 - Refactored Bookmark related tests
Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`
Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
Tiger Oakes
84349bda63
[fenix] Extract quick action sheet observer code ( https://github.com/mozilla-mobile/fenix/pull/4368 )
2019-08-19 08:28:33 -07:00
Emily Kager
80b2c4ee51
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4799 https://github.com/mozilla-mobile/fenix/issues/4790 - Don't use passed in sessions in BrowserToolbarController ( https://github.com/mozilla-mobile/fenix/pull/4800 )
2019-08-18 20:36:40 -05:00
Colin Lee
47bbb9081d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4686 : Fix potential security issue ( https://github.com/mozilla-mobile/fenix/pull/4764 )
2019-08-16 16:50:54 -05:00
Yeon Taek Jeong
d72c8cf1b6
[fenix] No issue: fixes click failures on search widget icon
2019-08-16 13:58:29 -07:00
Emily Kager
043f8829c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4688 - Try to use context instead of targetContext ( https://github.com/mozilla-mobile/fenix/pull/4765 )
2019-08-16 10:12:56 -07:00
Yeon Taek Jeong
b1fdb6a353
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4736 : Display search shortcuts only from home or search widget
2019-08-15 12:24:54 -04:00
Emily Kager
52ff9a61f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4688 - Try slightly different Context class for MockWebServer ( https://github.com/mozilla-mobile/fenix/pull/4747 )
2019-08-15 08:05:23 -07:00
Emily Kager
b037ddee5a
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4680 - Align collection creation text center vertical
2019-08-14 20:17:01 -04:00
Yeon Taek Jeong
6c41d30fd8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4384 : Hide mic icon if speech-to-text is unavailable ( https://github.com/mozilla-mobile/fenix/pull/4701 )
2019-08-14 16:40:21 -07:00
Yeon Taek Jeong
8efb7f9cdb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4516 : Use full width for large search widgets ( https://github.com/mozilla-mobile/fenix/pull/4659 )
2019-08-14 16:00:13 -07:00
Emily Kager
e4f3b39e0b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/3860 - Update description text for collections
2019-08-14 17:13:52 -04:00
Sawyer Blatz
6cfbb2c02b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4421 : Adds Leanplum events and attributes ( https://github.com/mozilla-mobile/fenix/pull/4626 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4421 : Adds Leanplum events and attributes
* For https://github.com/mozilla-mobile/fenix/issues/4421 : Adds Leanplum deep links
2019-08-14 13:48:45 -07:00
Yeon Taek Jeong
309b86544c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4421 : Add search widget attribute to Leanplum ( https://github.com/mozilla-mobile/fenix/pull/4694 )
2019-08-14 12:00:29 -07:00
Yeon Taek Jeong
468c400ff5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4457 : Adds telemetry for search widget actions ( https://github.com/mozilla-mobile/fenix/pull/4714 )
2019-08-14 11:39:54 -07:00
Yeon Taek Jeong
2c70a18a62
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4732 : Fix search engine display issue ( https://github.com/mozilla-mobile/fenix/pull/4735 )
2019-08-14 11:03:14 -07:00
Mihai Adrian
4835dbb1a8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4434 - made close button for collections more accessible. ( https://github.com/mozilla-mobile/fenix/pull/4443 )
...
* fixes https://github.com/mozilla-mobile/fenix/issues/4434 - made close button for collections more accessible.
set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
implemented same visual solution as for https://github.com/mozilla-mobile/fenix/issues/4193 - close button for tabs
* fixes https://github.com/mozilla-mobile/fenix/issues/4434 - made buttons for collection home list row more accessible and aligned 3 dot menu with individual tabs close button
set buttons sizes to recommended minimum size for accessibility 48x48, while keeping image size the same
removed margins from buttons as they were not needed anymore
aligned center of menu buttons with center of collection icon
constrained description top to bottom of title, instead of share button to reduce empty space. (overlap with share button is already prevented by end constraint of description)
2019-08-14 10:12:39 -07:00
Michael Cooper
9646181343
[fenix] Add no-op experiment to test service-experiments integration ( https://github.com/mozilla-mobile/fenix/pull/4551 )
...
* Add no-op experiment to test service-experiments integration
* Shorten metric name to meet schema
* Add active_experiment metric to docs
* Add approved data review
2019-08-14 12:07:41 -05:00
Tiger Oakes
07eda357ba
[fenix] Use global navigation action for browser fragment ( https://github.com/mozilla-mobile/fenix/pull/4691 )
2019-08-14 11:58:29 -05:00
isabelrios
61e400c2d8
[fenix] Fix UI Screenshot TabMenuTest ( https://github.com/mozilla-mobile/fenix/pull/4730 )
2019-08-14 11:57:36 -05:00
Colin Lee
4987c40d67
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1667 : Screen reader can't reach other UI items when QAB expanded ( https://github.com/mozilla-mobile/fenix/pull/4695 )
2019-08-14 09:56:29 -07:00
Emily Kager
bf76cbe7e6
[fenix] No issue - Autoformatting ( https://github.com/mozilla-mobile/fenix/pull/4715 )
2019-08-14 09:40:46 -05:00
Sebastian Kaspari
c30700580c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4719 : Get rid of fragment-testing dependency and create fragments in StoreProviderTest manually. ( https://github.com/mozilla-mobile/fenix/pull/4722 )
2019-08-14 09:10:24 -05:00