Michael Comella
3e96f6b385
For #13959 - review: add clarifying comments.
2020-10-06 14:11:53 -07:00
Michael Comella
50959d997e
For #13959 : add marker when StrictMode is suppressed.
2020-10-06 14:11:53 -07:00
Michael Comella
3b5d6d58d9
For #13959 : add MozillaStrictModeSuppression detekt check.
2020-10-06 14:11:53 -07:00
Michael Comella
66f220c22a
For #13959 : improve custom detekt violation output.
...
Before it used to output the violations all one one line. Now it looks
like:
```
MozillaStrictModeSuppression:
'import mozilla.components.support.ktx.android.os.resetAfter' at
(17,1) in /StrictModeManager.kt
Please use `components.strictMode.resetAfter` instead because it has
performance improvements and additional code to monitor for performance
regressions.
MozillaStrictModeSuppression:
'setThreadPolicy(threadPolicy.build())' at (56,24) in
/StrictModeManager.kt
Please use `components.strictMode.resetAfter` instead because it has
performance improvements and additional code to monitor for performance
regressions.
MozillaStrictModeSuppression:
'setVmPolicy(builder.build())' at (71,24) in /StrictModeManager.kt
NOT YET IMPLEMENTED: please consult the perf team about
implementing`StrictModeManager.resetAfter`: we want to understand the
performance implications of suppressing setVmPolicy before allowing it.
```
2020-10-06 14:11:53 -07:00
Michael Comella
b222376cb0
For #13959 : add test to prevent increasing StrictMode suppression count.
2020-10-06 14:11:53 -07:00
Michael Comella
c33aafb024
For #13959 : add HomeActivityTestRule.skipOnboarding.
...
This is more correct, faster, and results in less copy-paste duplication
than the current behavior:
homeScreen { }.dismissOnboarding()
Which opens settings to dismiss onboarding.
2020-10-06 14:11:53 -07:00
Michael Comella
4a4edeb184
For #13959 : count StrictMode suppressions on startup.
2020-10-06 14:11:53 -07:00
Jocelyne Abi Haidar
a5de2c0352
For #15675 : Disable Save button when editing saved login until something has been changed
...
set save button state by calling invalidateOptionsMenu, causing onPrepareOptionsMenu to be called which will enable/disable the save button depending on if changes have been made or not
2020-10-06 11:47:12 +03:00
mozilla-l10n-automation-bot
5fed37cf45
Import l10n. ( #15712 )
2020-10-05 18:08:06 -07:00
Mozilla L10n Automation Bot
ad2b99f9f9
Import l10n.
2020-10-05 12:19:48 +02:00
mcarare
07748f69b7
For #15632 : Improve checking open tabs logic to show collection button.
...
Check now considers selected tab tray mode.
2020-10-02 20:46:29 -04:00
ekager
ec3595d4fc
For #15600 - Move removal of timed out sessions to immediately after restoration
2020-10-02 13:22:49 -07:00
Roger Yang
450caf1e42
Revert "No issue: remove * ac from codeowners." ( #15638 )
...
This reverts commit f3b7e294be
2020-10-02 13:08:15 -04:00
Michael Comella
01d982d4b2
No issue: add custom lint guide to readme.
2020-10-02 09:41:07 -07:00
MickeyMoz
edcdac5402
Update Android Components version to 62.0.20201002143132.
2020-10-02 09:40:04 -07:00
ekager
01eedd159a
No issue: Update biometric, core, and recyclerview libraries
2020-10-02 08:47:40 -07:00
mcarare
b696fc4c4b
For #13031 : Show size in KB for smaller downloaded files.
2020-10-02 11:04:48 -04:00
Mozilla L10n Automation Bot
ee4a5283a4
Import l10n.
2020-10-01 17:46:57 -07:00
Michael Comella
f3b7e294be
No issue: remove * ac from codeowners.
...
rocketsroger and I agreed this may be undesireable due to the increased
notifications. If we remove it and someone complains, we can re-add it.
2020-10-01 17:09:39 -07:00
Jocelyne
0154c81f81
For #10107 : Show Today and Yesterday labels in History ( #15415 )
2020-10-01 16:42:50 -07:00
Michael Comella
f690f8736d
No issue: replace LintUnitTestRunner with detekt implementation.
...
This should be more performant and easier to maintain.
2020-10-01 16:06:53 -07:00
Michael Comella
57805b82a8
No issue: run detekt on unit test files.
...
detekt still passes after I make this change.
afaik, there isn't a good reason not to run it on unit tests and it can
be valuable to add custom rules for them. Also, detekt is already
running on our androidTest directory.
2020-10-01 16:06:53 -07:00
Jeff Boek
41a92a8d8b
For #15593 - Reverts back to simple UUID creation without Fenix side caching
2020-10-01 15:51:30 -07:00
MickeyMoz
a19a63db19
Update Android Components version to 62.0.20201001194334.
2020-10-01 14:58:06 -07:00
Michael Comella
a173749ad8
No issue: document list_compatible_dependency_versions script in README.
2020-10-01 13:34:27 -07:00
Jocelyne
e74a12b442
For #15471 : Show Delete button in red in multi-select overflow menu ( #15576 )
2020-10-01 13:10:33 -07:00
Mozilla L10n Automation Bot
97adee3bd9
Import l10n.
2020-10-01 20:13:40 +02:00
Grisha Kruglov
51dab196c4
Closes #15443 : Use fragment's lifecycleScope for AlertDialog actions
2020-09-30 17:42:40 -07:00
Christian Sadilek
ced92d69d1
Issue #15555 : Set channel to Nightly explicitly for SettingsFragmentTest
2020-09-30 18:35:20 -04:00
mcarare
67310061a3
For #15559 : Allow tabs to stretch in landscape mode for tablets.
...
This overrides the default tabMaxWidth of 264dp to allow for tabGravity="fill".
2020-09-30 14:46:22 -07:00
Christian Sadilek
4a06e40e70
Closes #15555 : Intermittent failures in SettingsFragmentTest
2020-09-30 14:53:18 -04:00
Stefan Arentz
ff930175de
For #15537 - Be more verbose about leanplum identifiers ( #15538 )
2020-09-30 13:05:28 -04:00
mcarare
19b377c021
For #15535 : hasOpenTabs now considers the selected tab mode in tray tab.
2020-09-30 08:33:38 -07:00
Ben Hearsum
cd6ab45119
Block github tagging on push-apk ( #15546 )
...
Currently, push-apk fails to verify its chain of trust if github tagging
is done before it runs. Until this is fixed, we need to make sure
tagging is blocked on pushing.
2020-09-30 15:28:40 +02:00
Michael Comella
56f78cb30c
No issue: elaborate on Components class doc.
...
This is to clarify a misunderstanding I found in PR review.
2020-09-29 15:39:10 -07:00
Sebastian Kaspari
2fda22e857
Revert "For #12565 : Pass metrics to share controller" for debug test failures.
...
This reverts commit bbaca06274
2020-09-29 10:59:31 +02:00
Sebastian Kaspari
4de466883b
Revert "For #12565 : Pass bookmark storage to controller" for debug test failures.
...
This reverts commit 3c22100b84
2020-09-29 10:59:17 +02:00
Andrew Gaul
cfbad1dae9
Show undo snackbars with padding with static bottom toolbar
...
This specifically fixes the close tab snackbar. This commit mirrors
the logic when not using Undo from
9e876ebc44#14982 .
2020-09-29 10:15:30 +02:00
ekager
01e802fef0
For #15324 - Show tab settings and recently closed items in menu when no tabs
2020-09-28 21:09:30 -07:00
ekager
e49cd9c558
For #15503 - Change recently closed max to 10
2020-09-29 00:03:49 -04:00
TrianguloY
b07af9ccd3
For #13856 - Prevent overscroll in swipe to switch tabs gesture
2020-09-28 20:43:44 -07:00
Tiger Oakes
25f62f1c76
Extract locale settings initial state
2020-09-28 20:39:49 -07:00
Tiger Oakes
acbad66f45
Add test for initial logins list state
2020-09-28 20:39:49 -07:00
Tiger Oakes
f2a6aa4f25
Add tests for initial collection creation state
2020-09-28 20:39:49 -07:00
Sören Hentzschel
01fdb4ac3f
For #11561 - changed inactive heading and menu icon color in dark mode
2020-09-28 20:24:12 -07:00
Mozilla L10n Automation Bot
863b135723
Import l10n.
2020-09-28 20:18:50 -07:00
Tiger Oakes
3c22100b84
For #12565 : Pass bookmark storage to controller
2020-09-28 20:05:50 -07:00
Tiger Oakes
bbaca06274
For #12565 : Pass metrics to share controller
2020-09-28 20:05:50 -07:00
Michael Comella
d767cd199e
For #13959 : fix startup crash by using arg Context.
...
The `context` member function returns null in attachBaseContext so we
need to use the Context that's being attached instead.
2020-09-28 18:01:19 -07:00
Michael Comella
42cca072e2
For #13959 : remove resetAfter & port tests to StrictModeManager.
2020-09-28 18:01:19 -07:00
