2
0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-17 15:26:23 +00:00
Commit Graph

3826 Commits

Author SHA1 Message Date
Mozilla L10n Automation Bot
33db252797 Import l10n. 2020-07-27 21:05:00 -04:00
ekager
0657bf41d3 For #12991 - Set height to recommended touch target size for collect button 2020-07-27 20:17:48 -04:00
Elise Richards
b7325a3833
For #12571: Rename shortcuts to search engine on search screen (#12839)
* Rename shortcuts to search engine on search screen

* Remove deprecated pref key

* Re-add deprecated string
2020-07-27 17:19:31 -05:00
Tiger Oakes
5d772337a8 Fix AccountUiView ui failures 2020-07-27 17:40:15 -04:00
Elise Richards
52a9acf87d
Enable editing saved logins on all channels (#12841) 2020-07-27 15:48:28 -05:00
Jeff Boek
46f010f247 For #2681 - Adds ability to bypass cache when reloading 2020-07-27 12:11:11 -07:00
Tiger Oakes
57ac6fc36d Extract navigation subgraphs 2020-07-27 15:04:28 -04:00
Tiger Oakes
61d6b333de Update LongParameterList baseline 2020-07-27 14:20:34 -04:00
Tiger Oakes
eab9660146 For #1146: Extract AccountUiView from settings 2020-07-27 21:05:47 +03:00
Tiger Oakes
d640f58316 For #12565 - Clean up controller and add tests 2020-07-27 10:40:09 -07:00
Mugurell
596300591e For #12772 - Opt-out of scoped storage
Targeting Android 10 means we need to support scoped storage or we need to
opt-out of that using requestLegacyExternalStorage="true".

This patch adds the opting-out leaving investigations for what changes we need
for fully supporting scoped storage to be done in issue #12822.
2020-07-27 10:39:47 -07:00
ekager
e5e62fa79a For #6846: Added quick actions for nav bar in home 2020-07-27 13:28:28 -04:00
ekager
1d604d327c For #12966 - Fixes session removal show home logic 2020-07-27 10:27:39 -07:00
Tiger Oakes
52de2b8f38 Fix license on remaining files 2020-07-27 13:04:55 -04:00
Mihai Eduard Badea
b1e7e60665 For issue #12181 - Convert String to sentence case
Changed the string values capitalization to sentence case.
2020-07-27 12:31:13 -04:00
ekager
9c4fba4565 Closes #12954 - Remove all ConstraintLayout casts in SearchEngineListPreference 2020-07-27 09:49:43 -04:00
Mihai Branescu
1cbc4eec52 For #7716 - modified xml to let 'Learn more' button have min 48dp for a11y
Added a margin top of 20dp as well on the buttons so as not to change UI
2020-07-27 10:16:31 +03:00
ekager
6f5faa332d For #12947 - Adjust tab selected state on bind 2020-07-25 20:07:30 -04:00
ekager
058f44e82d For #12721 - Remove SessionManager usages in TabCounter 2020-07-25 18:37:45 -04:00
Hakkı Kaan Çalışkan
3be6393ea5 For #12929: Change cast to LinearLayout 2020-07-25 10:14:48 -04:00
Hakkı Kaan Çalışkan
b3b7566fcf For #12804: Set min height for search engine radio button 2020-07-24 22:10:24 -04:00
ekager
46511d6f8e For #10163 - Adds tab multiselect mode 2020-07-24 18:18:26 -04:00
Jonathan Almeida
d15b8381a6 For #10925: Fix breaking APIs in tabs tray 2020-07-24 16:52:06 -04:00
Tiger Oakes
8c1d3dc827
For #12871 - Use local TWA DAL API (#12872) 2020-07-24 13:08:24 -07:00
Kainalu Hagiwara
cac0be43e6 For #12880 - Pass a CoordinatorLayout to Snackbars created by the context menu. 2020-07-24 12:30:46 -07:00
Sawyer Blatz
95d786a79f No issue: fix master 2020-07-24 15:06:38 -04:00
ekager
6edbb82591 For #12364 - Improve PWA onboarding timing logic 2020-07-24 14:43:28 -04:00
Sawyer Blatz
9c56e1905b For #12793: Improve snackbars for tabs tray 2020-07-24 10:56:54 -07:00
Sawyer Blatz
6c58098fef For #12791: Fix issue with undo snackbar last tab 2020-07-24 10:56:54 -07:00
Sawyer Blatz
c48159d76f
For #10997: Remove scrolling from home (#12866) 2020-07-24 10:43:53 -07:00
Michael Comella
923d841403 For #12345: replace Activity.reportFullyDrawnSafe with a-c impl. 2020-07-24 10:30:03 -07:00
mcarare
3883703ed5 For #10026: Update scroll flags on a11y state change. 2020-07-24 10:35:33 +03:00
mcarare
e7a5613afb For #10026: Add a11y state listener to BaseBrowserFragment. 2020-07-24 10:35:33 +03:00
mcarare
cf0126e079 For #10026: Add Context extension to get AccessibilityManager. 2020-07-24 10:35:33 +03:00
Kainalu Hagiwara
8f32b18dfa For #12868 - Fix tab counter menu snackbar position. 2020-07-23 18:30:04 -07:00
Sawyer Blatz
0e438ef9a7 For #12430: Hide the mic when not using Google 2020-07-23 19:29:26 -04:00
Tiger Oakes
d3a07e95c9 For #12565: Don't pass contest to SortingStrategy 2020-07-23 19:05:11 -04:00
Tiger Oakes
652af79e95
Migrate from Session.toTab to BrowserStore (#12221) 2020-07-23 12:27:39 -07:00
Tiger Oakes
9af167ba0a
Add tests for some classes in home/browser (#12837) 2020-07-23 11:17:52 -07:00
Tiger Oakes
0d77f761e9
Test sync adapter (#12810) 2020-07-23 11:16:11 -07:00
Arturo Mejia
6530a45eb9
For issue #11676: Features phone that doesn't a site permission exception shouldn't be shown (#12855)
exception shouldn't be shown
2020-07-23 09:12:22 -07:00
Mozilla L10n Automation Bot
7f829e1752 Import l10n. 2020-07-23 10:40:10 +03:00
Tiger Oakes
8f5a37733d
Create ToolbarPosition enum (#12747) 2020-07-22 19:23:38 -07:00
Jonathan Almeida
c143f95819 Issue #11333: Set ContentBlocking settings directly on GeckoRuntime
We set the ContentBlockingSettings directly on the GeckoRuntime now to
improve the startup of the engine.

This change has requirements from Android Components and GeckoView, so
we would only see the full perf benefits in Nightly as the changes ride
the train, although we might start to see some of them as we're updating
the GeckoProvider for the `geckoBeta` variant as well.

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2020-07-22 16:28:18 -04:00
Kainalu Hagiwara
b26e39906d No issue - Fix compilation error caused by removed extension function. 2020-07-22 13:00:07 -07:00
Kainalu Hagiwara
58ccc64386 Fix UI tests.
We need to pass a CoordinatorLayout instead of a SwipeGestureLayout to
FenixSnackbar.make() in BaseBrowserFragment to prevent UI tests from
breaking. We also need to remove a few view IDs from the tab preview.
2020-07-22 11:26:15 -07:00
Kainalu Hagiwara
e7dc5580b2 For #3481 - Implement swipe on toolbar to switch tabs. 2020-07-22 11:26:15 -07:00
Mozilla L10n Automation Bot
9a2da5bb0f Import l10n. 2020-07-22 11:25:16 -07:00
Kainalu Hagiwara
921b16233b For #1048 - Add ability to view tab history by long-pressing the back or forward button. 2020-07-22 11:20:47 -07:00
Hakkı Kaan Çalışkan
2a0a11f740 For #12571: Rename 'Shortcuts' to 'Search engines'
Co-Authored-By: Khushraj Rathod <khushrajrathod@gmail.com>
2020-07-22 11:05:04 -07:00
Tiger Oakes
c2d940cf06
Use AC RunWhenReadyQueue (#12800) 2020-07-22 09:48:36 -07:00
Tiger Oakes
d9357f1e32 For #12801 - Extra debug menu trigger, disable if already triggered 2020-07-22 19:28:48 +03:00
Jonathan Almeida
d5fbc17ccf Update to Android Components 52.0.20200722023149
Fixes breaking APIs in SyncedTabsFeature and
BookmarksStorageSuggestionProvider
2020-07-22 10:52:14 -04:00
Michael Comella
2ae88aec81 No issue: add missing newline. 2020-07-21 15:52:34 -07:00
Michael Comella
6e06c7fda1 No issue: clean up initVisualCompletenessQueue... method.
A no-op clean up.
2020-07-21 15:52:34 -07:00
Michael Comella
633bc4f2f2 No issue: extract initVisualCompletenessQueueAndQueueTasks.
This refactor, done entirely by IDE, is a no-op cleanup.
2020-07-21 15:52:34 -07:00
Michael Comella
169071ac61 No issue: extract startMetricsIfEnabled function.
This refactor, done entirely by IDE, is a no-op clean-up of this file.
2020-07-21 15:52:34 -07:00
Jeff Boek
11e2137fab
For #12806 - Adds unit tests to cover ToolbarView.update() (#12807) 2020-07-21 14:34:07 -07:00
Jonathan Almeida
99354174a9 For #12797: Use measured height/width for loading a thumbnail
Using `onNextLayout` has the side-effect of showing the thumbnail with
the tab.id from a recycled view.

The root cause of needing that call is to retrieve the measured
height/width from the view first before requesting. A simpler solution
to avoid the complexity is to retrieve these values from the dimen
resources.

Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2020-07-21 16:38:49 -04:00
Sawyer Blatz
b483067bd9 For #12461: Update content description for tabs tray open tab count 2020-07-21 15:48:38 -04:00
Sebastian Kaspari
96121a79fa Issue #7877: Add SearchActionProvider for faster responses that mirror entered text. 2020-07-21 14:41:00 -04:00
Tiger Oakes
c08d375c18
Move settings in components (#12675) 2020-07-21 10:47:10 -07:00
Mihai Eduard Badea
c3041bcb64 For issue #12387 - Display tab tray using .show
Replaced the global navigation action used for displaying the tab tray with the .show() function.
2020-07-21 10:31:24 -07:00
mcarare
8826f99ef7 For #9722: Refactor onboarding buttons with text.
Add title and description to button text, remove extra Textviews.
2020-07-21 10:28:45 -07:00
Tiger Oakes
0abb2c4f8b Add tests for web push integration 2020-07-21 10:12:06 -07:00
mcarare
9a7154e95e For android-l10n #241: Mark a11y link type as not translatable. 2020-07-21 17:59:17 +03:00
Johan Lorenzo
7e7d69cb8e
Bug 1652979 - Stop producing fennecNightly, fenixNightly and fenixBeta (#12225) 2020-07-21 16:42:08 +02:00
Tiger Oakes
e809df0858 Pass settings and metrics to CFR 2020-07-21 09:01:09 +03:00
mozilla-l10n-automation-bot
80b3b2dd82
Import l10n. (#12766) 2020-07-20 18:26:00 -07:00
Kainalu Hagiwara
02a929a926 No issue - Suppress new warnings from detekt update 2020-07-20 17:01:50 -07:00
Sawyer Blatz
284ec7b58f For #12461: Add tab count to tab tray 2020-07-20 19:16:47 -04:00
Tiger Oakes
f73411b924
For #5499 - Unify CFR drawables and dimens (#12749) 2020-07-20 16:00:57 -07:00
Hakkı Kaan Çalışkan
aeabd3e91b
For #12532: Quick fix for radio button alignment (#12691) 2020-07-20 15:33:32 -07:00
Kainalu Hagiwara
cd2532349d For #12551 - Implement swipe to delete for bookmarks. 2020-07-20 14:54:20 -07:00
Kainalu Hagiwara
313e5abf6a Rename tab_tray_background.xml 2020-07-20 14:54:20 -07:00
Michael Comella
fcb84d940a No issue: correct position of StartupTimeline; add warning. 2020-07-20 14:27:41 -07:00
Sawyer Blatz
445593b719
For #10466: Add search privately to top of list (#12744) 2020-07-20 13:25:36 -07:00
Tiger Oakes
51937e73fc
Closes #10924 - Cleanup SavedLoginsAuthFragment (#10930) 2020-07-20 13:25:24 -07:00
Kainalu Hagiwara
1121d844e6 For #12730 - Fix ripple for font size setting. 2020-07-20 13:00:59 -07:00
Sawyer Blatz
afbb039a08
For #11851: Close tab tray when last tab closed (#12615) 2020-07-20 11:05:32 -07:00
ekager
1dc0ad39f4 For #10784 - Fixes memory leak in BrowserAnimator 2020-07-20 13:50:18 -04:00
Sawyer Blatz
f0c6bc0226
For #12735: Fixes issue with tab deletion undo (#12737) 2020-07-20 10:48:16 -07:00
Hakkı Kaan Çalışkan
3f25a28cf7 For #12554: Helper class for password reveal on logins 2020-07-20 13:45:46 -04:00
mozilla-l10n-automation-bot
c66480d6dd
Import l10n. (#12687) 2020-07-19 21:30:11 -07:00
Christian Sadilek
16b6776938 Update Android Components to 51.0.20200717190031 2020-07-17 19:32:02 -04:00
Tiger Oakes
499f185fc0
Fix lint issues (#12683) 2020-07-17 16:20:08 -07:00
Tiger Oakes
13949d6968
Test migration classes (#12677) 2020-07-17 14:35:13 -07:00
Tiger Oakes
67fda80453
Add tests for login exceptions (#12681) 2020-07-17 14:25:45 -07:00
Mihai Adrian Carare
9c1b586e45
For #7966: Update toolbar content description. (#12667) 2020-07-17 16:22:13 -05:00
Elise Richards
37af9df3ad
For #12532: Align Settings -> Site permissions -> Sub-pages to 72dp keyline (#12680)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-17 15:54:57 -05:00
Mihai-Eduard Badea
1823fdb66d
For issue #9949 - Bookmarks/History deletion inconsistencies (#12630)
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.

 - Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in #8648.

Co-authored-by: Mihai Eduard Badea <mihai.badea@softvision.ro>
2020-07-17 15:13:18 -05:00
Tiger Oakes
eed20b43b9
Test session control controller (#12652) 2020-07-17 13:07:01 -07:00
Hakkı Kaan Çalışkan
aa7655f4d6 For #12509: Set height of remove add on button to 36dp 2020-07-17 12:55:36 -07:00
ekager
455e7b8f99 Update ContextMenuUseCases to just take a store 2020-07-17 14:49:10 -04:00
ekager
e1ef5f55ec For #12453 - Sets secure flags on private tab of tabs tray 2020-07-17 13:24:25 -04:00
ekager
e358f95eed For #12364 - Only show PWA prompt the third time a user visits installable site 2020-07-17 12:37:03 -04:00
Tiger Oakes
ac3df6bc5e
Add tests for adapters in collections (#12649) 2020-07-17 09:04:16 -07:00
Kainalu Hagiwara
2fe17a6220
For #12531: Align Settings -> Private browsing to 72dp keyline (#12654)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-16 22:26:49 -07:00
Elise Richards
023a4983fa
For #10173: login duplicates and save (#11208)
* Extract controller into it's own class. Implement find dupes and filter based on username.

Create edit login controller. Add text watchers and check for duplicates.

Edit controller test

* Find duplicates and save to store

* Retrieve duplicates from AC and check list on username text changed

Move duplicates logic into the controller

* Add glean pings for delete and edit. Move logic for login manipulation into the datastore.

* Use correct threads in controller. Enable save button when applicable.

Save enabled in datastore.

Move login data to datastore

Rebase with password error states

Update metrics to be more specific for edit

* Create logins controller for AC calls

* Interactor and controller methods for edit login. Add edit view to separate out some layout manipulation.

Inflate view in edit fragment. Double layout showing up.

Edit view

Controller tests

Controller tests passing

Interactor tests

Lint and detekt cleanup

* Remove datastore and use storage controller for all logins calls to password storage.

Addressed comments

Lint
:

Rebase - 1
2020-07-16 17:08:04 -05:00
Mugurell
e1fc0cc038
Ensure logins deletion (#12507)
* For #11227 - Cleanup saved logins list when one is selected

Selecting a saved login will open a detail screen for it from where users can
change details or even delete that particular login.
After the change is made the user is brought back to the list of saved logins
where for a brief moment (< 1s) until we get a new response from
passwordsStorage.list() the user can see and even interact with the old list
of items, which may still contain the just deleted one.

To avoid users seeing obsolete logins or even interacting with them (selecting
a previosuly deleted item will result in a crash) we will clean the list of
logins just before the selected login is opened in the detailed view.
When returning for a brief moment the users may see the "loading" UX until
passwordsStorage.list() returns the up-to-date list of logins to display.

* For #11227 - Refactor SavedLoginsView to be closer to MVI

- Interactors should only get passed other Interactors or Controllers as
dependencies to which they should delegate user actions.
- Controllers should hold most of the business logic and get passed all final
dependencies they need to do their job.
2020-07-16 14:40:08 -05:00
Tiger Oakes
2d066d77ad
Add tests for sync, wifi, and push (#12581) 2020-07-16 12:25:38 -07:00
Tiger Oakes
2291fb07aa
For #12565: Add Locale settings tests & use activity (#12579) 2020-07-16 11:43:27 -07:00
jhugman
3373f8b987
For #12600 - remove AddonInstalled event when the permission dialog is shown (#12601) r=csadilek,sblatz 2020-07-16 19:40:39 +01:00
Mihai Branescu
9373e7fcf4
For #12201 - forced callbacks to be on the main thread (#12543) 2020-07-16 13:39:31 -05:00
Elise Richards
4fe1fb8f4a
No issue: Delete unnecessary to-dos (#12603)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-16 13:38:07 -05:00
Hakkı Kaan Çalışkan
b997fba953 No issue: Move dp's to dimens.xml 2020-07-16 13:08:55 -04:00
Kainalu Hagiwara
b867e0de45 Update TabTrayViewHolder with A-C thumbnail changes. 2020-07-16 12:50:33 -04:00
Roger Yang
7923255fda For #12118: Add isSubframeRequest parameter for app links 2020-07-16 12:50:33 -04:00
Christian Sadilek
a0d9cdc450 For #12248: Webcompat reporter not active in Nightly 2020-07-16 12:24:21 -04:00
jhugman
fb1d7e12e6
For #11704 Add leanplum attributes for tracking protection (#11965) r=sblatz
* For 11657: add LP attribute for tracking protection

* For #11704: added tracking_protection_enabled attribute

* Added docs for the new attributes, linking to data-review to the mma.md

* Rename null to none when no ETP is enabled
2020-07-16 17:09:32 +01:00
Hakkı Kaan Çalışkan
cdd5d206fd For #12105: Follow ux mock on Settings --> Accessibility screen 2020-07-16 10:37:20 -04:00
James Hugman
798c1bf743 Address review comments 2020-07-16 10:37:03 -04:00
James Hugman
22689a9ff5 Remove need to specify component names for new intents 2020-07-16 10:37:03 -04:00
James Hugman
98a33ea82b Changed home_* style links to urls_* to reflect that the destination is a set of links, rather than where the screen is 2020-07-16 10:37:03 -04:00
James Hugman
1629878a66 Add install_search_widget 2020-07-16 10:37:03 -04:00
James Hugman
8130aaa2cc Add deep links for settings and home screens 2020-07-16 10:37:03 -04:00
Mugurell
d449184faa For #12544 - Prevent search engines mixup
Stricter synchronization by always using the same "loadedSearchEngines"
variable.
With "loadedSearchEngines" calling "refreshAsync()" we also get the fallback
engines to contain reddit and youtube (which are programatically added) and
also now we properly remember and display the engines added by user.
2020-07-16 16:49:54 +03:00
Tiger Oakes
6be39aebde
Add tests for StartupReportFullyDrawn (#12560) 2020-07-15 23:31:59 -07:00
Tiger Oakes
d4bb432e24
Add helper for underlining text (#12520) 2020-07-15 22:38:46 -07:00
Tiger Oakes
a0491b702e
Fix nav graph and theme tests (#12567) 2020-07-15 18:04:36 -07:00
Tiger Oakes
d0e9f1f165
Update Kotlin dependency (#10806) 2020-07-15 18:02:58 -07:00
mcarare
800702149b For #12503: Open addon permissions link in app. 2020-07-15 10:04:40 -04:00
ekager
9ed85510ae For #7094 - Adds save login exceptions 2020-07-14 14:47:37 -04:00
Tiger Oakes
69020a1f26
For #12457 - Add MockK matcher for nav directions (#12262) 2020-07-14 10:39:23 -07:00
Tiger Oakes
1ff64cab67
Add tests for search (#12437) 2020-07-14 10:32:04 -07:00
Tiger Oakes
e9fb1a61c7
Test viewholders in home.sessioncontrol (#12524) 2020-07-14 10:31:50 -07:00
Hakkı Kaan Çalışkan
f424656575 For #12107: Follow ux mock on Settings --> Account screen 2020-07-14 12:25:21 +03:00
Mozilla L10n Automation Bot
07e01c5b86 Import l10n. 2020-07-14 11:40:19 +03:00
ekager
88af736065 For #11099 For #12189 For #7532 - Clean up bottom navigation bar colors 2020-07-13 13:46:35 -04:00
Sawyer Blatz
98ad7ace49 For #10466: Put call & email at top of context list 2020-07-13 10:33:55 -07:00
Hakkı Kaan Çalışkan
ca30fef579 For #12106: Follow ux mock on Settings --> Logins screen 2020-07-13 11:14:32 -04:00
Mugurell
ea10d2a872 For #11875 - Prevent mixup of region / locale based search engines
We have two search engine types:
- one based on MLS reported region,
- one based only on Locale.

There are multiple steps involved in returning the default search engine for
example and though at each step we could verify if a certain operation is
completed we are still exposed to concurrency issues.
Simplest and most effective way to make sure the MLS engines do not mix with
Locale based engines is to use the same type of engines for the entire duration
of the app. At the next cold start we'll verify again which engines to use.

Using the Locale based engines (fallbacks) is expected to only happen once, at
the first run of the application after being installed.
2020-07-13 13:41:34 +03:00
Mozilla L10n Automation Bot
ca352c555b Import l10n. 2020-07-13 07:59:10 +03:00
jhugman
9df13ae121
For #11655: add leanplum event for installing an addon (#12136) r=elise
* For #11655: add leanplum event for installing an addon

* Add link to data-review request in PR

* Addressed CI comments
2020-07-12 23:47:34 +01:00
Grisha Kruglov
31248b835c Synced Tabs: make sure to stop 'loading' when we encounter an error 2020-07-10 19:02:55 -07:00
ekager
0add94e353 For #11324 - Adds trash icon to swipe to delete 2020-07-10 20:16:57 -04:00
Nazım Can Altınova
7319f77114 Add profiler markers for HomeActivity.load and DefaultTabTrayController.onNewTabTapped 2020-07-10 16:43:06 -07:00
Sawyer Blatz
5d9fdd6266 Update app/src/main/java/org/mozilla/fenix/HomeActivity.kt
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
2020-07-10 18:44:14 -04:00
Sawyer Blatz
bab0f9d95b No issue: Update AC version 2020-07-10 18:44:14 -04:00
Mihai Eduard Badea
9aab1d1678 For issue #12339 - Collection delete dialog string update
Set the collection delete dialog title text to "Delete %1$s?"
2020-07-10 11:38:39 -04:00
Mozilla L10n Automation Bot
c3b06374a1 Import l10n. 2020-07-09 21:39:49 -04:00
Grisha Kruglov
806f6031ae For #12433 - Allow synced tabs pull-to-refresh for non-critical account errors 2020-07-09 16:18:54 -07:00
ekager
ad265be672 For #11303 - Change copy login origin to open in browser 2020-07-09 18:09:41 -04:00
Tiger Oakes
c99a8f5cfa
Fixes #9832 - Change targetSdkVersion to Android 10 (#11014) 2020-07-09 10:50:51 -07:00
Emily Kager
63eb7b3e4e
For #12010: Follow ux mock on Settings --> ETP --> Info screen (#12429)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-09 09:47:09 -07:00
Sebastian Kaspari
a2a7b11425 Issue #12311: BrowserToolbarController: Stop SessionFeature and release session from EngineView. 2020-07-09 12:36:56 -04:00
Mozilla L10n Automation Bot
cba27a3883 Import l10n. 2020-07-09 11:29:38 -04:00
David Walsh
85cebf8796 For 11889 - Fix snackbar for collection creation in browser fragment 2020-07-09 08:50:12 +03:00
mozilla-l10n-automation-bot
6f49e08725
Import l10n. (#12404) 2020-07-08 18:56:37 -07:00
Hakkı Kaan Çalışkan
d76d8d1881 For #11563: Set ic_close.xml to use full width and height 2020-07-08 17:21:25 -04:00
ekager
38657bbfc6 For #11431 - Scroll to restored tab in tab tray 2020-07-08 17:18:16 -04:00
Christian Sadilek
216396d979 For #12353: URL copied to clipboard should not be extension/reader URL 2020-07-08 16:55:32 -04:00
Tiger Oakes
9ae1aa6f16 Add tests for exceptions 2020-07-08 15:52:37 -04:00
MickeyMoz
236b981881 Update Android Components version to 50.0.20200708130551. 2020-07-08 12:44:51 -04:00
Tiger Oakes
67ce5ad5d9
Add tests for onboarding viewholders (#11522) 2020-07-08 07:53:22 -07:00
Tiger Oakes
720a590902
Add tests for browser helper classes (#12370) 2020-07-07 19:46:25 -07:00
Mozilla L10n Automation Bot
bedd1d452c Import l10n. 2020-07-07 21:27:37 -04:00
Christian Sadilek
27c608d956 Update built-in extensions for new AC/GV API
New API (installBuiltIn/ensureBuiltin) requires
- Gecko IDs and new permissions
- Extension will only be re-installed if it has a new version

This includes a gradle task to automatically generate a
new version in manifest.json for every build so we don't
forget to update the version and end up with changes that
are never applied.
2020-07-07 18:41:12 -04:00
amkcpu
fab64229a5 Closes #11873 - Add scrollbar in tabs tray 2020-07-07 17:50:56 -04:00
ekager
bceb07a05b For #12312 - Disable settings that navigate while authenticating 2020-07-07 16:46:14 -04:00
Michael Comella
3e617245b5 For #12345: catch SecurityException when calling reportFullyDrawn.
That's amazing! I've got the same combination on my luggage.
2020-07-07 13:44:09 -07:00
Tiger Oakes
65637e9e2b
Use A-C version of Resources.getSpanned (#12358) 2020-07-07 13:36:29 -07:00
Mihai Eduard Badea
eeb8719fa1 For issue #12126 - Tab counter consumeFrom update
Added a direct call to the updateTabCounter method to account for changes made to the BrowserState while the tabCounter view is not visible.
2020-07-07 11:12:55 -04:00
Mozilla L10n Automation Bot
f838049e97 Import l10n. 2020-07-07 11:12:02 -04:00
Tiger Oakes
8e8e5aea36
Extract radio group logic into helper (#11493) 2020-07-06 17:09:42 -07:00
ValentinTimisica
e39d5b6de7 For #11763: Shows confirmation dialog when deleting last tab from collection 2020-07-06 17:06:10 -04:00
ValentinTimisica
c3acde438a For #11889: Changes collection creation confirmation snackbar strings
Also I changed the adding tabs to collection confirmation string from
tabtray to take into account the number of tabs.
Example: 1 tab-"Tab saved!"; multiple tabs-"Tabs saved!"
2020-07-06 17:02:02 -04:00
Tiger Oakes
1ab5fe3eb9
Add method to test fragments in roboletric (#12261) 2020-07-06 13:04:43 -07:00
Hakkı Kaan Çalışkan
426a1ba57d For #12078: Follow ux mock on Settings --> Language screen 2020-07-06 15:47:42 -04:00
mcarare
9bc4f443f5 For #9775: Increase touch target of elements in add search engine screen 2020-07-06 15:47:25 -04:00
ekager
170ae1aa33 For #12263 - Adds end margin to synced tabs header 2020-07-06 15:37:53 -04:00
Hakkı Kaan Çalışkan
331090d1e6 For #12007: Fix add search engine items using wrap content for height 2020-07-06 15:37:28 -04:00
Hakkı Kaan Çalışkan
296bdc5967 For #12016: Follow ux mock on Settings --> Data Collection 2020-07-06 15:27:46 -04:00
Emily Kager
90f43bf350
For #12086: Follow ux mock on Settings --> Customize screen (#12324)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-06 12:25:54 -07:00
MickeyMoz
da39a7e671 Update Android Components version to 49.0.20200705130154. 2020-07-06 15:21:40 -04:00
mcarare
94273bc274 For #12125: Handle visibility updates for add to collection button. 2020-07-06 14:37:39 -04:00
Mozilla L10n Automation Bot
2668a68678 Import l10n. 2020-07-06 14:06:24 -04:00
ekager
822d50192a For #12316 - Allow text wrap on buttons 2020-07-06 20:56:54 +03:00
Tiger Oakes
fd18687ac9 Switch to any calls 2020-07-06 20:38:08 +03:00
Tiger Oakes
41452e945b Move SearchProviderModel extension to class 2020-07-06 20:38:08 +03:00
Mugurell
0fb6bbc175 For #10401 - Hide Shortcuts if just one search engine is installed
Otherwise, the Shortcuts option which allows to choose with what search engines
to search would be redundant.
2020-07-06 14:36:04 +03:00
Sebastian Kaspari
388c144a62 SearchFragmentStore: Remove Session reference from state and read values from BrowserStore. 2020-07-03 21:01:59 +02:00
ekager
f863c341e8 Updates AC to 49.0.20200702190156 and fixes breaking changes 2020-07-03 06:40:06 -04:00
ekager
8533d96ee2 For #11320 - Expose login autofill setting to beta dimension 2020-07-03 06:40:06 -04:00
liuche
6ec0aeb843
Issue #12207 - Update "new nightly" link to point to org.mozilla.fenix (#12209) 2020-07-02 12:39:44 -07:00
Sawyer Blatz
8583cac8f8 Revert "For #11183: Redirect user to homescreen after widget added"
This reverts commit a8ed913654.
2020-07-02 11:22:18 -07:00
Sawyer Blatz
3cbab45566 For #12157: Don't show two search widget dialogs 2020-07-02 11:22:18 -07:00
mozilla-l10n-automation-bot
321ba02832
Import l10n. (#12175) 2020-07-02 08:29:18 -07:00
liuche
ad8e28ae02
For #12007: Follow ux mock on Settings --> Search screen (#12177)
Co-authored-by: Hakkı Kaan Çalışkan <caliskanhkaan@gmail.com>
2020-07-02 00:48:31 -07:00
Tiger Oakes
ed3a80a756
For #12095: Remove TWA feature flag (#12096) 2020-07-01 19:14:41 -07:00
Mihai Adrian Carare
daecbd348b
For #11996: Open all links from add-on details in Fenix. (#12080)
* For #11996: Open add-on homepage link in Fenix.

* For #11996: Open add-on details links in Fenix.
2020-07-01 19:13:23 -07:00
Sawyer Blatz
306505fee0
No issue: Remove feature flag for tips (#12172) 2020-07-01 14:47:40 -07:00
Johan Lorenzo
4bc1cb94c5
Bug 1649400 - part 1: ship org.mozilla.fenix as a nightly product (#12127) 2020-07-01 11:03:10 +02:00
Mozilla L10n Automation Bot
d17e91cc2e Import l10n. 2020-07-01 08:48:18 +03:00
Jeff Boek
fb4822498f For #12081 - Properly installs searchengines when MLS completes 2020-06-30 13:35:08 -07:00
Mozilla L10n Automation Bot
7b3fe9bab4 Import l10n. 2020-06-30 10:25:21 +03:00
Tiger Oakes
50c3c9a9dd
Fix ignored XML lint issues (#12094) 2020-06-29 16:36:52 -07:00
ekager
70f90e71e8 For #11991 - Show tab count during onboarding 2020-06-29 17:59:19 -04:00
Tiger Oakes
6bde0378a2
Add tests for StrictModeManager (#12013) 2020-06-29 08:17:07 -07:00
Mozilla L10n Automation Bot
f77bfdc2f2 Import l10n. 2020-06-28 20:41:02 -04:00
Mozilla L10n Automation Bot
a07f31375e Import l10n. 2020-06-28 09:59:49 -04:00
ekager
60069395eb Update AC to 48.0.20200627130132 and fix breaking changes 2020-06-27 20:11:31 -04:00
Mihai Eduard Badea
e0fa1c0db4 For issue #11835 - Update text fonts
Updated the fonts and colors for several texts throughout the application.
2020-06-26 23:18:52 -04:00
Tiger Oakes
ed334788e8 For #11903: Enforce private theme in custom tabs 2020-06-26 22:59:43 -04:00
Jeff Boek
b1a8c0f483 For #9935 - Use the searchengine deferred 2020-06-26 19:07:36 -07:00
Jeff Boek
40977a93a0 For #9935 - Fallback region selection on first load 2020-06-26 19:07:36 -07:00
Michael Comella
5ef6b49aa1
For #8795: remove redundant ConstraintLayout around BrowserToolbar. (#12014)
This is functionally equivalent to the code before this patch but should
be slightly more performant in theory because ConstraintLayout is
expensive to inflate.

The elevation and layoutParams set dynamically appeared to have no effect
with the wrapping view but broke the view when used by itself so I had
to remove them. I also updated a few other unnecessary params.

Theoretically this may have some perf benefits but I didn't see anything
outside noise levels after I took the numbers (but I didn't try very
hard).
2020-06-26 21:31:02 -04:00
David Walsh
c4a4beb6b9 For 11468 - Show tab tray after opening links from history and bookmarks 2020-06-26 18:28:31 -07:00
Kate Glazko
2ac8496315 For #12025: Set Search Shortcuts Off By Default 2020-06-26 18:21:58 -07:00
Jeff Boek
a18c1befd1
For #11044 - Sets the anchorView of the snackbar to be the new tab fab (#11930) 2020-06-26 17:56:56 -07:00
Jonathan Almeida
f89b157c23
For #12002: Show default tab background when thumbnail not available (#12041) 2020-06-26 20:46:23 -04:00
Sachin
4b9cc954fa
for #11830 added new metric for collecting startup method from all startup phases (#11940)
* for #11830 added new metric for collecting startup method

move all source startup telemetry into its own logic and added an UNKOWN state

* switched back to onNewIntent solution

* renamed the metric
2020-06-26 17:38:08 -07:00
Sawyer Blatz
61b1b5a895
No issue: update experiments when experiments updated (#12032) 2020-06-26 17:19:58 -07:00
Sawyer Blatz
8a08cb941e
For #11479: Record open tabs count in metrics ping (#12024) 2020-06-26 17:15:43 -07:00
MarcLeclair
c6415ce18f
For 11616: removed black flicker with placeholder animation (#11796)
Increasing duration removed second "light" flicker
2020-06-26 20:10:22 -04:00
Jonathan Almeida
b7d989a588 Fix breaking API in WebNotificationFeature 2020-06-26 19:59:57 -04:00
Marc Leclair
ff5d00362b Added A-C version 48.0.20200626213814 2020-06-26 19:59:57 -04:00
Sawyer Blatz
101ecfbf66
For #11273: Add tabs tray telemetry (#12036) 2020-06-26 16:37:07 -07:00
Tiger Oakes
7287b5579f
Test settings about/advanced (#12023) 2020-06-26 15:53:30 -07:00
mozilla-l10n-automation-bot
e71e7fb9c6
Import l10n. (#12022) 2020-06-26 15:44:57 -07:00
Tiger Oakes
4f6f0785c5
For #11943: Fix intermittent coroutine failure (#12027) 2020-06-26 15:42:53 -07:00
ekager
df49db6adb For #11294 - Enable Synced Tabs for all builds 2020-06-26 18:36:37 -04:00
Hakkı Kaan Çalışkan
2cbd969e34 For #11641: Update synced tabs view 2020-06-26 18:11:13 -04:00
Gabriel Luong
e6a56aec36
For #12026 - Update default top sites for new users (#12028) 2020-06-26 17:51:18 -04:00
Grisha Kruglov
f8cb1d6b48 Closes #11909: Metrics for recording number of recently used PWAs 2020-06-26 14:13:41 -07:00
Elise Richards
eeabcb10ff
Fix illegal arguments for onboarding keys (#12033) 2020-06-26 16:12:18 -05:00
Tiger Oakes
bcb2ef10ac
Add tests for PhoneFeature (#12021) 2020-06-26 12:12:52 -07:00
MarcLeclair
f3b44c06e4
For #11841: Removed topsite bug on private browsing (#12020) 2020-06-26 14:54:20 -04:00
Gabriel Luong
005ad6ff2a
Update Android Components version to 48.0.20200626130049. (#12006)
Co-authored-by: MickeyMoz <sebastian@mozilla.com>
Co-authored-by: Gabriel Luong <gabriel.luong@gmail.com>
2020-06-26 14:16:57 -04:00
Tiger Oakes
80de3851f3
Add tests for OnSharedPreferenceChangeListener (#12019) 2020-06-26 11:04:46 -07:00
mcarare
64947a8686 For #10285: Swap TextView for a LinkTextView to improve links a11y 2020-06-26 18:11:11 +03:00
ValentinTimisica
9f5c8819d3 For #11892: Remove dynamic calls to setupNavigationToolbar
This is a speculative fix for 11892 crash.
The side effect is that the back button will be visible in bookmarks root.
2020-06-26 07:54:11 -04:00
Mihai Branescu
93247e0b2f For #9425 - SearchFragment now reacts to undo operation for base engines 2020-06-26 13:21:00 +03:00
Mihai Branescu
e6e3166d2d For #9425 - SearchFragment now reacts to undo operation for custom engines
When you remove a search engine from our list, an undo snackbar that outlives the fragment is shown. If you go back to the search fragment and press undo, now the shortcut list gets updated
2020-06-26 13:21:00 +03:00
Mihai Branescu
46c1c130da For #9425 - Handle undo for custom search engines
On undo, get the template that the user entered for that engine and then
re-add it to the `CustomSearchEngineStore`
2020-06-26 13:21:00 +03:00
Sawyer Blatz
c5034fa770 No issue: Allow us to run experiments on nightly if needed 2020-06-26 09:16:38 +03:00
mcarare
0626384baf For #10285: Swap TextView for a LinkTextView to improve a11y. 2020-06-26 09:15:44 +03:00
mcarare
216da0c64b For #10285: Add a custom TextView for links with a11y improvements. 2020-06-26 09:15:44 +03:00
mozilla-l10n-automation-bot
ebd9efc769
Import l10n. (#11981) 2020-06-25 18:03:19 -07:00
Kainalu Hagiwara
b84f55c980 For #11677 - Adjust tab counter menu item order. 2020-06-25 15:48:10 -07:00
person808
ad90625b48 For #2165 - Add swipe to refresh gesture to bookmarks view. 2020-06-25 14:50:24 -07:00
Christian Sadilek
64440409b0 For #9100: Follow-up to fix memory leak in NotificationSessionObserver
The observer was moved and is now bound to the activity and its
context. If the activity is re-created we leak the observer and
therefore the activity itself.

With this we make sure to stop the observer and also don't use
the activity context to begin with.
2020-06-25 16:17:38 -04:00
ekager
c77ddd8d26 For #11866 - Update back press logic for SearchFragment 2020-06-25 14:40:31 -04:00
Christian Sadilek
7be56ce4fa For #11798: Allow sharing of reader view pages 2020-06-25 14:39:21 -04:00
Sawyer Blatz
04aee11d82
For #9625: Add telemetry for Tracking Protection CFR (#11923) 2020-06-25 11:24:55 -07:00
Elise Richards
665fb8d60c
#10824: Onboarding telemetry (#11867)
* Onboarding events and tracking

* Rename metrics for consistency

* Add reference to PR for the data review

* Add default values to onboarding events
2020-06-25 13:21:31 -05:00
Sawyer Blatz
2d65faf232
For #11392: Rename Installation ping to FirstSession (#11869) 2020-06-25 10:06:26 -07:00
ekager
d3de9e517e Remove ThumbnailsUseCases 2020-06-25 12:51:18 -04:00
Tiger Oakes
c958cc048a Update customtabs service 2020-06-24 23:26:49 -04:00
Sawyer Blatz
13c8abe3dc For #11613: Expand toolbar onUrlChanged 2020-06-24 21:50:06 -04:00
Mihai Branescu
be5213e944 For #11727 - added content description 2020-06-24 21:42:38 -04:00
Hakkı Kaan Çalışkan
9068c96ab3 don't animate unnecessarily
Fixes #11672, #11727: Empty default tab text and add padding to infinite character

Fixes #11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily

don't animate unnecessarily

Fixes #11739: Fix flicker

Update TabCounter.kt

squash commits

don't animate unnecessarily

Fixes #11672, #11727: Empty default tab text and add padding to infinite character

Fixes #11739: Fix flicker

Update TabCounter.kt

make lint happy

don't animate unnecessarily
2020-06-24 21:42:38 -04:00
Hakkı Kaan Çalışkan
3dc6c438f4 Fixes #11739: Fix flicker 2020-06-24 21:42:38 -04:00
Hakkı Kaan Çalışkan
b95804c33b Fixes #11672, #11727: Empty default tab text and add padding to infinite character 2020-06-24 21:42:38 -04:00
Sawyer Blatz
a8ed913654 For #11183: Redirect user to homescreen after widget added
Co-authored-by:  hakkikaancaliskan <caliskanhkaan@gmail.com>
2020-06-24 21:41:42 -04:00
David Walsh
77ed670558 For #11860 - Conditionally show add to collection button on Home screen 2020-06-24 21:41:19 -04:00
mcarare
7b20bb9976 For #11562: Align overflow menu button with close buttons. 2020-06-24 21:40:57 -04:00
mcarare
4aaa54c994 For #11880: Provide default text color for errors in a TextInputLayout 2020-06-24 21:40:10 -04:00
Sawyer Blatz
872c179cf4 For #11825: Removing the last pretty animation 😞
Goodbye, sweet summer child.
2020-06-24 21:38:28 -04:00
mcarare
a056e86e4f For #8080: Dismiss menu when swiping away from its anchor. 2020-06-24 21:37:57 -04:00
mcarare
b961fdcf02 For #11901: Use safe call for collection item info. 2020-06-24 21:37:24 -04:00
Mihai Branescu
49b617c999
For #9100 - Private browsing notification fixes
Co-authored-by: Seef <Saif Dara>
2020-06-24 21:35:11 -04:00
Mihai Branescu
632b64971f For #10467 - removed unused tests and resources related to blue dot notification 2020-06-24 21:33:32 -04:00
Mihai Branescu
3c2c7f705c For #10467 - blue dot doesn't disappear on menu dismiss 2020-06-24 21:33:32 -04:00
Tiger Oakes
0b781ae3b7 Add tests for collection creation controller 2020-06-24 21:21:02 -04:00
Jeff Boek
177e7a400f For #11406 - Scrolls to selected tab when switching modes 2020-06-24 21:16:48 -04:00
Jeff Boek
2c39d3ebca For #11430 - Gives enough padding to the tab tray give adequate space for the fab 2020-06-24 21:16:24 -04:00
Mozilla L10n Automation Bot
fe023e1a74 Import l10n. 2020-06-24 21:16:07 -04:00
Tiger Oakes
4415702fa8 Add tests for share sheet 2020-06-24 20:33:47 -04:00
Tiger Oakes
183ba1bce0 For #11903: fix custom tab private gradient 2020-06-24 20:33:16 -04:00
ekager
f39313d908 For #8374 - On external session removed, handle back press 2020-06-24 20:17:26 -04:00
Tiger Oakes
ce31a620d5 Minify XML path 2020-06-24 14:05:44 -04:00
person808
5f7e0e4dd6 Followup for #11442 - Add tab counter menu metrics to home fragment. 2020-06-24 10:20:51 -07:00
mozilla-l10n-automation-bot
673507d9b3
Import l10n. (#11870) 2020-06-23 19:02:50 -07:00
Tiger Oakes
9a8b800a76 For #8621 - fix intermittent test failures 2020-06-23 17:43:24 -04:00
Jeff Boek
621da0c4c1
For #9935 - Adds fallback searchengine provider for long MLS lookups (#11863) 2020-06-23 14:00:18 -07:00
mcarare
fe97dc9d2e For #11542: Update tabs positions in tab tray reported by screen readers 2020-06-23 11:28:24 -07:00
ekager
06e6cfa696 For #5636 - Unregisters wifiConnectedListener when setting changes, sets default blocked 2020-06-23 12:28:52 -04:00
Jeff Boek
8ce7cf59c8
For #11261 - Dismisses menu when rotating to landscape (#11845) 2020-06-23 10:50:20 -05:00
Jeff Boek
1cc259169d For #11042 - Make it slightly harder to accidently dismiss the tabs tray 2020-06-23 08:19:00 -07:00
Jeff Boek
2861421312 For #11112 - Adds save tabs to collection button to the no collections message 2020-06-23 08:17:55 -07:00
Mozilla L10n Automation Bot
dc36c9a6b5 Import l10n. 2020-06-22 22:08:59 -04:00
Tiger Oakes
ccb532bb77
For #11534 - Don't check lastUsed mode for screenshots (#11827) 2020-06-22 17:38:58 -07:00
ekager
761d253f59 For #8649 - Fixes overlapping bookmark sign in button 2020-06-22 18:19:47 -04:00
Jeff Boek
c7b1f215c8
No Issue - Fixes flash when toggling tab tray (#11826) 2020-06-22 16:49:07 -05:00
Tiger Oakes
18cc4c95c1
Add tests for ContextKt (#11824)
Migrated from an old branch by Kate

Co-authored-by: Kate Glazko <katglazko@gmail.com>
2020-06-22 14:00:43 -07:00
Hakkı Kaan Çalışkan
c8d36ddc36 For #8649: No bookmarks here strings are close to the top 2020-06-22 16:04:20 -04:00
ekager
88765c348b Update A-C version, add synced tabs empty state 2020-06-22 15:13:13 -04:00
mcarare
721e290734 For #10049: Provide correct seek bar value to screen readers. 2020-06-22 13:58:33 -04:00
mcarare
00862708ae For #10551: Increase touch target for link. 2020-06-22 13:58:02 -04:00
ValentinTimisica
c75ab3f720
For #10462: Removes back button from bookmarks and history fragments (#11721) 2020-06-22 13:15:33 -04:00
ekager
635c30510d No issue: refactor tabs tray to use interactor/controller, add tests 2020-06-22 13:01:35 -04:00
Mugurell
0ba1d266b3 For #9144 - Ignore previous Intent if activity is started from Recents
We'll now clearly differentiate between cold / hot starts of HomeActivity.kt.
This is needed because Android will resend the original Intent which initially
started the Activity whenever it is restarted from the Recents Screen if the
activity is already destroyed at that time. So in the event that the activity
was before started with an Intent to open a webpage for example whenever the
activity is restarted from Recents it will receive the same Intent to open a
webpage even though that Intent has already been consumed.

Activity's onCreate() will only use the intent processors when the activity is
cold started so that we'll only initially act upon Intents configured for
different behaviors inside the app.
If the activity is destroyed while in background and opened from Recents it
will not act upon the original Intent which is now resent by Android.

Activity's onNewIntent() will be called to act upon a new Intent if the
activity is hot started since we are declared as singleTask and it now has the
responsibility to delegate various intent processors to consume that Intent.
2020-06-22 12:08:24 -04:00
ValentinTimisica
0b57f5e71b Fixes #10551: Removes the increased touch target for learn more link 2020-06-22 16:40:15 +03:00
Mihai Eduard Badea
eb45b37207 For issue #10727 - Hide saved logins details
Removed the clearFlags call from the HomeActivity that was causing this issue and removed the now redundant call to update the flag from the redirectToReAuth method
2020-06-22 13:19:02 +03:00
ValentinTimisica
e9bb11e22d Fixes #9205: Changes add-ons and 'Open links in apps' icons from menus 2020-06-22 12:09:19 +03:00
Mozilla L10n Automation Bot
b635af8244 Import l10n. 2020-06-21 21:40:24 -04:00
Sachin
988513aa89
for #10568 moved awesomebar and toolbar into fragment_search (#11744) 2020-06-21 14:56:49 -07:00
Sachin
9269a53b21
for #11615 allowed strictMode disk read for violations made by the OS. (#11658) 2020-06-21 14:54:49 -07:00
Mozilla L10n Automation Bot
56ff4e4797 Import l10n. 2020-06-20 08:57:51 +03:00
Antti Vainikka
cb129231ae Closes #11500: Remove wrong activity title 2020-06-19 18:17:35 +03:00
ValentinTimisica
3ad7795a2d Fixes #11134: Removes margin to allow collection title to expand 2020-06-19 17:27:57 +03:00
mcarare
a0fe1a452a For #11756: Fix bottom toolbar preference reference. 2020-06-19 11:20:08 +03:00
mcarare
4bebc56c50 For #9229: Remember options for delete browsing data. 2020-06-19 09:32:37 +03:00
mcarare
e7bc266578 For #11665: Adjust visual design for delete browsing data screens. 2020-06-19 09:32:37 +03:00
mozilla-l10n-automation-bot
99f1f6732a
Import l10n. (#11752) 2020-06-18 19:49:18 -07:00
MarcLeclair
b52091ed34
For #11660: added prefetch for topsites and update in onCreateView() (#11668)
* For #11660:added prefetch for topsites

TopSites will be prefetched with observerOnce (wrapper around observerForever).
Also, the SessionControlView.update() is called right away instead of waiting from consumeFrom
in the HomeFragment.onCreateView() which will allow the UI to render all at once on its first
perform traversal

* Removed the submitList(null) since it retriggered a drawing on lower end device
2020-06-18 19:43:20 -04:00
Emily Kager
44ff29bdc0 Revert "For issue #9949 - Bookmarks/History deletion inconsistencies"
This reverts commit 3feab90b19.
2020-06-18 19:31:49 -04:00
ekager
df63c5a4bc For #11708 - Remove setMargins in CustomTabsIntegration 2020-06-18 17:02:34 -04:00
Jeff Boek
82cbafabaf
For #11625 - Fixes tab tray staying open when opening from another app (#11740) 2020-06-18 12:32:14 -05:00
mcarare
5f1c9449f3 For #8114: Restore normal UI when a library fragment is detached. 2020-06-18 17:42:06 +03:00
Tiger Oakes
c503798cd6 Replace PhoneFeature.getPreferenceKey 2020-06-18 09:02:58 -04:00
Tiger Oakes
596c579bbb Replace nullable findPreference 2020-06-18 09:02:58 -04:00
Tiger Oakes
45ef88f6b9 Replace requireNotNull(findPreference()) 2020-06-18 09:02:58 -04:00
Tiger Oakes
3e03439259 Add requirePreference helper 2020-06-18 09:02:58 -04:00
codrut.topliceanu
0eb2f328dc For #11371 - Fix for Dynamic Download Dialog 2020-06-18 09:00:55 -04:00
Mozilla L10n Automation Bot
d009b106dc Import l10n. 2020-06-18 11:18:34 +03:00
Mihai Eduard Badea
0ce4aa1e60 For issue #10764 - Onboarding toggle color
- Removed the theme from the toggle so that the default colors from the themes are used instead
2020-06-18 10:16:36 +03:00
MarcLeclair
5f7bb68a51
For #11666: TopSites layout from Constraint to Linear (#11669) 2020-06-17 19:18:14 -04:00
Hakkı Kaan Çalışkan
56b00d0625 For #11456: AddonDetailsFragment should use ConstraintLayout, not RelativeLayout 2020-06-17 15:51:29 -04:00
David Walsh
3feab90b19 For issue #9949 - Bookmarks/History deletion inconsistencies
- Added the undo action for deleting individual history items by creating a new field to the history state containing the id's of the history items that are pending for deletion; This field is used inside the update function from the view to show/hide the items.

 - Added a new check inside the "deleteMulti" method from BookmarkFragment that calls the showRemoveFoldersDialog to prevent the user from being able to delete one or more bookmark folders without being asked for confirmation, as in #8648.
2020-06-17 14:42:51 -04:00
Tiger Oakes
f6efb386d6 Add tests for addon details 2020-06-17 14:38:50 -04:00
Mugurell
fb505ed0d4 For #1871 - BrowserMenu minWidth will be 112dp.
Following user requests and UX recommendations we'll have all menus have a
dynamic width between 112dp and 314dp, automatically wrapping the widest
element.
2020-06-17 12:17:59 +03:00
Mozilla L10n Automation Bot
7e3795242c Import l10n. 2020-06-17 11:10:19 +03:00
Hakkı Kaan Çalışkan
8cbdce58e6 Update FxaServer.kt 2020-06-16 23:30:57 -04:00
Hakkı Kaan Çalışkan
670e03c3b2 Update app/src/main/java/org/mozilla/fenix/components/FxaServer.kt
Co-authored-by: Tiger Oakes <contact@tigeroakes.com>
2020-06-16 23:30:57 -04:00
Hakkı Kaan Çalışkan
bd85a9c399 remove suppress and unnecessary otherwise = private 2020-06-16 23:30:57 -04:00
Hakkı Kaan Çalışkan
87a65d2445 For #9782: Clean up unused FeatureFlags
I've currently found out this ones unused.
webPushIntegration removed because looks like all fatal bugs solved as it said from note.
2020-06-16 23:30:57 -04:00
Kainalu Hagiwara
291a29b334
For #11651 - Fix top site favicon size and dark theme border color. (#11652) 2020-06-16 14:10:15 -07:00
ekager
37ccc52d35 For #11558 - Fix double click required for tabs tray 2020-06-16 15:59:38 -04:00
Sören Hentzschel
396cd61efa For #9712 - show "AC: " before AC version on "About" screen 2020-06-16 15:29:00 -04:00
Sachin
36b1c710e7
for #11617 added a resetPoliciesAfter ext function for StrictMode, and replaced all existing calls to "resetAfter" with "resetPoliciesAfter" (#11619) 2020-06-16 11:12:18 -07:00
Mozilla L10n Automation Bot
6b4c46fdfb Import l10n. 2020-06-16 10:58:13 +03:00
Tiger Oakes
d81aa62683 Fix PIP toolbar 2020-06-15 15:34:06 -04:00
Tiger Oakes
d3d5c8934f Cleanup tests for toolbar controller 2020-06-15 15:25:33 -04:00
person808
9e3e95e351 For #11442 - Telemetry for tab counter menu. 2020-06-15 11:48:12 -07:00
Mozilla L10n Automation Bot
af64d93832 Import l10n. 2020-06-15 09:53:06 +03:00
Mihai Branescu
4f870e9251 For #6126 - moved the sessionObserver init to the onCreate
This helps because we will always need the observer to be initiated, not only when the `openToBrowser` method gets called. Example: Opening a tab from the tab tray had it's own method for opening the browser, causing this to not be called.
2020-06-15 08:01:32 +03:00
Jonathan Almeida
e6da2bd910 Fix breaking APIs in TabsAdapter and ViewHolder 2020-06-13 16:02:31 -04:00
Tiger Oakes
704fc6f983 Use updated webapphidetoolbarfeature 2020-06-12 19:21:34 -04:00
Tiger Oakes
fc96e188ab Convert flow from AC to livedata 2020-06-12 19:21:34 -04:00
David Walsh
149efc1683
For 9640 - Focus on last selected tab in tab tray with a11y turned on (#11487) 2020-06-12 18:15:13 -05:00
David Walsh
8b24cdec42
For 11428 - Focus on home screen address bar when tab tray new tab is tapped (#11429) 2020-06-12 17:55:07 -05:00
David Walsh
063cf457ba
For #11291 - Provide New Tab button when accessibility enabled (#11441) 2020-06-12 17:52:06 -05:00
liuche
35fa445165
Issue #11112 - Update empty collections string + tests. (#11538) 2020-06-12 18:01:38 -04:00
Arturo Mejia
a36ec7279e No issue: Decrease the frequency for checking for new supported add-ons 2020-06-12 17:19:07 -04:00
ekager
e71ed31ed9 For #11498 #11499 - preland new synced tabs strings 2020-06-12 16:04:19 -04:00
Tiger Oakes
294f29768d Test logins settings 2020-06-12 15:30:50 -04:00
Sawyer Blatz
0a9afbed42 For #11380: Update migration tip text 2020-06-12 15:17:53 -04:00
Gabriel Luong
a2f087b816 For #8312 - Land strings for limiting how many top sites you can add 2020-06-12 15:15:34 -04:00
Sawyer Blatz
fffbadbfca
For #11118: Add browsing history suggestion in metrics (#11525) 2020-06-12 11:40:04 -07:00
Sawyer Blatz
13d077eb66
For #11269: Telemetry for new reader mode position (#11385) 2020-06-12 11:39:35 -07:00
Sawyer Blatz
d1cd877374 For #11118: Add missing telemetry 2020-06-12 10:29:05 -07:00
Elise Richards
68017e5a00 Edit saved login duplicate error. 2020-06-12 12:12:37 -04:00
person808
a937bae2e9 Followup for #11081 - Fix top site colors for light theme. 2020-06-12 12:10:36 -04:00
mcarare
eb3e4fc415 For #11504: Rectify action bar button descriptions in bookmarks screen. 2020-06-12 09:33:20 -04:00
mcarare
724ca2fca9 For #10281: Reduce logo margin to compensate top site padding increase. 2020-06-12 09:31:23 -04:00
mcarare
852720f8c6 For #10281: Change margin with padding to allow flexbox to stretch. 2020-06-12 09:31:23 -04:00
mcarare
0ebfa4f947 For #11497: Disable pull to refresh in error states. 2020-06-12 14:09:16 +03:00
mozilla-l10n-automation-bot
0c514f5f1c
Import l10n. (#11495) 2020-06-11 17:30:11 -07:00
Jeff Boek
1639b1d3a1 For #11342 - Fixes missing space for the FAB 2020-06-11 18:25:57 -04:00
Tiger Oakes
651b2831fe Fix tests in toolbar controller 2020-06-11 18:15:09 -04:00
Sachin
cd26ba9a9c
for #11364 added a exception list for manufacturers violating strict mode policies on startup (#11407)
for #11364 changed blackList -> exceptionList, added one plus to the list

change magic strings into const Val
2020-06-11 11:50:07 -07:00
person808
d14b39a56e For #2165 - Implement pull-to-refresh gesture to sync history. 2020-06-11 10:23:27 -07:00
Mugurell
f163861b47 For #11177 - Load all share targets in the horizontal share menu
This was previously regressed by having the RecyclerViews for "recent" and
"all" items put inside a HorizontalScrollView which would then prevent the
RecyclerViews from actually scrolling, recycling, showing new items.

As a quick solution that would keep the desired behavior the "all" items list
is now a child of a RelativeLayout which will allow it to load all items at
once and so all the share targets will be available to the user but which also
means no recycling.

The RecyclerView for the "recent" items uses a `RECENT_APPS_LIMIT = 6` so this
does not need the same "fix" as all the items would fit the screen without
any issue.
2020-06-11 15:08:36 +03:00
mcarare
4b04a140fc For #11229: Update etp strict option title content description. 2020-06-11 10:20:01 +03:00
Sawyer Blatz
932a2f3703 For #11063: Update telemetry for etp settings 2020-06-10 22:51:21 -04:00
person808
3ff20c0b25 For #11081 - Add dark theme colors for top sites. 2020-06-10 19:42:34 -07:00
Mozilla L10n Automation Bot
53e984ec7a Import l10n. 2020-06-10 21:20:10 -04:00
Tiger Oakes
f0295048fa Remove Mockito 2020-06-10 21:19:50 -04:00
Jeff Boek
cd3b6181b3 For #10374 - Adds quick contextual menu to tab switcher
Co-authored-by: person808 <kainaluh808@gmail.com>
2020-06-10 16:50:28 -07:00
Elise Richards
137d66a511
For 10172: Set edit text listeners (#11196)
* Set edit text listeners

* Set clearable icons and change with error states

* Clear text buttons show and hide

* Move error checks to afterTextChanged. Refactor. Remove unused color.
2020-06-10 16:52:47 -05:00
Tiger Oakes
31edbc924c
Fixes #9056 - Start Fenix activity on search in external app (#10932) 2020-06-10 10:25:53 -07:00
Tiger Oakes
4b064afb81
Add tests for ext package (#11334) 2020-06-10 09:14:18 -07:00
Christian Sadilek
d16c70d8be Wire up UI to make add-on installation cancelable 2020-06-10 18:52:06 +03:00
ValentinTimisica
bc53296603 For #11365: Reorganizes 'SettingsFragment' items
Moved all the functionality form 'DefaultBrowserSettingsFragment' to
'SettingsFragment'.
2020-06-10 11:09:03 +03:00
ekager
11697c1363 For #11390 - Removes redundant session observer init for ETP overlay 2020-06-10 08:37:49 +03:00
Sawyer Blatz
27c7ef5ad4 For #8775: Removes feature flag for dynamic bottom toolbar 2020-06-09 20:58:17 -07:00
ValentinTimisica
f937c96c12 For #5148: Switch to the correct tab on media notification clicked
Processing the intent in OpenSpecificTabIntentProcessor to be able to switch
to the tab where audio/video is playing
2020-06-09 22:39:39 -04:00
David Walsh
1356b3e426 For 11271 - Provide useful tab counter message for accessibility 2020-06-09 22:37:46 -04:00
Tiger Oakes
96d2307df0 Add tests for widget 2020-06-09 22:31:12 -04:00
ValentinTimisica
3a28704fa6 For #11132: Replaces wrong icons from menus 2020-06-09 22:19:43 -04:00
ValentinTimisica
dc37baff0b For #11132: Rearranges home menu items 2020-06-09 22:19:43 -04:00
Jeff Boek
f41ca2f424 No Issue - Moves from being a tabstray observer to overriding tab use cases 2020-06-09 19:13:08 -07:00
Mozilla L10n Automation Bot
2c418de0a3 Import l10n. 2020-06-09 17:30:35 -07:00
Christian Sadilek
05496faa66 Clear speculative session on engine settings change 2020-06-09 18:55:43 -04:00
ValentinTimisica
32bfba5b36 For #11201: Updates 'synced tabs' and account settings 'tabs' strings 2020-06-09 18:05:51 -04:00
Sawyer Blatz
5445d34ac4 For #11357: Use AppCompatResources for reader mode icon 2020-06-09 18:04:13 -04:00
Jeff Boek
4ee1cd6716 For #11361 - Nulls out tabsFeature in the correct spot 2020-06-09 15:34:00 -04:00
Jeff Boek
d8ef0722e3 For #11175 - Moves tab tray strings to be translated, fixes description of the fab string 2020-06-09 13:06:02 -04:00
ekager
6d4a673c6f For #8967 - Expose autofill logins setting in nightly 2020-06-09 12:21:48 -04:00
ekager
29e1a9c670 For #7911 - Updates ETP shield assets with new size 2020-06-09 11:57:40 -04:00
Mozilla L10n Automation Bot
5373a75f57 For #10502 - Show snackbar after adding tabs to collection from tab tray 2020-06-09 08:29:06 -07:00
Mozilla L10n Automation Bot
eebc1f936a Import l10n. 2020-06-08 22:43:25 -04:00
Grisha Kruglov
8769d98e71 Pass crashReporter instance to RustLog 2020-06-08 17:38:30 -07:00
Sachin
8fdc28010d
for #10839 added IO coroutine to check onboarding stat from sharedpref (#11338)
changed coroutine scope to fragments lifecycle
2020-06-08 15:52:10 -07:00
Jeff Boek
e4e7cc5108 For #11260 - Fixes lifecycle issues with the tabs tray
- Also check to make sure the fragment manager is still valid before trying to show the tabs tray

Co-authored-by: Emily Kager <emilykager@gmail.com>
2020-06-08 18:42:46 -04:00
Sawyer Blatz
e9189dc089 For #11045: Add reader mode to urlView 2020-06-08 15:12:03 -07:00
Tiger Oakes
1a19b06227
Simplify PhoneFeature code (#10810) 2020-06-08 13:02:42 -07:00
Sachin
74948cb3f1
for #7225, Changed strictMode thread penalty to dialog on startup and back to logs after startup is done. (#10831)
for #7225, refactored and cleanup the branch.

for #7225, change strict mode policy only on main process.

for #7225, setting thread policy inside a seperate thread to keep it from getting overridden in activities.

for #7225 removed Handler().postAtFrontOfQueue as a solution due to unknown side effects. moved the enableStrictMode function to be static so we can reuse it.

for #7225 lint check

for #7225 created strict mode manager and moved enabledStrictMode function inside it.

for #7225 removed penalty death on network

for #7225 added allow disk access on thread for already existing violation


strict mode running in main process to see if it passes the gitlab check, will revert it if it doesnt

allowed diskread for super.onCreate for home activity

added comments for disk violation oncreate homeactivity

added fragment manager inside strictmode manager

allowed disk read for onboarding

allowed disk read for cachedTopSites
2020-06-08 10:45:33 -07:00
Mozilla L10n Automation Bot
04a436d30e Import l10n. 2020-06-07 20:44:39 -04:00
Mozilla L10n Automation Bot
01ade6e62a Import l10n. 2020-06-07 12:57:03 -04:00
Mozilla L10n Automation Bot
e28f9d49d1 Import l10n. 2020-06-05 21:03:20 -04:00
David Walsh
d33080571b
For #11267 - Announce "Your open tabs will be shown here (#11272) 2020-06-05 17:27:45 -05:00
mcarare
c8b40fa617 For #11246: Align text to viewStart to support RTL layouts. 2020-06-05 14:29:00 -04:00
person808
d66ccb8631 For #11277 - Set textAlignment to viewStart to fix RTL layout in empty ETP exceptions screen. 2020-06-05 14:27:54 -04:00
person808
a57d76eb4f For #6180 - Set textAlignment to viewStart to fix RTL layouts. 2020-06-05 14:27:26 -04:00
mcarare
512aa46224 For #11229: Update ETP cfr string and behaviour. 2020-06-05 14:18:25 -04:00
mcarare
91c27a023e For #11229: Update settings ETP copy. 2020-06-05 14:18:25 -04:00
mcarare
a0d9189321 For #11229: Update onboarding ETP copy. 2020-06-05 14:18:25 -04:00
Jeff Boek
52c2fdb310
Remove tab tray feature flag (#11176)
* For #11171 - Removes feature flag for the new tab tray

* For #11171 - Removes all tab references from homeFragment

* For #11171 - Fixes unit tests

* For #11171 - Gets UI tests to compile and HomeScreenTest to pass

* For #11171 - Fixes `deleteMultipleSelectionTest`

* For #11171 - Fixes `openHistoryItemInNewPrivateTabTest`

* For #11171 - Fixes `openHistoryInPrivateTabTest`

* For #11171 - Fixes `openHistoryInNewTabTest`

* For #11171 - Fixes `openNewPrivateTabTest`

* For #11171 - Fixes tabbedBrowsingTests

* For #11171 - Fixes SettingsPrivacyTest

* For #11171 - Fixes TopSitesTest

* For #11171 - Fixes lint errors

* Ignore
2020-06-05 12:59:08 -05:00
mcarare
741fa799ad For #7752, #7753: Adjust touch targets for elements in crash reporter. 2020-06-05 12:04:58 +03:00
mcarare
f47c80d10b No issue: Fix xml indentations. 2020-06-05 12:04:58 +03:00
mcarare
2d24369362 For #7725: Increase info button touch target while keeping size.
Also removed unnecessary touch delegate.
2020-06-05 11:57:17 +03:00
mcarare
8f3274eba9 For #9590: Increase widget elements touch target while keeping size. 2020-06-05 11:49:35 +03:00
person808
8c47b988b8 For #10525 - Remove tab tray item dividers. 2020-06-04 23:17:16 -07:00
ekager
094f3d0c97 Closes #10629 - Update Content Description of Edit Login Menu Item 2020-06-05 08:12:43 +03:00
Jeff Boek
bc53b94feb For #10989 - Fixes memory leak caused by retaining the TabTrayView and TabsFeature 2020-06-04 23:29:14 -04:00
Mozilla L10n Automation Bot
06d9133cb9 Import l10n. 2020-06-04 20:59:50 -04:00
Sawyer Blatz
1be2ec2cbf For #9488: Init widgetExperiment after Experimenter init 2020-06-04 16:22:52 -07:00
mcarare
886c1882c5 For #11230: Set default to false for allow screenshots in private setting 2020-06-04 18:24:26 -04:00
Dennis Schubert
e41fc7841a Bug 1643132 - Add WebCompat Reporter feature. 2020-06-04 18:23:11 -04:00
Dennis Schubert
d046d908fc Bug 1643132 - Remove native "Report site issue" functionality.
This will be replaced by the WebCompat team's system extension that ships as an android-component.
2020-06-04 18:23:11 -04:00
Sawyer Blatz
42f58a1984 For #9488: Add experimentation support 2020-06-04 14:10:22 -07:00
ekager
54df729fb3 For #8374 - Don't recreate ExternalAppBrowserActivity or finishing activities 2020-06-04 16:44:07 -04:00
mcarare
efae61d593 For #9771, #9768: Adjust touch target for buttons in error pages 2020-06-04 20:39:43 +03:00
Sawyer Blatz
9302d07d13 For #11118: Add toggle states to metrics ping 2020-06-04 10:08:23 -07:00
mcarare
5a23fb33f8 For #11182: Fix back button text update according to save step. 2020-06-04 11:50:29 -04:00
mcarare
a910698007 For #11182: Set click listener also to icon button. 2020-06-04 11:50:29 -04:00
Gabriel Luong
9520c9dd32 For #8920 - [Telemetry] Send add-on ids in a metrics ping 2020-06-04 08:15:39 -07:00
mcarare
29f1800021 For #11182: Explicitly clone select tabs on updating SaveCollectionStep. 2020-06-03 23:01:44 -04:00
mcarare
68286d263a For #11182: Set click listener to full layout instead of just icon. 2020-06-03 23:01:44 -04:00
Mozilla L10n Automation Bot
cda6995ca7 Import l10n. 2020-06-03 21:37:44 -04:00
person808
9272026b7e For #10193 - Remove page title when sharing links 2020-06-03 15:54:23 -07:00
Tiger Oakes
a7e74e308b
Migrate some SessionManager usage to BrowserStore (#10789) 2020-06-03 11:18:44 -07:00
mcarare
138c12696f For #11153:Add FLAG_SECURE on pause and clear on resume for private session. 2020-06-03 08:56:16 -04:00
David Walsh
7013e8198b For 11114 - Correct landscape tab tray buttons 2020-06-02 23:09:05 -07:00
David Walsh
d862d58051 Scroll to the top of home when using the tab tray 2020-06-02 23:08:20 -07:00
Jonathan Almeida
803ed6cde3 For #11154: Fix button color on migration UI 2020-06-02 18:08:45 -07:00
mcarare
2090b11c97 For #10434: Handle cases when proc/$pid/stat is not accessible. 2020-06-02 17:57:39 -07:00
Mozilla L10n Automation Bot
0df27742a3 Import l10n. 2020-06-02 17:50:39 -07:00
ekager
ead3194d86 For #8759 - Allow recently used in share fragment to scroll 2020-06-02 16:46:08 -04:00
Jeff Boek
2dd0a3cb9e
Implement tab tray design improvements and fix close functionality. 2020-06-02 15:03:58 -05:00
mcarare
7d50834a90 For #11139:Constrain title to start of checkbox and ellipsize. 2020-06-02 12:08:05 -04:00
Tiger Oakes
6317eea690 Add tests for some of collection creation 2020-06-02 10:06:17 -04:00
Tiger Oakes
b5d03ff62d Close #10571 - Add dark mode for error pages 2020-06-02 09:55:55 -04:00
mcarare
ad829115ef For #9545: Split button to allow distinct focus for a11y services. 2020-06-02 09:33:32 -04:00
ValentinTimisica
591e2c9a6f Fixes #9696: Adds Add-ons menu item to the home menu 2020-06-02 09:32:30 -04:00
ValentinTimisica
1c367080a5 Fixes #10113: Changes login prompt editText cursor color
This patch uses `mozacPromptLoginEditTextCursorColor` attribute defined in AC.
Check PR: https://github.com/mozilla-mobile/android-components/pull/7056
2020-06-02 09:29:59 -04:00
mcarare
7562e06b25 For #9595: Increase search pill touch target height to container height.
Adjust background to fit new dimensions.
2020-06-02 09:27:23 -04:00