2
0
mirror of https://github.com/fork-maintainers/iceraven-browser synced 2024-11-07 15:20:38 +00:00
Commit Graph

153 Commits

Author SHA1 Message Date
Severin Rudie
2e76d82c9a [fenix] 4281 remove qab (https://github.com/mozilla-mobile/fenix/pull/6310)
* For https://github.com/mozilla-mobile/fenix/issues/4281: small ToolbarMenu refactor

This makes it easier to see how items are ordered in the menuItems list

* For 4281: add QAB buttons to menu

* For 4281: removed menu back button per mocks

I double checked with UX, and we'll be relying on the hardware back button for its functionality

* For 4281: add content descriptions for bookmarking

* For 4281: updated BrowserToolbarController for new functionality

* For 4281: provided simple dependencies to browser controller

More complex changes will be in a following commit, for review readability

* For 4281: move toolbar controller dependencies up to BaseBrowserFragment

The functionality they control is being moved into the toolbar menu, which is shared by both normal tabs and custom ones

* For 4281: removed (now unused) code related to QAB

* For 4281: fix test compilation after QAB removal

Tests still need to be expanded to include added functionality

* For 4281: updated menu to show if url is bookmarked

This sloppy workaround is required because TwoStateButton requires that `isInPrimaryState` be a synchronous call, and checking whether or not the current site is bookmarked is quite slow (10-50 MS, in my tests).  After days of work and many attempted solutions, this was the least abhorrent among them.

https://github.com/mozilla-mobile/android-components/issues/4915 was opened against AC to evaluate potentially supporting async `isInPrimaryState` functions.
https://github.com/mozilla-mobile/fenix/issues/6370 was opened against Fenix to investigate the unexpectedly slow call to `BookmarkStorage`.

* For 4281: update reader mode switch

* For 4281: selectively show/hide menu items

* For 4281: add reader mode appearance

* For 4281: update bookmark button when it is clicked

* For 4281: removed unused QAB code

* For 4281: removed QAB robot, updated UI tests

* For 4281: removed QuickActionSheet metrics

Since this behavior now lives in the toolbar, it is tracked via Event.BrowserMenuItemTapped

* For 4281: fixed lint errors

* For 4281: add new strings for buttons added to menu

This is necessary because the location change (from QAB to toolbar menu) could affect the grammar in some languages

* For 4281: remove outdated TODOs

* For 4281: removed QAB container

* For 4281: removed back button reference from UI test

This button no longer exists

* For 4821: Fixes a visual defect (extra padding on top of toolbar)

* For 4281: update copy on reader mode

* For 4281: fixed review nits
2019-11-11 17:10:14 -08:00
Sawyer Blatz
c6e952238d [fenix] For https://github.com/mozilla-mobile/fenix/issues/4456: Updates total_uri_count upload (https://github.com/mozilla-mobile/fenix/pull/6482) 2019-11-06 19:10:56 -08:00
ekager
e709201056 [fenix] Use new API for ETP Exceptions 2019-11-05 12:45:58 -08:00
liuche
0eb5656020 [fenix] Closes https://github.com/mozilla-mobile/fenix/issues/6097 - Bump activation ping expiry date. (https://github.com/mozilla-mobile/fenix/pull/6309) 2019-11-01 14:06:44 -07:00
Sawyer Blatz
65fa1e255d [fenix] For https://github.com/mozilla-mobile/fenix/issues/5959 & https://github.com/mozilla-mobile/fenix/issues/5958: Integrates download feature into Fenix (https://github.com/mozilla-mobile/fenix/pull/6368) 2019-10-31 14:37:05 -07:00
Sawyer Blatz
506fdc79a8 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4456: Adds total_uri_count to metrics core ping (https://github.com/mozilla-mobile/fenix/pull/6003) 2019-10-30 11:02:33 -07:00
Sawyer Blatz
ed0d2c0c0c [fenix] For https://github.com/mozilla-mobile/fenix/issues/1298: Fixes issue with Adjust campaign not sending through Glean (https://github.com/mozilla-mobile/fenix/pull/5896) 2019-10-29 10:09:07 -07:00
Sawyer Blatz
8314b378d7 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5737: Adds telemetry for open links in a private tab (https://github.com/mozilla-mobile/fenix/pull/5975) 2019-10-24 17:16:49 -07:00
Jeff Boek
05b2e94dcf [fenix] No Issue - Updates telemetry docs 2019-10-10 23:00:27 -07:00
Sawyer Blatz
5581b61e60 [fenix] No issue: fixes master (https://github.com/mozilla-mobile/fenix/pull/5777) 2019-10-03 14:42:56 -07:00
Sawyer Blatz
d9881d8211 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5094: Adds telemetry for suggestion toggles (https://github.com/mozilla-mobile/fenix/pull/5704) 2019-10-03 10:03:14 -07:00
Sawyer Blatz
17e0c7a2f2 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5679: Hides autoplay behind feature flag (https://github.com/mozilla-mobile/fenix/pull/5685) 2019-09-30 12:01:04 -07:00
Sawyer Blatz
a95d6d58d0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/1298: Adds adjustCampaignId to core ping (https://github.com/mozilla-mobile/fenix/pull/5579) 2019-09-27 08:56:33 -07:00
Sawyer Blatz
1519dbf668 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5197: Adds telemetry for media notification (https://github.com/mozilla-mobile/fenix/pull/5520) 2019-09-27 08:02:29 -07:00
Emily Kager
937b18c4ca [fenix] For https://github.com/mozilla-mobile/fenix/issues/5312 - Add Telemetry for Tracking Protection 2019-09-23 08:29:45 -07:00
Sawyer Blatz
746016e560 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5197: Adds telemetry for media controls (https://github.com/mozilla-mobile/fenix/pull/5266) 2019-09-20 14:49:27 -07:00
Grisha Kruglov
6411072f0d [fenix] FxA WebChannels integration
This patch includes:
- WebChannels support enabled by default, with ability to disable it via remote flag
- expanded FxA telemetry (closes https://github.com/mozilla-mobile/fenix/issues/4971)

Co-authored-by: Arturo Mejia <arturomejiamarmol@gmail.com>
2019-09-16 19:44:13 -07:00
Alessio Placitelli
2edc73ed3f [fenix] Automatically generate metrics docs using the Glean SDK (https://github.com/mozilla-mobile/fenix/pull/5101) 2019-09-12 14:49:49 -07:00
Emily Kager
e647d7e8c6 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3700 - Add Setting to Delete Data on "Quit" menu action 2019-09-11 16:06:18 -07:00
Yeon Taek Jeong
88ecaf12b1 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4658: Add private browsing mode shortcut telemetry 2019-09-11 16:03:22 -07:00
Sawyer Blatz
88996e7f0c [fenix] For https://github.com/mozilla-mobile/fenix/issues/964: Adds ability to disable each suggestion provider (https://github.com/mozilla-mobile/fenix/pull/5096)
* For https://github.com/mozilla-mobile/fenix/issues/964: Adds ability to disable each suggestion provider

* Fix nit
2019-09-05 14:45:44 -07:00
Sawyer Blatz
5a5f46cb76 [fenix] For https://github.com/mozilla-mobile/fenix/issues/5021: Adds metric for what's new button 2019-09-04 09:17:14 -07:00
Sawyer Blatz
da34c36d24 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4908: Adds metrics for send tab telemetry 2019-09-04 09:15:50 -07:00
Yeon Taek Jeong
b4fa37b231 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4658: Add some private browsing mode telemetry (https://github.com/mozilla-mobile/fenix/pull/4968) 2019-08-28 14:41:37 -07:00
Sawyer Blatz
0356d7c3ec [fenix] For https://github.com/mozilla-mobile/fenix/issues/4969: Removes erroneous FxA sign up ping (https://github.com/mozilla-mobile/fenix/pull/4970) 2019-08-28 14:32:43 -07:00
Sawyer Blatz
1c995d36e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2706: Refactor Glean to reduce errors (https://github.com/mozilla-mobile/fenix/pull/4753)
* For https://github.com/mozilla-mobile/fenix/issues/2706: Adds recording for untracked events

* For https://github.com/mozilla-mobile/fenix/issues/2706: Adds key alignment to Metrics
2019-08-19 15:25:48 -07:00
Sawyer Blatz
46eaca2871 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4421: Fixes issues with new glean events (https://github.com/mozilla-mobile/fenix/pull/4816) 2019-08-19 14:49:48 -07:00
Sawyer Blatz
6cfbb2c02b [fenix] For https://github.com/mozilla-mobile/fenix/issues/4421: Adds Leanplum events and attributes (https://github.com/mozilla-mobile/fenix/pull/4626)
* For https://github.com/mozilla-mobile/fenix/issues/4421: Adds Leanplum events and attributes

* For https://github.com/mozilla-mobile/fenix/issues/4421: Adds Leanplum deep links
2019-08-14 13:48:45 -07:00
Yeon Taek Jeong
468c400ff5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4457: Adds telemetry for search widget actions (https://github.com/mozilla-mobile/fenix/pull/4714) 2019-08-14 11:39:54 -07:00
Michael Cooper
9646181343 [fenix] Add no-op experiment to test service-experiments integration (https://github.com/mozilla-mobile/fenix/pull/4551)
* Add no-op experiment to test service-experiments integration

* Shorten metric name to meet schema

* Add active_experiment metric to docs

* Add approved data review
2019-08-14 12:07:41 -05:00
Sawyer Blatz
20b0c30640 [fenix] For https://github.com/mozilla-mobile/fenix/issues/4123: Adds telemetry for quick action open in app (https://github.com/mozilla-mobile/fenix/pull/4629) 2019-08-09 13:51:12 -07:00
Sawyer Blatz
e904bd867e [fenix] For https://github.com/mozilla-mobile/fenix/issues/969: Adds more telemetry for collections (https://github.com/mozilla-mobile/fenix/pull/4539) 2019-08-07 16:05:20 -07:00
Sawyer Blatz
464a5f92cd [fenix] For https://github.com/mozilla-mobile/fenix/issues/2267: Fixes telemetry for reader view (https://github.com/mozilla-mobile/fenix/pull/4328) 2019-07-31 17:58:37 -07:00
Sawyer Blatz
1b027a36e4 [fenix] For https://github.com/mozilla-mobile/fenix/issues/969: Adds more telemetry for collections (https://github.com/mozilla-mobile/fenix/pull/4358) 2019-07-31 17:07:41 -07:00
Sawyer Blatz
9d4312204f [fenix] For https://github.com/mozilla-mobile/fenix/issues/969: Adds telemetry for collections (https://github.com/mozilla-mobile/fenix/pull/3935) 2019-07-18 16:05:42 -07:00
Sawyer Blatz
6dd34ece58 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2267: Adds telemetry for reader mode (https://github.com/mozilla-mobile/fenix/pull/3941) 2019-07-18 15:17:15 -07:00
Sawyer Blatz
8ab0e5a405 [fenix] For https://github.com/mozilla-mobile/fenix/issues/2362: Adds telemetry for history (https://github.com/mozilla-mobile/fenix/pull/3940) 2019-07-16 12:21:03 -07:00
Sawyer Blatz
a8b04c98b9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3174: Adds telemetry for bookmarks (https://github.com/mozilla-mobile/fenix/pull/3724) 2019-07-02 08:41:20 -07:00
Jeff Boek
61c06844f9 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3351 - Adds docs for the activation ping 2019-06-11 10:55:54 -07:00
Jeff Boek
9928cc3c1e [fenix] For https://github.com/mozilla-mobile/fenix/issues/3351 - Adds docs for search_default_engine telemetry 2019-06-11 10:55:54 -07:00
Jeff Boek
80ec7ccb9c [fenix] For https://github.com/mozilla-mobile/fenix/issues/3351 - Adds telemetry docs for metrics 2019-06-11 10:55:54 -07:00
Jeff Boek
04b53fc932 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3351 - Adds docs for the sync_account telemetry 2019-06-11 10:55:54 -07:00
Jeff Boek
5dc5594e41 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3351 - Adds docs for the sync_auth telemetry 2019-06-11 10:55:54 -07:00
Jeff Boek
4e6b9ddd17 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3351 - Adds error_page telemetry docs 2019-06-11 10:55:54 -07:00
Jeff Boek
f7bd53c1c5 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3351 - Adds telemetry docs for the library 2019-06-11 10:55:54 -07:00
Jeff Boek
ae158c1d6f [fenix] For https://github.com/mozilla-mobile/fenix/issues/3351 - Adds qr_scanner telemetry docs 2019-06-11 10:55:54 -07:00
Jeff Boek
04b2477f76 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3351 - Adds custom tab telemetry docs 2019-06-11 10:55:54 -07:00
Jeff Boek
442c10eb30 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3351 - Adds bookmark management documentation 2019-06-11 10:55:54 -07:00
Jeff Boek
c07a999e82 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3351 - Adds QAB documentation 2019-06-11 10:55:54 -07:00
Jeff Boek
b56239b9e0 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3351 - Adds find_in_page metrics 2019-06-11 10:55:54 -07:00
Jeff Boek
2b127911c3 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3351 - Adds context_menu docs 2019-06-11 10:55:54 -07:00
Jeff Boek
db605ba571 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3351 - Adds crash_reporter docs 2019-06-11 10:55:54 -07:00
Jeff Boek
20cff4c750 [fenix] For https://github.com/mozilla-mobile/fenix/issues/3351 - Create metrics.md 2019-06-11 10:55:54 -07:00