(´⌣`ʃƪ)
da54bdfe63
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4436 : Dismiss onboarding before navigating away from home ( https://github.com/mozilla-mobile/fenix/pull/4801 )
2019-08-20 10:56:28 -07:00
Tiger Oakes
9882aa6a50
[fenix] Adds setters and property delegates in Settings
( https://github.com/mozilla-mobile/fenix/pull/4809 )
...
* Change Settings to use setters
* Add delegate for shared preferences
2019-08-20 10:47:55 -07:00
Tiger Oakes
7780821922
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/2690 - Clean up CreateCollection viewmodel ( https://github.com/mozilla-mobile/fenix/pull/4731 )
2019-08-20 10:45:41 -07:00
Tiger Oakes
2fb1bd0283
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4774 - Use vector drawable compat ( https://github.com/mozilla-mobile/fenix/pull/4811 )
2019-08-20 10:43:02 -07:00
Tiger Oakes
500d557828
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4744 - Extract private browsing button ( https://github.com/mozilla-mobile/fenix/pull/4813 )
2019-08-20 10:41:18 -07:00
Tiger Oakes
d5e5b73485
[fenix] Color the system bars in custom tabs ( https://github.com/mozilla-mobile/fenix/pull/4819 )
2019-08-20 10:13:01 -07:00
Tiger Oakes
efe2e2e466
[fenix] Issue https://github.com/mozilla-mobile/fenix/issues/1000 - Remove isCustomTab flag ( https://github.com/mozilla-mobile/fenix/pull/4656 )
2019-08-20 10:00:49 -07:00
Sourabh
0e376bb266
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4399 : Create LibState Controller for Search ( https://github.com/mozilla-mobile/fenix/pull/4673 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4399 : Create LibState Controller for Search
* fix code format
* add unit tests for DefaultSearchController
* add more test
* fix unit tests
2019-08-20 09:07:00 -07:00
Mugurell
2634b6dee4
[fenix] For 4827 - Remove TransitionPreDrawListenerTest pending tests refactoring
...
New tests for `FragmentPreDrawManager` are to be added in https://github.com/mozilla-mobile/fenix/issues/4828
2019-08-20 13:45:55 +02:00
Mugurell
fa2abeffe9
[fenix] Fix 4827 - Use ktx doOnPreDraw() to restore HomeFragment's layout
...
The previous solution would result in a crash because the passed in
viewTreeObserver that would trigger onPreDraw would be invalid.
The proposed solution is simpler and ensures we'll always use the right
viewTreeObserver.
`FragmentPreDrawManager` is general enough that can be used by other Fragments
also, so I've added it to the `utils` package.
2019-08-20 13:45:55 +02:00
Emily Kager
9431f611d5
[fenix] Update strings.xml
...
Remove space in placeholder for es (temp for release)
2019-08-19 19:14:22 -07:00
Axel Hecht
7d5d5b7afd
[fenix] Import strings from android-l10n
...
State: mozilla-l10n/android-l10n@413e05dba4
2019-08-19 19:14:22 -07:00
Tiger Oakes
1c389d1231
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4744 - Extract TransitionPreDrawListener ( https://github.com/mozilla-mobile/fenix/pull/4812 )
2019-08-19 16:27:43 -07:00
Tiger Oakes
774d696c92
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4744 - Move search bar icon padding to dimens ( https://github.com/mozilla-mobile/fenix/pull/4814 )
2019-08-19 16:22:51 -07:00
Emily Kager
0268034e79
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4822 - Update Bookmark State in onResume ( https://github.com/mozilla-mobile/fenix/pull/4823 )
2019-08-19 16:22:20 -07:00
Mihai Adrian
8a1829b484
[fenix] fixes https://github.com/mozilla-mobile/fenix/issues/4179 removed control highlight from disconnect button ( https://github.com/mozilla-mobile/fenix/pull/4806 )
...
set colorControlHighlight to transparent in activity theme.
property cannot be set in view because it is overwritten by activity theme.
2019-08-19 16:16:06 -07:00
Sawyer Blatz
1c995d36e0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/2706 : Refactor Glean to reduce errors ( https://github.com/mozilla-mobile/fenix/pull/4753 )
...
* For https://github.com/mozilla-mobile/fenix/issues/2706 : Adds recording for untracked events
* For https://github.com/mozilla-mobile/fenix/issues/2706 : Adds key alignment to Metrics
2019-08-19 15:25:48 -07:00
Sawyer Blatz
46eaca2871
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4421 : Fixes issues with new glean events ( https://github.com/mozilla-mobile/fenix/pull/4816 )
2019-08-19 14:49:48 -07:00
Sawyer Blatz
ea193a5472
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4804 : Resolves issue with crash reporter stack
2019-08-19 16:40:41 -04:00
Aaron Train
aa9bf1aa6e
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4618 - Stub Library UI tests ( https://github.com/mozilla-mobile/fenix/pull/4619 )
...
See https://github.com/mozilla-mobile/fenix/issues/4572
2019-08-19 14:05:10 -04:00
Arturo Mejia
7f746f6f17
[fenix] Use Mozilla Android Components 9.0.0-SNAPSHOT. ( https://github.com/mozilla-mobile/fenix/pull/4750 )
2019-08-19 10:29:10 -07:00
Suraj Shah
f3a412e24e
[fenix] Fixes https://github.com/mozilla-mobile/fenix/issues/4704 ( https://github.com/mozilla-mobile/fenix/pull/4728 )
...
* Fixes https://github.com/mozilla-mobile/fenix/issues/4704 . Overrides `setEnabled` for DeleteBrowsingDataItem to change view alpha when disabled and to toggle the checkbox `isEnabled` behavior based on the value provided.
* Updates CHANGELOG.md
* Removes unnecessary disabling of checkbox in DeleteBrowsingDataItem.kt
Updates CHANGELOG.md to reflect the component changed.
2019-08-19 09:23:12 -07:00
Mugurell
43e4bcc0b1
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4396 - Add a Bookmarks Controller ( https://github.com/mozilla-mobile/fenix/pull/4593 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4396 - Rename BookmarkInteractor methods
Following the naming model used in other Interactors this too will use reactive
method names in the form of "on..." instead of the previous imperative model.
Kept the imperative naming model for the methods from `SelectionInteractor` as
they are a new addition and I'm not sure about the future direction.
* For https://github.com/mozilla-mobile/fenix/issues/4396 - Add a BookmarkController
It abstracts the Fragment behavior in a contract through which various
Interactors can inform about the specific View changes and can ask for
modifications in their container Fragment.
This contract and it's implementation - `DefaultBookmarkController` are the
result of extracting the container Fragment's business logic from
`BookmarkFragmentInteractor` in it's own standalone component.
* For https://github.com/mozilla-mobile/fenix/issues/4396 - Refactored Bookmark related tests
Added a new `BookmarkControllerTest` tests class which complements the new
`BookmarkController` to ensure that it properly operates on `BookmarkFragment`
Also refactored the existing `BookmarkFragmentInteractorTest` to accommodate
`BookmarkFragmentInteractor`'s now more specialized behavior.
2019-08-19 08:34:57 -07:00
Tiger Oakes
84349bda63
[fenix] Extract quick action sheet observer code ( https://github.com/mozilla-mobile/fenix/pull/4368 )
2019-08-19 08:28:33 -07:00
Emily Kager
80b2c4ee51
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4799 https://github.com/mozilla-mobile/fenix/issues/4790 - Don't use passed in sessions in BrowserToolbarController ( https://github.com/mozilla-mobile/fenix/pull/4800 )
2019-08-18 20:36:40 -05:00
Colin Lee
47bbb9081d
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4686 : Fix potential security issue ( https://github.com/mozilla-mobile/fenix/pull/4764 )
2019-08-16 16:50:54 -05:00
Yeon Taek Jeong
d72c8cf1b6
[fenix] No issue: fixes click failures on search widget icon
2019-08-16 13:58:29 -07:00
Emily Kager
043f8829c9
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4688 - Try to use context instead of targetContext ( https://github.com/mozilla-mobile/fenix/pull/4765 )
2019-08-16 10:12:56 -07:00
Sawyer Blatz
6dd829fdb4
[fenix] No issue: Add threshold to codecov ( https://github.com/mozilla-mobile/fenix/pull/4751 )
2019-08-15 10:40:05 -07:00
Yeon Taek Jeong
b1fdb6a353
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4736 : Display search shortcuts only from home or search widget
2019-08-15 12:24:54 -04:00
Emily Kager
52ff9a61f0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4688 - Try slightly different Context class for MockWebServer ( https://github.com/mozilla-mobile/fenix/pull/4747 )
2019-08-15 08:05:23 -07:00
Emily Kager
b037ddee5a
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4680 - Align collection creation text center vertical
2019-08-14 20:17:01 -04:00
Yeon Taek Jeong
6c41d30fd8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4384 : Hide mic icon if speech-to-text is unavailable ( https://github.com/mozilla-mobile/fenix/pull/4701 )
2019-08-14 16:40:21 -07:00
Yeon Taek Jeong
8efb7f9cdb
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4516 : Use full width for large search widgets ( https://github.com/mozilla-mobile/fenix/pull/4659 )
2019-08-14 16:00:13 -07:00
Emily Kager
e4f3b39e0b
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/3860 - Update description text for collections
2019-08-14 17:13:52 -04:00
Sawyer Blatz
6cfbb2c02b
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4421 : Adds Leanplum events and attributes ( https://github.com/mozilla-mobile/fenix/pull/4626 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4421 : Adds Leanplum events and attributes
* For https://github.com/mozilla-mobile/fenix/issues/4421 : Adds Leanplum deep links
2019-08-14 13:48:45 -07:00
Yeon Taek Jeong
309b86544c
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4421 : Add search widget attribute to Leanplum ( https://github.com/mozilla-mobile/fenix/pull/4694 )
2019-08-14 12:00:29 -07:00
Yeon Taek Jeong
468c400ff5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4457 : Adds telemetry for search widget actions ( https://github.com/mozilla-mobile/fenix/pull/4714 )
2019-08-14 11:39:54 -07:00
Yeon Taek Jeong
2c70a18a62
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4732 : Fix search engine display issue ( https://github.com/mozilla-mobile/fenix/pull/4735 )
2019-08-14 11:03:14 -07:00
Mihai Adrian
4835dbb1a8
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4434 - made close button for collections more accessible. ( https://github.com/mozilla-mobile/fenix/pull/4443 )
...
* fixes https://github.com/mozilla-mobile/fenix/issues/4434 - made close button for collections more accessible.
set recommended minimum size for accessibility 48x48, while keeping image size the same
removed margin from button as it was not needed anymore
aligned close button in center of tab to be visual consistent with alignment of favicon and more visual accessible
implemented same visual solution as for https://github.com/mozilla-mobile/fenix/issues/4193 - close button for tabs
* fixes https://github.com/mozilla-mobile/fenix/issues/4434 - made buttons for collection home list row more accessible and aligned 3 dot menu with individual tabs close button
set buttons sizes to recommended minimum size for accessibility 48x48, while keeping image size the same
removed margins from buttons as they were not needed anymore
aligned center of menu buttons with center of collection icon
constrained description top to bottom of title, instead of share button to reduce empty space. (overlap with share button is already prevented by end constraint of description)
2019-08-14 10:12:39 -07:00
Michael Cooper
9646181343
[fenix] Add no-op experiment to test service-experiments integration ( https://github.com/mozilla-mobile/fenix/pull/4551 )
...
* Add no-op experiment to test service-experiments integration
* Shorten metric name to meet schema
* Add active_experiment metric to docs
* Add approved data review
2019-08-14 12:07:41 -05:00
Jeff Boek
2e49f5b8b0
[fenix] Release documentation ( https://github.com/mozilla-mobile/fenix/pull/4617 )
...
* For https://github.com/mozilla-mobile/fenix/issues/4258 - Create release checklist
* For https://github.com/mozilla-mobile/fenix/issues/4258 - Adds table for sprint / release schedule
* For https://github.com/mozilla-mobile/fenix/issues/4258 - Fixes nits
2019-08-14 12:01:35 -05:00
Tiger Oakes
07eda357ba
[fenix] Use global navigation action for browser fragment ( https://github.com/mozilla-mobile/fenix/pull/4691 )
2019-08-14 11:58:29 -05:00
isabelrios
61e400c2d8
[fenix] Fix UI Screenshot TabMenuTest ( https://github.com/mozilla-mobile/fenix/pull/4730 )
2019-08-14 11:57:36 -05:00
Colin Lee
4987c40d67
[fenix] For https://github.com/mozilla-mobile/fenix/issues/1667 : Screen reader can't reach other UI items when QAB expanded ( https://github.com/mozilla-mobile/fenix/pull/4695 )
2019-08-14 09:56:29 -07:00
Emily Kager
bf76cbe7e6
[fenix] No issue - Autoformatting ( https://github.com/mozilla-mobile/fenix/pull/4715 )
2019-08-14 09:40:46 -05:00
Sebastian Kaspari
c30700580c
[fenix] Closes https://github.com/mozilla-mobile/fenix/issues/4719 : Get rid of fragment-testing dependency and create fragments in StoreProviderTest manually. ( https://github.com/mozilla-mobile/fenix/pull/4722 )
2019-08-14 09:10:24 -05:00
Colin Lee
2de56210e2
[fenix] For https://github.com/mozilla-mobile/fenix/issues/4709 : Fix Bugzilla issue 1573549 ( https://github.com/mozilla-mobile/fenix/pull/4710 )
2019-08-13 22:16:23 -05:00
Sourabh
9c7caab6e3
[fenix] fix https://github.com/mozilla-mobile/fenix/issues/4633 : show toast only on first login ( https://github.com/mozilla-mobile/fenix/pull/4676 )
...
This is a very low-risk PR, which should not require a rebase to deal with the scope issue today in TaskCluster.
2019-08-13 16:28:34 -05:00
(´⌣`ʃƪ)
f292286006
[fenix] Fix https://github.com/mozilla-mobile/fenix/issues/4436 : hide onboarding before navigating to settings ( https://github.com/mozilla-mobile/fenix/pull/4675 )
...
* Fix https://github.com/mozilla-mobile/fenix/issues/4436 : hide onboarding before navigating to settings
* No issue: Rename emitAccountChanges to emitModeChanges
2019-08-13 15:49:42 -05:00